]> granicus.if.org Git - postgresql/log
postgresql
18 years agoMake SQL arrays support null elements. This commit fixes the core array
Tom Lane [Thu, 17 Nov 2005 22:14:56 +0000 (22:14 +0000)]
Make SQL arrays support null elements.  This commit fixes the core array
functionality, but I still need to make another pass looking at places
that incidentally use arrays (such as ACL manipulation) to make sure they
are null-safe.  Contrib needs work too.
I have not changed the behaviors that are still under discussion about
array comparison and what to do with lower bounds.

18 years agoDropRelFileNodeBuffers failed to fix the state of the lookup hash table
Tom Lane [Thu, 17 Nov 2005 17:42:02 +0000 (17:42 +0000)]
DropRelFileNodeBuffers failed to fix the state of the lookup hash table
that was added to localbuf.c in 8.1; therefore, applying it to a temp table
left corrupt lookup state in memory.  The only case where this had a
significant chance of causing problems was an ON COMMIT DELETE ROWS temp
table; the other possible paths left bogus state that was unlikely to
be used again.  Per report from Csaba Nagy.

18 years agoUpdate, add mention of user locking table before MERGE:
Bruce Momjian [Wed, 16 Nov 2005 18:45:09 +0000 (18:45 +0000)]
Update, add mention of user locking table before MERGE:

<   so duplicate checking can be easily performed.
>   so duplicate checking can be easily performed.  It is possible to
>   do it without a unique index if we require the user to LOCK the table
>   before the MERGE.

18 years agomake_restrictinfo() failed to attach the specified required_relids to
Tom Lane [Wed, 16 Nov 2005 17:08:03 +0000 (17:08 +0000)]
make_restrictinfo() failed to attach the specified required_relids to
its result when the clause was an OR clause.  Brain fade exposed by
example from Sebastian BÎck.

18 years agoAdd batch mode, make new libpq section:
Bruce Momjian [Wed, 16 Nov 2005 16:33:44 +0000 (16:33 +0000)]
Add batch mode, make new libpq section:

< * Add a libpq function to support Parse/DescribeStatement capability
< * Add PQescapeIdentifier() to libpq
< * Prevent PQfnumber() from lowercasing unquoted the column name
<
<   PQfnumber() should never have been doing lowercasing, but historically
<   it has so we need a way to prevent it
<
648a642,661
>
>
> libpq
>
>  o Add a function to support Parse/DescribeStatement capability
>  o Add PQescapeIdentifier()
>  o Prevent PQfnumber() from lowercasing unquoted the column name
>
>    PQfnumber() should never have been doing lowercasing, but
>    historically it has so we need a way to prevent it
>
>  o Allow query results to be automatically batched to the client
>
>    Currently, all query results are transfered to the libpq
>    client before libpq makes the results available to the
>    application.  This feature would allow the application to make
>    use of the first result rows while the rest are transfered, or
>    held on the server waiting for them to be requested by libpq.
>    One complexity is that a query like SELECT 1/col could error
>    out mid-way through the result set.

18 years agoFix comment on -v option
Tatsuo Ishii [Wed, 16 Nov 2005 13:13:08 +0000 (13:13 +0000)]
Fix comment on -v option

18 years agoProperly document return value of strpos().
Bruce Momjian [Wed, 16 Nov 2005 03:56:16 +0000 (03:56 +0000)]
Properly document return value of strpos().

18 years agoUpdate error message and documentation for fsync test.
Bruce Momjian [Wed, 16 Nov 2005 03:32:04 +0000 (03:32 +0000)]
Update error message and documentation for fsync test.

18 years agoHave test_fsync honor -f filename argument.
Bruce Momjian [Wed, 16 Nov 2005 01:31:07 +0000 (01:31 +0000)]
Have test_fsync honor -f filename argument.

18 years agoUpdate MERGE:
Bruce Momjian [Tue, 15 Nov 2005 23:08:24 +0000 (23:08 +0000)]
Update MERGE:

>
>   To implement this cleanly requires that the table have a unique index
>   so duplicate checking can be easily performed.
>

18 years agoAdd reminder that we should link to the documentation section for new
Bruce Momjian [Tue, 15 Nov 2005 22:16:03 +0000 (22:16 +0000)]
Add reminder that we should link to the documentation section for new
features.

18 years agoPrevent certain symbols that are used for both typedefs and variable
Bruce Momjian [Tue, 15 Nov 2005 14:45:10 +0000 (14:45 +0000)]
Prevent certain symbols that are used for both typedefs and variable
names from being added to pgindent's typedef list.  The existance of
them caused weird formatting in the date/type files, and in keywords.c.

Backpatch to 8.1.X.

18 years agoFix recent problems with BSD indent, including indenting past 80
Bruce Momjian [Tue, 15 Nov 2005 00:43:01 +0000 (00:43 +0000)]
Fix recent problems with BSD indent, including indenting past 80
columns, shifting comment to the right when more than 150 'else if'
clauses were used, and update typedefs for 8.1.X.

NetBSD patched updated, with documentation.

18 years agoRestore the former RestrictInfo field valid_everywhere (but invert the flag
Tom Lane [Mon, 14 Nov 2005 23:54:23 +0000 (23:54 +0000)]
Restore the former RestrictInfo field valid_everywhere (but invert the flag
sense and rename to "outerjoin_delayed" to more clearly reflect what it
means).  I had decided that it was redundant in 8.1, but the folly of this
is exposed by a bug report from Sebastian Böck.  The place where it's
needed is to prevent orindxpath.c from cherry-picking arms of an outer-join
OR clause to form a relation restriction that isn't actually legal to push
down to the relation scan level.  There may be some legal cases that this
forbids optimizing, but we'd need much closer analysis to determine it.

18 years agoTranslation typo fix
Alvaro Herrera [Mon, 14 Nov 2005 22:08:14 +0000 (22:08 +0000)]
Translation typo fix

18 years agoRe-run pgindent to fix breakage when exceeding 150 'else if' clauses.
Bruce Momjian [Mon, 14 Nov 2005 17:48:43 +0000 (17:48 +0000)]
Re-run pgindent to fix breakage when exceeding 150 'else if' clauses.

Cosmetic fix only.

18 years agoPrevent ExecInsert() and ExecUpdate() from scribbling on the result tuple
Tom Lane [Mon, 14 Nov 2005 17:42:55 +0000 (17:42 +0000)]
Prevent ExecInsert() and ExecUpdate() from scribbling on the result tuple
slot of the topmost plan node when a trigger returns a modified tuple.
These appear to be the only places where a plan node's caller did not
treat the result slot as read-only, which is an assumption that nodeUnique
makes as of 8.1.  Fixes trigger-vs-DISTINCT bug reported by Frank van Vugt.

18 years agoRemove usage of ArrayType->flags field, use pgsql's macros BITS_PER_BYTE instead
Teodor Sigaev [Mon, 14 Nov 2005 16:11:37 +0000 (16:11 +0000)]
Remove usage of ArrayType->flags field, use pgsql's macros BITS_PER_BYTE instead
of self-defined macros, add limit of Array  to gist__int_ops. BTW, intarray now
doesn't support NULLs in arrays.

18 years agoUse postgres-wide macros BITS_PER_BYTE instead self-definenig macros, also use it...
Teodor Sigaev [Mon, 14 Nov 2005 14:44:06 +0000 (14:44 +0000)]
Use postgres-wide macros BITS_PER_BYTE instead self-definenig macros, also use it for calculating bit length of TPQTGist

18 years agofix returning value
Teodor Sigaev [Mon, 14 Nov 2005 09:59:13 +0000 (09:59 +0000)]
fix returning value

18 years agoForce the second argument of SUBSTRING(foo FOR bar) to be int4, to avoid
Tom Lane [Sun, 13 Nov 2005 19:11:28 +0000 (19:11 +0000)]
Force the second argument of SUBSTRING(foo FOR bar) to be int4, to avoid
surprising results when it's some other numeric type.  This doesn't solve
the generic problem of surprising implicit casts to text, but it's a
low-impact way of making sure this particular case behaves sanely.
Per gripe from Harald Fuchs and subsequent discussion.

18 years agoRevert pgindent length back to 79 because we are going to fix the BSD
Bruce Momjian [Sun, 13 Nov 2005 02:38:49 +0000 (02:38 +0000)]
Revert pgindent length back to 79 because we are going to fix the BSD
indent bug.

18 years agoadd missing quote mark to ident_file sample line - per Hiroshi Saito
Andrew Dunstan [Thu, 10 Nov 2005 14:01:55 +0000 (14:01 +0000)]
add missing quote mark to ident_file sample line - per Hiroshi Saito

18 years agoWhen in transaction-aborted state, reject Bind message for portals containing
Tom Lane [Thu, 10 Nov 2005 00:31:34 +0000 (00:31 +0000)]
When in transaction-aborted state, reject Bind message for portals containing
anything but transaction-exiting commands (ROLLBACK etc).  We already rejected
Parse and Execute in such cases, so there seems little point in allowing Bind.
This prevents at least an Assert failure, and probably worse things, since
there's a lot of infrastructure that doesn't work when not in a live
transaction.  We can also simplify the Bind logic a bit by rejecting messages
with a nonzero number of parameters, instead of the former kluge to silently
substitute NULL for each parameter.  Per bug #2033 from Joel Stevenson.

18 years agoFix misspelling of 'listen_addresses', per Devrim.
Tom Lane [Wed, 9 Nov 2005 17:44:10 +0000 (17:44 +0000)]
Fix misspelling of 'listen_addresses', per Devrim.

18 years agoFix rwrite(ARRAY) on 64-bit boxes:
Teodor Sigaev [Wed, 9 Nov 2005 09:26:04 +0000 (09:26 +0000)]
Fix rwrite(ARRAY) on 64-bit boxes:

Instead of getting elements of array manually call deconstruct_array

18 years agoNew features for tsearch2:
Teodor Sigaev [Tue, 8 Nov 2005 17:08:46 +0000 (17:08 +0000)]
New features for tsearch2:
1 Comparison operation for tsquery
2 Btree index on tsquery
3 numnode(tsquery) - returns 'length' of tsquery
4 tsquery @ tsquery, tsquery ~ tsquery - contains, contained for tsquery.
  Note: They don't gurantee exact result, only MAY BE, so it
  useful only for speed up rewrite functions
5 GiST index support for @,~
6 rewrite():
        select rewrite(orig, what, to);
        select rewrite(ARRAY[orig, what, to]) from tsquery_table;
        select rewrite(orig, 'select what, to from tsquery_table;');
7 significantly improve cover algorithm

18 years agoLower pgident length to 77, document BSD indent bug.
Bruce Momjian [Mon, 7 Nov 2005 23:50:20 +0000 (23:50 +0000)]
Lower pgident length to 77, document BSD indent bug.

18 years agoChange maximum pgindent length from 79 to 78, per Tom.
Bruce Momjian [Mon, 7 Nov 2005 22:52:41 +0000 (22:52 +0000)]
Change maximum pgindent length from 79 to 78, per Tom.

18 years agoR-tree is dead ... long live GiST.
Tom Lane [Mon, 7 Nov 2005 17:36:47 +0000 (17:36 +0000)]
R-tree is dead ... long live GiST.

18 years agoTranslation updates forward-port to HEAD.
Alvaro Herrera [Mon, 7 Nov 2005 02:40:38 +0000 (02:40 +0000)]
Translation updates forward-port to HEAD.

18 years agoAdd simple sanity checks on newly-read pages to GiST, too.
Tom Lane [Sun, 6 Nov 2005 22:39:21 +0000 (22:39 +0000)]
Add simple sanity checks on newly-read pages to GiST, too.

18 years agoAdd defenses to btree and hash index AMs to do simple sanity checks
Tom Lane [Sun, 6 Nov 2005 19:29:01 +0000 (19:29 +0000)]
Add defenses to btree and hash index AMs to do simple sanity checks
on every index page they read; in particular to catch the case of an
all-zero page, which PageHeaderIsValid allows to pass.  It turns out
hash already had this idea, but it was just Assert()ing things rather
than doing a straight error check, and the Asserts were partially
redundant with PageHeaderIsValid anyway.  Per recent failure example
from Jim Nasby.  (gist still needs the same treatment.)

18 years agoClean up representation of SLRU page state. This is the cleaner fix
Tom Lane [Sat, 5 Nov 2005 21:19:47 +0000 (21:19 +0000)]
Clean up representation of SLRU page state.  This is the cleaner fix
for the SLRU race condition that I posted a few days ago, but we decided
not to use in 8.1 and older branches.

18 years agoBrand HEAD branch as 8.2devel.
Tom Lane [Sat, 5 Nov 2005 16:42:02 +0000 (16:42 +0000)]
Brand HEAD branch as 8.2devel.

19 years agoTag everything for 8.1.0 ... Finally, a relesae on scheduale!! REL8_1_0
PostgreSQL Daemon [Sat, 5 Nov 2005 04:01:57 +0000 (04:01 +0000)]
Tag everything for 8.1.0 ... Finally, a relesae on scheduale!!

19 years agoRepair an error introduced by log_line_prefix patch: it is not acceptable
Tom Lane [Sat, 5 Nov 2005 03:04:53 +0000 (03:04 +0000)]
Repair an error introduced by log_line_prefix patch: it is not acceptable
to assume that the string pointer passed to set_ps_display is good forever.
There's no need to anyway since ps_status.c itself saves the string, and
we already had an API (get_ps_display) to return it.
I believe this explains Jim Nasby's report of intermittent crashes in
elog.c when %i format code is in use in log_line_prefix.
While at it, repair a previously unnoticed problem: on some platforms such as
Darwin, the string returned by get_ps_display was blank-padded to the maximum
length, meaning that lock.c's attempt to append " waiting" to it never worked.

19 years agoAdd mention to update FAQ item on most recent release to RELEASE_CHANGES.
Bruce Momjian [Sat, 5 Nov 2005 01:38:44 +0000 (01:38 +0000)]
Add mention to update FAQ item on most recent release to RELEASE_CHANGES.

19 years agoUpdate FAQ for most recent release as 8.1.
Bruce Momjian [Sat, 5 Nov 2005 01:35:18 +0000 (01:35 +0000)]
Update FAQ for most recent release as 8.1.

19 years agoYet another supported-platforms update.
Tom Lane [Sat, 5 Nov 2005 00:04:04 +0000 (00:04 +0000)]
Yet another supported-platforms update.

19 years agoEditorial review for partitioning/constraint exclusion documentation.
Tom Lane [Fri, 4 Nov 2005 23:53:18 +0000 (23:53 +0000)]
Editorial review for partitioning/constraint exclusion documentation.

19 years agoImprove description of constraint_exclusion variable.
Tom Lane [Fri, 4 Nov 2005 23:50:30 +0000 (23:50 +0000)]
Improve description of constraint_exclusion variable.

19 years agoTranslation updates
Peter Eisentraut [Fri, 4 Nov 2005 23:31:12 +0000 (23:31 +0000)]
Translation updates

19 years agoSpellchecking run, final cleanups
Peter Eisentraut [Fri, 4 Nov 2005 23:14:02 +0000 (23:14 +0000)]
Spellchecking run, final cleanups

19 years agoUpdate release notes for 8.1.
Bruce Momjian [Fri, 4 Nov 2005 22:21:33 +0000 (22:21 +0000)]
Update release notes for 8.1.

19 years agoRemove a gratuitous string difference (does not affect translations).
Peter Eisentraut [Fri, 4 Nov 2005 22:19:04 +0000 (22:19 +0000)]
Remove a gratuitous string difference (does not affect translations).

19 years agoFix logical error in option description.
Peter Eisentraut [Fri, 4 Nov 2005 22:18:26 +0000 (22:18 +0000)]
Fix logical error in option description.

19 years agoEnsure that we only create one ConsoleCtrlHandler per psql process,
Tom Lane [Fri, 4 Nov 2005 18:35:40 +0000 (18:35 +0000)]
Ensure that we only create one ConsoleCtrlHandler per psql process,
so as to avoid performance issues and possible ultimate crash on long
psql scripts.  Per Merlin Moncure.

19 years agoWe haven't seen any agreement emerge as to what is causing AIX 5.3 ML3
Bruce Momjian [Fri, 4 Nov 2005 18:16:50 +0000 (18:16 +0000)]
We haven't seen any agreement emerge as to what is causing AIX 5.3 ML3
to fail to successfully build the release candidates.

However, a patch has emerged (thanks, Seneca!) that does allow it to
work, and which I'd expect to be portable (better still!).

We are still actively pursuing why it breaks, but supposing that still
remains outstanding, at least the following would allow AIX users to
better survive a build...

Chris Browne

19 years agoDisregard superuserness when checking to see if a role GRANT would
Tom Lane [Fri, 4 Nov 2005 17:25:15 +0000 (17:25 +0000)]
Disregard superuserness when checking to see if a role GRANT would
create circularity of role memberships.  This is a minimum-impact fix
for the problem reported by Florian Pflug.  I thought about removing
the superuser_arg test from is_member_of_role() altogether, as it seems
redundant for many of the callers --- but not all, and it's way too late
in the 8.1 cycle to be making large changes.  Perhaps reconsider this
later.

19 years agoUpdate supported-platforms list.
Tom Lane [Fri, 4 Nov 2005 16:15:20 +0000 (16:15 +0000)]
Update supported-platforms list.

19 years agoAvoid referring to a specific version of the SQL standard except where
Tom Lane [Fri, 4 Nov 2005 02:56:31 +0000 (02:56 +0000)]
Avoid referring to a specific version of the SQL standard except where
necessary, and be careful to refer to the right version where it is
useful to do so.  This partially reverts an ill-considered search and
replace from a few months ago.

19 years agoFix a couple of missed None -> DestNone in comments.
Tom Lane [Thu, 3 Nov 2005 21:35:57 +0000 (21:35 +0000)]
Fix a couple of missed None -> DestNone in comments.

19 years agoFix one overlooked ocurrence of "None" in EXEC_BACKEND block.
Alvaro Herrera [Thu, 3 Nov 2005 20:02:50 +0000 (20:02 +0000)]
Fix one overlooked ocurrence of "None" in EXEC_BACKEND block.

19 years agoFix incorrect header size macros
Teodor Sigaev [Thu, 3 Nov 2005 18:16:31 +0000 (18:16 +0000)]
Fix incorrect header size macros

19 years agoThinking further, it seems we had better also copy down resorigtbl/resorigcol
Tom Lane [Thu, 3 Nov 2005 17:45:29 +0000 (17:45 +0000)]
Thinking further, it seems we had better also copy down resorigtbl/resorigcol
to ensure that SubqueryScan elimination doesn't change the behavior of
reporting of original column sources.

19 years agoFix the recently-added code that eliminates unnecessary SubqueryScan nodes
Tom Lane [Thu, 3 Nov 2005 17:34:03 +0000 (17:34 +0000)]
Fix the recently-added code that eliminates unnecessary SubqueryScan nodes
from a finished plan tree.  We have to copy the output column names
(resname fields) from the SubqueryScan down to its child plan node;
else, if this is the topmost level of the plan, the wrong column names
will be delivered to the client.  Per bug #2017 reported by Jolly Chen.

19 years agoRename the members of CommandDest enum so they don't collide with other uses of
Alvaro Herrera [Thu, 3 Nov 2005 17:11:40 +0000 (17:11 +0000)]
Rename the members of CommandDest enum so they don't collide with other uses of
those names.  (Debug and None were pretty bad names anyway.)  I hope I catched
all uses of the names in comments too.

19 years agoTranslation updates.
Alvaro Herrera [Thu, 3 Nov 2005 17:00:54 +0000 (17:00 +0000)]
Translation updates.

19 years agopgcrypto documentation polishing from Marko Kreen, and a small amount
Tom Lane [Thu, 3 Nov 2005 02:54:07 +0000 (02:54 +0000)]
pgcrypto documentation polishing from Marko Kreen, and a small amount
of copy-editing from myself.

19 years agoSome minor improvements to the CE docs. Also fix a bit of SGML markup
Neil Conway [Thu, 3 Nov 2005 00:51:43 +0000 (00:51 +0000)]
Some minor improvements to the CE docs. Also fix a bit of SGML markup
elsewhere.

19 years agoFix longstanding race condition in transaction log management: there was a
Tom Lane [Thu, 3 Nov 2005 00:23:36 +0000 (00:23 +0000)]
Fix longstanding race condition in transaction log management: there was a
very narrow window in which SimpleLruReadPage or SimpleLruWritePage could
think that I/O was needed when it wasn't (and indeed the buffer had already
been assigned to another page).  This would result in an Assert failure if
Asserts were enabled, and probably in silent data corruption if not.
Reported independently by Jim Nasby and Robert Creager.

I intend a more extensive fix when 8.2 development starts, but this is a
reasonably low-impact patch for the existing branches.

19 years agoAdd Tomoaki Sato to pgbench changes in release notes.
Bruce Momjian [Wed, 2 Nov 2005 14:08:43 +0000 (14:08 +0000)]
Add Tomoaki Sato to pgbench changes in release notes.

19 years agoAdd some documentation for constraint exclusion and basic partitioning.
Neil Conway [Tue, 1 Nov 2005 23:19:05 +0000 (23:19 +0000)]
Add some documentation for constraint exclusion and basic partitioning.
From Simon Riggs; cleanup and editorialization by Neil Conway.

19 years agoMake an editorial pass over the reference pages.
Tom Lane [Tue, 1 Nov 2005 21:09:51 +0000 (21:09 +0000)]
Make an editorial pass over the reference pages.

19 years agoProvide a --no-locale option for pg_regress and a corresponding NOLOCALE=1
Andrew Dunstan [Tue, 1 Nov 2005 15:09:11 +0000 (15:09 +0000)]
Provide a --no-locale option for pg_regress and a corresponding NOLOCALE=1
setting for the regression makefile, allowing Windows users to force locale
settings since Windows does not get its locale from the environment.

Per Petr Jelinek.

19 years agoUpdate supported-platforms entry for Tru64.
Tom Lane [Mon, 31 Oct 2005 21:12:35 +0000 (21:12 +0000)]
Update supported-platforms entry for Tru64.

19 years agoMention in the docs that temporary/non-temp tables can not share
Bruce Momjian [Mon, 31 Oct 2005 18:13:52 +0000 (18:13 +0000)]
Mention in the docs that temporary/non-temp tables can not share
referential integrity relationships.

19 years agoAdd sanity check of query
Teodor Sigaev [Mon, 31 Oct 2005 13:47:09 +0000 (13:47 +0000)]
Add sanity check of query

19 years agoUpdate supported-platforms list.
Tom Lane [Sun, 30 Oct 2005 19:21:42 +0000 (19:21 +0000)]
Update supported-platforms list.

19 years agotag it for rc1 REL8_1_0RC1
PostgreSQL Daemon [Sun, 30 Oct 2005 05:06:03 +0000 (05:06 +0000)]
tag it for rc1

19 years agoFix psql ref typo.
Bruce Momjian [Sun, 30 Oct 2005 03:01:49 +0000 (03:01 +0000)]
Fix psql ref typo.

Andreas Seltenreich

19 years agoFix some allocation size calculation errors that would cause pgbench
Tom Lane [Sat, 29 Oct 2005 19:38:07 +0000 (19:38 +0000)]
Fix some allocation size calculation errors that would cause pgbench
to fail with large test scripts.

19 years agoUpdate a couple of obsolete comments.
Tom Lane [Sat, 29 Oct 2005 18:39:17 +0000 (18:39 +0000)]
Update a couple of obsolete comments.

19 years agoTranslation updates
Peter Eisentraut [Sat, 29 Oct 2005 00:41:37 +0000 (00:41 +0000)]
Translation updates

19 years agoMessage corrections
Peter Eisentraut [Sat, 29 Oct 2005 00:31:52 +0000 (00:31 +0000)]
Message corrections

19 years agoUpdate supported-platforms list.
Tom Lane [Fri, 28 Oct 2005 20:01:40 +0000 (20:01 +0000)]
Update supported-platforms list.

19 years agoFix broken markup.
Tom Lane [Fri, 28 Oct 2005 20:00:03 +0000 (20:00 +0000)]
Fix broken markup.

19 years agoReorder code so that we don't have to hold a critical section while
Tom Lane [Fri, 28 Oct 2005 19:00:19 +0000 (19:00 +0000)]
Reorder code so that we don't have to hold a critical section while
reserving SLRU space for a new MultiXact.  The original coding would have
treated out-of-disk-space as a PANIC condition, which is unnecessary.

19 years agoClean up AIX build to avoid 'duplicate symbol' warnings, by moving use
Tom Lane [Fri, 28 Oct 2005 17:32:22 +0000 (17:32 +0000)]
Clean up AIX build to avoid 'duplicate symbol' warnings, by moving use
of postgres.imp file into BE_DLLLIBS macro.  This makes the AIX build
work more like the Windows and Darwin builds, which have similar requirements
to mention a backend library when linking shared libraries that will be
dynamically loaded into the backend.

19 years agoFix race condition in multixact code: it's possible to try to read a
Tom Lane [Fri, 28 Oct 2005 17:27:29 +0000 (17:27 +0000)]
Fix race condition in multixact code: it's possible to try to read a
multixact's starting offset before the offset has been stored into the
SLRU file.  A simple fix would be to hold the MultiXactGenLock until the
offset has been stored, but that looks like a big concurrency hit.  Instead
rely on knowledge that unset offsets will be zero, and loop when we see
a zero.  This requires a little extra hacking to ensure that zero is never
a valid value for the offset.  Problem reported by Matteo Beccati, fix
ideas from Martijn van Oosterhout, Alvaro Herrera, and Tom Lane.

19 years ago1 Fix problem with lost precision in rank with OR-ed lexemes
Teodor Sigaev [Fri, 28 Oct 2005 13:05:06 +0000 (13:05 +0000)]
1 Fix problem with lost precision in rank with OR-ed lexemes
2 Allow tsquery_in to input void tsquery: resolve dump/restore problem with tsquery

19 years agoRemove mention that \x doesn't affect backslash commands.
Bruce Momjian [Fri, 28 Oct 2005 02:39:07 +0000 (02:39 +0000)]
Remove mention that \x doesn't affect backslash commands.

19 years agoAdd an ifneq to avoid make warning on AIX --- there is a separate rule
Tom Lane [Thu, 27 Oct 2005 20:45:29 +0000 (20:45 +0000)]
Add an ifneq to avoid make warning on AIX --- there is a separate rule
for postgres: on line 86, and line 43 shouldn't be used.  Noted while
looking at kookaburra buildfarm results.

19 years agoTweak buffer manager so that 'internal' accesses to a buffer do not
Tom Lane [Thu, 27 Oct 2005 17:07:58 +0000 (17:07 +0000)]
Tweak buffer manager so that 'internal' accesses to a buffer do not
advance its usage_count.  This includes writes of dirty buffers triggered
by bgwriter, checkpoint, or FlushRelationBuffers, as well as various
corner cases that really ought not count as accesses to the page.
Should make for some marginal improvement in the quality of our decisions
about when to recycle buffers.  Per suggestion from ITAGAKI Takahiro.

19 years agoUpdate:
Bruce Momjian [Thu, 27 Oct 2005 14:16:05 +0000 (14:16 +0000)]
Update:

<  o Allow ALTER TABLE RENAME CONSTRAINT
>  o Add ALTER TABLE RENAME CONSTRAINT, update index name also

19 years agoAdd:
Bruce Momjian [Thu, 27 Oct 2005 14:07:29 +0000 (14:07 +0000)]
Add:

>  o Have ALTER INDEX update the name of a constraint using that index
>  o Allow ALTER TABLE RENAME CONSTRAINT

19 years agoAdd mention that .pgpass localhost matches tcp and unix domain sockets.
Bruce Momjian [Thu, 27 Oct 2005 13:53:41 +0000 (13:53 +0000)]
Add mention that .pgpass localhost matches tcp and unix domain sockets.

19 years agoAdd mention of errfinish.
Bruce Momjian [Thu, 27 Oct 2005 13:48:14 +0000 (13:48 +0000)]
Add mention of errfinish.

19 years agoDisable expanded mode only for \d tablename, not for all backslash
Bruce Momjian [Thu, 27 Oct 2005 13:34:47 +0000 (13:34 +0000)]
Disable expanded mode only for \d tablename, not for all backslash
commands.  Per complaint that \df+ is clearer in expanded mode.

19 years agoAdd comment documenting actual failure case of using
Bruce Momjian [Thu, 27 Oct 2005 02:45:22 +0000 (02:45 +0000)]
Add comment documenting actual failure case of using
interval_justify_hours in timestamp subtraction.  TODO already has text
description.

19 years agoAdd items from Tom:
Bruce Momjian [Thu, 27 Oct 2005 02:33:31 +0000 (02:33 +0000)]
Add items from Tom:

<  o Add a GUC variable to allow output of interval values in ISO8601
<    format
212a211,223
>  o Add a GUC variable to allow output of interval values in ISO8601
>    format
>  o Improve timestamptz subtraction to be DST-aware
>
>    Currently, subtracting one date from another that crosses a
>    daylight savings time adjustment can return '1 day 1 hour', but
>    adding that back to the first date returns a time one hour in
>    the future.  This is caused by the adjustment of '25 hours' to
>    '1 day 1 hour', and '1 day' is the same time the next day, even
>    if daylight savings adjustments are involved.
>
>  o Fix interval display to support values exceeding 2^31 hours
>  o Add overflow checking to timestamp and interval arithmetic

19 years agoAdd info about using rsync to make base backups. Per report from
Tom Lane [Wed, 26 Oct 2005 20:42:35 +0000 (20:42 +0000)]
Add info about using rsync to make base backups.  Per report from
Jeff Frost, it may be necessary to ignore specific exit codes.

19 years agoAdjust parser so that POSTQUEL-style implicit RTEs are stored with
Tom Lane [Wed, 26 Oct 2005 19:21:55 +0000 (19:21 +0000)]
Adjust parser so that POSTQUEL-style implicit RTEs are stored with
inFromCl true, meaning that they will list out as explicit RTEs if they
are in a view or rule.  Update comments about inFromCl to reflect the way
it's now actually used.  Per recent discussion.

19 years agoRename config section headings.
Bruce Momjian [Wed, 26 Oct 2005 12:55:07 +0000 (12:55 +0000)]
Rename config section headings.

Simon Riggs

19 years agoFix longstanding bug that would sometimes let the planner generate a bad plan
Tom Lane [Tue, 25 Oct 2005 20:30:30 +0000 (20:30 +0000)]
Fix longstanding bug that would sometimes let the planner generate a bad plan
for an outer join; symptom is bogus error "RIGHT JOIN is only supported with
merge-joinable join conditions".  Problem was that select_mergejoin_clauses
did its tests in the wrong order.  We need to force left join not right join
for a merge join when there are non-mergeable join clauses; but the test for
this only accounted for mergejoinability of the clause operator, and not
whether the left and right Vars were of the proper relations.  Per report
from Jean-Pierre Pelletier.

19 years agoAdd:
Bruce Momjian [Tue, 25 Oct 2005 18:50:56 +0000 (18:50 +0000)]
Add:

>
>  o Add auto-expanded mode so expanded output is used if the row
>    length is wider than the screen width.
>
>    Consider using auto-expanded mode for backslash commands like \df+.

19 years agoConvert explanation of interval change into something resembling grammatical
Tom Lane [Tue, 25 Oct 2005 17:54:30 +0000 (17:54 +0000)]
Convert explanation of interval change into something resembling grammatical
English, and fix the incorrect example.

19 years agoRemove justify_hours call from interval_mul and interval_div, and make
Tom Lane [Tue, 25 Oct 2005 17:13:07 +0000 (17:13 +0000)]
Remove justify_hours call from interval_mul and interval_div, and make
some small stylistic improvements in these functions.  Also fix several
places where TMODULO() was being used with wrong-sized quotient argument,
creating a risk of overflow --- interval2tm was actually capable of going
into an infinite loop because of this.

19 years agoSmall grammar correction.
Tom Lane [Tue, 25 Oct 2005 15:47:51 +0000 (15:47 +0000)]
Small grammar correction.