]>
granicus.if.org Git - graphviz/log
Magnus Jacobsson [Thu, 18 Jun 2020 11:08:04 +0000 (13:08 +0200)]
Make CMake get Graphviz version from autogen.sh by parsing it
This will make autotools and CMake builds have a single source of
truth for the Graphviz version.
First, the major, minor and patch versions are retrieved. If the patch
version is "$GRAPHVIZ_VERSION_DATE", the patch version is set to the
committer date of the latest commit. This effectively repeals part of
the intention of
266ff5ee80b2d91231907e90ec650154f5225aa5 : "Don't
encode build date stamp in it to be able to create reproducable
builds".
Magnus Jacobsson [Mon, 29 Jun 2020 04:24:49 +0000 (04:24 +0000)]
Merge branch 'gitlab-ci-windows' into 'master'
Windows builds in the Gitlab CI/CD pipeline
See merge request graphviz/graphviz!1438
Magnus Jacobsson [Thu, 25 Jun 2020 17:27:21 +0000 (19:27 +0200)]
Make Windows binaries contain version and platform in filename
Magnus Jacobsson [Thu, 25 Jun 2020 10:32:34 +0000 (12:32 +0200)]
Remove Appveyor stuff from DEVELOPERS.md
Magnus Jacobsson [Thu, 25 Jun 2020 10:18:26 +0000 (12:18 +0200)]
Fix linting errors in DEVELOPERS.md
Magnus Jacobsson [Wed, 24 Jun 2020 19:30:17 +0000 (21:30 +0200)]
Don't show progress from choco installs
Magnus Jacobsson [Mon, 22 Jun 2020 14:50:41 +0000 (16:50 +0200)]
Add deploy of Windows binaries to www2.graphviz.org
Final commit that resolves
https://gitlab.com/graphviz/graphviz/-/issues/1713.
Magnus Jacobsson [Mon, 22 Jun 2020 13:56:47 +0000 (15:56 +0200)]
Convert lab_gamut data to plain array (was array of struct)
Magnus Jacobsson [Mon, 22 Jun 2020 13:32:12 +0000 (15:32 +0200)]
Disable code analysis for lab_gamut
Magnus Jacobsson [Tue, 16 Jun 2020 21:02:44 +0000 (23:02 +0200)]
Add Windows build jobs to GitLab pipeline
Magnus Jacobsson [Mon, 15 Jun 2020 14:23:43 +0000 (16:23 +0200)]
Retarget to Visual Studio 2019 and toolset v142
Matthew Fernandez [Sat, 27 Jun 2020 00:48:06 +0000 (00:48 +0000)]
Merge branch '
e467ae7f -137b-4133-a0f7-
868171fc13db ' into 'master'
some lib/gvc simplification
See merge request graphviz/graphviz!1435
Matthew Fernandez [Sat, 27 Jun 2020 00:02:24 +0000 (00:02 +0000)]
Merge branch '
dac2636e -2144-4c57-8e9c-
33fc072b6642 ' into 'master'
remove legacy lib/agraph
Closes #1549
See merge request graphviz/graphviz!1434
Matthew Fernandez [Fri, 26 Jun 2020 00:52:24 +0000 (17:52 -0700)]
Merge branch 'master' of ssh://gitlab.com/graphviz/graphviz into
0B0BFA8E -A762-45A4-8F56-
030AD90FA42E
Matthew Fernandez [Fri, 26 Jun 2020 00:07:30 +0000 (00:07 +0000)]
Merge branch '
349F18B3 -F9F4-487E-BED4-
E534CF4FCF59 ' into 'master'
lib/ast cleanup
See merge request graphviz/graphviz!1433
Matthew Fernandez [Tue, 23 Jun 2020 13:44:33 +0000 (13:44 +0000)]
Merge branch '
F2AA1D9F -EB82-4EB5-8B26-
C5765A343AE9 ' into 'master'
exit on allocation failure in lib/common/memory.c wrappers (attempt 2)
See merge request graphviz/graphviz!1436
Matthew Fernandez [Tue, 16 Jun 2020 01:04:42 +0000 (18:04 -0700)]
swap malloc(n*m) pattern for calloc(n,m)
This avoids some potential integer overflows.
Matthew Fernandez [Tue, 16 Jun 2020 00:57:12 +0000 (17:57 -0700)]
remove some now-redundant error handling from a call to N_NEW
The N_NEW wrapper now exits on allocation failure, rendering this code path
redundant.
Matthew Fernandez [Tue, 16 Jun 2020 00:05:21 +0000 (17:05 -0700)]
remove some now-redundant error handling following a call to NEW()
Allocation failures in NEW() now cause an error message and exit, so this code
path was redundant.
Matthew Fernandez [Mon, 15 Jun 2020 23:23:24 +0000 (16:23 -0700)]
remove allocation failure check in setPrefix
The function being called here, gmalloc, now exits on allocation failure. None
of setPrefix's callers can tolerate failure anyway, so this error handling seems
to have been incomplete previously.
Matthew Fernandez [Tue, 2 Jun 2020 03:44:34 +0000 (20:44 -0700)]
use calloc instead of malloc;memset in zmalloc()
This is more efficient for larger allocations, where the allocator can just
provide a zeroed page from the operating system.
Matthew Fernandez [Tue, 2 Jun 2020 03:48:54 +0000 (20:48 -0700)]
also provide a calloc wrapper in lib/common
Matthew Fernandez [Tue, 2 Jun 2020 03:41:26 +0000 (20:41 -0700)]
remove commented out gmalloc variants
Matthew Fernandez [Tue, 2 Jun 2020 03:27:18 +0000 (20:27 -0700)]
exit on failure of any of the lib/common malloc wrappers
Previously, when these wrappers exhausted memory they would return a null
pointer leading to follow on memory corruption and debugging confusion. It seems
simpler to just stop when we run out of memory as we have no reasonable recovery
path at this time.
Matthew Fernandez [Tue, 16 Jun 2020 00:55:46 +0000 (17:55 -0700)]
refactor a RALLOC call that can tolerate failure to realloc
We are about to make the RALLOC wrapper exit on allocation failure, so this
preserves the semantics of this call which handles allocation failure locally.
Matthew Fernandez [Tue, 16 Jun 2020 00:06:27 +0000 (17:06 -0700)]
refactor calls to NEW that can tolerate failure into calloc
We are about to make the NEW wrapper exit on allocation failure, so this
preserves the existing semantics of allowing these calls to handle allocation
failure locally.
Matthew Fernandez [Mon, 15 Jun 2020 23:43:30 +0000 (16:43 -0700)]
refactor any N_GNEW calls that can tolerate allocation failure to calloc
We are about to change the N_GNEW wrapper to exit on failure, so this preserves
the semantics of allowing these few locations to handle allocation failure
locally.
Matthew Fernandez [Mon, 15 Jun 2020 23:16:36 +0000 (16:16 -0700)]
refactor a GNEW call that can tolerate failure into a direct malloc
We are about to make the GNEW wrapper exit on allocation failure, so this
preserves the existing semantics of allocation failure being non-fatal to this
call. This is the only GNEW call I can see that can tolerate allocation failure.
Matthew Fernandez [Tue, 16 Jun 2020 01:05:23 +0000 (18:05 -0700)]
remove one unused N_NEW wrapper
Matthew Fernandez [Tue, 16 Jun 2020 00:02:00 +0000 (17:02 -0700)]
remove incorrect commented out use of NEW()
This macro takes a type as its argument, not a size. This call would have
resulted in an incorrect allocation of sizeof(size_t) bytes.
Matthew Fernandez [Mon, 22 Jun 2020 14:58:52 +0000 (07:58 -0700)]
Revert "Merge branch 'master' of ssh://gitlab.com/graphviz/graphviz into
7ca60983 -b10d-4afe-88d5-
d275587aafb9 "
This reverts commit
c9941ccf24cf19e6ac73ee1f6407304949acaa85 , reversing
changes made to
af4fb9c4039b2d1aecc303ff2b6355b933397c57 . CI failed on Windows.
Matthew Fernandez [Mon, 22 Jun 2020 14:31:16 +0000 (07:31 -0700)]
Merge branch 'master' of ssh://gitlab.com/graphviz/graphviz into
7ca60983 -b10d-4afe-88d5-
d275587aafb9
Magnus Jacobsson [Sun, 21 Jun 2020 08:24:14 +0000 (08:24 +0000)]
Merge branch 'fix-sh-syntax-error-in-debian-rules' into 'master'
Fix "Python language bindings library for Ubuntu does not contain any Python code or binaries"
Closes #1737 and #1735
See merge request graphviz/graphviz!1426
Matthew Fernandez [Sat, 20 Jun 2020 20:25:45 +0000 (13:25 -0700)]
remove a level of pointer indirection and add a const in gvplugin_graph
Matthew Fernandez [Sat, 20 Jun 2020 20:20:32 +0000 (13:20 -0700)]
remove some pointer indirection and add a const in gvPluginList
Matthew Fernandez [Sat, 20 Jun 2020 20:17:24 +0000 (13:17 -0700)]
remove unnecessary pointer indirection and add const in gvplugin_list
Matthew Fernandez [Sat, 20 Jun 2020 20:12:21 +0000 (13:12 -0700)]
emove an unnecessary level of pointer indirection in gvplugin_load
Matthew Fernandez [Sat, 20 Jun 2020 20:03:17 +0000 (13:03 -0700)]
remove an unnecessary level of pointer indirection in gvplugin_activate
Matthew Fernandez [Sat, 20 Jun 2020 20:00:29 +0000 (13:00 -0700)]
update #include path in demo C code
These headers are now installed under graphviz/ within the include directory.
Matthew Fernandez [Sat, 20 Jun 2020 17:24:42 +0000 (10:24 -0700)]
remove lib/agraph
This was previously deprecated in favor of lib/cgraph. Closes #1549.
Matthew Fernandez [Sat, 20 Jun 2020 17:22:47 +0000 (10:22 -0700)]
update some legacy comments, libagraph->libcgraph
Matthew Fernandez [Sat, 20 Jun 2020 17:22:35 +0000 (10:22 -0700)]
remove a legacy reference to libagraph
Matthew Fernandez [Sat, 20 Jun 2020 17:21:25 +0000 (10:21 -0700)]
remove libgraph, libagraph references in gxl2gv's manpage
The manpages for libgraph and libagraph are not shipped to end users.
Matthew Fernandez [Sat, 20 Jun 2020 17:19:57 +0000 (10:19 -0700)]
remove a comment reference to legacy libgraph, libagraph
Matthew Fernandez [Sat, 20 Jun 2020 16:46:59 +0000 (09:46 -0700)]
Merge branch 'master' of ssh://gitlab.com/graphviz/graphviz into
ab44ecec -2c4c-4dc9-a57b-
5e4cba52e56c
Matthew Fernandez [Sat, 20 Jun 2020 01:58:21 +0000 (18:58 -0700)]
remove unused align.h
Matthew Fernandez [Sat, 20 Jun 2020 02:00:21 +0000 (19:00 -0700)]
remove unused #includes of align.h
Matthew Fernandez [Sat, 6 Jun 2020 00:10:09 +0000 (17:10 -0700)]
remove unused strsubmatch function
This also removes two compiler warnings.
Matthew Fernandez [Sat, 6 Jun 2020 00:08:50 +0000 (17:08 -0700)]
remove unused pathinclude function
This also removes a compiler warning.
Matthew Fernandez [Sat, 6 Jun 2020 00:07:17 +0000 (17:07 -0700)]
remove unused fmtnesq function
This also removes a compiler warning.
Matthew Fernandez [Fri, 19 Jun 2020 00:30:30 +0000 (17:30 -0700)]
remove lab_gamut manpage
The header this manpage was describing was not installed for users.
Matthew Fernandez [Fri, 19 Jun 2020 00:14:54 +0000 (17:14 -0700)]
stop shipping a PDF of the lab_gamut manpage
The header for this library was not being installed and we do not want users
directly accessing this data, so the PDF documentation was not useful to them.
Matthew Fernandez [Fri, 19 Jun 2020 00:12:08 +0000 (17:12 -0700)]
remove commented out line
Matthew Fernandez [Sat, 20 Jun 2020 00:27:50 +0000 (00:27 +0000)]
Merge branch '
461036BD -675E-4AA6-85E2-
4381BC03CC99 ' into 'master'
fix building of blank PDFs for manpages
Closes #1734
See merge request graphviz/graphviz!1428
Matthew Fernandez [Tue, 16 Jun 2020 01:04:42 +0000 (18:04 -0700)]
swap malloc(n*m) pattern for calloc(n,m)
This avoids some potential integer overflows.
Matthew Fernandez [Tue, 16 Jun 2020 00:57:12 +0000 (17:57 -0700)]
remove some now-redundant error handling from a call to N_NEW
The N_NEW wrapper now exits on allocation failure, rendering this code path
redundant.
Matthew Fernandez [Tue, 16 Jun 2020 00:05:21 +0000 (17:05 -0700)]
remove some now-redundant error handling following a call to NEW()
Allocation failures in NEW() now cause an error message and exit, so this code
path was redundant.
Matthew Fernandez [Mon, 15 Jun 2020 23:23:24 +0000 (16:23 -0700)]
remove allocation failure check in setPrefix
The function being called here, gmalloc, now exits on allocation failure. None
of setPrefix's callers can tolerate failure anyway, so this error handling seems
to have been incomplete previously.
Matthew Fernandez [Tue, 2 Jun 2020 03:44:34 +0000 (20:44 -0700)]
use calloc instead of malloc;memset in zmalloc()
This is more efficient for larger allocations, where the allocator can just
provide a zeroed page from the operating system.
Matthew Fernandez [Tue, 2 Jun 2020 03:48:54 +0000 (20:48 -0700)]
also provide a calloc wrapper in lib/common
Matthew Fernandez [Tue, 2 Jun 2020 03:41:26 +0000 (20:41 -0700)]
remove commented out gmalloc variants
Matthew Fernandez [Tue, 2 Jun 2020 03:27:18 +0000 (20:27 -0700)]
exit on failure of any of the lib/common malloc wrappers
Previously, when these wrappers exhausted memory they would return a null
pointer leading to follow on memory corruption and debugging confusion. It seems
simpler to just stop when we run out of memory as we have no reasonable recovery
path at this time.
Matthew Fernandez [Tue, 16 Jun 2020 00:55:46 +0000 (17:55 -0700)]
refactor a RALLOC call that can tolerate failure to realloc
We are about to make the RALLOC wrapper exit on allocation failure, so this
preserves the semantics of this call which handles allocation failure locally.
Matthew Fernandez [Tue, 16 Jun 2020 00:06:27 +0000 (17:06 -0700)]
refactor calls to NEW that can tolerate failure into calloc
We are about to make the NEW wrapper exit on allocation failure, so this
preserves the existing semantics of allowing these calls to handle allocation
failure locally.
Matthew Fernandez [Mon, 15 Jun 2020 23:43:30 +0000 (16:43 -0700)]
refactor any N_GNEW calls that can tolerate allocation failure to calloc
We are about to change the N_GNEW wrapper to exit on failure, so this preserves
the semantics of allowing these few locations to handle allocation failure
locally.
Matthew Fernandez [Mon, 15 Jun 2020 23:16:36 +0000 (16:16 -0700)]
refactor a GNEW call that can tolerate failure into a direct malloc
We are about to make the GNEW wrapper exit on allocation failure, so this
preserves the existing semantics of allocation failure being non-fatal to this
call. This is the only GNEW call I can see that can tolerate allocation failure.
Matthew Fernandez [Tue, 16 Jun 2020 01:05:23 +0000 (18:05 -0700)]
remove one unused N_NEW wrapper
Matthew Fernandez [Tue, 16 Jun 2020 00:25:18 +0000 (00:25 +0000)]
Merge branch '
7fce6ce6 -df5b-4bc3-938e-
28db4c30689a ' into 'master'
remove unused agutil
See merge request graphviz/graphviz!1425
Matthew Fernandez [Tue, 16 Jun 2020 00:02:00 +0000 (17:02 -0700)]
remove incorrect commented out use of NEW()
This macro takes a type as its argument, not a size. This call would have
resulted in an incorrect allocation of sizeof(size_t) bytes.
Matthew Fernandez [Mon, 15 Jun 2020 13:59:55 +0000 (06:59 -0700)]
Merge branch 'master' of ssh://gitlab.com/graphviz/graphviz into
c7194847 -d161-451c-9644-
72a4c19f8a1b
Magnus Jacobsson [Mon, 15 Jun 2020 11:54:51 +0000 (13:54 +0200)]
Update CHANGELOG.md
Magnus Jacobsson [Tue, 9 Jun 2020 22:35:29 +0000 (00:35 +0200)]
Fix sh syntax error in debian/rules
Fixes https://gitlab.com/graphviz/graphviz/-/issues/1735 (and fixes https://gitlab.com/graphviz/graphviz/-/issues/1737)).
The error message was: "/bin/sh: 1: Syntax error: "&" unexpected".
The |& syntax is only valid for bash, not for sh.
This was introduced in
b861a44f39521be6c5c81f0d7aa39bdedae6be82 .
Also fixed install of libgv-python for multiple python versions which
was masked by this problem.
Magnus Jacobsson [Mon, 15 Jun 2020 11:49:11 +0000 (11:49 +0000)]
Merge branch 'generate-configuration-table' into 'master'
Generate configuration table
See merge request graphviz/graphviz!1423
Magnus Jacobsson [Mon, 15 Jun 2020 10:49:19 +0000 (10:49 +0000)]
Merge branch 'add-developers-guide' into 'master'
Add DEVELOPERS.md with release instructions
See merge request graphviz/graphviz!1401
Magnus Jacobsson [Mon, 15 Jun 2020 09:49:33 +0000 (09:49 +0000)]
Merge branch 'convert-changelog-to-markdown' into 'master'
Convert changelog to markdown
See merge request graphviz/graphviz!1394
Mark Hansen [Mon, 15 Jun 2020 00:49:35 +0000 (00:49 +0000)]
Merge branch '
561bf79c -b7dd-4219-8c72-
e64b33dc5472 ' into 'master'
deallocate memory before exiting mkdefs.c
Closes #1741
See merge request graphviz/graphviz!1430
Matthew Fernandez [Sun, 14 Jun 2020 21:30:14 +0000 (21:30 +0000)]
Merge branch '
4d767af9 -1ea9-455a-b8bf-
c7de2c0f8aed ' into 'master'
remove some compiler warnings
See merge request graphviz/graphviz!1427
Matthew Fernandez [Sun, 14 Jun 2020 21:22:18 +0000 (14:22 -0700)]
deallocate memory before exiting mkdefs.c
The code in mkdef.c gets compiled and executed during Graphviz compilation. When
building with Address Sanitizer enabled, instrumentation is also applied to this
utility during compilation. Usually this is not a problem, but when configuring
ASan to exit with an error on leak detection it would cause the build step that
runs mkdefs to erroneously fail. We now explicitly clean up before exiting
mkdefs, making ASan happy in all configurations. Closes #1741.
Matthew Fernandez [Sun, 14 Jun 2020 14:58:44 +0000 (07:58 -0700)]
remove legacy lib/graph
This was superseded by lib/agraph, which was in turn superseded by lib/cgraph.
Related to #1549.
Matthew Fernandez [Sun, 14 Jun 2020 14:53:32 +0000 (07:53 -0700)]
remove unused include reference to lib/graph
The only possible lib/graph header imported by any of the tools is agxbuf.h, but
this is shadowed by the same named header in lib/cgraph. Having lib/graph in the
list of include directories here was a little dangerous as reordering would have
caused the tools to pick up lib/graph's copy. Furthermore as we are not
currently building lib/graph, this likely would have caused link failures.
Related to #1549.
Matthew Fernandez [Sat, 13 Jun 2020 22:56:43 +0000 (15:56 -0700)]
unfold groff|ps2pdf build steps into separate recipes
This way a Groff failure will cause a build failure, rather than failing
silently.
Matthew Fernandez [Sat, 13 Jun 2020 22:22:11 +0000 (15:22 -0700)]
fix incorrect makefile target for prune manpage PDF
Matthew Fernandez [Sat, 13 Jun 2020 21:51:24 +0000 (14:51 -0700)]
remove some further suppression of Groff errors in Makefiles
Matthew Fernandez [Sat, 13 Jun 2020 21:21:30 +0000 (14:21 -0700)]
fix empty content in man page PDFs
Commit
67a4546f95ae463db7cc3e6270d7fb32a848de7c inadvertently removed spaces in
this makefile causing the Groff commands to silently fail. Fixes #1734.
Matthew Fernandez [Sat, 6 Jun 2020 01:38:09 +0000 (18:38 -0700)]
mark some static functions as such
This removes 92 -Wmissing-prototypes warnings on GCC 8.3.
This reapplies and corrects commit
b25836334408f719380547942a360a4729d3060f
which was backed out because it caused build failures on Windows.
Matthew Fernandez [Sat, 6 Jun 2020 01:15:55 +0000 (18:15 -0700)]
remove internal prototype for unused function printvis
This reapplies commit
ea510836eb7224517f843c1f1189cbc5a9f34733 which was backed
out due to a CI failure.
Matthew Fernandez [Sat, 6 Jun 2020 01:01:11 +0000 (18:01 -0700)]
more precise definition of vec_new
Unfortunately a definition/declaration with no parameters in older C is
ambiguous. Explicitly saying 'void' tells the compiler this takes no arguments.
This silences a -Wstrict-prototypes warning on GCC 8.3.
This reapplies commit
31dbec0dbb2aa17535faf9093b15b26207497056 which was backed
out due to a CI failure.
Magnus Jacobsson [Sun, 7 Jun 2020 18:34:14 +0000 (20:34 +0200)]
Add generation of compile configuration table to CI
New meta-data job added to test stage
Magnus Jacobsson [Sun, 7 Jun 2020 16:54:30 +0000 (18:54 +0200)]
Add coloring options
Magnus Jacobsson [Sun, 7 Jun 2020 16:05:39 +0000 (18:05 +0200)]
Add --short option
Magnus Jacobsson [Sun, 7 Jun 2020 15:47:15 +0000 (17:47 +0200)]
Add HTML output format
Magnus Jacobsson [Sun, 7 Jun 2020 14:38:20 +0000 (16:38 +0200)]
Add JSON output
Magnus Jacobsson [Sun, 7 Jun 2020 14:05:58 +0000 (16:05 +0200)]
Add ci/generate-configuration-table.py
Magnus Jacobsson [Sun, 7 Jun 2020 14:04:16 +0000 (16:04 +0200)]
Add generation of configure.log to build.sh
Magnus Jacobsson [Sun, 7 Jun 2020 14:03:23 +0000 (16:03 +0200)]
Ensure immediate exit on failure in build.sh
Magnus Jacobsson [Sun, 7 Jun 2020 14:01:49 +0000 (16:01 +0200)]
Change to use bash in build.sh
Magnus Jacobsson [Sun, 7 Jun 2020 14:01:24 +0000 (16:01 +0200)]
Add ci/extract-configure-log.sh
Matthew Fernandez [Sat, 13 Jun 2020 02:30:19 +0000 (02:30 +0000)]
Revert "Merge branch '
13EFFB86 -601F-4F93-9FCF-
BB3F6E981794 ' into 'master'"
This reverts merge request !1402
Matthew Fernandez [Sat, 13 Jun 2020 02:00:24 +0000 (02:00 +0000)]
Merge branch '
13EFFB86 -601F-4F93-9FCF-
BB3F6E981794 ' into 'master'
remove some compiler warnings
See merge request graphviz/graphviz!1402
Matthew Fernandez [Fri, 12 Jun 2020 14:57:43 +0000 (14:57 +0000)]
Merge branch '
A48431E1 -2EF5-44DB-8F6B-
7B09F2F7C0E6 ' into 'master'
remove some unused parts of libsfio
See merge request graphviz/graphviz!1403