]> granicus.if.org Git - icu/log
icu
4 years agoMerge pull request #40 from younies/units_router_younies
Younies Mahmoud [Fri, 8 May 2020 15:46:44 +0000 (17:46 +0200)]
Merge pull request #40 from younies/units_router_younies

Merge sffc/units-staging

4 years agomerge units-staging 3
Younies Mahmoud [Fri, 8 May 2020 14:14:51 +0000 (16:14 +0200)]
merge units-staging 3

4 years agomerge units-staging
Younies Mahmoud [Fri, 8 May 2020 14:02:07 +0000 (16:02 +0200)]
merge units-staging

4 years agomerge units-staging
Younies Mahmoud [Fri, 8 May 2020 11:36:10 +0000 (13:36 +0200)]
merge units-staging

4 years agoMerge pull request #21 from younies/tryingdouble
Younies Mahmoud [Thu, 7 May 2020 11:24:31 +0000 (13:24 +0200)]
Merge pull request #21 from younies/tryingdouble

Add unit converter.

5 years agoMerge pull request #39 from younies/tryingdouble_staging
Younies Mahmoud [Wed, 6 May 2020 02:49:32 +0000 (04:49 +0200)]
Merge pull request #39 from younies/tryingdouble_staging

add a TODO to load the constants\' values from the units data

5 years agoadd a TODO to load the constants\' values from the units data
Younies Mahmoud [Wed, 6 May 2020 02:48:35 +0000 (04:48 +0200)]
add a TODO to load the constants\' values from the units data

5 years agoMerge pull request #38 from younies/tryingdouble_staging
Younies Mahmoud [Wed, 6 May 2020 02:45:04 +0000 (04:45 +0200)]
Merge pull request #38 from younies/tryingdouble_staging

fix substituteConstans function

5 years agofix substituteConstans function
Younies Mahmoud [Wed, 6 May 2020 02:28:35 +0000 (04:28 +0200)]
fix substituteConstans function

5 years agoMerge pull request #37 from younies/tryingdouble_staging
Younies Mahmoud [Wed, 6 May 2020 00:12:13 +0000 (02:12 +0200)]
Merge pull request #37 from younies/tryingdouble_staging

add substitution of the constant to `Factor`

5 years agoadd substitution of the constant to
Younies Mahmoud [Wed, 6 May 2020 00:07:36 +0000 (02:07 +0200)]
add substitution of the constant to

5 years agoMerge pull request #36 from younies/tryingdouble_staging
Younies Mahmoud [Tue, 5 May 2020 13:54:40 +0000 (15:54 +0200)]
Merge pull request #36 from younies/tryingdouble_staging

Fix Shane's comment about unitconverter.cpp

5 years agofix UnitConverter
Younies Mahmoud [Tue, 5 May 2020 13:48:19 +0000 (15:48 +0200)]
fix UnitConverter

5 years agoMerge pull request #35 from younies/tryingdouble_staging
Younies Mahmoud [Tue, 5 May 2020 01:50:19 +0000 (03:50 +0200)]
Merge pull request #35 from younies/tryingdouble_staging

Fix dependencies and small nits

5 years agofix dependices and small nits
Younies Mahmoud [Tue, 5 May 2020 01:43:49 +0000 (03:43 +0200)]
fix dependices and small nits

5 years agoMerge remote-tracking branch 'sffc/units-staging' into units_router
Hugo van der Merwe [Mon, 4 May 2020 18:00:37 +0000 (20:00 +0200)]
Merge remote-tracking branch 'sffc/units-staging' into units_router

5 years agoMerge pull request #34 from younies/tryingdouble_staging
Younies Mahmoud [Mon, 4 May 2020 13:07:05 +0000 (15:07 +0200)]
Merge pull request #34 from younies/tryingdouble_staging

Remove extractUnitInfo from UnitConverter's helpers

5 years agoremove extra spaces from the factors
Younies Mahmoud [Mon, 4 May 2020 13:06:05 +0000 (15:06 +0200)]
remove extra spaces from the factors

5 years agoremove extractUnitInfo from UnitConverter's helpers
Younies Mahmoud [Mon, 4 May 2020 03:34:45 +0000 (05:34 +0200)]
remove extractUnitInfo from UnitConverter's helpers

5 years agoMerge pull request #33 from hugovdm/tryingdouble_unitsTestTxt
Younies Mahmoud [Sun, 3 May 2020 18:17:06 +0000 (20:17 +0200)]
Merge pull request #33 from hugovdm/tryingdouble_unitsTestTxt

testConversions: test UnitConverter against unitsTest.txt test cases

5 years agoMerge pull request #41 from hugovdm/units-staging
Shane F. Carr [Sat, 2 May 2020 02:11:40 +0000 (21:11 -0500)]
Merge pull request #41 from hugovdm/units-staging

Update unitsTest.txt and unitPreferencesTest.txt from current CLDR master

5 years agoUpdate unitsTest.txt and unitPreferencesTest.txt from current CLDR master.
Hugo van der Merwe [Thu, 30 Apr 2020 13:46:23 +0000 (15:46 +0200)]
Update unitsTest.txt and unitPreferencesTest.txt from current CLDR master.

5 years agotestConversions: test UnitConverter against unitsTest.txt test cases
Hugo van der Merwe [Wed, 29 Apr 2020 12:07:50 +0000 (14:07 +0200)]
testConversions: test UnitConverter against unitsTest.txt test cases

5 years agoMerge pull request #32 from hugovdm/tryingdouble
Younies Mahmoud [Thu, 30 Apr 2020 12:06:58 +0000 (14:06 +0200)]
Merge pull request #32 from hugovdm/tryingdouble

Reinstate assertEqualsNear that got lost in merge.

5 years agoReinstate assertEqualsNear that got lost in merge.
Hugo van der Merwe [Thu, 30 Apr 2020 08:25:28 +0000 (10:25 +0200)]
Reinstate assertEqualsNear that got lost in merge.

- Code compiles, `make check` returns OK.

5 years agomerge sffc/units-staging
Younies Mahmoud [Wed, 29 Apr 2020 23:48:25 +0000 (01:48 +0200)]
merge sffc/units-staging

5 years agoMerge pull request #39 from hugovdm/unitsTestTxt
Shane F. Carr [Wed, 29 Apr 2020 21:52:34 +0000 (16:52 -0500)]
Merge pull request #39 from hugovdm/unitsTestTxt

testConversions: test convertibility of unitsTest.txt test cases.

5 years agoAdd IntlTest::assertNotEquals() for int32_t.
Hugo van der Merwe [Wed, 29 Apr 2020 19:55:13 +0000 (21:55 +0200)]
Add IntlTest::assertNotEquals() for int32_t.

5 years agoRemove hard-coded unit tests that were pulled out of unitsTest.txt.
Hugo van der Merwe [Wed, 29 Apr 2020 16:14:55 +0000 (18:14 +0200)]
Remove hard-coded unit tests that were pulled out of unitsTest.txt.

5 years agoAdd some comments to UnitsTestContext.
Hugo van der Merwe [Wed, 29 Apr 2020 16:10:08 +0000 (18:10 +0200)]
Add some comments to UnitsTestContext.

5 years agoRemove the 'FIXME_skip_tests' bool and branch.
Hugo van der Merwe [Wed, 29 Apr 2020 15:11:28 +0000 (17:11 +0200)]
Remove the 'FIXME_skip_tests' bool and branch.

5 years agoUncomment pound-force-per-square-inch test in unitsTest.txt
Hugo van der Merwe [Wed, 29 Apr 2020 12:10:28 +0000 (14:10 +0200)]
Uncomment pound-force-per-square-inch test in unitsTest.txt

5 years agotestConversions: test convertibility of unitsTest.txt test cases.
Hugo van der Merwe [Tue, 28 Apr 2020 19:48:28 +0000 (21:48 +0200)]
testConversions: test convertibility of unitsTest.txt test cases.

5 years agoPost-merge: update code to make "make check" pass.
Hugo van der Merwe [Tue, 28 Apr 2020 19:55:19 +0000 (21:55 +0200)]
Post-merge: update code to make "make check" pass.

* MaybeStackVector<ConversionRateInfo> -> ConversionRates.
* Inherit from UMemory to make MaybeStackVector happy (UnitConverter
  and ConverterPreference).
* Hack around getUnitsData's bad interface.

Code is still bad though, unit tests don't cover everything:

* getUnitsData does not work correctly, and various things are marked
  with "WIP" comments (Work In Progress).

5 years agoMerge branch 'tryingdouble' into units_router
Hugo van der Merwe [Wed, 29 Apr 2020 11:34:18 +0000 (13:34 +0200)]
Merge branch 'tryingdouble' into units_router

5 years agoComplicated manual merge of branch 'units-staging' into tryingdouble
Hugo van der Merwe [Wed, 29 Apr 2020 07:28:10 +0000 (09:28 +0200)]
Complicated manual merge of branch 'units-staging' into tryingdouble

This adds a ConversionRates::getInternalList() that needs to be
removed again, by improving APIs appropriately.

5 years agoMerge pull request #32 from younies/check_convirtible_units
Shane F. Carr [Tue, 28 Apr 2020 22:39:05 +0000 (17:39 -0500)]
Merge pull request #32 from younies/check_convirtible_units

Check convertible units

5 years agoadd units_extra to unitsformatter dependencies
Younies Mahmoud [Tue, 28 Apr 2020 21:54:54 +0000 (23:54 +0200)]
add units_extra to unitsformatter dependencies

5 years agoMerge pull request #31 from hugovdm/check_convirtible_units
Younies Mahmoud [Tue, 28 Apr 2020 15:35:08 +0000 (17:35 +0200)]
Merge pull request #31 from hugovdm/check_convirtible_units

Enable "testConversions" test again

5 years agoMerge branch 'check_convirtible_units' into check_convirtible_units
Younies Mahmoud [Tue, 28 Apr 2020 15:34:35 +0000 (17:34 +0200)]
Merge branch 'check_convirtible_units' into check_convirtible_units

5 years agofix unitConverter and add ConversionRates class
Younies Mahmoud [Tue, 28 Apr 2020 15:31:41 +0000 (17:31 +0200)]
fix unitConverter and add ConversionRates class

5 years agoFix make check: dependencies.txt, fix units_extra deps
Hugo van der Merwe [Tue, 28 Apr 2020 15:16:01 +0000 (17:16 +0200)]
Fix make check: dependencies.txt, fix units_extra deps

5 years agoRemove a getUnitsData test failure, but the function is still broken.
Hugo van der Merwe [Tue, 28 Apr 2020 15:00:12 +0000 (17:00 +0200)]
Remove a getUnitsData test failure, but the function is still broken.

5 years agoMerge branch 'tryingdouble' into units_router
Hugo van der Merwe [Tue, 28 Apr 2020 14:06:23 +0000 (16:06 +0200)]
Merge branch 'tryingdouble' into units_router

Tweaked during merge: use the "getAllConversionInfo" function.

5 years agoMerge branch 'units-staging' into tryingdouble
Hugo van der Merwe [Tue, 28 Apr 2020 12:34:47 +0000 (14:34 +0200)]
Merge branch 'units-staging' into tryingdouble

Conflict resolution: uncomment unit tests that pass now, but were
previously disabled by commenting-out within units-staging.

5 years agoEnable "testConversions" test again.
Hugo van der Merwe [Mon, 27 Apr 2020 17:43:08 +0000 (19:43 +0200)]
Enable "testConversions" test again.

With MeasureUnit fixes merged, these tests seem to pass now.

5 years agofix dependencies.txt
Younies Mahmoud [Mon, 27 Apr 2020 13:40:45 +0000 (15:40 +0200)]
fix dependencies.txt

5 years agomerge sffc/units-staging
Younies Mahmoud [Wed, 22 Apr 2020 14:19:32 +0000 (16:19 +0200)]
merge sffc/units-staging

5 years agoMerge pull request #31 from hugovdm/units-staging-getConversionRatesInfo
Shane F. Carr [Tue, 21 Apr 2020 20:47:01 +0000 (15:47 -0500)]
Merge pull request #31 from hugovdm/units-staging-getConversionRatesInfo

Add unitsdata.cpp, getConversionRatesInfo, and unit tests.

5 years agoMerge pull request #30 from hugovdm/check_convertible_units_identifierfixes
Younies Mahmoud [Fri, 17 Apr 2020 12:23:29 +0000 (14:23 +0200)]
Merge pull request #30 from hugovdm/check_convertible_units_identifierfixes

Fix the broken testConversionCapability unit identifiers.

5 years agoFix the broken testConversionCapability unit identifiers.
Hugo van der Merwe [Fri, 17 Apr 2020 00:57:09 +0000 (02:57 +0200)]
Fix the broken testConversionCapability unit identifiers.

5 years agoRemove testGetConversionRateInfo.
Hugo van der Merwe [Thu, 16 Apr 2020 23:49:29 +0000 (01:49 +0200)]
Remove testGetConversionRateInfo.

5 years agoFix deps: use UMemory as base class for it's new().
Hugo van der Merwe [Thu, 16 Apr 2020 23:47:57 +0000 (01:47 +0200)]
Fix deps: use UMemory as base class for it's new().

5 years agodependencies.txt attempt #1: where's "operator new(unsigned long)" coming from?
Hugo van der Merwe [Thu, 16 Apr 2020 22:49:06 +0000 (00:49 +0200)]
dependencies.txt attempt #1: where's "operator new(unsigned long)" coming from?

5 years agoNit: remove two unneeded #includes
Hugo van der Merwe [Thu, 16 Apr 2020 22:47:30 +0000 (00:47 +0200)]
Nit: remove two unneeded #includes

5 years agoComment out broken test cases as per younies' 476ca805c
Hugo van der Merwe [Thu, 16 Apr 2020 02:10:43 +0000 (04:10 +0200)]
Comment out broken test cases as per younies' 476ca805c

5 years agoLint: add copyright notices to .txt files from CLDR.
Hugo van der Merwe [Thu, 16 Apr 2020 01:59:44 +0000 (03:59 +0200)]
Lint: add copyright notices to .txt files from CLDR.

5 years agoSwitch result parameter from pointer to reference.
Hugo van der Merwe [Wed, 15 Apr 2020 11:59:48 +0000 (13:59 +0200)]
Switch result parameter from pointer to reference.

5 years agoReturn getAllConversionRates result via pointer parameter.
Hugo van der Merwe [Wed, 15 Apr 2020 11:55:00 +0000 (13:55 +0200)]
Return getAllConversionRates result via pointer parameter.

5 years agofix check Convertibility
Younies Mahmoud [Tue, 14 Apr 2020 21:01:57 +0000 (23:01 +0200)]
fix check Convertibility

5 years agoImprove documentation comments.
Hugo van der Merwe [Tue, 14 Apr 2020 18:59:41 +0000 (20:59 +0200)]
Improve documentation comments.

5 years agoChange outVector from reference to pointer for clarity of lack of ownership.
Hugo van der Merwe [Tue, 14 Apr 2020 15:10:56 +0000 (17:10 +0200)]
Change outVector from reference to pointer for clarity of lack of ownership.

5 years agoAdd getAllConversionRates(), drop selective code.
Hugo van der Merwe [Tue, 14 Apr 2020 14:33:59 +0000 (16:33 +0200)]
Add getAllConversionRates(), drop selective code.

5 years agofix compound basic unit
Younies Mahmoud [Tue, 14 Apr 2020 13:52:51 +0000 (15:52 +0200)]
fix compound basic unit

5 years agoMerge pull request #28 from hugovdm/hugovdm_check_convertible_units_unitstest
Younies Mahmoud [Tue, 14 Apr 2020 12:13:39 +0000 (14:13 +0200)]
Merge pull request #28 from hugovdm/hugovdm_check_convertible_units_unitstest

Test convertibility of some unitsTest.txt tests

5 years agosmall fixes
Younies Mahmoud [Tue, 14 Apr 2020 09:13:28 +0000 (11:13 +0200)]
small fixes

5 years agoMerge branch 'check_convirtible_units' of github.com:younies/icu into check_convirtib...
Younies Mahmoud [Tue, 7 Apr 2020 20:15:34 +0000 (22:15 +0200)]
Merge branch 'check_convirtible_units' of github.com:younies/icu into check_convirtible_units

5 years agoMerge remote-tracking branch 'upstream/maint/maint-67' into units-staging
Shane F. Carr [Tue, 7 Apr 2020 16:44:16 +0000 (11:44 -0500)]
Merge remote-tracking branch 'upstream/maint/maint-67' into units-staging

5 years agofixup! Rip out compound base unit calculation.
Hugo van der Merwe [Tue, 7 Apr 2020 14:14:24 +0000 (16:14 +0200)]
fixup! Rip out compound base unit calculation.

5 years agoCopy failing unitsTest.txt examples into testConversionCapability.
Hugo van der Merwe [Tue, 7 Apr 2020 13:18:03 +0000 (15:18 +0200)]
Copy failing unitsTest.txt examples into testConversionCapability.

5 years agoMerge pull request #33 from hugovdm/units-staging-testcases
Hugo [Tue, 7 Apr 2020 12:06:50 +0000 (14:06 +0200)]
Merge pull request #33 from hugovdm/units-staging-testcases

Update to latest CLDR test files: b7a23f3f41 CLDR-13587.

5 years agoMerge pull request #34 from hugovdm/units-staging-testimprovements
Hugo [Tue, 7 Apr 2020 12:05:48 +0000 (14:05 +0200)]
Merge pull request #34 from hugovdm/units-staging-testimprovements

Improve test output: no more fprintfs.

5 years agoICU-21060 Fix the foo-per-a-b -> foo-b-per-a bug.
Hugo van der Merwe [Fri, 3 Apr 2020 02:35:29 +0000 (04:35 +0200)]
ICU-21060 Fix the foo-per-a-b -> foo-b-per-a bug.

5 years agoMerge branch 'master' into units-staging
Shane F. Carr [Fri, 3 Apr 2020 21:47:36 +0000 (16:47 -0500)]
Merge branch 'master' into units-staging

5 years agoICU-20979 API Change Report for 67 RC release-67-rc
Steven R. Loomis [Fri, 3 Apr 2020 14:28:08 +0000 (07:28 -0700)]
ICU-20979 API Change Report for 67 RC

5 years agofixup! Rip out compound base unit calculation.
Hugo van der Merwe [Fri, 3 Apr 2020 09:52:41 +0000 (11:52 +0200)]
fixup! Rip out compound base unit calculation.

5 years agoICU-20979 Update TODOs in formatting code to point to open issues.
Shane F. Carr [Fri, 3 Apr 2020 02:16:11 +0000 (21:16 -0500)]
ICU-20979 Update TODOs in formatting code to point to open issues.

Also see: ICU-20920 ICU-21059 ICU-20429 ICU-21058

5 years agoICU-21015 Fixing gcc compiler warnings
Shane F. Carr [Tue, 31 Mar 2020 03:21:24 +0000 (22:21 -0500)]
ICU-21015 Fixing gcc compiler warnings

5 years agoComment out test case that seems to trigger a MeasureUnit parsing bug.
Hugo van der Merwe [Fri, 3 Apr 2020 01:27:45 +0000 (03:27 +0200)]
Comment out test case that seems to trigger a MeasureUnit parsing bug.

5 years agoImprove test output: no more fprintfs.
Hugo van der Merwe [Fri, 3 Apr 2020 00:25:12 +0000 (02:25 +0200)]
Improve test output: no more fprintfs.

5 years agoICU-20979 Updating double-conversion from upstream master
Shane F. Carr [Tue, 31 Mar 2020 02:36:28 +0000 (21:36 -0500)]
ICU-20979 Updating double-conversion from upstream master

5 years agoICU-20979 delete no-longer-relevant comment related to U_HIDE macros
Peter Edberg [Thu, 2 Apr 2020 07:47:40 +0000 (00:47 -0700)]
ICU-20979 delete no-longer-relevant comment related to U_HIDE macros

5 years agoICU-20979 integrate CLDR release-37-beta2 to master
Peter Edberg [Wed, 1 Apr 2020 23:20:18 +0000 (16:20 -0700)]
ICU-20979 integrate CLDR release-37-beta2 to master

5 years agoICU-20979 BRS 67rc, ICU4C API promotion
Peter Edberg [Wed, 1 Apr 2020 02:43:35 +0000 (19:43 -0700)]
ICU-20979 BRS 67rc, ICU4C API promotion

5 years agoICU-20979 Update ICU4C readme
Daniel Ju [Wed, 1 Apr 2020 22:13:18 +0000 (15:13 -0700)]
ICU-20979 Update ICU4C readme

5 years agoICU-21022 Update logKnownIssue to refer to ticket for fixing in a future release
Peter Edberg [Wed, 1 Apr 2020 21:25:29 +0000 (14:25 -0700)]
ICU-21022 Update logKnownIssue to refer to ticket for fixing in a future release

5 years agoICU-20979 BRS67RC Updating ICU4J readme
Yoshito Umaoka [Wed, 1 Apr 2020 21:23:54 +0000 (17:23 -0400)]
ICU-20979 BRS67RC Updating ICU4J readme

For now, just updating version to 67, but not mentioning it's RC, so we don't need another update.

I also updated all dead ICU user guide links.

5 years agoICU-20979 BRS67RC Adding ICU4J 67 API signature data file
Yoshito Umaoka [Wed, 1 Apr 2020 21:29:40 +0000 (17:29 -0400)]
ICU-20979 BRS67RC Adding ICU4J 67 API signature data file

And removed ICU4J 57 API signature data file.

5 years agoICU-20979 BRS67RC Updating ICU4J API change report
Yoshito Umaoka [Wed, 1 Apr 2020 20:31:52 +0000 (16:31 -0400)]
ICU-20979 BRS67RC Updating ICU4J API change report

Incoorporating last minutes fixes found during change report review.

5 years agoICU-20979 Fixing instructions in commit report tool
Shane F. Carr [Tue, 31 Mar 2020 02:24:39 +0000 (21:24 -0500)]
ICU-20979 Fixing instructions in commit report tool

5 years agoICU-20979 Fixing minor MSVC warnings
Jeff Genovy [Tue, 31 Mar 2020 20:01:55 +0000 (13:01 -0700)]
ICU-20979 Fixing minor MSVC warnings

5 years agoICU-20099 Fix API tags in ListFormatter.SpanField
Shane F. Carr [Wed, 1 Apr 2020 18:42:32 +0000 (13:42 -0500)]
ICU-20099 Fix API tags in ListFormatter.SpanField

5 years agoICU-20806 Removing 'implements Cloneable' from Precision.java
Shane F. Carr [Wed, 1 Apr 2020 18:26:53 +0000 (13:26 -0500)]
ICU-20806 Removing 'implements Cloneable' from Precision.java

5 years agoICU-20979 BRS67RC ICU4J API status promotion
Yoshito Umaoka [Wed, 1 Apr 2020 00:25:38 +0000 (20:25 -0400)]
ICU-20979 BRS67RC ICU4J API status promotion

Update ICU draft API up to 64 to stable. Regenerated API change report.

5 years agoICU-20979 BRS67RC Adding ICU4J serialization test data generated by 67
Yoshito Umaoka [Wed, 1 Apr 2020 00:46:41 +0000 (20:46 -0400)]
ICU-20979 BRS67RC Adding ICU4J serialization test data generated by 67

Also dropped ICU4J 62 serialization test data.

5 years agoUpdate to latest CLDR test files: b7a23f3f41 CLDR-13587.
Hugo van der Merwe [Wed, 1 Apr 2020 16:02:23 +0000 (18:02 +0200)]
Update to latest CLDR test files: b7a23f3f41 CLDR-13587.

These files come from a CLDR commit on 2020-03-18.

5 years agoUncomment test cases that MeasureFormat used to flag as ILLEGAL_ARG.
Hugo van der Merwe [Wed, 1 Apr 2020 15:57:03 +0000 (17:57 +0200)]
Uncomment test cases that MeasureFormat used to flag as ILLEGAL_ARG.

5 years agoMerge pull request #23 from hugovdm/units_router_integrate
Younies Mahmoud [Wed, 1 Apr 2020 14:51:01 +0000 (16:51 +0200)]
Merge pull request #23 from hugovdm/units_router_integrate

Integrate current state of sffc/icu/pull/31

5 years agoICU-13724 Removing obsolete numberformat2test.cpp
Shane F. Carr [Tue, 31 Mar 2020 02:48:54 +0000 (21:48 -0500)]
ICU-13724 Removing obsolete numberformat2test.cpp

5 years agoHave getConversionRatesInfo accept a MaybeStackVector instead of only source and...
Hugo van der Merwe [Mon, 30 Mar 2020 18:47:40 +0000 (20:47 +0200)]
Have getConversionRatesInfo accept a MaybeStackVector instead of only source and target.