]> granicus.if.org Git - postgresql/log
postgresql
20 years agoAttached is a 1 line bug fix for dbmirror that was submitted.
Joe Conway [Fri, 2 Jul 2004 00:58:09 +0000 (00:58 +0000)]
Attached is a 1 line bug fix for dbmirror that was submitted.
It fixes a bug where some transactions could be dropped when writing
mirrored SQL statements to files.
-- Steven Singer

20 years agoMore paranoia in AtEOSubXact_SPI: don't assume we can safely use SPI_finish
Tom Lane [Thu, 1 Jul 2004 21:17:13 +0000 (21:17 +0000)]
More paranoia in AtEOSubXact_SPI: don't assume we can safely use SPI_finish
for cleaning up.  It seems possible that the memory contexts SPI_finish
would try to touch are already gone; and there's no need for SPI itself
to delete them, since the containing contexts will surely be going away
anyway at transaction end.

20 years agoplperl update from Andrew Dunstan, deriving (I believe) from Command Prompt's
Joe Conway [Thu, 1 Jul 2004 20:50:22 +0000 (20:50 +0000)]
plperl update from Andrew Dunstan, deriving (I believe) from Command Prompt's
plperlNG. Review and minor cleanup/improvements by Joe Conway.

Summary of new functionality:
- Shared data space and namespace. There is a new global variable %_SHARED
  that functions can use to store and save data between invocations of a
  function, or between different functions. Also, all trusted plperl function
  now share a common Safe container (this is an optimization, also), which
  they can use for storing non-lexical variables, functions, etc.
- Triggers are now supported
- Records can now be returned (as a hash reference)
- Sets of records can now be returned (as a reference to an array of hash
  references).
- New function spi_exec_query() provided for performing db functions or
  getting data from db.
- Optimization for counting hash keys (Abhijit Menon-Sen)
- Allow return of 'record' and 'setof record'

20 years agoFurther review of xact.c state machine for nested transactions. Fix
Tom Lane [Thu, 1 Jul 2004 20:11:03 +0000 (20:11 +0000)]
Further review of xact.c state machine for nested transactions.  Fix
problems with starting subtransactions inside already-failed transactions.
Clean up some comments.

20 years agoRemoved unused variable and added a typecast.
Michael Meskes [Thu, 1 Jul 2004 18:32:58 +0000 (18:32 +0000)]
Removed unused variable and added a typecast.

20 years agoAdd double metaphone code from Andrew Dunstan. Also change metaphone so that
Joe Conway [Thu, 1 Jul 2004 03:25:48 +0000 (03:25 +0000)]
Add double metaphone code from Andrew Dunstan. Also change metaphone so that
an empty input string causes an empty output string to be returned, instead of
throwing an ERROR -- per complaint from Aaron Hillegass, and consistent with
double metaphone. Fix examples in README.soundex pointed out by James Robinson.

20 years agoFix seriously nasty memory leak in new TransactionIdIsInProgress code.
Tom Lane [Thu, 1 Jul 2004 03:13:05 +0000 (03:13 +0000)]
Fix seriously nasty memory leak in new TransactionIdIsInProgress code.

20 years agoNested transactions. There is still much left to do, especially on the
Tom Lane [Thu, 1 Jul 2004 00:52:04 +0000 (00:52 +0000)]
Nested transactions.  There is still much left to do, especially on the
performance front, but with feature freeze upon us I think it's time to
drive a stake in the ground and say that this will be in 7.5.

Alvaro Herrera, with some help from Tom Lane.

20 years agoRevert mistaken #include change, per Merlin Moncure.
Tom Lane [Wed, 30 Jun 2004 15:30:41 +0000 (15:30 +0000)]
Revert mistaken #include change, per Merlin Moncure.

20 years agoAdded SET DESCRIPTOR command.
Michael Meskes [Wed, 30 Jun 2004 15:01:58 +0000 (15:01 +0000)]
Added SET DESCRIPTOR command.
Note that this still has some bugs. The functionality is there though, it's just a matter of fixing the bugs now.
Cleaned up error handling in preprocessor.

20 years agoOverride upstream DSSSL style sheet formatting changes
Peter Eisentraut [Tue, 29 Jun 2004 20:44:34 +0000 (20:44 +0000)]
Override upstream DSSSL style sheet formatting changes

20 years agoComma splice police
Peter Eisentraut [Tue, 29 Jun 2004 19:57:40 +0000 (19:57 +0000)]
Comma splice police

20 years ago1 Eliminate duplicate field HLWORD->skip
Teodor Sigaev [Mon, 28 Jun 2004 16:19:09 +0000 (16:19 +0000)]
1 Eliminate duplicate field HLWORD->skip
2 Rework support for html tags in parser
3 add HighlightAll to headline function for generating highlighted
  whole text with saved html tags

20 years agoArrays can be read as arrays or as character strings now.
Michael Meskes [Mon, 28 Jun 2004 11:47:42 +0000 (11:47 +0000)]
Arrays can be read as arrays or as character strings now.

20 years agoRemove some no-longer-needed #includes.
Tom Lane [Mon, 28 Jun 2004 01:19:11 +0000 (01:19 +0000)]
Remove some no-longer-needed #includes.

20 years agoFix some bogus code in ConstBit production --- it managed to work, but
Tom Lane [Mon, 28 Jun 2004 00:18:47 +0000 (00:18 +0000)]
Fix some bogus code in ConstBit production --- it managed to work, but
only because 14627 still contained the same node that BitWithoutLength had
just produced.  Make it more transparent.  Also adjust ConstCharacter
to be coded the same way for consistency.

20 years agoFix bogus line break within a file name, as noted by Alvaro.
Tom Lane [Sun, 27 Jun 2004 22:58:19 +0000 (22:58 +0000)]
Fix bogus line break within a file name, as noted by Alvaro.

20 years ago- Only use typedefs inside their scope.
Michael Meskes [Sun, 27 Jun 2004 12:28:42 +0000 (12:28 +0000)]
- Only use typedefs inside their scope.
- Variables that are out of scope, were not removed all the time.
- Make a varchar NULL set everything to 0 when not using indicators.
- Synced parser.

20 years agoTranslation updates
Dennis Bjorklund [Sun, 27 Jun 2004 09:35:14 +0000 (09:35 +0000)]
Translation updates

20 years agoAdjust pgstat message definitions so that the target message size is
Tom Lane [Sat, 26 Jun 2004 16:32:04 +0000 (16:32 +0000)]
Adjust pgstat message definitions so that the target message size is
specified in just one place and adhered to exactly, rather than just more
or less.  A side effect is to increase PGSTAT_ACTIVITY_SIZE (maximum
reported query length) from 256 to nearly 1000.

20 years agoTranslation updates
Dennis Bjorklund [Sat, 26 Jun 2004 07:19:16 +0000 (07:19 +0000)]
Translation updates

20 years agoTranslation updates: update-po
Dennis Bjorklund [Sat, 26 Jun 2004 07:11:31 +0000 (07:11 +0000)]
Translation updates: update-po

20 years agoTranslation updates
Dennis Bjorklund [Sat, 26 Jun 2004 07:03:06 +0000 (07:03 +0000)]
Translation updates

20 years agoFix to work better with Exuberant's version of ctags.
Tom Lane [Fri, 25 Jun 2004 22:00:40 +0000 (22:00 +0000)]
Fix to work better with Exuberant's version of ctags.

Gavin Sherry

20 years agoSupport renaming of tablespaces, and changing the owners of
Tom Lane [Fri, 25 Jun 2004 21:55:59 +0000 (21:55 +0000)]
Support renaming of tablespaces, and changing the owners of
aggregates, conversions, functions, operators, operator classes,
schemas, types, and tablespaces.  Fold the existing implementations
of alter domain owner and alter database owner in with these.

Christopher Kings-Lynne

20 years agoTranslation updates
Dennis Bjorklund [Fri, 25 Jun 2004 17:53:22 +0000 (17:53 +0000)]
Translation updates

20 years agoAdd pg_get_serial_sequence() function, and cause pg_dump to use it.
Tom Lane [Fri, 25 Jun 2004 17:20:29 +0000 (17:20 +0000)]
Add pg_get_serial_sequence() function, and cause pg_dump to use it.
This eliminates the assumption that a serial column's sequence will
have the same name on reload that it was given in the original database.

Christopher Kings-Lynne

20 years ago#ifdef out file permissions check on SSL key file when on Windows, as
Tom Lane [Fri, 25 Jun 2004 15:07:52 +0000 (15:07 +0000)]
#ifdef out file permissions check on SSL key file when on Windows, as
we also have done for the data directory permissions check.

Dave Page

20 years agoTranslation updates
Dennis Bjorklund [Fri, 25 Jun 2004 11:22:58 +0000 (11:22 +0000)]
Translation updates

20 years agoSwedish translation of pg_ctl.
Dennis Bjorklund [Fri, 25 Jun 2004 09:49:36 +0000 (09:49 +0000)]
Swedish translation of pg_ctl.

20 years agoMake pg_ctl possible to translate. Strings marked for
Dennis Bjorklund [Fri, 25 Jun 2004 08:49:28 +0000 (08:49 +0000)]
Make pg_ctl possible to translate. Strings marked for
translation has to be complete sentences.

20 years agoTranslation updates
Dennis Bjorklund [Fri, 25 Jun 2004 08:13:49 +0000 (08:13 +0000)]
Translation updates

20 years agoTranslation updates
Dennis Bjorklund [Fri, 25 Jun 2004 07:43:19 +0000 (07:43 +0000)]
Translation updates

20 years agoAdd argument name to syntax.
Dennis Bjorklund [Fri, 25 Jun 2004 07:05:34 +0000 (07:05 +0000)]
Add argument name to syntax.

20 years agoTranslation updates
Dennis Bjorklund [Thu, 24 Jun 2004 22:21:22 +0000 (22:21 +0000)]
Translation updates

20 years agoTranslation updates
Dennis Bjorklund [Thu, 24 Jun 2004 21:56:31 +0000 (21:56 +0000)]
Translation updates

20 years agoReplace direct fprintf(stderr) calls by write_stderr(), and cause this
Tom Lane [Thu, 24 Jun 2004 21:03:42 +0000 (21:03 +0000)]
Replace direct fprintf(stderr) calls by write_stderr(), and cause this
routine to do something appropriate on Win32.  Also, add a security check
on Win32 that parallels the can't-run-as-root check on Unix.

Magnus Hagander

20 years agoAdd documentation for pg_cancel_backend and pg_terminate_backend.
Tom Lane [Thu, 24 Jun 2004 19:57:14 +0000 (19:57 +0000)]
Add documentation for pg_cancel_backend and pg_terminate_backend.

Magnus Hagander

20 years agoAdd --pwfile option to initdb, so that passwords can be set by GUI tools
Tom Lane [Thu, 24 Jun 2004 19:26:59 +0000 (19:26 +0000)]
Add --pwfile option to initdb, so that passwords can be set by GUI tools
that aren't able to feed the password to initdb's /dev/tty.

Magnus Hagander

20 years agoAvoid including <sys/time.h> on platforms that don't have it.
Tom Lane [Thu, 24 Jun 2004 18:55:21 +0000 (18:55 +0000)]
Avoid including <sys/time.h> on platforms that don't have it.
Per trouble report from Andreas Pflug.

20 years agoInclude c.h instead of postgres.h in files that need to be usable in
Tom Lane [Thu, 24 Jun 2004 18:53:48 +0000 (18:53 +0000)]
Include c.h instead of postgres.h in files that need to be usable in
both frontend and backend.  Per Andreas Pflug.

20 years agoExtend pg_ctl to handle service management under WIN32. Lacks docs.
Tom Lane [Thu, 24 Jun 2004 18:23:26 +0000 (18:23 +0000)]
Extend pg_ctl to handle service management under WIN32.  Lacks docs.

Claudio Natoli and Magnus Hagander

20 years agoPrevious commit wasnt full...
Teodor Sigaev [Wed, 23 Jun 2004 11:29:58 +0000 (11:29 +0000)]
Previous commit wasnt full...

20 years ago1 Fix affixes with void replacement (AFAIK, it's only russian)
Teodor Sigaev [Wed, 23 Jun 2004 11:06:11 +0000 (11:06 +0000)]
1 Fix affixes with void replacement (AFAIK, it's only russian)
2 Optimize regex execution

20 years agoRemove link:
Bruce Momjian [Wed, 23 Jun 2004 09:53:57 +0000 (09:53 +0000)]
Remove link:

<   http://momjian.postgresql.org/main/writings/pgsql/project/pitr.html

20 years agoFix stupid bug in installcheck
Teodor Sigaev [Wed, 23 Jun 2004 09:43:43 +0000 (09:43 +0000)]
Fix stupid bug in installcheck

20 years agoFix information schema views to return NULL for precision and scale of
Tom Lane [Tue, 22 Jun 2004 22:30:32 +0000 (22:30 +0000)]
Fix information schema views to return NULL for precision and scale of
an unconstrained numeric column.  Also, factor out some duplicate code
into functions, to ease future maintenance.

20 years agoAdd comment about rationale for continuing to use C library functions
Tom Lane [Mon, 21 Jun 2004 14:12:38 +0000 (14:12 +0000)]
Add comment about rationale for continuing to use C library functions
instead of src/timezone for timestamping log entries.

20 years agoFix pg_dump and pg_dumpall for new names of built-in tablespaces,
Tom Lane [Mon, 21 Jun 2004 13:36:42 +0000 (13:36 +0000)]
Fix pg_dump and pg_dumpall for new names of built-in tablespaces,
per Chris K-L.

20 years agoRename the built-in tablespaces to pg_default and pg_global, and prohibit
Tom Lane [Mon, 21 Jun 2004 04:06:07 +0000 (04:06 +0000)]
Rename the built-in tablespaces to pg_default and pg_global, and prohibit
creation of user-defined tablespaces with names starting with 'pg_', as
per suggestion of Chris K-L.  Also install admin-guide tablespace
documentation from Gavin.

20 years agoRename pg_tablespaces directory to pg_tblspc, so it is more unique from
Bruce Momjian [Mon, 21 Jun 2004 01:04:45 +0000 (01:04 +0000)]
Rename pg_tablespaces directory to pg_tblspc, so it is more unique from
the pg_tablespace table.  Update catalog version.

20 years agoSynced parser and keyword list.
Michael Meskes [Sun, 20 Jun 2004 10:45:47 +0000 (10:45 +0000)]
Synced parser and keyword list.

20 years agoAdd pgevent, with docs explaining out to install it on Win32.
Bruce Momjian [Sun, 20 Jun 2004 01:32:49 +0000 (01:32 +0000)]
Add pgevent, with docs explaining out to install it on Win32.

20 years agoAdjust TAS assembly as per recent discussions: use "+m"(*lock) everywhere
Tom Lane [Sat, 19 Jun 2004 23:02:32 +0000 (23:02 +0000)]
Adjust TAS assembly as per recent discussions: use "+m"(*lock) everywhere
to reference the spinlock variable, and specify "memory" as a clobber
operand to be sure gcc does not try to keep shared-memory values in
registers across a spinlock acquisition.  Also tighten the S/390 asm
sequence, which was apparently written with only minimal study of the
gcc asm documentation.  I have personally tested i386, ia64, ppc, hppa,
and s390 variants --- there is some small chance that I broke the others,
but I doubt it.

20 years agoLooks like s_lock_test needs <time.h> on some platforms.
Tom Lane [Sat, 19 Jun 2004 20:31:55 +0000 (20:31 +0000)]
Looks like s_lock_test needs <time.h> on some platforms.

20 years agos_lock_test requires libpgport to build now.
Tom Lane [Sat, 19 Jun 2004 19:43:11 +0000 (19:43 +0000)]
s_lock_test requires libpgport to build now.

20 years agoFix oversight in recent rowtype-handling improvements: transformTargetList
Tom Lane [Sat, 19 Jun 2004 18:19:56 +0000 (18:19 +0000)]
Fix oversight in recent rowtype-handling improvements: transformTargetList
should recognize 'foo.*' when the star appears in A_Indirection, not only
in ColumnRef.  This allows 'SELECT something.*' to do what the user
expects when the something is an expression yielding a row.

20 years agoFix Makefile syntax. Forgot to test this.
Bruce Momjian [Sat, 19 Jun 2004 15:14:17 +0000 (15:14 +0000)]
Fix Makefile syntax.  Forgot to test this.

20 years agoAdd changes to support threads on Win32 native port at some point in the future.
Bruce Momjian [Sat, 19 Jun 2004 04:43:18 +0000 (04:43 +0000)]
Add changes to support threads on Win32 native port at some point in the future.

20 years agoEnable thread safety for win32.mak build of PostgreSQL.
Bruce Momjian [Sat, 19 Jun 2004 04:22:17 +0000 (04:22 +0000)]
Enable thread safety for win32.mak build of PostgreSQL.

Andreas Pflug

20 years agoAdd:
Bruce Momjian [Sat, 19 Jun 2004 01:48:13 +0000 (01:48 +0000)]
Add:

> * Fix oid2name and dbsize for tablespaces

20 years agoReplace createdb's obsolete --location switch with --tablespace.
Tom Lane [Fri, 18 Jun 2004 21:47:24 +0000 (21:47 +0000)]
Replace createdb's obsolete --location switch with --tablespace.
I kept the same abbreviated letter -D, in hopes of maintaining some
modicum of backwards compatibility (though it's doubtful whether anyone
is really using scripts that invoke createdb -D ...)

20 years agoinitlocation is history. (It's still mentioned in manage-ag.sgml,
Tom Lane [Fri, 18 Jun 2004 21:24:06 +0000 (21:24 +0000)]
initlocation is history.  (It's still mentioned in manage-ag.sgml,
but I'll leave that file alone so as not to mess up the doc patch
I trust Gavin is working on.)

20 years agoAdd:
Bruce Momjian [Fri, 18 Jun 2004 18:35:53 +0000 (18:35 +0000)]
Add:

> * Allow reporting of which objects are in which tablespaces
> * Allow database recovery where tablespaces can't be created
211a213,214
>  o Add ALTER TABLESPACE to change location, name, owner
>  o Allow objects to be moved between tablespaces

20 years agoRemove tablespaces TODO.detail.
Bruce Momjian [Fri, 18 Jun 2004 16:04:13 +0000 (16:04 +0000)]
Remove tablespaces TODO.detail.

20 years agoDone:
Bruce Momjian [Fri, 18 Jun 2004 16:03:20 +0000 (16:03 +0000)]
Done:

> * -Add the concept of dataspaces/tablespaces (Gavin)

20 years agoTablespaces. Alternate database locations are dead, long live tablespaces.
Tom Lane [Fri, 18 Jun 2004 06:14:31 +0000 (06:14 +0000)]
Tablespaces.  Alternate database locations are dead, long live tablespaces.

There are various things left to do: contrib dbsize and oid2name modules
need work, and so does the documentation.  Also someone should think about
COMMENT ON TABLESPACE and maybe RENAME TABLESPACE.  Also initlocation is
dead, it just doesn't know it yet.

Gavin Sherry and Tom Lane.

20 years agoThe attached patch adds some index entries pointing to the cursor
Bruce Momjian [Thu, 17 Jun 2004 12:41:02 +0000 (12:41 +0000)]
The attached patch adds some index entries pointing to the cursor
reference pages.  Please apply.

Alvaro Herrera

20 years agoAdded patch by ISHIDA Akio to allow indicators in execute statements.
Michael Meskes [Thu, 17 Jun 2004 11:52:25 +0000 (11:52 +0000)]
Added patch by ISHIDA Akio to allow indicators in execute statements.

20 years agoImprove comment.
Bruce Momjian [Wed, 16 Jun 2004 03:01:32 +0000 (03:01 +0000)]
Improve comment.

20 years agoDo PGAC_FUNC_GETPWUID_R_5ARG and PGAC_FUNC_STRERROR_R_INT tests with the
Bruce Momjian [Wed, 16 Jun 2004 02:58:28 +0000 (02:58 +0000)]
Do PGAC_FUNC_GETPWUID_R_5ARG and PGAC_FUNC_STRERROR_R_INT tests with the
same thread flags that will be used to compile thread.c.  Add comment to
make sure no one breaks it.

20 years agoRepresent type-specific length coercion functions as pg_cast entries,
Tom Lane [Wed, 16 Jun 2004 01:27:00 +0000 (01:27 +0000)]
Represent type-specific length coercion functions as pg_cast entries,
eliminating the former hard-wired convention about their names.  Allow
pg_cast entries to represent both type coercion and length coercion in
a single step --- this is represented by a function that takes an
extra typmod argument, just like a length coercion function.  This
nicely merges the type and length coercion mechanisms into something
at least a little cleaner than we had before.  Make use of the single-
coercion-step behavior to fix integer-to-bit coercion so that coercing
to bit(n) yields the rightmost n bits of the integer instead of the
leftmost n bits.  This should fix recurrent complaints about the odd
behavior of this coercion.  Clean up the documentation of the bit string
functions, and try to put it where people might actually find it.
Also, get rid of the unreliable heuristics in ruleutils.c about whether
to display nested coercion steps; instead require parse_coerce.c to
label them properly in the first place.

20 years agoFix doc bug: to_timestamp() returns timestamptz, not plain timestamp.
Tom Lane [Mon, 14 Jun 2004 19:01:09 +0000 (19:01 +0000)]
Fix doc bug: to_timestamp() returns timestamptz, not plain timestamp.

20 years agoArrange to explicitly stop the pgstat processes at the same time we
Tom Lane [Mon, 14 Jun 2004 18:08:19 +0000 (18:08 +0000)]
Arrange to explicitly stop the pgstat processes at the same time we
begin the shutdown checkpoint; there isn't anything left for them to do,
so we may as well ensure that they shut down sooner rather than later.
Per discussion.

20 years agoNew wording:
Bruce Momjian [Mon, 14 Jun 2004 13:44:00 +0000 (13:44 +0000)]
New wording:

<   in-progress when the server terminates abruptly
>   in-progress when the server terminated abruptly

20 years agoNew wording:
Bruce Momjian [Mon, 14 Jun 2004 13:42:47 +0000 (13:42 +0000)]
New wording:

<   in-progress when the server crashed
>   in-progress when the server terminates abruptly

20 years agoAdd missing PQclear().
Tatsuo Ishii [Mon, 14 Jun 2004 11:00:12 +0000 (11:00 +0000)]
Add missing PQclear().

20 years agoUpdated wording:
Bruce Momjian [Sun, 13 Jun 2004 23:42:59 +0000 (23:42 +0000)]
Updated wording:

< * Remove unreferenced table files and temp tables during database vacuum
<   or postmaster startup (Bruce)
> * Remove unreferenced table files created by transactions that were
>   in-progress when the server crashed
>

20 years agoRe-add:
Bruce Momjian [Sun, 13 Jun 2004 23:39:30 +0000 (23:39 +0000)]
Re-add:

> * Remove unreferenced table files and temp tables during database vacuum
>   or postmaster startup (Bruce)

20 years agoGive inet/cidr datatypes their own hash function that ignores the inet vs
Tom Lane [Sun, 13 Jun 2004 21:57:28 +0000 (21:57 +0000)]
Give inet/cidr datatypes their own hash function that ignores the inet vs
cidr type bit, the same as network_eq does.  This is needed for hash joins
and hash aggregation to work correctly on these types.  Per bug report
from Michael Fuhr, 2004-04-13.
Also, improve hash function for int8 as suggested by Greg Stark.

20 years agoRemove README.CVS when making a distribution.
Peter Eisentraut [Sun, 13 Jun 2004 21:51:36 +0000 (21:51 +0000)]
Remove README.CVS when making a distribution.

20 years agoTranslation update
Peter Eisentraut [Sun, 13 Jun 2004 21:41:33 +0000 (21:41 +0000)]
Translation update

20 years agoCode review for recently-added network functions. Get it to work when
Tom Lane [Sun, 13 Jun 2004 19:56:52 +0000 (19:56 +0000)]
Code review for recently-added network functions.  Get it to work when
log_hostname is enabled, clean up documentation.

20 years agoCorrect erroneous table title, per Halley Pacheco de Oliveira.
Tom Lane [Sun, 13 Jun 2004 17:51:08 +0000 (17:51 +0000)]
Correct erroneous table title, per Halley Pacheco de Oliveira.

20 years agoNow needs to include <ctype.h>.
Tom Lane [Sat, 12 Jun 2004 20:31:43 +0000 (20:31 +0000)]
Now needs to include <ctype.h>.

20 years agoSome editorializing on 7.4.3 release notes.
Tom Lane [Sat, 12 Jun 2004 19:30:29 +0000 (19:30 +0000)]
Some editorializing on 7.4.3 release notes.

20 years agoImprove release wording.
Bruce Momjian [Sat, 12 Jun 2004 04:22:15 +0000 (04:22 +0000)]
Improve release wording.

20 years agoMarkup fix.
Bruce Momjian [Sat, 12 Jun 2004 04:08:02 +0000 (04:08 +0000)]
Markup fix.

20 years agoFix markup
Bruce Momjian [Sat, 12 Jun 2004 04:02:53 +0000 (04:02 +0000)]
Fix markup

20 years agoUpdate release notes for 7.4.3.
Bruce Momjian [Sat, 12 Jun 2004 03:54:51 +0000 (03:54 +0000)]
Update release notes for 7.4.3.

20 years agoECPG preprocessor for PostgreSQL 7.4.1, 7.4.2 doubles const,
Bruce Momjian [Fri, 11 Jun 2004 17:32:39 +0000 (17:32 +0000)]
ECPG preprocessor for PostgreSQL 7.4.1, 7.4.2 doubles const,
volatile, static, and register keywords before variables,
declared as VARCHAR.

Sergey N. Yatskevich

20 years agoStrategyDirtyBufferList wasn't being careful to honor max_buffers limit.
Tom Lane [Fri, 11 Jun 2004 17:20:39 +0000 (17:20 +0000)]
StrategyDirtyBufferList wasn't being careful to honor max_buffers limit.
Bug is only latent given that sole caller is passing NBuffers, but it
could bite someone in the rear someday.

20 years agoUse sizeof() rather than strlen() in array size.
Bruce Momjian [Fri, 11 Jun 2004 17:09:13 +0000 (17:09 +0000)]
Use sizeof() rather than strlen() in array size.

20 years agoAdd some code to Assert that when we release pin on a buffer, we are
Tom Lane [Fri, 11 Jun 2004 16:43:24 +0000 (16:43 +0000)]
Add some code to Assert that when we release pin on a buffer, we are
not holding the buffer's cntx_lock or io_in_progress_lock.  A recent
report from Litao Wu makes me wonder whether it is ever possible for
us to drop a buffer and forget to release its cntx_lock.  The Assert
does not fire in the regression tests, but that proves little ...

20 years agoCleanup use of Win32 START by using "" for title. No need for temp
Bruce Momjian [Fri, 11 Jun 2004 16:36:31 +0000 (16:36 +0000)]
Cleanup use of Win32 START by using "" for title.  No need for temp
batch files anymore.

20 years agoAdd URL about Win32 quoting behavior.
Bruce Momjian [Fri, 11 Jun 2004 16:10:09 +0000 (16:10 +0000)]
Add URL about Win32 quoting behavior.

20 years agoAnother fix for Win32 START.
Bruce Momjian [Fri, 11 Jun 2004 04:17:21 +0000 (04:17 +0000)]
Another fix for Win32 START.

20 years agoThe attached tiny patch removes spurious carriage returns that might be
Bruce Momjian [Fri, 11 Jun 2004 03:56:46 +0000 (03:56 +0000)]
The attached tiny patch removes spurious carriage returns that might be
copied by the script that generates psql's help. (You can get the
spurious CRs if you use a CVS client on Windows that does line end
translation.)  Elsewhere, the patch should be totally benign.

This removes quite a number of the compile warnings I posted the other
day.

Andrew Dunstan

20 years ago>> It certainly doesn't. There still was a bug with the locale stuff,
Bruce Momjian [Fri, 11 Jun 2004 03:54:54 +0000 (03:54 +0000)]
>> It certainly doesn't. There still was a bug with the locale stuff,
>> though - the GUC variable was not set in the child
>processes. So "show
>> lc_collate" would *always* return "C", for example. attached
>patch fixes
>> this.
>
>Hm.  Why were these vars not propagated by the regular
>mechanism for GUC
>variables (write_nondefault_variables or whatever it's called)?  If the
>problem is that it's not accepting PGC_INTERNAL values, then we need to
>fix it there not here, because otherwise we'll have to pass all the
>PGC_INTERNAL variables through the backend_variables file, which seems
>like a recipe for more of the same sort of bug.

Good point :-(

I think the problem is not only that it specifically does not deal with
PGC_INTERNAL variables. The problem is in the fact that
write_nondefault_variables is called *before* the locale is read
(because the locale is read from pg_control and not from any of the
"usual" ways to read it).

Attached patch is another stab at fixing it. It makes postmaster dump a
new copy of the file once it has started the database (before it accepts
any connections), which is when it will know about these parameters.
Also updates the reading code to set the context to the one where the
variable was originally set (PGC_POSTMASTER won't work for PGC_INTERNAL,
and the other way around).

We still pass lc_collate through the special file, because
set_config_option on lc_collate will speficially *not* call setlocale(),
and we need that call. But we no longer call set_config_option from
there.

Magnus Hagander

20 years agoThis patch updates pgpipe() on win32 to log exactly which part of the
Bruce Momjian [Fri, 11 Jun 2004 03:48:35 +0000 (03:48 +0000)]
This patch updates pgpipe() on win32 to log exactly which part of the
call fails when it does. (As it is now, there is no way to figure out
the point of error). Shouldn't be a problem since it's most defintily
not a performance-critical path (only called on pgstat startup ATM).

This should help us debug the pipe error message that's on the win32
status page (which I myself have never been able to reproduce, and thus
haven't figured out a better way to debug yet)

Magnus Hagander