]> granicus.if.org Git - postgresql/log
postgresql
22 years agoFix lookup tables used for rounding interval data values when not using
Thomas G. Lockhart [Tue, 14 May 2002 13:37:27 +0000 (13:37 +0000)]
Fix lookup tables used for rounding interval data values when not using
 integer datetimes. Thanks to Tom Lane for spotting the problem.

22 years agoMake regression tests locale-proof by setting some locale categories
Peter Eisentraut [Tue, 14 May 2002 13:05:43 +0000 (13:05 +0000)]
Make regression tests locale-proof by setting some locale categories
to C at run-time, and providing alternative output files for different
sort orders.

22 years agoFix bug in psql.
Tatsuo Ishii [Tue, 14 May 2002 04:20:15 +0000 (04:20 +0000)]
Fix bug in psql.

per report from sugita@sra.co.jp on Thu, 09 May 2002 11:57:51 +0900
(JST) at pgsql-patches list.

Illegal long options to pg_dump makes core on some systems, since it
lacks the last null sentinel of struct option array.

Attached is a patch made by Mr. Ishida Akio <iakio@pjam.jpweb.net>.

22 years agofixed problem connecting to server with client_min_messages set to debug. The code...
Barry Lind [Tue, 14 May 2002 03:00:35 +0000 (03:00 +0000)]
fixed problem connecting to server with client_min_messages set to debug.  The code was not expecting to receive notice messages during the connection handshake.

22 years agoFix typo in _copyAlterUserSetStmt.
Tom Lane [Mon, 13 May 2002 20:39:43 +0000 (20:39 +0000)]
Fix typo in _copyAlterUserSetStmt.

22 years agoAVG probably shouldn't be upper case here, considering
Tom Lane [Mon, 13 May 2002 19:22:06 +0000 (19:22 +0000)]
AVG probably shouldn't be upper case here, considering
that we don't upcase the others.

22 years agoMake operators have their own comments separate from those of the
Tom Lane [Mon, 13 May 2002 17:45:30 +0000 (17:45 +0000)]
Make operators have their own comments separate from those of the
underlying function; but cause psql's \do to show the underlying
function's comment if the operator has no comment of its own, to preserve
the useful functionality of the original behavior.  Also, implement
COMMENT ON SCHEMA.  Patch from Rod Taylor.

22 years agoGet rid of long-since-vestigial Iter node type, in favor of adding a
Tom Lane [Sun, 12 May 2002 23:43:04 +0000 (23:43 +0000)]
Get rid of long-since-vestigial Iter node type, in favor of adding a
returns-set boolean field in Func and Oper nodes.  This allows cleaner,
more reliable tests for expressions returning sets in the planner and
parser.  For example, a WHERE clause returning a set is now detected
and complained of in the parser, not only at runtime.

22 years agoFirst pass at set-returning-functions in FROM, by Joe Conway with
Tom Lane [Sun, 12 May 2002 20:10:05 +0000 (20:10 +0000)]
First pass at set-returning-functions in FROM, by Joe Conway with
some kibitzing from Tom Lane.  Not everything works yet, and there's
no documentation or regression test, but let's commit this so Joe
doesn't need to cope with tracking changes in so many files ...

22 years agoUpdate for additional options in CREATE OPERATOR.
Tom Lane [Sat, 11 May 2002 02:09:41 +0000 (02:09 +0000)]
Update for additional options in CREATE OPERATOR.

22 years agoForgot to handle 'opaque' function arguments in regprocedurein/out.
Tom Lane [Sat, 11 May 2002 00:24:16 +0000 (00:24 +0000)]
Forgot to handle 'opaque' function arguments in regprocedurein/out.

22 years agoFirst pass at schema-fying pg_dump/pg_restore. Much to do still,
Tom Lane [Fri, 10 May 2002 22:36:27 +0000 (22:36 +0000)]
First pass at schema-fying pg_dump/pg_restore.  Much to do still,
but the basic capability seems to work.

22 years agoSuppress duplicate logging of utility commands under debug_print_query.
Tom Lane [Fri, 10 May 2002 20:22:13 +0000 (20:22 +0000)]
Suppress duplicate logging of utility commands under debug_print_query.

22 years agoMake initdb print a message about which locale it is about to use.
Peter Eisentraut [Thu, 9 May 2002 13:30:24 +0000 (13:30 +0000)]
Make initdb print a message about which locale it is about to use.
Re-add warning if the locale prevents LIKE-optimization.  Done within
initdb now.

22 years agoAdd a file for version control.
Hiroshi Inoue [Thu, 9 May 2002 04:10:22 +0000 (04:10 +0000)]
Add a file for version control.

22 years agoAccept SET SESSION AUTHORIZATION DEFAULT and RESET SESSION AUTHORIZATION
Tom Lane [Mon, 6 May 2002 19:47:30 +0000 (19:47 +0000)]
Accept SET SESSION AUTHORIZATION DEFAULT and RESET SESSION AUTHORIZATION
to reset session userid to the originally-authenticated name.  Also,
relax SET SESSION AUTHORIZATION to allow specifying one's own username
even if one is not superuser, so as to avoid unnecessary error messages
when loading a pg_dump file that uses this command.  Per discussion from
several months ago.

22 years agoMake dumpACL behave more reasonably for case where owner has revoked
Tom Lane [Mon, 6 May 2002 18:33:45 +0000 (18:33 +0000)]
Make dumpACL behave more reasonably for case where owner has revoked
some of his own privileges.

22 years agoCause fmtId to always use its internal buffer for the returned value,
Tom Lane [Mon, 6 May 2002 17:34:45 +0000 (17:34 +0000)]
Cause fmtId to always use its internal buffer for the returned value,
in hopes of making erroneous usage more apparent.  Per discussion 15-Apr.

22 years agoReorder snapshot checks to save a couple comparisons in the common case,
Tom Lane [Mon, 6 May 2002 02:39:01 +0000 (02:39 +0000)]
Reorder snapshot checks to save a couple comparisons in the common case,
where the tuple's xmin or xmax is older than the snapshot xmin.  There
is no need to check it against snapshot xmax in that case.

22 years agoA little paranoia never hurt anyone.
Tom Lane [Sun, 5 May 2002 17:50:04 +0000 (17:50 +0000)]
A little paranoia never hurt anyone.

22 years agoplpgsql_dstring_append was broken for long strings.
Tom Lane [Sun, 5 May 2002 17:38:26 +0000 (17:38 +0000)]
plpgsql_dstring_append was broken for long strings.

22 years agoNot needed anymore.
Tom Lane [Sun, 5 May 2002 16:47:09 +0000 (16:47 +0000)]
Not needed anymore.

22 years agoAdd missing includes.
Tom Lane [Sun, 5 May 2002 16:14:24 +0000 (16:14 +0000)]
Add missing includes.

22 years agoAdd a trivial testbed for pg_sema and pg_shmem code.
Tom Lane [Sun, 5 May 2002 16:02:37 +0000 (16:02 +0000)]
Add a trivial testbed for pg_sema and pg_shmem code.

22 years agoCope with case that SEM_FAILED is not defined (assume failure code is -1)
Tom Lane [Sun, 5 May 2002 16:01:50 +0000 (16:01 +0000)]
Cope with case that SEM_FAILED is not defined (assume failure code is -1)

22 years agoFirst test of Darwin port with POSIX semaphore code.
Tom Lane [Sun, 5 May 2002 01:03:26 +0000 (01:03 +0000)]
First test of Darwin port with POSIX semaphore code.

22 years agoFix code to work when isalpha and friends are macros, not functions.
Tom Lane [Sun, 5 May 2002 00:50:31 +0000 (00:50 +0000)]
Fix code to work when isalpha and friends are macros, not functions.

22 years agoCreate an internal semaphore API that is not tied to SysV semaphores.
Tom Lane [Sun, 5 May 2002 00:03:29 +0000 (00:03 +0000)]
Create an internal semaphore API that is not tied to SysV semaphores.
As proof of concept, provide an alternate implementation based on POSIX
semaphores.  Also push the SysV shared-memory implementation into a
separate file so that it can be replaced conveniently.

22 years agoFix compile errors in CYR_RECODE code, per report from Oliver Elphick.
Tom Lane [Fri, 3 May 2002 20:43:30 +0000 (20:43 +0000)]
Fix compile errors in CYR_RECODE code, per report from Oliver Elphick.

22 years agoMake ruleutils.c schema-aware. Displayed names are schema-qualified
Tom Lane [Fri, 3 May 2002 20:15:02 +0000 (20:15 +0000)]
Make ruleutils.c schema-aware.  Displayed names are schema-qualified
only if they would not be found without qualification given the current
search path, as per idea from Peter Eisentraut.

22 years agoFix obsolete comments.
Tom Lane [Fri, 3 May 2002 17:42:11 +0000 (17:42 +0000)]
Fix obsolete comments.

22 years agoUse quote_identifier on relation names in EXPLAIN output, per suggestion
Tom Lane [Fri, 3 May 2002 15:56:45 +0000 (15:56 +0000)]
Use quote_identifier on relation names in EXPLAIN output, per suggestion
from Liam Stewart.  Minor code cleanups also.

22 years agoFix typo in usage instructions.
Tom Lane [Fri, 3 May 2002 14:21:38 +0000 (14:21 +0000)]
Fix typo in usage instructions.

22 years agoRemove the last traces of datatypes datetime and timespan.
Tom Lane [Fri, 3 May 2002 04:11:08 +0000 (04:11 +0000)]
Remove the last traces of datatypes datetime and timespan.

22 years agoRetire xlateSqlType/xlateSqlFunc; all type name translations are now
Tom Lane [Fri, 3 May 2002 00:32:19 +0000 (00:32 +0000)]
Retire xlateSqlType/xlateSqlFunc; all type name translations are now
handled as special productions.  This is needed to keep us honest about
user-schema type names that happen to coincide with system type names.
Per pghackers discussion 24-Apr.  To avoid bloating the keyword list
too much, I removed the translations for datetime, timespan, and lztext,
all of which were slated for destruction several versions back anyway.

22 years agoFix backslash-n typo, per Joe Conway.
Tom Lane [Thu, 2 May 2002 21:44:43 +0000 (21:44 +0000)]
Fix backslash-n typo, per Joe Conway.

22 years agoTweak scanner/grammar interface so that the keyword-as-identifier rules
Tom Lane [Thu, 2 May 2002 18:44:11 +0000 (18:44 +0000)]
Tweak scanner/grammar interface so that the keyword-as-identifier rules
in gram.y can make use of the keywords.c string table, instead of having
their own copies of the keyword strings.  This saves a few kilobytes and
more importantly eliminates an opportunity for cut-and-paste errors.

22 years agoAdd routines in namespace.c to determine whether objects are visible
Tom Lane [Wed, 1 May 2002 23:06:41 +0000 (23:06 +0000)]
Add routines in namespace.c to determine whether objects are visible
in the search path.  (We might want to make these available as SQL
functions too, but I haven't done that yet.)  Fix format_type to be
schema-aware.

22 years agoGive left_oper() and right_oper() noError parameters like oper() (the
Tom Lane [Wed, 1 May 2002 19:26:08 +0000 (19:26 +0000)]
Give left_oper() and right_oper() noError parameters like oper() (the
binary case) already has.  Needed for upcoming ruleutils change.

22 years agoImprove lexer's error reporting. You get the whole token mentioned now
Tom Lane [Wed, 1 May 2002 17:12:08 +0000 (17:12 +0000)]
Improve lexer's error reporting.  You get the whole token mentioned now
in parse error messages, not just the part scanned by the last flex rule.
For example,
select "foo" "bar";
used to draw
ERROR:  parser: parse error at or near """
which was rather unhelpful.  Now it gives
ERROR:  parser: parse error at or near ""bar""
Also, error messages concerning bitstring literals and suchlike will
quote the source text at you, not the processed internal form of the literal.

22 years agoThe attached patch fixes 4 instances of missing simi-colons in the
Jan Wieck [Wed, 1 May 2002 12:40:22 +0000 (12:40 +0000)]
The attached patch fixes 4 instances of missing simi-colons in the
PL/PgSQL grammar, which were causing warnings when used with Bison
1.35.

Neil Conway <neilconway@rogers.com>

22 years agoChange heap_get_latest_tid() so that a transaction can
Hiroshi Inoue [Wed, 1 May 2002 01:23:37 +0000 (01:23 +0000)]
Change heap_get_latest_tid() so that a transaction can
see changes made by the transaction itself.

22 years agoFix obj_description() and col_description() functions to work reliably
Tom Lane [Tue, 30 Apr 2002 21:01:52 +0000 (21:01 +0000)]
Fix obj_description() and col_description() functions to work reliably
in presence of schemas.

22 years agoDocument that NAMEDATALEN must be a multiple of sizeof(int).
Tom Lane [Tue, 30 Apr 2002 19:53:03 +0000 (19:53 +0000)]
Document that NAMEDATALEN must be a multiple of sizeof(int).

22 years agoClean up loose ends remaining from schema privileges discussion.
Tom Lane [Tue, 30 Apr 2002 01:26:26 +0000 (01:26 +0000)]
Clean up loose ends remaining from schema privileges discussion.
I concluded that RENAME should require CREATE privilege on the namespace
as well as ownership of the table.

22 years agoCode review for ALTER TRIGGER RENAME patch: make better use of index,
Tom Lane [Tue, 30 Apr 2002 01:24:57 +0000 (01:24 +0000)]
Code review for ALTER TRIGGER RENAME patch: make better use of index,
don't scribble on tuple returned by table scan.

22 years agoEnforce EXECUTE privilege for aggregate functions.
Tom Lane [Mon, 29 Apr 2002 22:28:19 +0000 (22:28 +0000)]
Enforce EXECUTE privilege for aggregate functions.

22 years agoImplement checking of USAGE rights on namespaces.
Tom Lane [Mon, 29 Apr 2002 22:15:07 +0000 (22:15 +0000)]
Implement checking of USAGE rights on namespaces.

22 years agoAdd cache invalidation callback hooks.
Tom Lane [Mon, 29 Apr 2002 22:14:34 +0000 (22:14 +0000)]
Add cache invalidation callback hooks.

22 years agoAdd missing 'static' keyword to suppress compiler complaints.
Tom Lane [Mon, 29 Apr 2002 17:30:18 +0000 (17:30 +0000)]
Add missing 'static' keyword to suppress compiler complaints.
gcc does not complain about this mistake, but other compilers do.

22 years agoRemove unnecessary/obsolete regproctooid() references.
Tom Lane [Mon, 29 Apr 2002 04:10:02 +0000 (04:10 +0000)]
Remove unnecessary/obsolete regproctooid() references.

22 years agoAdd Polish FAQ from Marcin Mazurek.
Bruce Momjian [Mon, 29 Apr 2002 02:57:18 +0000 (02:57 +0000)]
Add Polish FAQ from Marcin Mazurek.

22 years agoFix problem with new pg_hba.conf code where the same comparison function
Bruce Momjian [Sun, 28 Apr 2002 22:49:07 +0000 (22:49 +0000)]
Fix problem with new pg_hba.conf code where the same comparison function
was incorrectly used for both qsort and bsearch.

22 years agoSecond try at fixing join alias variables. Instead of attaching miscellaneous
Tom Lane [Sun, 28 Apr 2002 19:54:29 +0000 (19:54 +0000)]
Second try at fixing join alias variables.  Instead of attaching miscellaneous
lists to join RTEs, attach a list of Vars and COALESCE expressions that will
replace the join's alias variables during planning.  This simplifies
flatten_join_alias_vars while still making it easy to fix up varno references
when transforming the query tree.  Add regression test cases for interactions
of subqueries with outer joins.

22 years ago - Synced yet again.
Michael Meskes [Sun, 28 Apr 2002 17:20:03 +0000 (17:20 +0000)]
- Synced yet again.
- Fixed a typo in a comment printed by ecpg.

22 years agoMake ruleutils.c use format_type for printing typenames. Minor tweaks
Tom Lane [Sun, 28 Apr 2002 00:49:13 +0000 (00:49 +0000)]
Make ruleutils.c use format_type for printing typenames.  Minor tweaks
in quoting rules and recognition of implicit type coercions.

22 years agoMinor code cleanup.
Tom Lane [Sun, 28 Apr 2002 00:36:38 +0000 (00:36 +0000)]
Minor code cleanup.

22 years agoSupport toasting of shared system relations, and provide toast tables for
Tom Lane [Sat, 27 Apr 2002 21:24:34 +0000 (21:24 +0000)]
Support toasting of shared system relations, and provide toast tables for
pg_database, pg_shadow, pg_group, all of which now have potentially-long
fields.  Along the way, get rid of SharedSystemRelationNames list: shared
rels are now identified in their include/pg_catalog/*.h files by a
BKI_SHARED_RELATION macro, while indexes and toast rels inherit sharedness
automatically from their parent table.  Fix some bugs with failure to detoast
pg_group.grolist during ALTER GROUP.

22 years agoFix write of pg_pwd file for multiple users. Broken recently by my
Bruce Momjian [Sat, 27 Apr 2002 15:30:07 +0000 (15:30 +0000)]
Fix write of pg_pwd file for multiple users.  Broken recently by my
pg_hba.conf changes.

22 years agoRestructure aclcheck error reporting to make permission-failure
Tom Lane [Sat, 27 Apr 2002 03:45:03 +0000 (03:45 +0000)]
Restructure aclcheck error reporting to make permission-failure
messages more uniform and internationalizable: the global array
aclcheck_error_strings[] is gone in favor of a subroutine
aclcheck_error().  Partial implementation of namespace-related
permission checks --- not all done yet.

22 years agoUpdate DROP COLUMN example to use transactions and rollback-able DROP TABLE>
Bruce Momjian [Sat, 27 Apr 2002 03:04:08 +0000 (03:04 +0000)]
Update DROP COLUMN example to use transactions and rollback-able DROP TABLE>

22 years agoFix typo.
Tom Lane [Fri, 26 Apr 2002 19:47:35 +0000 (19:47 +0000)]
Fix typo.

22 years agoMove renametrig() from tablecmds.c to trigger.c --- if we're going to
Tom Lane [Fri, 26 Apr 2002 19:29:47 +0000 (19:29 +0000)]
Move renametrig() from tablecmds.c to trigger.c --- if we're going to
divide backend/commands by object type, let's try to pay at least
minimal attention to respecting that structure, eh?  Also reorder the
contents of tablecmds.c; it seems odd to me to put ALTER commands before
creation/deletion commands.

22 years agoUpdated:
Bruce Momjian [Fri, 26 Apr 2002 18:32:44 +0000 (18:32 +0000)]
Updated:

>  o Abort all SET changes made in an aborted transaction

22 years agoAdd checking for syslog.h
Tatsuo Ishii [Fri, 26 Apr 2002 13:55:38 +0000 (13:55 +0000)]
Add checking for syslog.h
Enable multibyte support by default. Note that this is the first cut,
and I'm gloing to remove #ifdef MULTIBYTE and others step by step...

22 years agoAdd current_schema() and current_schemas() inquiry functions.
Tom Lane [Fri, 26 Apr 2002 01:24:08 +0000 (01:24 +0000)]
Add current_schema() and current_schemas() inquiry functions.
Update has_table_privilege functions to cope with schema-qualified
names in the same way as nextval() and others.

22 years agoAdd a reference page for CREATE SCHEMA.
Tom Lane [Thu, 25 Apr 2002 21:47:07 +0000 (21:47 +0000)]
Add a reference page for CREATE SCHEMA.

22 years agoAdded:
Bruce Momjian [Thu, 25 Apr 2002 20:39:11 +0000 (20:39 +0000)]
Added:

> * Allow backslash handling in quoted strings to be disabled for portability

22 years agoImprove display of headings in HTML.
Bruce Momjian [Thu, 25 Apr 2002 20:20:50 +0000 (20:20 +0000)]
Improve display of headings in HTML.

22 years agoUpdates for schema features.
Tom Lane [Thu, 25 Apr 2002 20:14:43 +0000 (20:14 +0000)]
Updates for schema features.

22 years agoImplement types regprocedure, regoper, regoperator, regclass, regtype
Tom Lane [Thu, 25 Apr 2002 02:56:56 +0000 (02:56 +0000)]
Implement types regprocedure, regoper, regoperator, regclass, regtype
per pghackers discussion.  Add some more typsanity tests, and clean
up some problems exposed thereby (broken or missing array types for
some built-in types).  Also, clean up loose ends from unknownin/out
patch.

22 years agoFix for the following items about escape sequence
Hiroshi Inoue [Thu, 25 Apr 2002 02:50:08 +0000 (02:50 +0000)]
Fix for the following items about escape sequence

   by Marcelo Aceto <aceto@newinf.com.br> .

1) Wrong translations of embedded escape sequences inside outer join escape
sequences.
2) Wrong translation of parameter markers inside outer joins and function
escape sequences.
3) Bad concatenation of date, time, timestamp constants with next word in
statement:

22 years agoFix password code to deal with new quoting code.
Bruce Momjian [Thu, 25 Apr 2002 00:56:36 +0000 (00:56 +0000)]
Fix password code to deal with new quoting code.

22 years agoRemove reference to NAMEDATALEN, which wasn't necessary anyway.
Peter Eisentraut [Wed, 24 Apr 2002 23:00:40 +0000 (23:00 +0000)]
Remove reference to NAMEDATALEN, which wasn't necessary anyway.

22 years agoRemove references to NAMEDATALEN and INDEX_MAX_KEYS from pg_dump. Handles
Peter Eisentraut [Wed, 24 Apr 2002 22:39:49 +0000 (22:39 +0000)]
Remove references to NAMEDATALEN and INDEX_MAX_KEYS from pg_dump.  Handles
any size now.

22 years agoRemove reference to BLCKSZ.
Peter Eisentraut [Wed, 24 Apr 2002 21:00:10 +0000 (21:00 +0000)]
Remove reference to BLCKSZ.

22 years agoDon't dump core on empty table.
Tom Lane [Wed, 24 Apr 2002 15:56:38 +0000 (15:56 +0000)]
Don't dump core on empty table.

22 years agoRemove compile warnings for lo dump by casting to char *.
Bruce Momjian [Wed, 24 Apr 2002 14:03:22 +0000 (14:03 +0000)]
Remove compile warnings for lo dump by casting to char *.

22 years agoMissed one NAMEDATALEN.
Peter Eisentraut [Wed, 24 Apr 2002 06:17:04 +0000 (06:17 +0000)]
Missed one NAMEDATALEN.

22 years agoRemove traces of NAMEDATALEN and INDEX_MAX_KEYS from psql. Build buffers
Peter Eisentraut [Wed, 24 Apr 2002 05:24:00 +0000 (05:24 +0000)]
Remove traces of NAMEDATALEN and INDEX_MAX_KEYS from psql.  Build buffers
dynamically with PQExpBuffer.

22 years agoUpdate version for UNKNOWN regression fix.
Bruce Momjian [Wed, 24 Apr 2002 05:23:14 +0000 (05:23 +0000)]
Update version for UNKNOWN regression fix.

22 years agoFix UNKNOWN regression test failure.
Bruce Momjian [Wed, 24 Apr 2002 05:22:20 +0000 (05:22 +0000)]
Fix UNKNOWN regression test failure.

22 years agoFix regression for new DROP RULE syntax.
Bruce Momjian [Wed, 24 Apr 2002 03:52:16 +0000 (03:52 +0000)]
Fix regression for new DROP RULE syntax.

22 years agoAdd missing columns for UNKNOWN patch. Increment catalog version.
Bruce Momjian [Wed, 24 Apr 2002 03:09:09 +0000 (03:09 +0000)]
Add missing columns for UNKNOWN patch.  Increment catalog version.

22 years agoAdd missing SGML file.
Bruce Momjian [Wed, 24 Apr 2002 02:53:13 +0000 (02:53 +0000)]
Add missing SGML file.

22 years agoRestrict comment to the current database in order to prevent them from
Bruce Momjian [Wed, 24 Apr 2002 02:50:30 +0000 (02:50 +0000)]
Restrict comment to the current database in order to prevent them from
mysteriously disappearing.

ie.  \d+ will only ever show the comment for the current database --
which is appropriate since it can only pull comments from the current
database.

Won't break pgadmin functionality as it enforces this behaviour already.

I didn't find any regression tests for COMMENT.

Rod Taylor

22 years agoHere's a doc patch for ALTER TRIGGER RENAME. Please apply if there are
Bruce Momjian [Wed, 24 Apr 2002 02:49:50 +0000 (02:49 +0000)]
Here's a doc patch for ALTER TRIGGER RENAME. Please apply if there are
no objections.

Joe Conway

22 years agoAttached is a patch for ALTER TRIGGER RENAME per the above thread. I
Bruce Momjian [Wed, 24 Apr 2002 02:48:55 +0000 (02:48 +0000)]
Attached is a patch for ALTER TRIGGER RENAME per the above thread. I
left a stub for a future "ALTER RULE RENAME" but did not write that one
yet. Bruce, if you want to add my name for for that I'll take it and do
it later.

Joe Conway

22 years agoThe attached patch adds regression tests for setting and removing
Bruce Momjian [Wed, 24 Apr 2002 02:47:23 +0000 (02:47 +0000)]
The attached patch adds regression tests for setting and removing
default values using ALTER TABLE, on both views and tables.

(You'll need to apply the default-values-for-views patch that I sent
to -patches earlier for the regression tests to pass.)

Neil Conway <neilconway@rogers.com>

22 years agoI've improved the contributed vacuumlo command, now it behaves like all other
Bruce Momjian [Wed, 24 Apr 2002 02:45:51 +0000 (02:45 +0000)]
I've improved the contributed vacuumlo command, now it behaves like all other
postgres command line utilites e.g. supports -U, -p, -h, -?, -v, password
prompt and has a "test mode". In test mode, no large objects are removed,
just reported.

Mario Weilguni

22 years agoThe attached patch cleans up some code in pg_dump. It cuts some
Bruce Momjian [Wed, 24 Apr 2002 02:44:19 +0000 (02:44 +0000)]
The attached patch cleans up some code in pg_dump. It cuts some
unused function arguments, and makes the TableInfo struct slightly
smaller by removing an unnecessary member.

Neil Conway <neilconway@rogers.com>

22 years agoUpdate patch for DEFAULT on Views.
Bruce Momjian [Wed, 24 Apr 2002 02:42:27 +0000 (02:42 +0000)]
Update patch for DEFAULT on Views.

Apparently, you need to make two calls to appendPQExpBuffer() to
use fmtId() twice, because it uses a static buffer (thanks for
spotting this Tom).

Another revision of the patch is attached.

Neil Conway <neilconway@rogers.com>

22 years agoOops, wrong commit on previous. It was:
Bruce Momjian [Wed, 24 Apr 2002 02:40:45 +0000 (02:40 +0000)]
Oops, wrong commit on previous.  It was:

The attached patch allows views to have default values. You can't
specify a default value within a CREATE VIEW statement, it must be
done using ALTER TABLE ... ALTER COLUMN ... SET DEFAULT after the
view has already been created. Most of the hard work was done by
Tom Lane, I just patched pg_dump and updated the documentation.

Neil Conway <neilconway@rogers.com>

22 years agoDoc fix for INSERT ... (DEFAULT, ...)
Bruce Momjian [Wed, 24 Apr 2002 02:38:58 +0000 (02:38 +0000)]
Doc fix for INSERT ... (DEFAULT, ...)

Appears I forgot to update the docs earlier.

Rod Taylor

22 years agoAppears I forgot to update the docs earlier.
Bruce Momjian [Wed, 24 Apr 2002 02:31:30 +0000 (02:31 +0000)]
Appears I forgot to update the docs earlier.

Please note I have no way to test this.  Docbook doesn't like my
cygwin setup.

--
Rod Taylor

22 years agoUpdate jdbc errors_zh_TW.properties.
Bruce Momjian [Wed, 24 Apr 2002 02:30:53 +0000 (02:30 +0000)]
Update jdbc errors_zh_TW.properties.

Zhenbang Wei

22 years agoAttached is an update to contrib/dblink. Please apply if there are no
Bruce Momjian [Wed, 24 Apr 2002 02:28:28 +0000 (02:28 +0000)]
Attached is an update to contrib/dblink. Please apply if there are no
objections.

Major changes:
   - removed cursor wrap around input sql to allow for remote
     execution of INSERT/UPDATE/DELETE
   - dblink now returns a resource id instead of a real pointer
   - added several utility functions

I'm still hoping to add explicit cursor open/fetch/close support before
7.3 is released, but I need a bit more time on that.

On a somewhat unrelated topic, I never got any feedback on the
unknownin/out patch and the mb_substring patch. Is there anything else I
need to do to get those applied?

Joe Conway

22 years agoI'm at the win32 error messages once more. The DLL load thingy doesn't
Bruce Momjian [Wed, 24 Apr 2002 02:26:06 +0000 (02:26 +0000)]
I'm at the win32 error messages once more. The DLL load thingy doesn't
work on all win9x machines, so i made it go thru a l ookup table
instead, using the DLL as last resort.  I also moved this out of the
fe-misc.c file because of the size of the lookup ta ble. Who knows, we
might add more other win32 specific code there in the future.

I also fixed a small typo in the pg_config.h.win32 that made the
compiler compla in about the gnu snprintf declaration.

I tried to make this patch with psql coding style. I've successfully
tested this on win2k and win98 and it works fine (i.e. the mes sage
shows on win98 too, it didn't with the old implementation).

Magnus Naeslund

22 years agoReports missing values as bad.
Bruce Momjian [Wed, 24 Apr 2002 02:22:54 +0000 (02:22 +0000)]
Reports missing values as bad.

BAD:  INSERT INTO tab (col1, col2) VALUES ('val1');
GOOD: INSERT INTO tab (col1, col2) VALUES ('val1', 'val2');

Regress tests against DEFAULT and normal values as they're managed
slightly different.

Rod Taylor

22 years agoSpeed improvement for large object restore.
Bruce Momjian [Wed, 24 Apr 2002 02:21:04 +0000 (02:21 +0000)]
Speed improvement for large object restore.

Mario Weilguni