]> granicus.if.org Git - python/log
python
14 years agoMerge
Brian Curtin [Thu, 9 Jun 2011 00:29:53 +0000 (19:29 -0500)]
Merge

14 years agoBranch merge
Éric Araujo [Mon, 6 Jun 2011 15:11:31 +0000 (17:11 +0200)]
Branch merge

14 years agomerge 2.7.2 release branch
Benjamin Peterson [Sun, 5 Jun 2011 17:51:18 +0000 (12:51 -0500)]
merge 2.7.2 release branch

14 years agoStop adding txt files twice.
Martin v. Löwis [Sun, 5 Jun 2011 08:44:18 +0000 (10:44 +0200)]
Stop adding txt files twice.

14 years agoAdd 2.7.2 UUIDs
Martin v. Löwis [Sun, 5 Jun 2011 08:43:45 +0000 (10:43 +0200)]
Add 2.7.2 UUIDs

14 years agoRemove unnecessary executable bit on one distutils file
Éric Araujo [Sat, 4 Jun 2011 18:45:33 +0000 (20:45 +0200)]
Remove unnecessary executable bit on one distutils file

14 years agoIssue #12080: Fix a performance issue in Decimal._power_exact that caused some corner...
Mark Dickinson [Sat, 4 Jun 2011 17:24:15 +0000 (18:24 +0100)]
Issue #12080: Fix a performance issue in Decimal._power_exact that caused some corner-case Decimal.__pow__ calls to take an unreasonably long time.

14 years agoRemove outdated bit of advice (c882b5ff92d9 follow-up)
Éric Araujo [Sat, 4 Jun 2011 16:35:04 +0000 (18:35 +0200)]
Remove outdated bit of advice (c882b5ff92d9 follow-up)

14 years agoNull merge from 2.6.
Barry Warsaw [Sat, 4 Jun 2011 00:07:41 +0000 (20:07 -0400)]
Null merge from 2.6.

14 years agoReplay svn r88852.
Barry Warsaw [Sat, 4 Jun 2011 00:05:48 +0000 (20:05 -0400)]
Replay svn r88852.

14 years agoReplay svn r88850. v2.6.7
Barry Warsaw [Sat, 4 Jun 2011 00:02:47 +0000 (20:02 -0400)]
Replay svn r88850.

14 years agoIssue #12016: Add test_errorhandle() to TestBase_Mapping of
Victor Stinner [Fri, 3 Jun 2011 21:56:43 +0000 (23:56 +0200)]
Issue #12016: Add test_errorhandle() to TestBase_Mapping of
test_multibytecodec_support. Improve also error message of the
test_errorhandle() of TestBase.

14 years agoIssue #12016: Reindent decoders of HK and JP codecs
Victor Stinner [Fri, 3 Jun 2011 21:35:27 +0000 (23:35 +0200)]
Issue #12016: Reindent decoders of HK and JP codecs

14 years agomerge 2.7.2 release branch
Benjamin Peterson [Fri, 3 Jun 2011 21:17:48 +0000 (16:17 -0500)]
merge 2.7.2 release branch

14 years agoanother benefit of this change
Benjamin Peterson [Fri, 3 Jun 2011 21:17:22 +0000 (16:17 -0500)]
another benefit of this change

14 years agoDocument working dir for “make html” (#12249). Patch by Tshepang Lekhonkhobe.
Éric Araujo [Fri, 3 Jun 2011 17:25:58 +0000 (19:25 +0200)]
Document working dir for “make html” (#12249).  Patch by Tshepang Lekhonkhobe.

14 years agoFix named tuples to work with vars().
Raymond Hettinger [Fri, 3 Jun 2011 03:40:35 +0000 (20:40 -0700)]
Fix named tuples to work with vars().

14 years agosys.checkinterval() now refreshes the current countdown ticker.
Raymond Hettinger [Thu, 2 Jun 2011 01:21:42 +0000 (18:21 -0700)]
sys.checkinterval() now refreshes the current countdown ticker.

14 years agoCleanup example
Raymond Hettinger [Wed, 1 Jun 2011 23:01:21 +0000 (16:01 -0700)]
Cleanup example

14 years agoMultiple clean-ups to the docs for builtin functions.
Raymond Hettinger [Wed, 1 Jun 2011 22:50:34 +0000 (15:50 -0700)]
Multiple clean-ups to the docs for builtin functions.

* Use concrete example for dir() and eliminate the distracting doctest directives.
* Add a pure python equivalent for enumerate()
* Modify the enumerate() example to demonstrate the start argument
* Remove incorrect reference the *iterable* in the enumerate() docs.
* Downgrade the comments on input() from a warning to a note.
* Fix the iter() example to use the empty string as the terminating
  condition for file.readline().  Also, the old example was broken
  because readline() results include a newline, so 'STOP\n' would have
  been the correct terminating condition.  Even with that fix, the
  STOP example was fragile and would have lead to infinite loops with
  malformed inputs.
* Do not refer to classmethod as being "more advanced" than staticmethod.

14 years agoLink to suggestions for how to use super().
Raymond Hettinger [Wed, 1 Jun 2011 21:57:13 +0000 (14:57 -0700)]
Link to suggestions for how to use super().

14 years agoBranch merge
Éric Araujo [Wed, 1 Jun 2011 17:28:26 +0000 (19:28 +0200)]
Branch merge

14 years agomerge release tag
Benjamin Peterson [Wed, 1 Jun 2011 00:12:11 +0000 (19:12 -0500)]
merge release tag

14 years agomerge heads
Benjamin Peterson [Wed, 1 Jun 2011 00:08:12 +0000 (19:08 -0500)]
merge heads

14 years agomerge 2.7.2 release branch
Benjamin Peterson [Wed, 1 Jun 2011 00:01:23 +0000 (19:01 -0500)]
merge 2.7.2 release branch

14 years agosimply use the Python version for pyexpat.__version__ #12221
Benjamin Peterson [Tue, 31 May 2011 23:59:49 +0000 (18:59 -0500)]
simply use the Python version for pyexpat.__version__ #12221

14 years agoIssue #12085: Fix test_subprocess for my previous commit
Victor Stinner [Tue, 31 May 2011 23:57:48 +0000 (01:57 +0200)]
Issue #12085: Fix test_subprocess for my previous commit

Replace support by test_support, and add captured_stderr() function.

14 years agoadd 2.7.2 header
Benjamin Peterson [Tue, 31 May 2011 23:44:55 +0000 (18:44 -0500)]
add 2.7.2 header

14 years agoClose #12085: Fix an attribute error in subprocess.Popen destructor if the
Victor Stinner [Tue, 31 May 2011 23:03:00 +0000 (01:03 +0200)]
Close #12085: Fix an attribute error in subprocess.Popen destructor if the
constructor has failed, e.g. because of an undeclared keyword argument. Patch
written by Oleg Oshmyan.

14 years agoFix markup: arguments in a class directive are __init__ arguments, not base classes
Éric Araujo [Tue, 31 May 2011 19:50:22 +0000 (21:50 +0200)]
Fix markup: arguments in a class directive are __init__ arguments, not base classes

14 years agoFix error message to use the Python name instead of the C name
Éric Araujo [Tue, 31 May 2011 12:08:40 +0000 (14:08 +0200)]
Fix error message to use the Python name instead of the C name

14 years agoIssue #12057: Add tests for ISO 2022 codecs
Victor Stinner [Mon, 30 May 2011 21:58:21 +0000 (23:58 +0200)]
Issue #12057: Add tests for ISO 2022 codecs

iso2022_jp, iso2022_jp_2 and iso2022_kr

14 years agoIssue #1195: fix the issue number of the NEWS entry
Victor Stinner [Mon, 30 May 2011 21:49:13 +0000 (23:49 +0200)]
Issue #1195: fix the issue number of the NEWS entry

14 years agoIssue #12016: my_fgets() now always clears errors before calling fgets(). Fix
Victor Stinner [Mon, 30 May 2011 21:44:13 +0000 (23:44 +0200)]
Issue #12016: my_fgets() now always clears errors before calling fgets(). Fix
the following case: sys.stdin.read() stopped with CTRL+d (end of file),
raw_input() interrupted by CTRL+c.

14 years agoAdded tag v2.7.2rc1 for changeset f48756685406
Benjamin Peterson [Sun, 29 May 2011 21:50:40 +0000 (16:50 -0500)]
Added tag v2.7.2rc1 for changeset f48756685406

14 years agobump to 2.7.2rc1 v2.7.2rc1
Benjamin Peterson [Sun, 29 May 2011 21:50:27 +0000 (16:50 -0500)]
bump to 2.7.2rc1

14 years agoBranch merge
Éric Araujo [Sun, 29 May 2011 15:57:29 +0000 (17:57 +0200)]
Branch merge

14 years agoIssue #12205: Fix test_subprocess failure due to uninstalled test data.
Ned Deily [Sun, 29 May 2011 09:36:17 +0000 (02:36 -0700)]
Issue #12205: Fix test_subprocess failure due to uninstalled test data.

14 years agoRe-add missing doc stub for the distutils check command
Éric Araujo [Sat, 28 May 2011 22:31:30 +0000 (00:31 +0200)]
Re-add missing doc stub for the distutils check command

14 years agoBackport doc improvements for distutils.cmd.Command (#9223).
Éric Araujo [Sat, 28 May 2011 22:11:59 +0000 (00:11 +0200)]
Backport doc improvements for distutils.cmd.Command (#9223).

Original commit by Georg Brandl.

14 years agoFix test_distutils when sys.dont_write_bytecode is true (#9831).
Éric Araujo [Sat, 28 May 2011 21:21:19 +0000 (23:21 +0200)]
Fix test_distutils when sys.dont_write_bytecode is true (#9831).

The tests now pass all combinations of -O/-OO and -B.  See also #7071
and #6292 for previous variations on the same theme.

14 years agoIssue #11217: For 64-bit/32-bit Mac OS X universal framework builds,
Ned Deily [Sat, 28 May 2011 12:56:14 +0000 (05:56 -0700)]
Issue #11217: For 64-bit/32-bit Mac OS X universal framework builds,
ensure "make install" creates symlinks in --prefix bin for the "-32"
files in the framework bin directory like the installer does.

14 years agoNearly null-merge 2.5.6
Martin v. Löwis [Sat, 28 May 2011 12:14:17 +0000 (14:14 +0200)]
Nearly null-merge 2.5.6

14 years agoNearly null-merge 2.5.6
Martin v. Löwis [Sat, 28 May 2011 12:13:32 +0000 (14:13 +0200)]
Nearly null-merge 2.5.6

14 years agomerge 2.5.6c1 tag
Martin v. Löwis [Sat, 28 May 2011 12:06:55 +0000 (14:06 +0200)]
merge 2.5.6c1 tag

14 years agoAdded tag v2.5.6c1 for changeset a87c7b96672b
Martin v. Löwis [Sat, 28 May 2011 12:05:31 +0000 (14:05 +0200)]
Added tag v2.5.6c1 for changeset a87c7b96672b

14 years agoAdded tag v2.5.6 for changeset de34c7b097e8
Martin v. Löwis [Sat, 28 May 2011 12:00:37 +0000 (14:00 +0200)]
Added tag v2.5.6 for changeset de34c7b097e8

14 years agor88840: Prepare for 2.5.6. v2.5.6
Martin v. Löwis [Sat, 28 May 2011 11:58:36 +0000 (13:58 +0200)]
r88840: Prepare for 2.5.6.

14 years agor88828: Fix year.
Martin v. Löwis [Sat, 28 May 2011 11:57:28 +0000 (13:57 +0200)]
r88828: Fix year.

14 years agor88824: Prepare for 2.5.6c1. v2.5.6c1
Martin v. Löwis [Sat, 28 May 2011 11:56:22 +0000 (13:56 +0200)]
r88824: Prepare for 2.5.6c1.

14 years agoIssue #9670: Increase the default stack size for secondary threads on
Ned Deily [Sat, 28 May 2011 07:11:54 +0000 (00:11 -0700)]
Issue #9670: Increase the default stack size for secondary threads on
Mac OS X and FreeBSD to reduce the chances of a crash instead of a
"maximum recursion depth" RuntimeError exception.
(patch by Ronald Oussoren)

14 years agomerge heads
Benjamin Peterson [Thu, 26 May 2011 14:57:21 +0000 (09:57 -0500)]
merge heads

14 years agoraise an ValueError in getvalue() on closed StringIO (closes #12161)
Benjamin Peterson [Thu, 26 May 2011 14:56:41 +0000 (09:56 -0500)]
raise an ValueError in getvalue() on closed StringIO (closes #12161)

Thanks for Catalin Iacob for the patch.

14 years agoBranch merge
Éric Araujo [Thu, 26 May 2011 14:52:22 +0000 (16:52 +0200)]
Branch merge

14 years agoClose #12182: Fix pydoc.HTMLDoc.multicolumn() if Python uses the new (true)
Victor Stinner [Thu, 26 May 2011 11:37:25 +0000 (13:37 +0200)]
Close #12182: Fix pydoc.HTMLDoc.multicolumn() if Python uses the new (true)
division (python -Qnew). Patch written by Ralf W. Grosse-Kunstleve.

14 years agoIDLE: #6378: Further adjust idle.bat to start associated Python
Kurt B. Kaiser [Thu, 26 May 2011 02:36:51 +0000 (22:36 -0400)]
IDLE: #6378: Further adjust idle.bat to start associated Python

14 years agoIssue #12175: RawIOBase.readall() now returns None if read() returns None.
Victor Stinner [Wed, 25 May 2011 20:52:37 +0000 (22:52 +0200)]
Issue #12175: RawIOBase.readall() now returns None if read() returns None.

14 years agoIssue #12175: FileIO.readall() now raises a ValueError instead of an IOError if
Victor Stinner [Wed, 25 May 2011 20:15:36 +0000 (22:15 +0200)]
Issue #12175: FileIO.readall() now raises a ValueError instead of an IOError if
the file is closed.

14 years agoFix display of html.parser.HTMLParser.feed docstrin
Éric Araujo [Wed, 25 May 2011 16:11:43 +0000 (18:11 +0200)]
Fix display of html.parser.HTMLParser.feed docstrin

14 years agoAdd missing name in pkgutil.__all__
Éric Araujo [Wed, 25 May 2011 16:11:24 +0000 (18:11 +0200)]
Add missing name in pkgutil.__all__

14 years agoBranch merge
Éric Araujo [Wed, 25 May 2011 16:06:35 +0000 (18:06 +0200)]
Branch merge

14 years agoFix two typos
Éric Araujo [Wed, 25 May 2011 16:06:16 +0000 (18:06 +0200)]
Fix two typos

14 years agoIssue #12057: Add cjkencodings directory to the Makefile and Tools/msi/msi.py
Victor Stinner [Tue, 24 May 2011 23:19:57 +0000 (01:19 +0200)]
Issue #12057: Add cjkencodings directory to the Makefile and Tools/msi/msi.py

14 years agoIssue #12057: Add tests for the HZ encoding
Victor Stinner [Tue, 24 May 2011 22:19:07 +0000 (00:19 +0200)]
Issue #12057: Add tests for the HZ encoding

14 years agoIssue #1441530: In imaplib, use makefile() to wrap the SSL socket to avoid
Charles-François Natali [Tue, 24 May 2011 21:10:54 +0000 (23:10 +0200)]
Issue #1441530: In imaplib, use makefile() to wrap the SSL socket to avoid
heap fragmentation and MemoryError with some malloc implementations.

14 years agoIssue #12100: Don't reset incremental encoders of CJK codecs at each call to
Victor Stinner [Tue, 24 May 2011 20:29:13 +0000 (22:29 +0200)]
Issue #12100: Don't reset incremental encoders of CJK codecs at each call to
their encode() method anymore, but continue to call the reset() method if the
final argument is True.

14 years agouse '->' to indicate return values
Benjamin Peterson [Tue, 24 May 2011 17:42:51 +0000 (12:42 -0500)]
use '->' to indicate return values

14 years agomust clear an AttributeError if it is set
Benjamin Peterson [Mon, 23 May 2011 23:17:55 +0000 (18:17 -0500)]
must clear an AttributeError if it is set

14 years agohandle old-style instances
Benjamin Peterson [Mon, 23 May 2011 22:11:21 +0000 (17:11 -0500)]
handle old-style instances

14 years agocorrectly lookup __dir__
Benjamin Peterson [Mon, 23 May 2011 21:11:05 +0000 (16:11 -0500)]
correctly lookup __dir__

14 years agoNull merge from 2.6 branch.
Barry Warsaw [Mon, 23 May 2011 19:29:24 +0000 (15:29 -0400)]
Null merge from 2.6 branch.

14 years agoReplay changeset 70249:b571c7a8cf2e from fubar branch. Original commit
Barry Warsaw [Mon, 23 May 2011 19:27:52 +0000 (15:27 -0400)]
Replay changeset 70249:b571c7a8cf2e from fubar branch.  Original commit
message:

Merging post 2.6.7rc2 changes from Subversion.

14 years agoReplay changeset 70248:c714e2f92f63 from fubar branch. Original commit
Barry Warsaw [Mon, 23 May 2011 19:26:11 +0000 (15:26 -0400)]
Replay changeset 70248:c714e2f92f63 from fubar branch.  Original commit
message:

Cross-port changes for 2.6.7rc2 from the Subversion branch.

14 years agoReplay changeset 70238:03e488b5c009 from fubar branch. Original commit
Barry Warsaw [Mon, 23 May 2011 19:22:56 +0000 (15:22 -0400)]
Replay changeset 70238:03e488b5c009 from fubar branch.  Original commit
message:

Reconcile with the 2.6svn branch.  The 2.6.7 release will be made from
Subversion, but there were differences, so this brings them in sync.  These
changes should *not* propagate to any newer versions.

14 years agotest_codecs now removes the temporay file (created by the test)
Victor Stinner [Mon, 23 May 2011 14:19:31 +0000 (16:19 +0200)]
test_codecs now removes the temporay file (created by the test)

14 years agoIssue 12003: fixing error in xrange alternative sample
Eli Bendersky [Mon, 23 May 2011 03:10:26 +0000 (06:10 +0300)]
Issue 12003: fixing error in xrange alternative sample

14 years agoForward merge.
Barry Warsaw [Mon, 23 May 2011 01:17:49 +0000 (21:17 -0400)]
Forward merge.

14 years agoThese files have Windows line endings in 2.6.
Barry Warsaw [Mon, 23 May 2011 01:16:55 +0000 (21:16 -0400)]
These files have Windows line endings in 2.6.

14 years agoIssue #12012: test_ssl uses test_support.import_module()
Victor Stinner [Sun, 22 May 2011 11:22:28 +0000 (13:22 +0200)]
Issue #12012: test_ssl uses test_support.import_module()

Skip the whole file if the SSL module is missing. It was already the case,
except that the SkipTest exception was raised in test_main().

This commit fixes an error in test_ssl if the ssl module is missing.

14 years agoIssue 12126: removing incorrect claim about return value of select
Eli Bendersky [Sun, 22 May 2011 03:49:01 +0000 (06:49 +0300)]
Issue 12126: removing incorrect claim about return value of select

14 years agoSimplify example
Raymond Hettinger [Sat, 21 May 2011 16:39:57 +0000 (09:39 -0700)]
Simplify example

14 years agoIssue #12124: zipimport doesn't keep a reference to zlib.decompress() anymore
Victor Stinner [Sat, 21 May 2011 00:13:22 +0000 (02:13 +0200)]
Issue #12124: zipimport doesn't keep a reference to zlib.decompress() anymore
to be able to unload the module.

14 years agothis should actually be an IOError
Benjamin Peterson [Fri, 20 May 2011 16:49:06 +0000 (11:49 -0500)]
this should actually be an IOError

14 years agoadd example for not using access
Benjamin Peterson [Fri, 20 May 2011 16:41:13 +0000 (11:41 -0500)]
add example for not using access

14 years ago#12072: add missing parenthesis in the doc. Patch by Sandro Tosi.
Ezio Melotti [Fri, 20 May 2011 12:04:38 +0000 (15:04 +0300)]
#12072: add missing parenthesis in the doc.  Patch by Sandro Tosi.

14 years agoMinor code cleanup.
Raymond Hettinger [Wed, 18 May 2011 22:28:50 +0000 (17:28 -0500)]
Minor code cleanup.

14 years agomerge heads
Benjamin Peterson [Tue, 17 May 2011 23:32:26 +0000 (18:32 -0500)]
merge heads

14 years agostop using the old brain-dead interface for providing attributes/methods
Benjamin Peterson [Tue, 17 May 2011 23:31:20 +0000 (18:31 -0500)]
stop using the old brain-dead interface for providing attributes/methods

This closes #12099.

14 years agoIssue #12057: Fix .hgeol and test_multibytecodec_support for the conversion of
Victor Stinner [Tue, 17 May 2011 13:49:56 +0000 (15:49 +0200)]
Issue #12057: Fix .hgeol and test_multibytecodec_support for the conversion of
the CJK encoding testcase BLOB into multiple text files.

14 years ago(backport) Fixes #11088: IDLE crashes when using F5 to run a script on OSX with Tk 8.5
Ronald Oussoren [Tue, 17 May 2011 13:13:46 +0000 (15:13 +0200)]
(backport) Fixes #11088: IDLE crashes when using F5 to run a script on OSX with Tk 8.5
Without this patch IDLE will crash reliably on OSX when Tkinter
is linked to TkCocoa 8.5.x.

To reproduce:

* Create a new file (script.py) with the following two lines:

x = raw_input('prompt: ')
print x

* Save the script

* Run the script using the F5 keyboard shortcut
  (running from the menu works fine)

The patch is a fairly crude hack, but we haven't found a better
workaround for this Tk bug yet.

14 years ago(backport)Fix #10154 and #10090: locale normalizes the UTF-8 encoding to "UTF-8"...
Ronald Oussoren [Tue, 17 May 2011 11:22:30 +0000 (13:22 +0200)]
(backport)Fix #10154 and #10090: locale normalizes the UTF-8 encoding to "UTF-8" instead of "UTF8"

On MacOSX and OpenBSD (and possibly other BSDs) "en_US.UTF-8" is a valid locale
while "en_US.UTF8" is not. As the former works on Linux as well it is better
to normalize to that value.

14 years ago#12092: backport rephrasing of a paragraph in the tutorial.
Ezio Melotti [Tue, 17 May 2011 02:39:22 +0000 (05:39 +0300)]
#12092: backport rephrasing of a paragraph in the tutorial.

14 years ago#12093: fix typo in struct doc. Patch by Sandro Tosi.
Ezio Melotti [Tue, 17 May 2011 02:17:35 +0000 (05:17 +0300)]
#12093: fix typo in struct doc. Patch by Sandro Tosi.

14 years agoFix closes issue #12088 - fixes the tarfile.extractall issue when the
Senthil Kumaran [Tue, 17 May 2011 02:12:18 +0000 (10:12 +0800)]
Fix closes issue #12088 - fixes the tarfile.extractall  issue when the
symlinks/hardlink was broken. It handles now in a graceful manner (No exception
is raised, behavior similar GNU tar).

14 years agoIssue #11614: Fix test_linecache, cjkencodings_test.py doesn't exist anymore
Victor Stinner [Mon, 16 May 2011 23:18:33 +0000 (01:18 +0200)]
Issue #11614: Fix test_linecache, cjkencodings_test.py doesn't exist anymore

14 years agoIssue #12057: Convert CJK encoding testcase BLOB into multiple text files
Victor Stinner [Mon, 16 May 2011 15:16:18 +0000 (17:16 +0200)]
Issue #12057: Convert CJK encoding testcase BLOB into multiple text files

14 years agoNEWS entry for fix of issue #9516
Ronald Oussoren [Sun, 15 May 2011 14:51:10 +0000 (16:51 +0200)]
NEWS entry for fix of issue #9516

14 years agoIssue #9516: avoid errors in sysconfig when MACOSX_DEPLOYMENT_TARGET is set in shell.
Ronald Oussoren [Sun, 15 May 2011 14:44:27 +0000 (16:44 +0200)]
Issue #9516: avoid errors in sysconfig when MACOSX_DEPLOYMENT_TARGET is set in shell.

Without this patch python will fail to start properly when the environment
variable MACOSX_DEPLOYMENT_TARGET is set on MacOSX and has a value that is
not compatible with the value during Python's build. This is caused by code
in sysconfig that was only meant to be used in disutils.

14 years agoPort #6498 fix: fix several misspellings of "SystemExit" as "SystemError".
Georg Brandl [Sun, 15 May 2011 06:50:32 +0000 (08:50 +0200)]
Port #6498 fix: fix several misspellings of "SystemExit" as "SystemError".

14 years agoFixes Issue #12059: Properly handle missing hash functions even when
Gregory P. Smith [Sat, 14 May 2011 22:07:53 +0000 (15:07 -0700)]
Fixes Issue #12059: Properly handle missing hash functions even when
the expected builtin modules are not present.

This includes a unittest for __get_builtin_constructor() in the face
of such an error.