Cristy [Sun, 16 Sep 2018 00:50:58 +0000 (20:50 -0400)]
...
Cristy [Sat, 15 Sep 2018 19:15:04 +0000 (15:15 -0400)]
https://github.com/ImageMagick/ImageMagick/issues/1307
Cristy [Sat, 15 Sep 2018 19:10:19 +0000 (15:10 -0400)]
https://github.com/ImageMagick/ImageMagick/issues/1307
Cristy [Sat, 15 Sep 2018 19:08:33 +0000 (15:08 -0400)]
https://github.com/ImageMagick/ImageMagick/issues/1307
Ilya Shipitsin [Sat, 15 Sep 2018 18:50:02 +0000 (23:50 +0500)]
MagickCore/attribute.c: remove redundant check (#1313)
atDepth is assigned "true" in line 324
Cristy [Sat, 15 Sep 2018 17:36:46 +0000 (13:36 -0400)]
https://github.com/ImageMagick/ImageMagick/issues/1305
Dirk Lemstra [Sat, 15 Sep 2018 14:12:22 +0000 (16:12 +0200)]
Corrected patch.
Dirk Lemstra [Sat, 15 Sep 2018 14:09:33 +0000 (16:09 +0200)]
Added support for arithmetic coding to the jpeg encoder.
Dirk Lemstra [Sat, 15 Sep 2018 13:28:06 +0000 (15:28 +0200)]
Fixed several issues with FormatMagickCaption.
Dirk Lemstra [Sat, 15 Sep 2018 13:23:12 +0000 (15:23 +0200)]
Fixed build.
Dirk Lemstra [Sat, 15 Sep 2018 13:02:37 +0000 (15:02 +0200)]
Report libjpeg-turbo version.
Cristy [Fri, 14 Sep 2018 23:28:23 +0000 (19:28 -0400)]
...
Ilya Shipitsin [Fri, 14 Sep 2018 16:20:54 +0000 (21:20 +0500)]
coders/xpm.c: remove unused check
found by coverity
there's already check against NULL in line 382
Dirk Lemstra [Fri, 14 Sep 2018 14:57:47 +0000 (16:57 +0200)]
Reverted patch.
Dirk Lemstra [Fri, 14 Sep 2018 12:59:19 +0000 (14:59 +0200)]
Minor refactoring.
Ilya Shipitsin [Fri, 14 Sep 2018 09:47:27 +0000 (14:47 +0500)]
MagickCore/pixel-accessor.h: resolve null pointer dereference
found by coverity
Dirk Lemstra [Fri, 14 Sep 2018 09:31:09 +0000 (11:31 +0200)]
Added DrawGetTypeMetrics.
Dirk Lemstra [Fri, 14 Sep 2018 07:59:20 +0000 (09:59 +0200)]
Also call png_set_chunk_malloc_max when png:chunk-malloc-max is not set to avoid low build in limit #1301.
Dirk Lemstra [Fri, 14 Sep 2018 07:45:18 +0000 (09:45 +0200)]
Fixed possible multithreading issue.
Ilya Shipitsin [Thu, 13 Sep 2018 09:21:30 +0000 (14:21 +0500)]
coders/pgx.c: remove unused code
found by coverity
there's already check against NULL in line 176
Ilya Shipitsin [Wed, 12 Sep 2018 12:23:46 +0000 (17:23 +0500)]
coders/cut.c: remove unused code
found by coverity
clone_info is assigned NULL at line 317
Ilya Shipitsin [Wed, 12 Sep 2018 07:53:01 +0000 (12:53 +0500)]
MagickCore/annotate.c: remove unneeded check
line 631:
if ((width <= image->columns) || (s == (char *) NULL))
so, "s" cannot be NULL
Ilya Shipitsin [Sun, 9 Sep 2018 16:19:57 +0000 (21:19 +0500)]
coders/cut.c: remove unused code
found by coverity
pallete is assigned NULL in line 372
Cristy [Sun, 9 Sep 2018 23:48:37 +0000 (19:48 -0400)]
...
Cristy [Sun, 9 Sep 2018 23:46:34 +0000 (19:46 -0400)]
...
Cristy [Sun, 9 Sep 2018 23:34:39 +0000 (19:34 -0400)]
...
Cristy [Sun, 9 Sep 2018 19:37:28 +0000 (15:37 -0400)]
...
Cristy [Sun, 9 Sep 2018 18:53:58 +0000 (14:53 -0400)]
https://imagemagick.org/discourse-server/viewtopic.php?f=3&t=34675
Cristy [Sun, 9 Sep 2018 18:48:29 +0000 (14:48 -0400)]
https://imagemagick.org/discourse-server/viewtopic.php?f=3&t=34675
Cristy [Sun, 9 Sep 2018 18:30:52 +0000 (14:30 -0400)]
...
Cristy [Sun, 9 Sep 2018 16:38:32 +0000 (12:38 -0400)]
...
Cristy [Sun, 9 Sep 2018 16:09:53 +0000 (12:09 -0400)]
...
Cristy [Sun, 9 Sep 2018 14:29:56 +0000 (10:29 -0400)]
...
Cristy [Sun, 9 Sep 2018 14:28:40 +0000 (10:28 -0400)]
...
Cristy [Sun, 9 Sep 2018 00:45:44 +0000 (20:45 -0400)]
https://github.com/ImageMagick/ImageMagick/issues/1296
Cristy [Sun, 9 Sep 2018 00:41:41 +0000 (20:41 -0400)]
https://github.com/ImageMagick/ImageMagick/issues/1279
Cristy [Sat, 8 Sep 2018 23:40:47 +0000 (19:40 -0400)]
https://github.com/ImageMagick/ImageMagick/issues/1279
Dirk Lemstra [Sat, 8 Sep 2018 17:38:26 +0000 (19:38 +0200)]
Fixed bug in screenshot coder reported in #1276.
Cristy [Sat, 8 Sep 2018 17:35:15 +0000 (13:35 -0400)]
...
Cristy [Sat, 8 Sep 2018 17:20:17 +0000 (13:20 -0400)]
...
Cristy [Sat, 8 Sep 2018 17:01:43 +0000 (13:01 -0400)]
...
Cristy [Sat, 8 Sep 2018 13:58:47 +0000 (09:58 -0400)]
...
Ilya Shipitsin [Sat, 8 Sep 2018 13:56:49 +0000 (18:56 +0500)]
MagickCore/xwindow.c: remove not needed check (#1292)
found by cppcheck
there's already check in line 3367
https://github.com/ImageMagick/ImageMagick/blob/master/MagickCore/xwindow.c#L3367
Cristy [Sat, 8 Sep 2018 13:49:48 +0000 (09:49 -0400)]
https://github.com/ImageMagick/ImageMagick/issues/1295
Dirk Lemstra [Fri, 7 Sep 2018 08:43:41 +0000 (10:43 +0200)]
Fixed reading the number of layers.
Dirk Lemstra [Fri, 7 Sep 2018 07:25:17 +0000 (09:25 +0200)]
Minor refactoring.
Dirk Lemstra [Fri, 7 Sep 2018 06:40:07 +0000 (08:40 +0200)]
Fixed tiff compression issue reported in #1297 and fixed support for quantum:polarity.
Cristy [Wed, 5 Sep 2018 22:39:54 +0000 (18:39 -0400)]
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=8885
Robin [Tue, 4 Sep 2018 21:01:49 +0000 (22:01 +0100)]
Add R's magick package to the list
Cristy [Mon, 3 Sep 2018 23:45:54 +0000 (19:45 -0400)]
https://github.com/ImageMagick/ImageMagick/issues/1273
Dirk Lemstra [Mon, 3 Sep 2018 18:38:50 +0000 (20:38 +0200)]
Some minor code style tweaks.
Sergii Rudchenko [Mon, 3 Sep 2018 18:33:15 +0000 (20:33 +0200)]
Align pixel orientation with exif:Orientation in HEIC decoder (#1233)
* Align pixel orientation with exif:Orientation in HEIC decoder
It turns out that in HEIC the pixels are never rotated and the metadata only
indicates the orientation of the sensor when the photo was taken.
Hence, there was a discrepancy between `Image->orientation` and actual pixel
orientation in images loaded with the `heic` coder. Particularly, this led to
incorrect behavior of the `-auto-orient` which in this case tried to compensate
non-existing pixel rotation.
https://github.com/ImageMagick/ImageMagick/issues/1232
Cristy [Mon, 3 Sep 2018 12:39:13 +0000 (08:39 -0400)]
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=10197
Cristy [Mon, 3 Sep 2018 12:18:28 +0000 (08:18 -0400)]
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=10202
Cristy [Sun, 2 Sep 2018 22:34:14 +0000 (18:34 -0400)]
...
Cristy [Sun, 2 Sep 2018 22:28:19 +0000 (18:28 -0400)]
...
Cristy [Sun, 2 Sep 2018 21:25:36 +0000 (17:25 -0400)]
...
Cristy [Sun, 2 Sep 2018 11:38:05 +0000 (07:38 -0400)]
...
Ilya Shipitsin [Sun, 2 Sep 2018 10:18:08 +0000 (15:18 +0500)]
MagickWand/drawing-wand.c: resolve several null pointer dereferences
found by cppcheck
[MagickWand/drawing-wand.c:177] -> [MagickWand/drawing-wand.c:175]: (warning) Either the condition 'wand!=(DrawingWand*)NULL' is redundant or there is possible null pointer dereference: wand.
[MagickWand/drawing-wand.c:4540] -> [MagickWand/drawing-wand.c:4538]: (warning) Either the condition 'wand!=(DrawingWand*)NULL' is redundant or there is possible null pointer dereference: wand.
[MagickWand/drawing-wand.c:4682] -> [MagickWand/drawing-wand.c:4680]: (warning) Either the condition 'wand!=(DrawingWand*)NULL' is redundant or there is possible null pointer dereference: wand.
Cristy [Sat, 1 Sep 2018 19:32:29 +0000 (15:32 -0400)]
...
Cristy [Sat, 1 Sep 2018 18:39:31 +0000 (14:39 -0400)]
...
Ilya Shipitsin [Sat, 1 Sep 2018 16:56:56 +0000 (21:56 +0500)]
MagickCore/draw.c: check against null is not needed here
Dirk Lemstra [Sat, 1 Sep 2018 17:25:49 +0000 (19:25 +0200)]
Use the width and height of the extract area when no size is specified.
Dirk Lemstra [Sat, 1 Sep 2018 16:43:11 +0000 (18:43 +0200)]
Removed pragma messages as requested in #1275.
Cristy [Sat, 1 Sep 2018 15:20:40 +0000 (11:20 -0400)]
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=9435
Cristy [Sat, 1 Sep 2018 14:49:00 +0000 (10:49 -0400)]
https://github.com/ImageMagick/ImageMagick/issues/1273
Cristy [Sat, 1 Sep 2018 11:49:12 +0000 (07:49 -0400)]
https://github.com/ImageMagick/ImageMagick/issues/1285
Cristy [Sat, 1 Sep 2018 11:29:53 +0000 (07:29 -0400)]
https://github.com/ImageMagick/ImageMagick/issues/1286
Cristy [Fri, 31 Aug 2018 00:04:20 +0000 (20:04 -0400)]
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=10106
Cristy [Thu, 30 Aug 2018 23:50:53 +0000 (19:50 -0400)]
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=10085
Cristy [Thu, 30 Aug 2018 23:43:20 +0000 (19:43 -0400)]
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=10115
Ilya Shipitsin [Thu, 30 Aug 2018 10:16:20 +0000 (15:16 +0500)]
resolve several null pointer dereferences
found by cppcheck
[MagickCore/draw.c:881] -> [MagickCore/draw.c:879]: (warning) Either the condition 'draw_info!=(DrawInfo*)NULL' is redundant or there is possible null pointer dereference: draw_info.
[MagickCore/fx.c:3966] -> [MagickCore/fx.c:3964]: (warning) Either the condition 'image!=(Image*)NULL' is redundant or there is possible null pointer dereference: image.
[MagickCore/fx.c:5009] -> [MagickCore/fx.c:5006]: (warning) Either the condition 'right_image!=(const Image*)NULL' is redundant or there is possible null pointer dereference: right_image.
[MagickCore/montage.c:168] -> [MagickCore/montage.c:166]: (warning) Either the condition 'montage_info!=(MontageInfo*)NULL' is redundant or there is possible null pointer dereference: montage_info.
[MagickCore/montage.c:416] -> [MagickCore/montage.c:415]: (warning) Either the condition 'master_list==(Image**)NULL' is redundant or there is possible null pointer dereference: image_list.
[MagickCore/nt-base.c:1792] -> [MagickCore/nt-base.c:1797]: (warning) Either the condition 'entry!=(DIR*)NULL' is redundant or there is possible null pointer dereference: entry.
[MagickWand/drawing-wand.c:177] -> [MagickWand/drawing-wand.c:175]: (warning) Either the condition 'wand!=(DrawingWand*)NULL' is redundant or there is possible null pointer dereference: wand.
[MagickWand/drawing-wand.c:4540] -> [MagickWand/drawing-wand.c:4538]: (warning) Either the condition 'wand!=(DrawingWand*)NULL' is redundant or there is possible null pointer dereference: wand.
[MagickWand/drawing-wand.c:4682] -> [MagickWand/drawing-wand.c:4680]: (warning) Either the condition 'wand!=(DrawingWand*)NULL' is redundant or there is possible null pointer dereference: wand.
[coders/msl.c:575] -> [coders/msl.c:555]: (warning) Either the condition 'image==(Image*)NULL' is redundant or there is possible null pointer dereference: image.
Ilya Shipitsin [Thu, 30 Aug 2018 06:55:46 +0000 (11:55 +0500)]
MagickCore/constitute.c: resolve possible null pointer dereference
found by cppcheck
[MagickCore/constitute.c:1074] -> [MagickCore/constitute.c:1071]: (warning) Either the condition 'image!=(Image*)NULL' is redundant or there is possible null pointer dereference: image.
Cristy [Wed, 29 Aug 2018 15:00:37 +0000 (11:00 -0400)]
...
Cristy [Tue, 28 Aug 2018 23:58:34 +0000 (19:58 -0400)]
..
Cristy [Tue, 28 Aug 2018 23:57:49 +0000 (19:57 -0400)]
...
Cristy [Tue, 28 Aug 2018 23:48:01 +0000 (19:48 -0400)]
...
Cristy [Tue, 28 Aug 2018 23:42:33 +0000 (19:42 -0400)]
...
Florian Margaine [Sun, 19 Aug 2018 21:42:57 +0000 (23:42 +0200)]
Fix compiler warning about unused function.
When neither of those compiler macros are available, the compiler is going to spit a warning about the unused static function.
```
coders/miff.c:164:14: warning: 'AcquireCompressionMemory' defined but not used [-Wunused-function]
static void *AcquireCompressionMemory(void *context,const size_t items,
```
Fix this by making sure the static function is only defined when it's going to be used.
Dirk Lemstra [Tue, 28 Aug 2018 18:52:16 +0000 (20:52 +0200)]
Return UndefinedOptionFlag instead of -1.
Cristy [Tue, 28 Aug 2018 12:29:32 +0000 (08:29 -0400)]
https://www.imagemagick.org/discourse-server/viewtopic.php?f=1&t=34639
Cristy [Tue, 28 Aug 2018 11:50:26 +0000 (07:50 -0400)]
...
Cristy [Tue, 28 Aug 2018 11:48:30 +0000 (07:48 -0400)]
https://www.imagemagick.org/discourse-server/viewtopic.php?f=3&t=34644
Cristy [Mon, 27 Aug 2018 23:40:31 +0000 (19:40 -0400)]
...
Cristy [Mon, 27 Aug 2018 23:35:15 +0000 (19:35 -0400)]
https://github.com/ImageMagick/ImageMagick/issues/1269
Cristy [Mon, 27 Aug 2018 23:29:51 +0000 (19:29 -0400)]
https://github.com/ImageMagick/ImageMagick/issues/1269
Dirk Lemstra [Mon, 27 Aug 2018 19:34:21 +0000 (21:34 +0200)]
Fixed incorrect blob referencing.
Cristy [Mon, 27 Aug 2018 19:24:51 +0000 (15:24 -0400)]
...
Cristy [Mon, 27 Aug 2018 19:24:10 +0000 (15:24 -0400)]
https://github.com/ImageMagick/ImageMagick/issues/1268
Cristy [Mon, 27 Aug 2018 19:21:20 +0000 (15:21 -0400)]
...
Cristy [Mon, 27 Aug 2018 19:20:45 +0000 (15:20 -0400)]
https://github.com/ImageMagick/ImageMagick/issues/1267
Dirk Lemstra [Mon, 27 Aug 2018 05:23:44 +0000 (07:23 +0200)]
Added missing memory checks.
Cristy [Sun, 26 Aug 2018 23:47:07 +0000 (19:47 -0400)]
...
Cristy [Sun, 26 Aug 2018 17:51:53 +0000 (13:51 -0400)]
Advance past '{' of '{}' glob expression
Cristy [Sun, 26 Aug 2018 15:44:40 +0000 (11:44 -0400)]
https://www.imagemagick.org/discourse-server/viewtopic.php?f=3&t=34636
Cristy [Sun, 26 Aug 2018 13:53:04 +0000 (09:53 -0400)]
...
Cristy [Sun, 26 Aug 2018 13:52:01 +0000 (09:52 -0400)]
...
Cristy [Sun, 26 Aug 2018 12:01:30 +0000 (08:01 -0400)]
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=10058
Dirk Lemstra [Sun, 26 Aug 2018 09:19:36 +0000 (11:19 +0200)]
Revert alpha multiplication patch.
Dirk Lemstra [Sun, 26 Aug 2018 07:48:24 +0000 (09:48 +0200)]
Minor optimization.