Tom Lane [Mon, 14 Aug 2006 12:39:55 +0000 (12:39 +0000)]
Remove hash_destroy calls in hash_create's failure paths. As noted by
a Coverity warning, these are risky since the hashtable isn't necessarily
fully set up yet. They're unnecessary anyway: a deletable hashtable
should be in a memory context that will be cleared following elog(ERROR).
Per report from Martijn van Oosterhout.
Tom Lane [Mon, 14 Aug 2006 00:46:53 +0000 (00:46 +0000)]
Get rid of "lookahead" functionality in plpgsql's yylex() function,
and instead make the grammar production for the RETURN statement do the
heavy lifting. The lookahead idea was copied from the main parser, but
it does not work in plpgsql's parser because here gram.y looks explicitly
at the scanner's yytext variable, which will be out of sync after a
failed lookahead step. A minimal example is
create or replace function foo() returns void language plpgsql as '
begin
perform return foo bar;
end';
which can be seen by testing to deliver "foo foo bar" to the main parser
instead of the expected "return foo bar". This isn't a huge bug since
RETURN is not found in the main grammar, but it could bite someone who
tried to use "return" as an identifier.
Back-patch to 8.1. Bug exists further back, but HEAD patch doesn't apply
cleanly, and given the lack of field complaints it doesn't seem worth
the effort to develop adjusted patches.
Tom Lane [Sun, 13 Aug 2006 22:18:08 +0000 (22:18 +0000)]
Fix core dump in duration logging for a V3-protocol Execute message
when what's being executed is a COMMIT or ROLLBACK. Per report from
Sergey Koposov. Backpatch to 8.1; 8.0 and before don't have the bug
due to lack of any logging at all here.
Tom Lane [Sun, 13 Aug 2006 20:39:07 +0000 (20:39 +0000)]
If test postmaster fails to start within 60 seconds, try to kill -9 it
so that it won't interfere with later trials. Per recent buildfarm
experience. Anyone know how to do this on Windows?
Tom Lane [Sun, 13 Aug 2006 19:31:06 +0000 (19:31 +0000)]
Extend 'guc' regression test to check manipulations of datestyle as
well as vacuum_cost_delay. Since datestyle is a string variable,
this exercises memory allocation issues that might not appear when
modifying an integer GUC variable. Also, we can observe the side
effects of changing datestyle to check that assign hooks are called
at the right times.
Tom Lane [Sun, 13 Aug 2006 17:58:49 +0000 (17:58 +0000)]
Original coding of 'returning' regression test inadvertently chose a
nonunique join value, leading to plan-choice-dependent results ... and
it seems some platforms will choose a different plan. Tweak the test
so that it has well-defined results. Per report from Olivier Prenant.
Michael Meskes [Sun, 13 Aug 2006 10:18:31 +0000 (10:18 +0000)]
Applied patch for VPATH builds by Alvaro Herrera <alvherre@commandprompt.com>
Merged dyntest.pgc and dyntest2.pgc.
Hopefully fixed the last Coverity reports (finally)
Tom Lane [Sat, 12 Aug 2006 20:05:56 +0000 (20:05 +0000)]
Tweak SPI_cursor_open to allow INSERT/UPDATE/DELETE RETURNING; this was
merely a matter of fixing the error check, since the underlying Portal
infrastructure already handles it. This in turn allows these statements
to be used in some existing plpgsql and plperl contexts, such as a
plpgsql FOR loop. Also, do some marginal code cleanup in places that
were being sloppy about distinguishing SELECT from SELECT INTO.
Bruce Momjian [Sat, 12 Aug 2006 03:50:27 +0000 (03:50 +0000)]
Done:
< o Allow INSERT/UPDATE ... RETURNING new.col or old.col
<
< This is useful for returning the auto-generated key for an INSERT.
< One complication is how to handle rules that run as part of
< the insert.
< http://archives.postgresql.org/pgsql-patches/2005-07/msg00568.php
> o -Allow INSERT/UPDATE ... RETURNING new.col or old.col
Tom Lane [Sat, 12 Aug 2006 02:52:06 +0000 (02:52 +0000)]
Add INSERT/UPDATE/DELETE RETURNING, with basic docs and regression tests.
plpgsql support to come later. Along the way, convert execMain's
SELECT INTO support into a DestReceiver, in order to eliminate some ugly
special cases.
Bruce Momjian [Fri, 11 Aug 2006 20:08:28 +0000 (20:08 +0000)]
Refactor GUC set_config_option function:
The main reason for refactoring was that set_config_option() was too
overloaded function and its behavior did not consistent. Old version of
set_config_function hides some messages. For example if you type:
tcp_port = 5432.1
then old implementation ignore this error without any message to log
file in the signal context (configuration reload). Main problem was that
semantic analysis of postgresql.conf is not perform in the
ProcessConfigFile function, but in the set_config_options *after*
context check. This skipped check for variables with PG_POSTMASTER
context. There was request from Joachim Wieland to add more messages
about ignored changes in the config file as well.
Bruce Momjian [Fri, 11 Aug 2006 15:53:39 +0000 (15:53 +0000)]
Add URLs
< * Allow encoding on a per-column basis
> * Allow encoding on a per-column basis optionally using the ICU library:
> http://archives.postgresql.org/pgsql-patches/2005-08/msg00309.php
> http://archives.postgresql.org/pgsql-patches/2006-03/msg00233.php
Tom Lane [Thu, 10 Aug 2006 02:36:29 +0000 (02:36 +0000)]
Fix UNION/INTERSECT/EXCEPT so that when two inputs being merged have
same data type and same typmod, we show that typmod as the output
typmod, rather than generic -1. This responds to several complaints
over the past few years about UNIONs unexpectedly dropping length or
precision info.
Bruce Momjian [Wed, 9 Aug 2006 17:47:03 +0000 (17:47 +0000)]
Fix statement_timeout on Win32 so that it properly treats micro-seconds
as micro-seconds, rather than as 100 microseconds, as it does now. This
actually fixes all setitimer calls on Win32, but statement_timeout is
the most visible fix.
Bruce Momjian [Wed, 9 Aug 2006 16:35:51 +0000 (16:35 +0000)]
Add TODO items we don't want (Idea from Josh Berkus)
>
>
> Features We Do _Not_ Want
> =========================
>
> * All backends running as threads in a single process (not want)
>
> This eliminates the process protection we get from the current setup.
> Thread creation is usually the same overhead as process creation on
> modern systems, so it seems unwise to use a pure threaded model.
>
> * Optimizer hints (not want)
>
> Optimizer hints are used to work around problems in the optimizer. We
> would rather have the problems reported and fixed.
> http://archives.postgresql.org/pgsql-hackers/2006-08/msg00506.php
Bruce Momjian [Wed, 9 Aug 2006 14:55:39 +0000 (14:55 +0000)]
Update packages:
< A package would be a schema with public/private variables,
> A package would be a schema with session-local variables,
> http://archives.postgresql.org/pgsql-hackers/2006-08/msg00384.php
Bruce Momjian [Wed, 9 Aug 2006 02:48:10 +0000 (02:48 +0000)]
Update packages description:
< A package would be a schema with its own variables,
< private functions, and initialization functions. It
> A package would be a schema with public/private variables,
> public/private functions, and initialization functions. It
Bruce Momjian [Tue, 8 Aug 2006 22:51:37 +0000 (22:51 +0000)]
Update packages:
< private functions, and initialization functions
> private functions, and initialization functions. It
> is also possible to implement these capabilities
> in all schemas and not use a separate "packages"
> syntax at all.
Tom Lane [Tue, 8 Aug 2006 19:15:09 +0000 (19:15 +0000)]
Add a feature for automatic initialization and finalization of dynamically
loaded libraries: call functions _PG_init() and _PG_fini() if the library
defines such symbols. Hence we no longer need to specify an initialization
function in preload_libraries: we can assume that the library used the
_PG_init() convention, instead. This removes one source of pilot error
in use of preloaded libraries. Original patch by Ralf Engelschall,
preload_libraries changes by me.
Bruce Momjian [Tue, 8 Aug 2006 17:40:02 +0000 (17:40 +0000)]
Done:
< o Automatically force archiving of partially-filled WAL files when
> o -Automatically force archiving of partially-filled WAL files when
<
< Doing this will allow administrators to know more easily when
< the archive contains all the files needed for point-in-time
< recovery.
< http://archives.postgresql.org/pgsql-patches/2005-04/msg00121.php
<
< o Add reporting of the current WAL file and offset, perhaps as
> o -Add reporting of the current WAL file and offset, perhaps as
<
< The offset allows parts of a WAL file to be archived using
< an external program.
<
Bruce Momjian [Tue, 8 Aug 2006 01:24:36 +0000 (01:24 +0000)]
Done:
< * Allow protocol-level BIND parameter values to be logged
<
< http://archives.postgresql.org/pgsql-hackers/2006-02/msg00165.php
> * -Allow protocol-level BIND parameter values to be logged, if text mode
Bruce Momjian [Tue, 8 Aug 2006 01:23:15 +0000 (01:23 +0000)]
For protocol-level prepare/bind/execute:
o print user name for all
o print portal name if defined for all
o print query for all
o reduce log_statement header to single keyword
o print bind parameters as DETAIL if text mode
Tom Lane [Mon, 7 Aug 2006 17:41:42 +0000 (17:41 +0000)]
On some platforms, pg_usleep isn't interruptible by signals; fix
archiver to behave per original coder's expectation on these machines.
We already know this everywhere else AFAICT.
Tom Lane [Mon, 7 Aug 2006 16:57:57 +0000 (16:57 +0000)]
Make recovery from WAL be restartable, by executing a checkpoint-like
operation every so often. This improves the usefulness of PITR log
shipping for hot standby: formerly, if the standby server crashed, it
was necessary to restart it from the last base backup and replay all
the WAL since then. Now it will only need to reread about the same
amount of WAL as the master server would. The behavior might also
come in handy during a long PITR replay sequence. Simon Riggs,
with some editorialization by Tom Lane.
Tom Lane [Sun, 6 Aug 2006 04:35:21 +0000 (04:35 +0000)]
Tweak sanity_check regression test to display more tables (viz, those
without indexes) but not to display temp tables. It's a bit hard to
credit that sanity_check could get through a database-wide VACUUM
while the preceding create_index test is still trying to clean up
its temp tables ... but I see no other explanation for the current
failure report from buildfarm member sponge.
Tom Lane [Sun, 6 Aug 2006 03:53:44 +0000 (03:53 +0000)]
Add support for forcing a switch to a new xlog file; cause such a switch
to happen automatically during pg_stop_backup(). Add some functions for
interrogating the current xlog insertion point and for easily extracting
WAL filenames from the hex WAL locations displayed by pg_stop_backup
and friends. Simon Riggs with some editorialization by Tom Lane.
Tom Lane [Sat, 5 Aug 2006 17:21:52 +0000 (17:21 +0000)]
Fix inheritance_planner() to delete dummy subplans from its Append plan
list, when some of the child rels have been excluded by constraint
exclusion. This doesn't save a huge amount of time but it'll save some,
and it makes the EXPLAIN output look saner. We already did the
equivalent thing in set_append_rel_pathlist(), but not here.
Tom Lane [Sat, 5 Aug 2006 00:22:49 +0000 (00:22 +0000)]
Extend relation_excluded_by_constraints() to check for mutually
contradictory WHERE-clauses applied to a relation. This makes the
GUC variable constraint_exclusion rather inappropriately named,
but I've refrained for the moment from renaming it.
Per example from Martin Lesser.
Tom Lane [Sat, 5 Aug 2006 00:21:14 +0000 (00:21 +0000)]
Teach predicate_refuted_by() how to do proofs involving NOT-clauses.
This doesn't matter too much for ordinary NOTs, since prepqual.c does
its best to get rid of those, but it helps with IS NOT TRUE clauses
which the rule rewriter likes to insert. Per example from Martin Lesser.
Tom Lane [Fri, 4 Aug 2006 21:33:36 +0000 (21:33 +0000)]
Fix domain_in() bug exhibited by Darcy Buskermolen. The idea of an EState
that's shorter-lived than the expression state being evaluated in it really
doesn't work :-( --- we end up with fn_extra caches getting deleted while
still in use. Rather than abandon the notion of caching expression state
across domain_in calls altogether, I chose to make domain_in a bit cozier
with ExprContext. All we really need for evaluating variable-free
expressions is an ExprContext, not an EState, so I invented the notion of a
"standalone" ExprContext. domain_in can prevent resource leakages by doing
a ReScanExprContext on this rather than having to free it entirely; so we
can make the ExprContext have the same lifespan (and particularly the same
per_query memory context) as the expression state structs.
Tom Lane [Fri, 4 Aug 2006 14:09:51 +0000 (14:09 +0000)]
Teach eval_const_expressions to simplify BooleanTest nodes that have
constant input. Seems worth doing because rule rewriter inserts
IS NOT TRUE tests into WHERE clauses.
Tom Lane [Thu, 3 Aug 2006 20:57:06 +0000 (20:57 +0000)]
Cause ALTER TABLE to perform ALTER COLUMN DROP DEFAULT operations during
the DROP pass rather than the ADD_CONSTR pass. On examining the code I
think this was just an oversight rather than intentional, and it seems
to satisfy the principle of least surprise better than the alternative
solution that was discussed. Add an example to the ref page showing how
to do ALTER TYPE and update the default in one command. Per gripe from
Markus Bertheau that that wasn't possible.
Tom Lane [Thu, 3 Aug 2006 17:04:00 +0000 (17:04 +0000)]
Remove use of a regex character class in resultmap (for freebsd version
check). This isn't supported by pg_regress since the recent rewrite
into C. While we could add char classes to pg_regress.c's code, it's
not really needed at the moment: thanks to Andrew's patch to make
pg_regress always accept the 'standard' comparison file, we can just
drop the version check.
Tom Lane [Thu, 3 Aug 2006 16:04:41 +0000 (16:04 +0000)]
Fix AfterTriggerExecute() to pass tg_trigtuple and tg_newtuple as NULLs
rather than pointers to garbage, when calling AFTER STATEMENT triggers.
Michael Fuhr