]> granicus.if.org Git - python/log
python
18 years agorun_module shouldn't hold the import lock when running a script
Nick Coghlan [Fri, 24 Mar 2006 13:05:53 +0000 (13:05 +0000)]
run_module shouldn't hold the import lock when running a script

18 years agoUse absolute import.
Neal Norwitz [Fri, 24 Mar 2006 08:58:38 +0000 (08:58 +0000)]
Use absolute import.

18 years agoClarify cases when waitpid might not return self.pid.
Martin v. Löwis [Fri, 24 Mar 2006 08:26:26 +0000 (08:26 +0000)]
Clarify cases when waitpid might not return self.pid.

18 years agoBug #1183780: Add Popen objects to _active only in __del__.
Martin v. Löwis [Fri, 24 Mar 2006 08:14:54 +0000 (08:14 +0000)]
Bug #1183780: Add Popen objects to _active only in __del__.
Cleanup terminated processes as well.
Add cmd attribute to Popen4.

18 years agoExceptions should inherit from Exception now.
Neal Norwitz [Fri, 24 Mar 2006 08:02:51 +0000 (08:02 +0000)]
Exceptions should inherit from Exception now.

18 years agoHmmm, I don't think we wanted to test // twice and / not at all (in this section).
Neal Norwitz [Fri, 24 Mar 2006 07:30:56 +0000 (07:30 +0000)]
Hmmm, I don't think we wanted to test // twice and / not at all (in this section).

18 years agoExceptions should inherit from Exception now.
Neal Norwitz [Fri, 24 Mar 2006 07:03:44 +0000 (07:03 +0000)]
Exceptions should inherit from Exception now.

18 years agoSF bug #1457411, fix errors using variables that don't exist.
Neal Norwitz [Fri, 24 Mar 2006 05:36:33 +0000 (05:36 +0000)]
SF bug #1457411, fix errors using variables that don't exist.

Rename file -> filename to be clear.

Will backport.

18 years agoForward port of 43262: Add 2.4.3 UUIDs.
Martin v. Löwis [Thu, 23 Mar 2006 19:21:52 +0000 (19:21 +0000)]
Forward port of 43262: Add 2.4.3 UUIDs.

18 years agoRelax result test for program mode of quopri.
Martin v. Löwis [Thu, 23 Mar 2006 19:14:23 +0000 (19:14 +0000)]
Relax result test for program mode of quopri.

18 years agoPreserve command name, for later printing of active
Martin v. Löwis [Thu, 23 Mar 2006 18:18:35 +0000 (18:18 +0000)]
Preserve command name, for later printing of active
commands. If there are active commands when the tests
start, fail, printing these commands.

18 years agoRewrite pipe code using subprocess, to make sure the
Martin v. Löwis [Thu, 23 Mar 2006 18:16:43 +0000 (18:16 +0000)]
Rewrite pipe code using subprocess, to make sure the
child process is closed when the test completes.

18 years agoPatch #1396919: Reenable the system scope threads on FreeBSD 5.4
Hye-Shik Chang [Thu, 23 Mar 2006 12:32:36 +0000 (12:32 +0000)]
Patch #1396919: Reenable the system scope threads on FreeBSD 5.4
and later versions because they bumped the default setting to
get our basic tests to run correctly..

18 years agoCosmetic improvement for r43247
Hye-Shik Chang [Thu, 23 Mar 2006 12:12:44 +0000 (12:12 +0000)]
Cosmetic improvement for r43247

18 years agoSkip to install files for empty directories; to name it, Lib/lib-old.
Hye-Shik Chang [Thu, 23 Mar 2006 12:04:37 +0000 (12:04 +0000)]
Skip to install files for empty directories; to name it, Lib/lib-old.
BSD make stops the build when it tries to expand wild cards on empty
directories.

18 years agoStop duplicating code and handle slice indices consistently and correctly
Neal Norwitz [Thu, 23 Mar 2006 06:03:08 +0000 (06:03 +0000)]
Stop duplicating code and handle slice indices consistently and correctly
wrt to ssize_t.

18 years agoFix a ssize_t issue
Neal Norwitz [Thu, 23 Mar 2006 05:48:09 +0000 (05:48 +0000)]
Fix a ssize_t issue

18 years agoHeh -- used the right format for a refcount, but forgot
Tim Peters [Thu, 23 Mar 2006 05:41:24 +0000 (05:41 +0000)]
Heh -- used the right format for a refcount, but forgot
to stop truncating it.

18 years agoForward port MvL's fix in 43227:
Neal Norwitz [Thu, 23 Mar 2006 05:39:47 +0000 (05:39 +0000)]
Forward port MvL's fix in 43227:

Fix crash when a Unicode string containing an encoding declaration is
compile()d. Fixes #1115379.

18 years ago_Py_NegativeRefcount(): print the full value of ob_refcnt.
Tim Peters [Thu, 23 Mar 2006 05:38:33 +0000 (05:38 +0000)]
_Py_NegativeRefcount():  print the full value of ob_refcnt.

18 years agoAdd email/mime to LIBSUBDIRS. Fixes SF bug # 1454912.
Barry Warsaw [Wed, 22 Mar 2006 14:57:54 +0000 (14:57 +0000)]
Add email/mime to LIBSUBDIRS.  Fixes SF bug # 1454912.

18 years agoFix some int/Py_ssize_t issues which led to compiler warnings
Thomas Heller [Wed, 22 Mar 2006 13:21:16 +0000 (13:21 +0000)]
Fix some int/Py_ssize_t issues which led to compiler warnings
on 64-bit platforms.

18 years agoInclude <malloc.h> on windows, to avoid warnings when compiling with mingw.
Thomas Heller [Wed, 22 Mar 2006 12:59:53 +0000 (12:59 +0000)]
Include <malloc.h> on windows, to avoid warnings when compiling with mingw.
Don't use SEH when compiling wth mingw.
Use IS_INTRESOURCE to determine function name from function ordinal.

Rewrite the code that allocates and frees callback functions, hopefully
this avoids the coverty warnings: Remove the THUNK typedef, and move the
definition of struct ffi_info into the header file.

18 years agoctypes was added.
Thomas Heller [Wed, 22 Mar 2006 10:09:27 +0000 (10:09 +0000)]
ctypes was added.

18 years agoRemove false information from the comment and reformat it like other
Hye-Shik Chang [Wed, 22 Mar 2006 08:52:43 +0000 (08:52 +0000)]
Remove false information from the comment and reformat it like other
comments in the file. (SF #1455641)

18 years agoDamn another occurrence of using as as a keywordf
Neal Norwitz [Wed, 22 Mar 2006 07:13:30 +0000 (07:13 +0000)]
Damn another occurrence of using as as a keywordf

18 years agoChange NEWS entry for recent socket API change
Georg Brandl [Wed, 22 Mar 2006 06:44:14 +0000 (06:44 +0000)]
Change NEWS entry for recent socket API change

18 years agoWhitespace normalization.
Tim Peters [Wed, 22 Mar 2006 03:23:21 +0000 (03:23 +0000)]
Whitespace normalization.

18 years agoRecord that test_wait[34] get skipped on native Windows.
Tim Peters [Wed, 22 Mar 2006 02:58:17 +0000 (02:58 +0000)]
Record that test_wait[34] get skipped on native Windows.

18 years agoNews about email 4.0.
Barry Warsaw [Wed, 22 Mar 2006 02:45:50 +0000 (02:45 +0000)]
News about email 4.0.

18 years agoremove test file
Barry Warsaw [Tue, 21 Mar 2006 19:46:26 +0000 (19:46 +0000)]
remove test file

18 years agopy trunk svn test
Barry Warsaw [Tue, 21 Mar 2006 19:37:40 +0000 (19:37 +0000)]
py trunk svn test

18 years agopy trunk svn test
Barry Warsaw [Tue, 21 Mar 2006 19:26:34 +0000 (19:26 +0000)]
py trunk svn test

18 years agopy trunk svn test
Barry Warsaw [Tue, 21 Mar 2006 18:30:37 +0000 (18:30 +0000)]
py trunk svn test

18 years agoCorrect API design mistake from rev. 43126: make socket attributes readonly properties.
Georg Brandl [Tue, 21 Mar 2006 18:17:25 +0000 (18:17 +0000)]
Correct API design mistake from rev. 43126: make socket attributes readonly properties.

18 years agoUpdate to Tk 8.4.12 and Tix 8.4.0
Martin v. Löwis [Tue, 21 Mar 2006 13:20:29 +0000 (13:20 +0000)]
Update to Tk 8.4.12 and Tix 8.4.0

18 years agoUpdate to OpenSSL 0.9.8a
Martin v. Löwis [Tue, 21 Mar 2006 12:08:39 +0000 (12:08 +0000)]
Update to OpenSSL 0.9.8a

18 years agoAdd a note about pow(x,y) equalling x**y (the "**" operator
Georg Brandl [Tue, 21 Mar 2006 08:48:04 +0000 (08:48 +0000)]
Add a note about pow(x,y) equalling x**y (the "**" operator
was used unmotivated in the pow() docs)

18 years agoTry to repair at least one segfault on the Mac buildbot,
Tim Peters [Tue, 21 Mar 2006 03:58:41 +0000 (03:58 +0000)]
Try to repair at least one segfault on the Mac buildbot,
as diagnosed by Nick Coghlan.

test_capi.py:  A test module should never spawn a thread as
a side effect of being imported.  Because this one did, the
segfault one of its thread tests caused didn't occur until
a few tests after test_regrtest.py thought test_capi was
finished.  Repair that.  Also join() the thread spawned
at the end, so that test_capi is truly finished when
regrtest reports that it's done.

_testcapimodule.c test_thread_state():  this spawns a
couple of non-threading.py threads, passing them a PyObject*
argument, but did nothing to ensure that those threads
finished before returning.  As a result, the PyObject*
_could_ (although this was unlikely) get decref'ed out of
existence before the threads got around to using it.
Added explicit synchronization (via a Python mutex) so
that test_thread_state can reliably wait for its spawned
threads to finish.

18 years agoShow an example of calling a named set method.
Raymond Hettinger [Mon, 20 Mar 2006 18:35:55 +0000 (18:35 +0000)]
Show an example of calling a named set method.

18 years agoAvoid a potential double-free bug.
Thomas Heller [Mon, 20 Mar 2006 14:22:05 +0000 (14:22 +0000)]
Avoid a potential double-free bug.

18 years agoApply patch from Martin v. Loewis: Avoid function pointer casts.
Thomas Heller [Mon, 20 Mar 2006 10:22:42 +0000 (10:22 +0000)]
Apply patch from Martin v. Loewis: Avoid function pointer casts.

https://sourceforge.net/tracker/?func=detail&atid=532156&aid=1453037&group_id=71702

18 years agoRemove mention of fpectl in README.
Georg Brandl [Mon, 20 Mar 2006 09:38:58 +0000 (09:38 +0000)]
Remove mention of fpectl in README.

18 years agoDamn Coverity. I can't even sneak in a leak any more. :-)
Neal Norwitz [Mon, 20 Mar 2006 08:47:12 +0000 (08:47 +0000)]
Damn Coverity.  I can't even sneak in a leak any more. :-)

18 years agoFix another bug found by Coverty.
Thomas Heller [Mon, 20 Mar 2006 08:29:28 +0000 (08:29 +0000)]
Fix another bug found by Coverty.

18 years agoFix bug found by Coverty.
Thomas Heller [Mon, 20 Mar 2006 08:28:19 +0000 (08:28 +0000)]
Fix bug found by Coverty.

18 years agoPlug a leak in the ctypes test suite when tests are run repeatedly.
Thomas Heller [Mon, 20 Mar 2006 08:11:56 +0000 (08:11 +0000)]
Plug a leak in the ctypes test suite when tests are run repeatedly.

18 years agoAccessing unaligned structure fields works now on all architectures.
Thomas Heller [Mon, 20 Mar 2006 07:54:01 +0000 (07:54 +0000)]
Accessing unaligned structure fields works now on all architectures.
Including unittest.

18 years agoThe helper is only necessary for wait3/4.
Neal Norwitz [Mon, 20 Mar 2006 07:25:26 +0000 (07:25 +0000)]
The helper is only necessary for wait3/4.

18 years agowhitespace n11n
Anthony Baxter [Mon, 20 Mar 2006 07:10:01 +0000 (07:10 +0000)]
whitespace n11n

18 years agoTry to cleanup a lot of boilerplate #ifdef wrt wait types and make the code
Neal Norwitz [Mon, 20 Mar 2006 06:48:34 +0000 (06:48 +0000)]
Try to cleanup a lot of boilerplate #ifdef wrt wait types and make the code
more consistent (and smaller by 85 lines or so).

18 years agoMake some functions static, reformat function decl to be consistent and check for...
Neal Norwitz [Mon, 20 Mar 2006 06:34:06 +0000 (06:34 +0000)]
Make some functions static, reformat function decl to be consistent and check for error from PyModule_GetDict()

18 years agoGet Py_DEPRECATED to work with gcc 4.x too
Neal Norwitz [Mon, 20 Mar 2006 06:33:01 +0000 (06:33 +0000)]
Get Py_DEPRECATED to work with gcc 4.x too

18 years agomoved older releases into HISTORY
Anthony Baxter [Mon, 20 Mar 2006 06:30:41 +0000 (06:30 +0000)]
moved older releases into HISTORY

18 years agoPatch #1309579: wait3 and wait4 were added to the posix module by Chad J. Schroeder.
Neal Norwitz [Mon, 20 Mar 2006 06:30:08 +0000 (06:30 +0000)]
Patch #1309579: wait3 and wait4 were added to the posix module by Chad J. Schroeder.

This was a fair amount of rework of the patch.  Refactored test_fork1 so it
could be reused by the new tests for wait3/4.  Also made them into new style
unittests (derive from unittest.TestCase).

18 years agoexperimenting with release stuff. please ignore
Anthony Baxter [Mon, 20 Mar 2006 06:25:04 +0000 (06:25 +0000)]
experimenting with release stuff. please ignore

18 years agoreplace use of int16_t with a (typedef'd) short, to fix Windows buildbots.
Anthony Baxter [Mon, 20 Mar 2006 05:58:21 +0000 (05:58 +0000)]
replace use of int16_t with a (typedef'd) short, to fix Windows buildbots.
expand tabs.

18 years agoignore the fetched NormalizationTest.txt file
Anthony Baxter [Mon, 20 Mar 2006 05:29:26 +0000 (05:29 +0000)]
ignore the fetched NormalizationTest.txt file

18 years agoSF [ 1231053 ] audioop - alaw encoding/decoding added, code updated
Anthony Baxter [Mon, 20 Mar 2006 05:21:58 +0000 (05:21 +0000)]
SF [ 1231053 ] audioop - alaw encoding/decoding added, code updated
 This patch adds a-LAW encoding to audioop and replaces the old
u-LAW encoding/decoding code with the current code from sox.

Possible issues: the code from sox uses int16_t.

Code by Lars Immisch

18 years agoSF #1445431, fix some leaks in error conditions.
Neal Norwitz [Mon, 20 Mar 2006 04:08:12 +0000 (04:08 +0000)]
SF #1445431, fix some leaks in error conditions.

18 years agoGet rid of some warnings.
Neal Norwitz [Mon, 20 Mar 2006 02:04:23 +0000 (02:04 +0000)]
Get rid of some warnings.

18 years agoFix problem spotted by Coverity that occurs if tzinfo.tzname().replace()
Neal Norwitz [Mon, 20 Mar 2006 01:58:39 +0000 (01:58 +0000)]
Fix problem spotted by Coverity that occurs if tzinfo.tzname().replace()
returns a non-string when converting %Z.

Will backport.

18 years agoUpdate function name to reflect params and stop casting to long to avoid losing data
Neal Norwitz [Mon, 20 Mar 2006 01:55:26 +0000 (01:55 +0000)]
Update function name to reflect params and stop casting to long to avoid losing data

18 years agoUse macro versions instead of function versions when we already know the type.
Neal Norwitz [Mon, 20 Mar 2006 01:53:23 +0000 (01:53 +0000)]
Use macro versions instead of function versions when we already know the type.
This will hopefully get rid of some Coverity warnings, be a hint to
developers, and be marginally faster.

Some asserts were added when the type is currently known, but depends
on values from another function.

18 years agoSource file f.flush() after writing; trying to avoid lossage if user
Kurt B. Kaiser [Sun, 19 Mar 2006 20:40:05 +0000 (20:40 +0000)]
Source file f.flush() after writing; trying to avoid lossage if user
kills GUI.  Report from B. Sherwood.  Backport to 2.3.4.

18 years agoUpdate tutorial wrt PEP 341 try-except-finally statement
Georg Brandl [Sun, 19 Mar 2006 11:20:29 +0000 (11:20 +0000)]
Update tutorial wrt PEP 341 try-except-finally statement

18 years agoIgnore api.{dvi,idx,ind,l2h,log,toc} and modapi.ind, via suffix
Barry Warsaw [Sat, 18 Mar 2006 18:12:26 +0000 (18:12 +0000)]
Ignore api.{dvi,idx,ind,l2h,log,toc} and modapi.ind, via suffix
wildcards.

18 years agoIgnore *.pyc and *.pyo
Hye-Shik Chang [Sat, 18 Mar 2006 18:07:35 +0000 (18:07 +0000)]
Ignore *.pyc and *.pyo

18 years agoChange raise statement to PEP 8 style.
Walter Dörwald [Sat, 18 Mar 2006 16:35:17 +0000 (16:35 +0000)]
Change raise statement to PEP 8 style.

18 years agoShim for test_email_renamed.py tests.
Barry Warsaw [Sat, 18 Mar 2006 16:17:17 +0000 (16:17 +0000)]
Shim for test_email_renamed.py tests.

18 years agoMerge email package 4.0 from the sandbox, including documentation, test cases,
Barry Warsaw [Sat, 18 Mar 2006 15:41:53 +0000 (15:41 +0000)]
Merge email package 4.0 from the sandbox, including documentation, test cases,
and NEWS updates.

18 years agoAdd tests for the C APIs PyCodec_IncrementalEncoder() and
Walter Dörwald [Sat, 18 Mar 2006 14:22:26 +0000 (14:22 +0000)]
Add tests for the C APIs PyCodec_IncrementalEncoder() and
PyCodec_IncrementalDecoder().

18 years agoRelease codecs variable earlier.
Walter Dörwald [Sat, 18 Mar 2006 14:05:43 +0000 (14:05 +0000)]
Release codecs variable earlier.

18 years agoFix compiler warning.
Thomas Heller [Sat, 18 Mar 2006 12:52:54 +0000 (12:52 +0000)]
Fix compiler warning.

18 years agoBug #1353433: be conciliant with spaces in redirect URLs
Georg Brandl [Sat, 18 Mar 2006 11:35:18 +0000 (11:35 +0000)]
Bug #1353433: be conciliant with spaces in redirect URLs

18 years agoPreviously, Python code had no easy way to access the contents of a
Georg Brandl [Sat, 18 Mar 2006 07:59:59 +0000 (07:59 +0000)]
Previously, Python code had no easy way to access the contents of a
cell object. Now, a ``cell_contents`` attribute has been added
(closes patch #1170323).

18 years agoYou need at least one \item
Andrew M. Kuchling [Fri, 17 Mar 2006 22:25:15 +0000 (22:25 +0000)]
You need at least one \item

18 years agoWrite section
Andrew M. Kuchling [Fri, 17 Mar 2006 21:48:46 +0000 (21:48 +0000)]
Write section

18 years agoRFE #567972: Socket objects' family, type and proto properties are
Georg Brandl [Fri, 17 Mar 2006 19:17:34 +0000 (19:17 +0000)]
RFE #567972: Socket objects' family, type and proto properties are
now exposed via new get...() methods.

18 years agoFix some missing checks after PyTuple_New, PyList_New, PyDict_New
Georg Brandl [Fri, 17 Mar 2006 19:03:25 +0000 (19:03 +0000)]
Fix some missing checks after PyTuple_New, PyList_New, PyDict_New

18 years agoRemove the lib-old modules from Doc/lib/libundoc.tex.
Georg Brandl [Fri, 17 Mar 2006 18:47:14 +0000 (18:47 +0000)]
Remove the lib-old modules from Doc/lib/libundoc.tex.

Now only Modules/timingmodule.c is left. Should that be removed, too?
(dito for clmodule and svmodule)

18 years agoFix bug 1441408 where a double colon didn't trigger extended slice semantics (applies...
Nick Coghlan [Fri, 17 Mar 2006 17:59:10 +0000 (17:59 +0000)]
Fix bug 1441408 where a double colon didn't trigger extended slice semantics (applies patch 1452332)

18 years agoMore \exception fixes.
Georg Brandl [Fri, 17 Mar 2006 16:26:31 +0000 (16:26 +0000)]
More \exception fixes.

18 years agoAdd two items
Andrew M. Kuchling [Fri, 17 Mar 2006 15:56:41 +0000 (15:56 +0000)]
Add two items

18 years agoMarkup fix
Andrew M. Kuchling [Fri, 17 Mar 2006 15:56:13 +0000 (15:56 +0000)]
Markup fix

18 years agoMerge changes from the upstream version:
Thomas Heller [Fri, 17 Mar 2006 15:52:58 +0000 (15:52 +0000)]
Merge changes from the upstream version:
- cast is implemented as a foreign function now
- On Windows, it is now possible to access functions exported by ordinal only

18 years agoRemove mention of lib-old, and list more deleted modules
Andrew M. Kuchling [Fri, 17 Mar 2006 15:39:52 +0000 (15:39 +0000)]
Remove mention of lib-old, and list more deleted modules

18 years agoAdd some items
Andrew M. Kuchling [Fri, 17 Mar 2006 15:38:39 +0000 (15:38 +0000)]
Add some items

18 years agoas is on the road to keyword-hood, use a different var name.
Neal Norwitz [Fri, 17 Mar 2006 08:55:46 +0000 (08:55 +0000)]
as is on the road to keyword-hood, use a different var name.

18 years agoOops, copied the wrong code from keeprefs. Get the right code
Neal Norwitz [Fri, 17 Mar 2006 07:15:59 +0000 (07:15 +0000)]
Oops, copied the wrong code from keeprefs.  Get the right code
this time and call gc.collect(), since there is some garbage.

The original code didn't really leak (if gc.collect() was called).

18 years agoUpdate/expand on comments about leaking tests.
Neal Norwitz [Fri, 17 Mar 2006 04:52:38 +0000 (04:52 +0000)]
Update/expand on comments about leaking tests.

18 years agoIgnore ctypes leaks, but add a test case so we do not forget.
Neal Norwitz [Fri, 17 Mar 2006 04:45:38 +0000 (04:45 +0000)]
Ignore ctypes leaks, but add a test case so we do not forget.

18 years agoTry to find a host that responds slower from python.org so this test does not fail...
Neal Norwitz [Fri, 17 Mar 2006 04:37:34 +0000 (04:37 +0000)]
Try to find a host that responds slower from python.org so this test does not fail on macteagle (G4 OSX.4 in buildbot)

18 years agoIntroduced symbol PY_FORMAT_SIZE_T. See the new comments
Tim Peters [Fri, 17 Mar 2006 03:29:34 +0000 (03:29 +0000)]
Introduced symbol PY_FORMAT_SIZE_T.  See the new comments
in pyport.h.  Changed PyString_FromFormatV() to use it
instead of inlining its own maze of #if'ery.

18 years agoFix wrong argument format in PyCodec_IncrementalEncoder() and
Walter Dörwald [Thu, 16 Mar 2006 21:46:40 +0000 (21:46 +0000)]
Fix wrong argument format in PyCodec_IncrementalEncoder() and
PyCodec_IncrementalDecoder().

Factor out common code from PyCodec_Encoder()/PyCodec_Decoder(),
PyCodec_IncrementalEncoder()/PyCodec_IncrementalDecoder() and
PyCodec_StreamReader()/PyCodec_StreamWriter().

18 years agoFix a test that fails when libGL.so and libGLU.so are not installed (on posix systems).
Thomas Heller [Thu, 16 Mar 2006 20:09:22 +0000 (20:09 +0000)]
Fix a test that fails when libGL.so and libGLU.so are not installed (on posix systems).

18 years agoFix a leak that would happen under error conditions (found by Coverty).
Thomas Heller [Thu, 16 Mar 2006 20:02:36 +0000 (20:02 +0000)]
Fix a leak that would happen under error conditions (found by Coverty).

18 years agoUse int 0 as default defval for LCID if nothing has been supplied.
Thomas Heller [Thu, 16 Mar 2006 19:56:24 +0000 (19:56 +0000)]
Use int 0 as default defval for LCID if nothing has been supplied.

18 years agoFix compiler warning.
Thomas Heller [Thu, 16 Mar 2006 19:34:56 +0000 (19:34 +0000)]
Fix compiler warning.

18 years agoFixes from Neal Norwitz, plus other small fixes.
Thomas Heller [Thu, 16 Mar 2006 19:26:21 +0000 (19:26 +0000)]
Fixes from Neal Norwitz, plus other small fixes.