]> granicus.if.org Git - postgresql/log
postgresql
17 years agoGet rid of the separate EState for subplans, and just let them share the
Tom Lane [Tue, 27 Feb 2007 01:11:26 +0000 (01:11 +0000)]
Get rid of the separate EState for subplans, and just let them share the
parent query's EState.  Now that there's a single flat rangetable for both
the main plan and subplans, there's no need anymore for a separate EState,
and removing it allows cleaning up some crufty code in nodeSubplan.c and
nodeSubqueryscan.c.  Should be a tad faster too, although any difference
will probably be hard to measure.  This is the last bit of subsidiary
mop-up work from changing to a flat rangetable.

17 years agoPut back copyObject() call I removed in a fit of brain fade. This one
Tom Lane [Sun, 25 Feb 2007 17:44:01 +0000 (17:44 +0000)]
Put back copyObject() call I removed in a fit of brain fade.  This one
is still needed despite cleanups in setrefs.c, because the point is to
let the inserted Result node compute a different tlist than its input
node does.  Per example from Jeremy Drake.

17 years agoUpdate Solaris FAQ.
Bruce Momjian [Fri, 23 Feb 2007 23:22:33 +0000 (23:22 +0000)]
Update Solaris FAQ.

17 years agoNow that plans have flat rangetable lists, it's a lot easier to get EXPLAIN to
Tom Lane [Fri, 23 Feb 2007 21:59:45 +0000 (21:59 +0000)]
Now that plans have flat rangetable lists, it's a lot easier to get EXPLAIN to
drill down into subplan targetlists to print the referent expression for an
OUTER or INNER var in an upper plan node.  Hence, make it do that always, and
banish the old hack of showing "?columnN?" when things got too complicated.

Along the way, fix an EXPLAIN bug I introduced by suppressing subqueries from
execution-time range tables: get_name_for_var_field() assumed it could look at
rte->subquery to find out the real type of a RECORD var.  That doesn't work
anymore, but instead we can look at the input plan of the SubqueryScan plan
node.

17 years agoMove BLCKSZ < 1024 check to guc.c.
Bruce Momjian [Fri, 23 Feb 2007 21:36:19 +0000 (21:36 +0000)]
Move BLCKSZ < 1024 check to guc.c.

17 years agoSpelling fix.
Bruce Momjian [Fri, 23 Feb 2007 20:37:59 +0000 (20:37 +0000)]
Spelling fix.

17 years agoUpdate Solaris FAQ wording, per Peter.
Bruce Momjian [Fri, 23 Feb 2007 20:30:08 +0000 (20:30 +0000)]
Update Solaris FAQ wording, per Peter.

17 years agoUpdate upgrade FAQ info.
Bruce Momjian [Fri, 23 Feb 2007 19:06:22 +0000 (19:06 +0000)]
Update upgrade FAQ info.

17 years agoUpdate Solaris FAQ.
Bruce Momjian [Fri, 23 Feb 2007 18:38:19 +0000 (18:38 +0000)]
Update Solaris FAQ.

Zdenek Kotala

17 years agoAdd psql \prompt capability.
Bruce Momjian [Fri, 23 Feb 2007 18:20:59 +0000 (18:20 +0000)]
Add psql \prompt capability.

Chad Wagner

17 years agoChange Agg and Group nodes so that Vars contained in their targetlists
Tom Lane [Thu, 22 Feb 2007 23:44:25 +0000 (23:44 +0000)]
Change Agg and Group nodes so that Vars contained in their targetlists
and quals have varno OUTER, rather than zero, to indicate a reference to
an output of their lefttree subplan.  This is consistent with the way
that every other upper-level node type does it, and allows some simplifications
in setrefs.c and EXPLAIN.

17 years agoFix bug I introduced in recent patch to make hash joins discard null tuples
Tom Lane [Thu, 22 Feb 2007 22:49:27 +0000 (22:49 +0000)]
Fix bug I introduced in recent patch to make hash joins discard null tuples
immediately: ExecHashGetHashValue failed to restore the caller's memory
context before taking the failure exit.

17 years agoTurn the rangetable used by the executor into a flat list, and avoid storing
Tom Lane [Thu, 22 Feb 2007 22:00:26 +0000 (22:00 +0000)]
Turn the rangetable used by the executor into a flat list, and avoid storing
useless substructure for its RangeTblEntry nodes.  (I chose to keep using the
same struct node type and just zero out the link fields for unneeded info,
rather than making a separate ExecRangeTblEntry type --- it seemed too
fragile to have two different rangetable representations.)

Along the way, put subplans into a list in the toplevel PlannedStmt node,
and have SubPlan nodes refer to them by list index instead of direct pointers.
Vadim wanted to do that years ago, but I never understood what he was on about
until now.  It makes things a *whole* lot more robust, because we can stop
worrying about duplicate processing of subplans during expression tree
traversals.  That's been a constant source of bugs, and it's finally gone.

There are some consequent simplifications yet to be made, like not using
a separate EState for subplans in the executor, but I'll tackle that later.

17 years agoRemove extra tab.
Bruce Momjian [Wed, 21 Feb 2007 23:22:42 +0000 (23:22 +0000)]
Remove extra tab.

17 years agoRemove tabs from SGML reference files, so their addition can be detected
Bruce Momjian [Wed, 21 Feb 2007 23:21:12 +0000 (23:21 +0000)]
Remove tabs from SGML reference files, so their addition can be detected
in the future.

17 years agoUpdate upgrade wording.
Bruce Momjian [Wed, 21 Feb 2007 22:54:11 +0000 (22:54 +0000)]
Update upgrade wording.

17 years agoUpdate new optional VACUUM FULL hint for translations, per Alvaro.
Bruce Momjian [Wed, 21 Feb 2007 22:47:45 +0000 (22:47 +0000)]
Update new optional VACUUM FULL hint for translations, per Alvaro.

17 years agoMove increase FSM warning to after lazy_truncate_heap() because the
Bruce Momjian [Wed, 21 Feb 2007 22:15:21 +0000 (22:15 +0000)]
Move increase FSM warning to after lazy_truncate_heap() because the
function might reduce the number of free pages in the table.  Recommend
VACUUM FULL only if 20% free.

Simon Riggs.

17 years agobtree source code cleanups:
Bruce Momjian [Wed, 21 Feb 2007 20:02:17 +0000 (20:02 +0000)]
btree source code cleanups:

I refactored findsplitloc and checksplitloc so that the division of
labor is more clear IMO. I pushed all the space calculation inside the
loop to checksplitloc.

I also fixed the off by 4 in free space calculation caused by
PageGetFreeSpace subtracting sizeof(ItemIdData), even though it was
harmless, because it was distracting and I felt it might come back to
bite us in the future if we change the page layout or alignments.
There's now a new function PageGetExactFreeSpace that doesn't do the
subtraction.

findsplitloc now tries the "just the new item to right page" split as
well. If people don't like the refactoring, I can write a patch to just
add that.

Heikki Linnakangas

17 years agoUpdate FAQ about minor updates.
Bruce Momjian [Wed, 21 Feb 2007 19:48:02 +0000 (19:48 +0000)]
Update FAQ about minor updates.

17 years agoUpdate Japanese FAQ.
Bruce Momjian [Wed, 21 Feb 2007 17:23:49 +0000 (17:23 +0000)]
Update Japanese FAQ.

Jun Kuwamura

17 years agoUpdate URL in German FAQ for bug form, per Schima, Fabian
Bruce Momjian [Wed, 21 Feb 2007 16:49:37 +0000 (16:49 +0000)]
Update URL in German FAQ for bug form, per Schima, Fabian

17 years agoUpdate Chinese FAQs to have two versions, a traditional Chinese version (Taiwan)
Bruce Momjian [Wed, 21 Feb 2007 16:42:36 +0000 (16:42 +0000)]
Update Chinese FAQs to have two versions, a traditional Chinese version (Taiwan)
and a Simplified version (China (PRC)).

Backpatch to 8.2.X.

Daojing.Zhou

17 years agoFix typo, per Dave Page.
Bruce Momjian [Wed, 21 Feb 2007 16:09:01 +0000 (16:09 +0000)]
Fix typo, per Dave Page.

17 years agoUpdate minor release text.
Bruce Momjian [Wed, 21 Feb 2007 16:08:05 +0000 (16:08 +0000)]
Update minor release text.

17 years agoAdd configure --enable-profiling to enable GCC profiling. Patches from
Bruce Momjian [Wed, 21 Feb 2007 15:12:39 +0000 (15:12 +0000)]
Add configure --enable-profiling to enable GCC profiling.  Patches from
Korry Douglas and Nikhil S

17 years agoUpdate upgrade text.
Bruce Momjian [Wed, 21 Feb 2007 15:07:35 +0000 (15:07 +0000)]
Update upgrade text.

17 years agoRevert changes to process pg_proc.h entries without OIDs. We're not supposed
Magnus Hagander [Wed, 21 Feb 2007 12:28:27 +0000 (12:28 +0000)]
Revert changes to process pg_proc.h entries without OIDs. We're not supposed
to have such entries, and want to be notified when we do...
Leave the plain bugfix in genbki.

17 years agoUpdate URL for set-returning functions.
Bruce Momjian [Wed, 21 Feb 2007 03:50:57 +0000 (03:50 +0000)]
Update URL for set-returning functions.

17 years agoAllow pltcl args to spi_prepare and plpython args to plpy.prepare to be standard...
Andrew Dunstan [Wed, 21 Feb 2007 03:27:32 +0000 (03:27 +0000)]
Allow pltcl args to spi_prepare and plpython args to plpy.prepare to be standard type aliases as well as those known in pg_type. Similar to recent change in plperl.

17 years agoAdd URL for:
Bruce Momjian [Wed, 21 Feb 2007 01:08:58 +0000 (01:08 +0000)]
Add URL for:

      o Allow row and record variables to be set to NULL constants,
        and allow NULL tests on such variables

17 years agoPrevent BLCKSZ < 1024, and have initdb test shared buffers based on the
Bruce Momjian [Tue, 20 Feb 2007 23:49:38 +0000 (23:49 +0000)]
Prevent BLCKSZ < 1024, and have initdb test shared buffers based on the
BLCKSZ value.

17 years agoAdd:
Bruce Momjian [Tue, 20 Feb 2007 23:39:03 +0000 (23:39 +0000)]
Add:

>
> * Consider decreasing the amount of memory used by PrivateRefCount
>
>   http://archives.postgresql.org/pgsql-hackers/2006-11/msg00797.php
>   http://archives.postgresql.org/pgsql-hackers/2007-01/msg00752.php
>

17 years agoFix markup.
Bruce Momjian [Tue, 20 Feb 2007 23:14:19 +0000 (23:14 +0000)]
Fix markup.

17 years agoChange $(CC) to $(COMPILER) on Solaris gcc so -m64 is passed into the
Bruce Momjian [Tue, 20 Feb 2007 22:45:57 +0000 (22:45 +0000)]
Change $(CC) to $(COMPILER) on Solaris gcc so -m64 is passed into the
shared link line.

17 years agoAdd:
Bruce Momjian [Tue, 20 Feb 2007 22:29:28 +0000 (22:29 +0000)]
Add:

> * Increase locking when DROPing objects so dependent objects cannot
>   get dropped while the DROP operation is happening
>
>   http://archives.postgresql.org/pgsql-hackers/2007-01/msg00937.php

17 years agoAdd URL for:
Bruce Momjian [Tue, 20 Feb 2007 22:23:05 +0000 (22:23 +0000)]
Add URL for:

        o Allow UPDATE/DELETE WHERE CURRENT OF cursor
>    http://archives.postgresql.org/pgsql-hackers/2007-01/msg01014.php

17 years agoAdd:
Bruce Momjian [Tue, 20 Feb 2007 21:22:35 +0000 (21:22 +0000)]
Add:

>
> * Add missing operators for geometric data types
>
>   Some geometric types do not have the full suite of geometric operators,
>   e.g. box @> point
>

17 years agoUpdate "encode" documentation to mention that 'escape' only changes null
Bruce Momjian [Tue, 20 Feb 2007 19:59:04 +0000 (19:59 +0000)]
Update "encode" documentation to mention that 'escape' only changes null
bytes and backslashes, remove "ASCII" mention.  Backpatch to 8.2.X.

17 years agoUpdate pgpass Win32 wording.
Bruce Momjian [Tue, 20 Feb 2007 19:35:17 +0000 (19:35 +0000)]
Update pgpass Win32 wording.

17 years agoUpdate information_schema documentation to match system tables.
Bruce Momjian [Tue, 20 Feb 2007 18:47:25 +0000 (18:47 +0000)]
Update information_schema documentation to match system tables.
Backpatch to 8.2.X.

17 years agoWording improvement.
Bruce Momjian [Tue, 20 Feb 2007 18:18:05 +0000 (18:18 +0000)]
Wording improvement.

17 years agoMore clearly document that most PostgreSQL utilities support libpq
Bruce Momjian [Tue, 20 Feb 2007 18:10:59 +0000 (18:10 +0000)]
More clearly document that most PostgreSQL utilities support libpq
environment variables.  Backpatch to 8.2.X.

17 years agoAdjust user-facing documentation to explain why we don't check pgpass
Tom Lane [Tue, 20 Feb 2007 17:47:04 +0000 (17:47 +0000)]
Adjust user-facing documentation to explain why we don't check pgpass
file permissions on Windows.

17 years agoRemove the Query structure from the executor's API. This allows us to stop
Tom Lane [Tue, 20 Feb 2007 17:32:18 +0000 (17:32 +0000)]
Remove the Query structure from the executor's API.  This allows us to stop
storing mostly-redundant Query trees in prepared statements, portals, etc.
To replace Query, a new node type called PlannedStmt is inserted by the
planner at the top of a completed plan tree; this carries just the fields of
Query that are still needed at runtime.  The statement lists kept in portals
etc. now consist of intermixed PlannedStmt and bare utility-statement nodes
--- no Query.  This incidentally allows us to remove some fields from Query
and Plan nodes that shouldn't have been there in the first place.

Still to do: simplify the execution-time range table; at the moment the
range table passed to the executor still contains Query trees for subqueries.

initdb forced due to change of stored rules.

17 years agoRemove, item not needed for Win32:
Bruce Momjian [Tue, 20 Feb 2007 15:21:42 +0000 (15:21 +0000)]
Remove, item not needed for Win32:

<  o Check .pgpass file permissions
>

17 years agoAdd comment that on Win32, we don't need to check the .pgpass file
Bruce Momjian [Tue, 20 Feb 2007 15:20:51 +0000 (15:20 +0000)]
Add comment that on Win32, we don't need to check the .pgpass file
permission, per Magnus.

17 years agoRemove "History" sections for pg_dump and pg_restore. I don't think
Bruce Momjian [Tue, 20 Feb 2007 15:01:17 +0000 (15:01 +0000)]
Remove "History" sections for pg_dump and pg_restore.  I don't think
anyone cares because the last history change was for PostgreSQL 7.1.

17 years agoSpell check on array patch.
Bruce Momjian [Tue, 20 Feb 2007 14:54:47 +0000 (14:54 +0000)]
Spell check on array patch.

17 years agoAdd for WIN32:
Bruce Momjian [Tue, 20 Feb 2007 14:48:47 +0000 (14:48 +0000)]
Add for WIN32:

<
>  o Check .pgpass file permissions

17 years agoUpdate array slice documentation to be clearer.
Bruce Momjian [Tue, 20 Feb 2007 14:34:25 +0000 (14:34 +0000)]
Update array slice documentation to be clearer.

17 years agoAdd:
Bruce Momjian [Tue, 20 Feb 2007 14:17:24 +0000 (14:17 +0000)]
Add:

> * Fix IS OF so it matches the ISO specification, and add documentation
>
>   http://archives.postgresql.org/pgsql-patches/2003-08/msg00060.php
>   http://archives.postgresql.org/pgsql-hackers/2007-02/msg00060.php

17 years agoComment-out documentation for IS OF because it doesn't conform to the
Bruce Momjian [Tue, 20 Feb 2007 14:04:50 +0000 (14:04 +0000)]
Comment-out documentation for IS OF because it doesn't conform to the
ISO SQL behavior. Backpatch removal to 8.2.X.

17 years agoIdentify schema of inherited table in psql \d when necessary.
Peter Eisentraut [Tue, 20 Feb 2007 10:23:38 +0000 (10:23 +0000)]
Identify schema of inherited table in psql \d when necessary.

by Bernd Helmle

17 years agoAdd missing OIDs to pg_proc.
Peter Eisentraut [Tue, 20 Feb 2007 10:00:25 +0000 (10:00 +0000)]
Add missing OIDs to pg_proc.

17 years agoRemove item:
Bruce Momjian [Tue, 20 Feb 2007 03:47:03 +0000 (03:47 +0000)]
Remove item:

<  o ARRAY[[1,2],[3,4]])[1] should return the same values as
<    ARRAY[[1,2],[3,4]])[1:1];
<

17 years agoDocument IS [NOT] OF, which was added in 7.3.
Bruce Momjian [Tue, 20 Feb 2007 00:25:05 +0000 (00:25 +0000)]
Document IS [NOT] OF, which was added in 7.3.

17 years agoAdd FAQ text about Makefile.custom:
Bruce Momjian [Mon, 19 Feb 2007 23:45:38 +0000 (23:45 +0000)]
Add FAQ text about Makefile.custom:

    <P><I>src/Makefile.custom</I> can be used to set environment variables,
    like <I>CUSTOM_COPT</I>, that are used for every compile.

17 years agoDocument that to_char('J'/Julian) is midnight-based, per report that
Bruce Momjian [Mon, 19 Feb 2007 22:51:44 +0000 (22:51 +0000)]
Document that to_char('J'/Julian) is midnight-based, per report that
Julian technically is noon to noon.

17 years agoWording improvement.
Bruce Momjian [Mon, 19 Feb 2007 22:10:52 +0000 (22:10 +0000)]
Wording improvement.

17 years agoUpdate PQfree() documentation to be clearer, backpatch to 8.2.X.
Bruce Momjian [Mon, 19 Feb 2007 22:06:23 +0000 (22:06 +0000)]
Update PQfree() documentation to be clearer, backpatch to 8.2.X.

17 years agoUpdate wording:
Bruce Momjian [Mon, 19 Feb 2007 21:08:48 +0000 (21:08 +0000)]
Update wording:

< * Consider allowing configuration of TOAST thresholds
> * Allow user configuration of TOAST thresholds

17 years agoAdd:
Bruce Momjian [Mon, 19 Feb 2007 21:07:25 +0000 (21:07 +0000)]
Add:

> * Consider allowing configuration of TOAST thresholds
>
>   http://archives.postgresql.org/pgsql-hackers/2007-02/msg00213.php
>

17 years agoAdd newlines.
Bruce Momjian [Mon, 19 Feb 2007 20:42:33 +0000 (20:42 +0000)]
Add newlines.

17 years agoAdd:
Bruce Momjian [Mon, 19 Feb 2007 20:41:40 +0000 (20:41 +0000)]
Add:

> * Allow UPDATEs on only non-referential integrity columns not to conflict
>   with referential integrity locks
>
>   http://archives.postgresql.org/pgsql-hackers/2007-02/msg00073.php

17 years agoAdd:
Bruce Momjian [Mon, 19 Feb 2007 20:06:56 +0000 (20:06 +0000)]
Add:

> * Allow INSERT/UPDATE ... RETURNING inside a SELECT 'FROM' clause
>
>   http://archives.postgresql.org/pgsql-general/2006-09/msg00803.php
>   http://archives.postgresql.org/pgsql-hackers/2006-10/msg00693.php
>

17 years agoClarify documentation that initdb -A or editing pg_hba.conf is required
Bruce Momjian [Mon, 19 Feb 2007 18:57:18 +0000 (18:57 +0000)]
Clarify documentation that initdb -A or editing pg_hba.conf is required
if you do not trust local users.

17 years agoClarify documentation for "day of the week" handling for to_char() and
Bruce Momjian [Mon, 19 Feb 2007 18:20:06 +0000 (18:20 +0000)]
Clarify documentation for "day of the week" handling for to_char() and
EXTRACT().

17 years agoDone:
Bruce Momjian [Mon, 19 Feb 2007 17:58:32 +0000 (17:58 +0000)]
Done:

> * -Add ISO day of week format 'ID' to to_char() where Monday = 1

17 years agoAdd "isodow" option to EXTRACT() and date_part() where Sunday = 7.
Bruce Momjian [Mon, 19 Feb 2007 17:41:39 +0000 (17:41 +0000)]
Add "isodow" option to EXTRACT() and date_part() where Sunday = 7.

17 years agoDone:
Bruce Momjian [Mon, 19 Feb 2007 17:21:24 +0000 (17:21 +0000)]
Done:

> * -Add a field 'isoyear' to extract(), based on the ISO week

17 years agoDone:
Bruce Momjian [Mon, 19 Feb 2007 16:36:17 +0000 (16:36 +0000)]
Done:

<  o Add long file support for binary pg_dump output
<
<    While Win32 supports 64-bit files, the MinGW API does not,
<    meaning we have to build an fseeko replacement on top of the
<    Win32 API, and we have to make sure MinGW handles it.  Another
<    option is to wait for the MinGW project to fix it, or use the
<    code from the LibGW32C project as a guide.
<
<    http://archives.postgresql.org/pgsql-hackers/2006-12/msg00551.php
<
>  o -Add long file support for binary pg_dump output

17 years agoFix pg_dump on win32 to properly dump files larger than 2Gb when using
Magnus Hagander [Mon, 19 Feb 2007 15:05:06 +0000 (15:05 +0000)]
Fix pg_dump on win32 to properly dump files larger than 2Gb when using
binary dump formats.

17 years agoParse pg_proc.h with entries without OIDs.
Magnus Hagander [Mon, 19 Feb 2007 14:05:42 +0000 (14:05 +0000)]
Parse pg_proc.h with entries without OIDs.

17 years agoGet rid of some old and crufty global variables in the planner. When
Tom Lane [Mon, 19 Feb 2007 07:03:34 +0000 (07:03 +0000)]
Get rid of some old and crufty global variables in the planner.  When
this code was last gone over, there wasn't really any alternative to
globals because we didn't have the PlannerInfo struct being passed all
through the planner code.  Now that we do, we can restructure things
to avoid non-reentrancy.  I'm fooling with this because otherwise I'd
have had to add another global variable for the planned compact
range table list.

17 years agoImprove plpgsql's error message when a datatype declaration is omitted.
Tom Lane [Mon, 19 Feb 2007 03:18:51 +0000 (03:18 +0000)]
Improve plpgsql's error message when a datatype declaration is omitted.
Per example from Jeff Ross.

17 years agoPut function expressions and values lists into FunctionScan and ValuesScan
Tom Lane [Mon, 19 Feb 2007 02:23:12 +0000 (02:23 +0000)]
Put function expressions and values lists into FunctionScan and ValuesScan
plan nodes, so that the executor does not need to get these items from
the range table at runtime.  This will avoid needing to include these
fields in the compact range table I'm expecting to make the executor use.

17 years agoFix portal management code to support non-default command completion tags for
Tom Lane [Sun, 18 Feb 2007 19:49:25 +0000 (19:49 +0000)]
Fix portal management code to support non-default command completion tags for
portals using PORTAL_UTIL_SELECT strategy.  This is currently significant only
for FETCH queries, which are supposed to include a count in the tag.  Seems
it's been broken since 7.4, but nobody noticed before Knut Lehre.

17 years agoDocument limitation of SPI_execute() using multiple queries in a single
Bruce Momjian [Sun, 18 Feb 2007 01:47:40 +0000 (01:47 +0000)]
Document limitation of SPI_execute() using multiple queries in a single
string.

17 years agoUpdate wording:
Bruce Momjian [Sun, 18 Feb 2007 01:34:35 +0000 (01:34 +0000)]
Update wording:

<   Currently, ALTER USER and ALTER DATABASE support per-user and
>   Currently ALTER USER and ALTER DATABASE support per-user and
<    Currently, subtracting one date from another that crosses a
>    Currently subtracting one date from another that crosses a
<   Currently, SQL-language functions can only refer to parameters via $1, etc
>   Currently SQL-language functions can only refer to dollar parameters,
>   e.g. $1
<   Currently, queries prepared via the libpq API are planned on first
>   Currently queries prepared via the libpq API are planned on first
<    Currently, SET <tab> causes a database lookup to check all
>    Currently SET <tab> causes a database lookup to check all
<    Currently, all statement results are transferred to the libpq
>    Currently all statement results are transferred to the libpq

17 years agoAdd:
Bruce Momjian [Sun, 18 Feb 2007 01:32:55 +0000 (01:32 +0000)]
Add:

* Allow SQL-language functions to reference parameters by parameter name

  Currently SQL-language functions can only refer to parameters via $1, etc

17 years agoUpdate "Conflicting lock modes" to show as conflict, add
Bruce Momjian [Sun, 18 Feb 2007 01:21:49 +0000 (01:21 +0000)]
Update "Conflicting lock modes" to show as conflict, add
current/requested headings, add link to table from text.

17 years agoAdd code so that when COPY_PARSE_PLAN_TREES is defined, the copy and
Tom Lane [Sat, 17 Feb 2007 19:33:32 +0000 (19:33 +0000)]
Add code so that when COPY_PARSE_PLAN_TREES is defined, the copy and
equal functions are checked for raw parse trees as well as post-analysis
trees.  This was never very important before, but the upcoming plan cache
control module will need to be able to do copyObject() on raw parse trees.

17 years agoRemove rint() for to_char MS and US output. We can't us rint() because
Bruce Momjian [Sat, 17 Feb 2007 03:11:32 +0000 (03:11 +0000)]
Remove rint() for to_char MS and US output.  We can't us rint() because
we can't overflow to the next higher units, and we might print the lower
units for MS.

17 years agoAdd:
Bruce Momjian [Sat, 17 Feb 2007 02:01:02 +0000 (02:01 +0000)]
Add:

> * Allow holdable cursors in SPI

17 years agoCleanup of to_char() patch.
Bruce Momjian [Sat, 17 Feb 2007 01:51:42 +0000 (01:51 +0000)]
Cleanup of to_char() patch.

Brendan Jurd

17 years agoAdd:
Bruce Momjian [Sat, 17 Feb 2007 01:35:41 +0000 (01:35 +0000)]
Add:
>
>  o Allow row and record variables to be set to NULL constants,
>    and allow NULL tests on such variables
>
>    Because a row is not scalar, do not allow assignment
>    from NULL-valued scalars.

17 years agoRemove installation mention that integer timestamps is less stable that
Bruce Momjian [Sat, 17 Feb 2007 01:26:24 +0000 (01:26 +0000)]
Remove installation mention that integer timestamps is less stable that
floating point.

17 years agoCreate AVG() aggregates for int8 and NUMERIC which do not compute X^2,
Bruce Momjian [Sat, 17 Feb 2007 00:55:58 +0000 (00:55 +0000)]
Create AVG() aggregates for int8 and NUMERIC which do not compute X^2,
as a performance enhancement.

Mark Kirkwood

17 years agoTeach find_nonnullable_rels to handle OR cases: if every arm of an OR
Tom Lane [Fri, 16 Feb 2007 23:32:08 +0000 (23:32 +0000)]
Teach find_nonnullable_rels to handle OR cases: if every arm of an OR
forces a particular relation nonnullable, then we can say that the OR does.
This is worth a little extra trouble since it may allow reduction of
outer joins to plain joins.

17 years agoAdd:
Bruce Momjian [Fri, 16 Feb 2007 22:20:02 +0000 (22:20 +0000)]
Add:

>  o Consider reducing on-disk varlena length from four to two
>    because a heap row cannot be more than 64k in length

17 years agoFix new RI operator selection code to do the right thing when working with
Tom Lane [Fri, 16 Feb 2007 22:04:02 +0000 (22:04 +0000)]
Fix new RI operator selection code to do the right thing when working with
an opclass for a generic type such as ANYARRAY.  The original coding failed
to check that PK and FK columns were of the same array type.  Per discussion
with Tom Dunstan.  Also, make the code a shade more readable by not trying
to economize on variables.

17 years agoReduce the amount of memory "clobbered" for every process title change,
Bruce Momjian [Fri, 16 Feb 2007 21:34:04 +0000 (21:34 +0000)]
Reduce the amount of memory "clobbered" for every process title change,
on platforms that need this.  This is done by only writing past the
previously stored message, if it was longer.

17 years agoAdjust the definition of is_pushed_down so that it's always true for INNER
Tom Lane [Fri, 16 Feb 2007 20:57:19 +0000 (20:57 +0000)]
Adjust the definition of is_pushed_down so that it's always true for INNER
JOIN quals, just like WHERE quals, even if they reference every one of the
join's relations.  Now that we can reorder outer and inner joins, it's
possible for such a qual to end up being assigned to an outer join plan node,
and we mustn't have it treated as a join qual rather than a filter qual for
the node.  (If it were, the join could produce null-extended rows that it
shouldn't.)  Per bug report from Pelle Johansson.

17 years agoBetter fix for determining minimum and maximum int64 values that doesn't
Peter Eisentraut [Fri, 16 Feb 2007 18:37:43 +0000 (18:37 +0000)]
Better fix for determining minimum and maximum int64 values that doesn't
require stdint.h and works for "busted" int64.

17 years agoInstall a more correct fix in the timestamp and timestamptz regression tests:
Alvaro Herrera [Fri, 16 Feb 2007 17:49:15 +0000 (17:49 +0000)]
Install a more correct fix in the timestamp and timestamptz regression tests:
remove duplicated tests in timestamp, and complete timestamptz with the tests
that were missing to more closely mirror timestamp.

17 years agoCode review for SSLKEY patch.
Tom Lane [Fri, 16 Feb 2007 17:07:00 +0000 (17:07 +0000)]
Code review for SSLKEY patch.

17 years agoFix markup, spelling, grammar, and explanations for SSLKEY patch.
Tom Lane [Fri, 16 Feb 2007 16:37:29 +0000 (16:37 +0000)]
Fix markup, spelling, grammar, and explanations for SSLKEY patch.

17 years agoFix the timestamptz test problem, by moving the tests that use the
Alvaro Herrera [Fri, 16 Feb 2007 15:42:42 +0000 (15:42 +0000)]
Fix the timestamptz test problem, by moving the tests that use the
timestamp_tbl table into the timestamp test.  Also, restore a test that
used to exist as a valid test in the timestamptz test.

17 years agoFix // comment
Peter Eisentraut [Fri, 16 Feb 2007 10:55:47 +0000 (10:55 +0000)]
Fix // comment