granicus.if.org Git - taglib/log

]> granicus.if.org Git - taglib/log

projects / taglib / log

summary | shortlog | log | commit | commitdiff | tree
first ⋅ prev ⋅ next

commit | commitdiff | tree

Scott Wheeler [Thu, 21 Jul 2005 00:10:57 +0000 (00:10 +0000)]

Fix up the RVA2 handling. I'm still not thrilled with the API, but this
should be functional enough to hold over to the next binary
incompatible change and has a minimum of differences to the previous
API.

I did a slightly nasty hack so that the API docs will see just methods
with an optional argument, but those are actually two separate methods
(for BC).

Brian, please feel free to take a look at this prior to 1.4 going out.

BUG:107025

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437115 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Wed, 20 Jul 2005 22:23:34 +0000 (22:23 +0000)]

Fix from Felix Berger to get RVA2 frames a little closer
to working. The more complicated fix for #107025 will
follow shortly.

BUG:95545

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437091 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Thiago Macieira [Sat, 16 Jul 2005 14:39:38 +0000 (14:39 +0000)]

Adding and updating svn:ignore

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@435313 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Wed, 13 Jul 2005 12:22:34 +0000 (12:22 +0000)]

Misspelling.

BUG:107847

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@434245 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Tue, 17 May 2005 23:57:23 +0000 (23:57 +0000)]

Instead of returning 0 on finding a deprecated frame type, create an
UnknownFrame and set the flag to discard it on write.

As a special bonus this meant implementing the discard-on-tag-alter
flag.

BUG:100515

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@415248 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Tue, 17 May 2005 22:38:01 +0000 (22:38 +0000)]

Patch from Umesh Shankar to make sure that the frameID is current.

CCMAIL:Umesh Shankar <ushankar@cs.berkeley.edu>

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@415233 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Tue, 17 May 2005 21:27:51 +0000 (21:27 +0000)]

Check to make sure that there's content before trying to return it.

Almost the same as a patch from Clemens Fuchslocher

CCMAIL:clemens@allesdurcheinander.de

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@415211 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Tue, 17 May 2005 20:45:05 +0000 (20:45 +0000)]

Do a bounds check before trying to find the mid.

CCMAIL:Felix Hupfeld <hupfeld@zib.de>

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@415196 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Allan Sandfeld Jensen [Sun, 3 Apr 2005 16:41:17 +0000 (16:41 +0000)]

Double-deleting won't make it much better

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@402896 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Sun, 3 Apr 2005 16:37:56 +0000 (16:37 +0000)]

...or this

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@402894 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Sun, 3 Apr 2005 16:36:17 +0000 (16:36 +0000)]

Didn't mean to check this in.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@402892 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Sun, 3 Apr 2005 16:35:55 +0000 (16:35 +0000)]

fix memory leaks

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@402891 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Allan Sandfeld Jensen [Sat, 2 Apr 2005 20:53:11 +0000 (20:53 +0000)]

Decode samplerate correctly.
BUG: 99829

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@402712 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Allan Sandfeld Jensen [Fri, 18 Mar 2005 00:10:21 +0000 (00:10 +0000)]

Sorry, that was actually wrong.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@398578 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Allan Sandfeld Jensen [Fri, 18 Mar 2005 00:02:27 +0000 (00:02 +0000)]

Support the new OggFLAC 1.0 standard from FLAC 1.1.2

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@398574 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Wed, 2 Feb 2005 19:04:54 +0000 (19:04 +0000)]

Nice catch from Gunnar Roth -- the iterator was invalid here.

BUG:94662

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@385470 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Fri, 14 Jan 2005 13:04:36 +0000 (13:04 +0000)]

Don't dereference the iterator before checking to make sure that we're not
at the end of the list. Thanks to Gunnar Roth for catching this one.

BUG:96926

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@378404 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Benjamin Meyer [Sun, 19 Dec 2004 05:45:33 +0000 (05:45 +0000)]

startsWith() should be used to avoid bugs like: s.mid(0, 4) == "Foo".

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@371832 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Wed, 8 Dec 2004 16:50:10 +0000 (16:50 +0000)]

Make the private class a friend so that it can access the protected Header
class.
BUG:93869

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@369269 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Benjamin Meyer [Mon, 22 Nov 2004 20:08:11 +0000 (20:08 +0000)]

convert "" comparison to use built in empty() function

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@365215 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Sun, 7 Nov 2004 16:10:40 +0000 (16:10 +0000)]

1.3.1

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@361202 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Sat, 6 Nov 2004 14:43:24 +0000 (14:43 +0000)]

...and now implement the missing contructor.

BUG:92803

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@360973 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Sat, 6 Nov 2004 14:31:55 +0000 (14:31 +0000)]

Clean up includes and actually install apeitem.h. Prior to this the APE
API wasn't usable. Fortunately I'm planning on releasing a 1.3.1 tomorrow.

CCMAIL:Allan Sandfeld Jensen <kde@carewolf.com>
CCBUG:92803

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@360971 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Sat, 6 Nov 2004 14:24:40 +0000 (14:24 +0000)]

Since these headers weren't even usable when installed, might as well go
ahead and remove the deprecated crap...

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@360969 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Sun, 31 Oct 2004 20:30:47 +0000 (20:30 +0000)]

Do bounds checking before assuming that just because we've been told that
there are actually more items that there actually are.

BUG:92028

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@359382 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Sun, 31 Oct 2004 19:27:24 +0000 (19:27 +0000)]

Add some text explaining the APE format since it's non-obvious trying to
find it online and it's poorly written once found.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@359360 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Sat, 30 Oct 2004 16:14:35 +0000 (16:14 +0000)]

CVS_SILENT back in here again -- checking in formatting before content...

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@359015 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Fri, 29 Oct 2004 13:48:55 +0000 (13:48 +0000)]

Don't write a track number if the track is larger than 255.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@358768 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Thu, 28 Oct 2004 23:27:29 +0000 (23:27 +0000)]

Make sure that the type conversion happens so that this number ends up being
the appropriate seek location. I'm pretty sure that this is what was causing
Ogg length information to not work on x86_64. Can you confirm Hamish?

BUG:86806

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@358653 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Thu, 28 Oct 2004 22:20:00 +0000 (22:20 +0000)]

CVS_SILENT this comment belongs here now

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@358639 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Thu, 28 Oct 2004 22:11:41 +0000 (22:11 +0000)]

Make sure that there's (a) data in a bytevector that we're trying to convert
to an integer before trying to convert it and (b) make sure that there's data
in an APE::Item before trying to parse it.

BUG:92028

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@358637 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Thu, 28 Oct 2004 22:05:43 +0000 (22:05 +0000)]

More cleanups and some API docs additions.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@358636 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Thu, 28 Oct 2004 21:22:33 +0000 (21:22 +0000)]

Semantic and style cleanups. render() should be const. Use for() loops to
loop through lists rather than while, fix bracket style.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@358627 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Wed, 20 Oct 2004 23:34:55 +0000 (23:34 +0000)]

This line is redundant.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@356359 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Wed, 20 Oct 2004 23:15:08 +0000 (23:15 +0000)]

Add some more docs on how to use the ID3v1::StringHandler in the ID3v1::Tag
documentation.

BUG:90634

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@356354 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Mon, 18 Oct 2004 15:31:12 +0000 (15:31 +0000)]

Move the sanity check before the unknown frame stuff. As the code currently
is if a bogus frame is hit it may try to parse it as an UnknownFrame rather
than just discarding it.

CCMAIL:Espen Tveit <espen.tveit@gmail.com>

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@355686 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Fri, 10 Sep 2004 02:23:31 +0000 (02:23 +0000)]

Forgot this. Time to redo the tarballs.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@345358 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Fri, 10 Sep 2004 02:13:40 +0000 (02:13 +0000)]

CVS_SILENT missing doc for the namespace

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@345357 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Fri, 10 Sep 2004 01:54:20 +0000 (01:54 +0000)]

1.3 -- bump the libtool version

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@345355 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Fri, 10 Sep 2004 01:42:56 +0000 (01:42 +0000)]

misplace conditional

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@345352 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Fri, 10 Sep 2004 01:29:49 +0000 (01:29 +0000)]

Patch from Allan to add support for compressed frames.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@345351 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Allan Sandfeld Jensen [Thu, 9 Sep 2004 23:49:49 +0000 (23:49 +0000)]

Remove some annoying debuging code.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@345343 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Thu, 9 Sep 2004 00:28:57 +0000 (00:28 +0000)]

Scott's silly nitpicks...

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@345141 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Wed, 8 Sep 2004 22:38:00 +0000 (22:38 +0000)]

Some API overview updates.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@345123 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Sun, 5 Sep 2004 17:55:47 +0000 (17:55 +0000)]

Mention the return type.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@344197 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Sun, 5 Sep 2004 17:54:00 +0000 (17:54 +0000)]

Don't try to do stuff to files that aren't valid.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@344196 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Allan Sandfeld Jensen [Thu, 2 Sep 2004 19:32:19 +0000 (19:32 +0000)]

Cleaning up. Better documentation and remove dead code.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@343588 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Allan Sandfeld Jensen [Thu, 2 Sep 2004 18:50:26 +0000 (18:50 +0000)]

Fix typo.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@343576 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Allan Sandfeld Jensen [Wed, 25 Aug 2004 15:37:53 +0000 (15:37 +0000)]

Set APELocation to the beginning of the APE-tag

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@340956 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Allan Sandfeld Jensen [Mon, 23 Aug 2004 21:57:07 +0000 (21:57 +0000)]

Some extra documentation.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@340248 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Allan Sandfeld Jensen [Mon, 23 Aug 2004 20:39:32 +0000 (20:39 +0000)]

Find the starting position.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@340210 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Allan Sandfeld Jensen [Mon, 23 Aug 2004 20:38:47 +0000 (20:38 +0000)]

Update interface. Just needs more documentation now.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@340209 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Allan Sandfeld Jensen [Mon, 23 Aug 2004 15:26:23 +0000 (15:26 +0000)]

Convert from ByteVectorList to StringList

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@340107 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Allan Sandfeld Jensen [Sun, 15 Aug 2004 21:14:12 +0000 (21:14 +0000)]

APE-tags for mp3s.
Currently they are for special purposes only, and thus not used as a part
of the union tag.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@338184 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Sun, 8 Aug 2004 06:04:42 +0000 (06:04 +0000)]

add api docs

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@336790 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Sat, 7 Aug 2004 20:23:10 +0000 (20:23 +0000)]

Make sure that we're not setting the string size to -1.

CCMAIL:ismail donmez <kde@myrealbox.com>

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@336760 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Sat, 7 Aug 2004 01:39:26 +0000 (01:39 +0000)]

CVS_SILENT forgot a short description

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@336647 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Sat, 7 Aug 2004 00:59:16 +0000 (00:59 +0000)]

Adding support for the Unique File Identifier ID3v2 frame type (UFID).

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@336640 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Fri, 6 Aug 2004 23:41:56 +0000 (23:41 +0000)]

Add support for custom ID3v2 text frames (TXXX).

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@336629 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Fri, 6 Aug 2004 21:51:32 +0000 (21:51 +0000)]

Add overloads here so that the return type is in fact StringList.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@336601 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Fri, 6 Aug 2004 21:07:46 +0000 (21:07 +0000)]

Return a reference to the current list from append().

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@336591 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Fri, 6 Aug 2004 01:54:28 +0000 (01:54 +0000)]

Here's an oops -- this *really* should have been virtual. I'm not sure how
I missed that. I'll come up with something -- probably a functor or similar
to work around this at some point.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@336480 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Mon, 2 Aug 2004 19:35:47 +0000 (19:35 +0000)]

Ignore compressed and encrypted ID3v2 frames rather than just blindly giving
back the compressed/encrypted data as a string.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@335256 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Mon, 2 Aug 2004 12:51:14 +0000 (12:51 +0000)]

Always explicitly check for divide by zero conditions.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@335132 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Allan Sandfeld Jensen [Sun, 1 Aug 2004 23:30:06 +0000 (23:30 +0000)]

Create a correct footer

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@334982 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Allan Sandfeld Jensen [Sun, 1 Aug 2004 23:29:42 +0000 (23:29 +0000)]

A few changes to make the interface more flexible. It can now remove
tags including ID3v2.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@334981 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Tue, 27 Jul 2004 02:35:47 +0000 (02:35 +0000)]

Standard stuff -- make it fit with the coding style of the rest of TagLib
and make it build. There are still some missing API docs and I'm not sure
how I feel about non-opaque types (Item in this case) since they're not used
elsewhere in the API, but this will do for now.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@333117 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Tue, 27 Jul 2004 02:00:01 +0000 (02:00 +0000)]

This is wrong -- this would indicate a BIC library release. Please see
"info:/libtool/Updating version info" when changing the libtool version
string.

CCMAIL:Allan Sandfeld Jensen <kde@carewolf.com>

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@333116 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Allan Sandfeld Jensen [Mon, 26 Jul 2004 19:04:40 +0000 (19:04 +0000)]

Make mpc use the new APETag-structure

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@333012 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Allan Sandfeld Jensen [Mon, 26 Jul 2004 19:03:28 +0000 (19:03 +0000)]

Refactoring.
APE-tags are not native to musepack, so I am moving it out.
Seperated footer-decoding the same way header-decoding is seperated in
ID3v2.
Fixed a bug with the version in the footer. Should be 2000 (read 2.000) not 2.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@333011 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Mon, 26 Jul 2004 13:44:59 +0000 (13:44 +0000)]

missing const

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@332913 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Allan Sandfeld Jensen [Mon, 26 Jul 2004 12:58:59 +0000 (12:58 +0000)]

Large update:
* Give access to APEv2 features like lists and read-only fields (not enforced by TagLib).
* Support one common mistake: ID3v1 tags placed after an APE-tag. In this case both tags are now read and maintained. APE-tags after an ID3v1 tag is not supported.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@332903 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Mon, 26 Jul 2004 03:39:34 +0000 (03:39 +0000)]

Mark HEAD as TagLib 1.3

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@332793 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Mon, 26 Jul 2004 03:14:05 +0000 (03:14 +0000)]

Provide a default (empty) value for the language. The lack thereof was was
causing the bytes to not get lined up properly in the newly written tag and
then they weren't read back properly.

CCMAIL:82898-done@bugs.kde.org

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@332788 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Mon, 26 Jul 2004 02:44:23 +0000 (02:44 +0000)]

Use setData() rather than parseFields() here to make sure that the frame
header is initialized.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@332785 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Mon, 26 Jul 2004 02:22:05 +0000 (02:22 +0000)]

Make it possible to strip tags without deleting them (again). This is
used by MPEG::File::save() so that tags that aren't explicitly saves still
exist in memory.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@332783 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Mon, 26 Jul 2004 02:19:26 +0000 (02:19 +0000)]

CVS_SILENT indentation oops from the last commit

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@332782 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Mon, 26 Jul 2004 01:49:18 +0000 (01:49 +0000)]

Update the ID3v1 location when stripping the ID3v2 tag.

CCMAIL:83926-done@bugs.kde.org

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@332780 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Mon, 26 Jul 2004 01:29:39 +0000 (01:29 +0000)]

Fix a number of bugs to get things working with ID3v2.4 tags generated by
libid3tag:

*) Handle the case of there being an extended header where the first byte
   is zero (this was running into a check to see if the padding had been
   reached)
*) Add support for reading ID3v2::Frame::Header flags.  Previously this
   was not implemented, but was needed to...
*) Properly adjust the reading position for the existance of a data length
   indicator at the beginning of frames

Things now seem to work with the test files that I have here.  Since this
is the only other ID3v2.4 implmentation that I know of "in the wild" it's
nice that they now play nice together.  libid3tag uses many more of the
unique ID3v2.4 features than TagLib does.

CCMAIL:82867-done@bugs.kde.org

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@332778 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Sat, 24 Jul 2004 17:30:54 +0000 (17:30 +0000)]

Return a bool indicating if the save was successful as in File::save()

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@332349 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Tue, 20 Jul 2004 22:50:30 +0000 (22:50 +0000)]

Off by one -- make tagreader work with mpc files.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@331318 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Tue, 20 Jul 2004 22:46:38 +0000 (22:46 +0000)]

Add MPC to the C bindings.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@331317 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Tue, 20 Jul 2004 22:40:57 +0000 (22:40 +0000)]

A few more nitpicks.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@331315 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Tue, 20 Jul 2004 22:30:00 +0000 (22:30 +0000)]

standard style nitpicks and make it build with gcc 2.95

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@331313 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Allan Sandfeld Jensen [Mon, 19 Jul 2004 17:22:32 +0000 (17:22 +0000)]

Improve behavoir:
* use setValid(false) to indicate broken files
* avoid reading over file-end in case of truncated files
* subtract size of ID3v1 from streamSize
* skip known ID3v2 tag when scanning for first FLAC-frame
CCMAIL: 83924-done@bugs.kde.org
CCMAIL: 85356@bugs.kde.org

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@330951 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Allan Sandfeld Jensen [Sat, 17 Jul 2004 16:04:50 +0000 (16:04 +0000)]

Correct includes so they work when included with path,
like: #include <taglib/mpcfile.h>

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@330329 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Allan Sandfeld Jensen [Sat, 17 Jul 2004 14:19:48 +0000 (14:19 +0000)]

Also update taglib-config

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@330302 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Allan Sandfeld Jensen [Sat, 17 Jul 2004 14:17:09 +0000 (14:17 +0000)]

Fix a bit of bitrot

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@330300 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Allan Sandfeld Jensen [Sat, 17 Jul 2004 13:39:27 +0000 (13:39 +0000)]

Add support for reading musepack(mpc)-files and parsing APE-tags(v1 and v2).
Bumb version to have something to check for in JuK and kfile_mpc

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@330294 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Allan Sandfeld Jensen [Wed, 14 Jul 2004 11:33:46 +0000 (11:33 +0000)]

Compile

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@329093 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Allan Sandfeld Jensen [Tue, 13 Jul 2004 18:28:50 +0000 (18:28 +0000)]

Add find and erase semantics like those in tlist.h

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@328830 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Waldo Bastian [Mon, 12 Jul 2004 16:07:27 +0000 (16:07 +0000)]

Valgrind says home-brew strdup() is broken
Fixes saving of MP3 meta-info from properties dialog

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@328336 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Sat, 26 Jun 2004 14:26:36 +0000 (14:26 +0000)]

Fix spelling.

CCMAIL:83908-done@bugs.kde.org

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@323801 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Thu, 24 Jun 2004 15:48:58 +0000 (15:48 +0000)]

Don't try to read the properties from the bytevector if it's smaller than
the required size; in this case empty. Also some minor nitpicks along the
way.

CCMAIL:83898-done@bugs.kde.org

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@323360 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Wed, 23 Jun 2004 22:39:39 +0000 (22:39 +0000)]

CVS_SILENT add a note in the docs about strip() behavior

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@323204 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Wed, 23 Jun 2004 22:38:21 +0000 (22:38 +0000)]

Another nice patch from Teemu Tervo. This deletes the tags from memory
when they're stripped from the file.

CCMAIL:83424-done@bugs.kde.org

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@323203 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Wed, 23 Jun 2004 21:52:27 +0000 (21:52 +0000)]

Update the C bindings to reflect the earlier change in the return type
for saving files.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@323195 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Wed, 23 Jun 2004 18:45:26 +0000 (18:45 +0000)]

oops -- forgot FLAC -- return bool for the FLAC::File::save() too to provide
some information on if the save was successful.

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@323170 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Wed, 23 Jun 2004 18:37:00 +0000 (18:37 +0000)]

CVS_SILENT forgot to save this file before the last commit -- doc update

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@323166 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

commit | commitdiff | tree

Scott Wheeler [Wed, 23 Jun 2004 18:35:52 +0000 (18:35 +0000)]

Switch the return type of File::save() from void to bool to provide a little
bit of feedback on whether or not the safe operation worked.

CCMAIL:83882@bugs.kde.org

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@323165 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

Unnamed repository; edit this file 'description' to name the repository.