Tom Lane [Mon, 30 Sep 2002 20:18:59 +0000 (20:18 +0000)]
Back-patch fix for 'can't wait without a PROC structure' failures:
remove separate ShutdownBufferPoolAccess exit callback, and do the
work in ProcKill instead, before we delete MyProc.
Tom Lane [Fri, 20 Sep 2002 21:37:07 +0000 (21:37 +0000)]
Back-patch fix for failure to dump views containing FULL JOIN USING.
The bug is not present in CVS tip due to cleanup of JOIN handling,
but 7.2.* is broken.
Tom Lane [Sat, 15 Jun 2002 18:38:10 +0000 (18:38 +0000)]
Back-patch 7.3 fix to fully parenthesize UNION/EXCEPT/INTERSECT queries
in ruleutils output. The previous partial parenthesization was a hack
to get around grammar restrictions that have since been fixed; and as
Sam O'Connor pointed out, there were cases where it didn't work.
Bruce Momjian [Fri, 7 Jun 2002 21:53:09 +0000 (21:53 +0000)]
Please apply attached patch to contrib/intarray (7.2, 7.3).
Fixed bug with '=' operator for gist__int_ops and
define '=' operator for gist__intbig_ops opclass.
Now '=' operator is consistent with standard 'array' type.
Thanks Achilleus Mantzios for bug report and suggestion.
Tom Lane [Wed, 22 May 2002 17:29:45 +0000 (17:29 +0000)]
Make RelationForgetRelation error out if the relcache entry has nonzero
reference count. This avoids leaving dangling pointers around, as in
recent bug report against sequences (bug# 671).
Tom Lane [Tue, 14 May 2002 18:16:54 +0000 (18:16 +0000)]
Remove unnecessary pfree's in geometric operators. At least one of these
is actively dangerous, per bug report from Ewald Geschwinde 14-May-02,
and several of the rest look suspicious to me. Since there is no longer
any significant value in retail pfree's in these functions, just get
rid of all of them for safety's sake.
A backport patch.
Fix PQescapeBytea/PQunescapeBytea so that they handle bytes > 0x7f.
This is necessary for mulibyte character sequences.
See "[HACKERS] PQescapeBytea is not multibyte aware" thread posted around
2002/04/05 for more details.
Tom Lane [Tue, 2 Apr 2002 05:12:00 +0000 (05:12 +0000)]
Fix CLOG truncation code to not do the Wrong Thing when there are already
wrapped-around databases. The unvacuumed databases might be fine, or
they might not, but things will definitely not be fine if we remove the
wrong CLOG segments. Per trouble report from Gary Wolfe, 1-Apr-2002.
Bruce Momjian [Tue, 19 Mar 2002 14:16:32 +0000 (14:16 +0000)]
> > Users of contrib/tsearch needs after upgrading of module (compiling, installing)
> > to perform sql command:
> > update pg_amop set amopreqcheck = true where amopclaid =
> > (select oid from pg_opclass where opcname = 'gist_txtidx_ops');
>
> Oleg, sorry, I don't understand where this should appear. In the README
> file, and if so, where? Is this something only for people upgrading
> from 7.2?
Sorry Bruce, I was unclear. I have attached patch to Readme.tsearch
Also, It'd be worth to mention in Changes to point users of tsearch
about importang upgrade notices.
Tom Lane [Fri, 15 Mar 2002 19:20:47 +0000 (19:20 +0000)]
Repair two problems with WAL logging of sequence nextvalI() ops, as
per recent pghackers discussion: force a new WAL record at first nextval
after a checkpoint, and ensure that xlog is flushed to disk if a nextval
record is the only thing emitted by a transaction.
Bruce Momjian [Tue, 5 Mar 2002 06:10:49 +0000 (06:10 +0000)]
Please, apply attached patch for contrib/tsearch to 7.2.1 and current
CVS. It fix english stemmer's problem with ending words like
'technology'.
We have found one more bug in english stemmer. The bug is with
'irregular' english words like 'skies' -> 'sky'. Please, apply attached
cumulative patch to 7.2.1 and current CVS instead previous one.
Thank to Thomas T. Thai <tom@minnesota.com> for hard testing. This kind
of bug has significance only for dump/reload database and viewing, but
searching/indexing works right.
Tom Lane [Tue, 5 Mar 2002 05:13:36 +0000 (05:13 +0000)]
Previous patch to mark UNION outputs with common typmod (if any) breaks
three-or-more-way UNIONs, as per example from Josh Berkus. Cause is a
fragile assumption that one tlist's entries will exactly match another.
Restructure code to make that assumption a little less fragile.
Tatsuo Ishii [Tue, 5 Mar 2002 03:45:44 +0000 (03:45 +0000)]
A backport patch:
Fix bug in extract/date_part for milliseconds/miscroseconds and
timestamp/timestamptz combo. Now extract/date_part returns
seconds*1000 or 1000000 + fraction part as the manual stats.
regression test are also fixed.
Tatsuo Ishii [Wed, 27 Feb 2002 01:47:31 +0000 (01:47 +0000)]
Back-patch fix for followings:
Fix bug in COPY FROM when DELIMITER is not in ASCII range.
See pgsql-bugs/pgsql-hackers discussion "COPY FROM is not 8bit clean"
around 2002/02/26 for more details -- Tatsuo Ishii
Tom Lane [Tue, 26 Feb 2002 23:48:47 +0000 (23:48 +0000)]
Back-patch fix for command completion report handling. This is
primarily needed so that INSERTing a row still reports the row's OID
even when there are ON INSERT rules firing additional queries.
Tom Lane [Mon, 25 Feb 2002 21:37:47 +0000 (21:37 +0000)]
Tweak psql's \connect command to not downcase unquoted database and user
names. This is a temporary measure to allow backwards compatibility with
7.2 and earlier pg_dump. 7.2.1 and later pg_dump will double-quote mixed
case names in \connect. Once we feel that older dumps are not a problem
anymore, we can revert this change and treat \connect arguments as normal
SQL identifiers.
Bruce Momjian [Fri, 22 Feb 2002 06:08:48 +0000 (06:08 +0000)]
BACKPATCH:
Please, apply attached patch of contrib/btree_gist to 7.2.1 and current
cvs.
The patch fixes memory leak during creation GiST index on timestamp
column.
Bruce Momjian [Sun, 17 Feb 2002 11:50:09 +0000 (11:50 +0000)]
I think it's important that it's actually documented that they can add
primary keys after the fact!
Also, we need to add regression tests for alter table / add primary key
and alter table / drop constraint. These shouldn't be added until 7.3
tho
methinks...
Tom Lane [Thu, 14 Feb 2002 15:24:10 +0000 (15:24 +0000)]
Ensure that a cursor is scanned under the same scanCommandId it was
originally created with, so that the set of visible tuples does not
change as a result of other activity. This essentially makes PG cursors
INSENSITIVE per the SQL92 definition. See bug report of 13-Feb-02.
Tom Lane [Wed, 13 Feb 2002 19:32:17 +0000 (19:32 +0000)]
Point out that --adduser actually makes the new user a superuser. This
was mentioned on the man page for the underlying CREATE USER command,
but it should be explained here too.
Tom Lane [Tue, 12 Feb 2002 23:41:25 +0000 (23:41 +0000)]
Use RTLD_NOW, not RTLD_LAZY, as binding mode for dlopen() on all platforms.
This restores the Linux behavior to what it was in PG 7.0 and 7.1, and
causes other platforms to agree. (Other well-tested platforms like HPUX
were doing it this way already.) Per pghackers discussion over the past
month or so.
Tom Lane [Tue, 12 Feb 2002 21:25:41 +0000 (21:25 +0000)]
Modify COPY TO to emit carriage returns and newlines as backslash escapes
(backslash-r, backslash-n) for protection against newline-conversion
munging. In future we will also tweak COPY FROM, but this part of the
change should be backwards-compatible. Per pghackers discussion.
Also, update COPY reference page to describe the backslash conversions
more completely and accurately.
Tom Lane [Mon, 11 Feb 2002 22:41:59 +0000 (22:41 +0000)]
Tweak GiST code to work correctly on machines where 8-byte alignment
of pointers is required. Patch from Teodor Sigaev per pghackers
discussion. It's an ugly kluge but avoids forcing initdb; we'll put
a better fix into 7.3 or later.
Tom Lane [Mon, 11 Feb 2002 20:10:50 +0000 (20:10 +0000)]
Repair problems with EvalPlanQual where target table is scanned as
inner indexscan (ie, one with runtime keys). ExecIndexReScan must
compute or recompute runtime keys even if we are rescanning in the
EPQ case. TidScan seems to have comparable problems. Per bug
noted by Barry Lind 11-Feb-02.
Tom Lane [Mon, 11 Feb 2002 00:14:10 +0000 (00:14 +0000)]
pg_dump and pg_restore man pages need to mention that one should restore
into a virgin database, ie, one created from template0, if there are any
site-local additions in template1.
Tom Lane [Sun, 10 Feb 2002 22:56:31 +0000 (22:56 +0000)]
Don't Assert() that fsync() and close() never fail; I have seen this
crash on Solaris when over disk quota. Instead, report such failures
via elog(DEBUG).