]> granicus.if.org Git - php/log
php
4 years agoMerge branch 'PHP-7.4' into PHP-8.0
Nikita Popov [Fri, 27 Nov 2020 09:03:02 +0000 (10:03 +0100)]
Merge branch 'PHP-7.4' into PHP-8.0

* PHP-7.4:
  Fixed bug #80425

4 years agoFixed bug #80425
Nikita Popov [Fri, 27 Nov 2020 09:02:00 +0000 (10:02 +0100)]
Fixed bug #80425

Rename the methods in MessageFormatAdapter to make sure they don't
clash with anything defined by icu itself, which may be a problem
if icu is linked statically.

4 years agoUpdate PECL package release date
Christopher Jones [Thu, 26 Nov 2020 23:17:37 +0000 (10:17 +1100)]
Update PECL package release date

4 years agoFix bug number
Christoph M. Becker [Thu, 26 Nov 2020 22:34:35 +0000 (23:34 +0100)]
Fix bug number

4 years agoEliminate deafd stores
Dmitry Stogov [Thu, 26 Nov 2020 18:05:07 +0000 (21:05 +0300)]
Eliminate deafd stores

4 years agoMerge branch 'PHP-7.4' into PHP-8.0
Nikita Popov [Thu, 26 Nov 2020 10:56:00 +0000 (11:56 +0100)]
Merge branch 'PHP-7.4' into PHP-8.0

* PHP-7.4:
  Fix bug #80402: Don't strip -lpthread

4 years agoFix bug #80402: Don't strip -lpthread
Nikita Popov [Tue, 24 Nov 2020 11:23:03 +0000 (12:23 +0100)]
Fix bug #80402: Don't strip -lpthread

The current behavior has been introduced 20 years ago in
f9e375f493a1aeacbbcc8f2f00880d05b4ba7aaf as part of a larger change.
It's not clear to me why special treatement of -lpthread is necessary
here.

4 years agoRemove -dev from ZEND_VERSION
Sara Golemon [Thu, 26 Nov 2020 02:19:12 +0000 (02:19 +0000)]
Remove -dev from ZEND_VERSION

4 years agoAdd UPGRADING note for PDO::inTransaction()
Nikita Popov [Wed, 25 Nov 2020 16:28:23 +0000 (17:28 +0100)]
Add UPGRADING note for PDO::inTransaction()

[ci skip]

4 years agoMerge branch 'PHP-7.4' into PHP-8.0
Nikita Popov [Wed, 25 Nov 2020 16:24:49 +0000 (17:24 +0100)]
Merge branch 'PHP-7.4' into PHP-8.0

* PHP-7.4:
  Fixed bug #80411

4 years agoFixed bug #80411
Nikita Popov [Wed, 25 Nov 2020 16:23:42 +0000 (17:23 +0100)]
Fixed bug #80411

References to null-serializations are stored as null, and as such
are part of the reference count.

Reminds me that we really need to deprecate the mess that is
Serializable.

4 years agoFix unserialization ref source management, again
Nikita Popov [Wed, 25 Nov 2020 16:04:07 +0000 (17:04 +0100)]
Fix unserialization ref source management, again

Handle one case the previous patch did not account for: If
unserialization of data fails, we should still register a ref
source.

Also add an extra test for a reference between two typed properties,
as this used to be handled incorrectly earlier.

4 years agoMerge branch 'PHP-7.4' into PHP-8.0
Nikita Popov [Wed, 25 Nov 2020 15:29:00 +0000 (16:29 +0100)]
Merge branch 'PHP-7.4' into PHP-8.0

* PHP-7.4:
  Fixed error reporting in mysqli_stmt::__construct

4 years agoFixed error reporting in mysqli_stmt::__construct
Dharman [Tue, 24 Nov 2020 23:02:04 +0000 (23:02 +0000)]
Fixed error reporting in mysqli_stmt::__construct

For the sake of simplicity, I've synchronized the implementation
with PHP 8, which means null values are also accepted.

Closes GH-6454.

4 years agoMerge branch 'PHP-7.4' into PHP-8.0
Nikita Popov [Wed, 25 Nov 2020 15:08:28 +0000 (16:08 +0100)]
Merge branch 'PHP-7.4' into PHP-8.0

* PHP-7.4:
  Reindent more mysqli tests

4 years agoFix phpt reindentation in tidy script
Nikita Popov [Wed, 25 Nov 2020 15:07:56 +0000 (16:07 +0100)]
Fix phpt reindentation in tidy script

This was missing adjacent SKIPIF/FILE/CLEAN sections.

4 years agoReindent more mysqli tests
Nikita Popov [Wed, 25 Nov 2020 15:07:16 +0000 (16:07 +0100)]
Reindent more mysqli tests

Due to a bug in the tidy script, most tests did not actually get
reindented...

4 years agoMerge branch 'PHP-7.4' into PHP-8.0
Nikita Popov [Wed, 25 Nov 2020 14:58:21 +0000 (15:58 +0100)]
Merge branch 'PHP-7.4' into PHP-8.0

* PHP-7.4:
  Reindent ext/mysqli tests

4 years agoReindent ext/mysqli tests
Nikita Popov [Wed, 25 Nov 2020 14:57:11 +0000 (15:57 +0100)]
Reindent ext/mysqli tests

Reindent ext/mysqli tests on PHP-7.4, so they match with the
indentation on PHP-8.0. Otherwise merging test changes across
branches is very unpleasant.

4 years agoAllow running tidy.php on specific directory
Nikita Popov [Wed, 25 Nov 2020 14:54:26 +0000 (15:54 +0100)]
Allow running tidy.php on specific directory

4 years agoFix ref source management during unserialization
Nikita Popov [Wed, 25 Nov 2020 11:25:07 +0000 (12:25 +0100)]
Fix ref source management during unserialization

Only register the slot for adding ref sources later if we didn't
immediately register one. Also avoids leaking a ref source if
it is added early and the assignment fails.

Fixes oss-fuzz #27628.

4 years agosockets: Fix variable/macro name collision on AIX
Calvin Buckley [Tue, 24 Nov 2020 19:45:34 +0000 (15:45 -0400)]
sockets: Fix variable/macro name collision on AIX

The name "rem_size" is used by a macro in a system header on AIX,
specifically `sys/xmem.h`. Without changing the name, you get the
name mangled like so:

```
In file included from /usr/include/sys/uio.h:92:0,
                 from /QOpenSys/pkgs/lib/gcc/powerpc-ibm-aix6.1.0.0/6.3.0/include-fixed-7.1/sys/socket.h:83,
                 from /usr/include/sys/syslog.h:151,
                 from /usr/include/syslog.h:29,
                 from /home/calvin/rpmbuild/BUILD/php-8.0.0RC5/main/php_syslog.h:27,
                 from /home/calvin/rpmbuild/BUILD/php-8.0.0RC5/main/php.h:318,
                 from /home/calvin/rpmbuild/BUILD/php-8.0.0RC5/ext/sockets/sendrecvmsg.c:17:
/home/calvin/rpmbuild/BUILD/php-8.0.0RC5/ext/sockets/sendrecvmsg.c: In function 'zif_socket_cmsg_space':
/home/calvin/rpmbuild/BUILD/php-8.0.0RC5/ext/sockets/sendrecvmsg.c:298:10: error: expected '=', ',', ';', 'asm' or '__attribute__' before '.' token
   size_t rem_size = ZEND_LONG_MAX - entry->size;
          ^
/home/calvin/rpmbuild/BUILD/php-8.0.0RC5/ext/sockets/sendrecvmsg.c:298:10: error: expected expression before '.' token
/home/calvin/rpmbuild/BUILD/php-8.0.0RC5/ext/sockets/sendrecvmsg.c:299:18: error: 'u2' undeclared (first use in this function)
   size_t n_max = rem_size / entry->var_el_size;
                  ^
/home/calvin/rpmbuild/BUILD/php-8.0.0RC5/ext/sockets/sendrecvmsg.c:299:18: note: each undeclared identifier is reported only once for each function it appears in
```

...because of the declaration in `sys/xmem.h`:

```
```

This just renames the variable so that it won't trip on this
definition. Tested to fix the build on IBM i PASE.

Closes GH-6453.

4 years agoFixed bug #80377
Nikita Popov [Tue, 24 Nov 2020 14:52:41 +0000 (15:52 +0100)]
Fixed bug #80377

Make sure the $PHP_THREAD_SAFETY variable is always available
when configuring extensions. It was previously available for
phpized extensions, but for in-tree builds it was being set
too late.

Then, use $PHP_THREAD_SAFETY instead of $enable_zts to check for
ZTS in bundled extensions, which makes sure these checks also
work for phpize builds.

4 years agoFix test diff
Christopher Jones [Wed, 25 Nov 2020 05:42:12 +0000 (16:42 +1100)]
Fix test diff

4 years agoUse diferent temporary register (%r0 may keep a method address)
Dmitry Stogov [Wed, 25 Nov 2020 00:49:42 +0000 (03:49 +0300)]
Use diferent temporary register (%r0 may keep a method address)

4 years agoRevert "Fixed bug #80377"
Dmitry Stogov [Tue, 24 Nov 2020 22:10:26 +0000 (01:10 +0300)]
Revert "Fixed bug #80377"

This reverts commit fc26ad9b1220fdfd7db15ecaff5e7c38283c55b6.

4 years ago[ci skip] Fix misspelled method names
Florian Engelhardt [Tue, 24 Nov 2020 15:48:17 +0000 (16:48 +0100)]
[ci skip] Fix misspelled method names

Closes GH-6452.

4 years agoMerge branch 'PHP-7.4' into PHP-8.0
Nikita Popov [Tue, 24 Nov 2020 15:42:52 +0000 (16:42 +0100)]
Merge branch 'PHP-7.4' into PHP-8.0

* PHP-7.4:
  Fix usage of casted string in ReflectionParameter ctor

4 years agoFix usage of casted string in ReflectionParameter ctor
Nikita Popov [Tue, 24 Nov 2020 15:41:18 +0000 (16:41 +0100)]
Fix usage of casted string in ReflectionParameter ctor

Fixes oss-fuzz #27755.

4 years agoFixed bug #80377
Nikita Popov [Tue, 24 Nov 2020 14:52:41 +0000 (15:52 +0100)]
Fixed bug #80377

Use $PHP_THREAD_SAFETY instead of $enable_zts to check for ZTS.
This variable is also available for phpize builds, while enable_zts
is only present for in-tree builds.

4 years agoMerge branch 'PHP-7.4' into PHP-8.0
Nikita Popov [Tue, 24 Nov 2020 14:27:35 +0000 (15:27 +0100)]
Merge branch 'PHP-7.4' into PHP-8.0

* PHP-7.4:
  Fixed bug #80393

4 years agoFixed bug #80393
Nikita Popov [Tue, 24 Nov 2020 14:26:40 +0000 (15:26 +0100)]
Fixed bug #80393

Handle macos versions that don't start with 10.* in libtool.

Patch by kir dot morozov at gmail dot com.

4 years agoAllow PHP_CURL_APIs to be imported by DLLs
Christoph M. Becker [Thu, 19 Nov 2020 14:42:01 +0000 (15:42 +0100)]
Allow PHP_CURL_APIs to be imported by DLLs

Closes GH-6438.

4 years agoMerge branch 'PHP-7.4' into PHP-8.0
Christoph M. Becker [Tue, 24 Nov 2020 13:06:19 +0000 (14:06 +0100)]
Merge branch 'PHP-7.4' into PHP-8.0

* PHP-7.4:
  Fix #77961: finfo_open crafted magic parsing SIGABRT

4 years agoFix #77961: finfo_open crafted magic parsing SIGABRT
Christoph M. Becker [Mon, 23 Nov 2020 16:12:46 +0000 (17:12 +0100)]
Fix #77961: finfo_open crafted magic parsing SIGABRT

libmagic may abort the running process, which is not desirable for PHP;
we raise a fatal error instead.

Closes GH-6437.

4 years ago[ci skip] Update generate_patch.sh
Christoph M. Becker [Tue, 24 Nov 2020 12:35:15 +0000 (13:35 +0100)]
[ci skip] Update generate_patch.sh

This has apparently been forgotten when updating to libmagic 5.39.

4 years agoMerge branch 'PHP-7.4' into PHP-8.0
Christoph M. Becker [Tue, 24 Nov 2020 12:10:18 +0000 (13:10 +0100)]
Merge branch 'PHP-7.4' into PHP-8.0

* PHP-7.4:
  Fix #80366: Return Value of zend_fstat() not Checked

4 years agoFix #80366: Return Value of zend_fstat() not Checked
Christoph M. Becker [Tue, 17 Nov 2020 13:42:22 +0000 (14:42 +0100)]
Fix #80366: Return Value of zend_fstat() not Checked

In the somewhat unlikely case that `zend_fstat()` fails, we must not
proceed executing the function, but return `false` instead.

Patch based on the patch contributed by sagpant at microsoft dot com.

Closes GH-6432.

4 years agoMerge branch 'PHP-7.4' into PHP-8.0
Nikita Popov [Tue, 24 Nov 2020 12:02:08 +0000 (13:02 +0100)]
Merge branch 'PHP-7.4' into PHP-8.0

* PHP-7.4:
  Fixed bug #80362: Running dtrace scripts can cause php to crash

4 years agoFixed bug #80362: Running dtrace scripts can cause php to crash
Nikita Popov [Tue, 24 Nov 2020 12:00:53 +0000 (13:00 +0100)]
Fixed bug #80362: Running dtrace scripts can cause php to crash

Patch by al at coralnet dot name.

4 years agoFixed bug #80404
Nikita Popov [Tue, 24 Nov 2020 10:31:53 +0000 (11:31 +0100)]
Fixed bug #80404

For a division like [1..1]/[2..2] produce [0..1] as a result, which
would be the integer envelope of the floating-point result.

The implementation is pretty ugly (we're now taking min/max across
eight values...) but I couldn't come up with a more elegant way
to handle this that doesn't make things a lot more complex (the
division sign handling is the annoying issue here).

4 years agoFixed bug #80391
Nikita Popov [Tue, 24 Nov 2020 09:09:28 +0000 (10:09 +0100)]
Fixed bug #80391

Iterable was not considered a subtype of array|object, and thus
also not a subtype of mixed.

4 years agoFix PDOStatement::fetchObject() stub
Benjamin Morel [Mon, 23 Nov 2020 22:24:20 +0000 (23:24 +0100)]
Fix PDOStatement::fetchObject() stub

Closes GH-6449.

4 years agoSync README with package.xml
Christopher Jones [Mon, 23 Nov 2020 23:45:48 +0000 (10:45 +1100)]
Sync README with package.xml

4 years agoFix COMPersistHelper::__construct() stub
Christoph M. Becker [Mon, 23 Nov 2020 23:20:58 +0000 (00:20 +0100)]
Fix COMPersistHelper::__construct() stub

`$variant` is optional.

4 years agozip extension is 1.19.2
Remi Collet [Mon, 23 Nov 2020 14:59:15 +0000 (15:59 +0100)]
zip extension is 1.19.2

4 years agozend_jit_trace_stack_frame.stack can't be NULL
Dmitry Stogov [Mon, 23 Nov 2020 13:19:22 +0000 (16:19 +0300)]
zend_jit_trace_stack_frame.stack can't be NULL

4 years agoFixed use-after-free in PHPUnit tests
Dmitry Stogov [Mon, 23 Nov 2020 11:42:38 +0000 (14:42 +0300)]
Fixed use-after-free in PHPUnit tests

4 years agoKeep value of register before possible side exit
Dmitry Stogov [Mon, 23 Nov 2020 09:07:05 +0000 (12:07 +0300)]
Keep value of register before possible side exit

4 years agoMerge branch 'PHP-7.4' into PHP-8.0
Christoph M. Becker [Sun, 22 Nov 2020 13:04:21 +0000 (14:04 +0100)]
Merge branch 'PHP-7.4' into PHP-8.0

* PHP-7.4:
  Fix #77594: ob_tidyhandler is never reset

4 years agoFix #77594: ob_tidyhandler is never reset
Christoph M. Becker [Sat, 14 Nov 2020 14:03:58 +0000 (15:03 +0100)]
Fix #77594: ob_tidyhandler is never reset

We reset to original INI value on request shutdown.

Closes GH-6425.

4 years agoRemove some incorrect mixed parameter types
Máté Kocsis [Tue, 17 Nov 2020 19:13:42 +0000 (20:13 +0100)]
Remove some incorrect mixed parameter types

4 years agoMerge branch 'PHP-7.4' into PHP-8.0
Nikita Popov [Fri, 20 Nov 2020 15:50:52 +0000 (16:50 +0100)]
Merge branch 'PHP-7.4' into PHP-8.0

* PHP-7.4:
  Fix typos in php.ini files

4 years agoFix typos in php.ini files
Benjamin Morel [Fri, 20 Nov 2020 13:45:35 +0000 (14:45 +0100)]
Fix typos in php.ini files

Closes GH-6441.

[ci skip]

4 years agoUPGRADING: (real) cast has been removed
jrfnl [Fri, 20 Nov 2020 01:20:03 +0000 (02:20 +0100)]
UPGRADING: (real) cast has been removed

.. but the removal wasn't mentioned in the `UPGRADING` docs yet.

Ref:
* https://github.com/php/php-src/pull/5220
* https://github.com/php/php-src/commit/c9db32271a8083721582c5ec1dd09c4d4f562c74

Closes GH-6440.

[ci-skip]

4 years agoUse MIN/MAX when dumping RANGE[]
Nikita Popov [Thu, 19 Nov 2020 11:46:52 +0000 (12:46 +0100)]
Use MIN/MAX when dumping RANGE[]

It's very common that one of the bounds is LONG_MIN or LONG_MAX.
Dump them as MIN/MAX instead of the int representation in that
case, as it makes the dump less noisy.

4 years agoFixed incorrect TRACE_FRAME_MASK_NESTED flag setting
Dmitry Stogov [Fri, 20 Nov 2020 15:22:21 +0000 (18:22 +0300)]
Fixed incorrect TRACE_FRAME_MASK_NESTED flag setting

4 years agoFixed 32-bit JIT
Dmitry Stogov [Fri, 20 Nov 2020 12:12:30 +0000 (15:12 +0300)]
Fixed 32-bit JIT

4 years agoMerge branch 'PHP-7.4' into PHP-8.0
Christoph M. Becker [Thu, 19 Nov 2020 18:26:33 +0000 (19:26 +0100)]
Merge branch 'PHP-7.4' into PHP-8.0

* PHP-7.4:
  Fix #72964: White space not unfolded for CC/Bcc headers

4 years agoFix #72964: White space not unfolded for CC/Bcc headers
Christoph M. Becker [Tue, 10 Nov 2020 15:13:54 +0000 (16:13 +0100)]
Fix #72964: White space not unfolded for CC/Bcc headers

`\r\n` does only terminate a header, if not followed by `\t` or ` `.
We have to cater to that when determining the end position of the
respective headers.

Closes GH-6420.

4 years agoMerge branch 'PHP-7.4' into PHP-8.0
Christoph M. Becker [Thu, 19 Nov 2020 15:26:14 +0000 (16:26 +0100)]
Merge branch 'PHP-7.4' into PHP-8.0

* PHP-7.4:
  Fix #80345: PHPIZE configuration has outdated PHP_RELEASE_VERSION

4 years agoFix #80345: PHPIZE configuration has outdated PHP_RELEASE_VERSION
Christoph M. Becker [Tue, 10 Nov 2020 12:51:40 +0000 (13:51 +0100)]
Fix #80345: PHPIZE configuration has outdated PHP_RELEASE_VERSION

We must not redefine the version "constants" for phpize builds, because
these have already generated in phpize.js, from where we pass these
variables forward to configure.js.

We also add `PHP_EXTRA_VERSION` and `PHP_VERSION_STRING` to the files
for completeness.

Closes GH-6419.

4 years ago8.0 branch should be prepping for 8.0.1
Sara Golemon [Thu, 19 Nov 2020 14:37:44 +0000 (14:37 +0000)]
8.0 branch should be prepping for 8.0.1

4 years agoPrepare NEWS file for GA
Sara Golemon [Thu, 19 Nov 2020 14:27:49 +0000 (14:27 +0000)]
Prepare NEWS file for GA

4 years agoAdded missing deoptimization code for trampoline handling
Dmitry Stogov [Thu, 19 Nov 2020 09:32:36 +0000 (12:32 +0300)]
Added missing deoptimization code for trampoline handling

4 years agoExport zend_is_callable_at_frame
Nikita Popov [Thu, 19 Nov 2020 09:29:32 +0000 (10:29 +0100)]
Export zend_is_callable_at_frame

Export the zend_is_callable_impl() function as
zend_is_callable_at_frame() for use by extension. As twose pointed
out, an extension may want to retrieve fcc for a private method.

4 years agoFix curl_multi_getcontent() parameter name
Nikita Popov [Wed, 18 Nov 2020 15:43:45 +0000 (16:43 +0100)]
Fix curl_multi_getcontent() parameter name

While the function name starts with curl_multi_*, the function
actually accepts a CurlHandle. As such, it should also use just
$handle as the parameter name.

Closes GH-6435.

4 years agoMerge branch 'PHP-7.4' into PHP-8.0
Nikita Popov [Wed, 18 Nov 2020 11:46:12 +0000 (12:46 +0100)]
Merge branch 'PHP-7.4' into PHP-8.0

* PHP-7.4:
  Short-circuit get_gc for currently running generator

4 years agoShort-circuit get_gc for currently running generator
Nikita Popov [Wed, 18 Nov 2020 11:44:31 +0000 (12:44 +0100)]
Short-circuit get_gc for currently running generator

4 years agoFixed register clobbering
Dmitry Stogov [Wed, 18 Nov 2020 07:22:25 +0000 (10:22 +0300)]
Fixed register clobbering

4 years agoFixed trampoline handling
Dmitry Stogov [Tue, 17 Nov 2020 20:56:05 +0000 (23:56 +0300)]
Fixed trampoline handling

4 years agoUpdate NEWS for 8.0.0
Gabriel Caruso [Tue, 17 Nov 2020 16:34:55 +0000 (16:34 +0000)]
Update NEWS for 8.0.0

4 years agoUpdate NEWS for PHP 8.0.0RC5
Gabriel Caruso [Tue, 17 Nov 2020 16:23:11 +0000 (16:23 +0000)]
Update NEWS for PHP 8.0.0RC5

4 years agoFixed allocated register clobbering
Dmitry Stogov [Tue, 17 Nov 2020 15:31:14 +0000 (18:31 +0300)]
Fixed allocated register clobbering

4 years agoFixed false pasitive ASAN NULL pointer dereference warning
Dmitry Stogov [Tue, 17 Nov 2020 13:23:30 +0000 (16:23 +0300)]
Fixed false pasitive ASAN NULL pointer dereference warning

4 years agoMerge branch 'PHP-7.4' into PHP-8.0
Nikita Popov [Tue, 17 Nov 2020 12:16:17 +0000 (13:16 +0100)]
Merge branch 'PHP-7.4' into PHP-8.0

* PHP-7.4:
  Fix #80312: change default engine from MyISAM to InnoDB in tests

4 years agoFix #80312: change default engine from MyISAM to InnoDB in tests
Darek Slusarczyk [Fri, 6 Nov 2020 14:41:15 +0000 (15:41 +0100)]
Fix #80312: change default engine from MyISAM to InnoDB in tests

Change mysqli and pdo_mysql tests configuration to use by default
InnoDB instead of MyISAM.

Closes GH-6405.

4 years agoFixed bug #80370: Segmentation fault reflecting attributes of dynamic property
Benjamin Eberlei [Sun, 15 Nov 2020 07:45:26 +0000 (08:45 +0100)]
Fixed bug #80370: Segmentation fault reflecting attributes of dynamic property

Closes GH-6428.

4 years agoProvide unused retvals to observers
Sammy Kaye Powers [Wed, 11 Nov 2020 22:25:39 +0000 (14:25 -0800)]
Provide unused retvals to observers

Make sure that the return value is available to observers, even if
it is not used by the caller.

Closes GH-6422.

4 years agoMerge branch 'PHP-7.4' into PHP-8.0
Nikita Popov [Tue, 17 Nov 2020 09:20:23 +0000 (10:20 +0100)]
Merge branch 'PHP-7.4' into PHP-8.0

* PHP-7.4:
  Fix incorrectly optimized out live range

4 years agoFix incorrectly optimized out live range
Nikita Popov [Tue, 17 Nov 2020 09:18:37 +0000 (10:18 +0100)]
Fix incorrectly optimized out live range

For x ? y : z style structures, the live range starts at z, but
may also hold the value of y. Make sure that the refcounting check
takes this into account, by checking the type of a potential phi
user.

4 years agoFire open observer end handlers after a zend_bailout
Sammy Kaye Powers [Fri, 23 Oct 2020 18:43:31 +0000 (11:43 -0700)]
Fire open observer end handlers after a zend_bailout

Closes GH-6377

4 years agoFixed MAY_BE_INDIRECT inference
Dmitry Stogov [Mon, 16 Nov 2020 15:17:05 +0000 (18:17 +0300)]
Fixed MAY_BE_INDIRECT inference

4 years agoMerge branch 'PHP-7.4' into PHP-8.0
Christoph M. Becker [Mon, 16 Nov 2020 13:33:45 +0000 (14:33 +0100)]
Merge branch 'PHP-7.4' into PHP-8.0

* PHP-7.4:
  Fix #74558: Can't rebind closure returned by Closure::fromCallable()

4 years agoFix #74558: Can't rebind closure returned by Closure::fromCallable()
Christoph M. Becker [Thu, 12 Nov 2020 14:37:51 +0000 (15:37 +0100)]
Fix #74558: Can't rebind closure returned by Closure::fromCallable()

Failure to rebind such closures is not necessarily related to them
being created by `ReflectionFunctionAbstract::getClosure()`, so we fix
the error message.

Closes GH-6424.

4 years agoFixed alias handling
Dmitry Stogov [Mon, 16 Nov 2020 13:11:25 +0000 (16:11 +0300)]
Fixed alias handling

4 years agoFixed reference-counting
Dmitry Stogov [Mon, 16 Nov 2020 11:51:55 +0000 (14:51 +0300)]
Fixed reference-counting

4 years agoFixed incorrect FETCH_THIS optimization
Dmitry Stogov [Mon, 16 Nov 2020 11:51:39 +0000 (14:51 +0300)]
Fixed incorrect FETCH_THIS optimization

4 years agoFixed inconsistent VM stack state
Dmitry Stogov [Mon, 16 Nov 2020 10:19:44 +0000 (13:19 +0300)]
Fixed inconsistent VM stack state

4 years agoTrampoline cleanup
Dmitry Stogov [Mon, 16 Nov 2020 09:05:45 +0000 (12:05 +0300)]
Trampoline cleanup

4 years ago[ci skip] Add note that imagedestroy() no longer has an effect
Pavel Djundik [Sat, 14 Nov 2020 11:12:38 +0000 (13:12 +0200)]
[ci skip] Add note that imagedestroy() no longer has an effect

Closes GH-6427.

4 years agoInline pair production in json parser
Nikita Popov [Fri, 13 Nov 2020 13:55:26 +0000 (14:55 +0100)]
Inline pair production in json parser

Having this as a separate production has a noticeable performance
impact, and doesn't really make things clearer either.

4 years agoStrip trailing line breaks and periods from Windows error messages
Christoph M. Becker [Thu, 12 Nov 2020 13:58:47 +0000 (14:58 +0100)]
Strip trailing line breaks and periods from Windows error messages

PHP error messages should not contain line breaks, so we remove these
from the Windows specific error messages.  We also remove trailing
periods for the same reason.

Closes GH-6423.

4 years agoDon't assume libmysqlclient library name
Nikita Popov [Thu, 12 Nov 2020 14:09:18 +0000 (15:09 +0100)]
Don't assume libmysqlclient library name

By simply dropping the additional checks, in line with the general
guideline of trusting the output of config scripts (this should
be migrated to pkg-config though).

Also drop the code for manually adding -z if mysql_config does not
-- that's not our problem.

4 years agoFix memory leak when user filter onCreate returns false
Nikita Popov [Thu, 12 Nov 2020 11:18:33 +0000 (12:18 +0100)]
Fix memory leak when user filter onCreate returns false

4 years agoFix memory leak with bcsqrt on number 0<X<1
Nikita Popov [Thu, 12 Nov 2020 10:37:54 +0000 (11:37 +0100)]
Fix memory leak with bcsqrt on number 0<X<1

4 years agoFix reflection getDefaultValue() with user arg info
Nikita Popov [Thu, 12 Nov 2020 10:02:04 +0000 (11:02 +0100)]
Fix reflection getDefaultValue() with user arg info

The default value is part of the op_array in that case, but we have
no way to access it. Fail gracefully.

4 years agoFixed incorrectly eliminated type store
Dmitry Stogov [Wed, 11 Nov 2020 17:13:58 +0000 (20:13 +0300)]
Fixed incorrectly eliminated type store

4 years agoRemove assertion
Dmitry Stogov [Wed, 11 Nov 2020 15:34:16 +0000 (18:34 +0300)]
Remove assertion

4 years agoMerge branch 'PHP-7.4' into PHP-8.0
Nikita Popov [Wed, 11 Nov 2020 15:03:10 +0000 (16:03 +0100)]
Merge branch 'PHP-7.4' into PHP-8.0

* PHP-7.4:
  Handle errors during next_result()