jstebbins [Wed, 8 Jun 2011 21:17:31 +0000 (21:17 +0000)]
cli: Allow more flexible specification of native language in the cli
Let the user specify their native language using any of the strings
supported in the iso639_lang table.
jstebbins [Wed, 8 Jun 2011 21:15:06 +0000 (21:15 +0000)]
LinGui: move advanced audio from a dialog popup to an expander box
The expander fits on the audio tab and expands the advanced controls
when activated.
jstebbins [Tue, 7 Jun 2011 21:27:02 +0000 (21:27 +0000)]
libhb: add support for libav aac encoder (libhb only)
This generalizes the ac3 encoder to make it easy to add support
for any audio encoder that libav supports. Since ffaac is not quite
ready, the cli and gui does not expose ffaac yet.
Highlights:
- Sources with more than 20 streams (video, audio and subtitles combined)
are now supported
- Adds decoding support for 10-bit H.264
- Adds frame-based threading for H.264 and VP8
Not yet enabled in HB. See experimental patch on RB to enable.
- Quality tweaks for the AC3 encoder
- AAC encoder improvements
Not yet enabled in HB. See experimental patch on RB to enable.
- Miscellaneous other fixes and improvements
jstebbins [Tue, 7 Jun 2011 18:33:00 +0000 (18:33 +0000)]
libhb: Sort BD titles by playlist id
This makes the logs of different rips more consistent. Previously, the
order of titles was determined by the order the mpls files were written
in the PLAYLIST directory which could vary from rip to rip.
jstebbins [Sun, 5 Jun 2011 19:48:05 +0000 (19:48 +0000)]
Fix a problem with filtering and picking correct BD title
Titles that are the same except for number of chapters were being
filtered out of the title list. So sometimes you would get a BD title
that didn't seem to have any chapters.
sr55 [Fri, 3 Jun 2011 19:49:57 +0000 (19:49 +0000)]
WinGui:
- Added support for naming tracks. New text entry field on the Advanced Audio Window. (Note: May be some CLI issues that need to be fixed up for this. We'll see)
- Disabled application settings upgrade when moving from a release to a svn build. Upgrades now only work for svn -> svn builds as there has been reliability issues when upgrading from much older builds.
jstebbins [Fri, 3 Jun 2011 15:55:00 +0000 (15:55 +0000)]
LinGui: fix preview encode progress display when # previews > 10
flags array indicating that the preview had already been encoded
for live playback was limited to 10. Forgot to change it when we
started allowing more previews.
sr55 [Thu, 2 Jun 2011 19:03:17 +0000 (19:03 +0000)]
WinGui: Improvements to the AutoName functionality.
- Added more flexibility to the "{source_path}" option so that it can now be used with additional folders listed after it. e.g. "{source_path}\encoded". It is no longer limited to just that folder.
- Added an option to put todays date in the output filename "{date}"
- Some tweaks to the way warnings are displayed when using these features to make them a bit less annoying.
jstebbins [Tue, 31 May 2011 14:54:14 +0000 (14:54 +0000)]
Add patch to disable SSE in mpeg2dec for mingw64
This allows use of mpeg2dec with mingw64. From what I've read,
disabling sse in mpeg2dec will result in about 10% speed penalty.
jstebbins [Mon, 30 May 2011 16:38:08 +0000 (16:38 +0000)]
Fix gcc4.6 build error that results in a crash in sse2 code
This fixes mpeg2 decoding on fedora15 and probably also fixes
the mpeg2dec issue we saw with mingw64.
sr55 [Sun, 29 May 2011 16:19:19 +0000 (16:19 +0000)]
WinGui: Refactored the Encode Service to move any reusable code into a base class. Added a new service which will eventually work with libhb to do encodes. Currently this just contains placeholders which throw NotImplementedExceptions.
Removed the Total Elapsed Time on the Queue window since it doesn't work. This will be re-implemented later.
sr55 [Thu, 26 May 2011 18:29:04 +0000 (18:29 +0000)]
WinGui: Fix to the Audio Panel. It now creates a copy of the sources Audio Tracks collection rather than using a reference. The reference was getting cleared out if the user re-selected a title which was causing a crash. Also added some extra sanity checking code in to prevent possible issues.
dynaflash [Thu, 26 May 2011 16:17:13 +0000 (16:17 +0000)]
MacGui: Add -selectedPreset helper method
- Patch once again by blindjimmy.. thanks!
- This change consolidates all the calls in Controller.m of [fPresetsOutlineView itemAtRow:[fPresetsOutlineView selectedRow]] to get the currently selected preset to use a new -selectedPreset accessor method. This is both easier to read and is better decomposition.
- as per https://reviews.handbrake.fr/r/85/
dynaflash [Thu, 26 May 2011 15:48:37 +0000 (15:48 +0000)]
MacGui: Clean up internal architecture of HB Audio and HBAudioController
- patch by blindjimmy ... as always .... thank you!
- as per https://reviews.handbrake.fr/r/81/
dynaflash [Thu, 26 May 2011 04:27:08 +0000 (04:27 +0000)]
MacGui: Audio Gain Control initial implementation
- Adds a Circular Slider to implement gain from a range of -5 to +15 which is sane by any reasonable measure.
- Note: the circular slider with this range puts the default of 0.0 at the three o'clock position on the slider which is kind of wonky. Any ideas to make it more intuitive are welcome.
-The accompanying text field readout is left editable so values beyond the sliders range can be specified manually.
- Gain is disabled for any passthru options obviously.
- Though it has been in cli and lingui for some time, as a note my tests show that anything above +15 can get distorted quite easily. Of course that is open to opinion depending on source, I have yet to see a complaint about the volume of encoded audio being too high but we leave up to -5 there just for the corner cases.
- Any existing presets not specifying gain will use a gain of 0.0 which means of course its unmodified.
- Also as a sidenote takes care of blindjimmy's patch https://reviews.handbrake.fr/r/99/ as far as /macosx/HBQueueController.m
sr55 [Mon, 23 May 2011 18:37:36 +0000 (18:37 +0000)]
WinGui: Made a change to the Query Generator to use the Scanned Source Path rather than the folder selected for batch and single file scans. Falls back to old behaviour of users selected path if said path is not available.
sr55 [Sun, 22 May 2011 19:06:27 +0000 (19:06 +0000)]
WinGui: Add a new option "Add All" to the Audio track which adds any remaining tracks to the audio list, with default audio settings. Also changed the ObservableCollection back to a BindingList as the Track dropdown behaves better with this.
sr55 [Sun, 22 May 2011 10:51:43 +0000 (10:51 +0000)]
WinGui: Fix an unusual issue with the DataBinding on the AudioTrack dropdown control. Seems to no longer get the ListChanged events when the model object is marked as serializable.
sr55 [Sat, 21 May 2011 19:05:24 +0000 (19:05 +0000)]
WinGui:
- Added some debug handling into the presets service which will hopefully make it easier to track down the reason why presets sometimes do not load correctly when updating to a newer nightly build.
dynaflash [Thu, 19 May 2011 19:21:43 +0000 (19:21 +0000)]
Macgui: libhb, MacGUI: reflect the fact that DRC only applies to non-passthru AC3 sources
- As per https://reviews.handbrake.fr/r/74/
-Patch by Rodeo, Thanks.
sr55 [Sat, 14 May 2011 14:46:16 +0000 (14:46 +0000)]
WinGui:
- Removed the Question Alert box when adding an item to the queue where the destination folder does not exist. The folder is automatically created before encode anyway, so no point in asking the user pre-Encode.cs
- Better error handling in the encode service.
sr55 [Sun, 8 May 2011 11:00:16 +0000 (11:00 +0000)]
WinGui:
- Add Elapsed Encode Time the main window.
- Add Elapsed Queue Time to the queue window. (Note, Pausing the queue resets this currently)
- Fixed an issue with disabled controls on the audio panel after removing the last track which was passthru.
WinGui:
- Fix to the Audio Panel Track Display which was intermittently not showing a track.
- Fixed a number of bugs in the plist parser which was prevent imports.
- Fixed a number of Issues with the Preset Import/Export.
WinGui:
- Fix an issue where the user could overwrite a built-in preset.
- Fix some more audio issues in relation to incorrect bitrate and sample rate being selected.
MacGui: Save picture settings by default when creating a new preset.
- Use Custom (defaulted to current picture size).
- Use currently selected Filters.
- Note this is by default. All choices are still the same
- As per https://reviews.handbrake.fr/r/82/
fix screaching at the beginning of some ac3 to X transcodes
a52dec isn't completely thread safe. It has a collection of
static data that gets initialized when a52_init is called.
This static data gets initialized to the same thing every time,
but if one instance of the decoder is using the data when
it gets reinitialized, bad(tm) things happen.
libhb: don't use deprecated elements of the FFmpeg/Libav API
HandBrake uses many attributes of the FFmpeg API that are were deprecated
when we did the last bump. Many of them no longer exist in current
FFmpeg/Libav git, or are going to be removed soon.
Replaces them with non-deprecated attributes that already exist in the
build we currently use.
Thanks to Rodeo for the patch.
Fix a crash that can happen due to corrupt mpeg2 data
The mpe2dec can return nonsense values for width and height that
make sws_getContext fail. So check the context return value and
just drop the buffer if it fails.
Fix a problem with overlapping vobsubs
Since we now allow subtitles that overlap in time, it is no longer
appropriate to arbitrarily set the duration to 3 seconds when vobsubs
don't have an explicit stop time. This causes them to overlap on the display.
So now, we set the stop time for such vobsubs to -1. Then in sync adjust the
stop time to the start of the next vobsub when it is seen.
Make order of audio tracks found in PS streams more predictable
Since PS streams don't have a directory of streams, we find them by
scanning the PES headers for stream types. We were adding them in the
order found which is pretty random. This sorts audios by substream id.
Fix a problem when encoding the same source audio track twice from BD sources
The pid and substream were being added to the TS stream list twice which
caused 2 copies of each packet to be returned to reader. This caused sync
to drop every second packet with "time went backwards" log message.
MacGui: Simplify HBDVDDetector bsdName creation
- Instead of lazily populating bsdName identically in two places, why not just have its accessor do it.
- As per patch provided by blindjimmy https://reviews.handbrake.fr/r/78/
fix stall due due to propagation of incorrect audio timestamp
Was passing AV_NOPTS_VALUE that is generated by libav. Needed to
translate to -1 which is what we use to designate invalid timestamps.
Change scale factor for timestamp offset in vobsub commands
Testing shows that this should be 1024 instead of 900.
Thanks to Rodeo for validation and patch.
WinGui:
- Multiple bug fixes to the Audio Panel. (Disable DRC for non AC3 sources, DPL2 getting swaped out for stereo when you click between tracks, Exception thrown due to the source track not getting pushed into the Audio model before it's used.)
Add support for TrueHD and DTS-HD from BD sources
TrueHD and DTS-HD now show up in the audio list along side their
AC-3 and DTS counterparts.
Note that currently the DTS-HD decoder we are using (ffmpeg) discards
the HD portion of the stream and onle decodes the DTS core portion. So
there is no advantage yet to using the DTS-HD stream. In the future
I would like to add DTS-HD passthru support and hopefully ffmpeg will
improve their DTS-HD decoder.
WinGui:
- Save Filter settings in presets by default. Seems to be common mistake.
- Set the AcceptButton property on a few windows so they react properly to keyboard commands.
WinGui:
- Switching Audio Selection dropdown to be databound. Added The scanned source track to the Audio Track model.
- Added new Move to Top / Bottom options on the right click.
- Further UI tweaks and fixes.
Fix int overflow that can happen when computing PAR
If the source has large non-reduced PAR values, our computed value
was overflowing an int. Compute it in an int64_t then reduce it.
Also, keep num and den below 65535. Larger values just aren't really
significant and will cause more overflow issues.
MacGui: implement Frame Rate Mode as per the Lingui.
- Removes the current Peak Framerate checkbox and replaces it with appropriate Radio Buttons depending on if Same as Source or a specific framerate is chosen in the Frame Rate popup widget.
- Gets the macgui up to speed with https://trac.handbrake.fr/changeset/3770
projects / handbrake / log