]>
granicus.if.org Git - openjpeg/log
Even Rouault [Fri, 1 Sep 2017 14:30:35 +0000 (16:30 +0200)]
opj_tcd_init_tile(): fix typo on overflow detection condition (introduced in previous commit)
Even Rouault [Fri, 1 Sep 2017 14:30:32 +0000 (16:30 +0200)]
opj_dwt_decode_partial_tile(): avoid undefined behaviour in lifting operation by properly initializing working buffer
Even Rouault [Fri, 1 Sep 2017 14:30:29 +0000 (16:30 +0200)]
Sub-tile decoding: only allocate tile component buffer of the needed dimension
Instead of being the full tile size.
* Use a sparse array mechanism to store code-blocks and intermediate stages of
IDWT.
* IDWT, DC level shift and MCT stages are done just on that smaller array.
* Improve copy of tile component array to final image, by saving an intermediate
buffer.
* For full-tile decoding at reduced resolution, only allocate the tile buffer to
the reduced size, instead of the full-resolution size.
Even Rouault [Mon, 21 Aug 2017 21:21:39 +0000 (23:21 +0200)]
opj_compress: reorder checks related to code block dimensions, to avoid potential int overflow
Even Rouault [Mon, 21 Aug 2017 21:20:51 +0000 (23:20 +0200)]
opj_j2k_setup_encoder(): validate code block width/height
Even Rouault [Mon, 21 Aug 2017 21:12:45 +0000 (23:12 +0200)]
opj_t1_allocate_buffers(): remove useless overflow checks
Even Rouault [Fri, 1 Sep 2017 08:26:18 +0000 (10:26 +0200)]
Fix undefined shift behaviour in opj_dwt_is_whole_tile_decoding(). Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=3255. Credit to OSS Fuzz
Even Rouault [Tue, 29 Aug 2017 09:40:53 +0000 (11:40 +0200)]
Use IDWT whole tile decoding if the area of interest equals to the image bounds, taking into account the reduced resolution factor
Even Rouault [Mon, 28 Aug 2017 16:07:44 +0000 (18:07 +0200)]
Even Rouault [Mon, 28 Aug 2017 15:18:33 +0000 (17:18 +0200)]
Subtile decoding: fix overflows in subband coordinate computation that cause later buffer overflow. Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=3115. Credit to OSS Fuzz. master only
Even Rouault [Mon, 28 Aug 2017 12:57:49 +0000 (14:57 +0200)]
Make opj_set_decode_area() and opj_decode() take into account opj_set_decoded_resolution_factor() (#1006, affect API use)
* Better document usage of opj_set_decode_area(), ie expecting coordinates
in full resolution/reference grid even if requesting at a lower resolution
factor
* Make sure that image->comps[].factor is set by opj_set_decode_area() and
opj_decode() from the value specified in opj_set_decoded_resolution_factor()
* opj_decompress: add 2 environmenet variables to test alternate ways of
using the API, namely USE_OPJ_SET_DECODED_RESOLUTION_FACTOR=YES to use
opj_set_decoded_resolution_factor() instead of parameters.cp_reduce, and
SKIP_OPJ_SET_DECODE_AREA=YES to not call opj_set_decode_area() if -d is
not specified.
Even Rouault [Thu, 24 Aug 2017 12:38:24 +0000 (14:38 +0200)]
Another cleanup in knownfailures-* files
Even Rouault [Thu, 24 Aug 2017 12:32:36 +0000 (14:32 +0200)]
Remove test steps from specialized knownfailures- that are already in knownfailures-all.txt
Even Rouault [Thu, 24 Aug 2017 12:31:13 +0000 (14:31 +0200)]
issue104_jpxstream.jp2 decompresses just fine (and like Kakadu). Update md5refs.txt and remove from knownfailures
Even Rouault [Thu, 24 Aug 2017 12:09:34 +0000 (14:09 +0200)]
Remove broken.jpc test from known failures, by avoiding too long processing time
Even Rouault [Thu, 24 Aug 2017 12:09:31 +0000 (14:09 +0200)]
imagetopgx(): improve performance in 8 bit case (relates to broken.jpc test case)
Even Rouault [Thu, 24 Aug 2017 11:23:25 +0000 (13:23 +0200)]
Remove -NR-DEC-p1_06.j2k-156-decode and NR-DEC-p1_06.j2k-164-decode from knownfailures
and make them explicit failures. The result images are empty at the requested resolution
Even Rouault [Wed, 23 Aug 2017 16:58:32 +0000 (18:58 +0200)]
opj_dwt_decode_partial_97(): perf improvement: limit copy of coefficients at end of horizontal pass to actual range of interest
Even Rouault [Mon, 21 Aug 2017 21:06:53 +0000 (23:06 +0200)]
test_tile_encoder: fix checks on argc
Even Rouault [Mon, 21 Aug 2017 17:02:04 +0000 (19:02 +0200)]
j2k.c: fix comment, and remove FIXME
Even Rouault [Mon, 21 Aug 2017 15:19:13 +0000 (17:19 +0200)]
Add comment
Even Rouault [Mon, 21 Aug 2017 11:02:07 +0000 (13:02 +0200)]
Merge pull request #1001 from rouault/subtile_decoding_stage2
Subtile decoding: only apply IDWT on areas that participate to the window of interest
Even Rouault [Mon, 21 Aug 2017 10:25:38 +0000 (12:25 +0200)]
Add comments for filter_width values
Even Rouault [Sun, 20 Aug 2017 20:02:41 +0000 (22:02 +0200)]
Subtile decoding: only do 9x7 IDWT computations on relevant areas of tile-component buffer.
Even Rouault [Sat, 19 Aug 2017 13:45:54 +0000 (15:45 +0200)]
pgxtoimage(): avoid excessive memory allocation attempt (#999)
Even Rouault [Fri, 18 Aug 2017 13:08:51 +0000 (15:08 +0200)]
Subtile decoding: only do 5x3 IDWT computations on relevant areas of tile-component buffer.
This lowers 'bin/opj_decompress -i ../MAPA.jp2 -o out.tif -d 0,0,256,256'
down to 0.860s
Even Rouault [Fri, 18 Aug 2017 11:39:20 +0000 (13:39 +0200)]
pgxtoimage(): fix write stack buffer overflow (#997)
Even Rouault [Fri, 18 Aug 2017 10:30:11 +0000 (12:30 +0200)]
test_decode_area: fix to make it work with odd image dimensions
Even Rouault [Fri, 18 Aug 2017 08:16:38 +0000 (10:16 +0200)]
bmp_read_rle8_data(): avoid potential infinite loop (#996)
Even Rouault [Thu, 17 Aug 2017 17:18:48 +0000 (19:18 +0200)]
opj_j2k_update_rates(): grow tile size buffer for some situations
Even Rouault [Thu, 17 Aug 2017 14:07:19 +0000 (16:07 +0200)]
Zero-initialize tile buffer regions of skipped code-blocks, so as to make Valgrind happy
Even Rouault [Mon, 14 Aug 2017 11:23:57 +0000 (13:23 +0200)]
Sub-tile decoding: only decode precincts and codeblocks that intersect the window specified in opj_set_decode_area()
Even Rouault [Thu, 17 Aug 2017 17:05:29 +0000 (19:05 +0200)]
Fix -Wconversion warning
Even Rouault [Thu, 17 Aug 2017 15:04:48 +0000 (17:04 +0200)]
bench_dwt.c: fix signedness related warnings
Even Rouault [Thu, 17 Aug 2017 15:02:40 +0000 (17:02 +0200)]
convert.c: fix recently introduced -Wsign-conversion warnings
Even Rouault [Thu, 17 Aug 2017 12:52:10 +0000 (14:52 +0200)]
opj_getopt_long(): avoid infinite loop on invalid or missing value for an option (#736)
Even Rouault [Thu, 17 Aug 2017 10:01:16 +0000 (12:01 +0200)]
opj_decompress_fuzzer.cpp: reject images with too big tiles. Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=2918. Credit to OSS Fuzz
Even Rouault [Thu, 17 Aug 2017 09:47:40 +0000 (11:47 +0200)]
tgatoimage(): avoid excessive memory allocation attempt, and fixes unaligned load (#995)
Even Rouault [Thu, 17 Aug 2017 09:05:53 +0000 (11:05 +0200)]
Avoid asserting on assert(i == pcol) in opj_jp2_apply_pclr() by adding new check in opj_jp2_check_color(). Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=3068. Credit to OSS Fuzz
Even Rouault [Wed, 16 Aug 2017 16:29:59 +0000 (18:29 +0200)]
opj_t1_encode_cblk(): avoid uint32 overflow when numbps = 0 (which is well defined behaviour, and is properly handled here, but better avoid it to detect real issues)
Even Rouault [Wed, 16 Aug 2017 15:38:47 +0000 (17:38 +0200)]
Fix build issue of JPWL by adding opj_image_data_alloc() and opj_image_data_free() to src/lib/openmj2 (#994)
Even Rouault [Wed, 16 Aug 2017 15:20:29 +0000 (17:20 +0200)]
opj_t2_encode_packet(): fix potential write heap buffer overflow (#992)
Even Rouault [Wed, 16 Aug 2017 15:09:10 +0000 (17:09 +0200)]
opj_j2k_write_sot(): fix potential write heap buffer overflow (#991)
Even Rouault [Wed, 16 Aug 2017 11:36:52 +0000 (13:36 +0200)]
tiftoimage(): fix read heap buffer overflow (#988)
The number of components is given only by TIFFTAG_SAMPLESPERPIXEL / tiSpp.
Querying TIFFTAG_EXTRASAMPLES only give information about which channel is
the alpha channel, but we mostly ignore it for now, so remove that part of the
code.
Even Rouault [Wed, 16 Aug 2017 11:11:36 +0000 (13:11 +0200)]
imagetotga(): fix read heap buffer overflow if numcomps < 3 (#987)
Even Rouault [Wed, 16 Aug 2017 10:52:33 +0000 (12:52 +0200)]
opj_t2_encode_packet(): only emit an error about insufficiently large output buffer in FINAL_PASS mode. Fixes (master-only) regression added in
0b4fef6d1901254e41ab74ed681daba477d724c3
Even Rouault [Tue, 15 Aug 2017 09:55:58 +0000 (11:55 +0200)]
Fix assertion in debug mode / heap-based buffer overflow in opj_write_bytes_LE for Cinema profiles with numresolutions = 1 (#985)
Even Rouault [Mon, 14 Aug 2017 15:28:26 +0000 (17:28 +0200)]
Merge pull request #984 from stweil/const
Use more const qualifiers
Even Rouault [Mon, 14 Aug 2017 15:26:58 +0000 (17:26 +0200)]
bmp_read_info_header(): reject bmp files with biBitCount == 0 (#983)
Even Rouault [Mon, 14 Aug 2017 15:20:37 +0000 (17:20 +0200)]
Encoder: grow buffer size in opj_tcd_code_block_enc_allocate_data() to avoid write heap buffer overflow in opj_mqc_flush (#982)
Stefan Weil [Mon, 14 Aug 2017 12:36:06 +0000 (14:36 +0200)]
Use const qualifier for mqc_states
This allows more compiler optimizations.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Stefan Weil [Sun, 13 Aug 2017 20:57:31 +0000 (22:57 +0200)]
Use const qualifier for j2k_prog_order_list
This allows more compiler optimizations.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Even Rouault [Fri, 11 Aug 2017 13:13:35 +0000 (15:13 +0200)]
Merge pull request #980 from szukw000/changes-for-ppc64-converttif
Changes in converttif.c for PPC64
szukw000 [Thu, 10 Aug 2017 22:06:23 +0000 (00:06 +0200)]
Changes in converttif.c for PPC64
Even Rouault [Thu, 10 Aug 2017 14:58:36 +0000 (16:58 +0200)]
Fix argument order in error message of previous commit
Even Rouault [Thu, 10 Aug 2017 14:49:47 +0000 (16:49 +0200)]
Propagate event manager down to opj_t2_encode_packet() and use it to emit an error message when the output buffer is too small
Even Rouault [Thu, 10 Aug 2017 12:43:16 +0000 (14:43 +0200)]
Fix crash on encoding if using opj_set_default_encoder_parameters() without defining tcp_numlayers
Even Rouault [Thu, 10 Aug 2017 10:30:31 +0000 (12:30 +0200)]
Reformat tests/test_tile_encoder.c
Even Rouault [Thu, 10 Aug 2017 09:45:49 +0000 (11:45 +0200)]
Improve doc of opj_tccp_info_t::cblkw and cblkh
Antonin Descampe [Thu, 10 Aug 2017 04:51:16 +0000 (21:51 -0700)]
Comment back previous version in abi-check.sh
Antonin Descampe [Thu, 10 Aug 2017 04:35:30 +0000 (21:35 -0700)]
update abi-check for latest release
Antonin Descampe [Thu, 10 Aug 2017 00:31:50 +0000 (17:31 -0700)]
Preparing Release v2.2.0
Antonin Descampe [Thu, 10 Aug 2017 00:28:17 +0000 (17:28 -0700)]
Preparing Release v2.2.0
Even Rouault [Wed, 9 Aug 2017 23:14:35 +0000 (01:14 +0200)]
.travis.yml: add 'dist: precise' for config that requires it
Even Rouault [Wed, 9 Aug 2017 15:37:05 +0000 (17:37 +0200)]
Remove useless opj_tcd_t::enumcs field added per #975
Even Rouault [Wed, 9 Aug 2017 13:04:29 +0000 (15:04 +0200)]
Doc: fix error in previous commit
Even Rouault [Wed, 9 Aug 2017 12:50:59 +0000 (14:50 +0200)]
tcd.h: doc fixes and improvements
Even Rouault [Wed, 9 Aug 2017 12:13:58 +0000 (14:13 +0200)]
Document qmfbid values
Even Rouault [Wed, 9 Aug 2017 09:34:08 +0000 (11:34 +0200)]
Partial revert BPC related check of #975 (#979)
PR #975 introduced a check that rejects images that have different bit depth/sign
per compoment in SIZ marker if the JP2 IHDR box has BPC != 255
This didn't work properly if decoding a .j2k file since the new bit added in
opj_cp_t wasn't initialized to the right value.
For clarity, tThis new bit has also been renamed to allow_different_bit_depth_sign
But looking closer at the code, it seems we were already tolerant to inconsistencies.
For example we parsed a JP2 BPCC box even if BPC != 255 (just a warning is emitted)
So failing hard in opj_j2k_read_siz() wouldn't be very inconsistent, and that
alone cannot protect against other issues, so just emit a warning if BPC != 255
and the SIZ marker contains different bit depth/sign per component.
Note: we could also check that the content of JP2 BPCC box is consistant with the one
of the SIZ marker.
Even Rouault [Wed, 9 Aug 2017 08:03:59 +0000 (10:03 +0200)]
opj_decompress: document -quiet option, and remove spurious newline output
Even Rouault [Wed, 9 Aug 2017 07:50:39 +0000 (09:50 +0200)]
src/bin/jpwl/convert.c pgxtoimage(): add missing fclose() (#977)
Even Rouault [Wed, 9 Aug 2017 07:42:30 +0000 (09:42 +0200)]
imagetobmp: avoid shift by -1 (relates to #811)
Antonin Descampe [Wed, 9 Aug 2017 01:05:37 +0000 (18:05 -0700)]
Fix remaining warning
format specifier mismatch in #975
Antonin Descampe [Tue, 8 Aug 2017 23:51:54 +0000 (16:51 -0700)]
Merge pull request #975 from szukw000/changes-for-afl-tests
Catch images broken by AFL
Even Rouault [Mon, 7 Aug 2017 18:17:36 +0000 (20:17 +0200)]
Merge pull request #968 from rouault/reduce_memory_decoding
Reduce memory decoding
Even Rouault [Thu, 6 Jul 2017 17:34:21 +0000 (19:34 +0200)]
Slight improvement in management of code block chunks
Instead of having the chunk array at the segment level, we can move it down to
the codeblock itself since segments are filled in sequential order.
Limit the number of memory allocation, and decrease slightly the memory usage.
On MAPA_005.jp2
n4:
1871312549 (heap allocation functions) malloc/new/new[], --alloc-fns, etc.
n1:
1610689344 0x4E781E7: opj_aligned_malloc (opj_malloc.c:61)
n1:
1610689344 0x4E71D1B: opj_alloc_tile_component_data (tcd.c:676)
n1:
1610689344 0x4E726CF: opj_tcd_init_decode_tile (tcd.c:816)
n1:
1610689344 0x4E4BE39: opj_j2k_read_tile_header (j2k.c:8617)
n1:
1610689344 0x4E4C902: opj_j2k_decode_tiles (j2k.c:10348)
n1:
1610689344 0x4E4E3CE: opj_j2k_decode (j2k.c:7846)
n1:
1610689344 0x4E53002: opj_jp2_decode (jp2.c:1564)
n0:
1610689344 0x40374E: main (opj_decompress.c:1459)
n1:
219232541 0x4E4BC50: opj_j2k_read_tile_header (j2k.c:4683)
n1:
219232541 0x4E4C902: opj_j2k_decode_tiles (j2k.c:10348)
n1:
219232541 0x4E4E3CE: opj_j2k_decode (j2k.c:7846)
n1:
219232541 0x4E53002: opj_jp2_decode (jp2.c:1564)
n0:
219232541 0x40374E: main (opj_decompress.c:1459)
n1:
23893200 0x4E72735: opj_tcd_init_decode_tile (tcd.c:1225)
n1:
23893200 0x4E4BE39: opj_j2k_read_tile_header (j2k.c:8617)
n1:
23893200 0x4E4C902: opj_j2k_decode_tiles (j2k.c:10348)
n1:
23893200 0x4E4E3CE: opj_j2k_decode (j2k.c:7846)
n1:
23893200 0x4E53002: opj_jp2_decode (jp2.c:1564)
n0:
23893200 0x40374E: main (opj_decompress.c:1459)
n0:
17497464 in 52 places, all below massif's threshold (1.00%)
Even Rouault [Thu, 6 Jul 2017 14:11:11 +0000 (16:11 +0200)]
Decoding: do not allocate memory for the codestream of each codeblock
Currently we allocate at least 8192 bytes for each codeblock, and copy
the relevant parts of the codestream in that per-codeblock buffer as we
decode packets.
As the whole codestream for the tile is ingested in memory and alive
during the decoding, we can directly point to it instead of copying. But
to do that, we need an intermediate concept, a 'chunk' of code-stream segment,
given that segments may be made of data at different places in the code-stream
when quality layers are used.
With that change, the decoding of MAPA_005.jp2 goes down from the previous
improvement of 2.7 GB down to 1.9 GB.
New profile:
n4:
1885648469 (heap allocation functions) malloc/new/new[], --alloc-fns, etc.
n1:
1610689344 0x4E78287: opj_aligned_malloc (opj_malloc.c:61)
n1:
1610689344 0x4E71D7B: opj_alloc_tile_component_data (tcd.c:676)
n1:
1610689344 0x4E7272C: opj_tcd_init_decode_tile (tcd.c:816)
n1:
1610689344 0x4E4BDD9: opj_j2k_read_tile_header (j2k.c:8618)
n1:
1610689344 0x4E4C8A2: opj_j2k_decode_tiles (j2k.c:10349)
n1:
1610689344 0x4E4E36E: opj_j2k_decode (j2k.c:7847)
n1:
1610689344 0x4E52FA2: opj_jp2_decode (jp2.c:1564)
n0:
1610689344 0x40374E: main (opj_decompress.c:1459)
n1:
219232541 0x4E4BBF0: opj_j2k_read_tile_header (j2k.c:4685)
n1:
219232541 0x4E4C8A2: opj_j2k_decode_tiles (j2k.c:10349)
n1:
219232541 0x4E4E36E: opj_j2k_decode (j2k.c:7847)
n1:
219232541 0x4E52FA2: opj_jp2_decode (jp2.c:1564)
n0:
219232541 0x40374E: main (opj_decompress.c:1459)
n1:
39822000 0x4E727A9: opj_tcd_init_decode_tile (tcd.c:1219)
n1:
39822000 0x4E4BDD9: opj_j2k_read_tile_header (j2k.c:8618)
n1:
39822000 0x4E4C8A2: opj_j2k_decode_tiles (j2k.c:10349)
n1:
39822000 0x4E4E36E: opj_j2k_decode (j2k.c:7847)
n1:
39822000 0x4E52FA2: opj_jp2_decode (jp2.c:1564)
n0:
39822000 0x40374E: main (opj_decompress.c:1459)
n0:
15904584 in 52 places, all below massif's threshold (1.00%)
Even Rouault [Thu, 6 Jul 2017 11:23:29 +0000 (13:23 +0200)]
Add documentation for magic values in the code
Even Rouault [Thu, 6 Jul 2017 00:17:26 +0000 (02:17 +0200)]
opj_jp2_apply_pclr() also needs to use opj_image_data_alloc/opj_image_data_free
Even Rouault [Thu, 6 Jul 2017 00:02:25 +0000 (02:02 +0200)]
Complementary fix to previous commit
Even Rouault [Wed, 5 Jul 2017 23:47:40 +0000 (01:47 +0200)]
Add opj_image_data_alloc() / opj_image_data_free()
As bin/common/color.c used to directly call malloc()/free(), we need
to export functions dedicated to allocating/freeing image component data.
Even Rouault [Wed, 5 Jul 2017 23:05:24 +0000 (01:05 +0200)]
Fix crash on Windows due to
b7594c0fcb9dd3aa6356d72c4a525d76168da689
b7594c0fcb9dd3aa6356d72c4a525d76168da689 may put opj_tcd_tilecomp_t->data
allocated by opj_alloc_tile_component_data() as the image->comps[].data. As
opj_alloc_tile_component_data() use opj_aligned_malloc() we must be sure to
ue opj_alined_malloc()/_free() in all places where we alloc/free
image->comps[].data.
Note: this might have some compatibility impact in case user code does itself
the allocation/free of image->comps[].data
Even Rouault [Wed, 5 Jul 2017 21:48:28 +0000 (23:48 +0200)]
Decrease memory consumption for whole image single tile decoding.
We can use the same buffer for the tile decoding and the final image, and
save the intermediate buffer to transfer between those.
Effect on the decoding of MAPA (9944 x 13498 x 3 components of size byte)
Peak memory from 4.5 GB to 2.7 GB
Now:
n5:
2699708767 (heap allocation functions) malloc/new/new[], --alloc-fns, etc.
n1:
1610689344 0x4E77E07: opj_aligned_malloc (opj_malloc.c:61) <-- final image
n1:
1610689344 0x4E7195B: opj_alloc_tile_component_data (tcd.c:676)
n1:
1610689344 0x4E722D2: opj_tcd_init_decode_tile (tcd.c:816)
n1:
1610689344 0x4E4BCF1: opj_j2k_read_tile_header (j2k.c:8597)
n1:
1610689344 0x4E4C742: opj_j2k_decode_tiles (j2k.c:10324)
n1:
1610689344 0x4E4E20E: opj_j2k_decode (j2k.c:7826)
n1:
1610689344 0x4E52E42: opj_jp2_decode (jp2.c:1564)
n0:
1610689344 0x40369E: main (opj_decompress.c:1459)
n1:
815554560 0x4E72231: opj_tcd_init_decode_tile (tcd.c:1217) <-- working memory for code blocks: 9944*13498/64/64*8192*3
n1:
815554560 0x4E4BCF1: opj_j2k_read_tile_header (j2k.c:8597)
n1:
815554560 0x4E4C742: opj_j2k_decode_tiles (j2k.c:10324)
n1:
815554560 0x4E4E20E: opj_j2k_decode (j2k.c:7826)
n1:
815554560 0x4E52E42: opj_jp2_decode (jp2.c:1564)
n0:
815554560 0x40369E: main (opj_decompress.c:1459)
n1:
219758391 0x4E4C0BF: opj_j2k_read_tile_header (j2k.c:4661) <-- ingestion of code stream
n1:
219758391 0x4E4C742: opj_j2k_decode_tiles (j2k.c:10324)
n1:
219758391 0x4E4E20E: opj_j2k_decode (j2k.c:7826)
n1:
219758391 0x4E52E42: opj_jp2_decode (jp2.c:1564)
n0:
219758391 0x40369E: main (opj_decompress.c:1459)
n1:
39822000 0x4E7224F: opj_tcd_init_decode_tile (tcd.c:1224) <-- OPJ_J2K_DEFAULT_NB_SEGS*sizeof(opj_tcd_seg_t) per codeblock
n1:
39822000 0x4E4BCF1: opj_j2k_read_tile_header (j2k.c:8597)
n1:
39822000 0x4E4C742: opj_j2k_decode_tiles (j2k.c:10324)
n1:
39822000 0x4E4E20E: opj_j2k_decode (j2k.c:7826)
n1:
39822000 0x4E52E42: opj_jp2_decode (jp2.c:1564)
n0:
39822000 0x40369E: main (opj_decompress.c:1459)
n0:
13884472 in 49 places, all below massif's threshold (1.00%)
Before:
n5:
4493329848 (heap allocation functions) malloc/new/new[], --alloc-fns, etc.
n2:
1610709160 0x4E77C87: opj_aligned_malloc (opj_malloc.c:61)
n1:
1610689344 0x4E717DB: opj_alloc_tile_component_data (tcd.c:676)
n1:
1610689344 0x4E72152: opj_tcd_init_decode_tile (tcd.c:816)
n1:
1610689344 0x4E4BCF1: opj_j2k_read_tile_header (j2k.c:8597)
n1:
1610689344 0x4E4C64A: opj_j2k_decode_tiles (j2k.c:10318)
n1:
1610689344 0x4E4E08E: opj_j2k_decode (j2k.c:7826)
n1:
1610689344 0x4E52CC2: opj_jp2_decode (jp2.c:1564)
n0:
1610689344 0x40369E: main (opj_decompress.c:1459)
n0: 19816 in 2 places, all below massif's threshold (1.00%)
n1:
1610689344 0x4E43F36: opj_j2k_update_image_data.isra.7 (j2k.c:8743)
n1:
1610689344 0x4E4C5C1: opj_j2k_decode_tiles (j2k.c:10358)
n1:
1610689344 0x4E4E08E: opj_j2k_decode (j2k.c:7826)
n1:
1610689344 0x4E52CC2: opj_jp2_decode (jp2.c:1564)
n0:
1610689344 0x40369E: main (opj_decompress.c:1459)
n1:
815554560 0x4E720B1: opj_tcd_init_decode_tile (tcd.c:1217)
n1:
815554560 0x4E4BCF1: opj_j2k_read_tile_header (j2k.c:8597)
n1:
815554560 0x4E4C64A: opj_j2k_decode_tiles (j2k.c:10318)
n1:
815554560 0x4E4E08E: opj_j2k_decode (j2k.c:7826)
n1:
815554560 0x4E52CC2: opj_jp2_decode (jp2.c:1564)
n0:
815554560 0x40369E: main (opj_decompress.c:1459)
n1:
402672336 0x4E4C545: opj_j2k_decode_tiles (j2k.c:10336)
n1:
402672336 0x4E4E08E: opj_j2k_decode (j2k.c:7826)
n1:
402672336 0x4E52CC2: opj_jp2_decode (jp2.c:1564)
n0:
402672336 0x40369E: main (opj_decompress.c:1459)
n0:
53704448 in 58 places, all below massif's threshold (1.00%)
szukw000 [Mon, 7 Aug 2017 14:44:28 +0000 (16:44 +0200)]
Changes for converttif.c to fix tsize_t
Even Rouault [Fri, 4 Aug 2017 16:01:29 +0000 (18:01 +0200)]
opj_j2k_read_sot(): check current TPSot number regarding previous (non-zero) TNsot to avoid opj_j2k_merge_ppt() to be called several times. Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=2851. Credit to OSS Fuzz
szukw000 [Wed, 2 Aug 2017 15:27:08 +0000 (17:27 +0200)]
First change on changes-for-afl-tests
Antonin Descampe [Wed, 2 Aug 2017 15:07:29 +0000 (17:07 +0200)]
Update abi-check to take into account new defaults for "add" git command
Antonin Descampe [Wed, 2 Aug 2017 14:50:11 +0000 (16:50 +0200)]
WIP: fix abi-check and automatic upload
Even Rouault [Mon, 31 Jul 2017 15:35:10 +0000 (17:35 +0200)]
src/bin/jpwl/convert.c: add missing fclose() in error code path (suggested by maddin200, #976)
szukw000 [Mon, 31 Jul 2017 11:58:08 +0000 (13:58 +0200)]
Catch images broken by AFL
Even Rouault [Sun, 30 Jul 2017 17:46:52 +0000 (19:46 +0200)]
src/lib/openjp2/*.h: use OPJ_ prefix for inclusion guards instead of reserved __ (#587)
Even Rouault [Sun, 30 Jul 2017 17:27:01 +0000 (19:27 +0200)]
opj_event_msg(): force zero termination of buffer
Even Rouault [Sun, 30 Jul 2017 17:26:47 +0000 (19:26 +0200)]
Even Rouault [Sun, 30 Jul 2017 17:07:16 +0000 (19:07 +0200)]
Test return value of opj_j2k_setup_decoding_tile() (commit https://github.com/uclouvain/openjpeg/pull/561/commits/
ec31fa0c7f1ff8979312c07296cba41584c458a0 by ak-dxdy, #561)
Even Rouault [Sun, 30 Jul 2017 16:46:34 +0000 (18:46 +0200)]
Fix warnings in USE_JPIP compilation mode
Even Rouault [Sun, 30 Jul 2017 16:43:25 +0000 (18:43 +0200)]
Avoid heap buffer overflow in function pnmtoimage of convert.c, and unsigned integer overflow in opj_image_create() (CVE-2016-9118, #861)
Even Rouault [Sun, 30 Jul 2017 16:18:59 +0000 (18:18 +0200)]
Fix Doxygen warnings (patch derived from Winfried's doxygen-dif.txt.zip, #849)
Even Rouault [Sun, 30 Jul 2017 15:26:03 +0000 (17:26 +0200)]
j2k.c: remove hardcoded constants related to m_state, and useless FIXME
Even Rouault [Sun, 30 Jul 2017 14:48:15 +0000 (16:48 +0200)]
Avoid p_stream->m_user_data_length >= (OPJ_UINT64)p_stream->m_byte_offset assertion in opj_stream_get_number_byte_left(). Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=2786. Credit to OSS Fuzz
Even Rouault [Sun, 30 Jul 2017 13:35:47 +0000 (15:35 +0200)]
opj_j2k_set_decode_area: replace assertions by runtime checks. Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=2795. Credit to OSS Fuzz