Daniel Stenberg [Wed, 11 Feb 2015 22:18:32 +0000 (23:18 +0100)]
multi: fix *getsock() with CONNECT
The code used some happy eyeballs logic even _after_ CONNECT has been
sent to a proxy, while the happy eyeball phase is already (should be)
over by then.
This is solved by splitting the multi state into two separate states
introducing the new SENDPROTOCONNECT state.
Bug: http://curl.haxx.se/mail/lib-2015-01/0170.html
Reported-by: Peter Laser
Daniel Stenberg [Sat, 7 Mar 2015 18:14:35 +0000 (19:14 +0100)]
conncontrol: only log changes to the connection bit
Daniel Stenberg [Sat, 7 Mar 2015 10:10:30 +0000 (11:10 +0100)]
http2: use CURL_HTTP_VERSION_* symbols instead of NPN_*
Since they already exist and will make comparing easier
Daniel Stenberg [Sat, 7 Mar 2015 09:55:37 +0000 (10:55 +0100)]
http2: make the info-message about receiving HTTP2 headers debug-only
Alessandro Ghedini [Wed, 25 Feb 2015 10:33:12 +0000 (11:33 +0100)]
urldata: remove unused asked_for_h2 field
Alessandro Ghedini [Thu, 19 Feb 2015 18:41:48 +0000 (19:41 +0100)]
polarssl: make it possible to enable ALPN/NPN without HTTP2
Alessandro Ghedini [Mon, 16 Feb 2015 15:41:57 +0000 (16:41 +0100)]
nss: make it possible to enable ALPN/NPN without HTTP2
Alessandro Ghedini [Thu, 19 Feb 2015 15:22:07 +0000 (16:22 +0100)]
gtls: make it possible to enable ALPN/NPN without HTTP2
Alessandro Ghedini [Mon, 16 Feb 2015 15:47:56 +0000 (16:47 +0100)]
openssl: make it possible to enable ALPN/NPN without HTTP2
Daniel Stenberg [Fri, 6 Mar 2015 22:14:25 +0000 (23:14 +0100)]
metalink: add some error checks
malloc() and strdup() calls without checking return codes.
Reported-by: Markus Elfring
Bug: https://github.com/bagder/curl/issues/150
Daniel Stenberg [Fri, 6 Mar 2015 16:07:28 +0000 (17:07 +0100)]
curl_easy_setopt.3: added CURLOPT_SSL_VERIFYSTATUS
Reported-by: Jonathan Cardoso
Daniel Stenberg [Fri, 6 Mar 2015 09:13:40 +0000 (10:13 +0100)]
urldata: fix gnutls build
Steve Holme [Thu, 5 Mar 2015 20:47:14 +0000 (20:47 +0000)]
openssl: Removed use of USE_SSLEAY from the Visual Studio project files
In addition to commit
709cf76f6b, removed the USE_SSLEAY preprocessor
variable from the Visual Studio project files as it isn't required
anymore.
Daniel Stenberg [Thu, 5 Mar 2015 14:19:07 +0000 (15:19 +0100)]
multi: fix memory-leak on timeout (regression)
Since
1342a96ecfe0d44, a timeout detected in the multi state machine didn't
necesarily clear everything up, like formpost data.
Bug: https://github.com/bagder/curl/issues/147
Reported-by: Michel Promonet
Patched-by: Michel Promonet
Daniel Stenberg [Thu, 5 Mar 2015 14:38:47 +0000 (15:38 +0100)]
configure: follow-up fix from
709cf76f6
OpenSSL handling was a little broken.
Daniel Stenberg [Thu, 5 Mar 2015 09:57:52 +0000 (10:57 +0100)]
openssl: remove all uses of USE_SSLEAY
SSLeay was the name of the library that was subsequently turned into
OpenSSL many moons ago (1999). curl does not work with the old SSLeay
library since years. This is now reflected by only using USE_OPENSSL in
code that depends on OpenSSL.
Sergei Nikulov [Mon, 2 Mar 2015 23:15:38 +0000 (02:15 +0300)]
cmake: handle build definitions CURLDEBUG/DEBUGBUILD
Acked-by: Brad King
Daniel Stenberg [Wed, 4 Mar 2015 17:24:46 +0000 (18:24 +0100)]
FAQ: 4.21 Why is there a HTTP/1.1 in my HTTP/2 request?
Daniel Stenberg [Wed, 4 Mar 2015 07:36:38 +0000 (08:36 +0100)]
symbols.pl: handle '-' in the deprecated field
... which otherwise made the script skip the _LAST define for some
symbols.
Reported-by: Jeroen Ooms
Bug: http://curl.haxx.se/mail/lib-2015-03/0052.html
Daniel Stenberg [Wed, 4 Mar 2015 06:29:06 +0000 (07:29 +0100)]
curl.1: fix "The the" typo
Reported-by: Jon Seymour
Daniel Stenberg [Tue, 3 Mar 2015 22:17:43 +0000 (23:17 +0100)]
vtls: use curl_printf.h all over
No need to use _MPRINTF_REPLACE internally.
Daniel Stenberg [Tue, 3 Mar 2015 22:08:02 +0000 (23:08 +0100)]
tool: use ENABLE_CURLX_PRINTF instead of _MPRINTF_REPLACE
Daniel Stenberg [Tue, 3 Mar 2015 22:00:54 +0000 (23:00 +0100)]
tool_writeenv: remove _MPRINTF_REPLACE define, it wasn't used
Sergei Nikulov [Mon, 2 Mar 2015 12:58:27 +0000 (15:58 +0300)]
libtest: fixed linker errors on msvc
Bug: https://github.com/bagder/curl/pull/144
Daniel Stenberg [Tue, 3 Mar 2015 11:36:18 +0000 (12:36 +0100)]
mprintf.h: remove #ifdef CURLDEBUG
... and as a consequence, introduce curl_printf.h with that re-define
magic instead and make all libcurl code use that instead.
Daniel Stenberg [Tue, 3 Mar 2015 11:09:25 +0000 (12:09 +0100)]
tool_getpass: remove unused curl/mprintf.h include
Daniel Stenberg [Mon, 2 Mar 2015 23:38:41 +0000 (00:38 +0100)]
CONTRIBUTING.md: file for advice on github
Viktor Szakáts [Mon, 2 Mar 2015 10:42:04 +0000 (11:42 +0100)]
BINDINGS: add link to Harbour bindings
And UTF8-fix a few names
Daniel Stenberg [Mon, 2 Mar 2015 16:25:39 +0000 (17:25 +0100)]
CURLOPT_HEADERFUNCTION.3: typo in error code name
Reported-by: Jonathan Cardoso
Daniel Stenberg [Mon, 2 Mar 2015 07:51:14 +0000 (08:51 +0100)]
BINDINGS: tclcurl moved
Reporte-by: Steve Havelka
Jay Satiro [Sat, 28 Feb 2015 05:06:45 +0000 (00:06 -0500)]
opts: Fix pipelining examples
Jay Satiro [Sat, 28 Feb 2015 04:58:01 +0000 (23:58 -0500)]
curl_multi_setopt.3: Link to CURLMOPT_MAXCONNECTS
Daniel Stenberg [Sun, 1 Mar 2015 22:39:14 +0000 (23:39 +0100)]
CONTRIBUTE: the new more github-friendly attitude!
Steve Holme [Sat, 28 Feb 2015 11:20:59 +0000 (11:20 +0000)]
RELEASE-NOTES: Synced with
921d195187
Kamil Dudka [Sat, 28 Feb 2015 09:53:33 +0000 (10:53 +0100)]
tool: wrap lines longer than 79 columns
... to avoid a build failure when configured with --enable-debug
Tatsuhiro Tsujikawa [Thu, 26 Feb 2015 14:28:30 +0000 (23:28 +0900)]
http2: Return error if stream was closed with other than NO_ERROR
Previously, we just ignored error code passed to
on_stream_close_callback and just return 0 (success) after stream
closure even if stream was reset with error. This patch records error
code in on_stream_close_callback, and return -1 and use CURLE_HTTP2
error code on abnormal stream closure.
Steve Holme [Fri, 27 Feb 2015 20:48:38 +0000 (20:48 +0000)]
tool: Updated the warnf() function to use the GlobalConfig structure
As the 'error' and 'mute' options are now part of the GlobalConfig,
rather than per Operation, updated the warnf() function to use this
structure rather than the OperationConfig.
Steve Holme [Thu, 26 Feb 2015 21:12:41 +0000 (21:12 +0000)]
build: Removed DataExecutionPrevention directive from VC9+ project files
Removed the DataExecutionPrevention directive from the project files for
Visual Studio 2008 and above. The XML value in the VC9 project files was
set to "0" (Default) whilst the VC10+ project files contained an empty
XML element.
Steve Holme [Thu, 26 Feb 2015 20:59:20 +0000 (20:59 +0000)]
build: Use default RandomizedBaseAddress directive in VC9+ project files
Visual Studio 2008 introduced support for the address space layout
randomization (ASLR) feature of Windows Vista. However, upgrading the
VC8 project files to VC9 and above disabled this feature.
Removed the RandomizedBaseAddress directive to enabled the default
setting (/DYNAMICBASE). Note: This doesn't appear to have any negative
impact when compiled and ran on Windows XP.
Steve Holme [Thu, 26 Feb 2015 20:43:46 +0000 (20:43 +0000)]
build: Added support to Generate.bat for files in the upcoming vauth folder
Daniel Stenberg [Wed, 25 Feb 2015 12:50:31 +0000 (13:50 +0100)]
http2: return recv error on unexpected EOF
Pointed-out-by: Tatsuhiro Tsujikawa
Bug: http://curl.haxx.se/bug/view.cgi?id=1487
Kamil Dudka [Wed, 25 Feb 2015 11:12:47 +0000 (12:12 +0100)]
dist: add symbol-scan.pl to the tarball
... in order to make test1135 succeed
Daniel Stenberg [Wed, 25 Feb 2015 10:45:46 +0000 (11:45 +0100)]
http2: move lots of verbose output to be debug-only
Kamil Dudka [Tue, 24 Feb 2015 17:58:55 +0000 (18:58 +0100)]
curl-config.in: eliminate double quotes around CURL_CA_BUNDLE
Otherwise it expands to:
echo ""/etc/pki/tls/certs/ca-bundle.crt""
Detected by ShellCheck:
curl-config:74:16: warning: The double quotes around this do
nothing. Remove or escape them. [SC2140]
Kamil Dudka [Tue, 24 Feb 2015 14:18:45 +0000 (15:18 +0100)]
nss: do not skip Curl_nss_seed() if data is NULL
In that case, we only skip writing the error message for failed NSS
initialization (while still returning the correct error code).
Kamil Dudka [Tue, 24 Feb 2015 14:10:15 +0000 (15:10 +0100)]
nss: improve error handling in Curl_nss_random()
The vtls layer now checks the return value, so it is no longer necessary
to abort if a random number cannot be provided by NSS. This also fixes
the following Coverity report:
Error: FORWARD_NULL (CWE-476):
lib/vtls/nss.c:1918: var_compare_op: Comparing "data" to null implies that "data" might be null.
lib/vtls/nss.c:1923: var_deref_model: Passing null pointer "data" to "Curl_failf", which dereferences it.
lib/sendf.c:154:3: deref_parm: Directly dereferencing parameter "data".
Daniel Stenberg [Wed, 25 Feb 2015 09:05:41 +0000 (10:05 +0100)]
RELEASE-PROCEDURE: add some more future release dates
... and remove some old ones
Daniel Stenberg [Mon, 23 Feb 2015 12:12:50 +0000 (13:12 +0100)]
sws: timeout idle CONNECT connections
Daniel Stenberg [Wed, 25 Feb 2015 08:08:13 +0000 (09:08 +0100)]
bump: start working toward 7.42.0
Daniel Stenberg [Wed, 25 Feb 2015 07:34:06 +0000 (08:34 +0100)]
THANKS: added contributors from the 7.41.0 RELEASE-NOTES
Daniel Stenberg [Wed, 25 Feb 2015 07:30:27 +0000 (08:30 +0100)]
RELEASE-NOTES: sync with
ffc2aeec6e (7.41.0 release time!)
Marc Hoersken [Tue, 24 Feb 2015 23:16:10 +0000 (00:16 +0100)]
Revert "telnet.c: fix handling of 0 being returned from custom read function"
This reverts commit
03fa576833643c67579ae216c4e7350fa9b5f2fe.
Marc Hoersken [Tue, 24 Feb 2015 23:01:14 +0000 (00:01 +0100)]
telnet.c: fix invalid use of custom read function if not being set
obj_count can be 1 if the custom read function is set or the stdin
handle is a reference to a pipe. Since the pipe should be handled
using the PeekNamedPipe-check below, the custom read function should
only be used if it is actually enabled.
Marc Hoersken [Tue, 24 Feb 2015 22:59:06 +0000 (23:59 +0100)]
telnet.c: fix handling of 0 being returned from custom read function
According to [1]: "Returning 0 will signal end-of-file to the library
and cause it to stop the current transfer."
This change makes the Windows telnet code handle this case accordingly.
[1] http://curl.haxx.se/libcurl/c/CURLOPT_READFUNCTION.html
Daniel Stenberg [Mon, 23 Feb 2015 12:13:22 +0000 (13:13 +0100)]
sws: stop logging about TPC_NODELAY nonsense
Daniel Stenberg [Mon, 23 Feb 2015 23:06:36 +0000 (00:06 +0100)]
lib530: make it less timing sensible
... by making sure the first request is completed before doing the
remainder.
Kamil Dudka [Mon, 16 Feb 2015 16:16:57 +0000 (17:16 +0100)]
connect: wait for IPv4 connection attempts
... even if the last IPv6 connection attempt has failed.
Bug: https://bugzilla.redhat.com/show_bug.cgi?id=
1187531#c4
Kamil Dudka [Mon, 16 Feb 2015 16:00:05 +0000 (17:00 +0100)]
connect: avoid skipping an IPv4 address
... in case the protocol versions are mixed in a DNS response
(IPv6 -> IPv4 -> IPv6).
Bug: https://bugzilla.redhat.com/show_bug.cgi?id=
1187531#c3
Daniel Stenberg [Mon, 23 Feb 2015 07:05:41 +0000 (08:05 +0100)]
RELEASE-NOTES: synced with
5e4395eab839d
Daniel Stenberg [Fri, 20 Feb 2015 22:31:59 +0000 (23:31 +0100)]
ROADMAP: curl_easy_setopt.3 has already been split up
Remove cmake as marked for removal. It is in much better state now.
Daniel Stenberg [Fri, 20 Feb 2015 22:29:19 +0000 (23:29 +0100)]
ROADMAP: extend the HTTP/2 stuff, remove SPDY
Julian Ospald [Sat, 7 Feb 2015 21:06:40 +0000 (22:06 +0100)]
configure: allow both --with-ca-bundle and --with-ca-path
SSL_CTX_load_verify_locations by default (and if given non-Null
parameters) searches the CAfile first and falls back to CApath. This
allows for CAfile to be a basis (e.g. installed by the package manager)
and CApath to be a user configured directory.
This wasn't reflected by the previous configure constraint which this
patch fixes.
Bug: https://github.com/bagder/curl/pull/139
Ben Boeckel [Wed, 18 Feb 2015 22:19:04 +0000 (17:19 -0500)]
cmake: install the dll file to the correct directory
Alessandro Ghedini [Thu, 19 Feb 2015 18:58:28 +0000 (19:58 +0100)]
nss: fix NPN/ALPN protocol negotiation
Correctly check for memcmp() return value (it returns 0 if the strings match).
This is not really important, since curl is going to use http/1.1 anyway, but
it's still a bug I guess.
Alessandro Ghedini [Thu, 19 Feb 2015 18:55:59 +0000 (19:55 +0100)]
polarssl: fix ALPN protocol negotiation
Correctly check for strncmp() return value (it returns 0 if the strings
match).
Sergei Nikulov [Tue, 23 Dec 2014 21:05:57 +0000 (00:05 +0300)]
CMake: Fix generation of tool_hugehelp.c on windows
Use "cmake -E echo" instead of "echo".
Reviewed-by: Brad King <brad.king@kitware.com>
Sergei Nikulov [Tue, 23 Dec 2014 21:05:57 +0000 (00:05 +0300)]
CMake: fix winsock2 detection on windows
Set CMAKE_REQUIRED_DEFINITIONS to include definitions needed to get
the winsock2 API from windows.h. Simplify the order of checks to
avoid extra conditions.
Use check_include_file instead of check_include_file_concat to look
for OpenSSL headers. They do not need to participate in a sequence
of dependent system headers. Also they may cause winsock.h to be
included before ws2tcpip.h, causing the latter to not be detected
in the sequence.
Reviewed-by: Brad King <brad.king@kitware.com>
Alessandro Ghedini [Thu, 19 Feb 2015 15:44:27 +0000 (16:44 +0100)]
gtls: fix build with HTTP2
Steve Holme [Mon, 16 Feb 2015 00:20:07 +0000 (00:20 +0000)]
Makefile.vc6: Corrected typos in rename of darwinssl.obj
Nick Zitzmann [Sun, 15 Feb 2015 23:11:01 +0000 (17:11 -0600)]
By request, change the name of "curl_darwinssl.[ch]" to "darwinssl.[ch]"
Steve Holme [Sat, 14 Feb 2015 22:22:52 +0000 (22:22 +0000)]
RELEASE-NOTES: Synced with
6f89f86c3d
Steve Holme [Sat, 14 Feb 2015 20:54:06 +0000 (20:54 +0000)]
tests/README: Updated to reflect email test ranges
Alessandro Ghedini [Sat, 14 Feb 2015 17:35:27 +0000 (18:35 +0100)]
curl.1: --cert-status is also supported by OpenSSL now
Steve Holme [Sat, 14 Feb 2015 17:01:49 +0000 (17:01 +0000)]
build: Removed Visual Studio SuppressStartupBanner directive for VC8+
Visual Studio 2005 and above defaults to disabling the startup banner
for the Compiler, Linker and MIDL tools (with /NOLOGO). As such there
is no need to explicitly set the SuppressStartupBanner directive, as
this is a leftover from the VC7 and VC7.1 projects being upgraded to
VC8 and above.
Kamil Dudka [Thu, 12 Feb 2015 07:34:40 +0000 (08:34 +0100)]
openssl: fix a compile-time warning
lib/vtls/openssl.c:1450:7: warning: extra tokens at end of #endif directive
Steve Holme [Wed, 11 Feb 2015 20:56:12 +0000 (20:56 +0000)]
openssl: Use OPENSSL_IS_BORINGSSL for BoringSSL detection
For consistency with other conditionally compiled code in openssl.c,
use OPENSSL_IS_BORINGSSL rather than HAVE_BORINGSSL and try to use
HAVE_BORINGSSL outside of openssl.c when the OpenSSL header files are
not included.
Patrick Monnerat [Wed, 11 Feb 2015 18:51:57 +0000 (19:51 +0100)]
ftp: accept all 2xx responses to the PORT command
Steve Holme [Mon, 9 Feb 2015 20:58:33 +0000 (20:58 +0000)]
openssl: Disable OCSP in old versions of OpenSSL
Versions of OpenSSL prior to v0.9.8h do not support the necessary
functions for OCSP stapling.
Tatsuhiro Tsujikawa [Mon, 9 Feb 2015 13:30:24 +0000 (22:30 +0900)]
http2: Fix bug that associated stream canceled on PUSH_PROMISE
Previously we don't ignore PUSH_PROMISE header fields in on_header
callback. It makes header values mixed with following HEADERS,
resulting protocol error.
Jay Satiro [Fri, 2 Jan 2015 17:33:41 +0000 (12:33 -0500)]
polarssl: Fix exclusive SSL protocol version options
Prior to this change the options for exclusive SSL protocol versions did
not actually set the protocol exclusive.
http://curl.haxx.se/mail/lib-2015-01/0002.html
Reported-by: Dan Fandrich
Jay Satiro [Fri, 2 Jan 2015 17:37:45 +0000 (12:37 -0500)]
gskit: Fix exclusive SSLv3 option
Daniel Stenberg [Mon, 9 Feb 2015 09:33:54 +0000 (10:33 +0100)]
curl.1: clarify that -X is used for all requests
Reported-by: Jon Seymour
Daniel Stenberg [Sat, 7 Feb 2015 23:05:55 +0000 (00:05 +0100)]
curl.1: add warning when using -H and redirects
Steve Holme [Sat, 7 Feb 2015 20:50:30 +0000 (20:50 +0000)]
schannel: Removed curl_ prefix from source files
Removed the curl_ prefix from the schannel source files as discussed
with Marc and Daniel at FOSDEM.
Daniel Stenberg [Fri, 6 Feb 2015 13:36:25 +0000 (14:36 +0100)]
md5: use axTLS's own MD5 functions when available
Daniel Stenberg [Fri, 6 Feb 2015 13:26:01 +0000 (14:26 +0100)]
MD(4|5): make the MD4_* and MD5_* functions static
Daniel Stenberg [Fri, 6 Feb 2015 13:04:16 +0000 (14:04 +0100)]
axtls: fix conversion from size_t to int warning
Steve Holme [Thu, 5 Feb 2015 20:31:12 +0000 (20:31 +0000)]
ftp: Use 'CURLcode result' for curl result codes
Daniel Stenberg [Thu, 5 Feb 2015 10:56:29 +0000 (11:56 +0100)]
openssl: SSL_SESSION->ssl_version no longer exist
The struct went private in 1.0.2 so we cannot read the version number
from there anymore. Use SSL_version() instead!
Reported-by: Gisle Vanem
Bug: http://curl.haxx.se/mail/lib-2015-02/0034.html
Dan Fandrich [Wed, 4 Feb 2015 21:59:14 +0000 (22:59 +0100)]
unit1600: Fix compilation when NTLM is disabled
Daniel Stenberg [Tue, 3 Feb 2015 09:09:35 +0000 (10:09 +0100)]
MD5: fix compiler warnings and code style nits
Daniel Stenberg [Tue, 3 Feb 2015 09:06:20 +0000 (10:06 +0100)]
MD5: replace implementation
The previous one was "encumbered" by RSA Inc - to avoid the licensing
restrictions it has being replaced. This is the initial import,
inserting the md5.c and md5.h files from
http://openwall.info/wiki/people/solar/software/public-domain-source-code/md5
Code-by: Alexander Peslyak
Daniel Stenberg [Tue, 3 Feb 2015 09:00:54 +0000 (10:00 +0100)]
MD4: fix compiler warnings and code style nits
Daniel Stenberg [Tue, 3 Feb 2015 08:55:47 +0000 (09:55 +0100)]
MD4: replace implementation
The previous one was "encumbered" by RSA Inc - to avoid the licensing
restrictions it has being replaced. This is the initial import,
inserting the md4.c and md4.h files from
http://openwall.info/wiki/people/solar/software/public-domain-source-code/md4
Code-by: Alexander Peslyak
Steve Holme [Wed, 4 Feb 2015 00:09:31 +0000 (00:09 +0000)]
telnet: Prefer 'CURLcode result' for curl result codes
Steve Holme [Wed, 4 Feb 2015 00:05:30 +0000 (00:05 +0000)]
hostasyn: Prefer 'CURLcode result' for curl result codes
Steve Holme [Wed, 4 Feb 2015 00:03:05 +0000 (00:03 +0000)]
schannel: Prefer 'CURLcode result' for curl result codes
Daniel Stenberg [Tue, 3 Feb 2015 21:52:18 +0000 (22:52 +0100)]
unit1601: MD5 unit tests
Daniel Stenberg [Tue, 3 Feb 2015 19:59:54 +0000 (20:59 +0100)]
unit1600: unit test for Curl_ntlm_core_mk_nt_hash
Daniel Stenberg [Tue, 3 Feb 2015 09:44:41 +0000 (10:44 +0100)]
unit1600: NTLM unit test