Richard Russon [Thu, 3 Aug 2017 14:36:53 +0000 (15:36 +0100)]
merge: create library of shared code
* split out state functions
* split out parameter functions
* create library
* change code to use lib/lib.h
* move the ascii functions to the library
* move the base64 functions to the library
* move the date functions to the library
* move the exit functions to the library
* move the md5 functions to the library
* move the sha1 functions to the library
* move the memory functions to the library
* move the message functions to the library
* move the debug functions to the library
* move the string functions to the library
* move the file functions to the library
* move the buffer functions to the library
* move the hash functions to the library
* drop lib.c
* doxygen: update config
* rename the library to libmutt
Pietro Cerutti [Thu, 20 Jul 2017 14:33:55 +0000 (15:33 +0100)]
Look for ncurses headers in more dedicated locations first (#679)
This solves a problem on FreeBSD, where the base system is shipped with
ncurses 5.9 (/usr/include/ncurses.h). When building against 3rd party
ncurses 6.0 from ports (/usr/local/include/ncurses/ncurses.h), the
configure script picks up the 5.9 headers and the 6.0 library. This
might cause problems, since 6.0 is not ABI compatible with 5.0.
Richard Russon [Fri, 14 Jul 2017 21:07:37 +0000 (22:07 +0100)]
rename mutt_format_string and mutt_FormatString
`mutt_format_string` and `mutt_FormatString` were much to similarly
named to be useful. The first only does formatting. The second uses
expandos to allow custom expansion.
To avoid future confusion, I've created new names that are distinct:
mutt_format_string mutt_simple_format
mutt_FormatString mutt_expando_format
Thomas Adam [Sat, 8 Jul 2017 16:17:16 +0000 (17:17 +0100)]
compile-time output: use two lists
When asking NeoMutt for a list of compile-time features, the current
implementation assumes a mixture of options which can be enabled through
./configure, and some which default to on, without compile-time
exclusion.
It's not clear to anyone why this variable existed in the first place,
so it was decided that it should be removed.
Most of the time, AC_CHECK_LIB and AC_SEARCH_LIBS will already alter
LIBS to prepend to it the found library, so there is no real reason to
duplicate this mechanism.
Some manual assignments have been kept because either the
action-if-found was set to no-op, or because new found libraries were
appended to MUTTLIBS, so this keeps the diff minimal with the same
"behaviour".
Richard Russon [Fri, 14 Jul 2017 11:08:04 +0000 (12:08 +0100)]
merge: upstream fixes (mutt/default)
* fix signed/unsigned comparison in longest_common_prefix
* Fix crash when $postponed is on another server.
* bcache: cast to avoid implicit signed/unsigned comparison in bcache_path
* drop unused flags argument from imap_access
Kevin McCarthy [Wed, 12 Jul 2017 19:38:22 +0000 (12:38 -0700)]
Fix crash when $postponed is on another server.
imap_mxcmp() translates NULL to "INBOX". When $postponed points to a
URL with an empty or "INBOX" path, this will end up matching against a
NULL idata->mailbox in imap_status(). This resulted in a crash
because idata->ctx is also NULL.
Thanks to Olaf Hering for the detailed bug report and suggested fix.
Kevin McCarthy [Wed, 12 Jul 2017 19:38:22 +0000 (12:38 -0700)]
Fix crash when $postponed is on another server.
imap_mxcmp() translates NULL to "INBOX". When $postponed points to a
URL with an empty or "INBOX" path, this will end up matching against a
NULL idata->mailbox in imap_status(). This resulted in a crash
because idata->ctx is also NULL.
Thanks to Olaf Hering for the detailed bug report and suggested fix.
Richard Russon [Thu, 6 Jul 2017 14:15:31 +0000 (15:15 +0100)]
merge: upstream fixes (mutt/default)
* Add more description for the %S and %Z $index_format characters.
* Add L10N comments to the GNUTLS certificate prompt.
* Add ~<() and ~>() immediate parent/children patterns. (closes #3144)
Stefan Bühler [Tue, 4 Jul 2017 09:57:24 +0000 (11:57 +0200)]
fix gpgme S/MIME non-detached signature handling
- gpgsm ends the session after the decrypt error, so restart gpgsm when
retrying with "maybe_signed".
- evolution sends encrypted + signed S/MIME mails with non-detached
signatures