]>
granicus.if.org Git - neomutt/log
Kevin McCarthy [Sun, 26 May 2019 23:03:40 +0000 (16:03 -0700)]
Change mutt_addr_is_user() to no for a NULL address
The behavior is generating a false 'F' flag for a spam message with an
unparsable From address.
After reviewing the callers, I can't see a reason returning 'yes' in
this case.
Co-authored-by: Richard Russon <rich@flatcap.org>
Kevin McCarthy [Sun, 26 May 2019 21:34:42 +0000 (14:34 -0700)]
Turn on $ssl_force_tls by default
Ticket #135 suggests that these days, it's better to force encryption
over all connections. RFC8314 is recommending MUA's move in that
direction (actually even directing towards implicit TLS over
STARTTLS).
I'm enabling this at the beginning of the 1.13 development cycle to
give others time to chime in with any objections. Personally, I've
had this option set myself for years. The only place it could become
an issue is for a localhost IMAP server with no cert. In that case,
it's easy enough to have an account hook unset if needed, and I think
a better idea that the user be forced to turn it off.
Co-authored-by: Richard Russon <rich@flatcap.org>
David Harrigan [Thu, 6 Jun 2019 12:09:25 +0000 (13:09 +0100)]
Save attachments without prompting.
If the 'attach_save_without_prompting' variable is set (to true), then on
saving a list of tagged attachments the user will not be prompted each time
for the name of file.
Conflicting filenames during save are also handled.
-=david=-
closes #1603
Pietro Cerutti [Wed, 5 Jun 2019 08:45:19 +0000 (08:45 +0000)]
Update to latest autosetup, use @include feature
Up-to-date with Autosetup
4701f3e (2019-06-05)
Pietro Cerutti [Thu, 6 Jun 2019 09:06:56 +0000 (09:06 +0000)]
Fix segfault on bounce
Fixes #1735
Richard Russon [Wed, 5 Jun 2019 10:55:41 +0000 (11:55 +0100)]
add missing translation file
Richard Russon [Mon, 3 Jun 2019 12:00:17 +0000 (13:00 +0100)]
show backtrace on segfault
Add a configure option `--backtrace` that uses libunwind to print a
basic backtrace if NeoMutt segfaults.
Co-authored-by: Pietro Cerutti <gahr@gahr.ch>
Richard Russon [Mon, 3 Jun 2019 14:03:05 +0000 (15:03 +0100)]
add funding details
Richard Russon [Sun, 2 Jun 2019 23:32:30 +0000 (00:32 +0100)]
merge Config and normal Accounts
Richard Russon [Mon, 3 Jun 2019 10:59:24 +0000 (11:59 +0100)]
merge: add basic notifications
* debug: add notify level
* add central NeoMutt object
* add notify/observer
* config notify
* test: fix config tests
Richard Russon [Tue, 28 May 2019 14:20:44 +0000 (15:20 +0100)]
test: fix config tests
Richard Russon [Tue, 21 May 2019 09:31:22 +0000 (10:31 +0100)]
config notify
Richard Russon [Tue, 21 May 2019 12:52:03 +0000 (13:52 +0100)]
add notify/observer
Richard Russon [Mon, 20 May 2019 11:42:20 +0000 (12:42 +0100)]
add central NeoMutt object
Richard Russon [Mon, 20 May 2019 14:29:24 +0000 (14:29 +0000)]
debug: add notify level
Richard Russon [Mon, 3 Jun 2019 09:01:25 +0000 (10:01 +0100)]
merge: mime: use description if filename is missing
* mime_lookup: use description if filename isn't useful
* mime_lookup: use compose mailcap entries when replying
Andres Freund [Mon, 29 Aug 2016 18:16:38 +0000 (11:16 -0700)]
mime_lookup: use compose mailcap entries when replying
Use compose mailcap entries to format attachments when replying to a message
Andres Freund [Thu, 22 Nov 2012 23:12:18 +0000 (00:12 +0100)]
mime_lookup: use description if filename isn't useful
"fix" mime_lookup to also look into Description mime tags if the
filename tag doesn't come up with something useful
Richard Russon [Sun, 2 Jun 2019 00:04:14 +0000 (01:04 +0100)]
test: fix config_dump
Richard Russon [Sat, 1 Jun 2019 23:48:01 +0000 (00:48 +0100)]
merge: small fixes and tidying
* clang-format
* use enum return value
* test: fix lcov out-of-tree build
* test: boolify test_mutt_pattern_comp()
* refactor: replace ctime() with strftime()
* bug: prevent unterminated string
* check range of uuencoded char
* log failed atoi() calls
* fix buffer handling
* restore randomness to mutt_buffer_mktemp_full()
* check state buffer
* check for overflow in mutt_edit_content_type()
* reduce scope of variables
* add/remove checks
* use param, not global, in prereq()
* add brackets to clarify logic
* misc small changes
Richard Russon [Sat, 1 Jun 2019 20:05:33 +0000 (21:05 +0100)]
misc small changes
- Initialise some variables
- Fix some formatting strings
- Remove unused variables
Richard Russon [Sat, 1 Jun 2019 19:48:29 +0000 (20:48 +0100)]
add brackets to clarify logic
Richard Russon [Sat, 1 Jun 2019 19:46:32 +0000 (20:46 +0100)]
use param, not global, in prereq()
The test function prereq() wasn't using the Context parameter, but the
Context global.
Richard Russon [Sat, 1 Jun 2019 19:44:22 +0000 (20:44 +0100)]
add/remove checks
Some functions needed checks.
Some others had redundant checks.
Richard Russon [Sat, 1 Jun 2019 17:17:30 +0000 (18:17 +0100)]
reduce scope of variables
Richard Russon [Sat, 2 Mar 2019 14:27:15 +0000 (14:27 +0000)]
check for overflow in mutt_edit_content_type()
Thanks to lgtm.com
Richard Russon [Sat, 1 Jun 2019 11:28:24 +0000 (12:28 +0100)]
check state buffer
Coverity: CID 186614
Richard Russon [Sat, 1 Jun 2019 11:25:34 +0000 (12:25 +0100)]
restore randomness to mutt_buffer_mktemp_full()
Coverity: CID 189775
Richard Russon [Sat, 1 Jun 2019 11:06:02 +0000 (12:06 +0100)]
fix buffer handling
Coverity: CID 197580, 198376, 198378, 198379
Richard Russon [Sat, 1 Jun 2019 11:00:33 +0000 (12:00 +0100)]
log failed atoi() calls
Coverity: CID 198492, 198493
Richard Russon [Sat, 1 Jun 2019 10:50:18 +0000 (11:50 +0100)]
check range of uuencoded char
Coverity: CID 180829
Richard Russon [Sat, 1 Jun 2019 10:43:35 +0000 (11:43 +0100)]
bug: prevent unterminated string
Coverity: CID 83483
Richard Russon [Fri, 31 May 2019 22:39:54 +0000 (23:39 +0100)]
refactor: replace ctime() with strftime()
ctime() is marked obsolete in POSIX:2008.
It's recommended to use strftime() instead.
Thanks to lgtm.com
Richard Russon [Fri, 31 May 2019 21:38:09 +0000 (22:38 +0100)]
test: boolify test_mutt_pattern_comp()
Richard Russon [Thu, 30 May 2019 22:40:48 +0000 (23:40 +0100)]
test: fix lcov out-of-tree build
Richard Russon [Thu, 30 May 2019 20:24:48 +0000 (21:24 +0100)]
use enum return value
- mutt_check_mime_type()
- mutt_lookup_mime_type()
Richard Russon [Sat, 1 Jun 2019 20:19:14 +0000 (21:19 +0100)]
clang-format
Richard Russon [Thu, 30 May 2019 10:30:47 +0000 (11:30 +0100)]
travis: workaround locale problems
Richard Russon [Thu, 30 May 2019 10:08:56 +0000 (11:08 +0100)]
merge: improve date tests
* date: move defines, so they can be used for testing
* test: improve test_mutt_date_add_timeout()
* test: improve test_mutt_date_check_month()
* test: improve test_mutt_date_gmtime()
* test: improve test_mutt_date_is_day_name()
* test: improve test_mutt_date_local_tz()
* test: improve test_mutt_date_localtime()
* test: improve test_mutt_date_localtime_format()
* test: improve test_mutt_date_make_date()
* test: improve test_mutt_date_make_imap()
* test: improve test_mutt_date_make_time()
* test: improve test_mutt_date_make_tls()
* test: improve test_mutt_date_normalize_time()
* test: improve test_mutt_date_parse_date()
* test: improve test_mutt_date_parse_imap()
Richard Russon [Thu, 30 May 2019 09:34:25 +0000 (10:34 +0100)]
test: improve test_mutt_date_parse_imap()
Richard Russon [Thu, 30 May 2019 09:34:25 +0000 (10:34 +0100)]
test: improve test_mutt_date_parse_date()
Richard Russon [Thu, 30 May 2019 09:34:25 +0000 (10:34 +0100)]
test: improve test_mutt_date_normalize_time()
Richard Russon [Thu, 30 May 2019 09:34:25 +0000 (10:34 +0100)]
test: improve test_mutt_date_make_tls()
Richard Russon [Thu, 30 May 2019 09:34:25 +0000 (10:34 +0100)]
test: improve test_mutt_date_make_time()
Richard Russon [Thu, 30 May 2019 09:34:25 +0000 (10:34 +0100)]
test: improve test_mutt_date_make_imap()
Richard Russon [Thu, 30 May 2019 09:34:25 +0000 (10:34 +0100)]
test: improve test_mutt_date_make_date()
Richard Russon [Thu, 30 May 2019 09:34:25 +0000 (10:34 +0100)]
test: improve test_mutt_date_localtime_format()
Richard Russon [Thu, 30 May 2019 09:34:25 +0000 (10:34 +0100)]
test: improve test_mutt_date_localtime()
Richard Russon [Thu, 30 May 2019 09:34:25 +0000 (10:34 +0100)]
test: improve test_mutt_date_local_tz()
Richard Russon [Thu, 30 May 2019 09:34:25 +0000 (10:34 +0100)]
test: improve test_mutt_date_is_day_name()
Richard Russon [Thu, 30 May 2019 09:34:25 +0000 (10:34 +0100)]
test: improve test_mutt_date_gmtime()
Richard Russon [Thu, 30 May 2019 09:34:25 +0000 (10:34 +0100)]
test: improve test_mutt_date_check_month()
Richard Russon [Thu, 30 May 2019 09:34:25 +0000 (10:34 +0100)]
test: improve test_mutt_date_add_timeout()
Richard Russon [Thu, 30 May 2019 09:35:11 +0000 (10:35 +0100)]
date: move defines, so they can be used for testing
Richard Russon [Thu, 30 May 2019 10:08:36 +0000 (11:08 +0100)]
merge: improve list tests
* test: ignore mutt_exit()
* test: add shared list testing code
* test: improve test_mutt_list_clear()
* test: improve test_mutt_list_compare()
* test: improve test_mutt_list_find()
* test: improve test_mutt_list_free()
* test: improve test_mutt_list_free_type()
* test: improve test_mutt_list_insert_after()
* test: improve test_mutt_list_insert_head()
* test: improve test_mutt_list_insert_tail()
* test: improve test_mutt_list_match()
Richard Russon [Wed, 29 May 2019 16:00:53 +0000 (17:00 +0100)]
test: improve test_mutt_list_match()
Richard Russon [Wed, 29 May 2019 16:00:53 +0000 (17:00 +0100)]
test: improve test_mutt_list_insert_tail()
Richard Russon [Wed, 29 May 2019 16:00:53 +0000 (17:00 +0100)]
test: improve test_mutt_list_insert_head()
Richard Russon [Wed, 29 May 2019 16:00:53 +0000 (17:00 +0100)]
test: improve test_mutt_list_insert_after()
Richard Russon [Wed, 29 May 2019 16:00:53 +0000 (17:00 +0100)]
test: improve test_mutt_list_free_type()
Richard Russon [Wed, 29 May 2019 16:00:53 +0000 (17:00 +0100)]
test: improve test_mutt_list_free()
Richard Russon [Wed, 29 May 2019 16:00:53 +0000 (17:00 +0100)]
test: improve test_mutt_list_find()
Richard Russon [Wed, 29 May 2019 16:00:53 +0000 (17:00 +0100)]
test: improve test_mutt_list_compare()
Richard Russon [Wed, 29 May 2019 16:00:53 +0000 (17:00 +0100)]
test: improve test_mutt_list_clear()
Richard Russon [Wed, 29 May 2019 16:01:33 +0000 (17:01 +0100)]
test: add shared list testing code
Richard Russon [Tue, 28 May 2019 11:45:42 +0000 (12:45 +0100)]
test: ignore mutt_exit()
toogley [Sat, 25 May 2019 08:59:48 +0000 (10:59 +0200)]
doc: add example to find all maildir mailboxes
Richard Russon [Mon, 27 May 2019 09:43:30 +0000 (10:43 +0100)]
test: fix test failures
Pietro Cerutti [Mon, 27 May 2019 07:58:59 +0000 (07:58 +0000)]
Fix list-reply regression introduced when converting Address to TAILQ
Fixes #1724
Sebastian Stark [Sun, 26 May 2019 08:04:58 +0000 (10:04 +0200)]
make OP_HALF_{UP,DOWN} behave symmetric.
- the calculation of number of lines to scroll up/down should not
depend on whether the number of rows in the pager/index/terminal is
odd or even.
- this patch will make the behaviour symmetric such that in both cases
(even/odd number of rows) scrolling up and down by half a page (or the
other way round) will get you back to the exact same line as before.
Richard Russon [Sun, 26 May 2019 16:20:09 +0000 (17:20 +0100)]
merge: improve string tests
* test: improve test_mutt_str_adjust()
* test: improve test_mutt_str_append_item()
* test: improve test_mutt_str_asprintf()
* test: improve test_mutt_str_dequote_comment()
* test: improve test_mutt_str_find_word()
* test: improve test_mutt_str_getenv()
* test: improve test_mutt_str_inline_replace()
* test: improve test_mutt_str_is_ascii()
* test: improve test_mutt_str_is_email_wsp()
* test: improve test_mutt_str_lws_len()
* test: improve test_mutt_str_lws_rlen()
* test: improve test_mutt_str_next_word()
* test: improve test_mutt_str_pretty_size()
* test: improve test_mutt_str_remall_strcasestr()
* test: improve test_mutt_str_remove_trailing_ws()
* test: improve test_mutt_str_replace()
* test: improve test_mutt_str_rstrnstr()
* test: improve test_mutt_str_skip_email_wsp()
* test: improve test_mutt_str_skip_whitespace()
* test: improve test_mutt_str_split()
* test: improve test_mutt_str_startswith()
* test: improve test_mutt_str_strcasecmp()
* test: improve test_mutt_str_strcasestr()
* test: improve test_mutt_str_strcat()
* test: improve test_mutt_str_strchrnul()
* test: improve test_mutt_str_strcmp()
* test: improve test_mutt_str_strcoll()
* test: improve test_mutt_str_strdup()
* test: improve test_mutt_str_strfcpy()
* test: improve test_mutt_str_stristr()
* test: improve test_mutt_str_strlen()
* test: improve test_mutt_str_strlower()
* test: improve test_mutt_str_strncasecmp()
* test: improve test_mutt_str_strncat()
* test: improve test_mutt_str_strncmp()
* test: improve test_mutt_str_strnfcpy()
* test: improve test_mutt_str_substr_cpy()
* test: improve test_mutt_str_substr_dup()
* test: improve test_mutt_str_word_casecmp()
Richard Russon [Sun, 26 May 2019 15:02:24 +0000 (16:02 +0100)]
test: improve test_mutt_str_word_casecmp()
Richard Russon [Sun, 26 May 2019 15:02:24 +0000 (16:02 +0100)]
test: improve test_mutt_str_substr_dup()
Richard Russon [Sun, 26 May 2019 15:02:24 +0000 (16:02 +0100)]
test: improve test_mutt_str_substr_cpy()
Richard Russon [Sun, 26 May 2019 15:02:24 +0000 (16:02 +0100)]
test: improve test_mutt_str_strnfcpy()
Richard Russon [Sun, 26 May 2019 15:02:24 +0000 (16:02 +0100)]
test: improve test_mutt_str_strncmp()
Richard Russon [Sun, 26 May 2019 15:02:24 +0000 (16:02 +0100)]
test: improve test_mutt_str_strncat()
Richard Russon [Sun, 26 May 2019 15:02:24 +0000 (16:02 +0100)]
test: improve test_mutt_str_strncasecmp()
Richard Russon [Sun, 26 May 2019 15:02:24 +0000 (16:02 +0100)]
test: improve test_mutt_str_strlower()
Richard Russon [Sun, 26 May 2019 15:02:24 +0000 (16:02 +0100)]
test: improve test_mutt_str_strlen()
Richard Russon [Sun, 26 May 2019 15:02:24 +0000 (16:02 +0100)]
test: improve test_mutt_str_stristr()
Richard Russon [Sun, 26 May 2019 15:02:24 +0000 (16:02 +0100)]
test: improve test_mutt_str_strfcpy()
Richard Russon [Sun, 26 May 2019 15:02:24 +0000 (16:02 +0100)]
test: improve test_mutt_str_strdup()
Richard Russon [Sun, 26 May 2019 15:02:24 +0000 (16:02 +0100)]
test: improve test_mutt_str_strcoll()
Richard Russon [Sun, 26 May 2019 15:02:24 +0000 (16:02 +0100)]
test: improve test_mutt_str_strcmp()
Richard Russon [Sun, 26 May 2019 15:02:24 +0000 (16:02 +0100)]
test: improve test_mutt_str_strchrnul()
Richard Russon [Sun, 26 May 2019 15:02:24 +0000 (16:02 +0100)]
test: improve test_mutt_str_strcat()
Richard Russon [Sun, 26 May 2019 15:02:24 +0000 (16:02 +0100)]
test: improve test_mutt_str_strcasestr()
Richard Russon [Sun, 26 May 2019 15:02:24 +0000 (16:02 +0100)]
test: improve test_mutt_str_strcasecmp()
Richard Russon [Sun, 26 May 2019 15:02:24 +0000 (16:02 +0100)]
test: improve test_mutt_str_startswith()
Richard Russon [Sun, 26 May 2019 15:02:23 +0000 (16:02 +0100)]
test: improve test_mutt_str_split()
Richard Russon [Sun, 26 May 2019 15:02:23 +0000 (16:02 +0100)]
test: improve test_mutt_str_skip_whitespace()
Richard Russon [Sun, 26 May 2019 15:02:23 +0000 (16:02 +0100)]
test: improve test_mutt_str_skip_email_wsp()
Richard Russon [Sun, 26 May 2019 15:02:23 +0000 (16:02 +0100)]
test: improve test_mutt_str_rstrnstr()
Richard Russon [Sun, 26 May 2019 15:02:23 +0000 (16:02 +0100)]
test: improve test_mutt_str_replace()
Richard Russon [Sun, 26 May 2019 15:02:23 +0000 (16:02 +0100)]
test: improve test_mutt_str_remove_trailing_ws()
Richard Russon [Sun, 26 May 2019 15:02:23 +0000 (16:02 +0100)]
test: improve test_mutt_str_remall_strcasestr()
Richard Russon [Sun, 26 May 2019 15:02:23 +0000 (16:02 +0100)]
test: improve test_mutt_str_pretty_size()
Richard Russon [Sun, 26 May 2019 15:02:23 +0000 (16:02 +0100)]
test: improve test_mutt_str_next_word()
Richard Russon [Sun, 26 May 2019 15:02:23 +0000 (16:02 +0100)]
test: improve test_mutt_str_lws_rlen()