Tom Lane [Tue, 27 Mar 2007 23:21:12 +0000 (23:21 +0000)]
Fix array coercion expressions to ensure that the correct volatility is
seen by code inspecting the expression. The best way to do this seems
to be to drop the original representation as a function invocation, and
instead make a special expression node type that represents applying
the element-type coercion function to each array element. In this way
the element function is exposed and will be checked for volatility.
Per report from Guillaume Smet.
Alvaro Herrera [Tue, 27 Mar 2007 20:36:03 +0000 (20:36 +0000)]
Cosmetic changes: rename some struct fields, and move the fetching of pgstat
table entries to a separate routine. Don't pass the pgstat database entry to
do_autovacuum; rather, have it fetch it by itself.
Bruce Momjian [Tue, 27 Mar 2007 17:27:01 +0000 (17:27 +0000)]
Remove item due to lack of interest:
< * %Add pg_get_acldef(), pg_get_typedefault(), pg_get_attrdef(),
< pg_get_tabledef(), pg_get_domaindef(), pg_get_functiondef()
<
< These would be for application use, not for use by pg_dump.
<
Bruce Momjian [Tue, 27 Mar 2007 15:36:40 +0000 (15:36 +0000)]
Add:
>
> * Allow configuration of backend priorities via the operating system
>
> Though backend priorities make priority inversion during lock
> waits possible, research shows that this is not a huge problem.
> http://archives.postgresql.org/pgsql-general/2007-02/msg00493.php
Bruce Momjian [Mon, 26 Mar 2007 23:47:53 +0000 (23:47 +0000)]
Add:
> * Increase the number of rows recognized as dead during multi-statement
> transactions
>
> http://archives.postgresql.org/pgsql-patches/2007-03/msg00358.php
>
Tom Lane [Mon, 26 Mar 2007 16:58:41 +0000 (16:58 +0000)]
Allow non-superuser database owners to create procedural languages.
A DBA is allowed to create a language in his database if it's marked
"tmpldbacreate" in pg_pltemplate. The factory default is that this is set
for all standard trusted languages, but of course a superuser may adjust
the settings. In service of this, add the long-foreseen owner column to
pg_language; renaming, dropping, and altering owner of a PL now follow
normal ownership rules instead of being superuser-only.
Jeremy Drake, with some editorialization by Tom Lane.
Tom Lane [Mon, 26 Mar 2007 02:37:17 +0000 (02:37 +0000)]
Add -lcrypto as one of the possible link dependencies of libkrb5.
Per report from Jim Rosenberg. This possibly should get back-patched,
but I'm a bit suspicious of it still because of the lack of prior reports.
Tom Lane [Mon, 26 Mar 2007 01:41:57 +0000 (01:41 +0000)]
Remove assertion that constraint_exclusion risks wrong answers if
table constraints are changed; this is no longer true now that we
have a plan invalidation mechanism.
Tom Lane [Mon, 26 Mar 2007 00:36:19 +0000 (00:36 +0000)]
Fix plancache's invalidation callback to do the right thing for a SI
reset event, namely invalidate everything. This oversight probably
explains the rare failures that some buildfarm machines have been
showing for the plancache regression test.
Tom Lane [Sun, 25 Mar 2007 23:42:43 +0000 (23:42 +0000)]
Make _SPI_execute_plan pass the query source string down to ProcessUtility
if possible. I had left this undone in the first pass at the API change
for ProcessUtility, but forgot to revisit it after the plancache changes
made it possible to do it.
Tom Lane [Sun, 25 Mar 2007 23:27:59 +0000 (23:27 +0000)]
Remove the prohibition on executing cursor commands through SPI_execute.
Vadim had included this restriction in the original design of the SPI code,
but I'm darned if I can see a reason for it.
I left the macro definition of SPI_ERROR_CURSOR in place, so as not to
needlessly break any SPI callers that are checking for it, but that code
will never actually be returned anymore.
Tom Lane [Sun, 25 Mar 2007 19:45:14 +0000 (19:45 +0000)]
Clean up the representation of special snapshots by including a "method
pointer" in every Snapshot struct. This allows removal of the case-by-case
tests in HeapTupleSatisfiesVisibility, which should make it a bit faster
(I didn't try any performance tests though). More importantly, we are no
longer violating portable C practices by assuming that small integers are
distinct from all pointer values, and HeapTupleSatisfiesDirty no longer
has a non-reentrant API involving side-effects on a global variable.
There were a couple of places calling HeapTupleSatisfiesXXX routines
directly rather than through the HeapTupleSatisfiesVisibility macro.
Since these places had to be changed anyway, I chose to make them go
through the macro for uniformity.
Along the way I renamed HeapTupleSatisfiesSnapshot to HeapTupleSatisfiesMVCC
to emphasize that it's only used with MVCC-type snapshots. I was sorely
tempted to rename HeapTupleSatisfiesVisibility to HeapTupleSatisfiesSnapshot,
but forebore for the moment to avoid confusion and reduce the likelihood that
this patch breaks some of the pending patches. Might want to reconsider
doing that later.
Tatsuo Ishii [Sun, 25 Mar 2007 11:56:04 +0000 (11:56 +0000)]
Add new encoding EUC_JIS_2004 and SHIFT_JIS_2004,
along with new conversions among EUC_JIS_2004, SHIFT_JIS_2004 and UTF-8.
catalog version has been bump up.
Tom Lane [Fri, 23 Mar 2007 20:24:41 +0000 (20:24 +0000)]
Adjust DatumGetBool macro so that it isn't fooled by garbage in the Datum
to the left of the actual bool value. While in most cases there won't be
any, our support for old-style user-defined functions violates the C spec
to the extent of calling functions that might return char or short through
a function pointer declared to return "char *", which we then coerce to
Datum. It is not surprising that the result might contain garbage
high-order bits ... what is surprising is that we didn't see such cases
long ago. Per report from Magnus.
Tom Lane [Fri, 23 Mar 2007 19:53:52 +0000 (19:53 +0000)]
Fix plancache so that any required replanning is done with the same
search_path that was active when the plan was first made. To do this,
improve namespace.c to support a stack of "override" search path settings
(we must have a stack since nested replan events are entirely possible).
This facility replaces the "special namespace" hack formerly used by
CREATE SCHEMA, and should be able to support per-function search path
settings as well.
Magnus Hagander [Fri, 23 Mar 2007 08:30:55 +0000 (08:30 +0000)]
Remove headers for old sysv shmem emulation that I forgot.
Also remove headers for old sysv semaphore emulation that were forgotten
when that was changed about a year ago.
Bruce Momjian [Thu, 22 Mar 2007 20:55:19 +0000 (20:55 +0000)]
Add:
>
> * Fix cases where invalid byte encodings are accepted by the database,
> but throw an error on SELECT
>
> http://archives.postgresql.org/pgsql-hackers/2007-03/msg00767.php
Tom Lane [Thu, 22 Mar 2007 19:55:04 +0000 (19:55 +0000)]
Arrange for PreventTransactionChain to reject commands submitted as part
of a multi-statement simple-Query message. This bug goes all the way
back, but unfortunately is not nearly so easy to fix in existing releases;
it is only the recent ProcessUtility API change that makes it fixable in
HEAD. Per report from William Garrison.
Tom Lane [Thu, 22 Mar 2007 19:51:44 +0000 (19:51 +0000)]
Allow DROP TABLESPACE to succeed (with a warning) if the pg_tblspc symlink
doesn't exist. This allows DROP to be used to clean out the pg_tablespace
catalog entry in a situation where a previous DROP attempt failed before
committing but after having removed the directories and symlink.
Per report from William Garrison. Even though his test case depends on an
unrelated bug in PreventTransactionChain, it's certainly possible for this
situation to arise due to other problems, eg a system crash at just the
right time.
Alvaro Herrera [Thu, 22 Mar 2007 18:57:52 +0000 (18:57 +0000)]
Remove the currently unused FRONTEND case in dllist.c. This allows the usage
of palloc instead of malloc, which means a list can be freed simply by deleting
the memory context that contains it.
Tom Lane [Wed, 21 Mar 2007 22:18:12 +0000 (22:18 +0000)]
Fix some problems with selectivity estimation for partial indexes.
First, genericcostestimate() was being way too liberal about including
partial-index conditions in its selectivity estimate, resulting in
substantial underestimates for situations such as an indexqual "x = 42"
used with an index on x "WHERE x >= 40 AND x < 50". While the code is
intentionally set up to favor selecting partial indexes when available,
this was too much...
Second, choose_bitmap_and() was likewise easily fooled by cases of this
type, since it would similarly think that the partial index had selectivity
independent of the indexqual.
Fixed by using predicate_implied_by() rather than simple equality checks
to determine redundancy. This is a good deal more expensive but I don't
see much alternative. At least the extra cost is only paid when there's
actually a partial index under consideration.
Per report from Jeff Davis. I'm not going to risk back-patching this,
though.
Bruce Momjian [Wed, 21 Mar 2007 21:21:21 +0000 (21:21 +0000)]
Remove TODO item, not wanted:
< * Add NUMERIC division operator that doesn't round?
<
< Currently NUMERIC _rounds_ the result to the specified precision.
< This means division can return a result that multiplied by the
< divisor is greater than the dividend, e.g. this returns a value > 10:
<
< SELECT (10::numeric(2,0) / 6::numeric(2,0))::numeric(2,0) * 6;
<
< The positive modulus result returned by NUMERICs might be considered
< inaccurate, in one sense.
<
Bruce Momjian [Wed, 21 Mar 2007 00:33:08 +0000 (00:33 +0000)]
Add URL for:
* Allow accurate statistics to be collected on indexes with more than
one column or expression indexes, perhaps using per-index statistics
> http://archives.postgresql.org/pgsql-hackers/2007-03/msg01131.php
Neil Conway [Tue, 20 Mar 2007 05:45:00 +0000 (05:45 +0000)]
Add three new regexp functions: regexp_matches, regexp_split_to_array,
and regexp_split_to_table. These functions provide access to the
capture groups resulting from a POSIX regular expression match,
and provide the ability to split a string on a POSIX regular
expression, respectively. Patch from Jeremy Drake; code review by
Neil Conway, additional comments and suggestions from Tom and
Peter E.
This patch bumps the catversion, adds some regression tests,
and updates the docs.
Jan Wieck [Tue, 20 Mar 2007 03:53:26 +0000 (03:53 +0000)]
Bumping catversion due to changes to pg_trigger and pg_rewrite.
BTW, the comment in this file says that we hope we never have more than
10 catversion changes per day, but to even make this possible we should
start counting at zero, shouldn't we?
Jan Wieck [Mon, 19 Mar 2007 23:38:32 +0000 (23:38 +0000)]
Changes pg_trigger and extend pg_rewrite in order to allow triggers and
rules to be defined with different, per session controllable, behaviors
for replication purposes.
This will allow replication systems like Slony-I and, as has been stated
on pgsql-hackers, other products to control the firing mechanism of
triggers and rewrite rules without modifying the system catalog directly.
The firing mechanisms are controlled by a new superuser-only GUC
variable, session_replication_role, together with a change to
pg_trigger.tgenabled and a new column pg_rewrite.ev_enabled. Both
columns are a single char data type now (tgenabled was a bool before).
The possible values in these attributes are:
'O' - Trigger/Rule fires when session_replication_role is "origin"
(default) or "local". This is the default behavior.
'D' - Trigger/Rule is disabled and fires never
'A' - Trigger/Rule fires always regardless of the setting of
session_replication_role
'R' - Trigger/Rule fires when session_replication_role is "replica"
The GUC variable can only be changed as long as the system does not have
any cached query plans. This will prevent changing the session role and
accidentally executing stored procedures or functions that have plans
cached that expand to the wrong query set due to differences in the rule
firing semantics.
The SQL syntax for changing a triggers/rules firing semantics is
Tom Lane [Mon, 19 Mar 2007 16:44:41 +0000 (16:44 +0000)]
Further buildfarm experience shows that actually we can't run the plancache
test in parallel with the rules test at all, because the former wants to
create a couple of temp views, which can sometimes show up in the latter's
output. Let's try it in the next parallel group instead.
Tom Lane [Sun, 18 Mar 2007 17:57:34 +0000 (17:57 +0000)]
Fix ecpg/preproc makefile for parallel builds: parser.o must depend
on preproc.h, else make may try to build it before preproc.h is ready.
Per failures seen here and in buildfarm.
Michael Meskes [Sat, 17 Mar 2007 19:25:24 +0000 (19:25 +0000)]
- Changed some whitespacing in connect statement.
- Made some chars const as proposed by Stefan Huehner <stefan@huehner.org>.
- Synced parser and keyword lists.
- Copied two token parsing from backend parser to ecpg parser.
- Also added a test case for this.
Magnus Hagander [Sat, 17 Mar 2007 13:50:42 +0000 (13:50 +0000)]
Turn most vc build scripts into modules instead of scripts, and just have
skeleton scripts calling them. To make it easier for the buildfarm
(or other "outside callers") to use these modules directly.
Tom Lane [Sat, 17 Mar 2007 03:15:38 +0000 (03:15 +0000)]
SPI_cursor_open failed to enforce that only read-only queries could be
executed in read_only mode. This could lead to various relatively-subtle
failures, such as an allegedly stable function returning non-stable results.
Bug goes all the way back to the introduction of read-only mode in 8.0.
Per report from Gaetano Mendola.
Tom Lane [Sat, 17 Mar 2007 01:15:55 +0000 (01:15 +0000)]
Ooops, got only one of the two ArrayExpr variants correct in first
cut at exprTypmod support. Also, experimentation shows that we need
to label the type of Const nodes that are numeric with a specific
typmod.
Tom Lane [Sat, 17 Mar 2007 00:11:05 +0000 (00:11 +0000)]
Fix up the remaining places where the expression node structure would lose
available information about the typmod of an expression; namely, Const,
ArrayRef, ArrayExpr, and EXPR and ARRAY SubLinks. In the ArrayExpr and
SubLink cases it wasn't really the data structure's fault, but exprTypmod()
being lazy. This seems like a good idea in view of the expected increase in
typmod usage from Teodor's work to allow user-defined types to have typmods.
In particular this responds to the concerns we had about eliminating the
special-purpose hack that exprTypmod() used to have for BPCHAR Consts.
We can now tell whether or not such a Const has been cast to a specific
length, and report or display properly if so.
Tom Lane [Fri, 16 Mar 2007 16:11:49 +0000 (16:11 +0000)]
Fix race condition in parallel regression tests. The new plancache test
was expecting there to be no regular table named 'foo', but it turns out
the rules test transiently creates one, so that plancache would sometimes
fail. I couldn't reproduce that in quite a few tries here, but several
buildfarm machines have shown the failure. Fix by renaming plancache's
temp table to something nonconflicting.