Nick Lewycky [Sun, 22 Sep 2013 10:07:22 +0000 (10:07 +0000)]
Fix comment to match name of variable.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@191171
91177308-0d34-0410-b5e6-
96231b3b80d8
Nick Lewycky [Sun, 22 Sep 2013 10:06:57 +0000 (10:06 +0000)]
Simplify code to equivalent code. No need to test for null after cast<>, use
takeAs<> instead of cast<>(.take()). Fix 80-column violation in whitespace after
comment.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@191170
91177308-0d34-0410-b5e6-
96231b3b80d8
Nick Lewycky [Sun, 22 Sep 2013 10:06:01 +0000 (10:06 +0000)]
Fix typo. Add missing whitespace. No functionality change.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@191169
91177308-0d34-0410-b5e6-
96231b3b80d8
David Majnemer [Sun, 22 Sep 2013 03:30:01 +0000 (03:30 +0000)]
Parse: Move simple-type-specifier sanity check earlier
No functional change, just makes the error handling a bit more obvious.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@191162
91177308-0d34-0410-b5e6-
96231b3b80d8
David Majnemer [Sun, 22 Sep 2013 01:24:26 +0000 (01:24 +0000)]
Parse: Don't crash during parsing if we lack a simple-type-specifier
Summary:
Parsing cast expressions during error recovery can put us in a bad
state. Check to see if the token for a simple-type-specifier makes
sense before further parsing.
Fixes PR17255.
Reviewers: rsmith, doug.gregor, CornedBee, eli.friedman
CC: cfe-commits
Differential Revision: http://llvm-reviews.chandlerc.com/D1696
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@191159
91177308-0d34-0410-b5e6-
96231b3b80d8
Fariborz Jahanian [Sun, 22 Sep 2013 00:02:16 +0000 (00:02 +0000)]
ObjectiveC: ObjC declarations, including forward class
and protocols can be at global scope only.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@191155
91177308-0d34-0410-b5e6-
96231b3b80d8
Richard Smith [Sat, 21 Sep 2013 21:55:46 +0000 (21:55 +0000)]
PR17295: Do not allow explicit conversion functions to be used in cases where
an additional conversion (other than a qualification conversion) would be
required after the explicit conversion.
Conversely, do allow explicit conversion functions to be used when initializing
a temporary for a reference binding in direct-list-initialization.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@191150
91177308-0d34-0410-b5e6-
96231b3b80d8
Richard Smith [Sat, 21 Sep 2013 21:23:47 +0000 (21:23 +0000)]
Some comment updates and tweaks for clarity.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@191147
91177308-0d34-0410-b5e6-
96231b3b80d8
Richard Smith [Sat, 21 Sep 2013 21:19:19 +0000 (21:19 +0000)]
Rearrange narrowing checks in initialization to be a different form of step
rather than a post-processing action, so we can support inserting these checks
at stages other than the end of the initialization. No functionality change
intended.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@191146
91177308-0d34-0410-b5e6-
96231b3b80d8
Daniel Jasper [Sat, 21 Sep 2013 17:31:51 +0000 (17:31 +0000)]
clang-format: Improve address-of-operator detection
Before:
size = sizeof * a;
After:
size = sizeof *a;
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@191139
91177308-0d34-0410-b5e6-
96231b3b80d8
Daniel Jasper [Sat, 21 Sep 2013 10:05:02 +0000 (10:05 +0000)]
Fix clang-format-diff.py to accept -style again.
Copy and paste error in r190935..
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@191137
91177308-0d34-0410-b5e6-
96231b3b80d8
Petar Jovanovic [Sat, 21 Sep 2013 01:27:01 +0000 (01:27 +0000)]
[Mips] Allocate NaClTargetInfo for MIPSEL NaCl
A patch to AllocateTarget function to recognize llvm::Triple::NaCl for
MIPSEL and return NaClTargetInfo. Additional test has been added to check
if the expected macros get defined.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@191124
91177308-0d34-0410-b5e6-
96231b3b80d8
Eli Friedman [Sat, 21 Sep 2013 00:05:25 +0000 (00:05 +0000)]
Fix return type of _mm_extract_epi8 etc.
PR17300.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@191120
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Fri, 20 Sep 2013 21:12:25 +0000 (21:12 +0000)]
Switch tests in test/Headers to use %clang_cc1 rather than %clang. There
is no need to go through the driver indirection here, and it clutters
things up as dependencies can sneak in for specific things the driver is
doing.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@191107
91177308-0d34-0410-b5e6-
96231b3b80d8
Richard Smith [Fri, 20 Sep 2013 20:10:22 +0000 (20:10 +0000)]
Refactor: CheckExplicitInitList is only called to check an entire InitListExpr,
so the Index in/out parameters are pointless (always passed in as 0, always
ignored by the caller).
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@191103
91177308-0d34-0410-b5e6-
96231b3b80d8
Hans Wennborg [Fri, 20 Sep 2013 18:16:35 +0000 (18:16 +0000)]
clang-cl: implement custom search for cl.exe in /fallback mode
This solves the problem of fallback onto ourselves if clang-cl
has been renamed to cl.exe and put on the PATH, as happens with
the VS integration.
Differential Revision: http://llvm-reviews.chandlerc.com/D1731
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@191099
91177308-0d34-0410-b5e6-
96231b3b80d8
Reid Kleckner [Fri, 20 Sep 2013 18:01:52 +0000 (18:01 +0000)]
Update -fmsc-version docs for r190908, which set the default to 1700
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@191098
91177308-0d34-0410-b5e6-
96231b3b80d8
Reid Kleckner [Fri, 20 Sep 2013 17:54:39 +0000 (17:54 +0000)]
Fix ReST links I just added to the manual
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@191097
91177308-0d34-0410-b5e6-
96231b3b80d8
Reid Kleckner [Fri, 20 Sep 2013 17:51:00 +0000 (17:51 +0000)]
Clarify that we silently ignore some MS extensions like IDL attributes
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@191096
91177308-0d34-0410-b5e6-
96231b3b80d8
Reid Kleckner [Fri, 20 Sep 2013 17:04:25 +0000 (17:04 +0000)]
Use -fms-compatibility to trigger lookup into dep. bases
Update the docs for -fms-extensions and -fms-compatibility to try to
clarify the difference between the two.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@191095
91177308-0d34-0410-b5e6-
96231b3b80d8
Jordan Rose [Fri, 20 Sep 2013 16:51:50 +0000 (16:51 +0000)]
[analyzer] Use getParentIgnoreParenCasts instead of doing it by hand.
Apart from being more compact and already implemented, this also handles the
case where the parent is null. (It does also ignore all casts, not just
implicit ones, but this is more efficient to test and in the case we care
about---a message in a PseudoObjectExpr---there should only be implicit casts
anyway.
This should fix our internal buildbot.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@191094
91177308-0d34-0410-b5e6-
96231b3b80d8
Alexander Potapenko [Fri, 20 Sep 2013 08:23:19 +0000 (08:23 +0000)]
[ASan] Fix darwin-sanitizer-ld.c to test for the new order of linker flags introduced by r191076.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@191077
91177308-0d34-0410-b5e6-
96231b3b80d8
Alexander Potapenko [Fri, 20 Sep 2013 08:09:51 +0000 (08:09 +0000)]
[ASan] Do not imply -undefined dynamic_lookup when linking dylibs with -fsanitize=address.
Instead add the ASan runtime to the linker command line so that only the ASan API functions can be undefined in the target library.
Fixes http://llvm.org/bugs/show_bug.cgi?id=17275
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@191076
91177308-0d34-0410-b5e6-
96231b3b80d8
Richard Trieu [Fri, 20 Sep 2013 03:03:06 +0000 (03:03 +0000)]
Modify the uninitialized field visitor to detect uninitialized use across the
fields in the class. This allows a better checking of member intiailizers and
in class initializers in regards to initialization ordering.
For instance, this code will now produce warnings:
class A {
int x;
int y;
A() : x(y) {} // y is initialized after x, warn here
A(int): y(x) {} // default initialization of leaves x uninitialized, warn here
};
Several test cases were updated with -Wno-uninitialized to silence this warning.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@191068
91177308-0d34-0410-b5e6-
96231b3b80d8
Richard Smith [Fri, 20 Sep 2013 02:48:08 +0000 (02:48 +0000)]
Testcase I forgot to svn add in r191057.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@191067
91177308-0d34-0410-b5e6-
96231b3b80d8
Richard Smith [Fri, 20 Sep 2013 01:15:31 +0000 (01:15 +0000)]
Switch the semantic DeclContext for a block-scope declaration of a function or
variable from being the function to being the enclosing namespace scope (in
C++) or the TU (in C). This allows us to fix a selection of related issues
where we would build incorrect redeclaration chains for such declarations, and
fail to notice type mismatches.
Such declarations are put into a new IdentifierNamespace, IDNS_LocalExtern,
which is only found when searching scopes, and not found when searching
DeclContexts. Such a declaration is only made visible in its DeclContext if
there are no non-LocalExtern declarations.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@191064
91177308-0d34-0410-b5e6-
96231b3b80d8
Richard Smith [Fri, 20 Sep 2013 00:27:40 +0000 (00:27 +0000)]
PR17290: Use 'false' macro in fix-it hint for initializing a variable of type
_Bool in C, if the macro is defined. Also teach FixItUtils to look at whether
the macro was defined at the source location for which it is creating a fixit,
rather than looking at whether it's defined *now*. This is especially relevant
for analysis-based warnings which are delayed until end of TU.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@191057
91177308-0d34-0410-b5e6-
96231b3b80d8
Kaelyn Uhrain [Thu, 19 Sep 2013 22:38:48 +0000 (22:38 +0000)]
Don't correct typos in Sema::BuildCXXNestedNameSpecifier with -fms-extensions
When -fms-extensions is enabled, the typo correction was being called here on
non-error paths (as in test/SemaTemplate/lookup-dependent-bases.cpp) and correct
compilation depended on Sema::CorrectTypo not finding a viable candidate.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@191046
91177308-0d34-0410-b5e6-
96231b3b80d8
Hans Wennborg [Thu, 19 Sep 2013 20:32:16 +0000 (20:32 +0000)]
clang-cl: implement /fallback mode
When this flag is enabled, clang-cl falls back to cl.exe if it
cannot compile the code itself for some reason.
The idea is to use this to help build projects that almost compile
with clang-cl, except for some files that can then be built with
the fallback mechanism.
Differential Revision: http://llvm-reviews.chandlerc.com/D1711
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@191034
91177308-0d34-0410-b5e6-
96231b3b80d8
Fariborz Jahanian [Thu, 19 Sep 2013 17:52:50 +0000 (17:52 +0000)]
Fixes a buildbot failure (was using local
type in template instantiation).
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@191022
91177308-0d34-0410-b5e6-
96231b3b80d8
Fariborz Jahanian [Thu, 19 Sep 2013 17:18:55 +0000 (17:18 +0000)]
Refinement to my previous patch for
objc_returns_inner_pointer on properties. // rdar://
14990439
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@191016
91177308-0d34-0410-b5e6-
96231b3b80d8
Reid Kleckner [Thu, 19 Sep 2013 17:00:54 +0000 (17:00 +0000)]
clang-cl: Accept -fmsc-version so we can set it without -Xclang
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@191011
91177308-0d34-0410-b5e6-
96231b3b80d8
Fariborz Jahanian [Thu, 19 Sep 2013 16:37:20 +0000 (16:37 +0000)]
ObjectiveC: Allow NS_RETURNS_INNER_POINTER annotation
of ObjectiveC properties to mean annotation of
NS_RETURNS_INNER_POINTER on its synthesized getter.
This also facilitates more migration to properties when
methods are annotated with NS_RETURNS_INNER_POINTER.
// rdar://
14990439
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@191009
91177308-0d34-0410-b5e6-
96231b3b80d8
Ben Langmuir [Thu, 19 Sep 2013 14:07:14 +0000 (14:07 +0000)]
Fix ifdef macro missed in previous commit
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@191003
91177308-0d34-0410-b5e6-
96231b3b80d8
Ben Langmuir [Thu, 19 Sep 2013 14:00:22 +0000 (14:00 +0000)]
Move sha intrinsics to immintrin.h
This is consistent with ICC and Intel's SHA-enabled GCC version.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@191002
91177308-0d34-0410-b5e6-
96231b3b80d8
Amara Emerson [Thu, 19 Sep 2013 13:54:03 +0000 (13:54 +0000)]
[ARMv8] Add crypto-neon-fp-armv8 -mfpu option in driver.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@191001
91177308-0d34-0410-b5e6-
96231b3b80d8
Ben Langmuir [Thu, 19 Sep 2013 13:22:04 +0000 (13:22 +0000)]
Add C intrinsics for Intel SHA Extensions
Intrinsics added shaintrin.h, which is included from x86intrin.h if __SHA__ is
enabled. SHA implies SSE2, which is needed for the __m128i type.
Also add the -msha/-mno-sha option.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190999
91177308-0d34-0410-b5e6-
96231b3b80d8
Reid Kleckner [Thu, 19 Sep 2013 01:54:40 +0000 (01:54 +0000)]
Use -ffreestanding in ms-intrin.cpp and define size_t manually.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190985
91177308-0d34-0410-b5e6-
96231b3b80d8
Eli Friedman [Thu, 19 Sep 2013 01:51:23 +0000 (01:51 +0000)]
Fix use-after-free in r190980.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190984
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Thu, 19 Sep 2013 01:13:07 +0000 (01:13 +0000)]
Use curly braces all the way through long if/else chain for consistency and readability.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190982
91177308-0d34-0410-b5e6-
96231b3b80d8
Eli Friedman [Thu, 19 Sep 2013 01:12:33 +0000 (01:12 +0000)]
Fix crash with cast of value-dependent expr.
We don't really need to perform semantic analysis on the dependent expression
anyway, so just call the cast dependent.
<rdar://problem/
15012610>
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190981
91177308-0d34-0410-b5e6-
96231b3b80d8
Eli Friedman [Thu, 19 Sep 2013 00:41:32 +0000 (00:41 +0000)]
Make Preprocessor::Lex non-recursive.
Before this patch, Lex() would recurse whenever the current lexer changed (e.g.
upon entry into a macro). This patch turns the recursion into a loop: the
various lex routines now don't return a token when the current lexer changes,
and at the top level Preprocessor::Lex() now loops until it finds a token.
Normally, the recursion wouldn't end up being very deep, but the recursion depth
can explode in edge cases like a bunch of consecutive macros which expand to
nothing (like in the testcase test/Preprocessor/macro_expand_empty.c in this
patch).
<rdar://problem/
14569770>
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190980
91177308-0d34-0410-b5e6-
96231b3b80d8
Reid Kleckner [Thu, 19 Sep 2013 00:32:11 +0000 (00:32 +0000)]
Avoid including <stdlib.h> in the intrin.h test
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190979
91177308-0d34-0410-b5e6-
96231b3b80d8
Reid Kleckner [Thu, 19 Sep 2013 00:19:53 +0000 (00:19 +0000)]
Fix ifdef ordering at the end of Intrin.h from r190965
Test that intrin.h at least parses in C++ TUs.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190978
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Thu, 19 Sep 2013 00:01:05 +0000 (00:01 +0000)]
Disabling sse2 should disable aes and pclmul support.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190977
91177308-0d34-0410-b5e6-
96231b3b80d8
Eli Friedman [Wed, 18 Sep 2013 23:23:17 +0000 (23:23 +0000)]
Add specific warning flags for GNU ext in Sema.
This patch adds the following, more specific warning flags:
gnu-anonymous-struct
gnu-compound-literal-initializer
gnu-empty-struct
gnu-flexible-array-initializer
gnu-flexible-array-union-member
gnu-folding-constant
redeclared-class-member
gnu-redeclared-enum
gnu-union-cast
gnu-variable-sized-type-not-at-end
Patch by Peter Lewis.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190972
91177308-0d34-0410-b5e6-
96231b3b80d8
Eli Friedman [Wed, 18 Sep 2013 23:23:13 +0000 (23:23 +0000)]
Fix CharByteWidth assertion in LiteralSupport.
Patch by Eelis van der Weegen.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190971
91177308-0d34-0410-b5e6-
96231b3b80d8
Richard Smith [Wed, 18 Sep 2013 23:09:24 +0000 (23:09 +0000)]
Remove a bogus diagnostic preventing static data member templates from being
defined with no initializer.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190970
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Wed, 18 Sep 2013 22:40:18 +0000 (22:40 +0000)]
Fix closing brace around ifdef.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190965
91177308-0d34-0410-b5e6-
96231b3b80d8
Hans Wennborg [Wed, 18 Sep 2013 22:26:39 +0000 (22:26 +0000)]
clang-cl: Don't warn about overriding /MD with /MT, /Fo with another /Fo, etc.
I put in the warnings because MSVC has them, but I don't think they're very
useful.
Clang does not warn about overriding flags in general, e.g. it's perfectly
fine to have -fomit-frame-pointer followed by -fno-omit-frame-pointer.
We should focus on warning where things get confusing, such as with the
/TP and /TC options. In "clang-cl /TC a.c /TP b.cc", the user might not
realize that the /TP flag will apply to both files, and we warn about that.
Differential Revision: http://llvm-reviews.chandlerc.com/D1718
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190964
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Wed, 18 Sep 2013 22:24:01 +0000 (22:24 +0000)]
The intrinsics should all have C linkage.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190963
91177308-0d34-0410-b5e6-
96231b3b80d8
Adrian Prantl [Wed, 18 Sep 2013 22:18:17 +0000 (22:18 +0000)]
get rid of extra parentheses.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190962
91177308-0d34-0410-b5e6-
96231b3b80d8
Adrian Prantl [Wed, 18 Sep 2013 22:08:57 +0000 (22:08 +0000)]
Debug info: Explicitly set the DIVariable::isIndirect() flag for VLAs.
This allows us to get rid of an ugly hack in the backend.
Paired commit with LLVM.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190960
91177308-0d34-0410-b5e6-
96231b3b80d8
Richard Smith [Wed, 18 Sep 2013 21:55:14 +0000 (21:55 +0000)]
Remove some dead code.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190959
91177308-0d34-0410-b5e6-
96231b3b80d8
Fariborz Jahanian [Wed, 18 Sep 2013 20:35:47 +0000 (20:35 +0000)]
ObjectiveC migrator: For consistency, also infer
'instancetype' for known family of methods
with related result type; such as 'init'
methods. // rdar://
14987948
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190956
91177308-0d34-0410-b5e6-
96231b3b80d8
Jordan Rose [Wed, 18 Sep 2013 18:58:58 +0000 (18:58 +0000)]
[analyzer] Don't even try to convert floats to booleans for now.
We now have symbols with floating-point type to make sure that
(double)x == (double)x comes out true, but we still can't do much with
these. For now, don't even bother trying to create a floating-point zero
value; just give up on conversion to bool.
PR14634, C++ edition.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190953
91177308-0d34-0410-b5e6-
96231b3b80d8
Fariborz Jahanian [Wed, 18 Sep 2013 17:22:25 +0000 (17:22 +0000)]
ObjectiveC migrator: Infer property in the presense
of methods annotated with attributes.
// rdar://
14987909
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190947
91177308-0d34-0410-b5e6-
96231b3b80d8
Fariborz Jahanian [Wed, 18 Sep 2013 15:43:52 +0000 (15:43 +0000)]
ObjectiveC migrator: placing another check for
'deprecated' container before doing the 'instancetype'
inference.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190943
91177308-0d34-0410-b5e6-
96231b3b80d8
Daniel Jasper [Wed, 18 Sep 2013 12:14:09 +0000 (12:14 +0000)]
Simplify clang-format-diff.py using new clang-format options.
clang-format's -lines parameter makes this significantly easier.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190935
91177308-0d34-0410-b5e6-
96231b3b80d8
Joey Gouly [Wed, 18 Sep 2013 10:07:09 +0000 (10:07 +0000)]
[ARMv8] Add builtins for CRC instructions.
Patch by Bradley Smith!
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190931
91177308-0d34-0410-b5e6-
96231b3b80d8
Stepan Dyatkovskiy [Wed, 18 Sep 2013 09:08:52 +0000 (09:08 +0000)]
Recommited:
Fix for PR16752. Second commit.
PR16752: 'mode' attribute for unusual targets doesn't work properly
Description:
Troubles could be happened due to some assumptions in handleModeAttr function (see SemaDeclAttr.cpp).
For example, it assumes that 32 bit integer is 'int', while it could be 16 bit only.
Instead of asking target: 'which type do you want to use for int32_t ?' it just hardcodes general opinion. That doesn't looks pretty correct.
Please consider the next solution:
1. In Basic/TargetInfo add getIntTypeByWidth and getRealTypeByWidth methods. Methods asks target for proper type for given bit width.
2. Fix handleModeAttr according to new methods in TargetInfo.
Fixes:
1st Commit (Done): Add new methods for TargetInfo:
getRealTypeByWidth and getIntTypeByWidth
for ASTContext names are almost same(invokes new methods from TargetInfo):
getIntTypeForBitwidth and getRealTypeForBitwidth
2nd Commit (Current): Fix SemaDeclAttr, handleModeAttr function.
Also test/Sema/attr-mode.c was fixed. 'XC' mode test was disabled for PPC64 machines.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190926
91177308-0d34-0410-b5e6-
96231b3b80d8
Amaury de la Vieuville [Wed, 18 Sep 2013 08:33:53 +0000 (08:33 +0000)]
Add support for poly16 vtst and vtstq
vtst and vtstq currently support poly8 types, but they should also work on
poly16.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190925
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Wed, 18 Sep 2013 06:19:40 +0000 (06:19 +0000)]
Add new libm LIBBUILTIN definitions, synchronizing with __builtin_*
For all libm __builtin_* functions that are defined, this adds the
corresponding LIBBUILTIN definitions (tagged, as necessary, with "e" instead of
"c" when the function may set errno).
Note that this changes the current definitions for lrint and fma
(unfortunately). The Linux man page documents that these don't set errno, but
the POSIX standard says that they should.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190922
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Wed, 18 Sep 2013 03:29:45 +0000 (03:29 +0000)]
Add the intrinsic __builtin_convertvector
LLVM supports applying conversion instructions to vectors of the same number of
elements (fptrunc, fptosi, etc.) but there had been no way for a Clang user to
cause such instructions to be generated when using builtin vector types.
C-style casting on vectors is already defined in terms of bitcasts, and so
cannot be used for these conversions as well (without leading to a very
confusing set of semantics). As a result, this adds a __builtin_convertvector
intrinsic (patterned after the OpenCL __builtin_astype intrinsic). This is
intended to aid the creation of vector intrinsic headers that create generic IR
instead of target-dependent intrinsics (in other words, this is a generic
_mm_cvtepi32_ps). As noted in the documentation, the action of
__builtin_convertvector is defined in terms of the action of a C-style cast on
each vector element.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190915
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Wed, 18 Sep 2013 03:29:09 +0000 (03:29 +0000)]
Remove unnecessary comment regarding AsTypeExpr base class
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190914
91177308-0d34-0410-b5e6-
96231b3b80d8
Richard Smith [Wed, 18 Sep 2013 02:10:12 +0000 (02:10 +0000)]
Fix accepts-invalid if a variable template explicit instantiation is missing an
argument list, but could be instantiated with argument list of <>.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190913
91177308-0d34-0410-b5e6-
96231b3b80d8
Eli Friedman [Wed, 18 Sep 2013 01:59:16 +0000 (01:59 +0000)]
Fix ObjC @encode for C++ classes w/virtual bases.
PR17142.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190912
91177308-0d34-0410-b5e6-
96231b3b80d8
Richard Smith [Wed, 18 Sep 2013 01:36:02 +0000 (01:36 +0000)]
-ast-dump support for variable templates.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190911
91177308-0d34-0410-b5e6-
96231b3b80d8
Richard Smith [Wed, 18 Sep 2013 01:35:26 +0000 (01:35 +0000)]
If a variable template specialization with an incomplete array type is
referenced, try to instantiate its definition in order to complete the type.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190910
91177308-0d34-0410-b5e6-
96231b3b80d8
Hans Wennborg [Wed, 18 Sep 2013 00:41:15 +0000 (00:41 +0000)]
Add comment about exporting clang::driver::ArgStringList,
as suggested by Jordan on IRC. Also, use the unqualified name
in Job.cpp.
And while we're here, refer to StringRef with the unqualified
name, because we have a using directive for that too.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190909
91177308-0d34-0410-b5e6-
96231b3b80d8
Reid Kleckner [Wed, 18 Sep 2013 00:33:59 +0000 (00:33 +0000)]
Claim compatibility with VS 2012 by default
This will define _MSC_VER to 1700 by default and avoid linker errors
from /failifmismatch linker directives in the C++ standard headers.
Most people trying out the Visual Studio integration are using 2012,
since that's the only version that clang-format works with. This way
they don't have to pass funky -Xclang -fmsc-version=1700 flags just to
link against the standard C++ runtime.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190908
91177308-0d34-0410-b5e6-
96231b3b80d8
Hans Wennborg [Wed, 18 Sep 2013 00:21:51 +0000 (00:21 +0000)]
Revert r190902 and r190906
The first one broke the build, and the latter one made it worse.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190907
91177308-0d34-0410-b5e6-
96231b3b80d8
Hans Wennborg [Wed, 18 Sep 2013 00:17:07 +0000 (00:17 +0000)]
Revert "Move using directive from Job.h to Job.cpp" (r190902)
Seems like it was intentional to export ArgStringList as
driver::ArgStringList, and e.g. examples/clang-interpreter/main.cpp
uses it this way.
However, exporting it with a typedef seems like a more common way to do it.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190906
91177308-0d34-0410-b5e6-
96231b3b80d8
David Majnemer [Tue, 17 Sep 2013 23:57:10 +0000 (23:57 +0000)]
Revert "Revert "[-cxx-abi microsoft] Mangle local TagDecls appropriately""
This reverts commit r190895 which reverted r190892.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190904
91177308-0d34-0410-b5e6-
96231b3b80d8
Hans Wennborg [Tue, 17 Sep 2013 23:37:44 +0000 (23:37 +0000)]
Move using directive from Job.h to Job.cpp
I don't think it belongs in the header, but seems handy in the .cpp file.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190902
91177308-0d34-0410-b5e6-
96231b3b80d8
Fariborz Jahanian [Tue, 17 Sep 2013 23:32:51 +0000 (23:32 +0000)]
ObjectiveC migrator. infer NS_OPTIONS correctly in the
presense of parenthesized enumerator initializers.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190901
91177308-0d34-0410-b5e6-
96231b3b80d8
Hans Wennborg [Tue, 17 Sep 2013 23:27:39 +0000 (23:27 +0000)]
clang-cl: ignore ths /GS- flag
The /GS- flag is used to turn off run-time buffer security checks (/GS).
Since no such checks are enabled in the first place, I think we should just
ignore this flag.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190900
91177308-0d34-0410-b5e6-
96231b3b80d8
David Majnemer [Tue, 17 Sep 2013 22:45:28 +0000 (22:45 +0000)]
Revert "[-cxx-abi microsoft] Mangle local TagDecls appropriately"
This reverts commit r190892.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190895
91177308-0d34-0410-b5e6-
96231b3b80d8
Fariborz Jahanian [Tue, 17 Sep 2013 22:41:25 +0000 (22:41 +0000)]
ObjectiveC migrator: Don't infer property from
'deprected' setters either. // rdar://
14989365
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190894
91177308-0d34-0410-b5e6-
96231b3b80d8
David Majnemer [Tue, 17 Sep 2013 22:21:27 +0000 (22:21 +0000)]
[-cxx-abi microsoft] Mangle local TagDecls appropriately
Summary:
When selecting a mangling for an anonymous tag type:
- We should first try it's typedef'd name.
- If that doesn't work, we should mangle in the name of the declarator
that specified it as a declaration specifier.
- If that doesn't work, fall back to a static mangling of
<unnamed-type>.
This should make our anonymous type mangling compatible.
This partially fixes PR16994; we would need to have an implementation of
scope numbering to get it right (a separate issue).
Reviewers: rnk, rsmith, rjmccall, cdavis5x
CC: cfe-commits
Differential Revision: http://llvm-reviews.chandlerc.com/D1540
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190892
91177308-0d34-0410-b5e6-
96231b3b80d8
Fariborz Jahanian [Tue, 17 Sep 2013 21:56:04 +0000 (21:56 +0000)]
ObjectiveC migrator. Ignore migrating 'deprecated'
entities. // rdar://
14989365
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190890
91177308-0d34-0410-b5e6-
96231b3b80d8
Fariborz Jahanian [Tue, 17 Sep 2013 19:38:55 +0000 (19:38 +0000)]
ObjectiveC migrator: Don't infer a property from isXXX method
of retainable object (readonly or otherwise).
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190881
91177308-0d34-0410-b5e6-
96231b3b80d8
Argyrios Kyrtzidis [Tue, 17 Sep 2013 19:14:29 +0000 (19:14 +0000)]
[arcmt] Don't try to handle files that are already ARC'ified, this is not possible currently.
rdar://
14461559
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190880
91177308-0d34-0410-b5e6-
96231b3b80d8
Fariborz Jahanian [Tue, 17 Sep 2013 19:00:30 +0000 (19:00 +0000)]
ObjectiveC migrator. Infer property in categories
declared as getter with or without setter method.
// rdar://
15010020
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190878
91177308-0d34-0410-b5e6-
96231b3b80d8
Fariborz Jahanian [Tue, 17 Sep 2013 17:51:48 +0000 (17:51 +0000)]
ObjectiveC modern translator: Provide proper cast of
the ObjectiveC object of an @synchronized statement.
// rdar://
14993814
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190874
91177308-0d34-0410-b5e6-
96231b3b80d8
Daniel Jasper [Tue, 17 Sep 2013 09:52:48 +0000 (09:52 +0000)]
clang-format: Don't accidentally move tokens into preprocessor directive.
This fixes llvm.org/PR17265.
Before:
Foo::Foo()
#ifdef BAR
: baz(0)
#endif {
}
After:
Foo::Foo()
#ifdef BAR
: baz(0)
#endif
{
}
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190861
91177308-0d34-0410-b5e6-
96231b3b80d8
Daniel Jasper [Tue, 17 Sep 2013 09:26:07 +0000 (09:26 +0000)]
clang-format: Add comment to tests explaining their grouping.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190858
91177308-0d34-0410-b5e6-
96231b3b80d8
Daniel Jasper [Tue, 17 Sep 2013 08:28:05 +0000 (08:28 +0000)]
clang-format: Fix line breaking bug after empty ifs.
Before:
if () {
}
else {
}
After:
if () {
} else {
}
This fixed llvm.org/PR17262.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190855
91177308-0d34-0410-b5e6-
96231b3b80d8
Daniel Jasper [Tue, 17 Sep 2013 08:15:46 +0000 (08:15 +0000)]
clang-format: Don't split a >>-operator.
Before (with column limit 60):
aaaaaaaaaaaaaaaaaaaaaaaaaaaa(
aaaaaaaaaaaaaaaaaaaaaaaaaaaaa >
> aaaaa);
After:
aaaaaaaaaaaaaaaaaaaaaaaaaaaa(
aaaaaaaaaaaaaaaaaaaaaaaaaaaaa >> aaaaa);
(Not sure how that could have stayed in that long without being
detected..)
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190854
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Tue, 17 Sep 2013 04:51:29 +0000 (04:51 +0000)]
Push contents of X86TargetInfo::setFeatureEnabled down to a static function called by the virtual version and all the places in getDefaultFeatures. This way getDefaultFeatures doesn't make so many virtual calls.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190847
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Tue, 17 Sep 2013 04:12:55 +0000 (04:12 +0000)]
Mark setSSELevel/setMMXLevel/setXOPLevel as static since they don't access anything in the class.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190846
91177308-0d34-0410-b5e6-
96231b3b80d8
Eli Friedman [Tue, 17 Sep 2013 04:07:04 +0000 (04:07 +0000)]
Don't build extra init lists.
AssignConvertType::IncompatibleVectors means the two types are in fact
compatible. :)
No testcase; I don't think the extra init list has any actual visible effect
other than making the resulting AST dump look a bit strange.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190845
91177308-0d34-0410-b5e6-
96231b3b80d8
Eli Friedman [Tue, 17 Sep 2013 04:07:02 +0000 (04:07 +0000)]
Fix const-eval of vector init-lists of a vector.
Like any other type, an init list for a vector can have the same type as
the vector itself; handle that case.
<rdar://problem/
14990460>
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190844
91177308-0d34-0410-b5e6-
96231b3b80d8
Anna Zaks [Tue, 17 Sep 2013 01:30:57 +0000 (01:30 +0000)]
[analyzer] More reliably detect property accessors.
This has a side effect of preventing a crash, which occurs because we get a
property getter declaration, which is overriding but is declared inside
@protocol. Will file a bug about this inconsistency internally. Getting a
small test case is very challenging.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190836
91177308-0d34-0410-b5e6-
96231b3b80d8
Anna Zaks [Tue, 17 Sep 2013 00:53:28 +0000 (00:53 +0000)]
[analyzer] Stop tracking the objects with attribute cleanup in the RetainCountChecker.
This suppresses false positive leaks. We stop tracking a value if it is assigned to a variable declared with a cleanup attribute.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190835
91177308-0d34-0410-b5e6-
96231b3b80d8
Eli Friedman [Tue, 17 Sep 2013 00:51:31 +0000 (00:51 +0000)]
Address review comment on r189557.
We need to escape filenames the same way in InclusionRewriter whether
UseLineDirective is true or false.
Review comment from http://llvm.org/bugs/show_bug.cgi?id=17018#c2
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190834
91177308-0d34-0410-b5e6-
96231b3b80d8
Eli Friedman [Tue, 17 Sep 2013 00:51:29 +0000 (00:51 +0000)]
Fix potential race in module building code.
Let the module building code handle the case of overwriting an existing file
itself, so the existing locking infrastructure works correctly.
<rdar://problem/
14403381>
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190833
91177308-0d34-0410-b5e6-
96231b3b80d8
Hans Wennborg [Tue, 17 Sep 2013 00:50:43 +0000 (00:50 +0000)]
cl-options.c just use touch to create that .obj file
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190832
91177308-0d34-0410-b5e6-
96231b3b80d8
Hans Wennborg [Tue, 17 Sep 2013 00:25:08 +0000 (00:25 +0000)]
Fix test/Driver/cl-options.c test
The test builds an object file to be able to get into linking mode
with a valid obj file on the command-line. Using clang-cl for this,
which targets win32, caused problems on some buildbots, so just
use regular clang.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190829
91177308-0d34-0410-b5e6-
96231b3b80d8
Hans Wennborg [Tue, 17 Sep 2013 00:03:41 +0000 (00:03 +0000)]
clang-cl: ignore compile-only options in link-only invocations.
Previously we would warn about unused arguments such as /MD when linking.
Clang already has logic to ignore compile-only options, e.g. for -D and -U.
This patch extends that to include clang-cl's compile-only options too.
Also, some clang-cl options should always be ignored. Doing this earlier
means they get ignored both for compilation and link-only invocations.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190825
91177308-0d34-0410-b5e6-
96231b3b80d8