]> granicus.if.org Git - graphviz/log
graphviz
2 years agogdiplus plugin: remove MS Visual Studio 8 patches
Matthew Fernandez [Sun, 27 Mar 2022 22:20:58 +0000 (15:20 -0700)]
gdiplus plugin: remove MS Visual Studio 8 patches

These patches appear to have been working around some non-portable code in the
headers shipped with Microsoft Visual Studio 8 (a.k.a. Microsoft Visual Studio
2005). This version of Visual Studio was EOLed on 2016-04-12. Neither the CMake
nor MS Build build systems (the only CI environments for which compilation of
this plugin is enabled) were using these patches. So apparently they have not
been useful for a long time.

2 years agoMerge branch 'smattr/17FC7676-22B2-48E6-9D6F-0BC12096581A' into 'main'
Matthew Fernandez [Tue, 29 Mar 2022 03:08:43 +0000 (03:08 +0000)]
Merge branch 'smattr/17FC7676-22B2-48E6-9D6F-0BC12096581A' into 'main'

remove unused Smyrna icons

See merge request graphviz/graphviz!2537

2 years agoshare/gui: remove duplicate 'zoom.png'
Matthew Fernandez [Wed, 23 Mar 2022 02:42:42 +0000 (19:42 -0700)]
share/gui: remove duplicate 'zoom.png'

2 years agoshare/gui: remove duplicate 'move.png'
Matthew Fernandez [Wed, 23 Mar 2022 02:41:55 +0000 (19:41 -0700)]
share/gui: remove duplicate 'move.png'

2 years agoremove 'rect_select*.png' Smyrna icons
Matthew Fernandez [Wed, 23 Mar 2022 02:32:14 +0000 (19:32 -0700)]
remove 'rect_select*.png' Smyrna icons

These appear to have never been used.

2 years agoremove 'preview.png' Smyrna icon
Matthew Fernandez [Wed, 23 Mar 2022 02:29:14 +0000 (19:29 -0700)]
remove 'preview.png' Smyrna icon

This appears to have never been used.

2 years agoshare/gui: remove duplicate pan.png
Matthew Fernandez [Wed, 23 Mar 2022 02:27:31 +0000 (19:27 -0700)]
share/gui: remove duplicate pan.png

2 years agoremove 'node.png' Smyrna icon
Matthew Fernandez [Wed, 23 Mar 2022 02:27:04 +0000 (19:27 -0700)]
remove 'node.png' Smyrna icon

This seems to have never been used.

2 years agoremove 'fit.png' Smyrna icon
Matthew Fernandez [Wed, 23 Mar 2022 02:22:51 +0000 (19:22 -0700)]
remove 'fit.png' Smyrna icon

The last use of this was removed in 68ba63a7c72e61bc0b2f12db9041f4dde4ab47cf.

2 years agoremove 'fish.PNG' Smyrna icon
Matthew Fernandez [Wed, 23 Mar 2022 02:19:43 +0000 (19:19 -0700)]
remove 'fish.PNG' Smyrna icon

This seems to have never been used.

2 years agoremove 'edge.png' Smyrna icon
Matthew Fernandez [Wed, 23 Mar 2022 02:18:19 +0000 (19:18 -0700)]
remove 'edge.png' Smyrna icon

This seems to have never been used.

2 years agoremove 'ltwopi.png' Smyrna icon
Matthew Fernandez [Wed, 23 Mar 2022 02:15:06 +0000 (19:15 -0700)]
remove 'ltwopi.png' Smyrna icon

The last use of this was removed in 89ba8c1507b84cef5bc892322ee767ed048101f4.

2 years agoremove 'lneato.png' Smyrna icon
Matthew Fernandez [Wed, 23 Mar 2022 02:13:43 +0000 (19:13 -0700)]
remove 'lneato.png' Smyrna icon

The last use of this was removed in 89ba8c1507b84cef5bc892322ee767ed048101f4.

2 years agoremove 'lfdp.png' Smyrna icon
Matthew Fernandez [Wed, 23 Mar 2022 02:12:31 +0000 (19:12 -0700)]
remove 'lfdp.png' Smyrna icon

The last use of this was removed in 89ba8c1507b84cef5bc892322ee767ed048101f4.

2 years agoremove 'ldot.png' Smyrna icon
Matthew Fernandez [Wed, 23 Mar 2022 02:09:54 +0000 (19:09 -0700)]
remove 'ldot.png' Smyrna icon

The last use of this was removed in 89ba8c1507b84cef5bc892322ee767ed048101f4.

2 years agoremove 'lcirco.png' Smyrna icon
Matthew Fernandez [Wed, 23 Mar 2022 02:08:27 +0000 (19:08 -0700)]
remove 'lcirco.png' Smyrna icon

The last use of this was removed in 89ba8c1507b84cef5bc892322ee767ed048101f4.

2 years agoremove 'glade-3.png' Smyrna icon
Matthew Fernandez [Wed, 23 Mar 2022 02:07:01 +0000 (19:07 -0700)]
remove 'glade-3.png' Smyrna icon

This seems to have never been used.

2 years agoremove 'dot.PNG' Smyrna icon
Matthew Fernandez [Wed, 23 Mar 2022 02:05:38 +0000 (19:05 -0700)]
remove 'dot.PNG' Smyrna icon

This seems to have never been used.

2 years agoremove 'rotate.*' Smyrna icons
Matthew Fernandez [Wed, 23 Mar 2022 01:51:51 +0000 (18:51 -0700)]
remove 'rotate.*' Smyrna icons

The last use of these was removed in f565e185203d287fd659af1f11d83bcf44c351f3.

2 years agoremove 'zoomplus.raw' Smyrna icon
Matthew Fernandez [Wed, 23 Mar 2022 01:49:17 +0000 (18:49 -0700)]
remove 'zoomplus.raw' Smyrna icon

The last use of this was removed in 9a9cfd4e90775aa14a11a0db6745783f3a59ef56.

2 years agoremove 'zoomminus.raw' Smyrna icon
Matthew Fernandez [Wed, 23 Mar 2022 01:48:08 +0000 (18:48 -0700)]
remove 'zoomminus.raw' Smyrna icon

The last use of this was removed in 9a9cfd4e90775aa14a11a0db6745783f3a59ef56.

2 years agoremove 'ok*.raw' Smyrna icons
Matthew Fernandez [Wed, 23 Mar 2022 01:46:20 +0000 (18:46 -0700)]
remove 'ok*.raw' Smyrna icons

These seem to have never been used.

2 years agoremove 'select.png' Smyrna icon
Matthew Fernandez [Wed, 23 Mar 2022 01:43:20 +0000 (18:43 -0700)]
remove 'select.png' Smyrna icon

The last use of this was removed in 1c6ea45d410c76f6b98dc9d33c7f91a6e02f7e7e.

2 years agoremove 'newzoom.png' Smyrna icon
Matthew Fernandez [Wed, 23 Mar 2022 01:39:55 +0000 (18:39 -0700)]
remove 'newzoom.png' Smyrna icon

The last use of this was removed in 1c6ea45d410c76f6b98dc9d33c7f91a6e02f7e7e.

2 years agoremove 'new_node.png' Smyrna icon
Matthew Fernandez [Wed, 23 Mar 2022 01:36:07 +0000 (18:36 -0700)]
remove 'new_node.png' Smyrna icon

The last use of this was removed in 1c6ea45d410c76f6b98dc9d33c7f91a6e02f7e7e.

2 years agoremove 'magnifier_zoom_in.png' Smyrna icon
Matthew Fernandez [Wed, 23 Mar 2022 01:34:38 +0000 (18:34 -0700)]
remove 'magnifier_zoom_in.png' Smyrna icon

The last use of this was removed in 1c6ea45d410c76f6b98dc9d33c7f91a6e02f7e7e.

2 years agoremove 'magnifier.png' Smyrna icon
Matthew Fernandez [Wed, 23 Mar 2022 01:33:10 +0000 (18:33 -0700)]
remove 'magnifier.png' Smyrna icon

The last use of this was removed in f565e185203d287fd659af1f11d83bcf44c351f3.

2 years agoremove 'magifier_zoom_out.png' Smyrna icon
Matthew Fernandez [Wed, 23 Mar 2022 01:29:22 +0000 (18:29 -0700)]
remove 'magifier_zoom_out.png' Smyrna icon

The last use of this was removed in 1a65f4b82be8bb588edf6895e4712012f1cbe17a.

2 years agoremove 'hourglass.png' Smyrna icon
Matthew Fernandez [Wed, 23 Mar 2022 01:27:55 +0000 (18:27 -0700)]
remove 'hourglass.png' Smyrna icon

The last use of this was removed in 1a65f4b82be8bb588edf6895e4712012f1cbe17a.

2 years agoremove 'find_node.png' Smyrna icon
Matthew Fernandez [Wed, 23 Mar 2022 01:25:39 +0000 (18:25 -0700)]
remove 'find_node.png' Smyrna icon

The last use of this was removed in 1c6ea45d410c76f6b98dc9d33c7f91a6e02f7e7e.

2 years agoremove 'find_edge.png' Smyrna icon
Matthew Fernandez [Wed, 23 Mar 2022 01:24:48 +0000 (18:24 -0700)]
remove 'find_edge.png' Smyrna icon

The last use of this was removed in 1c6ea45d410c76f6b98dc9d33c7f91a6e02f7e7e.

2 years agoremove 'delete_node.png' Smyrna icon
Matthew Fernandez [Wed, 23 Mar 2022 01:23:22 +0000 (18:23 -0700)]
remove 'delete_node.png' Smyrna icon

The last use of this was removed in 1c6ea45d410c76f6b98dc9d33c7f91a6e02f7e7e.

2 years agoremove 'deletE_edge.png' Smyrna icon
Matthew Fernandez [Wed, 23 Mar 2022 01:22:34 +0000 (18:22 -0700)]
remove 'deletE_edge.png' Smyrna icon

The last use of this was removed in 1c6ea45d410c76f6b98dc9d33c7f91a6e02f7e7e.

2 years agoremove 'AntiselectRect' Smyrna icons
Matthew Fernandez [Wed, 23 Mar 2022 01:18:32 +0000 (18:18 -0700)]
remove 'AntiselectRect' Smyrna icons

The last use of these was removed in 1c6ea45d410c76f6b98dc9d33c7f91a6e02f7e7e.

2 years agoremove 'add_edge.png' Smyrna icon
Matthew Fernandez [Wed, 23 Mar 2022 01:16:25 +0000 (18:16 -0700)]
remove 'add_edge.png' Smyrna icon

The last use of this was removed in 1c6ea45d410c76f6b98dc9d33c7f91a6e02f7e7e.

2 years agoMerge branch 'smattr/5B54693E-4A14-4B13-8A39-B13568AEE42D' into 'main'
Matthew Fernandez [Mon, 28 Mar 2022 17:33:02 +0000 (17:33 +0000)]
Merge branch 'smattr/5B54693E-4A14-4B13-8A39-B13568AEE42D' into 'main'

CMake: enable 'diffimg'

Closes #1788

See merge request graphviz/graphviz!2535

2 years agoCMake: enable 'diffimg'
Matthew Fernandez [Sat, 26 Mar 2022 20:39:07 +0000 (13:39 -0700)]
CMake: enable 'diffimg'

Note that the rtest/rtest.py work around is still not fully removed because
libgd is not currently available in the 64-bit Windows CI environment.

Gitlab: closes #1788

2 years agoMerge branch 'smattr/0E5378C5-27A2-4E7A-A4A8-8BC527899AF6' into 'main'
Matthew Fernandez [Sun, 27 Mar 2022 19:40:35 +0000 (19:40 +0000)]
Merge branch 'smattr/0E5378C5-27A2-4E7A-A4A8-8BC527899AF6' into 'main'

smyrna: clean up and warning squashing

See merge request graphviz/graphviz!2533

2 years agocmd/smyrna: remove unused return value from 'close_graph'
Matthew Fernandez [Sun, 27 Mar 2022 18:22:34 +0000 (11:22 -0700)]
cmd/smyrna: remove unused return value from 'close_graph'

2 years agocmd/smyrna/viewport.c: fix -Wnon-literal-null-conversion with Clang
Matthew Fernandez [Sat, 26 Mar 2022 19:46:23 +0000 (12:46 -0700)]
cmd/smyrna/viewport.c: fix -Wnon-literal-null-conversion with Clang

This was causing the CMake build (to be enabled in a future commit) on macOS to
fail.

Gitlab: #1836, #1854

2 years agocmd/smyrna: fix a comment typo
Matthew Fernandez [Sat, 26 Mar 2022 18:08:11 +0000 (11:08 -0700)]
cmd/smyrna: fix a comment typo

2 years agocmd/smyrna: fix -Wnon-literal-null-conversion with Clang
Matthew Fernandez [Sat, 26 Mar 2022 18:07:00 +0000 (11:07 -0700)]
cmd/smyrna: fix -Wnon-literal-null-conversion with Clang

This was causing the CMake build (to be enabled in a future commit) on macOS to
fail.

Gitlab: #1836, #1854

2 years agocmd/smyrna: remove no-op if statement
Matthew Fernandez [Sat, 26 Mar 2022 15:39:20 +0000 (08:39 -0700)]
cmd/smyrna: remove no-op if statement

When enabling Smyrna in the CMake build system, compilation fails with a
-Wempty-body warning about this line. I am guessing that it was intended to not
be a conditional here.

Gitlab: #1836, #1854

2 years agofix: teach Smyrna '-?' on macOS and Windows
Matthew Fernandez [Sat, 26 Mar 2022 15:13:30 +0000 (08:13 -0700)]
fix: teach Smyrna '-?' on macOS and Windows

This is the equivalent of cd80b6262c7e1b95307756f13c89a9f6b2900520 and friends
but for Smyrna. It was not previously detected that this problem also affects
Smyrna because it is not currently built on macOS or Windows in CI. This will be
improved in future.

Gitlab: #1852

2 years agolib/glcomp: fix -Wnon-literal-null-conversion with Clang
Matthew Fernandez [Sat, 26 Mar 2022 00:30:58 +0000 (17:30 -0700)]
lib/glcomp: fix -Wnon-literal-null-conversion with Clang

This was causing the CMake build (to be enabled in a future commit) on macOS to
fail.

Gitlab: #1836, #1854

2 years agolib/glcomp: remove unused 'glCompButton.customptr'
Matthew Fernandez [Sat, 26 Mar 2022 00:28:25 +0000 (17:28 -0700)]
lib/glcomp: remove unused 'glCompButton.customptr'

With Clang on macOS, this causes compiler warnings due to initializing a pointer
with `'\0'`. This fails the CMake build which will be enabled in a future
commit. We could rephrase this, but it is simpler to just remove this unused
member.

Gitlab: #1836, #1854

2 years agosmyrna: remove unnecessary 'gpointer' cast
Matthew Fernandez [Sat, 26 Mar 2022 19:52:56 +0000 (12:52 -0700)]
smyrna: remove unnecessary 'gpointer' cast

`gpointer` is just a typedef for `void*` that implicitly coerces to all other
pointer types.

2 years agosmyrma: remove unnecessary 'gint' cast
Matthew Fernandez [Sat, 26 Mar 2022 19:50:16 +0000 (12:50 -0700)]
smyrma: remove unnecessary 'gint' cast

`G_PRIORITY_DEFAULT` is already a `gint` (typedef for `int`).

2 years agosmyrna: remove use of 'guint' cast
Matthew Fernandez [Sat, 26 Mar 2022 19:48:28 +0000 (12:48 -0700)]
smyrna: remove use of 'guint' cast

`guint` is just a Glib typedef for `unsigned int`. So we can write this simpler.

2 years agoMerge branch 'smattr/1D9B0E32-37CA-4547-A966-AE877344C814' into 'main'
Matthew Fernandez [Sun, 27 Mar 2022 18:12:06 +0000 (18:12 +0000)]
Merge branch 'smattr/1D9B0E32-37CA-4547-A966-AE877344C814' into 'main'

tests: remove unused cdiff.c

See merge request graphviz/graphviz!2532

2 years agotests: remove unused cdiff.c
Matthew Fernandez [Sat, 26 Mar 2022 20:08:17 +0000 (13:08 -0700)]
tests: remove unused cdiff.c

2 years agoMerge branch 'smattr/63D62C3D-D094-4ED8-A675-538D7283B9E6' into 'main'
Matthew Fernandez [Sat, 26 Mar 2022 19:58:17 +0000 (19:58 +0000)]
Merge branch 'smattr/63D62C3D-D094-4ED8-A675-538D7283B9E6' into 'main'

use suffixed literals instead of casts to construct 'GLfloat' values

See merge request graphviz/graphviz!2530

2 years agouse suffixed literals instead of casts to construct 'GLfloat' values
Matthew Fernandez [Fri, 25 Mar 2022 05:13:05 +0000 (22:13 -0700)]
use suffixed literals instead of casts to construct 'GLfloat' values

The `GLfloat` type is 32-bit IEEE-754 floating-point.¹ As of C99, the `float`
type is also 32-bit IEEE-754 floating-point on all platforms with support.² In
contemporary usage, this is effectively all C99 platforms that support
floating-point arithmetic. Graphviz has been compiled in C99 mode since commit
fe3f9411d2c59b463ab1b64eecfd19f2db55d2fc. Putting those things together, we can
abbreviate the way we write `GLfloat` literals, leading to more readable code.

¹ https://www.khronos.org/opengl/wiki/OpenGL_Type
² https://en.wikipedia.org/wiki/C99#IEEE_754_floating-point_support

2 years agoMerge branch 'smattr/26236D4A-346B-44B1-ACAB-ED8D7E59E09E' into 'main'
Matthew Fernandez [Sat, 26 Mar 2022 18:27:02 +0000 (18:27 +0000)]
Merge branch 'smattr/26236D4A-346B-44B1-ACAB-ED8D7E59E09E' into 'main'

gvc: remove unused unistd.h #include

See merge request graphviz/graphviz!2531

2 years agogvc: remove unused unistd.h #include
Matthew Fernandez [Sat, 26 Mar 2022 03:16:51 +0000 (20:16 -0700)]
gvc: remove unused unistd.h #include

Gitlab: #2204

2 years agoMerge branch 'smattr/9691B69C-F05E-4819-B327-8258BB2B3D23' into 'main'
Matthew Fernandez [Sat, 26 Mar 2022 15:45:29 +0000 (15:45 +0000)]
Merge branch 'smattr/9691B69C-F05E-4819-B327-8258BB2B3D23' into 'main'

move XML validation tests into a separate CI job

Closes #2216

See merge request graphviz/graphviz!2527

2 years agomove XML validation tests into a separate CI job
Matthew Fernandez [Wed, 23 Mar 2022 00:42:32 +0000 (17:42 -0700)]
move XML validation tests into a separate CI job

This parametrized test was checking the validity of checked in Graphviz HTML
sources. There is no need to run this identical check in every single CI test
job nor on end users machines where they may have differing versions of
`xmllint` installed.

Gitlab: closes #2216

2 years agoMerge branch 'smattr/A0DB9535-2265-4E6C-9389-16058C1BB35B' into 'main'
Matthew Fernandez [Sat, 26 Mar 2022 06:47:53 +0000 (06:47 +0000)]
Merge branch 'smattr/A0DB9535-2265-4E6C-9389-16058C1BB35B' into 'main'

towards enabling Smyrna in CMake

See merge request graphviz/graphviz!2526

2 years agosmyrna Init: squash -Wincompatible-pointer-types
Matthew Fernandez [Mon, 21 Mar 2022 15:09:55 +0000 (08:09 -0700)]
smyrna Init: squash -Wincompatible-pointer-types

OpenGL has an unorthodox API wherein the `gluTessCallback` function’s prototype
indicates it takes a `void(*)(void)`, but its docs¹ explain that the type
actually varies depending on the second argument. As a result, the compiler
(correctly) warns that some of these `gluTessCallback` calls are passing
function pointers that do not have the same ABI. Presumably this works out
because at the end of the day a function pointer is just some bits in C and the
OpenGL implementation branches on the `which` argument and invokes the pointer
correctly. But if OpenGL really wanted to discard type safety this way, it is
not clear to me why they did not make the function pointer argument a `void*`.
Anyway, this commit squashes the compiler warnings which emerge when enabling
this in the CMake build system, failing the build.

Gitlab: related to #1836

¹ This is not the authoritative source, but Microsoft’s docs for their
  implementation provide a good explanation.
  https://docs.microsoft.com/en-us/windows/win32/opengl/glutess

2 years agosmyrna cb_mouseclick: remove unused 'g'
Matthew Fernandez [Mon, 21 Mar 2022 14:57:22 +0000 (07:57 -0700)]
smyrna cb_mouseclick: remove unused 'g'

This causes compiler warnings resulting in build failure when enabling this in
the CMake build system.

Gitlab: related to #1836

2 years agosmyrna on_attrAddBtn_clicked: remove unused 'value'
Matthew Fernandez [Mon, 21 Mar 2022 14:49:00 +0000 (07:49 -0700)]
smyrna on_attrAddBtn_clicked: remove unused 'value'

This causes compiler warnings resulting in build failure when enabling this in
the CMake build system.

Gitlab: related to #1836

2 years agosmyrna: remove unused 'gvpr_select'
Matthew Fernandez [Mon, 21 Mar 2022 14:33:28 +0000 (07:33 -0700)]
smyrna: remove unused 'gvpr_select'

The last use of this was removed in 7e1f01ad52915498a252dd213f85daf5a058aa5d.
This causes compiler warnings resulting in build failure when enabling this in
the CMake build system.

Gitlab: related to #1836

2 years agosmyrna on_attrAddBtn_clicked: remove unused 'prog'
Matthew Fernandez [Mon, 21 Mar 2022 14:31:31 +0000 (07:31 -0700)]
smyrna on_attrAddBtn_clicked: remove unused 'prog'

This causes compiler warnings resulting in build failure when enabling this in
the CMake build system.

Gitlab: related to #1836

2 years agosmyrna doApply: remove unused 't'
Matthew Fernandez [Mon, 21 Mar 2022 14:29:04 +0000 (07:29 -0700)]
smyrna doApply: remove unused 't'

This causes compiler warnings resulting in build failure when enabling this in
the CMake build system.

Gitlab: related to #1836

2 years agocmd/smyrna: remove some unnecessary intermediate buffers
Matthew Fernandez [Mon, 21 Mar 2022 04:42:28 +0000 (21:42 -0700)]
cmd/smyrna: remove some unnecessary intermediate buffers

2 years agocmd/smyrna: remove some excess white space
Matthew Fernandez [Mon, 21 Mar 2022 04:42:02 +0000 (21:42 -0700)]
cmd/smyrna: remove some excess white space

2 years agocmd/smyrna: remove some open coded 'NULL'
Matthew Fernandez [Mon, 21 Mar 2022 04:41:08 +0000 (21:41 -0700)]
cmd/smyrna: remove some open coded 'NULL'

2 years agoCI: install libglade on CentOS 7, enabling lib/glcomp
Matthew Fernandez [Mon, 21 Mar 2022 02:18:25 +0000 (19:18 -0700)]
CI: install libglade on CentOS 7, enabling lib/glcomp

A step on the way towards enabling Smyrna in the CMake build.

Gitlab: #1836

2 years agoCMake: enable lib/glcomp
Matthew Fernandez [Sun, 20 Mar 2022 23:37:07 +0000 (16:37 -0700)]
CMake: enable lib/glcomp

Interestingly enabling this revealed that lib/glcomp also depends on Pango,
something unexpressed in either the Autotools or MS Build build systems.

Gitlab: #1836

2 years agolib/glcomp: remove gtkglext CFLAGS tweak
Matthew Fernandez [Mon, 21 Mar 2022 00:07:06 +0000 (17:07 -0700)]
lib/glcomp: remove gtkglext CFLAGS tweak

As far as I can tell, glcomp does not use gtkglext. Smyrna, which depends on
glcomp, does. But Smyrna specifies its own linking against gtkglext.

2 years agolib/glcomp: remove unnecessary 'static' from some variables
Matthew Fernandez [Mon, 21 Mar 2022 04:35:20 +0000 (21:35 -0700)]
lib/glcomp: remove unnecessary 'static' from some variables

These are unconditionally overwritten during their respective functions before
they are ever read.

2 years agolib/glcomp: remove unnecessary parens
Matthew Fernandez [Mon, 21 Mar 2022 04:34:55 +0000 (21:34 -0700)]
lib/glcomp: remove unnecessary parens

2 years agolib/glcomp: remove some unnecessary casts
Matthew Fernandez [Mon, 21 Mar 2022 04:34:02 +0000 (21:34 -0700)]
lib/glcomp: remove some unnecessary casts

2 years agolib/glcomp: remove some open coded 'NULL'
Matthew Fernandez [Mon, 21 Mar 2022 04:33:21 +0000 (21:33 -0700)]
lib/glcomp: remove some open coded 'NULL'

2 years agolib/glcomp: remove some duplicate #includes
Matthew Fernandez [Sun, 20 Mar 2022 23:59:01 +0000 (16:59 -0700)]
lib/glcomp: remove some duplicate #includes

2 years agolib/glcomp: remove some trailing white space
Matthew Fernandez [Sun, 20 Mar 2022 23:58:44 +0000 (16:58 -0700)]
lib/glcomp: remove some trailing white space

2 years agolib/topfish: missing CMake dependencies
Matthew Fernandez [Tue, 22 Mar 2022 02:03:51 +0000 (19:03 -0700)]
lib/topfish: missing CMake dependencies

This seems to have been broken since CMake support for lib/topfish was
introduced in 45893ca105777e1c5b97788cd169e400250ffa1f. But it was never noticed
because there is no executable in the CMake build system that links against
topfish yet.

Gitlab: #1836

2 years agolib/topfish: fix CMakeLists.txt indentation
Matthew Fernandez [Tue, 22 Mar 2022 01:13:03 +0000 (18:13 -0700)]
lib/topfish: fix CMakeLists.txt indentation

Unclear why `cmakelang.lint` does not warn about this.

2 years agolib/topfish maxmatch: remove unused 'sum_weights'
Matthew Fernandez [Tue, 22 Mar 2022 01:43:47 +0000 (18:43 -0700)]
lib/topfish maxmatch: remove unused 'sum_weights'

This causes compiler warnings resulting in build failure when enabling this in
the CMake build system.

Gitlab: related to #1836

2 years agoremove unused 'HAVE_GTKGLEXT'
Matthew Fernandez [Sun, 20 Mar 2022 23:18:31 +0000 (16:18 -0700)]
remove unused 'HAVE_GTKGLEXT'

Aside from being unused, it is unclear why the Windows config.h was defining
this given it does not define `HAVE_GTKGL`.

2 years agopathfind: remove an unnecessary cast
Matthew Fernandez [Mon, 21 Mar 2022 04:45:17 +0000 (21:45 -0700)]
pathfind: remove an unnecessary cast

2 years agoMerge branch 'smattr/E88122C7-BB84-4919-9B41-D44586D94783' into 'main'
Matthew Fernandez [Sat, 26 Mar 2022 03:26:59 +0000 (03:26 +0000)]
Merge branch 'smattr/E88122C7-BB84-4919-9B41-D44586D94783' into 'main'

CMake: enable edgepaint

See merge request graphviz/graphviz!2525

2 years agoCMake: add cmd/edgepaint compilation
Matthew Fernandez [Sat, 19 Mar 2022 21:06:49 +0000 (14:06 -0700)]
CMake: add cmd/edgepaint compilation

Gitlab: #1836

2 years agoCMake: enable lib/edgepaint compilation
Matthew Fernandez [Sat, 19 Mar 2022 20:47:17 +0000 (13:47 -0700)]
CMake: enable lib/edgepaint compilation

Note that the target here is named “edgepaintib” in anticipation of future
enabling of cmd/edgepaint claiming the name “edgepaint”. This also does not
define a separate liblab_gamut, as the Autotools build does. This separate
library seems only useful for cmd/edgepaint, so it does not seem worth splitting
it out as a separate library.

Gitlab: #1836

2 years agolib/edgepaint: remove linking against libANN
Matthew Fernandez [Sat, 19 Mar 2022 21:04:17 +0000 (14:04 -0700)]
lib/edgepaint: remove linking against libANN

For the same motivation as the prior commit, this is unused.

2 years agolib/edgepaint: remove application of ANN’s CFLAGS
Matthew Fernandez [Sat, 19 Mar 2022 20:42:49 +0000 (13:42 -0700)]
lib/edgepaint: remove application of ANN’s CFLAGS

This seems to have been a mistake in aadee957012e676c9aaf36ec40cb2860c178e269.
lib/edgepaint does not depend on libANN, so it does not seem correct to apply
ANN’s CFLAGS when compiling it.

2 years agoMerge branch 'smattr/71744FB7-FA95-46C5-949E-64F986D85872' into 'main'
Matthew Fernandez [Sat, 26 Mar 2022 01:40:28 +0000 (01:40 +0000)]
Merge branch 'smattr/71744FB7-FA95-46C5-949E-64F986D85872' into 'main'

test case for #2215

See merge request graphviz/graphviz!2521

2 years agogvParseArgs etc: use a clearer idiom for accessing characters of 'arg'
Matthew Fernandez [Sat, 19 Mar 2022 17:45:02 +0000 (10:45 -0700)]
gvParseArgs etc: use a clearer idiom for accessing characters of 'arg'

2 years agogvParseArgs etc: remove tests for 'NULL' members in 'argv'
Matthew Fernandez [Sat, 19 Mar 2022 17:42:24 +0000 (10:42 -0700)]
gvParseArgs etc: remove tests for 'NULL' members in 'argv'

The strings in `argv` within the range of `argc` are guaranteed non-null.

2 years agoadd a test case for #2215
Matthew Fernandez [Sat, 19 Mar 2022 17:38:56 +0000 (10:38 -0700)]
add a test case for #2215

2 years agoMerge branch 'smattr/875065A8-89A1-453D-9A36-2C2A8E259B84' into 'main'
Matthew Fernandez [Fri, 25 Mar 2022 15:56:17 +0000 (15:56 +0000)]
Merge branch 'smattr/875065A8-89A1-453D-9A36-2C2A8E259B84' into 'main'

gvpr: remove some sfio, unistd.h dependencies

See merge request graphviz/graphviz!2523

2 years agogvpr: rewrite debug graph processing to use stdio instead of sfio
Matthew Fernandez [Sun, 20 Mar 2022 01:36:40 +0000 (18:36 -0700)]
gvpr: rewrite debug graph processing to use stdio instead of sfio

This cuts a dependency on sfio, as well as a dependency on non-portable unistd.h
functions.

Gitlab: #1998, #2204

2 years agogvpr: rewrite debug I/O output to use stdio instead of unistd
Matthew Fernandez [Sun, 20 Mar 2022 01:29:07 +0000 (18:29 -0700)]
gvpr: rewrite debug I/O output to use stdio instead of unistd

There is no need to use the lower level `write` API for this I/O. By using
`fprintf` instead, we avoid a dependency on non-portable unistd.h.

Gitlab: #2204

2 years agoMerge branch 'smattr/B24E1807-D40B-483F-8529-60C8EB2E4707' into 'main'
Matthew Fernandez [Fri, 25 Mar 2022 05:45:09 +0000 (05:45 +0000)]
Merge branch 'smattr/B24E1807-D40B-483F-8529-60C8EB2E4707' into 'main'

further pathcanon clean up and remove strings.h detection

See merge request graphviz/graphviz!2522

2 years agoremove no longer used strings.h detection
Matthew Fernandez [Sat, 19 Mar 2022 20:19:33 +0000 (13:19 -0700)]
remove no longer used strings.h detection

2 years agorender.h: remove unused strings.h #include
Matthew Fernandez [Sat, 19 Mar 2022 20:18:05 +0000 (13:18 -0700)]
render.h: remove unused strings.h #include

2 years agopathfind: remove unused strings.h #include
Matthew Fernandez [Sat, 19 Mar 2022 20:17:02 +0000 (13:17 -0700)]
pathfind: remove unused strings.h #include

2 years agopathcanon: remove unused 'loop' variable
Matthew Fernandez [Sat, 19 Mar 2022 20:13:17 +0000 (13:13 -0700)]
pathcanon: remove unused 'loop' variable

2 years agopathcanon: remove unnecessary 'errno' save and restore
Matthew Fernandez [Sat, 19 Mar 2022 20:12:20 +0000 (13:12 -0700)]
pathcanon: remove unnecessary 'errno' save and restore

a3db9ad8f8eb79a931f0bc6d087ca3b52de3dd62 removed any logic in this function that
affected `errno`. So there is no need to save and restore it anymore.

2 years agoMerge branch 'smattr/9E1814ED-8451-43CC-A7A1-AAF2BE8EDF86' into 'main'
Matthew Fernandez [Thu, 24 Mar 2022 16:52:38 +0000 (16:52 +0000)]
Merge branch 'smattr/9E1814ED-8451-43CC-A7A1-AAF2BE8EDF86' into 'main'

roll out cgraph allocation wrappers to edgepaint

See merge request graphviz/graphviz!2517