]> granicus.if.org Git - icinga2/log
icinga2
8 years agoUpdate RELEASE.md
Michael Friedrich [Mon, 7 Dec 2015 15:29:19 +0000 (16:29 +0100)]
Update RELEASE.md

8 years agoAdd -pthread to build flags
Gunnar Beutner [Tue, 16 Feb 2016 12:08:21 +0000 (13:08 +0100)]
Add -pthread to build flags

refs #10963

8 years agoIncrease query queue size for testing
Michael Friedrich [Fri, 12 Feb 2016 13:14:48 +0000 (14:14 +0100)]
Increase query queue size for testing

refs #10963

8 years agoEnsure that checks are not scheduled for command_endpoint fake hosts
Gunnar Beutner [Thu, 21 Jan 2016 15:37:52 +0000 (16:37 +0100)]
Ensure that checks are not scheduled for command_endpoint fake hosts

refs #10963

8 years agoRemove redundant log messages
Gunnar Beutner [Thu, 21 Jan 2016 12:02:53 +0000 (13:02 +0100)]
Remove redundant log messages

refs #10963

8 years agoMake sure we're not running command_endpoint-based checks more than once
Gunnar Beutner [Thu, 21 Jan 2016 09:32:38 +0000 (10:32 +0100)]
Make sure we're not running command_endpoint-based checks more than once

refs #10963

8 years agoAdd missing SetSyncing() call
Gunnar Beutner [Wed, 20 Jan 2016 13:07:07 +0000 (14:07 +0100)]
Add missing SetSyncing() call

refs #10963

8 years agoSkip log replay for endpoints with log_duration = 0
Gunnar Beutner [Tue, 19 Jan 2016 16:25:28 +0000 (17:25 +0100)]
Skip log replay for endpoints with log_duration = 0

refs #10963

8 years agoOnly build leak detection code when I2_LEAK_DEBUG is set
Gunnar Beutner [Tue, 19 Jan 2016 15:43:46 +0000 (16:43 +0100)]
Only build leak detection code when I2_LEAK_DEBUG is set

refs #10963

8 years agoCheck the certificate name when reconnecting to an instance
Gunnar Beutner [Tue, 19 Jan 2016 15:24:12 +0000 (16:24 +0100)]
Check the certificate name when reconnecting to an instance

refs #10963

8 years agoDecrease memory usage for the Object class
Gunnar Beutner [Tue, 19 Jan 2016 14:25:44 +0000 (15:25 +0100)]
Decrease memory usage for the Object class

refs #10963

8 years agoImprove debug support for analyzing memory leaks
Gunnar Beutner [Tue, 19 Jan 2016 14:24:17 +0000 (15:24 +0100)]
Improve debug support for analyzing memory leaks

refs #10963

8 years agoPlug two memory leaks
Jean Flach [Fri, 15 Jan 2016 09:11:52 +0000 (10:11 +0100)]
Plug two memory leaks

refs #10963

8 years agoReplace boost-base64 with an openssl implementation
Jean Flach [Fri, 18 Dec 2015 15:03:57 +0000 (16:03 +0100)]
Replace boost-base64 with an openssl implementation

Also add unit tests

fixes #10714

8 years agoFix: "node setup" tries to chown() files before they're created
Gunnar Beutner [Tue, 23 Feb 2016 07:41:48 +0000 (08:41 +0100)]
Fix: "node setup" tries to chown() files before they're created

fixes #11204

8 years agoUpdate AUTHORS
Gunnar Beutner [Tue, 23 Feb 2016 07:42:46 +0000 (08:42 +0100)]
Update AUTHORS

refs #11178

8 years agoDocumentation: Fix escaping the pipe character in tables
Stefan Triep [Wed, 17 Feb 2016 19:42:14 +0000 (20:42 +0100)]
Documentation: Fix escaping the pipe character in tables

fixes #11178

Signed-off-by: Michael Friedrich <michael.friedrich@gmail.com>
8 years agoBuild fix for CentOS 5
Gunnar Beutner [Mon, 22 Feb 2016 07:12:35 +0000 (08:12 +0100)]
Build fix for CentOS 5

fixes #11179

8 years agoRename the IOTHREADS macro
Gunnar Beutner [Tue, 16 Feb 2016 12:30:55 +0000 (13:30 +0100)]
Rename the IOTHREADS macro

refs #11014

8 years agoAdd check_iostat to ITL
Thomas Widhalm [Sat, 5 Dec 2015 19:37:23 +0000 (20:37 +0100)]
Add check_iostat to ITL

fixes #10777

Signed-off-by: Jean Flach <jean-marcel.flach@netways.de>
8 years agoFixed precision for percentage calculations with large units
Per von Zweigbergk [Sat, 31 Oct 2015 13:47:36 +0000 (14:47 +0100)]
Fixed precision for percentage calculations with large units

The check_memory and check_swap plugins on Windows were incorrectly
rounding the memory/swap measurements to the nearest unit prior to
calculating a percentage. This was causing imprecise percentage
values when the unit selected meant that the values in question had
few significant figures.

fixes #10497

Signed-off-by: Jean Flach <jean-marcel.flach@netways.de>
8 years agoDocument disk_ignore_reserved
Jean Flach [Fri, 12 Feb 2016 12:15:23 +0000 (13:15 +0100)]
Document disk_ignore_reserved

fixes #11138

8 years agoAdd -f option to check_disk CheckCommand
Jean Flach [Fri, 12 Feb 2016 09:22:15 +0000 (10:22 +0100)]
Add -f option to check_disk CheckCommand

fixes #11138

8 years agoUpdate AUTHORS
Gunnar Beutner [Mon, 22 Feb 2016 07:05:23 +0000 (08:05 +0100)]
Update AUTHORS

refs #10777
refs #11132

8 years agoFix parsing of YYYY-MM-DD in LegacyTimePeriod::ParseTimeSpec
Adam James [Tue, 9 Feb 2016 18:04:37 +0000 (18:04 +0000)]
Fix parsing of YYYY-MM-DD in LegacyTimePeriod::ParseTimeSpec

fixes #11132

Signed-off-by: Jean Flach <jean-marcel.flach@netways.de>
8 years agoDB IDO: PArtially revert change for *group_members
Michael Friedrich [Mon, 22 Feb 2016 19:23:18 +0000 (20:23 +0100)]
DB IDO: PArtially revert change for *group_members

Otherwise the index breaks.

refs #11103

8 years agoDB IDO: Fix problem with hostgroup_members cleanup
Michael Friedrich [Mon, 8 Feb 2016 10:05:27 +0000 (11:05 +0100)]
DB IDO: Fix problem with hostgroup_members cleanup

fixes #11103

8 years agoFix: Cluster WQ thread dies after fork()
Gunnar Beutner [Tue, 9 Feb 2016 11:46:11 +0000 (12:46 +0100)]
Fix: Cluster WQ thread dies after fork()

fixes #11118

8 years agoApiListener: Bail out if object could not be created during config sync
Michael Friedrich [Fri, 12 Feb 2016 13:11:50 +0000 (14:11 +0100)]
ApiListener: Bail out if object could not be created during config sync

refs #11006

8 years agoFix crash in ApiListener::ConfigUpdateObjectAPIHandler
Gunnar Beutner [Tue, 9 Feb 2016 08:13:43 +0000 (09:13 +0100)]
Fix crash in ApiListener::ConfigUpdateObjectAPIHandler

fixes #11006

8 years agoRemove unused variables
Jean Flach [Mon, 8 Feb 2016 16:10:12 +0000 (17:10 +0100)]
Remove unused variables

fixes #11111

8 years agoMake schedule-downtime default fixed
Jean Flach [Mon, 8 Feb 2016 15:04:41 +0000 (16:04 +0100)]
Make schedule-downtime default fixed

fixes #10923

8 years agoFix: Deleting an object via API does not disable it in DB IDO
Michael Friedrich [Fri, 5 Feb 2016 11:37:00 +0000 (12:37 +0100)]
Fix: Deleting an object via API does not disable it in DB IDO

fixes #11065

8 years agoBuild fix
Gunnar Beutner [Tue, 9 Feb 2016 12:56:17 +0000 (13:56 +0100)]
Build fix

fixes #11096

8 years agoWindows build fix
Michael Friedrich [Thu, 4 Feb 2016 22:15:48 +0000 (23:15 +0100)]
Windows build fix

fixes #11096

8 years agoFix missing escaping in doc/7-icinga-template-library.md
Tobias Birnbaum [Wed, 3 Feb 2016 02:33:08 +0000 (18:33 -0800)]
Fix missing escaping in doc/7-icinga-template-library.md

There are several not properly escaped sequences in
doc/7-icinga-template-library.md
Namely these are missing backslashes in front of \n, \r, \t in various
occurrences. The make for example markup->latex conversion using pandoc
impossible.

fixes #11074

Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>
8 years agoUpdate AUTHORS
Michael Friedrich [Thu, 4 Feb 2016 21:46:44 +0000 (22:46 +0100)]
Update AUTHORS

refs #11074
refs #11075

8 years agoDocs: Fix outdated link to icingaweb2-module-nagvis
Tobias Birnbaum [Wed, 3 Feb 2016 02:41:34 +0000 (18:41 -0800)]
Docs: Fix outdated link to icingaweb2-module-nagvis

The link to icingaweb2-module-nagvis is pointing to an outdated
repository. This is fixed now by using the official Icinga-git
repository.

fixes #11075

Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>
8 years agoFix: API queries on non-existant objects cause exception
Michael Friedrich [Thu, 4 Feb 2016 21:40:01 +0000 (22:40 +0100)]
Fix: API queries on non-existant objects cause exception

fixes #11088

8 years agoFix memory leak in Stream::Close
Gunnar Beutner [Wed, 3 Feb 2016 11:56:54 +0000 (12:56 +0100)]
Fix memory leak in Stream::Close

refs #10655

8 years agoFix memory/thread leak in the HttpServerConnection class
Gunnar Beutner [Wed, 3 Feb 2016 08:54:31 +0000 (09:54 +0100)]
Fix memory/thread leak in the HttpServerConnection class

fixes #10655

8 years agoEnsure that HttpServerConnections are properly closed
Gunnar Beutner [Wed, 13 Jan 2016 09:30:38 +0000 (10:30 +0100)]
Ensure that HttpServerConnections are properly closed

fixes #10655

8 years agoFix crash in ConfigItem::RunWithActivationContext
Gunnar Beutner [Thu, 4 Feb 2016 12:17:37 +0000 (13:17 +0100)]
Fix crash in ConfigItem::RunWithActivationContext

fixes #11085

8 years agoMake sure the "syncing" attribute is set to false
Gunnar Beutner [Mon, 8 Feb 2016 12:15:24 +0000 (13:15 +0100)]
Make sure the "syncing" attribute is set to false

refs #11083

8 years agoEnsure that config sync updates are always sent on reconnect
Michael Friedrich [Thu, 4 Feb 2016 10:30:27 +0000 (11:30 +0100)]
Ensure that config sync updates are always sent on reconnect

fixes #11083

8 years agoImplement String#trim
Michael Friedrich [Tue, 26 Jan 2016 14:59:29 +0000 (15:59 +0100)]
Implement String#trim

fixes #11037

8 years agoFix incorrect --version information
Michael Friedrich [Tue, 26 Jan 2016 14:16:59 +0000 (15:16 +0100)]
Fix incorrect --version information

fixes #10784

8 years agoImprove performance for TlsStream::OnEvent
Gunnar Beutner [Tue, 2 Feb 2016 12:51:17 +0000 (13:51 +0100)]
Improve performance for TlsStream::OnEvent

refs #11014

8 years agoFix crash in IdoCheckTask::ScriptFunc
Gunnar Beutner [Tue, 2 Feb 2016 11:03:12 +0000 (12:03 +0100)]
Fix crash in IdoCheckTask::ScriptFunc

refs #11014

8 years agoUse multiple threads for socket IO
Gunnar Beutner [Tue, 2 Feb 2016 10:17:33 +0000 (11:17 +0100)]
Use multiple threads for socket IO

refs #11014

8 years agoRemove debug log message
Gunnar Beutner [Tue, 2 Feb 2016 08:54:31 +0000 (09:54 +0100)]
Remove debug log message

refs #11014

8 years agoAvoid unnecessary pollfd updates
Gunnar Beutner [Tue, 2 Feb 2016 08:52:23 +0000 (09:52 +0100)]
Avoid unnecessary pollfd updates

refs #11014

8 years agoIncrease the buffer size in TlsStream::OnEvent to avoid unnecessary poll() calls
Gunnar Beutner [Tue, 2 Feb 2016 07:28:54 +0000 (08:28 +0100)]
Increase the buffer size in TlsStream::OnEvent to avoid unnecessary poll() calls

refs #11014

8 years agoFix deadlock in HttpClientConnection::DataAvailableHandler
Gunnar Beutner [Mon, 1 Feb 2016 13:50:18 +0000 (14:50 +0100)]
Fix deadlock in HttpClientConnection::DataAvailableHandler

refs #11014

8 years agoFix incorrect memcpy() with overlapping buffers
Gunnar Beutner [Mon, 1 Feb 2016 11:58:42 +0000 (12:58 +0100)]
Fix incorrect memcpy() with overlapping buffers

refs #11014

8 years agoFix incorrect method call in JsonRpcConnection::MessageHandler
Gunnar Beutner [Mon, 1 Feb 2016 10:25:34 +0000 (11:25 +0100)]
Fix incorrect method call in JsonRpcConnection::MessageHandler

refs #11014

8 years agoAvoid unnecessary new/deletes
Gunnar Beutner [Mon, 1 Feb 2016 08:33:33 +0000 (09:33 +0100)]
Avoid unnecessary new/deletes

refs #11014

8 years agoFix deadlock in {HttpServerConnection,JsonRpcConnection}::DataAvailableHandler
Gunnar Beutner [Mon, 1 Feb 2016 07:35:55 +0000 (08:35 +0100)]
Fix deadlock in {HttpServerConnection,JsonRpcConnection}::DataAvailableHandler

refs #11014

8 years agoRemove debug output, part 2
Michael Friedrich [Fri, 29 Jan 2016 13:09:50 +0000 (14:09 +0100)]
Remove debug output, part 2

refs #11014

8 years agoRemove debug output
Michael Friedrich [Fri, 29 Jan 2016 13:03:58 +0000 (14:03 +0100)]
Remove debug output

refs #11014

8 years agoAvoid unnecessary reallocs in FIFO::Optimize
Gunnar Beutner [Thu, 28 Jan 2016 12:09:17 +0000 (13:09 +0100)]
Avoid unnecessary reallocs in FIFO::Optimize

refs #11014

8 years agoAvoid unnecessary dictionary lookups in SocketEvents::ThreadProc
Gunnar Beutner [Thu, 28 Jan 2016 12:07:09 +0000 (13:07 +0100)]
Avoid unnecessary dictionary lookups in SocketEvents::ThreadProc

refs #11014

8 years agoRemove debug output
Gunnar Beutner [Thu, 28 Jan 2016 11:23:07 +0000 (12:23 +0100)]
Remove debug output

refs #11014

8 years agoAvoid unnecessary wake-ups in SocketEvents::ChangeEvents (part 2)
Gunnar Beutner [Thu, 28 Jan 2016 10:55:31 +0000 (11:55 +0100)]
Avoid unnecessary wake-ups in SocketEvents::ChangeEvents (part 2)

refs #11014

8 years agoAvoid updating the file descriptor list for poll() unless we really need to
Gunnar Beutner [Thu, 28 Jan 2016 06:19:32 +0000 (07:19 +0100)]
Avoid updating the file descriptor list for poll() unless we really need to

refs #11014

8 years agoDecode cluster messages in the WorkQueue threads
Gunnar Beutner [Wed, 27 Jan 2016 15:43:23 +0000 (16:43 +0100)]
Decode cluster messages in the WorkQueue threads

refs #11014

8 years agoUse multiple WorkQueues to process cluster messages
Gunnar Beutner [Wed, 27 Jan 2016 14:45:58 +0000 (15:45 +0100)]
Use multiple WorkQueues to process cluster messages

refs #11014

8 years agoImprove performance for ApiListener::RelayMessageOne
Gunnar Beutner [Wed, 27 Jan 2016 12:39:31 +0000 (13:39 +0100)]
Improve performance for ApiListener::RelayMessageOne

refs #11014

8 years agoImprove the performance for ApiListener::SyncRelayMessage (part 2)
Gunnar Beutner [Wed, 27 Jan 2016 11:18:16 +0000 (12:18 +0100)]
Improve the performance for ApiListener::SyncRelayMessage (part 2)

refs #11014

8 years agoImprove performance for ApiListener::SyncRelayMessage
Gunnar Beutner [Wed, 27 Jan 2016 07:43:20 +0000 (08:43 +0100)]
Improve performance for ApiListener::SyncRelayMessage

refs #11014

8 years agoIgnore the .timestamp file when determining whether the zone config has changed ...
Gunnar Beutner [Tue, 26 Jan 2016 14:42:54 +0000 (15:42 +0100)]
Ignore the .timestamp file when determining whether the zone config has changed (second attempt)

refs #11014

8 years agoIgnore the .timestamp file when determining whether the zone config has changed
Gunnar Beutner [Tue, 26 Jan 2016 10:32:54 +0000 (11:32 +0100)]
Ignore the .timestamp file when determining whether the zone config has changed

refs #11014

8 years agoMake sure the updated config sync works with old versions of Icinga 2
Gunnar Beutner [Tue, 26 Jan 2016 09:46:27 +0000 (10:46 +0100)]
Make sure the updated config sync works with old versions of Icinga 2

refs #11014

8 years agoMake sure the .timestamp file is synced for config updates
Gunnar Beutner [Tue, 26 Jan 2016 08:04:26 +0000 (09:04 +0100)]
Make sure the .timestamp file is synced for config updates

refs #11014

8 years agoFix cluster config timestamp again
Michael Friedrich [Mon, 25 Jan 2016 14:21:25 +0000 (15:21 +0100)]
Fix cluster config timestamp again

refs #11014

8 years agoFix cluster config sync timestamp
Michael Friedrich [Mon, 25 Jan 2016 13:25:37 +0000 (14:25 +0100)]
Fix cluster config sync timestamp

refs #11014

8 years agoMake sure we only have one connection per satellite
Gunnar Beutner [Mon, 25 Jan 2016 09:57:06 +0000 (10:57 +0100)]
Make sure we only have one connection per satellite

refs #11014

8 years agoUse MkDirP instead of MkDir when syncing zone configs
Gunnar Beutner [Tue, 26 Jan 2016 09:45:03 +0000 (10:45 +0100)]
Use MkDirP instead of MkDir when syncing zone configs

fixes #10932

8 years agoFix mongodb CheckCommand
Claudio Kuenzler [Mon, 18 Jan 2016 14:00:34 +0000 (15:00 +0100)]
Fix mongodb CheckCommand

Signed-off-by: Jean Flach <jean-marcel.flach@netways.de>
fixes #10979

8 years agoAdd timeout to snmpv3 check
Sebastian Brückner [Fri, 27 Nov 2015 13:50:15 +0000 (14:50 +0100)]
Add timeout to snmpv3 check

Signed-off-by: Jean Flach <jean-marcel.flach@netways.de>
fixes #10920

8 years agoReload logs after logrotate across distros
Lee Clemens [Wed, 20 Jan 2016 00:12:00 +0000 (19:12 -0500)]
Reload logs after logrotate across distros

Signed-off-by: Jean Flach <jean-marcel.flach@netways.de>
fixes #10935

8 years agoDocumentation: Fix missing SUSE repository for monitoring plugins
Michael Friedrich [Wed, 9 Dec 2015 14:33:31 +0000 (15:33 +0100)]
Documentation: Fix missing SUSE repository for monitoring plugins

fixes #10806

8 years agoDocumentation: Fix typos in troubleshooting.
Mathieu Lutfy [Wed, 23 Dec 2015 19:30:59 +0000 (14:30 -0500)]
Documentation: Fix typos in troubleshooting.

Signed-off-by: Jean Flach <jean-marcel.flach@netways.de>
fixes #10908

8 years agoOnly execute chcon if selinux is enabled and use full context
Dirk Goetz [Fri, 4 Dec 2015 14:49:36 +0000 (15:49 +0100)]
Only execute chcon if selinux is enabled and use full context

fixes #10773

8 years agoAdded exclude parameter in disk-windows CheckCommand
Eduard Güldner [Thu, 10 Dec 2015 17:01:01 +0000 (18:01 +0100)]
Added exclude parameter in disk-windows CheckCommand

Added missing command parameter in definition for disk-windows CheckCommand
in order to be able to exclude certain drives from being checked.
This parameter was addressed in feature #9201
Further details can be found in feature #10787

Signed-off-by: Jean Flach <jean-marcel.flach@netways.de>
fixes #10787

8 years agoUse a work queue for replaying the cluster log
Michael Friedrich [Wed, 25 Nov 2015 12:11:41 +0000 (13:11 +0100)]
Use a work queue for replaying the cluster log

refs #10713

8 years agoFix incorrect return value for ApiListener::GetInstance
Gunnar Beutner [Mon, 30 Nov 2015 14:31:11 +0000 (15:31 +0100)]
Fix incorrect return value for ApiListener::GetInstance

refs #10711

8 years agoImprove performance for Zone::CanAccessObject
Michael Friedrich [Tue, 24 Nov 2015 14:25:55 +0000 (15:25 +0100)]
Improve performance for Zone::CanAccessObject

fixes #10711

8 years agoDB IDO: Only update 'next_check' column when manually scheduling a check
Michael Friedrich [Fri, 22 Jan 2016 17:42:15 +0000 (18:42 +0100)]
DB IDO: Only update 'next_check' column when manually scheduling a check

Otherwise the changes from #7287 already take care of setting
the proper next check time from inside ProcessCheckResult().

There is no need to use the generic OnNextCheckChanged signal
but instead we're using a new one, locally just for DB IDO.

fixes #11019

8 years agoProperly set the next check time for active and passive checks
Michael Friedrich [Fri, 22 Jan 2016 17:40:14 +0000 (18:40 +0100)]
Properly set the next check time for active and passive checks

fixes #7287
refs #11019

8 years agoExternalCommandListener: Fix crash when reading from socket
Michael Friedrich [Wed, 20 Jan 2016 15:38:31 +0000 (16:38 +0100)]
ExternalCommandListener: Fix crash when reading from socket

refs #10700

8 years agoFix: Modified attributes do not work for the IcingaApplication object w/ external...
Michael Friedrich [Thu, 21 Jan 2016 18:07:54 +0000 (19:07 +0100)]
Fix: Modified attributes do not work for the IcingaApplication object w/ external commands

fixes #10974

8 years agoFix AUTHORS and .mailmap
Jean Flach [Mon, 18 Jan 2016 15:12:59 +0000 (16:12 +0100)]
Fix AUTHORS and .mailmap

A name appears twice

fixes #10981

8 years agoRaise a config error for "Checkable" objects in global zones
Michael Friedrich [Thu, 14 Jan 2016 14:33:28 +0000 (15:33 +0100)]
Raise a config error for "Checkable" objects in global zones

fixes #10807

8 years agodoc/5-advanced-topics: add example how to use custom functions in attributes
Simon Ruderich [Fri, 20 Nov 2015 15:22:28 +0000 (16:22 +0100)]
doc/5-advanced-topics: add example how to use custom functions in attributes

Signed-off-by: Jean Flach <jean-marcel.flach@netways.de>
fixes #10947

8 years agoAdd network.target to unit file
Lee Clemens [Wed, 13 Jan 2016 18:22:27 +0000 (13:22 -0500)]
Add network.target to unit file

Icinga2 fails with 'Cannot bind TCP socket for host',
if other services requiring network.target are not installed.

Signed-off-by: Jean Flach <jean-marcel.flach@netways.de>
fixes #10968

8 years agoTroubleshooting: Explain how to fetch the executed command
Michael Friedrich [Wed, 13 Jan 2016 15:48:43 +0000 (16:48 +0100)]
Troubleshooting: Explain how to fetch the executed command

fixes #10964

8 years agoFix incorrect is_active queries
Gunnar Beutner [Mon, 11 Jan 2016 13:23:16 +0000 (14:23 +0100)]
Fix incorrect is_active queries

fixes #10891

8 years agoBuild fix for Windows
Gunnar Beutner [Mon, 11 Jan 2016 13:28:58 +0000 (14:28 +0100)]
Build fix for Windows

fixes #10824

8 years agoChange B/s unit to B to comply with Nagios plugin spec
Per von Zweigbergk [Thu, 5 Nov 2015 16:27:41 +0000 (17:27 +0100)]
Change B/s unit to B to comply with Nagios plugin spec

Unfortunately B/s is not a valid unit in the Nagios plugin specification. As a bit of a sad workaround, we set the unit to B, which is technically incorrect, but we can't really do much about that without amending the spec...

fixes #10544

Signed-off-by: Jean Flach <jean-marcel.flach@netways.de>