]> granicus.if.org Git - php/log
php
4 years agoAdd zend_create_member_string() API
Nikita Popov [Tue, 14 Apr 2020 14:52:13 +0000 (16:52 +0200)]
Add zend_create_member_string() API

This is a recurring pattern.

4 years agoUse UNKNOWN default for socket_connect()
Nikita Popov [Tue, 14 Apr 2020 13:16:28 +0000 (15:16 +0200)]
Use UNKNOWN default for socket_connect()

Specifying the port is mandatory for INET sockets.

4 years agoFix socket_write() default value
Nikita Popov [Tue, 14 Apr 2020 13:14:40 +0000 (15:14 +0200)]
Fix socket_write() default value

4 years agoMerge branch 'PHP-7.4'
Nikita Popov [Tue, 14 Apr 2020 14:08:43 +0000 (16:08 +0200)]
Merge branch 'PHP-7.4'

* PHP-7.4:
  Don't leak peername if accept fails

4 years agoMerge branch 'PHP-7.3' into PHP-7.4
Nikita Popov [Tue, 14 Apr 2020 14:08:07 +0000 (16:08 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
  Don't leak peername if accept fails

4 years agoDon't leak peername if accept fails
Nikita Popov [Tue, 14 Apr 2020 14:05:57 +0000 (16:05 +0200)]
Don't leak peername if accept fails

Even if the accept fails, the peername may be populated.

4 years agoAdd Intl resource bundle files for big-endian architecture.
George Peter Banyard [Tue, 14 Apr 2020 11:56:48 +0000 (13:56 +0200)]
Add Intl resource bundle files for big-endian architecture.

Little and Big endian files have their own designated folder.
Both use the ASCII charset family.
We may want to add a big-endian/EBCDIC charset family resource bundle in the future.

The build script is currently left untouched as it seems to mostly be for Windows.

4 years agoImprove some TypeError and ValueError messages
Máté Kocsis [Mon, 13 Apr 2020 08:41:23 +0000 (10:41 +0200)]
Improve some TypeError and ValueError messages

Closes GH-5377

4 years agoAdded missed '~'
Dmitry Stogov [Tue, 14 Apr 2020 12:37:20 +0000 (15:37 +0300)]
Added missed '~'

4 years agoMerge branch 'PHP-7.4'
Christoph M. Becker [Tue, 14 Apr 2020 12:01:00 +0000 (14:01 +0200)]
Merge branch 'PHP-7.4'

* PHP-7.4:
  Fix test cases

4 years agoMerge branch 'PHP-7.3' into PHP-7.4
Christoph M. Becker [Tue, 14 Apr 2020 11:59:39 +0000 (13:59 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
  Fix test cases

4 years agoFix test cases
Christoph M. Becker [Tue, 14 Apr 2020 11:55:56 +0000 (13:55 +0200)]
Fix test cases

4 years agoGenerate method entries for ext/intl
Máté Kocsis [Sun, 12 Apr 2020 12:03:43 +0000 (14:03 +0200)]
Generate method entries for ext/intl

Closes GH-5370

4 years agoIncrease timeout on ubsan/asan job
Nikita Popov [Tue, 14 Apr 2020 10:52:24 +0000 (12:52 +0200)]
Increase timeout on ubsan/asan job

This one occasionally runs for more than 2:30 hours.

4 years agoMerge branch 'PHP-7.4'
Nikita Popov [Tue, 14 Apr 2020 10:02:04 +0000 (12:02 +0200)]
Merge branch 'PHP-7.4'

* PHP-7.4:
  Fixed bug #79468

4 years agoMerge branch 'PHP-7.3' into PHP-7.4
Nikita Popov [Tue, 14 Apr 2020 10:00:02 +0000 (12:00 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
  Fixed bug #79468

4 years agoFixed bug #79468
dinosaur [Mon, 13 Apr 2020 23:46:34 +0000 (07:46 +0800)]
Fixed bug #79468

Close the stream filter resources when removing them from the stream.

4 years agoRemove PDO::dbh_constructor()
Máté Kocsis [Tue, 14 Apr 2020 09:32:33 +0000 (11:32 +0200)]
Remove PDO::dbh_constructor()

4 years agoGenerate method entries from stubs for curl, ffi, pdo, phar
Máté Kocsis [Sun, 12 Apr 2020 16:50:41 +0000 (18:50 +0200)]
Generate method entries from stubs for curl, ffi, pdo, phar

Closes GH-5375

4 years agoGenerate function entries from stubs for a couple of extensions
Máté Kocsis [Mon, 13 Apr 2020 14:28:55 +0000 (16:28 +0200)]
Generate function entries from stubs for a couple of extensions

Migrates ext/standard, ext/tidy, ext/tokenizer,
ext/xml, ext/xml_reader, and ext/xml_writer. Closes GH-5381.

4 years agoSyntax errors caused by unclosed {, [, ( mention specific location
Alex Dowad [Wed, 8 Apr 2020 11:19:39 +0000 (13:19 +0200)]
Syntax errors caused by unclosed {, [, ( mention specific location

Aside from a few very specific syntax errors for which detailed exceptions are
thrown, generally PHP just emits the default error messages generated by bison on syntax
error. These messages are very uninformative; they just say "Unexpected ... at line ...".

This is most problematic with constructs which can span an arbitrary number of lines, such
as blocks of code delimited by { }, 'if' conditions delimited by ( ), and so on. If a closing
delimiter is missed, the block will run for the entire remainder of the source file (which
could be thousands of lines), and then at the end, a parse error will be thrown with the
dreaded words: "Unexpected end of file".

Therefore, track the positions of opening and closing delimiters and ensure that they match
up correctly. If any mismatch or missing delimiter is detected, immediately throw a parse
error which points the user to the offending line. This is best done in the *lexer* and not
in the parser.

Thanks to Nikita Popov and George Peter Banyard for suggesting improvements.

Fixes bug #79368.
Closes GH-5364.

4 years agoRemove int6store()
Nikita Popov [Tue, 14 Apr 2020 08:36:55 +0000 (10:36 +0200)]
Remove int6store()

The implementation is broken (syntactically). As it's not used
anyway, I'm just dropping it instead.

4 years agoMerge branch 'PHP-7.4'
Christoph M. Becker [Tue, 14 Apr 2020 06:57:29 +0000 (08:57 +0200)]
Merge branch 'PHP-7.4'

* PHP-7.4:
  Add NEWS entries [ci skip]

4 years agoMerge branch 'PHP-7.3' into PHP-7.4
Christoph M. Becker [Tue, 14 Apr 2020 06:55:48 +0000 (08:55 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
  Add NEWS entries [ci skip]

4 years agoAdd NEWS entries [ci skip]
Christoph M. Becker [Tue, 14 Apr 2020 06:53:35 +0000 (08:53 +0200)]
Add NEWS entries [ci skip]

4 years agoMerge branch 'PHP-7.4'
Stanislav Malyshev [Tue, 14 Apr 2020 04:09:23 +0000 (21:09 -0700)]
Merge branch 'PHP-7.4'

* PHP-7.4:
  Fix bug #79465 - use unsigneds as indexes.
  Fix bug #79330 - make all execution modes consistent in rejecting \0

4 years agoMerge branch 'PHP-7.3' into PHP-7.4
Stanislav Malyshev [Tue, 14 Apr 2020 04:09:15 +0000 (21:09 -0700)]
Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
  Fix bug #79465 - use unsigneds as indexes.
  Fix bug #79330 - make all execution modes consistent in rejecting \0

4 years agoMerge branch 'PHP-7.2' into PHP-7.3
Stanislav Malyshev [Tue, 14 Apr 2020 04:09:08 +0000 (21:09 -0700)]
Merge branch 'PHP-7.2' into PHP-7.3

* PHP-7.2:
  Fix bug #79465 - use unsigneds as indexes.
  Fix bug #79330 - make all execution modes consistent in rejecting \0

4 years agoFix bug #79465 - use unsigneds as indexes.
Stanislav Malyshev [Tue, 14 Apr 2020 04:07:04 +0000 (21:07 -0700)]
Fix bug #79465 - use unsigneds as indexes.

4 years agoFix bug #79330 - make all execution modes consistent in rejecting \0
Stanislav Malyshev [Tue, 14 Apr 2020 04:00:44 +0000 (21:00 -0700)]
Fix bug #79330 - make all execution modes consistent in rejecting \0

4 years agoFix [-Wchar-subscripts] in Hash extension
George Peter Banyard [Mon, 13 Apr 2020 18:25:22 +0000 (20:25 +0200)]
Fix [-Wchar-subscripts] in Hash extension

Use size_t type instead of char for string index.
Char may be unsigned on some platforms.

partial fix to bug 79431

4 years agoFix [-Werror=missing-braces] compiler warning
George Peter Banyard [Sun, 12 Apr 2020 16:23:54 +0000 (18:23 +0200)]
Fix [-Werror=missing-braces] compiler warning

Partial fix to bug 79431

4 years agoGenerate method entries for ext/session and ext/reflection
Máté Kocsis [Sun, 12 Apr 2020 17:53:32 +0000 (19:53 +0200)]
Generate method entries for ext/session and ext/reflection

Closes GH-5376

4 years agoGenerate method entries for ext/dom
Máté Kocsis [Sat, 11 Apr 2020 20:01:51 +0000 (22:01 +0200)]
Generate method entries for ext/dom

Closes GH-5374

4 years agoFix [-Wempty-body] compiler warning in Phar extension
George Peter Banyard [Sun, 12 Apr 2020 19:10:03 +0000 (21:10 +0200)]
Fix [-Wempty-body] compiler warning in Phar extension

4 years agoAdapt assertion as mbfl_strwidth returns a size_t
George Peter Banyard [Sun, 12 Apr 2020 17:34:05 +0000 (19:34 +0200)]
Adapt assertion as mbfl_strwidth returns a size_t

4 years agoGenerate method entries for ext/xsl
Máté Kocsis [Sat, 11 Apr 2020 23:49:13 +0000 (01:49 +0200)]
Generate method entries for ext/xsl

Closes GH-5372

4 years agoFix nullable types in PHPDoc
Máté Kocsis [Sat, 11 Apr 2020 22:25:33 +0000 (00:25 +0200)]
Fix nullable types in PHPDoc

4 years agoFix an undefined class error running gen_stub in php8
Tyson Andre [Sat, 11 Apr 2020 20:52:47 +0000 (16:52 -0400)]
Fix an undefined class error running gen_stub in php8

For whatever reason, php 8 would not have loaded the subsequent classes when
running `php build/gen_stub.php path/to/filename.php`.
I assume it didn't load the classes immediately because there's a possibility
the code before it would throw.
(Probably because __toString was added recently and prevents early binding)

Also, fix a typo

Closes GH-5369

4 years agoLowercase NULL to null in stubs
Máté Kocsis [Sat, 11 Apr 2020 12:13:11 +0000 (14:13 +0200)]
Lowercase NULL to null in stubs

4 years agoGenerate method entries from stubs for a couple of extensions
Máté Kocsis [Sat, 11 Apr 2020 11:27:04 +0000 (13:27 +0200)]
Generate method entries from stubs for a couple of extensions

Closes GH-5368

4 years agoAdd missing visibility modifiers in stubs
Máté Kocsis [Sat, 11 Apr 2020 08:23:51 +0000 (10:23 +0200)]
Add missing visibility modifiers in stubs

4 years agoAdd support for generating method entries from stubs
Máté Kocsis [Thu, 9 Apr 2020 09:27:20 +0000 (11:27 +0200)]
Add support for generating method entries from stubs

Closes GH-5363

4 years agoImprove the default value format in incompatible signature error messages
Máté Kocsis [Thu, 9 Apr 2020 07:46:44 +0000 (09:46 +0200)]
Improve the default value format in incompatible signature error messages

Closes GH-5361

4 years agoFix the default value of the $length parameter of grapheme_substr()
Máté Kocsis [Fri, 10 Apr 2020 16:04:17 +0000 (18:04 +0200)]
Fix the default value of the $length parameter of grapheme_substr()

4 years agoFix default value of the $class_name parameter of mysqli_fetch_object()
Máté Kocsis [Fri, 10 Apr 2020 16:03:20 +0000 (18:03 +0200)]
Fix default value of the $class_name parameter of mysqli_fetch_object()

4 years agoFix the default value of the $flags parameter of mysqli_begin_transaction()
Máté Kocsis [Fri, 10 Apr 2020 15:39:21 +0000 (17:39 +0200)]
Fix the default value of the $flags parameter of mysqli_begin_transaction()

4 years agoAdd missing parameter to the stub of mysqli_real_connect
Máté Kocsis [Fri, 10 Apr 2020 15:30:30 +0000 (17:30 +0200)]
Add missing parameter to the stub of mysqli_real_connect

4 years agoRefactor and remove dead code in mb_ereg(i)_replace
George Peter Banyard [Fri, 10 Apr 2020 15:54:59 +0000 (17:54 +0200)]
Refactor and remove dead code in mb_ereg(i)_replace

We do not support the 'e' option anymore.
Merged together code which would emit an error if this option is present.
This also makes it clearer that the whole branch in the replacement section supporting this option is never hit, thus removed.

4 years agoFix the default parameter values of stream_socket_client()
Máté Kocsis [Fri, 10 Apr 2020 15:17:12 +0000 (17:17 +0200)]
Fix the default parameter values of stream_socket_client()

$timeout and $flags were mixed up

4 years agoFix the default parameter values of session_set_save_handler()
Máté Kocsis [Fri, 10 Apr 2020 15:06:15 +0000 (17:06 +0200)]
Fix the default parameter values of session_set_save_handler()

Co-Authored-By: Christoph M. Becker <cmbecker69@gmx.de>
4 years agoSeparate zend_jit_dump_lifetime_interval() function
Dmitry Stogov [Fri, 10 Apr 2020 13:10:19 +0000 (16:10 +0300)]
Separate zend_jit_dump_lifetime_interval() function

4 years agoFixed overflow handling
Dmitry Stogov [Fri, 10 Apr 2020 11:42:26 +0000 (14:42 +0300)]
Fixed overflow handling

4 years agoRegister allocator refactoring
Dmitry Stogov [Thu, 9 Apr 2020 16:31:18 +0000 (19:31 +0300)]
Register allocator refactoring

4 years agoMark $time argument of touch() as UNKNOWN as well
Nikita Popov [Thu, 9 Apr 2020 14:50:46 +0000 (16:50 +0200)]
Mark $time argument of touch() as UNKNOWN as well

For some reason I thought that passing 0 is same as current time,
but that's not the case.

4 years agoMark spl_autoload_register function arg as UNKNOWN
Nikita Popov [Thu, 9 Apr 2020 14:47:39 +0000 (16:47 +0200)]
Mark spl_autoload_register function arg as UNKNOWN

Not passing any parameters to this function has magic behavior.

4 years agoFix mysqli_get_client_info() stub
Nikita Popov [Thu, 9 Apr 2020 14:42:26 +0000 (16:42 +0200)]
Fix mysqli_get_client_info() stub

The dummy link argument is not nullable.

4 years agoMark fgets() argument as UNKNOWN
Nikita Popov [Thu, 9 Apr 2020 14:21:48 +0000 (16:21 +0200)]
Mark fgets() argument as UNKNOWN

If no value is passed, this reads as much as necessary, not 1024
bytes.

4 years agoChange parameter default to always available value
Christoph M. Becker [Thu, 9 Apr 2020 12:51:55 +0000 (14:51 +0200)]
Change parameter default to always available value

`SIGTERM` is only defined in ext/pcntl, and as such never available on
Windows.  Moving the constant to ext/standard does not make much sense,
because that parameter is actually unused on Windows.  Therefore, we
use the magic number `15` instead, what is also done in the PHP manual.

4 years agoMake touch() $atime parameter UNKNOWN
Nikita Popov [Thu, 9 Apr 2020 14:06:37 +0000 (16:06 +0200)]
Make touch() $atime parameter UNKNOWN

The actual default here is $time, not 0.

4 years agoMark rand/mt_rand args as UNKNOWN
Nikita Popov [Thu, 9 Apr 2020 14:01:44 +0000 (16:01 +0200)]
Mark rand/mt_rand args as UNKNOWN

The second argument should be mt_getrandmax(), not PHP_INT_MAX.
Additionally this function only accepts either zero or two arguments,
so err on the side of being conservative and mark both UNKNOWN.

4 years agoMark array_walk $userdata arg as UNKNOWN
Nikita Popov [Thu, 9 Apr 2020 13:52:05 +0000 (15:52 +0200)]
Mark array_walk $userdata arg as UNKNOWN

It makes a difference whether this arg is not passed or is null.

4 years agoMake stream_socket_enable_crypto() session stream nullable
Nikita Popov [Thu, 9 Apr 2020 13:46:33 +0000 (15:46 +0200)]
Make stream_socket_enable_crypto() session stream nullable

4 years agoAccept null context in stream_socket_(client|server)
Nikita Popov [Thu, 9 Apr 2020 13:36:29 +0000 (15:36 +0200)]
Accept null context in stream_socket_(client|server)

4 years agoAdd Z_PARAM_RESOURCE_OR_NULL()
Nikita Popov [Thu, 9 Apr 2020 13:39:11 +0000 (15:39 +0200)]
Add Z_PARAM_RESOURCE_OR_NULL()

As a more explicit alternative to Z_PARAM_RESOURCE_EX(, 1, 0).

4 years agoExport the zend_string_concat3() API
Nikita Popov [Thu, 9 Apr 2020 13:06:53 +0000 (15:06 +0200)]
Export the zend_string_concat3() API

4 years agoExport API for fetching internal func default
Nikita Popov [Thu, 9 Apr 2020 12:55:55 +0000 (14:55 +0200)]
Export API for fetching internal func default

Make this functionality available outside reflection.

4 years agoFix typo (UNKOWN -> UNKNOWN)
Christoph M. Becker [Thu, 9 Apr 2020 12:06:11 +0000 (14:06 +0200)]
Fix typo (UNKOWN -> UNKNOWN)

4 years agoConvert if blocks to assertions and adapt stubs accordingly
George Peter Banyard [Wed, 8 Apr 2020 19:05:59 +0000 (21:05 +0200)]
Convert if blocks to assertions and adapt stubs accordingly

4 years agoCache MBFL encoding for Oniguruma regex functions.
George Peter Banyard [Mon, 6 Apr 2020 13:22:59 +0000 (15:22 +0200)]
Cache MBFL encoding for Oniguruma regex functions.

Closes GH-5355

4 years agocleanup
Dmitry Stogov [Thu, 9 Apr 2020 11:33:29 +0000 (14:33 +0300)]
cleanup

4 years agoDon't get number of passed arguments from "fake" INIT frames
Dmitry Stogov [Thu, 9 Apr 2020 10:38:40 +0000 (13:38 +0300)]
Don't get number of passed arguments from "fake" INIT frames

4 years agoFix #79462: method_exists and property_exists incoherent behavior
Christoph M. Becker [Thu, 9 Apr 2020 08:55:53 +0000 (10:55 +0200)]
Fix #79462: method_exists and property_exists incoherent behavior

Both functions are closely related, so should behave the same for wrong
input types, i.e. both should throw a TypeError.

4 years agoAdd test to make sure internal param default eval doesn't error
Nikita Popov [Thu, 9 Apr 2020 09:22:00 +0000 (11:22 +0200)]
Add test to make sure internal param default eval doesn't error

4 years agoMerge branch 'PHP-7.4'
Nikita Popov [Thu, 9 Apr 2020 08:35:50 +0000 (10:35 +0200)]
Merge branch 'PHP-7.4'

* PHP-7.4:
  Fixed bug #78434

4 years agoFixed bug #78434
Nikita Popov [Fri, 3 Apr 2020 08:06:41 +0000 (10:06 +0200)]
Fixed bug #78434

The DO_INIT flag, which will skip the first resume on a primed
generator, should always be set when starting to yield from a
new generator, not only when the yield from happens during priming.

4 years agoStore default parameter values of internal functions in arg info
Máté Kocsis [Mon, 6 Apr 2020 09:02:13 +0000 (11:02 +0200)]
Store default parameter values of internal functions in arg info

Closes GH-5353. From now on, PHP will have reflection information
about default values of parameters of internal functions.

Co-authored-by: Nikita Popov <nikita.ppv@gmail.com>
4 years agoMerge branch 'PHP-7.4'
Nikita Popov [Wed, 8 Apr 2020 15:11:50 +0000 (17:11 +0200)]
Merge branch 'PHP-7.4'

* PHP-7.4:
  Add php_cli_server_connect() helper

4 years agoAdd php_cli_server_connect() helper
Nikita Popov [Wed, 8 Apr 2020 15:10:20 +0000 (17:10 +0200)]
Add php_cli_server_connect() helper

To encapsulate the repeated fsockopen() code.

This gives us a chance to control the timeout in one place:
Raise it to one second.

4 years agoMerge branch 'PHP-7.4'
Nikita Popov [Wed, 8 Apr 2020 14:38:18 +0000 (16:38 +0200)]
Merge branch 'PHP-7.4'

* PHP-7.4:
  Make mysqli_poll test more deterministic

4 years agoMake mysqli_poll test more deterministic
Nikita Popov [Wed, 8 Apr 2020 14:36:01 +0000 (16:36 +0200)]
Make mysqli_poll test more deterministic

Handle errors appearing in different order.

4 years agoFix typo in GD stub
Nikita Popov [Wed, 8 Apr 2020 10:02:27 +0000 (12:02 +0200)]
Fix typo in GD stub

4 years agoUpdate mb_strrpos() stub
Nikita Popov [Wed, 8 Apr 2020 10:00:48 +0000 (12:00 +0200)]
Update mb_strrpos() stub

We no longer accept the encoding as 3rd param, so we can make this
a proper int argument.

4 years agoDump information about trace side exits
Dmitry Stogov [Wed, 8 Apr 2020 09:39:24 +0000 (12:39 +0300)]
Dump information about trace side exits

4 years agoMerge branch 'PHP-7.4'
Christoph M. Becker [Wed, 8 Apr 2020 09:35:28 +0000 (11:35 +0200)]
Merge branch 'PHP-7.4'

* PHP-7.4:
  Relax overly strict test expectation

4 years agoRelax overly strict test expectation
Christoph M. Becker [Wed, 8 Apr 2020 09:29:49 +0000 (11:29 +0200)]
Relax overly strict test expectation

There is no reason to expect a `1` after the PID; neither the session
ID nor the memory usage are required to contain one.  Actually, we just
want to verify here, that the process with the $child_pid is running,
and is a php.exe process.

4 years agoMerge branch 'PHP-7.4'
Christoph M. Becker [Wed, 8 Apr 2020 08:37:28 +0000 (10:37 +0200)]
Merge branch 'PHP-7.4'

* PHP-7.4:
  Fix memory leak introduced by fixing bug #78221

4 years agoMerge branch 'PHP-7.3' into PHP-7.4
Christoph M. Becker [Wed, 8 Apr 2020 08:36:57 +0000 (10:36 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
  Fix memory leak introduced by fixing bug #78221

4 years agoFix memory leak introduced by fixing bug #78221
Christoph M. Becker [Wed, 8 Apr 2020 08:35:54 +0000 (10:35 +0200)]
Fix memory leak introduced by fixing bug #78221

We have to free the retrieved text content; to keep the code readable,
we extract a helper function to check for empty nodes.  Unfortunately,
we cannot use xmlIsBlankNode(), because that also recognizes whitespace
only text content.

We also make sure to properly handle NULL returns from
xmlNodeGetContent().

4 years agoMerge branch 'PHP-7.4'
Nikita Popov [Wed, 8 Apr 2020 07:41:26 +0000 (09:41 +0200)]
Merge branch 'PHP-7.4'

* PHP-7.4:
  Fix test

4 years agoFix test
Nikita Popov [Wed, 8 Apr 2020 07:41:14 +0000 (09:41 +0200)]
Fix test

4 years agoUpdate stack type, only if necessary
Dmitry Stogov [Wed, 8 Apr 2020 07:34:24 +0000 (10:34 +0300)]
Update stack type, only if necessary

4 years agoFixed TYPE/INFO mismatch
Dmitry Stogov [Tue, 7 Apr 2020 21:27:19 +0000 (00:27 +0300)]
Fixed TYPE/INFO mismatch

4 years agoMerge branch 'PHP-7.4'
George Peter Banyard [Tue, 7 Apr 2020 20:49:17 +0000 (22:49 +0200)]
Merge branch 'PHP-7.4'

* PHP-7.4:
  Revert "Went to fast and forgot to update tests"
  Revert "Fix Bug #79448 0 is a valid Unicode codepoint, but mb_substitute_character(0) fails"

4 years agoMerge branch 'PHP-7.3' into PHP-7.4
George Peter Banyard [Tue, 7 Apr 2020 20:27:00 +0000 (22:27 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
  Revert "Went to fast and forgot to update tests"
  Revert "Fix Bug #79448 0 is a valid Unicode codepoint, but mb_substitute_character(0) fails"

4 years agoRevert "Went to fast and forgot to update tests"
George Peter Banyard [Tue, 7 Apr 2020 20:24:40 +0000 (22:24 +0200)]
Revert "Went to fast and forgot to update tests"

This reverts commit 656eac74fa6074aebc087bb73d2e4651f7dc8c9e.

4 years agoRevert "Fix Bug #79448 0 is a valid Unicode codepoint, but mb_substitute_character...
George Peter Banyard [Tue, 7 Apr 2020 20:23:24 +0000 (22:23 +0200)]
Revert "Fix Bug #79448 0 is a valid Unicode codepoint, but mb_substitute_character(0) fails"

This commit brings some substantial changes in behaviour due to the weird implementation.
This will be fixed in master due to BC concerns.

This reverts commit 1333b46d6dc0c293c1fd626803f91bc69743eb79.

4 years agocleanup
Dmitry Stogov [Tue, 7 Apr 2020 18:37:10 +0000 (21:37 +0300)]
cleanup

4 years agoRevert "cleanup" (wrong commit)
Dmitry Stogov [Tue, 7 Apr 2020 18:34:18 +0000 (21:34 +0300)]
Revert "cleanup" (wrong commit)

This reverts commit 5db5f71f2831df4d32484a5638f6f6aa72e364a5.

4 years agocleanup
Dmitry Stogov [Tue, 7 Apr 2020 18:30:47 +0000 (21:30 +0300)]
cleanup