]>
granicus.if.org Git - php/log
Sara Golemon [Tue, 7 Mar 2017 19:27:46 +0000 (11:27 -0800)]
Detect invalid port in xp_socket parse ip address
For historical reasons, fsockopen() accepts the port and hostname
separately: fsockopen('127.0.0.1', 80)
However, with the introdcution of stream transports in PHP 4.3,
it became possible to include the port in the hostname specifier:
fsockopen('127.0.0.1:80')
Or more formally: fsockopen('tcp://127.0.0.1:80')
Confusing results when these two forms are combined, however.
fsockopen('127.0.0.1:80', 443) results in fsockopen() attempting
to connect to '127.0.0.1:80:443' which any reasonable stack would
consider invalid.
Unfortunately, PHP parses the address looking for the first colon
(with special handling for IPv6, don't worry) and calls atoi()
from there. atoi() in turn, simply stops parsing at the first
non-numeric character and returns the value so far.
The end result is that the explicitly supplied port is treated
as ignored garbage, rather than producing an error.
This diff replaces atoi() with strtol() and inspects the
stop character. If additional "garbage" of any kind is found,
it fails and returns an error.
Nikita Popov [Tue, 7 Mar 2017 12:16:06 +0000 (13:16 +0100)]
Fix out of bounds access in gc_find_additional_buffer()
Dmitry Stogov [Fri, 3 Mar 2017 13:10:46 +0000 (16:10 +0300)]
Fixed file-cache (Zend/tests/unused_shared_static_variables.phpt)
Anatol Belski [Thu, 2 Mar 2017 19:45:15 +0000 (20:45 +0100)]
sync NEWS for bug #74159
Anatol Belski [Thu, 2 Mar 2017 19:27:27 +0000 (20:27 +0100)]
improve signal globals consistency check for TS
Seems when we receive TERM, TLS is destroyed completely. In that case,
not only signal globals, but the entire globals array doesn't exist
anymore.
Anatol Belski [Thu, 2 Mar 2017 15:39:32 +0000 (16:39 +0100)]
do not try to handle signals, when globals are inconsistent
somedaysummer [Fri, 27 Jan 2017 20:20:07 +0000 (15:20 -0500)]
PHP bug #74004
Fix for DOMDocument loadHTML and loadHTMLFile ignore LIBXML_NOWARNING
and LIBXML_NOERROR flags.
Derick Rethans [Thu, 2 Mar 2017 11:28:02 +0000 (11:28 +0000)]
Fixed tests after tzdb removed abbreviations
Derick Rethans [Thu, 2 Mar 2017 11:27:44 +0000 (11:27 +0000)]
Make sure we anchor this test to February
Mitch Hagstrand [Wed, 1 Mar 2017 23:08:59 +0000 (15:08 -0800)]
Fix bug73858.phpt to work in months without 31 days
Used hardcoded months in bug73858.phpt rather than the current and previous
month.
Christopher Jones [Thu, 2 Mar 2017 04:28:01 +0000 (15:28 +1100)]
Fixed bug #54379 (PDO_OCI: UTF-8 output gets truncated)
This was a modification of an incomplete PR #2276.
Derick Rethans [Wed, 1 Mar 2017 20:07:51 +0000 (20:07 +0000)]
Updated to version 2017.1 (2017a)
Remi Collet [Wed, 1 Mar 2017 16:01:58 +0000 (17:01 +0100)]
make type consistent with glob_t.gl_pathc
Sara Golemon [Wed, 22 Feb 2017 21:56:38 +0000 (13:56 -0800)]
Fix potential crash when setting invalid declare value
Using a non-literal expression in a declare value can cause the
compiler to crash trying to turn that AST node into a usable zval.
There was an existing test for such values using 'encoding',
but that didn't crash because it's handled by the lexer
rather than being compiled.
Trying to use a non-literal with ticks reproduces the crash.
Anatol Belski [Tue, 28 Feb 2017 08:46:11 +0000 (09:46 +0100)]
prepare next
Joe Watkins [Mon, 27 Feb 2017 19:21:10 +0000 (19:21 +0000)]
Revert "fix crash in phpdbg shutdown process when opcache is loaded"
This reverts commit
008fb28eafa3740b1e3696b1a5cf7566d493b97d .
Joe Watkins [Mon, 27 Feb 2017 17:54:48 +0000 (17:54 +0000)]
fix crash in phpdbg shutdown process when opcache is loaded
Nikita Popov [Sat, 25 Feb 2017 11:55:14 +0000 (12:55 +0100)]
Improve fix for bug #73807
At least on some architectures memmove() on FreeBSD does not
short-curcuit if src==dst. Check for it explicitly to avoid
quadratic copying.
Grundik [Sat, 18 Feb 2017 02:53:13 +0000 (05:53 +0300)]
Fix bug #73127
gost-crypto hash was incorrect if input data contained long 0xFF
sequence, due to a carry-propagation bug.
Anatol Belski [Fri, 24 Feb 2017 18:37:16 +0000 (19:37 +0100)]
Support run or test target invoked within debugger
Useful, as it gets all the environment produced by the makefile. For the
test target, it might make sense to have the child process debug plugin
for VS installed.
Aaron Piotrowski [Fri, 24 Feb 2017 04:24:59 +0000 (22:24 -0600)]
Update test for bug #74159
Aaron Piotrowski [Fri, 24 Feb 2017 03:10:14 +0000 (21:10 -0600)]
Update NEWS
Aaron Piotrowski [Fri, 24 Feb 2017 02:58:12 +0000 (20:58 -0600)]
Fix bug #74159
Thanks to @brzuchal for the patch to xp_ssl.c and @DaveRandom for helping debug the problem.
Xinchen Hui [Thu, 23 Feb 2017 04:33:17 +0000 (12:33 +0800)]
Fixed bug #74152 (if statement says true to a null variable)
Xinchen Hui [Thu, 23 Feb 2017 03:02:23 +0000 (11:02 +0800)]
Fixed bug #74148 (ReflectionFunction incorrectly reports the number of arguments)
Remi Collet [Tue, 21 Feb 2017 15:27:51 +0000 (16:27 +0100)]
report about OpenSSL 1.1 not supported during configure
Coenraad Loubser [Tue, 21 Feb 2017 02:02:22 +0000 (04:02 +0200)]
pull-request/2393:
stop make install from clobbering default dot d configuration
Dmitry Stogov [Tue, 21 Feb 2017 07:47:48 +0000 (10:47 +0300)]
too many dashes
Dmitry Stogov [Tue, 21 Feb 2017 07:41:20 +0000 (10:41 +0300)]
Increase WSDL cache version (7.0 wsdl cache is incomatible with PHP-5)
Include WSDL cache version number into file name
Remi Collet [Sun, 19 Feb 2017 16:02:00 +0000 (17:02 +0100)]
fix test for libzip 1.2.0
Anatol Belski [Sat, 18 Feb 2017 16:58:17 +0000 (17:58 +0100)]
initialize valid_symbol_table, important for the main thread
to prevent php_errormsg population on invalid symlol_table
Benjamin Robin [Wed, 15 Feb 2017 23:06:46 +0000 (00:06 +0100)]
Fixed bug #74105
If getrandom syscall is unavailable (ENOSYS), try to fallback on
/dev/urandom.
Ondřej Surý [Thu, 16 Feb 2017 07:57:30 +0000 (08:57 +0100)]
Disable RTLD_DEEPBIND when compiling with AddressSanitizer (-fsanitize=address).
The AddressSanitizer doesn't support RTLD_DEEPBIND resulting in
erratic errors when deinitializing phar module and possibly others.
Clang use __has_feature() macro to indicate compilation with
AddressSanitizer while gcc uses __SANITIZE_ADDRESS__ define.
Fixes bug #73677.
Nikita Popov [Thu, 16 Feb 2017 16:24:07 +0000 (17:24 +0100)]
Fix memory errors in url rewriter
Strings aren't terminated here...
Nikita Popov [Thu, 16 Feb 2017 15:59:17 +0000 (16:59 +0100)]
Fix autoload_func_info destruction
Can't reference the function ptr after the closure has been
destroyed.
Mitch Hagstrand [Thu, 16 Feb 2017 09:19:47 +0000 (01:19 -0800)]
Make the ftp and stream tests more reliable.
The tests can sometimes fail because it chooses a passive port for ftp that
is already in use. This makes the test attempt multiple times to find a free
port.
Nikita Popov [Thu, 16 Feb 2017 11:45:15 +0000 (12:45 +0100)]
Add json dep to test
Anatol Belski [Wed, 15 Feb 2017 15:33:49 +0000 (16:33 +0100)]
[ci skip] update NEWS
Anatol Belski [Wed, 15 Feb 2017 10:22:47 +0000 (11:22 +0100)]
Fixed bug #74090 stream_get_contents maxlength>-1 returns empty string
Xinchen Hui [Mon, 13 Feb 2017 11:16:17 +0000 (19:16 +0800)]
Fixed bug #73989 (PHP 7.1 Segfaults within Symfony test suite)
Nikita Popov [Sun, 12 Feb 2017 21:02:39 +0000 (22:02 +0100)]
Revert "Fixed bug #74035"
This reverts commit
9ffc6ca62f53431a4b32b30cdda8180142f47cdb .
Derick Rethans [Sun, 12 Feb 2017 20:17:01 +0000 (20:17 +0000)]
Upgrade timelib to 2017.01
This fixes:
- Fixed bug #72719 (Relative datetime format ignores weekday on sundays only).
- Fixed bug #73294 (DateTime wrong when date string is negative).
- Fixed bug #73489 (wrong timestamp when call setTimeZone multi times with UTC
offset).
- Fixed bug #73858 (first/last day of' flag is not being reset).
- Fixed bug #73942 ($date->modify('Friday this week') doesn't return a Friday
if $date is a Sunday).
- Fixed bug #74057 (wrong day when using "this week" in strtotime).
Xinchen Hui [Sun, 12 Feb 2017 12:34:08 +0000 (20:34 +0800)]
Fixed bug #74084 (Out of bound read - zend_mm_alloc_small)
andrewnester [Wed, 1 Feb 2017 10:43:55 +0000 (13:43 +0300)]
Fixed bug #74021
Xinchen Hui [Sun, 12 Feb 2017 10:55:19 +0000 (18:55 +0800)]
Fixed #73496 (Invalid memory access in zend_inline_hash_func)
no test script is added because it requre too much memory
Nikita Popov [Sat, 11 Feb 2017 23:19:17 +0000 (00:19 +0100)]
run-tests: Exit 1 on BORKED tests
Adam Saponara [Sat, 11 Feb 2017 04:58:25 +0000 (23:58 -0500)]
Fixed bug #73118
Denis Yeldandi [Thu, 9 Feb 2017 07:22:37 +0000 (10:22 +0300)]
Fixed bug #69860
Xinchen Hui [Fri, 10 Feb 2017 16:01:09 +0000 (00:01 +0800)]
Fixed typo
Xinchen Hui [Fri, 10 Feb 2017 06:24:01 +0000 (14:24 +0800)]
Fixed bug #74019 (Segfault with list)
Zheng SHAO [Wed, 18 Jan 2017 09:50:21 +0000 (18:50 +0900)]
Fixed bug #61471
dreamsxin [Tue, 7 Feb 2017 03:36:22 +0000 (11:36 +0800)]
Add #ifndef restrict
Christian Schmidt [Thu, 2 Feb 2017 17:52:27 +0000 (18:52 +0100)]
Fix detection of isnan and isinf
The isnan() and isinf() are C99 macros not functions.
Also fix is_infinite(-INF) in case isinf is not defined.
Anatol Belski [Tue, 7 Feb 2017 12:16:30 +0000 (13:16 +0100)]
use some dynamically generated NAN as well
Anatol Belski [Tue, 7 Feb 2017 11:01:14 +0000 (12:01 +0100)]
switch to smart str conversion routine to hide exact NAN type
see https://github.com/php/php-src/pull/2356#issuecomment-
277564135
Nikita Popov [Mon, 6 Feb 2017 00:45:53 +0000 (01:45 +0100)]
Revert "Fix detection of isnan and isinf"
This reverts commit
9ea0949f43959ff0cf519e7a10ef9de7a538cde3 .
Christian Schmidt [Thu, 2 Feb 2017 17:52:27 +0000 (18:52 +0100)]
Fix detection of isnan and isinf
The isnan() and isinf() are C99 macros not functions.
Also fix is_infinite(-INF) in case isinf is not defined.
Andrea Faulds [Sun, 5 Feb 2017 01:30:20 +0000 (01:30 +0000)]
Fix bug #73954
Nikita Popov [Fri, 3 Feb 2017 17:41:36 +0000 (18:41 +0100)]
Revert "Merge branch 'pull-request/2344' into PHP-7.0"
This reverts commit
6988d070ea8c7d44452d8c98e594d65ea722a1d8 , reversing
changes made to
75ad2b301a047209e7b5a6b5912eb589cfbc773d .
andrewnester [Fri, 3 Feb 2017 08:57:16 +0000 (11:57 +0300)]
Fixed bug #74035
Joe Watkins [Fri, 3 Feb 2017 06:10:19 +0000 (06:10 +0000)]
Merge branch 'pull-request/2344' into PHP-7.0
* pull-request/2344:
Fixed bug #74004 LIBXML_NOWARNING (etc) ignored by DOMDocument::loadHTML
somedaysummer [Fri, 27 Jan 2017 20:20:07 +0000 (15:20 -0500)]
Fixed bug #74004 LIBXML_NOWARNING (etc) ignored by DOMDocument::loadHTML
Joe Watkins [Fri, 3 Feb 2017 06:00:34 +0000 (06:00 +0000)]
Merge branch 'pull-request/2359' into PHP-7.0
* pull-request/2359:
increase wait time in timeout_variation_9.phpt by 1 second
Rodrigo Prado [Wed, 1 Feb 2017 23:12:05 +0000 (21:12 -0200)]
increase wait time in timeout_variation_9.phpt by 1 second
Joe Watkins [Fri, 3 Feb 2017 05:54:50 +0000 (05:54 +0000)]
Merge branch 'pull-request/2360' into PHP-7.0
* pull-request/2360:
increase wait time in timeout_variation_10.phpt by 1 second
Rodrigo Prado [Wed, 1 Feb 2017 23:22:35 +0000 (15:22 -0800)]
increase wait time in timeout_variation_10.phpt by 1 second
Mitch Hagstrand [Tue, 31 Jan 2017 17:25:05 +0000 (09:25 -0800)]
BUG #73998: Numeric properties are not accessible from get_object_vars
Matěj Humpál [Thu, 2 Feb 2017 09:24:00 +0000 (10:24 +0100)]
Fix bug #74031
Fix incorrect parameter count for imagepng function
Nikita Popov [Thu, 2 Feb 2017 15:04:02 +0000 (16:04 +0100)]
Fix bug #73807
Anatol Belski [Thu, 2 Feb 2017 13:19:35 +0000 (14:19 +0100)]
[ci skip] update NEWS
Anatol Belski [Thu, 2 Feb 2017 11:48:12 +0000 (12:48 +0100)]
Fixed #74022 PHP Fast CGI crashes when reading from a pfx file.
Anatol Belski [Thu, 2 Feb 2017 00:33:41 +0000 (01:33 +0100)]
update NEWS
Anatol Belski [Wed, 1 Feb 2017 19:00:32 +0000 (20:00 +0100)]
sync NEWS with the reverted stuff
Anatol Belski [Wed, 1 Feb 2017 18:59:24 +0000 (19:59 +0100)]
Revert "fixed bug #50989 (DOM support for LIBXML_NOXMLDECL)"
This reverts commit
2fcf1259c6a9c1d70bcdfb96aeabc54c47e2a4a0 .
Anatol Belski [Wed, 1 Feb 2017 18:59:18 +0000 (19:59 +0100)]
Revert "fix BC break introduced by #2346 (sebastianbergmann/phpunit#2454)"
This reverts commit
62938bf08806129b42b17e74d79a450c30d4ff30 .
Dmitry Stogov [Wed, 1 Feb 2017 14:36:55 +0000 (17:36 +0300)]
typo
Dmitry Stogov [Wed, 1 Feb 2017 13:05:33 +0000 (16:05 +0300)]
fixed macro
Anatol Belski [Wed, 1 Feb 2017 12:43:33 +0000 (13:43 +0100)]
fix possible NULL dereference
Anatol Belski [Wed, 1 Feb 2017 11:49:32 +0000 (12:49 +0100)]
remove unused var
Anatol Belski [Wed, 1 Feb 2017 11:45:19 +0000 (12:45 +0100)]
use zend_string API
Anatol Belski [Wed, 1 Feb 2017 11:36:14 +0000 (12:36 +0100)]
Fixed bug #74005 mail.add_x_header causes RFC-breaking lone line feed
Anatol Belski [Wed, 1 Feb 2017 10:59:44 +0000 (11:59 +0100)]
Merge branch 'PHP-5.6' into PHP-7.0
* PHP-5.6:
fix test for 32bits (int -> float)
Remi Collet [Wed, 1 Feb 2017 09:25:30 +0000 (10:25 +0100)]
fix test for 32bits (int -> float)
(cherry picked from commit
0f1ae93bfa2feb3d0fd0b8d3036148df8ef856e2 )
Remi Collet [Wed, 1 Feb 2017 09:25:30 +0000 (10:25 +0100)]
fix test for 32bits (int -> float)
Anatol Belski [Tue, 31 Jan 2017 17:25:36 +0000 (18:25 +0100)]
add a primitive debug facility to sendmail
Anatol Belski [Tue, 31 Jan 2017 13:21:20 +0000 (14:21 +0100)]
Anatol Belski [Tue, 31 Jan 2017 10:18:23 +0000 (11:18 +0100)]
bump versions for next in dev
Rodrigo Prado [Mon, 30 Jan 2017 22:06:09 +0000 (20:06 -0200)]
removed additional ";" from run-tests.php
Anatol Belski [Mon, 30 Jan 2017 21:34:14 +0000 (22:34 +0100)]
update NEWS
Sara Golemon [Mon, 30 Jan 2017 16:57:17 +0000 (08:57 -0800)]
Securely zero the hash context key
Anatol Belski [Mon, 30 Jan 2017 11:25:50 +0000 (12:25 +0100)]
Fixed bug #73983 crash on finish work with phar in cli + opcache
The file_cache_only option causes the storage to be per process,
furthermore the arena is destroyed per request. Thus, zend_string's
can't survive between request and the permanent flag should not
be set. This is already done with the file cache part, but the
persistency part is used in various scenarios and should respect
this case as well. In this particular bug, the pcre pattern cache
needs to survive between requests and uses pattern strings as hash
keys. One more case relevant here would be various situations where
the flow disables the use of shared memory.
Joe Watkins [Mon, 30 Jan 2017 11:26:02 +0000 (11:26 +0000)]
Merge branch 'pull-request/2348' into PHP-7.0
* pull-request/2348:
fix BC break introduced by #2346 (sebastianbergmann/phpunit#2454)
jhdxr [Mon, 30 Jan 2017 09:48:00 +0000 (17:48 +0800)]
fix BC break introduced by #2346 (sebastianbergmann/phpunit#2454)
Anatol Belski [Mon, 30 Jan 2017 10:40:23 +0000 (11:40 +0100)]
move id initialization into ctor
Anatol Belski [Mon, 30 Jan 2017 00:54:36 +0000 (01:54 +0100)]
fix system id initialization for multiple threads
Jakub Zelenka [Sun, 29 Jan 2017 20:43:58 +0000 (20:43 +0000)]
Try fpm path for testing in sbin as it is default target
jhdxr [Sat, 28 Jan 2017 06:56:03 +0000 (14:56 +0800)]
fixed bug #50989 (DOM support for LIBXML_NOXMLDECL)
Mitch Hagstrand [Thu, 26 Jan 2017 10:24:07 +0000 (02:24 -0800)]
Fix 00version.phpt when commit message has multiple lines.
The environment variable "TRAVIS_COMMIT_MESSAGE" can contain multiple lines.
An example can be seen here https://travis-ci.org/php/php-src/jobs/
195465293
andrewnester [Tue, 24 Jan 2017 13:38:30 +0000 (16:38 +0300)]
Fixed #73973 - debug_zval_dump() assertion error for resource consts with --enable-debug
Joe Watkins [Thu, 26 Jan 2017 05:50:46 +0000 (05:50 +0000)]
[ci skip] news entry for PR #2337