Bruce Momjian [Fri, 23 Nov 2007 16:37:55 +0000 (16:37 +0000)]
Update text:
< * Prevent long-lived temporary tables from causing frozen-Xid advancement
> * Prevent long-lived temporary tables from causing frozen-xid advancement
>
> The problem is that autovacuum cannot vacuum them to set frozen xids;
> only the session that created them can do that.
>
>
>
Alvaro Herrera [Fri, 23 Nov 2007 01:46:34 +0000 (01:46 +0000)]
Fix buggy usage of vsnprintf in PL/Python by removing it altogether, instead
relying on stringinfo.c. This fixes a problem reported by Marko Kreen, but I
didn't use his patch, per subsequent discussion.
Tom Lane [Thu, 22 Nov 2007 19:40:25 +0000 (19:40 +0000)]
Actually ... it's pretty silly that parse_oper.c doesn't set up the
opfuncid of an OpExpr initially, considering that it has the information
at hand already. We'll still treat opfuncid as a cache rather than a
guaranteed-valid value, but this change saves one more syscache lookup
in the normal code path.
Tom Lane [Thu, 22 Nov 2007 19:09:23 +0000 (19:09 +0000)]
Save one syscache lookup when examining volatility or strictness of
OpExpr and related nodes. We're going to have to set the opfuncid of
such nodes eventually (if we haven't already), so we might as well
exploit the opportunity to cache the function OID. Buys back some
of the extra planner overhead noted by Guillaume Smet, though I still
need to fool with equivclass.c to really respond to that.
Tom Lane [Thu, 22 Nov 2007 17:47:28 +0000 (17:47 +0000)]
Prevent Perl from introducing a possibly-incompatible definition of type
"bool" into plperl.c. This has always been a hazard since Perl allows a
platform-specific choice to define bool as int rather than char, but
evidently this didn't happen on any platform we support ... until OS X 10.5.
Per report from Brandon Maust.
Back-patch as far as 8.0 --- a bit arbitrary, but it seems unlikely anyone
will be trying to port 7.x onto new platforms.
Tom Lane [Tue, 20 Nov 2007 23:14:41 +0000 (23:14 +0000)]
Fix bogus length calculation that could lead to crash if the string
happened to be right up against the end of memory, per report from
Matt Magoffin. While at it, avoid useless multiple copying of string
by not depending on xmlStrncatNew.
Andrew Dunstan [Tue, 20 Nov 2007 02:25:22 +0000 (02:25 +0000)]
Change descriptions of entity and tag objects to "XML entity" and "XML tag".
Allow tag and entity names that follow XML rules. Provide for hexadecimal
as well as decimal numeric entities. Adjust code names to coincide with
new descriptions.
Bruce Momjian [Tue, 20 Nov 2007 00:18:46 +0000 (00:18 +0000)]
Update COMMENT item:
< o Prevent COMMENT ON dbname from issuing a warning when loading
< into a database with a different name, perhaps using COMMENT ON
< CURRENT DATABASE
> o Change pg_dump so that a comment on the dumped database is
> applied to the loaded database, even if the database has a
> different name. This will require new backend syntax, perhaps
> COMMENT ON CURRENT DATABASE.
Bruce Momjian [Mon, 19 Nov 2007 23:48:46 +0000 (23:48 +0000)]
Update wording:
< o Allow COMMENT ON dbname to work when loading into a database
< with a different name, perhaps using COMMENT ON CURRENT
< DATABASE
> o Prevent COMMENT ON dbname from issuing a warning when loading
> into a database with a different name, perhaps using COMMENT ON
> CURRENT DATABASE
Tom Lane [Fri, 16 Nov 2007 21:55:59 +0000 (21:55 +0000)]
Improve GIN index build's tracking of memory usage by using
GetMemoryChunkSpace, not just the palloc request size. This brings the
allocatedMemory counter close enough to reality (as measured by
MemoryContextStats printouts) that I think we can get rid of the arbitrary
factor-of-2 adjustment that was put into the code initially. Given the
sensitivity of GIN build to work memory size, not using as much of work
memory as we're allowed to seems a pretty bad idea.
Tom Lane [Fri, 16 Nov 2007 21:50:06 +0000 (21:50 +0000)]
GIN index build's allocatedMemory counter needs to be long, not uint32.
Else, in a 64-bit machine with maintenance_work_mem set to above 4Gb,
the counter overflows and we never recognize having reached the
maintenance_work_mem limit. I believe this explains out-of-memory
failure recently reported by Sean Davis.
Tom Lane [Fri, 16 Nov 2007 19:53:50 +0000 (19:53 +0000)]
Repair still another bug in the btree page split WAL reduction patch:
it failed for splits of non-leaf pages because in such pages the first
data key on a page is suppressed, and so we can't just copy the first
key from the right page to reconstitute the left page's high key.
Problem found by Koichi Suzuki, patch by Heikki.
Tom Lane [Fri, 16 Nov 2007 00:34:54 +0000 (00:34 +0000)]
Add snb_ru_init(internal) to list of stub functions in tsearch2
compatibility module. Needed to support loading of 8.1-era tsearch2
configuration data.
Bruce Momjian [Fri, 16 Nov 2007 00:13:02 +0000 (00:13 +0000)]
Modify LOOPBYTE/LOOPBIT macros to be more logical; rather than have the
for() body passed as a parameter, make the macros act as simple headers
to code blocks.
Bruce Momjian [Thu, 15 Nov 2007 23:23:44 +0000 (23:23 +0000)]
Fix pgindent to properly handle 'else' and single-line comments on the
same line; previous fix was only partial. Re-run pgindent on files
that need it.
Tom Lane [Thu, 15 Nov 2007 20:36:40 +0000 (20:36 +0000)]
Prevent re-use of a deleted relation's relfilenode until after the next
checkpoint. This guards against an unlikely data-loss scenario in which
we re-use the relfilenode, then crash, then replay the deletion and
recreation of the file. Even then we'd be OK if all insertions into the
new relation had been WAL-logged ... but that's not guaranteed given all
the no-WAL-logging optimizations that have recently been added.
Patch by Heikki Linnakangas, per a discussion last month.
Tom Lane [Wed, 14 Nov 2007 23:43:27 +0000 (23:43 +0000)]
Add a rank/(rank+1) normalization option to ts_rank(). While the usefulness
of this seems a bit marginal, if it's useful enough to be shown in the manual
then we probably ought to support doing it without double evaluation of the
ts_rank function. Per my proposal earlier today.
Tom Lane [Wed, 14 Nov 2007 18:36:37 +0000 (18:36 +0000)]
Add an Accept parameter to "simple" dictionaries. The default of true
gives the old behavior; selecting false allows the dictionary to be used
as a filter ahead of other dictionaries, because it will pass on rather
than accept words that aren't in its stopword list.
Jan Urbanski
Magnus Hagander [Wed, 14 Nov 2007 14:25:55 +0000 (14:25 +0000)]
Add note about deprecating krb5 authentication in favour of GSSAPI,
per discussions (a long time ago). Documentation only, we keep full
support in the code.
Tom Lane [Wed, 14 Nov 2007 03:26:24 +0000 (03:26 +0000)]
Update discussion of tsearch2 migration. I'm not entirely sure about
the division of material between here and the tsearch2 contrib page,
but at least it's not obviously unfinished any more.
Tom Lane [Wed, 14 Nov 2007 02:36:43 +0000 (02:36 +0000)]
Move contrib docs to an appendix (next door to External Projects).
Change title to Additional Supplied Modules. Improve discussion of
how to build and install 'em.