]> granicus.if.org Git - postgresql/log
postgresql
14 years agoCentralize DML permissions-checking logic.
Robert Haas [Thu, 22 Jul 2010 00:47:59 +0000 (00:47 +0000)]
Centralize DML permissions-checking logic.

Remove bespoke code in DoCopy and RI_Initial_Check, which now instead
fabricate call ExecCheckRTPerms with a manufactured RangeTblEntry.
This is intended to make it feasible for an enhanced security provider
to actually make use of ExecutorCheckPerms_hook, but also has the
advantage that RI_Initial_Check can allow use of the fast-path when
column-level but not table-level permissions are present.

KaiGai Kohei.  Reviewed (in an earlier version) by Stephen Frost, and by me.
Some further changes to the comments by me.

14 years agoCVS test: please ignore
Bruce Momjian [Tue, 20 Jul 2010 18:38:53 +0000 (18:38 +0000)]
CVS test:  please ignore

Does modification just of CVS tag text cause an empty CVS diff for the commit?

14 years agoProperly replay CREATE TABLESPACE during crash recovery by deleting
Bruce Momjian [Tue, 20 Jul 2010 18:14:16 +0000 (18:14 +0000)]
Properly replay CREATE TABLESPACE during crash recovery by deleting
directory/symlink before creation.

Report from Tom Lane.

Backpatch to 9.0.

14 years agoHave \conninfo mention the port even for local sockets.
Robert Haas [Tue, 20 Jul 2010 14:14:30 +0000 (14:14 +0000)]
Have \conninfo mention the port even for local sockets.

Per discussion with David Christensen, there can be multiple
instances of PG accessible via local sockets, and you need the port
to see which one you're actually connected to.  David's original
patch worked this way, but I inadvertently ripped it out during
commit.

14 years agoAdd \conninfo command to psql, to show current connection info.
Robert Haas [Tue, 20 Jul 2010 03:54:19 +0000 (03:54 +0000)]
Add \conninfo command to psql, to show current connection info.

David Christensen. Reviewed by Steve Singer.  Some further changes by me.

14 years agoMake ECPG regression tests independent of standard_conforming_strings.
Robert Haas [Tue, 20 Jul 2010 01:57:19 +0000 (01:57 +0000)]
Make ECPG regression tests independent of standard_conforming_strings.

Per buildfarm, again.

14 years agoMake hstore regression tests independent of standard_conforming_strings.
Robert Haas [Tue, 20 Jul 2010 01:22:52 +0000 (01:22 +0000)]
Make hstore regression tests independent of standard_conforming_strings.

Per buildfarm.

14 years agoAdd restart_after_crash GUC.
Robert Haas [Tue, 20 Jul 2010 00:47:53 +0000 (00:47 +0000)]
Add restart_after_crash GUC.

Normally, we automatically restart after a backend crash, but in some
cases when PostgreSQL is invoked by clusterware it may be desirable to
suppress this behavior, so we provide an option which does this.
Since no existing GUC group quite fits, create a new group called
"error handling options" for this and the previously undocumented GUC
exit_on_error, which is now documented.

Review by Fujii Masao.

14 years agoChange the default value of standard_conforming_strings to on.
Robert Haas [Tue, 20 Jul 2010 00:34:44 +0000 (00:34 +0000)]
Change the default value of standard_conforming_strings to on.

This change should be publicized to driver maintainers at once and
release-noted as an incompatibility with previous releases.

14 years agoPortability fixes for Solaris for requirepeer feature patch
Peter Eisentraut [Mon, 19 Jul 2010 18:53:25 +0000 (18:53 +0000)]
Portability fixes for Solaris for requirepeer feature patch

per report from Dave Page

14 years agoRemove unnecessary "Not safe to send CSV data" complaint from elog.c's fallback
Tom Lane [Sun, 18 Jul 2010 23:43:32 +0000 (23:43 +0000)]
Remove unnecessary "Not safe to send CSV data" complaint from elog.c's fallback
path when CSV logging is configured but not yet operational.  It's sufficient
to send the message to stderr, as we were already doing, and the "Not safe"
gripe has already confused at least two core members ...

Backpatch to 9.0, but not further --- doesn't seem appropriate to change
this behavior in stable branches.

14 years agoAllow ORDER BY/GROUP BY/etc items to match targetlist items regardless of
Tom Lane [Sun, 18 Jul 2010 19:37:49 +0000 (19:37 +0000)]
Allow ORDER BY/GROUP BY/etc items to match targetlist items regardless of
any implicit casting previously applied to the targetlist item.  This is
reasonable because the implicit cast, by definition, wasn't written by the
user; so we are preserving the expected behavior that ORDER BY items match
textually equivalent tlist items.  The case never arose before because there
couldn't be any implicit casting of a top-level SELECT item before we process
ORDER BY etc.  But now it can arise in the context of aggregates containing
ORDER BY clauses, since the "targetlist" is the already-casted list of
arguments for the aggregate.  The net effect is that the datatype used for
ORDER BY/DISTINCT purposes is the aggregate's declared input type, not that
of the original input column; which is a bit debatable but not horrendous,
and to do otherwise would require major rework that doesn't seem justified.

Per bug #5564 from Daniel Grace.  Back-patch to 9.0 where aggregate ORDER BY
was implemented.

14 years agoFix up poor handling of unsupported-platform case in requirepeer patch.
Tom Lane [Sun, 18 Jul 2010 17:08:11 +0000 (17:08 +0000)]
Fix up poor handling of unsupported-platform case in requirepeer patch.

14 years agoFix thinko in recent patch: 'sock' should be 'conn->sock'.
Tom Lane [Sun, 18 Jul 2010 16:42:20 +0000 (16:42 +0000)]
Fix thinko in recent patch: 'sock' should be 'conn->sock'.

14 years agoAdd SO_PEERCRED check in new unix domain socket permission checking code.
Bruce Momjian [Sun, 18 Jul 2010 15:51:00 +0000 (15:51 +0000)]
Add SO_PEERCRED check in new unix domain socket permission checking code.

14 years agoAdd server authentication over Unix-domain sockets
Peter Eisentraut [Sun, 18 Jul 2010 11:37:26 +0000 (11:37 +0000)]
Add server authentication over Unix-domain sockets

This adds a libpq connection parameter requirepeer that specifies the user
name that the server process is expected to run under.

reviewed by KaiGai Kohei

14 years agoSimplify missing tablespace replay error hint message, but only in HEAD
Bruce Momjian [Sun, 18 Jul 2010 04:47:46 +0000 (04:47 +0000)]
Simplify missing tablespace replay error hint message, but only in HEAD
so we don't need to re-translate for 9.0.

14 years agoAdd a log_file_mode GUC that allows control of the file permissions set on
Tom Lane [Fri, 16 Jul 2010 22:25:51 +0000 (22:25 +0000)]
Add a log_file_mode GUC that allows control of the file permissions set on
log files created by the syslogger process.

In passing, make unix_file_permissions display its value in octal, same
as log_file_mode now does.

Martin Pihlak

14 years agoFix typo spotted by Thom Brown.
Heikki Linnakangas [Fri, 16 Jul 2010 11:35:40 +0000 (11:35 +0000)]
Fix typo spotted by Thom Brown.

14 years agoAdd a paragraph explaining what restartpoints are. Mention that
Heikki Linnakangas [Fri, 16 Jul 2010 11:20:23 +0000 (11:20 +0000)]
Add a paragraph explaining what restartpoints are. Mention that
wal_keep_segments does not take effect during recovery.

Fujii Masao

14 years agoAdd support for dividing money by money (yielding a float8 result) and for
Tom Lane [Fri, 16 Jul 2010 02:15:56 +0000 (02:15 +0000)]
Add support for dividing money by money (yielding a float8 result) and for
casting between money and numeric.

Andy Balholm, reviewed by Kevin Grittner

14 years agoRemove a sanity check in the exclusion-constraint code that prevented users
Tom Lane [Fri, 16 Jul 2010 00:45:30 +0000 (00:45 +0000)]
Remove a sanity check in the exclusion-constraint code that prevented users
from defining non-self-conflicting constraints.

Jeff Davis

Note: I (tgl) objected to removing this check in 9.0 on the grounds that it
was an important sanity check in new, poorly tested code.  However, it should
be all right to remove it for 9.1, since we'll get field testing from the
9.0 branch.

14 years agoRemove duplicate code in DefineOpFamily().
Tom Lane [Fri, 16 Jul 2010 00:13:23 +0000 (00:13 +0000)]
Remove duplicate code in DefineOpFamily().

The code was probably meant to be this way all along, since the subroutine
CreateOpFamily previously had only one caller.  But it wasn't.

KaiGai Kohei

14 years agoUse an <xref> for restore_command reference. Marko Tiikkaja
Tom Lane [Wed, 14 Jul 2010 22:04:21 +0000 (22:04 +0000)]
Use an <xref> for restore_command reference.  Marko Tiikkaja

14 years agoFix several problems in pg_dump's handling of SQL/MED objects, notably failure
Tom Lane [Wed, 14 Jul 2010 21:21:08 +0000 (21:21 +0000)]
Fix several problems in pg_dump's handling of SQL/MED objects, notably failure
to dump a PUBLIC user mapping correctly, as per bug #5560 from Shigeru Hanada.
Use the pg_user_mappings view rather than trying to access pg_user_mapping
directly, so that the code doesn't fail when run by a non-superuser.  And
clean up some minor carelessness such as unsafe usage of fmtId().

Back-patch to 8.4 where this code was added.

14 years agoAllow full SSL certificate verification (wherein libpq checks its host name
Tom Lane [Wed, 14 Jul 2010 17:09:45 +0000 (17:09 +0000)]
Allow full SSL certificate verification (wherein libpq checks its host name
parameter against server cert's CN field) to succeed in the case where
both host and hostaddr are specified.  As with the existing precedents
for Kerberos, GSSAPI, SSPI, it is the calling application's responsibility
that host and hostaddr match up --- we just use the host name as given.
Per bug #5559 from Christopher Head.

In passing, make the error handling and messages for the no-host-name-given
failure more consistent among these four cases, and correct a lie in the
documentation: we don't attempt to reverse-lookup host from hostaddr
if host is missing.

Back-patch to 8.4 where SSL cert verification was introduced.

14 years agoTeach EXPLAIN to print PARAM_EXEC Params as the referenced expressions,
Tom Lane [Tue, 13 Jul 2010 20:57:19 +0000 (20:57 +0000)]
Teach EXPLAIN to print PARAM_EXEC Params as the referenced expressions,
rather than just $N.  This brings the display of nestloop-inner-indexscan
plans back to where it's been, and incidentally improves the display of
SubPlan parameters as well.  In passing, simplify the EXPLAIN code by
having it deal primarily in the PlanState tree rather than separately
searching Plan and PlanState trees.  This is noticeably cleaner for
subplans, and about a wash elsewhere.

One small difference from previous behavior is that EXPLAIN will no longer
qualify local variable references in inner-indexscan plan nodes, since it
no longer sees such nodes as possibly referencing multiple tables.  Vars
referenced through PARAM_EXEC Params are still forcibly qualified, though,
so I don't think the display is any more confusing than before.  Adjust a
couple of examples in the documentation to match this behavior.

14 years agoOn Win32, pg_upgrade cannot sent any server log output to the log file
Bruce Momjian [Tue, 13 Jul 2010 20:03:32 +0000 (20:03 +0000)]
On Win32, pg_upgrade cannot sent any server log output to the log file
because of file access limitations on that platform.

14 years agoRemove incorrect email address for pg_upgrade bug reports.
Bruce Momjian [Tue, 13 Jul 2010 18:14:14 +0000 (18:14 +0000)]
Remove incorrect email address for pg_upgrade bug reports.

14 years agoIn pg_upgrade, report /bin directory checks independent of /data checks.
Bruce Momjian [Tue, 13 Jul 2010 18:09:55 +0000 (18:09 +0000)]
In pg_upgrade, report /bin directory checks independent of /data checks.

14 years agoPrint each test_fsync description while test is running, rather than at
Bruce Momjian [Tue, 13 Jul 2010 17:00:50 +0000 (17:00 +0000)]
Print each test_fsync description while test is running, rather than at
the end.

14 years agoIn pg_upgrade, prevent psql AUTOCOMMIT=off by not loading .psqlrc.
Bruce Momjian [Tue, 13 Jul 2010 15:56:53 +0000 (15:56 +0000)]
In pg_upgrade, prevent psql AUTOCOMMIT=off by not loading .psqlrc.

14 years agoOops, in the previous fix to prevent a cursor that's being used in a FOR
Heikki Linnakangas [Tue, 13 Jul 2010 09:02:30 +0000 (09:02 +0000)]
Oops, in the previous fix to prevent a cursor that's being used in a FOR
loop from being dropped, I missed subtransaction cleanup. Pinned portals
must be dropped at subtransaction cleanup just as they are at main
transaction cleanup.

Per bug #5556 by Robert Walker. Backpatch to 8.0, 7.4 didn't have
subtransactions.

14 years agoRestore pl/pgsql default install release note item.
Bruce Momjian [Mon, 12 Jul 2010 18:30:36 +0000 (18:30 +0000)]
Restore pl/pgsql default install release note item.

14 years ago9.0 release note improvements
Bruce Momjian [Mon, 12 Jul 2010 18:25:21 +0000 (18:25 +0000)]
9.0 release note improvements

Erik Rijkers

14 years agoSpellcheck 9.0 release notes.
Bruce Momjian [Mon, 12 Jul 2010 17:47:39 +0000 (17:47 +0000)]
Spellcheck 9.0 release notes.

14 years agoMake NestLoop plan nodes pass outer-relation variables into their inner
Tom Lane [Mon, 12 Jul 2010 17:01:06 +0000 (17:01 +0000)]
Make NestLoop plan nodes pass outer-relation variables into their inner
relation using the general PARAM_EXEC executor parameter mechanism, rather
than the ad-hoc kluge of passing the outer tuple down through ExecReScan.
The previous method was hard to understand and could never be extended to
handle parameters coming from multiple join levels.  This patch doesn't
change the set of possible plans nor have any significant performance effect,
but it's necessary infrastructure for future generalization of the concept
of an inner indexscan plan.

ExecReScan's second parameter is now unused, so it's removed.

14 years agoDocument bump of minor library version numbers.
Bruce Momjian [Mon, 12 Jul 2010 16:21:51 +0000 (16:21 +0000)]
Document bump of minor library version numbers.

14 years agoBump minor library version numbers, for 9.1 release.
Bruce Momjian [Mon, 12 Jul 2010 16:18:44 +0000 (16:18 +0000)]
Bump minor library version numbers, for 9.1 release.

14 years agoAdd a note about preferred window width to the section about code
Tom Lane [Sat, 10 Jul 2010 18:37:00 +0000 (18:37 +0000)]
Add a note about preferred window width to the section about code
formatting conventions.

14 years agoClarify that "psql -c" ignores psqlrc files.
Robert Haas [Sat, 10 Jul 2010 00:50:24 +0000 (00:50 +0000)]
Clarify that "psql -c" ignores psqlrc files.

Tim Landscheidt

14 years agoAvoid an Assert failure in deconstruct_array() by making get_attstatsslot()
Tom Lane [Fri, 9 Jul 2010 22:57:39 +0000 (22:57 +0000)]
Avoid an Assert failure in deconstruct_array() by making get_attstatsslot()
use the actual element type of the array it's disassembling, rather than
trusting the type OID passed in by its caller.  This is needed because
sometimes the planner passes in a type OID that's only binary-compatible
with the target column's type, rather than being an exact match.  Per an
example from Bernd Helmle.

Possibly we should refactor get_attstatsslot/free_attstatsslot to not expect
the caller to supply type ID data at all, but for now I'll just do the
minimum-change fix.

Back-patch to 7.4.  Bernd's test case only crashes back to 8.0, but since
these subroutines are the same in 7.4, I suspect there may be variant
cases that would crash 7.4 as well.

14 years agoFix ruleutils' get_variable() to print something useful for Vars referencing
Tom Lane [Fri, 9 Jul 2010 21:11:47 +0000 (21:11 +0000)]
Fix ruleutils' get_variable() to print something useful for Vars referencing
resjunk outputs of subquery tlists, instead of throwing an error.  Per bug
#5548 from Daniel Grace.

We might at some point find we ought to back-patch this further than 9.0,
but I think that such Vars can only occur as resjunk members of upper-level
tlists, in which case the problem can't arise because prior versions didn't
print resjunk tlist items in EXPLAIN VERBOSE.

14 years agoProperly report errno/out-of-disk-space error from pg_upgrade when in
Bruce Momjian [Fri, 9 Jul 2010 16:51:23 +0000 (16:51 +0000)]
Properly report errno/out-of-disk-space error from pg_upgrade when in
copy mode, per report from depstein@alliedtesting.com.

Patch suggestion from Magnus.

Backpatch to 9.0.X.

14 years agoAdd a hook in ExecCheckRTPerms().
Robert Haas [Fri, 9 Jul 2010 14:06:01 +0000 (14:06 +0000)]
Add a hook in ExecCheckRTPerms().

This hook allows a loadable module to gain control when table permissions
are checked.  It is expected to be used by an eventual SE-PostgreSQL
implementation, but there are other possible applications as well.  A
sample contrib module can be found in the archives at:

http://archives.postgresql.org/pgsql-hackers/2010-05/msg01095.php

Robert Haas and Stephen Frost

14 years agoStamp HEAD as 9.1devel.
Tom Lane [Fri, 9 Jul 2010 04:10:58 +0000 (04:10 +0000)]
Stamp HEAD as 9.1devel.
(And there was much rejoicing.)

14 years agotag beta3 REL9_0_BETA3
Marc G. Fournier [Fri, 9 Jul 2010 02:43:12 +0000 (02:43 +0000)]
tag beta3

14 years agoUpdate release notes for 9.0 beta 3.
Bruce Momjian [Thu, 8 Jul 2010 22:26:14 +0000 (22:26 +0000)]
Update release notes for 9.0 beta 3.

14 years agoSome small changes for plperl.sgml:
Peter Eisentraut [Thu, 8 Jul 2010 21:35:33 +0000 (21:35 +0000)]
Some small changes for plperl.sgml:
   - wrapped long code-lines, for pdf
   - typo

Erik Rijkers

14 years agoTranslation updates for 9.0beta3
Peter Eisentraut [Thu, 8 Jul 2010 21:32:28 +0000 (21:32 +0000)]
Translation updates for 9.0beta3

14 years agoMinor kibitzing on previous patch: no need to run check more than once.
Tom Lane [Thu, 8 Jul 2010 19:00:11 +0000 (19:00 +0000)]
Minor kibitzing on previous patch: no need to run check more than once.
(_PG_init should be called only once anyway, but as long as it's got an
internal guard against repeat calls, that should be in front of the
version check.)

14 years agoInstall safeguard against running PL/Python 2 and 3 in the same session
Peter Eisentraut [Thu, 8 Jul 2010 18:42:12 +0000 (18:42 +0000)]
Install safeguard against running PL/Python 2 and 3 in the same session

14 years agoDoc change: effected -> affected, per correction from Matthew Wakeling
Bruce Momjian [Thu, 8 Jul 2010 16:44:12 +0000 (16:44 +0000)]
Doc change:  effected -> affected, per correction from Matthew Wakeling

14 years agoAdd a cross-reference to precedence information to CREATE OPERATOR's
Tom Lane [Thu, 8 Jul 2010 16:30:13 +0000 (16:30 +0000)]
Add a cross-reference to precedence information to CREATE OPERATOR's
documentation.  Per suggestion from Marc Cousin.

14 years agoMake the Windows tcp keepalive support depend on the existance of the
Magnus Hagander [Thu, 8 Jul 2010 16:19:50 +0000 (16:19 +0000)]
Make the Windows tcp keepalive support depend on the existance of the
SIO_KEEPALIVE_VALS define instead of just WIN32, since MingW doesn't
support this API (yet?).

14 years agoUpdate obsolete comment. Noted by Josh Tolley.
Tom Lane [Thu, 8 Jul 2010 16:08:30 +0000 (16:08 +0000)]
Update obsolete comment.  Noted by Josh Tolley.

14 years agoFix variant float8 expected files to have exactly the expected spacing.
Tom Lane [Thu, 8 Jul 2010 15:15:05 +0000 (15:15 +0000)]
Fix variant float8 expected files to have exactly the expected spacing.
This wasn't important when we used diff's -w (--ignore-all-space) option
to compare regression result files, but it is now.  Per buildfarm member
canary, which evidently has been offline since we did that in November,
but came to life again today.

14 years agoAdd support for TCP keepalives on Windows, both for backend and the new
Magnus Hagander [Thu, 8 Jul 2010 10:20:14 +0000 (10:20 +0000)]
Add support for TCP keepalives on Windows, both for backend and the new
libpq support.

14 years agoFix "cannot handle unplanned sub-select" error that can occur when a
Tom Lane [Thu, 8 Jul 2010 00:14:04 +0000 (00:14 +0000)]
Fix "cannot handle unplanned sub-select" error that can occur when a
sub-select contains a join alias reference that expands into an expression
containing another sub-select.  Per yesterday's report from Merlin Moncure
and subsequent off-list investigation.

Back-patch to 7.4.  Older versions didn't attempt to flatten sub-selects in
ways that would trigger this problem.

14 years agoAdjust mbutils.c so it won't get broken by future pgindent runs.
Tom Lane [Wed, 7 Jul 2010 15:13:21 +0000 (15:13 +0000)]
Adjust mbutils.c so it won't get broken by future pgindent runs.
To do that, replace L'\0' by (WCHAR) 0.  Perhaps someday we should teach
pgindent about wide-character literals, but so long as this is the only
use-case in the entire Postgres sources, a workaround seems easier.

14 years agoDocument the interaction of write-barrier-enabled file systems, and BBU
Bruce Momjian [Wed, 7 Jul 2010 14:42:09 +0000 (14:42 +0000)]
Document the interaction of write-barrier-enabled file systems, and BBU
caches, per June email thread.

14 years agoMake log_temp_files based on kB, and revert docs & comments to match.
Robert Haas [Tue, 6 Jul 2010 22:55:26 +0000 (22:55 +0000)]
Make log_temp_files based on kB, and revert docs & comments to match.

Per extensive discussion on pgsql-hackers.  We are deliberately not
back-patching this even though the behavior of 8.3 and 8.4 is
unquestionably broken, for fear of breaking existing users of this
parameter.  This incompatibility should be release-noted.

14 years agoAccept slightly grotty coding in Makefile.global in order to keep the -L
Tom Lane [Tue, 6 Jul 2010 22:03:05 +0000 (22:03 +0000)]
Accept slightly grotty coding in Makefile.global in order to keep the -L
flag for src/port/ in front of any -L flags placed in LDFLAGS by configure.
This undoes an L-flag-ordering change that I had thought would be safe,
but seems to be making at least one buildfarm member fail --- the only
theory for orca's failure that I can think of is that it's got an old
copy of libpgport.a in /usr/lib.  Also allow for LDFLAGS_SL to be set by
contrib makefiles before they invoke Makefile.global.

14 years agoAdd note that using PL/Python 2 and 3 in the same session will probably crash
Peter Eisentraut [Tue, 6 Jul 2010 21:37:31 +0000 (21:37 +0000)]
Add note that using PL/Python 2 and 3 in the same session will probably crash

14 years agoSupport setting the keepalive idle time on MacOS X.
Robert Haas [Tue, 6 Jul 2010 21:14:25 +0000 (21:14 +0000)]
Support setting the keepalive idle time on MacOS X.

MacOS X uses TCP_KEEPALIVE rather than TCP_KEEPIDLE for this purpose.

Thanks to Fujii Masao for the review.

14 years agoUndo pgindent breakage (again). Per buildfarm.
Tom Lane [Tue, 6 Jul 2010 21:09:00 +0000 (21:09 +0000)]
Undo pgindent breakage (again).  Per buildfarm.

14 years agoMention why one C file fails pgindent.
Bruce Momjian [Tue, 6 Jul 2010 19:26:28 +0000 (19:26 +0000)]
Mention why one C file fails pgindent.

14 years agopgindent run for 9.0, second run
Bruce Momjian [Tue, 6 Jul 2010 19:19:02 +0000 (19:19 +0000)]
pgindent run for 9.0, second run

14 years agoUpdate pgindent testing instructions.
Bruce Momjian [Tue, 6 Jul 2010 19:18:19 +0000 (19:18 +0000)]
Update pgindent testing instructions.

14 years agoStill more third thoughts: when linking shared libraries, LDFLAGS probably
Tom Lane [Tue, 6 Jul 2010 03:55:33 +0000 (03:55 +0000)]
Still more third thoughts: when linking shared libraries, LDFLAGS probably
needs to appear before anything placed in SHLIB_LINK.  This is because
SHLIB_LINK is typically a subset of LIBS, and LIBS has to appear after
LDFLAGS on platforms that are sensitive to the relative order of -L and -l
switches.

14 years agoAllow for LDFLAGS_SL already having a value in Makefile.aix.
Tom Lane [Tue, 6 Jul 2010 03:41:02 +0000 (03:41 +0000)]
Allow for LDFLAGS_SL already having a value in Makefile.aix.
Per buildfarm results.

14 years agoDept. of third thoughts: PG_LIBS may contain a -L switch, so it had better
Tom Lane [Mon, 5 Jul 2010 23:40:13 +0000 (23:40 +0000)]
Dept. of third thoughts: PG_LIBS may contain a -L switch, so it had better
stay in front of LDFLAGS.

14 years agoMake sure LDFLAGS come before LIBS when linking contrib programs.
Tom Lane [Mon, 5 Jul 2010 23:30:50 +0000 (23:30 +0000)]
Make sure LDFLAGS come before LIBS when linking contrib programs.
Solaris, at least, seems to be sensitive to the relative order of -L
and -l switches, so this is needed.  Per buildfarm results.

14 years agoFix a few single-file (MODULES, not MODULE_big) contrib makefiles that were
Tom Lane [Mon, 5 Jul 2010 23:15:56 +0000 (23:15 +0000)]
Fix a few single-file (MODULES, not MODULE_big) contrib makefiles that were
supposing that they should set SHLIB_LINK rather than LDFLAGS_SL.  Since these
don't go through Makefile.shlib that was a no-op on most platforms.  Also
regularize the few platform-specific Makefiles that did pay attention to
SHLIB_LINK: it seems that the real value of that is to pull in BE_DLLLIBS,
so do that instead.  Per buildfarm failures on cygwin.

14 years agoSplit the LDFLAGS make variable into two parts: LDFLAGS is now used for
Tom Lane [Mon, 5 Jul 2010 18:54:38 +0000 (18:54 +0000)]
Split the LDFLAGS make variable into two parts: LDFLAGS is now used for
linking both executables and shared libraries, and we add on LDFLAGS_EX when
linking executables or LDFLAGS_SL when linking shared libraries.  This
provides a significantly cleaner way of dealing with link-time switches than
the former behavior.  Also, make sure that the various platform-specific
%.so: %.o rules incorporate LDFLAGS and LDFLAGS_SL; most of them missed that
before.  (I did not add these variables for the platforms that invoke $(LD)
directly, however.  It's not clear if we can do that safely, since for the
most part we assume these variables use CC command-line syntax.)

Per gripe from Aaron Swenson and subsequent investigation.

14 years agoThe previous fix in CVS HEAD and 8.4 for handling the case where a cursor
Heikki Linnakangas [Mon, 5 Jul 2010 09:27:18 +0000 (09:27 +0000)]
The previous fix in CVS HEAD and 8.4 for handling the case where a cursor
being used in a PL/pgSQL FOR loop is closed was inadequate, as Tom Lane
pointed out. The bug affects FOR statement variants too, because you can
close an implicitly created cursor too by guessing the "<unnamed portal X>"
name created for it.

To fix that, "pin" the portal to prevent it from being dropped while it's
being used in a PL/pgSQL FOR loop. Backpatch all the way to 7.4 which is
the oldest supported version.

14 years agoSimplify test_fsync duration computation.
Bruce Momjian [Sun, 4 Jul 2010 13:42:51 +0000 (13:42 +0000)]
Simplify test_fsync duration computation.

14 years agoReport test_fynsc times in tests per second, instead of total seconds.
Bruce Momjian [Sun, 4 Jul 2010 01:50:29 +0000 (01:50 +0000)]
Report test_fynsc times in tests per second, instead of total seconds.

14 years agoRemove SGML tab.
Bruce Momjian [Sat, 3 Jul 2010 22:52:25 +0000 (22:52 +0000)]
Remove SGML tab.

14 years agoDon't set recoveryLastXTime when replaying a checkpoint --- that was a bogus
Tom Lane [Sat, 3 Jul 2010 22:15:45 +0000 (22:15 +0000)]
Don't set recoveryLastXTime when replaying a checkpoint --- that was a bogus
idea from the start since the variable is only meant to track commit/abort
events.  This patch reverts the logic around the variable to what it was in
8.4, except that the value is now kept in shared memory rather than a static
variable, so that it can be reported correctly by CreateRestartPoint (which is
executed in the bgwriter).

14 years agoMake vacuum_defer_cleanup_age be PGC_SIGHUP level, since it's not sensible
Tom Lane [Sat, 3 Jul 2010 21:23:58 +0000 (21:23 +0000)]
Make vacuum_defer_cleanup_age be PGC_SIGHUP level, since it's not sensible
to have different values in different processes of the primary server.
Also put it into the "Streaming Replication" GUC category; it doesn't belong
in "Standby Servers" because you use it on the master not the standby.
In passing also correct guc.c's idea of wal_keep_segments' category.

14 years agoReplace max_standby_delay with two parameters, max_standby_archive_delay and
Tom Lane [Sat, 3 Jul 2010 20:43:58 +0000 (20:43 +0000)]
Replace max_standby_delay with two parameters, max_standby_archive_delay and
max_standby_streaming_delay, and revise the implementation to avoid assuming
that timestamps found in WAL records can meaningfully be compared to clock
time on the standby server.  Instead, the delay limits are compared to the
elapsed time since we last obtained a new WAL segment from archive or since
we were last "caught up" to WAL data arriving via streaming replication.
This avoids problems with clock skew between primary and standby, as well
as other corner cases that the original coding would misbehave in, such
as the primary server having significant idle time between transactions.
Per my complaint some time ago and considerable ensuing discussion.

Do some desultory editing on the hot standby documentation, too.

14 years agoDocument more clearly on XML namespaces inside xpath function
Bruce Momjian [Sat, 3 Jul 2010 17:21:48 +0000 (17:21 +0000)]
Document more clearly on XML namespaces inside xpath function

Nikolay Samokhvalov

14 years agoMake pg_upgrade copyrights just 2010, not 2010-2010.
Bruce Momjian [Sat, 3 Jul 2010 16:33:15 +0000 (16:33 +0000)]
Make pg_upgrade copyrights just 2010, not 2010-2010.

14 years agoAdd copyrights to pg_upgrade and pg_upgrade_tools files, per Tom.
Bruce Momjian [Sat, 3 Jul 2010 16:25:01 +0000 (16:25 +0000)]
Add copyrights to pg_upgrade and pg_upgrade_tools files, per Tom.

14 years agoAdd CVS tags to pg_upgrade and pg_upgrade_support files, per request
Bruce Momjian [Sat, 3 Jul 2010 14:23:14 +0000 (14:23 +0000)]
Add CVS tags to pg_upgrade and pg_upgrade_support files, per request
from Tom.

14 years agoAllow REASSIGNED OWNED to handle opclasses and opfamilies.
Robert Haas [Sat, 3 Jul 2010 13:53:13 +0000 (13:53 +0000)]
Allow REASSIGNED OWNED to handle opclasses and opfamilies.

Backpatch to 8.3, which is as far back as we have opfamilies.
The opclass portion could probably be backpatched to 8.2, when
REASSIGN OWNED was added, but for now I have not done that.

Asko Tiidumaa, with minor adjustments by me.

14 years agoFix assorted misstatements and poor wording in the descriptions of the I/O
Tom Lane [Sat, 3 Jul 2010 04:03:06 +0000 (04:03 +0000)]
Fix assorted misstatements and poor wording in the descriptions of the I/O
formats for geometric types.  Per bug #5536 from Jon Strait, and my own
testing.

Back-patch to all supported branches, since this doco has been wrong right
along -- we certainly haven't changed the I/O behavior of these types in
many years.

14 years agoAdditional cross-references to window functions documentation.
Robert Haas [Sat, 3 Jul 2010 02:57:46 +0000 (02:57 +0000)]
Additional cross-references to window functions documentation.

Erik Rijkers

14 years agoUnbreak MSVC builds by removing copydir.c from list of libpgport files
Andrew Dunstan [Fri, 2 Jul 2010 23:25:27 +0000 (23:25 +0000)]
Unbreak MSVC builds by removing copydir.c from list of libpgport files

14 years agoRemove hstore % text[] operator; use slice() function instead.
Robert Haas [Fri, 2 Jul 2010 20:36:49 +0000 (20:36 +0000)]
Remove hstore % text[] operator; use slice() function instead.

David Wheeler, with one small correction by me.

14 years agoMove copydir.c from src/port to src/backend/storage/file
Robert Haas [Fri, 2 Jul 2010 17:03:30 +0000 (17:03 +0000)]
Move copydir.c from src/port to src/backend/storage/file

The previous commit to make copydir() interruptible prevented
postgres.exe from linking on MinGW and Cygwin, because on those
platforms libpgport_srv.a can't freely reference symbols defined
by the backend.  Since that code is already backend-specific anyway,
just move the whole file into the backend rather than adding further
kludges to deal with the symbols needed by CHECK_FOR_INTERRUPTS().

This probably needs some further cleanup, but this commit just moves
the file as-is, which should hopefully be enough to turn the
buildfarm green again.

14 years agoIssue 'mkdir' hint when replying CREATE TABLESPACE in recovery mode.
Bruce Momjian [Fri, 2 Jul 2010 02:44:32 +0000 (02:44 +0000)]
Issue 'mkdir' hint when replying CREATE TABLESPACE in recovery mode.

Per idea from Fujii Masao

14 years agoAllow copydir() to be interrupted.
Robert Haas [Thu, 1 Jul 2010 20:12:40 +0000 (20:12 +0000)]
Allow copydir() to be interrupted.

This makes ALTER DATABASE .. SET TABLESPACE and CREATE DATABASE more
sensitive to interrupts.  Backpatch to 8.4, where ALTER DATABASE .. SET
TABLESPACE was introduced.  We could go back further, but in the absence
of complaints about the CREATE DATABASE case it doesn't seem worth it.

Guillaume Lelarge, with a small correction by me.

14 years agoGet rid of some more stuff that duplicates c.h or port.h.
Tom Lane [Thu, 1 Jul 2010 15:52:52 +0000 (15:52 +0000)]
Get rid of some more stuff that duplicates c.h or port.h.

14 years agoRemove port.h prototypes from pg_upgrade.h, per report from Robert Haas.
Bruce Momjian [Thu, 1 Jul 2010 14:37:53 +0000 (14:37 +0000)]
Remove port.h prototypes from pg_upgrade.h, per report from Robert Haas.

14 years agoAllow ALTER TABLE .. SET TABLESPACE to be interrupted.
Robert Haas [Thu, 1 Jul 2010 14:10:21 +0000 (14:10 +0000)]
Allow ALTER TABLE .. SET TABLESPACE to be interrupted.

Backpatch to 8.0, where tablespaces were introduced.

Guillaume Lelarge

14 years agoUpdate 9.0 release notes so streaming replication and hot standby is not
Bruce Momjian [Thu, 1 Jul 2010 02:33:21 +0000 (02:33 +0000)]
Update 9.0 release notes so streaming replication and hot standby is not
assumed to require continuous archiving.

Per report from Fujii Masao

14 years agostringToNode() and deparse_expression_pretty() crash on invalid input,
Heikki Linnakangas [Wed, 30 Jun 2010 18:10:23 +0000 (18:10 +0000)]
stringToNode() and deparse_expression_pretty() crash on invalid input,
but we have nevertheless exposed them to users via pg_get_expr(). It would
be too much maintenance effort to rigorously check the input, so put a hack
in place instead to restrict pg_get_expr() so that the argument must come
from one of the system catalog columns known to contain valid expressions.

Per report from Rushabh Lathia. Backpatch to 7.4 which is the oldest
supported version at the moment.

14 years agoCorrect missing/misspelled surname.
Andrew Dunstan [Wed, 30 Jun 2010 14:25:24 +0000 (14:25 +0000)]
Correct missing/misspelled surname.