Peter Eisentraut [Tue, 14 Aug 2018 08:27:29 +0000 (10:27 +0200)]
Travis CI: Run optscan.sh
Peter Eisentraut [Tue, 14 Aug 2018 08:27:02 +0000 (10:27 +0200)]
optscan.sh: exit 1 on error
Peter Eisentraut [Mon, 13 Aug 2018 06:56:22 +0000 (08:56 +0200)]
Update v1.9.0 release date
Peter Eisentraut [Mon, 13 Aug 2018 06:55:14 +0000 (08:55 +0200)]
Fix typo
Petr Jelinek [Fri, 3 Aug 2018 15:29:17 +0000 (17:29 +0200)]
Bump libusual
Petr Jelinek [Fri, 3 Aug 2018 14:18:11 +0000 (16:18 +0200)]
v1.9
Peter Eisentraut [Thu, 26 Jul 2018 10:03:45 +0000 (12:03 +0200)]
WAIT_CLOSE command
Peter Eisentraut [Wed, 25 Jul 2018 10:57:24 +0000 (12:57 +0200)]
Fast close
Disconnect a server in session pool mode immediately if it is in
"close_needed" (reconnect) mode. This ensures that the RECONNECT
command doesn't have to wait for session end.
Peter Eisentraut [Wed, 25 Jul 2018 09:18:01 +0000 (11:18 +0200)]
RECONNECT command
Peter Eisentraut [Wed, 25 Jul 2018 07:44:14 +0000 (09:44 +0200)]
Add close_needed column to SHOW SERVERS
This allows monitoring which server connections need reconnecting after
a configuration change.
Peter Eisentraut [Tue, 31 Jul 2018 22:24:15 +0000 (00:24 +0200)]
Improve whitespace
Peter Eisentraut [Mon, 30 Jul 2018 19:53:38 +0000 (21:53 +0200)]
Fix -Wimplicit-fallthrough warnings
in otherwise forgotten test program file
Peter Eisentraut [Mon, 30 Jul 2018 19:52:23 +0000 (21:52 +0200)]
Minor whitespace fix in log message
Peter Eisentraut [Sun, 29 Jul 2018 05:56:29 +0000 (07:56 +0200)]
test: Update MacOS firewall commands
Make commands in conntest.sh match the newer variants in test.sh. Also
add a missing sudo.
Peter Eisentraut [Fri, 27 Jul 2018 15:33:17 +0000 (17:33 +0200)]
doc: Clarify file descriptor formula
The previous phrasing made it look like max_pool_size etc. were
configuration settings. Perhaps this way it's a bit clearer.
fixes #190
Peter Eisentraut [Fri, 27 Jul 2018 12:59:53 +0000 (14:59 +0200)]
Make capitalization of log messages consistent
also minor typo and punctuation corrections
Peter Eisentraut [Thu, 26 Jul 2018 21:17:50 +0000 (23:17 +0200)]
Merge pull request #255 from eulerto/reserve-pool-fix
Fix reserve_pool parameter
Peter Eisentraut [Thu, 26 Jul 2018 19:39:26 +0000 (21:39 +0200)]
NEWS: Fix typos
fixes #296
Peter Eisentraut [Thu, 26 Jul 2018 19:13:50 +0000 (21:13 +0200)]
doc: Clarify documentation of server_lifetime
fixes #305
Peter Eisentraut [Thu, 26 Jul 2018 16:09:21 +0000 (18:09 +0200)]
doc: Document that KILL requires RESUME afterwards
fixes #310
Peter Eisentraut [Thu, 26 Jul 2018 11:56:30 +0000 (13:56 +0200)]
test.sh: Sort out netcat zoo
The previous code distinguished between Linux and non-Linux netcat.
This didn't stand the test of time, since Linux distributions now ship
multiple variants of netcat and other operating systems also provide
multiple options. So instead try to detect the variant from the help
output. Also, the previous uses of the -q and -w options behaved
strangely with some versions and/or were inconsistent with the
documentation. So abandon those options and just rely on the existing
killall call.
The test_server_connect_timeout_establish test should now pass again on
hopefully most configurations.
Peter Eisentraut [Wed, 25 Jul 2018 20:14:56 +0000 (22:14 +0200)]
Fix comments
Peter Eisentraut [Wed, 25 Jul 2018 20:11:23 +0000 (22:11 +0200)]
Improve punctuation in stats message
Peter Eisentraut [Wed, 25 Jul 2018 07:34:37 +0000 (09:34 +0200)]
Update code comment
Peter Eisentraut [Wed, 25 Jul 2018 07:33:37 +0000 (09:33 +0200)]
doc: Document reconnect behavior on reload and DNS change
This is long-standing behavior, just make the documentation about it
more explicit.
Peter Eisentraut [Tue, 24 Jul 2018 19:59:57 +0000 (21:59 +0200)]
doc: Add missing documentation for various SHOW fields
Various output fields from SHOW commands were not documented.
Peter Eisentraut [Tue, 24 Jul 2018 10:19:18 +0000 (12:19 +0200)]
Fix -Wimplicit-fallthrough warnings
These warnings started showing up with GCC 7. The code was already
correct, but the intent is now a bit clearer. Compilation with recent
GCCs should now be warning-free again.
Peter Eisentraut [Mon, 23 Jul 2018 11:24:38 +0000 (13:24 +0200)]
test: Restore userlist.txt after test run
Peter Eisentraut [Mon, 23 Jul 2018 11:00:45 +0000 (13:00 +0200)]
test.sh: Wrap all sudo calls in CAN_SUDO check
One call had been missed.
Peter Eisentraut [Mon, 23 Jul 2018 10:58:24 +0000 (12:58 +0200)]
.gitignore: Add test/pgdata/
Peter Eisentraut [Thu, 19 Jul 2018 16:32:04 +0000 (18:32 +0200)]
Correct list of required software
In particular, pkg-config is required for normal builds, not just from
Git.
Peter Eisentraut [Thu, 19 Jul 2018 16:24:04 +0000 (18:24 +0200)]
Normalize spelling of Git
Peter Eisentraut [Thu, 19 Jul 2018 16:18:13 +0000 (18:18 +0200)]
doc: Document SET command
Peter Eisentraut [Thu, 19 Jul 2018 12:54:17 +0000 (14:54 +0200)]
doc: Small improvement in quick start
Add an indication that the "SHOW HELP" example output is not complete.
Then we don't have to feel obliged to update it every time we add
something to the actual help output.
Petr Jelinek [Wed, 13 Jun 2018 21:16:34 +0000 (23:16 +0200)]
Merge pull request #301 from danielgustafsson/dg-null_deref
Fix a double-free and a NULL pointer deref
Daniel Gustafsson [Thu, 7 Jun 2018 21:04:29 +0000 (23:04 +0200)]
Avoid NULL pointer deref in parse_line
If we fail to calloc the rule buffer, going to failed: will deref
rule via the rule_free() call. Avoid by returning false directly
and bypass the failed: block.
Daniel Gustafsson [Thu, 7 Jun 2018 20:59:53 +0000 (22:59 +0200)]
Avoid double-free in parse_filename
If the fopen() call fails parse_namefile() frees the filename buffer
fn, and the caller does the same. Avoid freeing in parse_namefile()
and leave the cleanup to the caller.
Peter Eisentraut [Thu, 15 Mar 2018 17:20:20 +0000 (13:20 -0400)]
Fix whitespace errors reported by Git
Peter Eisentraut [Thu, 8 Mar 2018 22:18:13 +0000 (17:18 -0500)]
doc: Improve signals documentation
Add SIGUSR1 and SIGUSR2. Fix grammar a bit.
Peter Eisentraut [Wed, 27 Dec 2017 22:30:46 +0000 (17:30 -0500)]
Port mkauth.py to Python 3
fixes #263
Peter Eisentraut [Wed, 27 Dec 2017 00:31:22 +0000 (19:31 -0500)]
Travis CI: Test make deb target
Peter Eisentraut [Tue, 26 Dec 2017 21:55:08 +0000 (16:55 -0500)]
Fix mistake in test setup
This caused the test test_database_change to fail.
Peter Eisentraut [Tue, 26 Dec 2017 21:49:36 +0000 (16:49 -0500)]
Fix psql invocation in tests
Always run psql with -X, otherwise some tests fail if there is something
in .psqlrc producing output. Also fix some potential portability
problems in option syntax: Put non-option arguments last, don't mix
options with and without arguments.
Peter Eisentraut [Wed, 20 Dec 2017 13:32:23 +0000 (08:32 -0500)]
v1.8.1
Peter Eisentraut [Tue, 19 Dec 2017 23:43:44 +0000 (18:43 -0500)]
Travis CI: Add configure arguments matrix
Peter Eisentraut [Wed, 20 Dec 2017 00:09:41 +0000 (19:09 -0500)]
Travis CI: Convert script to single YAML block
Otherwise the scripts are all run independently of each other, which
doesn't make sense.
Peter Eisentraut [Tue, 19 Dec 2017 21:54:24 +0000 (16:54 -0500)]
Travis CI: Add test for building from dist tarball
Check that the distribution tarball can actually be built from, in case
it's missing a file. Also check `make install` while we're here.
Peter Eisentraut [Tue, 19 Dec 2017 23:15:25 +0000 (18:15 -0500)]
Add include/pam.h to distribution tarball
fixes #261
Peter Eisentraut [Tue, 19 Dec 2017 13:35:54 +0000 (08:35 -0500)]
v1.8
Peter Eisentraut [Tue, 19 Dec 2017 14:19:05 +0000 (09:19 -0500)]
doc: Fix rst syntax
Words ending in underscore are links. This confuses pandoc (for the web
site) (but apparently not rst2man). Escape with backslash to fix.
Petr Jelinek [Mon, 18 Dec 2017 21:08:12 +0000 (22:08 +0100)]
Display 0 ttl for stale DNS entries in SHOW DNS_HOSTS
Peter Eisentraut [Mon, 18 Dec 2017 16:34:58 +0000 (11:34 -0500)]
Travis CI: Add dist target to script
Peter Eisentraut [Mon, 18 Dec 2017 15:54:32 +0000 (10:54 -0500)]
Use strerror() instead of %m for portability
Peter Eisentraut [Sat, 16 Dec 2017 20:31:31 +0000 (15:31 -0500)]
Minor spelling and grammar improvements
Petr Jelinek [Fri, 15 Dec 2017 16:38:27 +0000 (17:38 +0100)]
Merge pull request #260 from petere/doc-fixes
detect and fix errors in documentation sources
Peter Eisentraut [Thu, 14 Dec 2017 19:14:34 +0000 (14:14 -0500)]
doc: Fix duplicate target name
Since there are two sections called "auth_user", we need to make one of
them an explicit target so we can link to it.
Peter Eisentraut [Thu, 14 Dec 2017 19:06:59 +0000 (14:06 -0500)]
doc: Catch warnings and errors from rst2man
Make rst2man exit with a non-zero exit status when there are warnings or
errors in the source.
Peter Eisentraut [Thu, 14 Dec 2017 19:03:00 +0000 (14:03 -0500)]
Travis CI: Add python-docutils as dependency
for rst2man
Peter Eisentraut [Thu, 14 Dec 2017 18:54:58 +0000 (13:54 -0500)]
Fix handling of absent rst2man
The makefile line
RST2MAN ?= rst2man
didn't have the desired effect, because config.mak sets RST2MAN, and ?=
doesn't do anything if the variable is set to empty. So instead let
configure put in a default value if the program cannot be found.
Peter Eisentraut [Wed, 6 Dec 2017 21:49:46 +0000 (16:49 -0500)]
Add Travis CI
Peter Eisentraut [Wed, 13 Dec 2017 18:40:52 +0000 (13:40 -0500)]
Merge pull request #257 from eulerto/default-values-fix
Use default values in config file
Peter Eisentraut [Wed, 13 Dec 2017 17:45:25 +0000 (12:45 -0500)]
Update libusual
Euler Taveira [Fri, 8 Dec 2017 22:00:24 +0000 (22:00 +0000)]
Use default values in config file
Instead of using arbritary values, use the default values. It is to
avoid surprises if you just remove comment character (;). I also did
some cosmetic changes. While at it, add some default information for
auth_user.
Euler Taveira [Fri, 8 Dec 2017 18:36:50 +0000 (18:36 +0000)]
Fix reserve_pool parameter
The correct per pool parameter is reserve_pool. The global parameter is named
reserve_pool_size.
While at it, document reserve_pool parameter.
Petr Jelinek [Fri, 8 Dec 2017 17:31:32 +0000 (18:31 +0100)]
Merge pull request #253 from eshkinkot/master
Receiving NotificationResponse asynchronously should not raise warning
Sergey Burladyan [Tue, 5 Dec 2017 14:02:19 +0000 (17:02 +0300)]
Receiving NotificationResponse asynchronously should not raise warning
Petr Jelinek [Sat, 4 Nov 2017 16:12:59 +0000 (17:12 +0100)]
Improve handling of auth_file cache and errors
Fixes #192
Petr Jelinek [Sat, 4 Nov 2017 15:18:20 +0000 (16:18 +0100)]
Improve the hba.conf parsing issue warning
This was added by
4f3dfc9, the wording was no ideal.
Petr Jelinek [Sat, 4 Nov 2017 15:17:16 +0000 (16:17 +0100)]
Merge pull request #243 from gplv2/master
add clues for sysadmin concerning HBA issues
Petr Jelinek [Sat, 4 Nov 2017 15:03:58 +0000 (16:03 +0100)]
Merge pull request #229 from petere/crash-fix
Fix crash from memory overrun
Petr Jelinek [Sat, 4 Nov 2017 13:13:11 +0000 (14:13 +0100)]
Merge pull request #235 from petere/pgbouncer-ini-auth-type
pgbouncer.ini: Add missing auth_type's to comment
Petr Jelinek [Sat, 4 Nov 2017 13:11:53 +0000 (14:11 +0100)]
Add STATS_TOTALS/STATS_AVERAGES into HELP
And separate the STATS* commands to it's own line.
Missed by
656844e
Petr Jelinek [Sat, 4 Nov 2017 13:00:19 +0000 (14:00 +0100)]
Merge pull request #238 from 'tvondra/statistics-fixes'
Track separate stats for queries and transactions
Glenn Plas [Mon, 23 Oct 2017 10:37:32 +0000 (12:37 +0200)]
add clues for sysadmin concerning HBA issues
Tomas Vondra [Sun, 24 Sep 2017 16:49:35 +0000 (18:49 +0200)]
Add SHOW STATS_TOTALS / STATS_AVERAGES as admin commands
We already had SHOW STATS, but after adding the wait_time colums it
got a bit too wide for regular screens. That's incovenient, as the
admin interface does not selecting only some of the columns.
But in most cases we're only interested either in totals or averages,
not both at the same time. So let's add commands showing only the
relevant subset of columns.
Tomas Vondra [Wed, 20 Sep 2017 21:22:39 +0000 (23:22 +0200)]
Track total time spent waiting for server
There already is maxwait column in pool details, showing how long
the oldest client is currently waiting. Which is useful, but it does
not allow us to easily break client time into the three basic
categories: busy, idle and waiting.
This adds tracking of total time spent waiting for a server, and
adds it as wait_time into SHOW STATS. The total value is simply
accumulated over time, the average value is 'per second' value.
The value is only updated when a client acquires a server, so if
a client is waiting indefinitely, the wait time won't be reflected
in the value. That would require inspecting the the list of waiting
clients, which seems like overkill. Moreover, that's what maxwait
is good for.
Tomas Vondra [Wed, 20 Sep 2017 19:00:17 +0000 (21:00 +0200)]
Track separate stats for queries and transactions
The documentation claimed avg_query tracks average query duration,
but it was only updated when switching into 'idle' state. So in
transaction or session pooling modes, it was actually the duration
of the whole transaction, including 'idle in transaction' time and
time spen executing (multiple) queries.
This was causing confusion, e.g. when the application was keeping
transactions open without executing any queries. In that case the
avg_query metric was increasing although the database was handling
queries just fine (without any slow-down).
Instead of just fixing the avg_query metric, it seems quite useful
to have timing data both for queries and transactions. So this
patch replaces
- total_query_time
- avg_query
with
- total_xact_time
- total_query_time
- avg_xact_time
- avg_query_time
This is also related to the definition of 'request' which was used
to compute the avg_query, and so it equal to a transaction. This
patch replaces the counter with two - one for transactions and one
for queries. As we also computed avg_req, the patch replaces
- total_requests
- avg_req
with
- total_xact_count
- total_query_time
- avg_xact_count
- avg_query_count
Note: This is likely to affect monitoring solutions, as the column
names in SHOW STATS change.
Peter Eisentraut [Fri, 11 Aug 2017 18:52:08 +0000 (14:52 -0400)]
Corrects bits vs bytes
Change "b/s" to "B/s", because the units are bytes.
Peter Eisentraut [Tue, 19 Sep 2017 16:10:55 +0000 (12:10 -0400)]
pgbouncer.ini: Add missing auth_type's to comment
Peter Eisentraut [Thu, 24 Aug 2017 17:11:03 +0000 (13:11 -0400)]
Fix crash from memory overrun
Fixes: #228
Marko Kreen [Sun, 9 Jul 2017 13:07:40 +0000 (16:07 +0300)]
Merge branch 'master' of https://github.com/pgbouncer/pgbouncer
Marko Kreen [Sun, 9 Jul 2017 13:06:41 +0000 (16:06 +0300)]
Merge pull request #217 from mnencia/patch-1
dns_zone_check_period is available also with c-ares backend
Marko Kreen [Sun, 9 Jul 2017 13:03:58 +0000 (16:03 +0300)]
Upgrade libusual
Marko Kreen [Sun, 9 Jul 2017 13:03:31 +0000 (16:03 +0300)]
Dont set flags when doing with-cares=auto
Marko Kreen [Sun, 9 Jul 2017 12:58:37 +0000 (15:58 +0300)]
Merge pull request #218 from mnencia/patch-2
Fix --with-cares=auto
Marko Kreen [Sun, 9 Jul 2017 12:56:50 +0000 (15:56 +0300)]
Merge pull request #219 from rubenv/patch-1
Add missing space
Ruben Vermeersch [Fri, 7 Jul 2017 08:42:08 +0000 (10:42 +0200)]
Add missing space
Turns this:
Stats: 21 req/s, in 579668 b/s, out 422757 b/s,query 84412 us
Into this:
Stats: 21 req/s, in 579668 b/s, out 422757 b/s, query 84412 us
Marco Nenciarini [Thu, 29 Jun 2017 12:01:33 +0000 (14:01 +0200)]
Fix --with-cares=auto
Marco Nenciarini [Thu, 29 Jun 2017 10:29:50 +0000 (12:29 +0200)]
dns_zone_check_period is available also with c-ares backend
Marko Kreen [Wed, 28 Jun 2017 15:21:27 +0000 (18:21 +0300)]
Merge pull request #196 from mhagander/auth_type_mode
Fix incorrect references to auth_mode
Marko Kreen [Wed, 28 Jun 2017 15:15:50 +0000 (18:15 +0300)]
Merge pull request #202 from gbartolini/dev/142
Global management of 'auth_user'
Marko Kreen [Wed, 28 Jun 2017 15:02:04 +0000 (18:02 +0300)]
Merge pull request #183 from jeduardo/master
Increased maximum length for postgres password
Marko Kreen [Wed, 28 Jun 2017 15:00:46 +0000 (18:00 +0300)]
Merge branch 'master' of https://github.com/pgbouncer/pgbouncer
Marko Kreen [Wed, 28 Jun 2017 14:58:51 +0000 (17:58 +0300)]
sbuf: check for EAGAIN in connect
seems it can be returned in win32
fixes: #188 #161
Marko Kreen [Wed, 28 Jun 2017 14:50:50 +0000 (17:50 +0300)]
hba: call next_token after parsing filename (#209)
Marko Kreen [Wed, 28 Jun 2017 14:48:30 +0000 (17:48 +0300)]
hba: parse_namefile did unnecessary free
Fixes: #209
Marko Kreen [Wed, 28 Jun 2017 14:38:16 +0000 (17:38 +0300)]
Merge pull request #213 from procore/add_client_wait_time
Add per-socket wait times to SHOW SOCKET.
Marko Kreen [Wed, 28 Jun 2017 14:37:55 +0000 (17:37 +0300)]
Merge pull request #212 from procore/add_maxwait_us
Add a maxwait microseconds column to SHOW POOLS.
Marko Kreen [Wed, 28 Jun 2017 14:35:21 +0000 (17:35 +0300)]
Merge pull request #214 from secwall/master
Fix memleak on pg_hba file reload
secwall [Sat, 10 Jun 2017 10:45:35 +0000 (13:45 +0300)]
Free user_name and db_name in hba rule_free to avoid memory leak on hba file reload