]> granicus.if.org Git - postgresql/log
postgresql
17 years agoFix seriously broken markup for libpq-envars cross-references.
Tom Lane [Mon, 26 Mar 2007 17:23:37 +0000 (17:23 +0000)]
Fix seriously broken markup for libpq-envars cross-references.

17 years agoAllow non-superuser database owners to create procedural languages.
Tom Lane [Mon, 26 Mar 2007 16:58:41 +0000 (16:58 +0000)]
Allow non-superuser database owners to create procedural languages.
A DBA is allowed to create a language in his database if it's marked
"tmpldbacreate" in pg_pltemplate.  The factory default is that this is set
for all standard trusted languages, but of course a superuser may adjust
the settings.  In service of this, add the long-foreseen owner column to
pg_language; renaming, dropping, and altering owner of a PL now follow
normal ownership rules instead of being superuser-only.
Jeremy Drake, with some editorialization by Tom Lane.

17 years agoAdd checking of end of line in parsing stopword list. Thanks to sharp eyes of Tom...
Teodor Sigaev [Mon, 26 Mar 2007 13:57:07 +0000 (13:57 +0000)]
Add checking of end of line in parsing stopword list. Thanks to sharp eyes of Tom lane

17 years agoFix stopword and synonym files parsing bug in MSVC build, per report from
Teodor Sigaev [Mon, 26 Mar 2007 12:25:35 +0000 (12:25 +0000)]
Fix stopword and synonym files parsing bug in MSVC build, per report from
Magnus Hagander. Also, now it ignores space symbol after stopwords.

17 years agoFix pg_wchar_table's maxmblen field of EUC_CN, EUC_TW, MULE_INTERNAL
Tatsuo Ishii [Mon, 26 Mar 2007 11:15:13 +0000 (11:15 +0000)]
Fix pg_wchar_table's maxmblen field of EUC_CN, EUC_TW, MULE_INTERNAL
and GB18030. patches from ITAGAKI Takahiro.

17 years agoSeems some people have been forgetting to run autoheader.
Tom Lane [Mon, 26 Mar 2007 02:38:22 +0000 (02:38 +0000)]
Seems some people have been forgetting to run autoheader.

17 years agoAdd -lcrypto as one of the possible link dependencies of libkrb5.
Tom Lane [Mon, 26 Mar 2007 02:37:17 +0000 (02:37 +0000)]
Add -lcrypto as one of the possible link dependencies of libkrb5.
Per report from Jim Rosenberg.  This possibly should get back-patched,
but I'm a bit suspicious of it still because of the lack of prior reports.

17 years agoRemove assertion that constraint_exclusion risks wrong answers if
Tom Lane [Mon, 26 Mar 2007 01:41:57 +0000 (01:41 +0000)]
Remove assertion that constraint_exclusion risks wrong answers if
table constraints are changed; this is no longer true now that we
have a plan invalidation mechanism.

17 years agoFix plancache's invalidation callback to do the right thing for a SI
Tom Lane [Mon, 26 Mar 2007 00:36:19 +0000 (00:36 +0000)]
Fix plancache's invalidation callback to do the right thing for a SI
reset event, namely invalidate everything.  This oversight probably
explains the rare failures that some buildfarm machines have been
showing for the plancache regression test.

17 years agoMake _SPI_execute_plan pass the query source string down to ProcessUtility
Tom Lane [Sun, 25 Mar 2007 23:42:43 +0000 (23:42 +0000)]
Make _SPI_execute_plan pass the query source string down to ProcessUtility
if possible.  I had left this undone in the first pass at the API change
for ProcessUtility, but forgot to revisit it after the plancache changes
made it possible to do it.

17 years agoRemove the prohibition on executing cursor commands through SPI_execute.
Tom Lane [Sun, 25 Mar 2007 23:27:59 +0000 (23:27 +0000)]
Remove the prohibition on executing cursor commands through SPI_execute.
Vadim had included this restriction in the original design of the SPI code,
but I'm darned if I can see a reason for it.

I left the macro definition of SPI_ERROR_CURSOR in place, so as not to
needlessly break any SPI callers that are checking for it, but that code
will never actually be returned anymore.

17 years agoClean up the representation of special snapshots by including a "method
Tom Lane [Sun, 25 Mar 2007 19:45:14 +0000 (19:45 +0000)]
Clean up the representation of special snapshots by including a "method
pointer" in every Snapshot struct.  This allows removal of the case-by-case
tests in HeapTupleSatisfiesVisibility, which should make it a bit faster
(I didn't try any performance tests though).  More importantly, we are no
longer violating portable C practices by assuming that small integers are
distinct from all pointer values, and HeapTupleSatisfiesDirty no longer
has a non-reentrant API involving side-effects on a global variable.

There were a couple of places calling HeapTupleSatisfiesXXX routines
directly rather than through the HeapTupleSatisfiesVisibility macro.
Since these places had to be changed anyway, I chose to make them go
through the macro for uniformity.

Along the way I renamed HeapTupleSatisfiesSnapshot to HeapTupleSatisfiesMVCC
to emphasize that it's only used with MVCC-type snapshots.  I was sorely
tempted to rename HeapTupleSatisfiesVisibility to HeapTupleSatisfiesSnapshot,
but forebore for the moment to avoid confusion and reduce the likelihood that
this patch breaks some of the pending patches.  Might want to reconsider
doing that later.

17 years agoAdd new encoding EUC_JIS_2004 and SHIFT_JIS_2004,
Tatsuo Ishii [Sun, 25 Mar 2007 11:56:04 +0000 (11:56 +0000)]
Add new encoding EUC_JIS_2004 and SHIFT_JIS_2004,
along with new conversions among EUC_JIS_2004, SHIFT_JIS_2004 and UTF-8.
catalog version has been bump up.

17 years agoAdd:
Bruce Momjian [Sun, 25 Mar 2007 02:21:19 +0000 (02:21 +0000)]
Add:

>
> * Allow BEFORE INSERT triggers on views
>
>   http://archives.postgresql.org/pgsql-general/2007-02/msg01466.php

17 years agoAdd:
Bruce Momjian [Sat, 24 Mar 2007 23:12:34 +0000 (23:12 +0000)]
Add:

>  o Add more logical syntax CLUSTER table ORDER BY index;
>    support current syntax for backward compatibility

17 years agoSupport for installing NLS files, and update support to use gettext
Magnus Hagander [Sat, 24 Mar 2007 22:16:49 +0000 (22:16 +0000)]
Support for installing NLS files, and update support to use gettext
from gnuwin32.

17 years agoDocument that LDAP URLs should be double-quoted in pg_hba.conf because
Bruce Momjian [Sat, 24 Mar 2007 21:46:23 +0000 (21:46 +0000)]
Document that LDAP URLs should be double-quoted in pg_hba.conf because
commas are often present in the URL.

Backpatch to 8.2.X.

17 years agoInstall contrib sql and readme files
Magnus Hagander [Sat, 24 Mar 2007 15:28:48 +0000 (15:28 +0000)]
Install contrib sql and readme files

17 years agoProperly parse the name of contrib modules that aren't named the same
Magnus Hagander [Sat, 24 Mar 2007 14:13:27 +0000 (14:13 +0000)]
Properly parse the name of contrib modules that aren't named the same
way as their directory (notably xml2/pgxml and intarray/_int)

17 years agoSet the node properly, per Tom.
Alvaro Herrera [Fri, 23 Mar 2007 21:57:10 +0000 (21:57 +0000)]
Set the node properly, per Tom.

17 years agoSeparate the code to start a new worker into its own function. The code is
Alvaro Herrera [Fri, 23 Mar 2007 21:45:17 +0000 (21:45 +0000)]
Separate the code to start a new worker into its own function.  The code is
exactly the same, modulo whitespace.

17 years agoSeparate fetch of pg_autovacuum tuple into its own function.
Alvaro Herrera [Fri, 23 Mar 2007 21:23:13 +0000 (21:23 +0000)]
Separate fetch of pg_autovacuum tuple into its own function.

17 years agoWe no longer need to palloc the VacuumStmt node; keeping it on the stack is
Alvaro Herrera [Fri, 23 Mar 2007 20:56:39 +0000 (20:56 +0000)]
We no longer need to palloc the VacuumStmt node; keeping it on the stack is
simpler.

17 years agoAdjust DatumGetBool macro so that it isn't fooled by garbage in the Datum
Tom Lane [Fri, 23 Mar 2007 20:24:41 +0000 (20:24 +0000)]
Adjust DatumGetBool macro so that it isn't fooled by garbage in the Datum
to the left of the actual bool value.  While in most cases there won't be
any, our support for old-style user-defined functions violates the C spec
to the extent of calling functions that might return char or short through
a function pointer declared to return "char *", which we then coerce to
Datum.  It is not surprising that the result might contain garbage
high-order bits ... what is surprising is that we didn't see such cases
long ago.  Per report from Magnus.

17 years agoFix plancache so that any required replanning is done with the same
Tom Lane [Fri, 23 Mar 2007 19:53:52 +0000 (19:53 +0000)]
Fix plancache so that any required replanning is done with the same
search_path that was active when the plan was first made.  To do this,
improve namespace.c to support a stack of "override" search path settings
(we must have a stack since nested replan events are entirely possible).
This facility replaces the "special namespace" hack formerly used by
CREATE SCHEMA, and should be able to support per-function search path
settings as well.

17 years agoAllow 4 bytes UTF-8 (UCS-4 range 00010000-001FFFFF)
Tatsuo Ishii [Fri, 23 Mar 2007 13:51:30 +0000 (13:51 +0000)]
Allow 4 bytes UTF-8 (UCS-4 range 00010000-001FFFFF)
This is necessary to support JIS X 0213 <--> UTF-8 conversion.

17 years agoForgot commit: support for special-cases in pgcrypto
Magnus Hagander [Fri, 23 Mar 2007 10:05:34 +0000 (10:05 +0000)]
Forgot commit: support for special-cases in pgcrypto

17 years agoSupport for running contribcheck on msvc
Magnus Hagander [Fri, 23 Mar 2007 09:57:55 +0000 (09:57 +0000)]
Support for running contribcheck on msvc

17 years agoGenerate SQL files for /contrib (based on .sql.in)
Magnus Hagander [Fri, 23 Mar 2007 09:53:33 +0000 (09:53 +0000)]
Generate SQL files for /contrib (based on .sql.in)

17 years agoAdd define to exclude configured libraries, to be able to easily build a
Magnus Hagander [Fri, 23 Mar 2007 08:43:51 +0000 (08:43 +0000)]
Add define to exclude configured libraries, to be able to easily build a
stripped down version of libpq. To be used by the installer.

17 years agoRemove headers for old sysv shmem emulation that I forgot.
Magnus Hagander [Fri, 23 Mar 2007 08:30:55 +0000 (08:30 +0000)]
Remove headers for old sysv shmem emulation that I forgot.
Also remove headers for old sysv semaphore emulation that were forgotten
when that was changed about a year ago.

17 years agoCleanup for procarray.c.
Bruce Momjian [Fri, 23 Mar 2007 03:16:39 +0000 (03:16 +0000)]
Cleanup for procarray.c.

17 years agoAdd:
Bruce Momjian [Thu, 22 Mar 2007 20:55:19 +0000 (20:55 +0000)]
Add:

>
> * Fix cases where invalid byte encodings are accepted by the database,
>   but throw an error on SELECT
>
>   http://archives.postgresql.org/pgsql-hackers/2007-03/msg00767.php

17 years agoAdd comment that pg_dump 'append' format is used only by pg_dump, per
Bruce Momjian [Thu, 22 Mar 2007 20:47:12 +0000 (20:47 +0000)]
Add comment that pg_dump 'append' format is used only by pg_dump, per
Dave Page.

17 years agoAdd to TODO:
Bruce Momjian [Thu, 22 Mar 2007 20:38:42 +0000 (20:38 +0000)]
Add to TODO:

CLUSTER:
>
>  o %Add VERBOSE option to report tables as they are processed,
>    like VACUUM VERBOSE

17 years agoCommit newest version of xmlpath().
Bruce Momjian [Thu, 22 Mar 2007 20:26:30 +0000 (20:26 +0000)]
Commit newest version of xmlpath().

Nikolay Samokhvalov

17 years agoIn pg_dump, strcasecmp -> pg_strcasecmp.
Bruce Momjian [Thu, 22 Mar 2007 20:18:49 +0000 (20:18 +0000)]
In pg_dump, strcasecmp -> pg_strcasecmp.

17 years agoAdd xmlpath() to evaluate XPath expressions, with namespaces support.
Bruce Momjian [Thu, 22 Mar 2007 20:14:58 +0000 (20:14 +0000)]
Add xmlpath() to evaluate XPath expressions, with namespaces support.

Nikolay Samokhvalov

17 years agoArrange for PreventTransactionChain to reject commands submitted as part
Tom Lane [Thu, 22 Mar 2007 19:55:04 +0000 (19:55 +0000)]
Arrange for PreventTransactionChain to reject commands submitted as part
of a multi-statement simple-Query message.  This bug goes all the way
back, but unfortunately is not nearly so easy to fix in existing releases;
it is only the recent ProcessUtility API change that makes it fixable in
HEAD.  Per report from William Garrison.

17 years agoAllow the pgstat process to restart immediately after a receiving
Bruce Momjian [Thu, 22 Mar 2007 19:53:31 +0000 (19:53 +0000)]
Allow the pgstat process to restart immediately after a receiving
SIGQUIT signal, rather than waiting for PGSTAT_RESTART_INTERVAL.

17 years agoAllow DROP TABLESPACE to succeed (with a warning) if the pg_tblspc symlink
Tom Lane [Thu, 22 Mar 2007 19:51:44 +0000 (19:51 +0000)]
Allow DROP TABLESPACE to succeed (with a warning) if the pg_tblspc symlink
doesn't exist.  This allows DROP to be used to clean out the pg_tablespace
catalog entry in a situation where a previous DROP attempt failed before
committing but after having removed the directories and symlink.

Per report from William Garrison.  Even though his test case depends on an
unrelated bug in PreventTransactionChain, it's certainly possible for this
situation to arise due to other problems, eg a system crash at just the
right time.

17 years agoProperly enforce pg_dump -F formation options; only single letter or
Bruce Momjian [Thu, 22 Mar 2007 19:42:02 +0000 (19:42 +0000)]
Properly enforce pg_dump -F formation options; only single letter or
full words support, per report from Mark Stosberg.

17 years agoRemove the currently unused FRONTEND case in dllist.c. This allows the usage
Alvaro Herrera [Thu, 22 Mar 2007 18:57:52 +0000 (18:57 +0000)]
Remove the currently unused FRONTEND case in dllist.c.  This allows the usage
of palloc instead of malloc, which means a list can be freed simply by deleting
the memory context that contains it.

17 years agoFix parser bug on Windows with UTF8 encoding and C locale, the reason was
Teodor Sigaev [Thu, 22 Mar 2007 15:58:24 +0000 (15:58 +0000)]
Fix parser bug on Windows with UTF8 encoding and C locale, the reason was
sizeof(wchar_t) = 2 instead of 4.

17 years agoRemove tabs in SGML files.
Bruce Momjian [Thu, 22 Mar 2007 15:46:56 +0000 (15:46 +0000)]
Remove tabs in SGML files.

17 years agoRemove tabs from SGML file.
Bruce Momjian [Thu, 22 Mar 2007 15:45:56 +0000 (15:45 +0000)]
Remove tabs from SGML file.

17 years agoForgot to add file needed for PL regression tests
Magnus Hagander [Thu, 22 Mar 2007 13:43:02 +0000 (13:43 +0000)]
Forgot to add file needed for PL regression tests

17 years agoFix some problems with selectivity estimation for partial indexes.
Tom Lane [Wed, 21 Mar 2007 22:18:12 +0000 (22:18 +0000)]
Fix some problems with selectivity estimation for partial indexes.

First, genericcostestimate() was being way too liberal about including
partial-index conditions in its selectivity estimate, resulting in
substantial underestimates for situations such as an indexqual "x = 42"
used with an index on x "WHERE x >= 40 AND x < 50".  While the code is
intentionally set up to favor selecting partial indexes when available,
this was too much...

Second, choose_bitmap_and() was likewise easily fooled by cases of this
type, since it would similarly think that the partial index had selectivity
independent of the indexqual.

Fixed by using predicate_implied_by() rather than simple equality checks
to determine redundancy.  This is a good deal more expensive but I don't
see much alternative.  At least the extra cost is only paid when there's
actually a partial index under consideration.

Per report from Jeff Davis.  I'm not going to risk back-patching this,
though.

17 years agoAdd:
Bruce Momjian [Wed, 21 Mar 2007 21:25:46 +0000 (21:25 +0000)]
Add:

<
<
>  o During index creation, pre-sort the tuples to improve build speed
>
>    http://archives.postgresql.org/pgsql-hackers/2007-03/msg01199.php
>

17 years agoRemove TODO item, not wanted:
Bruce Momjian [Wed, 21 Mar 2007 21:21:21 +0000 (21:21 +0000)]
Remove TODO item, not wanted:

< * Add NUMERIC division operator that doesn't round?
<
<   Currently NUMERIC _rounds_ the result to the specified precision.
<   This means division can return a result that multiplied by the
<   divisor is greater than the dividend, e.g. this returns a value > 10:
<
<     SELECT (10::numeric(2,0) / 6::numeric(2,0))::numeric(2,0) * 6;
<
<   The positive modulus result returned by NUMERICs might be considered
<   inaccurate, in one sense.
<

17 years agoAdd documentation about vcregress.
Magnus Hagander [Wed, 21 Mar 2007 19:22:52 +0000 (19:22 +0000)]
Add documentation about vcregress.

17 years agoAdd URL for:
Bruce Momjian [Wed, 21 Mar 2007 16:43:31 +0000 (16:43 +0000)]
Add URL for:

* Add locale-aware MONEY type, and support multiple currencies
  http://archives.postgresql.org/pgsql-hackers/2007-03/msg01181.php

17 years agoAdd support for running regression tests on procedural languages
Magnus Hagander [Wed, 21 Mar 2007 16:21:40 +0000 (16:21 +0000)]
Add support for running regression tests on procedural languages

17 years agoProperly return exitcode when regression tests fails.
Magnus Hagander [Wed, 21 Mar 2007 15:39:03 +0000 (15:39 +0000)]
Properly return exitcode when regression tests fails.

17 years agoNative shared memory implementation for win32.
Magnus Hagander [Wed, 21 Mar 2007 14:39:23 +0000 (14:39 +0000)]
Native shared memory implementation for win32.
Uses same underlying tech as before, but not the sysv emulation layer.

17 years agoAdd URL for:
Bruce Momjian [Wed, 21 Mar 2007 00:33:08 +0000 (00:33 +0000)]
Add URL for:

* Allow accurate statistics to be collected on indexes with more than
  one column or expression indexes, perhaps using per-index statistics
>   http://archives.postgresql.org/pgsql-hackers/2007-03/msg01131.php

17 years agoIn FAQ, reference upgrade info via URL.
Bruce Momjian [Tue, 20 Mar 2007 17:43:57 +0000 (17:43 +0000)]
In FAQ, reference upgrade info via URL.

17 years agoNot done, reverted:
Bruce Momjian [Tue, 20 Mar 2007 16:36:20 +0000 (16:36 +0000)]
Not done, reverted:

<  o -Allow commenting of variables in postgresql.conf to restore them
>  o Allow commenting of variables in postgresql.conf to restore them

17 years agoDone:
Bruce Momjian [Tue, 20 Mar 2007 16:32:42 +0000 (16:32 +0000)]
Done:

>  o -Allow commenting of variables in postgresql.conf to restore them
<    http://archives.postgresql.org/pgsql-hackers/2006-09/msg01481.php

17 years agoAdd three new regexp functions: regexp_matches, regexp_split_to_array,
Neil Conway [Tue, 20 Mar 2007 05:45:00 +0000 (05:45 +0000)]
Add three new regexp functions: regexp_matches, regexp_split_to_array,
and regexp_split_to_table. These functions provide access to the
capture groups resulting from a POSIX regular expression match,
and provide the ability to split a string on a POSIX regular
expression, respectively. Patch from Jeremy Drake; code review by
Neil Conway, additional comments and suggestions from Tom and
Peter E.

This patch bumps the catversion, adds some regression tests,
and updates the docs.

17 years agoBumping catversion due to changes to pg_trigger and pg_rewrite.
Jan Wieck [Tue, 20 Mar 2007 03:53:26 +0000 (03:53 +0000)]
Bumping catversion due to changes to pg_trigger and pg_rewrite.

BTW, the comment in this file says that we hope we never have more than
10 catversion changes per day, but to even make this possible we should
start counting at zero, shouldn't we?

Jan

17 years agoChanges pg_trigger and extend pg_rewrite in order to allow triggers and
Jan Wieck [Mon, 19 Mar 2007 23:38:32 +0000 (23:38 +0000)]
Changes pg_trigger and extend pg_rewrite in order to allow triggers and
rules to be defined with different, per session controllable, behaviors
for replication purposes.

This will allow replication systems like Slony-I and, as has been stated
on pgsql-hackers, other products to control the firing mechanism of
triggers and rewrite rules without modifying the system catalog directly.

The firing mechanisms are controlled by a new superuser-only GUC
variable, session_replication_role, together with a change to
pg_trigger.tgenabled and a new column pg_rewrite.ev_enabled. Both
columns are a single char data type now (tgenabled was a bool before).
The possible values in these attributes are:

     'O' - Trigger/Rule fires when session_replication_role is "origin"
           (default) or "local". This is the default behavior.

     'D' - Trigger/Rule is disabled and fires never

     'A' - Trigger/Rule fires always regardless of the setting of
           session_replication_role

     'R' - Trigger/Rule fires when session_replication_role is "replica"

The GUC variable can only be changed as long as the system does not have
any cached query plans. This will prevent changing the session role and
accidentally executing stored procedures or functions that have plans
cached that expand to the wrong query set due to differences in the rule
firing semantics.

The SQL syntax for changing a triggers/rules firing semantics is

     ALTER TABLE <tabname> <when> TRIGGER|RULE <name>;

     <when> ::= ENABLE | ENABLE ALWAYS | ENABLE REPLICA | DISABLE

psql's \d command as well as pg_dump are extended in a backward
compatible fashion.

Jan

17 years agoRemove last line of patch license, per Zeugswetter Andreas:
Bruce Momjian [Mon, 19 Mar 2007 16:53:03 +0000 (16:53 +0000)]
Remove last line of patch license, per Zeugswetter Andreas:

"If the patch is not BSD-licensed, it will be rejected."

17 years agoFurther buildfarm experience shows that actually we can't run the plancache
Tom Lane [Mon, 19 Mar 2007 16:44:41 +0000 (16:44 +0000)]
Further buildfarm experience shows that actually we can't run the plancache
test in parallel with the rules test at all, because the former wants to
create a couple of temp views, which can sometimes show up in the latter's
output.  Let's try it in the next parallel group instead.

17 years agoFix 8.2 breakage of domains over array types, and add a regression test case
Tom Lane [Mon, 19 Mar 2007 16:30:32 +0000 (16:30 +0000)]
Fix 8.2 breakage of domains over array types, and add a regression test case
to cover it.  Per report from Anton Pikhteryev.

17 years agoAdd URL for:
Bruce Momjian [Mon, 19 Mar 2007 15:50:48 +0000 (15:50 +0000)]
Add URL for:

* Simplify ability to create partitioned tables
>   http://archives.postgresql.org/pgsql-hackers/2007-03/msg00375.php

17 years agoAdd URL for:
Bruce Momjian [Mon, 19 Mar 2007 15:24:17 +0000 (15:24 +0000)]
Add URL for:

* Allow sequential scans to take advantage of other concurrent
  sequential scans, also called "Synchronised Scanning"

  http://archives.postgresql.org/pgsql-hackers/2007-03/msg00415.php

17 years agoecpglib requires libpgport, per Andrew Dunstan
Magnus Hagander [Mon, 19 Mar 2007 09:34:09 +0000 (09:34 +0000)]
ecpglib requires libpgport, per Andrew Dunstan

17 years agoFix ecpg/preproc makefile for parallel builds: parser.o must depend
Tom Lane [Sun, 18 Mar 2007 17:57:34 +0000 (17:57 +0000)]
Fix ecpg/preproc makefile for parallel builds: parser.o must depend
on preproc.h, else make may try to build it before preproc.h is ready.
Per failures seen here and in buildfarm.

17 years agoCode cleanup: mark some variables with the "const" modifier, when they
Neil Conway [Sun, 18 Mar 2007 16:50:44 +0000 (16:50 +0000)]
Code cleanup: mark some variables with the "const" modifier, when they
are initialized with a string literal. Patch from Stefan Huehner.

17 years agoCode cleanup for function prototypes: change two K&R-style prototypes
Neil Conway [Sun, 18 Mar 2007 05:36:50 +0000 (05:36 +0000)]
Code cleanup for function prototypes: change two K&R-style prototypes
to ANSI-style, and change "()" -> "(void)". Patch from Stefan Huehner.

17 years agoSimplified sortby rule
Michael Meskes [Sat, 17 Mar 2007 19:27:12 +0000 (19:27 +0000)]
Simplified sortby rule

17 years ago- Changed some whitespacing in connect statement.
Michael Meskes [Sat, 17 Mar 2007 19:25:24 +0000 (19:25 +0000)]
- Changed some whitespacing in connect statement.
- Made some chars const as proposed by Stefan Huehner <stefan@huehner.org>.
- Synced parser and keyword lists.
- Copied two token parsing from backend parser to ecpg parser.
- Also added a test case for this.

17 years agomsvc build actually needs Bison 2.2 or later, not 2.1. Or 1.875 as before.
Magnus Hagander [Sat, 17 Mar 2007 17:11:41 +0000 (17:11 +0000)]
msvc build actually needs Bison 2.2 or later, not 2.1. Or 1.875 as before.

17 years agoAdd note that diff is required for regression tests.
Magnus Hagander [Sat, 17 Mar 2007 14:30:00 +0000 (14:30 +0000)]
Add note that diff is required for regression tests.

17 years agoAdd cvs tags to msvc build files, along with a (very short) comment about
Magnus Hagander [Sat, 17 Mar 2007 14:01:01 +0000 (14:01 +0000)]
Add cvs tags to msvc build files, along with a (very short) comment about
what each script does.

17 years agoOops, forgot to remove the old genbki script.
Magnus Hagander [Sat, 17 Mar 2007 13:54:34 +0000 (13:54 +0000)]
Oops, forgot to remove the old genbki script.

17 years agoTurn most vc build scripts into modules instead of scripts, and just have
Magnus Hagander [Sat, 17 Mar 2007 13:50:42 +0000 (13:50 +0000)]
Turn most vc build scripts into modules instead of scripts, and just have
skeleton scripts calling them. To make it easier for the buildfarm
(or other "outside callers") to use these modules directly.

Per suggestion from Andrew Dunstan.

17 years agoSPI_cursor_open failed to enforce that only read-only queries could be
Tom Lane [Sat, 17 Mar 2007 03:15:38 +0000 (03:15 +0000)]
SPI_cursor_open failed to enforce that only read-only queries could be
executed in read_only mode.  This could lead to various relatively-subtle
failures, such as an allegedly stable function returning non-stable results.
Bug goes all the way back to the introduction of read-only mode in 8.0.
Per report from Gaetano Mendola.

17 years agoOoops, got only one of the two ArrayExpr variants correct in first
Tom Lane [Sat, 17 Mar 2007 01:15:55 +0000 (01:15 +0000)]
Ooops, got only one of the two ArrayExpr variants correct in first
cut at exprTypmod support.  Also, experimentation shows that we need
to label the type of Const nodes that are numeric with a specific
typmod.

17 years agoFix up the remaining places where the expression node structure would lose
Tom Lane [Sat, 17 Mar 2007 00:11:05 +0000 (00:11 +0000)]
Fix up the remaining places where the expression node structure would lose
available information about the typmod of an expression; namely, Const,
ArrayRef, ArrayExpr, and EXPR and ARRAY SubLinks.  In the ArrayExpr and
SubLink cases it wasn't really the data structure's fault, but exprTypmod()
being lazy.  This seems like a good idea in view of the expected increase in
typmod usage from Teodor's work to allow user-defined types to have typmods.
In particular this responds to the concerns we had about eliminating the
special-purpose hack that exprTypmod() used to have for BPCHAR Consts.
We can now tell whether or not such a Const has been cast to a specific
length, and report or display properly if so.

initdb forced due to changes in stored rules.

17 years agoAdd new columns for tuple statistics on a database level to
Magnus Hagander [Fri, 16 Mar 2007 17:57:36 +0000 (17:57 +0000)]
Add new columns for tuple statistics on a database level to
pg_stat_database.

17 years agoFix race condition in parallel regression tests. The new plancache test
Tom Lane [Fri, 16 Mar 2007 16:11:49 +0000 (16:11 +0000)]
Fix race condition in parallel regression tests.  The new plancache test
was expecting there to be no regular table named 'foo', but it turns out
the rules test transiently creates one, so that plancache would sometimes
fail.  I couldn't reproduce that in quite a few tries here, but several
buildfarm machines have shown the failure.  Fix by renaming plancache's
temp table to something nonconflicting.

17 years agoFix uninitialized value in pgstatindex leading to invalid values being
Alvaro Herrera [Fri, 16 Mar 2007 15:06:43 +0000 (15:06 +0000)]
Fix uninitialized value in pgstatindex leading to invalid values being
reported in some cases.  Report and patch from Tatsuhito Kasahara.

Also fix a couple of other bugs I noticed in skimming the surrounding code.

17 years agoRemove undocumented support for copy syntax from before 7.3. Update comments to
Andrew Dunstan [Fri, 16 Mar 2007 13:41:21 +0000 (13:41 +0000)]
Remove undocumented support for copy syntax from before 7.3. Update comments to
reflect syntax actually supported, e.g. by including CSV params.

17 years agoShow aggregate return types in psql \da output.
Magnus Hagander [Fri, 16 Mar 2007 08:28:01 +0000 (08:28 +0000)]
Show aggregate return types in psql \da output.

Greg Sabino Mullane

17 years agoMake use of plancache module for SPI plans. In particular, since plpgsql
Tom Lane [Thu, 15 Mar 2007 23:12:07 +0000 (23:12 +0000)]
Make use of plancache module for SPI plans.  In particular, since plpgsql
uses SPI plans, this finally fixes the ancient gotcha that you can't
drop and recreate a temp table used by a plpgsql function.

Along the way, clean up SPI's API a little bit by declaring SPI plan
pointers as "SPIPlanPtr" instead of "void *".  This is cosmetic but
helps to forestall simple programming mistakes.  (I have changed some
but not all of the callers to match; there are still some "void *"'s
in contrib and the PL's.  This is intentional so that we can see if
anyone's compiler complains about it.)

17 years agoFix a longstanding bug in VACUUM FULL's handling of update chains. The code
Tom Lane [Wed, 14 Mar 2007 18:48:55 +0000 (18:48 +0000)]
Fix a longstanding bug in VACUUM FULL's handling of update chains.  The code
did not expect that a DEAD tuple could follow a RECENTLY_DEAD tuple in an
update chain, but because the OldestXmin rule for determining deadness is a
simplification of reality, it is possible for this situation to occur
(implying that the RECENTLY_DEAD tuple is in fact dead to all observers,
but this patch does not attempt to exploit that).  The code would follow a
chain forward all the way, but then stop before a DEAD tuple when backing
up, meaning that not all of the chain got moved.  This could lead to copying
the chain multiple times (resulting in duplicate copies of the live tuple at
its end), or leaving dangling index entries behind (which, aside from
generating warnings from later vacuums, creates a risk of wrong query
results or bogus duplicate-key errors once the heap slot the index entry
points to is repopulated).

The fix is to recheck HeapTupleSatisfiesVacuum while following a chain
forward, and to stop if a DEAD tuple is reached.  Each contiguous group
of RECENTLY_DEAD tuples will therefore be copied as a separate chain.
The patch also adds a couple of extra sanity checks to verify correct
behavior.

Per report and test case from Pavan Deolasee.

17 years agoArrange to install a "posixrules" entry in our timezone database, so that
Tom Lane [Wed, 14 Mar 2007 17:38:06 +0000 (17:38 +0000)]
Arrange to install a "posixrules" entry in our timezone database, so that
POSIX-style timezone specs that don't exactly match any database entry will
be treated as having correct USA DST rules.  Also, document that this can
be changed if you want to use some other DST rules with a POSIX zone spec.

We could consider changing localtime.c's TZDEFRULESTRING, but since that
facility can only deal with one DST transition rule, it seems fairly useless
now; might as well just plan to override it using a "posixrules" entry.

Backpatch as far as 8.0.  There isn't much we can do in 7.x ... either your
libc gets it right, or it doesn't.

17 years agoAdd GIN support for pg_trgm. From Guillaume Smet <guillaume.smet@gmail.com>
Teodor Sigaev [Wed, 14 Mar 2007 14:21:53 +0000 (14:21 +0000)]
Add GIN support for pg_trgm. From Guillaume Smet <guillaume.smet@gmail.com>
with minor editorization by me.

Hstore improvements
* add operation hstore ? text - excat equivalent of exist()
* remove undocumented behaviour of contains operation with NULL value
* now 'key'::text=>NULL returns '"key"=>NULL' instead of NULL
* Add GIN support for contains and exist operations
* Add GiST support for exist operatiion
* improve regression tests

17 years agoAdd GIN support for pg_trgm. From Guillaume Smet <guillaume.smet@gmail.com>
Teodor Sigaev [Wed, 14 Mar 2007 14:15:40 +0000 (14:15 +0000)]
Add GIN support for pg_trgm. From Guillaume Smet <guillaume.smet@gmail.com>
with minor editorization by me.

17 years agoRemove extra single-quotes copied from Unix build. Win32 doesn't strip
Magnus Hagander [Wed, 14 Mar 2007 09:55:03 +0000 (09:55 +0000)]
Remove extra single-quotes copied from Unix build. Win32 doesn't strip
single quotes...

17 years agoFix broken markup, strange tab width.
Tom Lane [Wed, 14 Mar 2007 00:15:26 +0000 (00:15 +0000)]
Fix broken markup, strange tab width.

17 years agoRegression makefile now needs to make separate lists of what to clean
Tom Lane [Tue, 13 Mar 2007 22:56:48 +0000 (22:56 +0000)]
Regression makefile now needs to make separate lists of what to clean
for input/ and output/ directories, because with the addition of
largeobject_1.source, they're not the same list.  Apparently the current
buildfarm process does not exercise whether 'make distclean' leaves a
clean tree behind, else the farm would have been failing for awhile.

17 years agoRewrite win32 install documentation (it's not client only anymore, and it's
Magnus Hagander [Tue, 13 Mar 2007 16:03:36 +0000 (16:03 +0000)]
Rewrite win32 install documentation (it's not client only anymore, and it's
now complete). Update for the MSVC6/Borland support now being only libpq.
Move most of the information about full MSVC build from README file into
documentation.

17 years agoReverted waiting for further fixes:
Peter Eisentraut [Tue, 13 Mar 2007 14:32:25 +0000 (14:32 +0000)]
Reverted waiting for further fixes:

Make configuration parameters fall back to their default values when they
are removed from the configuration file.

Joachim Wieland

17 years agoFilter out warnings coming from the stylesheets, so that actual warnings show up...
Magnus Hagander [Tue, 13 Mar 2007 14:28:30 +0000 (14:28 +0000)]
Filter out warnings coming from the stylesheets, so that actual warnings show up properly.
Show some minor progress messages.

17 years agoSet root of docbook stuff from buildenv.bat and not from builddoc.bat.
Magnus Hagander [Tue, 13 Mar 2007 09:45:32 +0000 (09:45 +0000)]
Set root of docbook stuff from buildenv.bat and not from builddoc.bat.
Fix calling for file renaming when cd:ed into a different directory.

17 years agoProperly use pg_strcasecmp() instead of strcasecmp().
Magnus Hagander [Tue, 13 Mar 2007 09:11:05 +0000 (09:11 +0000)]
Properly use pg_strcasecmp() instead of strcasecmp().
Un-breaks win32 build.

17 years agoSet stderr to unbuffered for pgbench on win32.
Magnus Hagander [Tue, 13 Mar 2007 09:06:35 +0000 (09:06 +0000)]
Set stderr to unbuffered for pgbench on win32.
ITAGAKI Takahiro