]>
granicus.if.org Git - esp-idf/log
Ivan Grokhotkov [Wed, 21 Nov 2018 05:54:09 +0000 (13:54 +0800)]
ci: don’t look for project CMakeLists in common_components
Ivan Grokhotkov [Tue, 20 Nov 2018 16:40:26 +0000 (00:40 +0800)]
examples: add component for protocol examples network functionality
Angus Gratton [Sun, 14 Apr 2019 23:57:11 +0000 (07:57 +0800)]
Merge branch 'feat/spi_hal_support' into 'master'
spi_master: refactor and add HAL support
See merge request idf/esp-idf!4159
Jiang Jiang Jian [Sun, 14 Apr 2019 03:20:22 +0000 (11:20 +0800)]
Merge branch 'bugfix/rename_ldgen_common_module' into 'master'
ldgen: rename common module
See merge request idf/esp-idf!4758
Renz Christian Bagaporo [Sat, 13 Apr 2019 00:59:32 +0000 (08:59 +0800)]
ldgen: rename common module
Jiang Jiang Jian [Fri, 12 Apr 2019 15:48:11 +0000 (23:48 +0800)]
Merge branch 'feature/wifi_refactor_softap_power_save' into 'master'
refactor softap power save
Closes WIFI-415 and IDF-81
See merge request idf/esp-idf!1905
Jiang Jiang Jian [Fri, 12 Apr 2019 15:04:10 +0000 (23:04 +0800)]
Merge branch 'bugfix/nvs_fix_erase_any' into 'master'
nvs_flash: Multi-page blob erased using nvs_erase_key should be cleaned properly
See merge request idf/esp-idf!4634
Jiang Jiang Jian [Fri, 12 Apr 2019 15:00:44 +0000 (23:00 +0800)]
Merge branch 'bugfix/btdm_fix_memory_leak_when_set_txpwr' into 'master'
component/bt: fix memory leak when settig tx power
See merge request idf/esp-idf!4712
Jiang Jiang Jian [Fri, 12 Apr 2019 14:57:04 +0000 (22:57 +0800)]
Merge branch 'bugfix/improve_spi_timing_for_psram_and_flash' into 'master'
bugfix(psram): improve spi cs timing settings for psram
See merge request idf/esp-idf!4641
Ivan Grokhotkov [Fri, 12 Apr 2019 08:12:57 +0000 (16:12 +0800)]
Merge branch 'feat/example_sdio_over_spi' into 'master'
sdio: support SDIO over spi
See merge request idf/esp-idf!3069
Angus Gratton [Fri, 12 Apr 2019 08:06:38 +0000 (16:06 +0800)]
Merge branch 'feature/move_aws_iot_to_independent_repository' into 'master'
aws_iot: moving AWS IoT to independent repository
See merge request idf/esp-idf!4624
Ivan Grokhotkov [Fri, 12 Apr 2019 05:55:15 +0000 (13:55 +0800)]
Merge branch 'feature/esp_event_loop_examples_wifi' into 'master'
examples/wifi,ethernet,system: use esp_event library for event handling
See merge request idf/esp-idf!3765
Ivan Grokhotkov [Fri, 12 Apr 2019 05:54:18 +0000 (13:54 +0800)]
Merge branch 'feature/esp_event_loop_library_compat_base' into 'master'
Implement Wi-Fi, Ethernet, IP event handling based on esp_event library
Closes IDF-37 and IDF-267
See merge request idf/esp-idf!3635
Mahavir Jain [Mon, 25 Mar 2019 16:00:26 +0000 (21:30 +0530)]
aws_iot: moving AWS IoT to independent repository
Like other cloud frameworks, AWS IoT will also be supported through
independent repository, https://github.com/espressif/esp-aws-iot
Angus Gratton [Fri, 12 Apr 2019 05:33:50 +0000 (13:33 +0800)]
Merge branch 'bugfix/enb_secboot_post_flash_enc' into 'master'
Enable secure boot only after encrypting flash
Closes IDF-234
See merge request idf/esp-idf!4709
Angus Gratton [Fri, 12 Apr 2019 01:31:23 +0000 (09:31 +0800)]
Merge branch 'feature/unit_test_tag_leaks' into 'master'
Add support a [leaks] tag for UT
Closes IDF-143
See merge request idf/esp-idf!4333
Konstantin Kondrashov [Fri, 12 Apr 2019 01:31:23 +0000 (09:31 +0800)]
Add support a [leaks] tag for UT
Michael (XIAO Xufeng) [Thu, 23 Aug 2018 12:43:07 +0000 (20:43 +0800)]
sdio: support SDIO over spi in the example
michael [Fri, 28 Dec 2018 18:04:37 +0000 (02:04 +0800)]
sdmmc: support SDIO over SPI
XiaXiaotian [Mon, 5 Feb 2018 04:16:59 +0000 (12:16 +0800)]
refactor softap power save
1. Softap support multicast and broadcast saving and flushing
when the associated stations enable IEEE80211 legacy power
save(which is called modem sleep in ESP32).
2. Improve the frame saving and flushing mechanism of softap power
save.
Krzysztof Budzynski [Thu, 11 Apr 2019 07:33:39 +0000 (15:33 +0800)]
Merge branch 'doc/review_system_log-index' into 'master'
Review log.rst and index.rst files in api-reference/system
See merge request idf/esp-idf!4738
Kirill Chalov [Thu, 11 Apr 2019 07:33:38 +0000 (15:33 +0800)]
Review log.rst and index.rst files in api-reference/system
Ivan Grokhotkov [Tue, 20 Nov 2018 10:26:53 +0000 (18:26 +0800)]
examples/wifi: use esp_event library to handle events
Ivan Grokhotkov [Tue, 20 Nov 2018 10:25:25 +0000 (18:25 +0800)]
examples/system: use esp_event library to handle events
Ivan Grokhotkov [Tue, 20 Nov 2018 10:24:49 +0000 (18:24 +0800)]
examples/ethernet: use esp_event library to handle events
Ivan Grokhotkov [Thu, 11 Apr 2019 04:19:29 +0000 (12:19 +0800)]
Merge branch 'feature/gcc8_use_bundled_newlib' into 'master'
Use newlib headers and libraries from toolchain when compiling with GCC 8.2
See merge request idf/esp-idf!4450
Ivan Grokhotkov [Tue, 9 Apr 2019 04:09:56 +0000 (12:09 +0800)]
wifi: don’t disable event handling for SoftAP
Events are needed to initialise the tcpip_adapter and start the DHCP server
Ivan Grokhotkov [Mon, 8 Apr 2019 11:31:37 +0000 (19:31 +0800)]
esp_event: don’t warn if no handlers are present for specific event
Ivan Grokhotkov [Mon, 8 Apr 2019 11:30:32 +0000 (19:30 +0800)]
tcpip_adapter: unregister shutdown handlers, don’t fail on repeated registration
Ivan Grokhotkov [Mon, 8 Apr 2019 11:30:07 +0000 (19:30 +0800)]
system_api: return error on repeated registration of shutdown handler
Ivan Grokhotkov [Mon, 8 Apr 2019 11:29:44 +0000 (19:29 +0800)]
system_api: add esp_unregister_shutdown_handler
Ivan Grokhotkov [Tue, 25 Dec 2018 07:44:14 +0000 (15:44 +0800)]
event: re-add wifi disconnect reason logging (
e621e0af )
Ivan Grokhotkov [Wed, 21 Nov 2018 07:56:06 +0000 (15:56 +0800)]
docs: add event handling API guide
Ivan Grokhotkov [Wed, 21 Nov 2018 05:46:45 +0000 (13:46 +0800)]
mdns: use esp_event library to handle events
Ivan Grokhotkov [Tue, 6 Nov 2018 03:09:32 +0000 (11:09 +0800)]
event loop: re-implement based on esp_event library
Includes ds2ds unit test fix, iperf example test fix
Ivan Grokhotkov [Tue, 25 Dec 2018 07:28:56 +0000 (15:28 +0800)]
tcpip_adapter: add event declarations
Ivan Grokhotkov [Thu, 23 Aug 2018 09:50:29 +0000 (17:50 +0800)]
ethernet: add event declarations
Ivan Grokhotkov [Thu, 23 Aug 2018 09:50:16 +0000 (17:50 +0800)]
wifi: add event declarations
Ivan Grokhotkov [Mon, 19 Nov 2018 08:54:57 +0000 (16:54 +0800)]
esp_event: move trailing semicolons out of defines
Jiang Jiang Jian [Thu, 11 Apr 2019 03:49:26 +0000 (11:49 +0800)]
Merge branch 'bugfix/wifi_spike_power' into 'master'
esp32: fix the issue that the spike transmit power of WiFi is higher than configured when WiFi and Bluetooth coexist
See merge request idf/esp-idf!4611
Angus Gratton [Thu, 11 Apr 2019 01:15:13 +0000 (09:15 +0800)]
Merge branch 'feature/post_events_from_isr' into 'master'
Support posting events from ISR
See merge request idf/esp-idf!4283
Anton Maklakov [Wed, 10 Apr 2019 14:05:10 +0000 (21:05 +0700)]
pthread: Use a definition only if we have the old toolchain
Anurag Kar [Thu, 4 Apr 2019 09:55:22 +0000 (15:25 +0530)]
Enable secure boot only after encrypting flash
This prevents a device from being bricked in case when both secure boot & flash encryption are enabled and encryption gets interrupted during first boot. After interruption, all partitions on the device need to be reflashed (including the bootloader).
List of changes:
* Secure boot key generation and bootloader digest generation logic, implemented inside function esp_secure_boot_permanently_enable(), has been pulled out into new API esp_secure_boot_generate_digest(). The enabling of R/W protection of secure boot key on EFUSE still happens inside esp_secure_boot_permanently_enable()
* Now esp_secure_boot_permanently_enable() is called only after flash encryption process completes
* esp_secure_boot_generate_digest() is called before flash encryption process starts
negativekelvin [Wed, 27 Mar 2019 14:44:56 +0000 (20:14 +0530)]
nvs_flash: Multi-page blob erased using nvs_erase_key should be cleaned properly
Earlier eraseItem function in Storage class would do lazy cleanup of
multi-page blobs if called using type "ANY" instead of "BLOB". It used to
just delete BLOB data and index would remain as is. Any subsequent read
would delete index entry as well. This however would return a valid
length without error if nvs_get_blob API was just used for finding
length and not reading the complete blob. This change fixes this issue.
Closes https://github.com/espressif/esp-idf/issues/3255
Renz Christian Bagaporo [Tue, 12 Mar 2019 13:53:39 +0000 (21:53 +0800)]
esp_event: test posting from interrupt handler
Renz Christian Bagaporo [Fri, 15 Feb 2019 13:28:24 +0000 (21:28 +0800)]
esp_event: allow posting events from ISRs
Renz Christian Bagaporo [Wed, 10 Apr 2019 01:00:35 +0000 (09:00 +0800)]
ci: add unit test job
Angus Gratton [Wed, 10 Apr 2019 06:48:22 +0000 (14:48 +0800)]
Merge branch 'bugfix/http_client_redirection' into 'master'
Fix url redirection issue
See merge request idf/esp-idf!4623
Anton Maklakov [Tue, 9 Apr 2019 03:14:31 +0000 (10:14 +0700)]
esp32: disable -Wframe-address
Since the behavior is well defined on Xtensa with Window ABI we can
suppress a frame-address warning. Also fix the CMAKE_C*_FLAGS parsing.
Ivan Grokhotkov [Mon, 1 Apr 2019 07:21:12 +0000 (15:21 +0800)]
newlib: when compiling with GCC8, use newlib headers and libraries from toolchain
Ivan Grokhotkov [Mon, 18 Mar 2019 03:47:00 +0000 (11:47 +0800)]
newlib: force including IDF locks implementation
Ivan Grokhotkov [Fri, 8 Mar 2019 07:07:50 +0000 (15:07 +0800)]
newlib: when compiling with GCC8, use newlib headers and libraries from toolchain
Ivan Grokhotkov [Fri, 29 Mar 2019 04:37:51 +0000 (12:37 +0800)]
esp_rom: don’t include locale functions when compiling with newlib 3
Ivan Grokhotkov [Sun, 10 Mar 2019 14:12:34 +0000 (22:12 +0800)]
esp_rom: export newlib functions as strong symbols
Ivan Grokhotkov [Fri, 8 Mar 2019 07:07:00 +0000 (15:07 +0800)]
pthread: add dummy implementation of pthread_setcancelstate
Used by new versions of newlib in stdio functions.
Ivan Grokhotkov [Thu, 28 Mar 2019 11:22:37 +0000 (19:22 +0800)]
newlib: fixes for compatibility with newlib 3.0
Ivan Grokhotkov [Fri, 29 Mar 2019 04:38:06 +0000 (12:38 +0800)]
newlib: add missing tzset() to the time test
Anton Maklakov [Tue, 9 Apr 2019 05:26:59 +0000 (12:26 +0700)]
sysview: fix test case for compatibility with new binutils
Since the ‘addr2line’ works correctly in the new version of binutils,
line numbers are different.
Ivan Grokhotkov [Fri, 8 Mar 2019 06:57:00 +0000 (14:57 +0800)]
spi_master: compile as C11 due to use of stdatomic.h
stdatomic.h is available both in newlib and GCC include directories.
Normally (if you invoke the compiler without any flags) GCC include
directories are first on the list, so GCC’s stdatomic.h is used. In
IDF, we used to pass newlib include path as an extra include
directory, so newlib’s stdint.h got included instead.
Newlib 2.2.0 stdatomic implementation is compatible with -std=gnu99
but incompatible with -std=gnu11. And GCC doesn’t support atomic_load
with -std=gnu99 (it’s a C11 feature). So when we used atomic_load
with -std=gnu99, it worked due to newlib’s header.
Since we are no longer going to be including newlib headers into IDF,
GCC stdatomic will be used instead. Hence, add -std=gnu11 for source
files which use atomic features.
Vikram Dattu [Tue, 26 Mar 2019 08:45:46 +0000 (16:45 +0800)]
Fix url redirection issue.
Operation:
In `esp_http_client_set_url`, we check for if old_host is same as new_host.
Delete and open new connection if host is different.
Issue:
We just pointed `client->connection_info.host` to `old_host` and reassigned it.
This made old_host and new_host always point to same location and hence, using old_host with new request.
Fix:
Made a separate copy for old_host using strdup.
Closes https://github.com/espressif/esp-idf/issues/2631
Signed-off-by: Vikram Dattu <vikram.dattu@espressif.com>
Angus Gratton [Wed, 10 Apr 2019 05:07:52 +0000 (13:07 +0800)]
Merge branch 'bugfix/make_bootloader_depends_on_target' into 'master'
make bootloader depend on IDF_TARGET
See merge request idf/esp-idf!4704
XiaXiaotian [Mon, 25 Mar 2019 06:13:09 +0000 (14:13 +0800)]
esp32_wifi: fix the issue that the spike transmit power of WiFi is higher
than configured when WiFi and Bluetooth coexist
Jiang Jiang Jian [Tue, 9 Apr 2019 12:45:21 +0000 (20:45 +0800)]
Merge branch 'bugfix/increase_block_scan_timeout_value' into 'master'
esp_wifi: increase block scan timeout value
Closes WIFI-396
See merge request idf/esp-idf!4695
Wangjialin [Thu, 28 Mar 2019 13:31:14 +0000 (21:31 +0800)]
bugfix(psram): improve spi cs timing settings for psram
1. remove redundant SPI clock settings, use rom functions to set clock.
2. remove redundant SPI cs setup and hold settings.
3. for old 32Mbit psram, cs hold time must only be 0.5T due to the special driving mode.(cs_setup = 0; cs_hold = 0)
4. for new 64Mbit psram, cs hold time is recommended to be 2.5T. (cs_setup = 1, cs_setup_time = 0;cs_hold = 1, cs_hold_time = 1)
Angus Gratton [Tue, 9 Apr 2019 02:19:47 +0000 (10:19 +0800)]
Merge branch 'bugfix/ws_transport_crash_on_connect_fail' into 'master'
transport_ws: Stop connecting when the parent's connect call has failed
See merge request idf/esp-idf!4701
Angus Gratton [Tue, 9 Apr 2019 01:28:18 +0000 (09:28 +0800)]
Merge branch 'bugfix/prov_fix_conn_id' into 'master'
Unified Provisioning: Miscellaneous fixes in BLE
See merge request idf/esp-idf!4691
liu zhifu [Mon, 8 Apr 2019 11:58:51 +0000 (19:58 +0800)]
esp_wifi: increase WiFi block scan timeout value
Increase WiFi block scan internal timeout value.
Angus Gratton [Tue, 9 Apr 2019 01:18:44 +0000 (09:18 +0800)]
Merge branch 'fix/mfg_util_todo_leftback' into 'master'
mfg_util: Remove to-do line leftback
See merge request idf/esp-idf!4707
Angus Gratton [Tue, 9 Apr 2019 00:10:06 +0000 (08:10 +0800)]
Merge branch 'bugfix/bootloader_flash_crypt_cnt_ff' into 'master'
flash encryption: reduce FLASH_CRYPT_CNT bit width to 7 bits
See merge request idf/esp-idf!4642
Jiang Jiang Jian [Mon, 8 Apr 2019 11:38:23 +0000 (19:38 +0800)]
Merge branch 'bugfix/wifi_fix_no_tbtt_after_rx_wrong_beacon' into 'master'
esp_wifi: fix the bug that no TBTT will be generated anymore after receiving wrong beacon when WiFi and BT coexist.
Closes IDF-589
See merge request idf/esp-idf!4716
suda-morris [Thu, 4 Apr 2019 07:20:24 +0000 (15:20 +0800)]
make bootloader depend on IDF_TARGET
XiaXiaotian [Mon, 8 Apr 2019 02:36:29 +0000 (10:36 +0800)]
esp_wifi: fix the bug that no TBTT will be generated anymore after receiving
wrong beacon when WiFi and BT coexist.
Hrishikesh Dhayagude [Wed, 3 Apr 2019 10:15:34 +0000 (15:45 +0530)]
Unified Provisioning: Miscellaneous fixes in BLE
1. Pass the correct conn_id to protocomm_req_handle
In transport_simple_ble_write(), passing param->exec_write.conn_id would
be invalid. Instead param->write.conn_id should be passed
Similar change in transport_simple_ble_exec_write() to use
param->exec_write.conn_id
2. simple_ble_start() assumes that the mode is BLE only and enables
Bluetooth controller accordingly. For, cases having BT + BLE like Alexa
(Provisioning over BLE + Audio over classic BT), this assumption should
be removed.
Angus Gratton [Thu, 4 Apr 2019 23:19:22 +0000 (07:19 +0800)]
Merge branch 'feature/common_fragment_grammar' into 'master'
ldgen: Common fragment grammar
See merge request idf/esp-idf!4576
Bas Verhoeven [Tue, 12 Mar 2019 09:44:27 +0000 (10:44 +0100)]
transport_ws: Stop connecting when the parent's connect call has failed
Merges https://github.com/espressif/esp-idf/pull/3164
Jiang Jiang Jian [Thu, 4 Apr 2019 12:53:04 +0000 (20:53 +0800)]
Merge branch 'bugfix/coex_bt_disconn' into 'master'
components/coex: Fix BT disconnecting due to too many reset BB
See merge request idf/esp-idf!4675
zhiweijian [Thu, 4 Apr 2019 11:49:23 +0000 (19:49 +0800)]
component/bt: fix memory leak when settig tx power
Jiang Jiang Jian [Thu, 4 Apr 2019 10:45:25 +0000 (18:45 +0800)]
Merge branch 'bugfix/btdm_fix_warning_when_disable_logs' into 'master'
components/bt: Fix warning when disable debug logs or in release mode and improve the code structure
See merge request idf/esp-idf!4618
Jiang Jiang Jian [Thu, 4 Apr 2019 10:44:53 +0000 (18:44 +0800)]
Merge branch 'bugfix/btdm_disconn_with_apple_device' into 'master'
components/bt: Fix disconnect with apple device
See merge request idf/esp-idf!4665
Renz Christian Bagaporo [Tue, 2 Apr 2019 08:40:43 +0000 (16:40 +0800)]
ldgen: add backward-compatibility with previous mapping fragment style
Renz Christian Bagaporo [Tue, 19 Mar 2019 10:44:16 +0000 (18:44 +0800)]
docs: update linker script generation docs
Shivani Tipnis [Thu, 4 Apr 2019 08:29:52 +0000 (13:59 +0530)]
mfg_util: Remove todo line leftback
Renz Christian Bagaporo [Tue, 19 Mar 2019 06:19:39 +0000 (14:19 +0800)]
ldgen: update component linker fragment files
Renz Christian Bagaporo [Tue, 19 Mar 2019 06:36:04 +0000 (14:36 +0800)]
ldgen: update tests for common fragment parsing
Renz Christian Bagaporo [Tue, 19 Mar 2019 06:35:47 +0000 (14:35 +0800)]
ldgen: implement common fragment parsing
Krzysztof Budzynski [Thu, 4 Apr 2019 07:40:56 +0000 (15:40 +0800)]
Merge branch 'doc/fix-an-important-typo-in-Getting-Started-Guide' into 'master'
Fixed a typo that cannot wait
See merge request idf/esp-idf!4685
Angus Gratton [Thu, 4 Apr 2019 06:40:33 +0000 (14:40 +0800)]
Merge branch 'update/mfg_util' into 'master'
mfg_util: Add changes to mfg_util as per changes in nvs_util
See merge request idf/esp-idf!3573
Angus Gratton [Thu, 4 Apr 2019 06:26:49 +0000 (14:26 +0800)]
Merge branch 'bugfix/httpd_accept_conn' into 'master'
esp_http_server : Only accept new connections if server has capacity to handle more
Closes IDFGH-749
See merge request idf/esp-idf!4655
Angus Gratton [Thu, 4 Apr 2019 06:26:48 +0000 (14:26 +0800)]
Merge branch 'feature/micro-ecc-only-in-bootloader' into 'master'
Use micro_ecc library only in bootloader
See merge request idf/esp-idf!4082
Angus Gratton [Thu, 4 Apr 2019 03:16:46 +0000 (11:16 +0800)]
Merge branch 'feature/misc_adjustment_of_esp32' into 'master'
misc adjustment of esp32 component
Closes IDF-36
See merge request idf/esp-idf!4627
Angus Gratton [Wed, 3 Apr 2019 23:42:24 +0000 (07:42 +0800)]
Merge branch 'bugfix/soc_register_struct_names' into 'master'
soc:Added names to anonymous register structs
See merge request idf/esp-idf!4668
Anurag Kar [Wed, 3 Apr 2019 13:31:40 +0000 (19:01 +0530)]
esp_http_server : Test added to check limit on max_open_sockets config option
Anurag Kar [Mon, 1 Apr 2019 09:22:04 +0000 (14:52 +0530)]
esp_http_server : Only accept new connections if server has capacity to handle more
This fix prevents HTTP server from accepting new connections when the total count of connected
sockets has reached the max_open_sockets limit set during configuration. The pending connections
are kept in backlog until atleast one of the connected sockets is closed. The maximum number of
connection requests that can kept in backlog is specified as backlog_conn configuration option.
Note that this modification has no effect when LRU purge is enabled.
Also added sanity check on setting for max_open_sockets during configuration.
Solution suggested by jimparis https://github.com/espressif/esp-idf/issues/3183#issue-
421234265
Closes https://github.com/espressif/esp-idf/issues/3183
baohongde [Wed, 3 Apr 2019 12:42:03 +0000 (20:42 +0800)]
components/coex: Fix BT disconnecting due to too many reset BB
Update coex version to 1.1.6
morris [Tue, 26 Mar 2019 08:30:43 +0000 (16:30 +0800)]
misc adjustment of esp32 component
liying [Wed, 3 Apr 2019 10:34:34 +0000 (18:34 +0800)]
Fix a very important typo that cannot wait
baohongde [Wed, 3 Apr 2019 09:22:01 +0000 (17:22 +0800)]
components/bt: Fix disconnect with apple device
1. Fix disconnect with apple device
2. Fix hci_refresh_enc_key_cmd will be ignored
3. Fix hci_refresh_enc_key_cmd will crash
Closes https://github.com/espressif/esp-idf/issues/3140
Shivani Tipnis [Mon, 29 Oct 2018 07:49:20 +0000 (13:19 +0530)]
mfg_util: Add changes to mfg_util as per changes in nvs_util
revert changeson this file
Update README for mfg util
Update to correct coding style of script
Angus Gratton [Wed, 3 Apr 2019 03:12:51 +0000 (11:12 +0800)]
Merge branch 'feature/support_comments_in_csv' into 'master'
nvs_util: Add support to include comments in csv file
See merge request idf/esp-idf!4656
huub [Sun, 24 Mar 2019 21:24:05 +0000 (22:24 +0100)]
soc:Added names to anonymous register structs
For typedef volatile struct in components/soc/esp32/include/soc
Merges https://github.com/espressif/esp-idf/pull/3199