]> granicus.if.org Git - sudo/log
sudo
9 years agodisable_coredump can be set to no on modern OSes without
Todd C. Miller [Sun, 9 Aug 2015 22:12:00 +0000 (16:12 -0600)]
disable_coredump can be set to no on modern OSes without
security consequences.

9 years agoEmphasis on the never.
Todd C. Miller [Fri, 7 Aug 2015 23:05:50 +0000 (17:05 -0600)]
Emphasis on the never.

9 years agoExplicitly tell people not to grant sudoedit to directories the
Todd C. Miller [Fri, 7 Aug 2015 23:01:15 +0000 (17:01 -0600)]
Explicitly tell people not to grant sudoedit to directories the
user can write to.  While sudoedit will no longer open symbolic
links, hard links are still an issue.

9 years agoAdd warning about writable directories and sudo/sudoedit.
Todd C. Miller [Fri, 7 Aug 2015 23:00:42 +0000 (17:00 -0600)]
Add warning about writable directories and sudo/sudoedit.

9 years agoEmphasize that wildcards are not regexps. Bug #692
Todd C. Miller [Fri, 7 Aug 2015 18:37:15 +0000 (12:37 -0600)]
Emphasize that wildcards are not regexps.  Bug #692

9 years agoEmphasize that wildcards in command line arguments are dangerous.
Todd C. Miller [Fri, 7 Aug 2015 18:21:37 +0000 (12:21 -0600)]
Emphasize that wildcards in command line arguments are dangerous.
Document the failings of the passwd example on GNU systems.
Bug #691

9 years agoEscape the colons in [[:alpha:]] as required by sudoers.
Todd C. Miller [Fri, 7 Aug 2015 18:00:12 +0000 (12:00 -0600)]
Escape the colons in [[:alpha:]] as required by sudoers.

9 years agoChange warning when user tries to sudoedit a symbolic link.
Todd C. Miller [Fri, 7 Aug 2015 13:09:01 +0000 (07:09 -0600)]
Change warning when user tries to sudoedit a symbolic link.

9 years agoregen
Todd C. Miller [Thu, 6 Aug 2015 19:21:37 +0000 (13:21 -0600)]
regen

9 years agoregen
Todd C. Miller [Thu, 6 Aug 2015 19:20:36 +0000 (13:20 -0600)]
regen

9 years agoDo not follow symbolic links in sudoedit by default. This behavior
Todd C. Miller [Thu, 6 Aug 2015 19:20:01 +0000 (13:20 -0600)]
Do not follow symbolic links in sudoedit by default.  This behavior
can be controlled by the sudoedit_follow Defaults flag as well as
the FOLLOW/NOFOLLOW tags.

9 years agoSudo 1.8.15
Todd C. Miller [Thu, 6 Aug 2015 19:15:00 +0000 (13:15 -0600)]
Sudo 1.8.15

9 years agoadd .json regress files to MANIFEST
Todd C. Miller [Thu, 6 Aug 2015 19:39:59 +0000 (13:39 -0600)]
add .json regress files to MANIFEST

9 years agoCheck JSON output of sudoers test files too.
Todd C. Miller [Thu, 6 Aug 2015 16:57:42 +0000 (10:57 -0600)]
Check JSON output of sudoers test files too.

9 years agoMove comment to match moved code.
Todd C. Miller [Tue, 4 Aug 2015 22:15:11 +0000 (16:15 -0600)]
Move comment to match moved code.

9 years agomaxseq is an int not a string
Todd C. Miller [Tue, 4 Aug 2015 17:28:43 +0000 (11:28 -0600)]
maxseq is an int not a string

9 years agoInclude sys/types.h for id_t. Bug #711
Todd C. Miller [Mon, 3 Aug 2015 01:59:32 +0000 (19:59 -0600)]
Include sys/types.h for id_t.  Bug #711

9 years agoAvoid a potential out of bounds read found by enh while fuzzing
Todd C. Miller [Fri, 31 Jul 2015 22:10:03 +0000 (16:10 -0600)]
Avoid a potential out of bounds read found by enh while fuzzing
with address sanitizer enabled.

9 years agoSet sssd lib location to /usr/lib64 on 64-bit RHEL/Centos.
Todd C. Miller [Mon, 27 Jul 2015 13:07:38 +0000 (07:07 -0600)]
Set sssd lib location to /usr/lib64 on 64-bit RHEL/Centos.
Bug #710

9 years agoAdd Jakub Wilk
Todd C. Miller [Wed, 8 Jul 2015 21:14:55 +0000 (15:14 -0600)]
Add Jakub Wilk

9 years agoThe init.d files are generated from a .in file so we need to install
Todd C. Miller [Fri, 24 Jul 2015 19:38:03 +0000 (13:38 -0600)]
The init.d files are generated from a .in file so we need to install
from top_builddir not top_srcdir.  From Ross Burton.  Bug #708

9 years agoReplace two "return 0" with debug_return_bool(false).
Todd C. Miller [Thu, 23 Jul 2015 01:11:32 +0000 (19:11 -0600)]
Replace two "return 0" with debug_return_bool(false).

9 years agofix typo in previous commit
Todd C. Miller [Wed, 22 Jul 2015 12:21:21 +0000 (06:21 -0600)]
fix typo in previous commit

9 years agoSudo 1.8.14p3
Todd C. Miller [Wed, 22 Jul 2015 12:09:14 +0000 (06:09 -0600)]
Sudo 1.8.14p3

9 years agoFix errno value from get_process_ttyname() when no tty is present.
Todd C. Miller [Tue, 21 Jul 2015 21:20:49 +0000 (15:20 -0600)]
Fix errno value from get_process_ttyname() when no tty is present.

9 years agoOn AIX, only convert the tty device number from dev64_t to dev32_t
Todd C. Miller [Tue, 21 Jul 2015 21:02:56 +0000 (15:02 -0600)]
On AIX, only convert the tty device number from dev64_t to dev32_t
if dev_t is 32-bits.

9 years agoSudo 1.8.14p2
Todd C. Miller [Tue, 21 Jul 2015 02:27:40 +0000 (20:27 -0600)]
Sudo 1.8.14p2

9 years agoFix creation of the timestamp file; bug #704
Todd C. Miller [Tue, 21 Jul 2015 02:16:14 +0000 (20:16 -0600)]
Fix creation of the timestamp file; bug #704

9 years agoAvoid needless memory allocation when resolving the tty name.
Todd C. Miller [Mon, 20 Jul 2015 02:19:22 +0000 (20:19 -0600)]
Avoid needless memory allocation when resolving the tty name.

9 years agoSudo 1.8.14p1
Todd C. Miller [Fri, 17 Jul 2015 21:28:26 +0000 (15:28 -0600)]
Sudo 1.8.14p1

9 years agoFix typo in sudo_sss_attrcpy() that caused a memory allocation error.
Todd C. Miller [Fri, 17 Jul 2015 19:58:26 +0000 (13:58 -0600)]
Fix typo in sudo_sss_attrcpy() that caused a memory allocation error.

9 years agorebuild
Todd C. Miller [Wed, 15 Jul 2015 18:36:02 +0000 (12:36 -0600)]
rebuild

9 years agoAdd some debugging printfs when malloc fails and we don't have an
Todd C. Miller [Tue, 14 Jul 2015 21:28:01 +0000 (15:28 -0600)]
Add some debugging printfs when malloc fails and we don't have an
explicit call to sudo_warnx().

9 years agoAdd missing warnings for memory allocation failure.
Todd C. Miller [Tue, 14 Jul 2015 20:50:36 +0000 (14:50 -0600)]
Add missing warnings for memory allocation failure.
Add function name to memory allocation warnings.

9 years agoReturn -1 if realloc() fails.
Todd C. Miller [Tue, 14 Jul 2015 20:48:04 +0000 (14:48 -0600)]
Return -1 if realloc() fails.

9 years agoAdd line number to debug log for memory allocation errors.
Todd C. Miller [Tue, 14 Jul 2015 20:47:12 +0000 (14:47 -0600)]
Add line number to debug log for memory allocation errors.

9 years agoAdd warning if calloc() fails.
Todd C. Miller [Tue, 14 Jul 2015 20:00:18 +0000 (14:00 -0600)]
Add warning if calloc() fails.
Add debugging for other unexpected errors.

9 years agoAdd missing check for calloc(3) return value.
Todd C. Miller [Tue, 14 Jul 2015 19:56:29 +0000 (13:56 -0600)]
Add missing check for calloc(3) return value.

9 years agoDocument that the values printed by "sudo -V" are affected by
Todd C. Miller [Mon, 13 Jul 2015 18:58:25 +0000 (12:58 -0600)]
Document that the values printed by "sudo -V" are affected by
Defaults settings in sudoers.

9 years agoAvoid calling dlerror() multiple times since it clear the error
Todd C. Miller [Fri, 10 Jul 2015 16:31:21 +0000 (10:31 -0600)]
Avoid calling dlerror() multiple times since it clear the error
status after printing the error.
Problem caused by sudo_warn/sudo_fatal being macros...

9 years agoAttempt to clarify the conditions under which MAIL and HOME are
Todd C. Miller [Fri, 10 Jul 2015 16:02:38 +0000 (10:02 -0600)]
Attempt to clarify the conditions under which MAIL and HOME are
set to the target user.

9 years agoBetter checks for the libaudit package for Debian and error out
Todd C. Miller [Thu, 9 Jul 2015 19:01:43 +0000 (13:01 -0600)]
Better checks for the libaudit package for Debian and error out
if we can't figure it out.

9 years agoFix linux_audit setting on non-multiarch Debian.
Todd C. Miller [Thu, 9 Jul 2015 17:36:51 +0000 (11:36 -0600)]
Fix linux_audit setting on non-multiarch Debian.

9 years agoFix typo that broke the linux_audit dependency on Debian.
Todd C. Miller [Thu, 9 Jul 2015 17:06:03 +0000 (11:06 -0600)]
Fix typo that broke the linux_audit dependency on Debian.

9 years agoMention /proc/stat btime fix.
Todd C. Miller [Thu, 9 Jul 2015 16:45:33 +0000 (10:45 -0600)]
Mention /proc/stat btime fix.

9 years agoSolaris 2.6 has the prototypes for inet_pton() and inet_ntop() in
Todd C. Miller [Thu, 9 Jul 2015 16:11:25 +0000 (10:11 -0600)]
Solaris 2.6 has the prototypes for inet_pton() and inet_ntop() in
resolv.h.

9 years agoSprinkle debugging for boottime.
Todd C. Miller [Thu, 9 Jul 2015 16:10:34 +0000 (10:10 -0600)]
Sprinkle debugging for boottime.

9 years agoThe old Solaris /bin/sh doesn't support POSIX $( .. ) syntax,
Todd C. Miller [Thu, 9 Jul 2015 15:34:22 +0000 (09:34 -0600)]
The old Solaris /bin/sh doesn't support POSIX $( .. ) syntax,
use backquotes instead.

9 years agoOnly use --with-sssd-lib on Debian/Ubuntu w/ multipackage.
Todd C. Miller [Thu, 9 Jul 2015 00:13:39 +0000 (18:13 -0600)]
Only use --with-sssd-lib on Debian/Ubuntu w/ multipackage.
Use dpkg-query to determine the name of the audit package
for proper dependencies.

9 years agoUpdate Debian/Ubuntu packages to be more like the vendor ones. One
Todd C. Miller [Wed, 8 Jul 2015 22:15:53 +0000 (16:15 -0600)]
Update Debian/Ubuntu packages to be more like the vendor ones.  One
notable exception is that sudo.ws packages use /var/run, not /var/lib
for timestamp files.

9 years agoStrip newline from /proc/stat btime line to avoid a strtonum() failure.
Todd C. Miller [Wed, 8 Jul 2015 21:13:14 +0000 (15:13 -0600)]
Strip newline from /proc/stat btime line to avoid a strtonum() failure.
From Jakub Wilk.

9 years agoIn io_callback() service writes before reads. That way, if both
Todd C. Miller [Wed, 8 Jul 2015 16:12:15 +0000 (10:12 -0600)]
In io_callback() service writes before reads.  That way, if both
SUDO_EV_READ and SUDO_EV_WRITE are set and read() returns 0 (EOF)
we don't close the fd before the write() is performed.

If the write() returns EPIPE, ENXIO, EIO or EBADF, clear SUDO_EV_READ
before we close the fd to avoid calling read() on a closed fd.

9 years agoCheck sudo_conf_read() return value and exit on fatal error (a
Todd C. Miller [Tue, 7 Jul 2015 19:17:50 +0000 (13:17 -0600)]
Check sudo_conf_read() return value and exit on fatal error (a
warning was already printed by sudo_conf_read()).

9 years agoMention double-quoted sudoOption value support.
Todd C. Miller [Tue, 7 Jul 2015 17:28:49 +0000 (11:28 -0600)]
Mention double-quoted sudoOption value support.

9 years agoAdd support for parsing quoted strings in a sudoOption just like
Todd C. Miller [Tue, 7 Jul 2015 16:58:05 +0000 (10:58 -0600)]
Add support for parsing quoted strings in a sudoOption just like
sudoers Defaults settings.

9 years agoSync with translationproject.org
Todd C. Miller [Tue, 7 Jul 2015 16:34:37 +0000 (10:34 -0600)]
Sync with translationproject.org

9 years agoUpdate year.
Todd C. Miller [Mon, 6 Jul 2015 22:45:33 +0000 (16:45 -0600)]
Update year.

9 years agoSync with translationproject.org
Todd C. Miller [Mon, 6 Jul 2015 22:44:23 +0000 (16:44 -0600)]
Sync with translationproject.org

9 years agoFix utmp setup broken by commit be0ca60facf8
Todd C. Miller [Mon, 6 Jul 2015 19:56:39 +0000 (13:56 -0600)]
Fix utmp setup broken by commit be0ca60facf8

9 years agoSync with translationproject.org
Todd C. Miller [Fri, 3 Jul 2015 13:28:00 +0000 (07:28 -0600)]
Sync with translationproject.org

9 years agoregen
Todd C. Miller [Fri, 3 Jul 2015 13:12:30 +0000 (07:12 -0600)]
regen

9 years agoFix typo in error message.
Todd C. Miller [Fri, 3 Jul 2015 13:06:29 +0000 (07:06 -0600)]
Fix typo in error message.

9 years agoBug #702 is the AIX timespec issue.
Todd C. Miller [Thu, 2 Jul 2015 20:06:16 +0000 (14:06 -0600)]
Bug #702 is the AIX timespec issue.

9 years agoWe require POSIX so no need to conditionally include dirent.h.
Todd C. Miller [Thu, 2 Jul 2015 15:24:48 +0000 (09:24 -0600)]
We require POSIX so no need to conditionally include dirent.h.
Add a check for d_namlen and use the result in the NAMLEN macro.

9 years agoThere's no need to conditionalize the #include <unistd.h>, we require
Todd C. Miller [Thu, 2 Jul 2015 15:08:28 +0000 (09:08 -0600)]
There's no need to conditionalize the #include <unistd.h>, we require
a POSIX system.

9 years agoRemove some compatibilty defines that should no longer be needed.
Todd C. Miller [Thu, 2 Jul 2015 15:07:15 +0000 (09:07 -0600)]
Remove some compatibilty defines that should no longer be needed.

9 years agoFinal changes in 1.8.14
Todd C. Miller [Tue, 30 Jun 2015 20:29:39 +0000 (14:29 -0600)]
Final changes in 1.8.14

9 years agoNeed to include stddef.h to get rsize_t on Mac OS X for sudo_memset_s()
Todd C. Miller [Tue, 30 Jun 2015 20:11:53 +0000 (14:11 -0600)]
Need to include stddef.h to get rsize_t on Mac OS X for sudo_memset_s()
prototype.

9 years agoAdd missing exit value.
Todd C. Miller [Tue, 30 Jun 2015 18:19:24 +0000 (12:19 -0600)]
Add missing exit value.

9 years agoAdd missing fcntl.h include.
Todd C. Miller [Tue, 30 Jun 2015 18:19:17 +0000 (12:19 -0600)]
Add missing fcntl.h include.

9 years agoDo check for inet_pton before inet_ntop since we may need to record
Todd C. Miller [Tue, 30 Jun 2015 16:57:42 +0000 (10:57 -0600)]
Do check for inet_pton before inet_ntop since we may need to record
dependent libraries for inet_pton when linking our getaddrinfo
replacement.

9 years agoFix build on compilers w/o __func__ or __FUNCTION__
Todd C. Miller [Tue, 30 Jun 2015 16:41:14 +0000 (10:41 -0600)]
Fix build on compilers w/o __func__ or __FUNCTION__

9 years agoRemove sudo_evasprintf_v1, missed during alloc.c removal.
Todd C. Miller [Tue, 30 Jun 2015 16:37:06 +0000 (10:37 -0600)]
Remove sudo_evasprintf_v1, missed during alloc.c removal.

9 years agoAdd missing fcntl.h include.
Todd C. Miller [Tue, 30 Jun 2015 16:32:42 +0000 (10:32 -0600)]
Add missing fcntl.h include.

9 years agoAdd check for inline support.
Todd C. Miller [Tue, 30 Jun 2015 16:16:56 +0000 (10:16 -0600)]
Add check for inline support.

9 years agoAdd reallocarray.c license.
Todd C. Miller [Mon, 29 Jun 2015 14:16:43 +0000 (08:16 -0600)]
Add reallocarray.c license.

9 years agoFix entry for Joel Pelaez Jorge.
Todd C. Miller [Sat, 27 Jun 2015 20:01:09 +0000 (14:01 -0600)]
Fix entry for Joel Pelaez Jorge.

9 years agoAdd an error flag to the lbuf struct to simplify error checking.
Todd C. Miller [Fri, 26 Jun 2015 21:58:04 +0000 (15:58 -0600)]
Add an error flag to the lbuf struct to simplify error checking.
Callers of the lbuf functions now check the error flag to tell if
a memory allocation error ocurred.

9 years agodisplay_privs() and display_cmnd() may need to return -1 on error.
Todd C. Miller [Fri, 26 Jun 2015 16:33:28 +0000 (10:33 -0600)]
display_privs() and display_cmnd() may need to return -1 on error.

9 years agoReturn -1, not 0 from sudoers when there is an error (as opposed to
Todd C. Miller [Thu, 25 Jun 2015 17:12:36 +0000 (11:12 -0600)]
Return -1, not 0 from sudoers when there is an error (as opposed to
a policy denial).

9 years agoCheck restore_perms() return value in all cases, pushing the
Todd C. Miller [Thu, 25 Jun 2015 17:12:36 +0000 (11:12 -0600)]
Check restore_perms() return value in all cases, pushing the
return value back up the call stack.

9 years agoAdd Joel Pelaez Jorge
Todd C. Miller [Thu, 25 Jun 2015 15:16:07 +0000 (09:16 -0600)]
Add Joel Pelaez Jorge

9 years agoWhen checking whether the PAM prompt matches "Password:", also check
Todd C. Miller [Thu, 25 Jun 2015 15:12:15 +0000 (09:12 -0600)]
When checking whether the PAM prompt matches "Password:", also check
for the untranslated version.  The PAM module might not be using the
localized string even though it exists.  From Joel Pelaez Jorge.
Fixes Bug #701

9 years agoSilence clang analyzer warning on glibc systems where the first
Todd C. Miller [Wed, 24 Jun 2015 16:32:08 +0000 (10:32 -0600)]
Silence clang analyzer warning on glibc systems where the first
argument to qsort() is marked as non-NULL.
Also change some counters from into to unsigned int and two flags
from int to bool.

9 years agoSilence clang analyzer warning on glibc systems where the first
Todd C. Miller [Tue, 23 Jun 2015 22:37:01 +0000 (16:37 -0600)]
Silence clang analyzer warning on glibc systems where the first
argument to qsort() is marked as non-NULL.

9 years agoUse our own bitmap macros instead of borrowing the ones from select.
Todd C. Miller [Tue, 23 Jun 2015 22:37:00 +0000 (16:37 -0600)]
Use our own bitmap macros instead of borrowing the ones from select.

9 years agoQuiet clang analyzer false positive.
Todd C. Miller [Tue, 23 Jun 2015 18:58:02 +0000 (12:58 -0600)]
Quiet clang analyzer false positive.

9 years agoFix uninitialized variables warnings in error case when src file
Todd C. Miller [Tue, 23 Jun 2015 18:57:47 +0000 (12:57 -0600)]
Fix uninitialized variables warnings in error case when src file
cannot be opened.  At least one of these is a false positive.

9 years agoMust call round_nfds() with fd+1 since it takes a count not the fd
Todd C. Miller [Tue, 23 Jun 2015 19:49:56 +0000 (13:49 -0600)]
Must call round_nfds() with fd+1 since it takes a count not the fd
number.  In other words, the lowest value is 1, not 0.

9 years agoIt's safe to rely on C89 semantics for realloc(NULL, size).
Todd C. Miller [Sun, 21 Jun 2015 01:27:31 +0000 (19:27 -0600)]
It's safe to rely on C89 semantics for realloc(NULL, size).

9 years agomalloc() sets errno to ENOMEM on failure so we don't need to set
Todd C. Miller [Sun, 21 Jun 2015 01:26:43 +0000 (19:26 -0600)]
malloc() sets errno to ENOMEM on failure so we don't need to set
it explicitly.

9 years agoNo longer need __malloc_like
Todd C. Miller [Sat, 20 Jun 2015 22:56:57 +0000 (16:56 -0600)]
No longer need __malloc_like

9 years agoRemove symbols from the now-removed alloc.c.
Todd C. Miller [Sat, 20 Jun 2015 22:56:42 +0000 (16:56 -0600)]
Remove symbols from the now-removed alloc.c.

9 years agoOnly include stddef.h where it is needed.
Todd C. Miller [Sat, 20 Jun 2015 11:34:35 +0000 (05:34 -0600)]
Only include stddef.h where it is needed.

9 years agoregen
Todd C. Miller [Fri, 19 Jun 2015 22:50:54 +0000 (16:50 -0600)]
regen

9 years agoBetter handling of setlocale() returning NULL.
Todd C. Miller [Fri, 19 Jun 2015 22:49:02 +0000 (16:49 -0600)]
Better handling of setlocale() returning NULL.

9 years agoAdd function name to "unable to allocate memory" warnings.
Todd C. Miller [Fri, 19 Jun 2015 20:51:17 +0000 (14:51 -0600)]
Add function name to "unable to allocate memory" warnings.

9 years agoWe require ANSI C so stop using the obsolete STDC_HEADERS.
Todd C. Miller [Fri, 19 Jun 2015 20:29:27 +0000 (14:29 -0600)]
We require ANSI C so stop using the obsolete STDC_HEADERS.

9 years agoAdd back _REENTRANT define on HP-UX to expose strtok_r on some versions.
Todd C. Miller [Fri, 19 Jun 2015 18:35:51 +0000 (12:35 -0600)]
Add back _REENTRANT define on HP-UX to expose strtok_r on some versions.
We may need to define it on other systems too.

9 years agoUse strtok_r() instead of strtok()
Todd C. Miller [Fri, 19 Jun 2015 18:35:51 +0000 (12:35 -0600)]
Use strtok_r() instead of strtok()