]> granicus.if.org Git - openjpeg/log
openjpeg
8 years agoFix coverity 113065 (CWE-484) (#824)
Matthieu Darbois [Thu, 8 Sep 2016 20:14:19 +0000 (22:14 +0200)]
Fix coverity 113065 (CWE-484) (#824)

8 years agoUpdate THANKS.md
Antonin Descampe [Thu, 8 Sep 2016 09:28:58 +0000 (11:28 +0200)]
Update THANKS.md

8 years agoCast to size_t before multiplication
Matthieu Darbois [Thu, 8 Sep 2016 05:34:46 +0000 (07:34 +0200)]
Cast to size_t before multiplication

Need to cast to size_t before multiplication otherwise overflow check is useless.

8 years agoAdd sanity check for tile coordinates (#823)
Matthieu Darbois [Wed, 7 Sep 2016 22:24:15 +0000 (00:24 +0200)]
Add sanity check for tile coordinates (#823)

Coordinates are casted from OPJ_UINT32 to OPJ_INT32
Add sanity check for negative values and upper bound becoming lower
than lower bound.
See also
https://pdfium.googlesource.com/pdfium/+/b6befb2ed2485a3805cddea86dc7574510178ea9

8 years agoAdd test for PR 818 (#822)
Matthieu Darbois [Tue, 6 Sep 2016 22:00:21 +0000 (00:00 +0200)]
Add test for PR 818 (#822)

update uclouvain/openjpeg#818

8 years agoUpdate to libpng 1.6.25 (#821)
Matthieu Darbois [Tue, 6 Sep 2016 20:33:45 +0000 (22:33 +0200)]
Update to libpng 1.6.25 (#821)

8 years agofix incrementing of "l_tcp->m_nb_mcc_records" in opj_j2k_read_mcc (#820)
Matthieu Darbois [Tue, 6 Sep 2016 20:33:26 +0000 (22:33 +0200)]
fix incrementing of "l_tcp->m_nb_mcc_records" in opj_j2k_read_mcc (#820)

8 years agoFix an integer overflow issue (#809)
trylab [Tue, 6 Sep 2016 05:55:49 +0000 (13:55 +0800)]
Fix an integer overflow issue (#809)

Prevent an integer overflow issue in function opj_pi_create_decode of
pi.c.

8 years agoAdd overflow check in opj_tcd_init_tile (#819)
Matthieu Darbois [Tue, 6 Sep 2016 05:54:29 +0000 (07:54 +0200)]
Add overflow check in opj_tcd_init_tile (#819)

8 years agoFix leak & invalid behavior of opj_jp2_read_ihdr (#818)
Matthieu Darbois [Mon, 5 Sep 2016 23:31:15 +0000 (01:31 +0200)]
Fix leak & invalid behavior of opj_jp2_read_ihdr (#818)

In case multiple ihdr box are present, only the first one shall be
taken into account.

8 years agoAdd overflow check in opj_j2k_update_image_data (#817)
Matthieu Darbois [Mon, 5 Sep 2016 22:50:44 +0000 (00:50 +0200)]
Add overflow check in opj_j2k_update_image_data (#817)

8 years agoChange 'restrict' define to 'OPJ_RESTRICT' (#816)
Matthieu Darbois [Mon, 5 Sep 2016 22:49:53 +0000 (00:49 +0200)]
Change 'restrict' define to 'OPJ_RESTRICT' (#816)

Visual Studio 2015 does not pass regression tests with `__restrict` so kept disabled for MSVC.
Need to check proper usage of OPJ_RESTRICT (if correct then there’s
probably a bug  in vc14)

Closes #661

8 years agoAdd .gitignore (#787)
Stefan Weil [Mon, 5 Sep 2016 20:07:50 +0000 (22:07 +0200)]
Add .gitignore (#787)

Ignore all files and directories which are generated by `cmake . && make`.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
8 years agoSwitch to clang 3.8 (#814)
Matthieu Darbois [Fri, 2 Sep 2016 21:58:12 +0000 (23:58 +0200)]
Switch to clang 3.8 (#814)

clang 3.9 is currently unavailable for precise through apt

8 years agoUpdate to lcms 2.8 (#808)
Matthieu Darbois [Sat, 6 Aug 2016 11:04:56 +0000 (13:04 +0200)]
Update to lcms 2.8 (#808)

8 years agoUpdate to libpng 1.6.24 (#807)
Matthieu Darbois [Sat, 6 Aug 2016 10:51:40 +0000 (12:51 +0200)]
Update to libpng 1.6.24 (#807)

8 years agoReenable clang-3.9 build on travis (#806)
Matthieu Darbois [Sat, 6 Aug 2016 10:26:46 +0000 (12:26 +0200)]
Reenable clang-3.9 build on travis (#806)

clang-3.9 is now available with apt add-on in travis-ci

8 years agoAdd compilation test for standalone inclusion of openjpeg.h (#798)
Matthieu Darbois [Thu, 14 Jul 2016 09:06:26 +0000 (11:06 +0200)]
Add compilation test for standalone inclusion of openjpeg.h (#798)

This ensures all openjpeg.h dependencies are met.
Fix #673

8 years agojpwl: Remove non-portable data type u_int16_t (fix issue #796) (#797)
Stefan Weil [Thu, 14 Jul 2016 08:49:17 +0000 (10:49 +0200)]
jpwl: Remove non-portable data type u_int16_t (fix issue #796) (#797)

The type casts which used this data type can be removed by changing
the signature of function swap16. As this function is called with
unsigned variables, this change is reasonable.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
8 years agoFix dependency for pkg-config (issue #594) (#795)
Stefan Weil [Mon, 11 Jul 2016 22:45:51 +0000 (00:45 +0200)]
Fix dependency for pkg-config (issue #594) (#795)

openjpeg provides libopenjp2.pc, so the require statements must refer to
libopenjp2 instead of openjp2.
Fixes #594

Signed-off-by: Stefan Weil <sw@weilnetz.de>
8 years agoUpdate ABI tracker script
mayeut [Tue, 5 Jul 2016 22:26:37 +0000 (00:26 +0200)]
Update ABI tracker script

Disable previous version.

8 years agoUpdate ABI tracker from 2.1 to 2.1.1
mayeut [Tue, 5 Jul 2016 21:53:31 +0000 (23:53 +0200)]
Update ABI tracker from 2.1 to 2.1.1

8 years agoupdate api/abi tracker
Antonin Descampe [Tue, 5 Jul 2016 21:33:00 +0000 (23:33 +0200)]
update api/abi tracker

8 years agoAdd version 2.1.1 to ABI tracker
mayeut [Tue, 5 Jul 2016 20:12:11 +0000 (22:12 +0200)]
Add version 2.1.1 to ABI tracker

8 years agoTrigger API/ABI update on website
Antonin Descampe [Tue, 5 Jul 2016 16:10:35 +0000 (18:10 +0200)]
Trigger API/ABI update on website

8 years agoUpdate INSTALL.md
Antonin Descampe [Tue, 5 Jul 2016 14:49:10 +0000 (16:49 +0200)]
Update INSTALL.md

8 years agoUpdate AUTHORS.md
Antonin Descampe [Tue, 5 Jul 2016 14:40:27 +0000 (16:40 +0200)]
Update AUTHORS.md

8 years agoUpdate AUTHORS file
Antonin Descampe [Tue, 5 Jul 2016 14:07:16 +0000 (16:07 +0200)]
Update AUTHORS file

8 years agoUpdate INSTALL, README and THANKS file
Antonin Descampe [Tue, 5 Jul 2016 14:04:29 +0000 (16:04 +0200)]
Update INSTALL, README and THANKS file

8 years agoUpload changelog and convert some files to mardown
Antonin Descampe [Tue, 5 Jul 2016 13:29:02 +0000 (15:29 +0200)]
Upload changelog and convert some files to mardown

8 years agoRemove useless diff command in abi-check.sh
Antonin Descampe [Sun, 26 Jun 2016 18:00:37 +0000 (20:00 +0200)]
Remove useless diff command in abi-check.sh

8 years agoCorrect abi-check.sh for PR (#791)
Matthieu Darbois [Fri, 24 Jun 2016 23:09:42 +0000 (01:09 +0200)]
Correct abi-check.sh for PR (#791)

8 years agoUpdate tcd.c (#790)
maddin200 [Tue, 21 Jun 2016 20:13:57 +0000 (22:13 +0200)]
Update tcd.c (#790)

cppcheck unitialized variable

8 years agoRemove clang-3.9 build
Matthieu Darbois [Tue, 21 Jun 2016 20:09:08 +0000 (22:09 +0200)]
Remove clang-3.9 build

c.f. travis-ci/travis-ci#6120

8 years agoAutomatic upload of ABI report (end)
Antonin Descampe [Tue, 21 Jun 2016 15:41:29 +0000 (17:41 +0200)]
Automatic upload of ABI report (end)

8 years agoAutomatic upload of ABI report (ctd)
Antonin Descampe [Tue, 21 Jun 2016 15:21:08 +0000 (17:21 +0200)]
Automatic upload of ABI report (ctd)

8 years agoAutomatic upload of ABI report (ctd)
Antonin Descampe [Tue, 21 Jun 2016 14:46:38 +0000 (16:46 +0200)]
Automatic upload of ABI report (ctd)

8 years agosetup automatic upload of ABI reports
Antonin Descampe [Tue, 21 Jun 2016 14:19:06 +0000 (16:19 +0200)]
setup automatic upload of ABI reports

8 years agoWIP automatic release
Antonin Descampe [Sat, 14 May 2016 23:36:31 +0000 (01:36 +0200)]
WIP automatic release

8 years agoWIP: debug travis run script
Antonin Descampe [Sat, 14 May 2016 22:53:24 +0000 (00:53 +0200)]
WIP: debug travis run script

8 years agoUpdate travis and appveyor to enable automatic releases on tag commit
Antonin Descampe [Sat, 14 May 2016 22:42:54 +0000 (00:42 +0200)]
Update travis and appveyor to enable automatic releases on tag commit

8 years agoUpdate version number in CMakeLists.txt
Antonin Descampe [Fri, 13 May 2016 10:31:56 +0000 (12:31 +0200)]
Update version number in CMakeLists.txt

8 years agoUpdate NEWS
Antonin Descampe [Fri, 13 May 2016 10:25:55 +0000 (12:25 +0200)]
Update NEWS

8 years agoUpdate implementation of opj_calloc (#705)
Stefan Weil [Tue, 10 May 2016 20:08:49 +0000 (22:08 +0200)]
Update implementation of opj_calloc (#705)

8 years agoAdd missing source for the JPIP library and executables (issue #658) (#659)
Stefan Weil [Tue, 10 May 2016 20:02:49 +0000 (22:02 +0200)]
Add missing source for the JPIP library and executables (issue #658) (#659)

They all need opj_malloc and other functions from opc_malloc.c.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
8 years agoCorrect expected result for test of issue 495
mayeut [Sun, 8 May 2016 18:26:12 +0000 (20:26 +0200)]
Correct expected result for test of issue 495

8 years agoFix Out-of-Bounds Access in function opj_tgt_reset
mayeut [Sun, 8 May 2016 18:10:13 +0000 (20:10 +0200)]
Fix Out-of-Bounds Access in function opj_tgt_reset

Fix uclouvain/openjpeg#775

8 years agoFix Heap Buffer Overflow in function color_cmyk_to_rgb
mayeut [Sun, 8 May 2016 17:18:05 +0000 (19:18 +0200)]
Fix Heap Buffer Overflow in function color_cmyk_to_rgb

Fix uclouvain/openjpeg#774

8 years agoFix division by zero
mayeut [Sun, 8 May 2016 16:40:12 +0000 (18:40 +0200)]
Fix division by zero

Fix uclouvain/openjpeg#733

8 years agoUpdate lcms2 (#773)
Matthieu Darbois [Tue, 3 May 2016 20:22:03 +0000 (22:22 +0200)]
Update lcms2 (#773)

Update to mm2/Little-CMS@e342f44

8 years agoMerge pull request #769 from julienmalik/cmake_lowercase
julienmalik [Mon, 2 May 2016 19:57:55 +0000 (21:57 +0200)]
Merge pull request #769 from julienmalik/cmake_lowercase

Use lowercase for cmake commands consistenly

8 years agoUse lowercase for cmake commands consistenly
Julien Malik [Mon, 2 May 2016 14:03:16 +0000 (16:03 +0200)]
Use lowercase for cmake commands consistenly

Inspired from https://github.com/InsightSoftwareConsortium/ITK/blob/master/Utilities/Maintenance/HowToCreateTheCMakeCaseConversion.txt
This needs vim 7.3 and fails with vim 7.4

This also fixes a number of :
- missing empty line at end of files
- useless space at end of lines

8 years agoMerge pull request #767 from julienmalik/fix_memset_null_pointer
julienmalik [Mon, 2 May 2016 12:34:32 +0000 (14:34 +0200)]
Merge pull request #767 from julienmalik/fix_memset_null_pointer

Fix UBSan gcc warning for first arg to memset non null

8 years agoMerge pull request #768 from julienmalik/filter_clang_warnings
julienmalik [Mon, 2 May 2016 12:32:08 +0000 (14:32 +0200)]
Merge pull request #768 from julienmalik/filter_clang_warnings

Ignore clang's summary warning

8 years agoIgnore clang's summary warning
Julien Malik [Mon, 2 May 2016 10:55:43 +0000 (12:55 +0200)]
Ignore clang's summary warning

This assumes prior text has matched some other warning expression.

This reduces the warnings reported for clang build on the dashboard,
which were caused only by the "XXX warnings generated." message.
For some reason they were not reported when not using ctest launchers.

This commit allows to confidently use ctest launchers to improve
dashboard reports.

8 years agoFix UBSan gcc warning for first arg to memset non null
Julien Malik [Mon, 2 May 2016 10:13:24 +0000 (12:13 +0200)]
Fix UBSan gcc warning for first arg to memset non null

8 years agoUpdate to libtiff-4.0.6 (#764)
Matthieu Darbois [Sun, 1 May 2016 16:05:46 +0000 (18:05 +0200)]
Update to libtiff-4.0.6 (#764)

8 years agoAdd tests for recent issues
mayeut [Sat, 30 Apr 2016 16:51:36 +0000 (18:51 +0200)]
Add tests for recent issues

Update uclouvain/openjpeg#725
Update uclouvain/openjpeg#726

8 years agoUpdate lcms (#544)
Matthieu Darbois [Sat, 30 Apr 2016 15:58:04 +0000 (17:58 +0200)]
Update lcms (#544)

Update to mm2/Little-CMS@0e8234e090d6aab33f90e2eb0296f30aa0705e57

8 years agoMerge pull request #706 from mayeut/issue135
Antonin Descampe [Sat, 30 Apr 2016 11:51:01 +0000 (13:51 +0200)]
Merge pull request #706 from mayeut/issue135

Fix issue 135
The fix is legal regarding the standard but I did not manage to find out if it covers a bug in opj_t2_read_packet_data or if the file is corrupted

8 years agoFix some coverity warnings
mayeut [Sat, 30 Apr 2016 10:15:22 +0000 (12:15 +0200)]
Fix some coverity warnings

8 years agoFix bad call to fclose with NULL pointer
mayeut [Fri, 29 Apr 2016 23:50:33 +0000 (01:50 +0200)]
Fix bad call to fclose with NULL pointer

8 years agoFix warnings (#763)
Matthieu Darbois [Fri, 29 Apr 2016 23:12:16 +0000 (01:12 +0200)]
Fix warnings (#763)

8 years agoFix Out-Of-Bounds Read in sycc42x_to_rgb function (#745)
Matthieu Darbois [Fri, 29 Apr 2016 22:33:27 +0000 (00:33 +0200)]
Fix Out-Of-Bounds Read in sycc42x_to_rgb function (#745)

42x Images with an odd x0/y0 lead to subsampled component starting at the
2nd column/line.
That is offset = comp->dx * comp->x0 - image->x0 = 1

Fix #726

8 years agoFix heap-buffer-overflow in color_esycc_to_rgb (#748)
Matthieu Darbois [Fri, 29 Apr 2016 21:51:14 +0000 (23:51 +0200)]
Fix heap-buffer-overflow in color_esycc_to_rgb (#748)

When all components do not have the same dx/dy, components buffer are
read beyond their end.
Do not convert in this case.

Update uclouvain/openjpeg#725

8 years agocppcheck fix for openjp2 (#740)
julienmalik [Fri, 29 Apr 2016 21:49:17 +0000 (23:49 +0200)]
cppcheck fix for openjp2 (#740)

8 years agoCheck SSIZ is valid in opj_j2k_read_siz (#762)
Matthieu Darbois [Thu, 28 Apr 2016 17:20:14 +0000 (19:20 +0200)]
Check SSIZ is valid in opj_j2k_read_siz (#762)

8 years agoFix unsigned int overflow reported by UBSan (#761)
Matthieu Darbois [Thu, 28 Apr 2016 11:16:43 +0000 (13:16 +0200)]
Fix unsigned int overflow reported by UBSan (#761)

* Fix unsigned int overflow reported by UBSan

Please add -DOPJ_UBSAN_BUILD to CFLAGS when building with
-fsanitize=undefined,unsigned-integer-overflow

It seems clang/gcc do not allow to disable checking for block of code
other than function or file.

8 years agoFix implicit float-to-bool conversions (#752)
julienmalik [Thu, 28 Apr 2016 09:52:45 +0000 (11:52 +0200)]
Fix implicit float-to-bool conversions (#752)

8 years agoFix unsigned int overflow reported by UBSan (#759)
Matthieu Darbois [Wed, 27 Apr 2016 22:18:37 +0000 (00:18 +0200)]
Fix unsigned int overflow reported by UBSan (#759)

8 years agoFix issue 135
mayeut [Mon, 25 Jan 2016 21:16:49 +0000 (22:16 +0100)]
Fix issue 135

dwt_interleave_h.gsr105.jp2 now has the same output as kakadu
issue399 is corrupted. Only the corrupted part changes.

Update known failures for x86 MD5

NR-DEC-kodak_2layers_lrcp.j2c-31-decode-md5
NR-DEC-kodak_2layers_lrcp.j2c-32-decode-md5
NR-DEC-issue135.j2k-68-decode-md5

8 years agoAdd clang 3.9 build to Travis matrix (#753)
julienmalik [Wed, 27 Apr 2016 21:05:43 +0000 (23:05 +0200)]
Add clang 3.9 build to Travis matrix (#753)

8 years agoFix negative shift left reported by UBSan (#758)
Matthieu Darbois [Wed, 27 Apr 2016 19:56:09 +0000 (21:56 +0200)]
Fix negative shift left reported by UBSan (#758)

Follow-up of #757

This shall have no performance impact on 2’s complement machine where
the compiler replaces the multiplication by power of two (constant) by
a left shift.
Verified at least on MacOS Xcode 7.3, same assembly generated after fix.

8 years agoRemove whitespace and CR at line endings (#678)
Stefan Weil [Tue, 26 Apr 2016 20:12:11 +0000 (22:12 +0200)]
Remove whitespace and CR at line endings (#678)

Signed-off-by: Stefan Weil <sw@weilnetz.de>
8 years agoFix negative shift left reported by UBSan (#757)
Matthieu Darbois [Tue, 26 Apr 2016 20:06:06 +0000 (22:06 +0200)]
Fix negative shift left reported by UBSan (#757)

This shall have no performance impact on 2’s complement machine where
the compiler replaces the multiplication by power of two (constant) by
a left shift.
Verified at least on MacOS Xcode 7.3, same assembly generated after fix.

8 years agoDo not define __attribute__ in opj_includes.h (#751)
Matthieu Darbois [Sat, 23 Apr 2016 12:17:31 +0000 (14:17 +0200)]
Do not define __attribute__ in opj_includes.h (#751)

Fix #727

8 years agoMerge pull request #750 from mayeut/issue-729-2
Matthieu Darbois [Sat, 23 Apr 2016 08:51:46 +0000 (10:51 +0200)]
Merge pull request #750 from mayeut/issue-729-2

Allow to read/write 3/5/7/9/11/13/15 bpp TIF files

8 years agoAllow to write 3/5/7/9/11/13/15 bpp TIF files
mayeut [Fri, 22 Apr 2016 23:53:32 +0000 (01:53 +0200)]
Allow to write 3/5/7/9/11/13/15 bpp TIF files

Update uclouvain/openjpeg#729

8 years agoAllow to read 3/5/7/9/11/13/15 bpp TIF files
mayeut [Sat, 23 Apr 2016 02:24:04 +0000 (04:24 +0200)]
Allow to read 3/5/7/9/11/13/15 bpp TIF files

8 years agoMerge pull request #746 from senbox-org/update_cmake_jpylyzer
Matthieu Darbois [Fri, 22 Apr 2016 10:54:25 +0000 (12:54 +0200)]
Merge pull request #746 from senbox-org/update_cmake_jpylyzer

Update cmake & jpylyzer for travis builds

8 years agoMerge pull request #747 from julienmalik/update_libpng
Matthieu Darbois [Fri, 22 Apr 2016 08:48:40 +0000 (10:48 +0200)]
Merge pull request #747 from julienmalik/update_libpng

update libpng to from 1.6.17 to 1.6.21

8 years agoImport pnglibconf.h.prebuilt as new pnglibconf.h
Julien Malik [Thu, 21 Apr 2016 22:16:16 +0000 (00:16 +0200)]
Import pnglibconf.h.prebuilt as new pnglibconf.h

8 years agoupdate libpng to from 1.6.17 to 1.6.21
Julien Malik [Thu, 21 Apr 2016 16:49:15 +0000 (18:49 +0200)]
update libpng to from 1.6.17 to 1.6.21

8 years agoUpdate jpylyzer to 1.17.0
Julien Malik [Tue, 19 Apr 2016 13:25:42 +0000 (15:25 +0200)]
Update jpylyzer to 1.17.0

8 years agoupgrade cmake to 3.5.2
Julien Malik [Tue, 19 Apr 2016 13:22:49 +0000 (15:22 +0200)]
upgrade cmake to 3.5.2

8 years agoMerge pull request #708 from GrokImageCompression/issue_695
Antonin Descampe [Mon, 18 Apr 2016 08:51:51 +0000 (10:51 +0200)]
Merge pull request #708 from GrokImageCompression/issue_695

issue #695 MQ Encode: ensure that bp pointer never points to uninitialized memory

8 years agoMerge pull request #734 from senbox-org/opj_dump_dead_code
Antonin Descampe [Tue, 12 Apr 2016 08:48:02 +0000 (10:48 +0200)]
Merge pull request #734 from senbox-org/opj_dump_dead_code

Remove dead code in opj_dump

8 years agoMerge pull request #735 from senbox-org/cppcheck_fix_openjp2
Antonin Descampe [Tue, 12 Apr 2016 08:47:28 +0000 (10:47 +0200)]
Merge pull request #735 from senbox-org/cppcheck_fix_openjp2

Fix uninitialized variable reported by cppcheck

8 years agoFix uninitialized variable reported by cppcheck
Julien Malik [Sat, 9 Apr 2016 17:02:05 +0000 (19:02 +0200)]
Fix uninitialized variable reported by cppcheck

Also reorder initialization to follow declaration order

8 years agoRemove dead code in opj_dump
Julien Malik [Sat, 9 Apr 2016 16:34:11 +0000 (18:34 +0200)]
Remove dead code in opj_dump

8 years agosuppress valgrind error - avoid accessing uninitialized memory in mq encoder
Aaron Boxer [Sat, 30 Jan 2016 15:05:46 +0000 (10:05 -0500)]
suppress valgrind error - avoid accessing uninitialized memory in mq encoder

8 years agoissue #695 MQ Encode: ensure that bp pointer never points to uninitialized memory
Aaron Boxer [Fri, 29 Jan 2016 00:34:00 +0000 (19:34 -0500)]
issue #695 MQ Encode: ensure that bp pointer never points to uninitialized memory

8 years agofixed tile numbering
Antonin Descampe [Mon, 25 Jan 2016 16:30:43 +0000 (17:30 +0100)]
fixed tile numbering

Fixes #245

8 years agoMerge pull request #648 from stweil/alloc
Antonin Descampe [Sat, 23 Jan 2016 18:43:09 +0000 (19:43 +0100)]
Merge pull request #648 from stweil/alloc

Fix support of posix_memalloc for Linux

8 years agoUpdate known failures
mayeut [Sun, 10 Jan 2016 23:35:47 +0000 (00:35 +0100)]
Update known failures

8 years agoMerge pull request #551 from mayeut/coc-qcc
Matthieu Darbois [Sun, 10 Jan 2016 23:23:44 +0000 (00:23 +0100)]
Merge pull request #551 from mayeut/coc-qcc

Add COC/QCC in main header when needed

8 years agoMerge pull request #690 from rouault/failed_malloc_opj_dwt_encode_procedure
Mathieu Malaterre [Sat, 9 Jan 2016 13:53:29 +0000 (14:53 +0100)]
Merge pull request #690 from rouault/failed_malloc_opj_dwt_encode_procedure

[git/2.1 regression] Fix opj_write_tile() failure when numresolutions=1

8 years agoAdd comment explaining bj is not use when l_data_size == 0
Even Rouault [Sat, 9 Jan 2016 13:30:48 +0000 (14:30 +0100)]
Add comment explaining bj is not use when l_data_size == 0

8 years ago[git/2.1 regression] Fix opj_write_tile() failure when numresolutions=1
Even Rouault [Fri, 8 Jan 2016 18:38:45 +0000 (19:38 +0100)]
[git/2.1 regression] Fix opj_write_tile() failure when numresolutions=1

When trying the GDAL OpenJPEG driver against openjpeg current master HEAD,
I get failures when trying to create .jp2 files. The driver uses
opj_write_tile() and in some tests numresolutions = 1.

In openjp2/dwt.c:410, l_data_size = opj_dwt_max_resolution( tilec->resolutions,tilec->numresolutions) * (OPJ_UINT32)sizeof(OPJ_INT32);
is called and returns l_data_size = 0. Now in git opj_malloc() has a special case
for 0 to return a NULL pointer whereas previously it relied on system malloc(),
which in my case didn't return NULL.

So only test the pointer value if l_data_size != 0. This makes the GDAL
autotest suite to pass again.

8 years agoMerge pull request #687 from stweil/memalign
Matthieu Darbois [Wed, 6 Jan 2016 22:15:05 +0000 (23:15 +0100)]
Merge pull request #687 from stweil/memalign

Fix fatal crash on 64 bit Linux