Marc G. Fournier [Mon, 23 Sep 1996 08:39:53 +0000 (08:39 +0000)]
From: Bruce Momjian <maillist@candle.pha.pa.us>
To: Bryan Henderson <bryanh@giraffe.netgate.net> Cc: Postgres95-development <pg95-dev@ki.net>
Subject: Re: [PG95-DEV] DELETE statement
>
> Does the man page for DELETE need to be corrected? It gives as syntax
>
> DELETE instance_variable [FROM fromlist] [WHERE qual] .
>
> But the actual syntax appears to be
>
> DELETE FROM classname WHERE qual .
>
> --
> Bryan Henderson Phone 408-227-6803
> San Jose, California
>
Marc G. Fournier [Mon, 23 Sep 1996 08:24:13 +0000 (08:24 +0000)]
Here's a patch that I discussed recently on pg95-dev that changes the
way one creates a database system. Parts that were in "make install"
are not either in "make all" or initdb. Nothing goes in the PGDATA
directory besides user data. Creating multiple database systems is
easier.
In addition to applying the patch, it is necessary to move the file
libpq/pg_hba to backend/libpq/pg_hba.sample.
Marc G. Fournier [Sat, 21 Sep 1996 06:31:13 +0000 (06:31 +0000)]
|For starters, here's a small patch that removes a compiler warning in that
|regex stuff on Linux.
|
|--
|Bryan Henderson Phone 408-227-6803
|San Jose, California
|
Marc G. Fournier [Thu, 19 Sep 1996 20:05:59 +0000 (20:05 +0000)]
I have two small patches which correct some very obscure bug in the parser
of the array constants and in one of the loadable modules I posted some time
ago.
Marc G. Fournier [Thu, 19 Sep 1996 20:00:37 +0000 (20:00 +0000)]
A few changes to cleanup the code.
- Added the header access/heapam.h.
- Changed all instances of "length" to "data_length" to quiet
the compiler.
- initialized a few variables. The compiler couldn't see that
the code guaranteed that these would be initialized before
being dereferenced. If anyone wants to check my work follow
the usage of these variables and make sure that this true
and wasn't actually a bug in the original code.
- added a missing break statement to a default case. This
was a benign error but bad style.
- layed out heap_sysattrlen differently. I think this way
makes the structure of the code crystal clear. There should
be no actual difference in the actual behaviour of the code.
Marc G. Fournier [Mon, 16 Sep 1996 06:32:25 +0000 (06:32 +0000)]
Various standardizations and fixes submitted by D'Arcy Cain
NOTE: Makefile.custom is commented out, since it isn't there by default.
If you read the section telling you about it to know to create it,
you can uncomment it while you are there ...
Marc G. Fournier [Mon, 16 Sep 1996 06:11:44 +0000 (06:11 +0000)]
At Andrew's suggestion, upgrade the Version numbers to reflect the
current state of development...namely, we are on 2.0
NOTE:
BTW, the is also a check in postmaster which won't let you use an older
version of the database by checking the version number. The version number
of a database is in data/PG_VERSION (a plain ASCII file).
Marc G. Fournier [Mon, 16 Sep 1996 05:54:53 +0000 (05:54 +0000)]
I have made some corrections to my previous patches for retrieving array
attributes as tcl arrays. The previous code had problems with some chars
used as delimiter by Tcl. The new code should be more robust.
Marc G. Fournier [Mon, 16 Sep 1996 05:50:46 +0000 (05:50 +0000)]
Fixes:
Async notifies received while a backend is in the middle of a begin/end
transaction block are lost by libpq when the final end command is issued.
The bug is in the routine PQexec of libpq. The routine throws away any
message from the backend when a message of type 'C' is received. This
type of message is sent when the result of a portal query command with
no tuples is returned. Unfortunately this is the case of the end command.
As all async notification are sent only when the transaction is finished,
if they are received in the middle of a transaction they are lost in the
libpq library. I added some tracing code to PQexec and this is the output:
Marc G. Fournier [Mon, 16 Sep 1996 05:36:38 +0000 (05:36 +0000)]
There is a bug in the function executor. The backend crashes while trying to
execute an sql function containing an utility command (create, notify, ...).
The bug is part in the planner, which returns a number of plans different
than the number of commands if there are utility commands in the query, and
in part in the function executor which assumes that all commands are normal
query commands and causes a SIGSEGV trying to execute commands without plan.
Marc G. Fournier [Mon, 16 Sep 1996 05:33:20 +0000 (05:33 +0000)]
|Subject: Postgres patch: Assert attribute type match
|
|Here's a patch for Version 2 only. It just adds an Assert to catch some
|inconsistencies in the catalog classes.
|
|--
|Bryan Henderson Phone 408-227-6803
|San Jose, California
|
Marc G. Fournier [Tue, 10 Sep 1996 06:48:52 +0000 (06:48 +0000)]
Fixes:
The problem is that the function arguments are not considered as possible key
candidates for index scan and so only a sequential scan is possible inside
the body of a function. I have therefore made some patches to the optimizer
so that indices are now used also by functions. I have also moved the plan
debug message from pg_eval to pg_plan so that it is printed also for plans
genereated for function execution. I had also to add an index rescan to the
executor because it ignored the parameters set in the execution state, they
were flagged as runtime variables in ExecInitIndexScan but then never used
by the executor so that the scan were always done with any key=1. Very odd.
This means that an index rescan is now done twice for each function execution
which uses an index, the first time when the index scan is initialized and
the second when the actual function arguments are finally available for the
execution. I don't know what is the cost of an double index scan but I
suppose it is anyway less than the cost of a full sequential scan, at leat
for large tables. This is my patch, you must also add -DINDEXSCAN_PATCH in
Makefile.global to enable the changes.
Marc G. Fournier [Tue, 10 Sep 1996 06:41:38 +0000 (06:41 +0000)]
Fixes:
The comparison routines for text and char data type give incorrect results
if the input data contains characters greater than 127. As these routines
perform the comparison using signed char variables all character codes
greater than 127 are interpreted as less than 0. These codes are used to
encode the iso8859 char sets.
The other text-like data types seem to work as expected as they use unsigned
chars in comparisons.
Marc G. Fournier [Tue, 27 Aug 1996 22:00:21 +0000 (22:00 +0000)]
#include "postgres.h" exists in most .c files in system, so adding
#include "config.h" here will (should?) ensure that any platform
dependencies defined in config.h should be reflected in all .c files...
Marc G. Fournier [Mon, 26 Aug 1996 20:38:52 +0000 (20:38 +0000)]
The patch that is applied at the end of the email makes sure that these
conditions are always met. The patch can be applied to any version
of Postgres95 from 1.02 to 1.05. After applying the patch, queries
using indices on bpchar and varchar fields should (hopefully ;-) )
always return the same tuple set regardless to the fact whether
indices are used or not.
Marc G. Fournier [Sat, 24 Aug 1996 20:56:16 +0000 (20:56 +0000)]
This patch for Versions 1 and 2 corrects the following bug:
In a catalog class that has a "name" type attribute, UPDATEing of an
instance of that class may destroy all of the attributes of that
instance that are stored as or after the "name" attribute.
This is caused by the alignment value of the "name" type being set to
"double" in Class pg_type, but "integer" in Class pg_attribute.
Postgres constructs a tuple using double alignment, but interprets it
using integer alignment.
The fix is to change the alignment to integer in pg_type.
Note that this corrects the problem for new Postgres systems. Existing
databases already contain the error and it can't easily be repaired because
this very bug prevents updating the class that contains it.
--
Bryan Henderson Phone 408-227-6803
San Jose, California
Marc G. Fournier [Sat, 24 Aug 1996 20:49:41 +0000 (20:49 +0000)]
The patch does several things:
It adds a WITH OIDS option to the copy command, which allows
dumping and loading of oids.
If a copy command tried to load in an oid that is greater than
its current system max oid, the system max oid is incremented. No
checking is done to see if other backends are running and have cached
oids.
pg_dump as its first step when using the -o (oid) option, will
copy in a dummy row to set the system max oid value so as rows are
loaded in, they are certain to be lower than the system oid.
pg_dump now creates indexes at the end to speed loading
Submitted by: Bruce Momjian <maillist@candle.pha.pa.us>
Marc G. Fournier [Wed, 21 Aug 1996 04:32:09 +0000 (04:32 +0000)]
|May I suggest to add access to the oid of an inserted
|record, by a small patch to libpq++? At least until the
|feature that will allow dumped oid's to be re-loaded into
|a database becomes available, I need access to the oids
|of newly created records... To this end, I have written a
|three-line wrapper for the PQoidStatus function in libpq and
|named this wrapper OidStatus() (I'd appreciate suggestions for
|a name that would better fit into the general naming scheme).
|
|Regards,
|
|Ernst
|
Marc G. Fournier [Wed, 21 Aug 1996 04:25:49 +0000 (04:25 +0000)]
Here's a patch for Versions 1 and 2 that fixes the following bug:
When you try to do any UPDATE of the catalog class pg_class, such as
to change ownership of a class, the backend crashes.
This is really two serial bugs: 1) there is a hardcoded copy of the
schema of pg_class in the postgres program, and it doesn't match the
actual class that initdb creates in the database; 2) Parts of postgres
determine whether to pass an attribute value by value or by reference
based on the attbyval attribute of the attribute in class
pg_attribute. Other parts of postgres have it hardcoded. For the
relacl[] attribute in class pg_class, attbyval does not match the
hardcoded expectation.
The fix is to correct the hardcoded schema for pg_attribute and to
change the fetchatt macro so it ignores attbyval for all variable
length attributes. The fix also adds a bunch of logic documentation and
extends genbki.sh so it allows source files to contain such documentation.
--
Bryan Henderson Phone 408-227-6803
San Jose, California
Marc G. Fournier [Mon, 19 Aug 1996 13:52:54 +0000 (13:52 +0000)]
Added a SVR4 port
---
below my signature, there are a coupls of diffs and files in a shell
archive, which were needed to build postgres95 1.02 on Siemens Nixdorfs
MIPS based SINIX systems. Except for the compiler switches "-W0" and
"-LD-Blargedynsym" these diffs should also apply for other SVR4 based
systems. The changes in "Makefile.global" and "genbki.sh" can probably
be ignored (I needed gawk, to make the script run).
There is one bugfix thou. In "src/backend/parser/sysfunc.c" the
function in this file didn't honor the EUROPEAN_DATES ifdef.
---
Submitted by: Frank Ridderbusch <ridderbusch.pad@sni.de>
Marc G. Fournier [Mon, 19 Aug 1996 13:32:14 +0000 (13:32 +0000)]
Fixes:
Here's a couple more small fixes that I've made to make my runtime
checker happy with the code. More along the lines of those that
I sent in the past, ie, a pointer to an array != the name of
an array. The last patch is that I mailed about yesterday -- I got
two replies of "do it", so it's done. As far as I can tell, however,
the function in question is never called by pg95, so either way
it can't hurt...
Marc G. Fournier [Mon, 19 Aug 1996 13:25:40 +0000 (13:25 +0000)]
Fixes:
When you connect to a database with PQsetdb, as with psql, depending on
how your uninitialized variables are set, you can get a failure with a
"There is no connection to the backend" message.
The fix is to move a call to PQexec() from inside connectDB() to
PQsetdb() after connectDB() returns to PQsetdb(). That way a connection
doesn't have to be already established in order to establish it!
projects / postgresql / log