Yonghong Song [Wed, 18 Sep 2019 03:49:07 +0000 (03:49 +0000)]
[BPF] Permit all user instructed offset relocatiions
Currently, not all user specified relocations
(with clang intrinsic __builtin_preserve_access_index())
will turn into relocations.
In the current implementation, a __builtin_preserve_access_index()
chain is turned into relocation only if the result of the clang
intrinsic is used in a function call or a nonzero offset computation
of getelementptr. For all other cases, the relocatiion request
is ignored and the __builtin_preserve_access_index() is turned
into regular getelementptr instructions.
The main reason is to mimic bpf_probe_read() requirement.
But there are other use cases where relocatable offset is
generated but not used for bpf_probe_read(). This patch
relaxed previous constraints when to generate relocations.
Now, all user __builtin_preserve_access_index() will have
relocations generated.
Differential Revision: https://reviews.llvm.org/D67688
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372198
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Wed, 18 Sep 2019 01:57:46 +0000 (01:57 +0000)]
[X86] Prevent assertion when calling a function that returns double with -mno-sse2 on x86-64.
As seen in the most recent updates to PR10498
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372197
91177308-0d34-0410-b5e6-
96231b3b80d8
Francis Visoiu Mistrih [Wed, 18 Sep 2019 01:04:45 +0000 (01:04 +0000)]
[Remarks] Allow the RemarkStreamer to be used directly with a stream
The filename in the RemarkStreamer should be optional to allow clients
to stream remarks to memory or to existing streams.
This introduces a new overload of `setupOptimizationRemarks`, and avoids
enforcing the presence of a filename at different places.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372195
91177308-0d34-0410-b5e6-
96231b3b80d8
Teresa Johnson [Tue, 17 Sep 2019 23:12:13 +0000 (23:12 +0000)]
[PGO] Change hardcoded thresholds for cold/inlinehint to use summary
Summary:
The PGO counter reading will add cold and inlinehint (hot) attributes
to functions that are very cold or hot. This was using hardcoded
thresholds, instead of the profile summary cutoffs which are used in
other hot/cold detection and are more dynamic and adaptable. Switch
to using the summary-based cold/hot detection.
The hardcoded limits were causing some code that had a medium level of
hotness (per the summary) to be incorrectly marked with a cold
attribute, blocking inlining.
Reviewers: davidxl
Subscribers: llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D67673
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372189
91177308-0d34-0410-b5e6-
96231b3b80d8
Eli Friedman [Tue, 17 Sep 2019 21:42:38 +0000 (21:42 +0000)]
[ARM] VFPv2 only supports 16 D registers.
r361845 changed the way we handle "D16" vs. "D32" targets; there used to
be a negative "d16" which removed instructions from the instruction set,
and now there's a "d32" feature which adds instructions to the
instruction set. This is good, but there was an oversight in the
implementation: the behavior of VFPv2 was changed. In particular, the
"vfp2" feature was changed to imply "d32". This is wrong: VFPv2 only
supports 16 D registers.
In practice, this means if you specify -mfpu=vfpv2, the compiler will
generate illegal instructions.
This patch gets rid of "vfp2d16" and "vfp2d16sp", and fixes "vfp2" and
"vfp2sp" so they don't imply "d32".
Differential Revision: https://reviews.llvm.org/D67375
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372186
91177308-0d34-0410-b5e6-
96231b3b80d8
Reid Kleckner [Tue, 17 Sep 2019 21:10:49 +0000 (21:10 +0000)]
[PGO] Don't use comdat groups for counters & data on COFF
For COFF, a comdat group is really a symbol marked
IMAGE_COMDAT_SELECT_ANY and zero or more other symbols marked
IMAGE_COMDAT_SELECT_ASSOCIATIVE. Typically the associative symbols in
the group are not external and are not referenced by other TUs, they are
things like debug info, C++ dynamic initializers, or other section
registration schemes. The Visual C++ linker reports a duplicate symbol
error for symbols marked IMAGE_COMDAT_SELECT_ASSOCIATIVE even if they
would be discarded after handling the leader symbol.
Fixes coverage-inline.cpp in check-profile after r372020.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372182
91177308-0d34-0410-b5e6-
96231b3b80d8
Jinsong Ji [Tue, 17 Sep 2019 21:09:41 +0000 (21:09 +0000)]
Reland "[docs][Bugpoint]Add notes about multiple crashes"
Fix the warning.
Bugpoint.rst:124:Mismatch: both interpreted text role prefix and
reference suffix.
Note that the line no here is wrong and misleading,
the problem is in line 128, not 124.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372181
91177308-0d34-0410-b5e6-
96231b3b80d8
Greg Clayton [Tue, 17 Sep 2019 20:31:01 +0000 (20:31 +0000)]
Fix buildbots.
MSVC doesn't correctly capture constexpr in lambdas, and other builds warn if you do, others will error out if you do. Avoid lambdas.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372179
91177308-0d34-0410-b5e6-
96231b3b80d8
Jessica Paquette [Tue, 17 Sep 2019 20:24:23 +0000 (20:24 +0000)]
[AArch64][GlobalISel] Support -tailcallopt
This adds support for `-tailcallopt` tail calls to CallLowering. This
piggy-backs off the changes from D67577, since doing it without a bit of
refactoring gets extremely ugly.
Support is basically ported from AArch64ISelLowering. The main difference here
is that tail calls in `-tailcallopt` change the ABI, so there's some extra
bookkeeping for the stack.
Show that we are correctly lowering these by updating tail-call.ll.
Also show that we don't do anything strange in general by updating
fastcc-reserved.ll, which passes `-tailcallopt`, but doesn't emit any tail
calls.
Differential Revision: https://reviews.llvm.org/D67580
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372177
91177308-0d34-0410-b5e6-
96231b3b80d8
GN Sync Bot [Tue, 17 Sep 2019 19:41:36 +0000 (19:41 +0000)]
gn build: Merge r372168
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372173
91177308-0d34-0410-b5e6-
96231b3b80d8
Roman Lebedev [Tue, 17 Sep 2019 19:37:07 +0000 (19:37 +0000)]
AArch64CallLowering::lowerCall(): fix build by not passing InArgs into lowerTailCall()
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372172
91177308-0d34-0410-b5e6-
96231b3b80d8
Roman Lebedev [Tue, 17 Sep 2019 19:32:26 +0000 (19:32 +0000)]
[NFC][InstCombine] dropRedundantMaskingOfLeftShiftInput(): some NFC diff shaving
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372171
91177308-0d34-0410-b5e6-
96231b3b80d8
Roman Lebedev [Tue, 17 Sep 2019 19:32:11 +0000 (19:32 +0000)]
[NFC][InstCombine] More tests for "Dropping pointless masking before left shift" (PR42563)
While we already fold that pattern if the sum of shift amounts is not
smaller than bitwidth, there's painfully obvious generalization:
https://rise4fun.com/Alive/F5R
I.e. the "sub of shift amounts" tells us how many bits will be left
in the output. If it's less than bitwidth, we simply need to
apply a mask, which is constant.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372170
91177308-0d34-0410-b5e6-
96231b3b80d8
Bardia Mahjour [Tue, 17 Sep 2019 19:22:01 +0000 (19:22 +0000)]
Revert "Data Dependence Graph Basics"
This reverts commit
c98ec60993a7aa65073692b62f6d728b36e68ccd, which broke the sphinx-docs build.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372168
91177308-0d34-0410-b5e6-
96231b3b80d8
Simon Pilgrim [Tue, 17 Sep 2019 19:16:00 +0000 (19:16 +0000)]
NVPTXAsmPrinter - Don't dereference a dyn_cast result. NFCI.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372166
91177308-0d34-0410-b5e6-
96231b3b80d8
Simon Pilgrim [Tue, 17 Sep 2019 19:14:11 +0000 (19:14 +0000)]
WasmEmitter - Don't dereference a dyn_cast result. NFCI.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372165
91177308-0d34-0410-b5e6-
96231b3b80d8
Jessica Paquette [Tue, 17 Sep 2019 19:08:44 +0000 (19:08 +0000)]
[AArch64][GlobalISel][NFC] Refactor tail call lowering code
When you begin implementing -tailcallopt, this gets somewhat hairy. Refactor
the call lowering code so that the tail call lowering stuff gets its own
function.
Differential Revision: https://reviews.llvm.org/D67577
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372164
91177308-0d34-0410-b5e6-
96231b3b80d8
GN Sync Bot [Tue, 17 Sep 2019 19:00:41 +0000 (19:00 +0000)]
gn build: Merge r372162
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372163
91177308-0d34-0410-b5e6-
96231b3b80d8
Bardia Mahjour [Tue, 17 Sep 2019 18:55:44 +0000 (18:55 +0000)]
Data Dependence Graph Basics
Summary:
This is the first patch in a series of patches that will implement data dependence graph in LLVM. Many of the ideas used in this implementation are based on the following paper:
D. J. Kuck, R. H. Kuhn, D. A. Padua, B. Leasure, and M. Wolfe (1981). DEPENDENCE GRAPHS AND COMPILER OPTIMIZATIONS.
This patch contains support for a basic DDGs containing only atomic nodes (one node for each instruction). The edges are two fold: def-use edges and memory-dependence edges.
The implementation takes a list of basic-blocks and only considers dependencies among instructions in those basic blocks. Any dependencies coming into or going out of instructions that do not belong to those basic blocks are ignored.
The algorithm for building the graph involves the following steps in order:
1. For each instruction in the range of basic blocks to consider, create an atomic node in the resulting graph.
2. For each node in the graph establish def-use edges to/from other nodes in the graph.
3. For each pair of nodes containing memory instruction(s) create memory edges between them. This part of the algorithm goes through the instructions in lexicographical order and creates edges in reverse order if the sink of the dependence occurs before the source of it.
Authored By: bmahjour
Reviewer: Meinersbur, fhahn, myhsu, xtian, dmgreen, kbarton, jdoerfert
Reviewed By: Meinersbur, fhahn, myhsu
Subscribers: ychen, arphaman, simoll, a.elovikov, mgorny, hiraditya, jfb, wuzish, llvm-commits, jsji, Whitney, etiotto
Tag: #llvm
Differential Revision: https://reviews.llvm.org/D65350
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372162
91177308-0d34-0410-b5e6-
96231b3b80d8
Jinsong Ji [Tue, 17 Sep 2019 18:39:04 +0000 (18:39 +0000)]
[docs][Bugpoint] Revert
5584ead50 a5aa3353
No sure why there are still warnings, revert while I investigate.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372161
91177308-0d34-0410-b5e6-
96231b3b80d8
Jinsong Ji [Tue, 17 Sep 2019 18:23:06 +0000 (18:23 +0000)]
[docs][Bugpoint] Fix build break.
Bugpoint.rst:124: WARNING: Mismatch: both interpreted text role prefix
and reference suffix.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372160
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Tue, 17 Sep 2019 18:19:06 +0000 (18:19 +0000)]
[X86] Use APInt::operator<<= and APInt::lshrInPlace. NFC
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372159
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Tue, 17 Sep 2019 18:19:02 +0000 (18:19 +0000)]
[SimplifyDemandedBits] Use APInt::intersects to instead of ANDing and comparing to 0 separately. NFC
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372158
91177308-0d34-0410-b5e6-
96231b3b80d8
Jinsong Ji [Tue, 17 Sep 2019 18:10:09 +0000 (18:10 +0000)]
[docs][Bugpoint]Add notes about multiple crashes
Summary:
When reducing case for a CodeGenCrash, bugpoint may generate a new
reduced
testcase that exposes/causes another crash or break something due to
limitation.
Bugpoint does not distiguish different crashes currently,
so when this happens, bugpoint will go on reducing for the new crash,
or just abort, we can't get the case reduced for the origial crash.
An advice is added into usage doc to connect to recommend checking error
message with scripts and `-compile-command`.
Reviewers: modocache, bogner, sebpop, reames, vsk, MatzeB
Reviewed By: vsk
Subscribers: mehdi_amini, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66832
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372157
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Tue, 17 Sep 2019 18:02:56 +0000 (18:02 +0000)]
[X86] Simplify b2b KSHIFTL+KSHIFTR using demanded elts.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372155
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Tue, 17 Sep 2019 18:02:52 +0000 (18:02 +0000)]
[X86] Call SimplifyDemandedVectorElts on KSHIFTL/KSHIFTR nodes during DAG combine.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372154
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Tue, 17 Sep 2019 18:02:46 +0000 (18:02 +0000)]
[X86] Simplify some code in LowerBUILD_VECTORvXi1. NFCI
The case were Immediate is 0 and HasConstElts is true should never
happen since that would mean the constant elts were all zero. But
we check for all zero build vector earlier. So just use HasConstElts
and blindly take Immediate without checking if its 0.
Move the code that bitcasts and extract the immediate into the
the HasConstElts case since the other code just creates an undef
with the right type. No casting needed.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372153
91177308-0d34-0410-b5e6-
96231b3b80d8
Stanislav Mekhanoshin [Tue, 17 Sep 2019 17:56:13 +0000 (17:56 +0000)]
[AMDGPU] Added MI bit IsDOT
NFC, needed for future commit.
Differential Revision: https://reviews.llvm.org/D67669
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372151
91177308-0d34-0410-b5e6-
96231b3b80d8
GN Sync Bot [Tue, 17 Sep 2019 17:51:27 +0000 (17:51 +0000)]
gn build: Merge r372149
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372150
91177308-0d34-0410-b5e6-
96231b3b80d8
Greg Clayton [Tue, 17 Sep 2019 17:46:13 +0000 (17:46 +0000)]
GSYM: Add the llvm::gsym::Header header class with tests
This patch adds the llvm::gsym::Header class which appears at the start of a stand alone GSYM file, or in the first bytes of the GSYM data in a GSYM section within a file. Added encode and decode methods with full error handling and full tests.
Differential Revision: https://reviews.llvm.org/D67666
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372149
91177308-0d34-0410-b5e6-
96231b3b80d8
Simon Pilgrim [Tue, 17 Sep 2019 17:32:15 +0000 (17:32 +0000)]
[TableGen] CodeGenMapTable - Don't dereference a dyn_cast result. NFCI.
The static analyzer is warning about potential null dereferences of dyn_cast<> results - in these cases we can safely use cast<> directly as we know that these cases should all be the correct type, which is why its working atm and anyway cast<> will assert if they aren't.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372146
91177308-0d34-0410-b5e6-
96231b3b80d8
Simon Pilgrim [Tue, 17 Sep 2019 17:26:14 +0000 (17:26 +0000)]
[ARM][AsmParser] Don't dereference a dyn_cast result. NFCI.
The static analyzer is warning about potential null dereferences of dyn_cast<> results - in these cases we can safely use cast<> directly as we know that these cases should all be the correct type, which is why its working atm and anyway cast<> will assert if they aren't.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372145
91177308-0d34-0410-b5e6-
96231b3b80d8
Simon Pilgrim [Tue, 17 Sep 2019 17:24:55 +0000 (17:24 +0000)]
Fix MSVC lambda capture warnings. NFCI.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372144
91177308-0d34-0410-b5e6-
96231b3b80d8
David Bolvansky [Tue, 17 Sep 2019 17:12:24 +0000 (17:12 +0000)]
Reland "[SLC] Preserve attrs for strncpy(x, "", y) -> memset(align 1 x, '\0', y)"
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372142
91177308-0d34-0410-b5e6-
96231b3b80d8
Nemanja Ivanovic [Tue, 17 Sep 2019 16:45:20 +0000 (16:45 +0000)]
[PowerPC] Exploit single instruction load-and-splat for word and doubleword
We currently produce a load, followed by (possibly a move for integers and) a
splat as separate instructions. VSX has always had a splatting load for
doublewords, but as of Power9, we have it for words as well. This patch just
exploits these instructions.
Differential revision: https://reviews.llvm.org/D63624
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372139
91177308-0d34-0410-b5e6-
96231b3b80d8
Alina Sbirlea [Tue, 17 Sep 2019 16:33:35 +0000 (16:33 +0000)]
[MemorySSA] Fix phi insertion when inserting a def.
Summary:
When inserting a Def, the current algorithm is walking edges backward
and inserting new Phis where needed. There may be additional Phis needed
in the IDF of the newly inserted Def and Phis.
Adding Phis in the IDF of the Def was added ina previous patch, but we
may also need other Phis in the IDF of the newly added Phis.
Reviewers: george.burgess.iv
Subscribers: Prazek, sanjoy.google, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D67637
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372138
91177308-0d34-0410-b5e6-
96231b3b80d8
Alina Sbirlea [Tue, 17 Sep 2019 16:31:37 +0000 (16:31 +0000)]
[MemorySSA] Update MSSA for non-conventional AA.
Summary:
Regularly when moving an instruction that may not read or write memory,
the instruction is not modelled in MSSA, so not action is necessary.
For a non-conventional AA pipeline, MSSA needs to explicitly check when
creating accesses, so as to not model instructions that may not read and
write memory.
Reviewers: george.burgess.iv
Subscribers: Prazek, sanjoy.google, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D67562
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372137
91177308-0d34-0410-b5e6-
96231b3b80d8
Petr Hosek [Tue, 17 Sep 2019 16:27:36 +0000 (16:27 +0000)]
Move DK_Misexpect for compatability with getNextAvailablePluginDiagnosticKind
First identified after D66324 landed.
Patch By: paulkirth
Differential Revision: https://reviews.llvm.org/D67648
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372136
91177308-0d34-0410-b5e6-
96231b3b80d8
Greg Clayton [Tue, 17 Sep 2019 16:15:49 +0000 (16:15 +0000)]
GSYM: add encoding and decoding to FunctionInfo
This patch adds encoding and decoding of the FunctionInfo objects along with full error handling and tests. Full details of the FunctionInfo encoding format appear in the FunctionInfo.h header file.
Differential Revision: https://reviews.llvm.org/D67506
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372135
91177308-0d34-0410-b5e6-
96231b3b80d8
David Green [Tue, 17 Sep 2019 15:32:28 +0000 (15:32 +0000)]
[ARM] Add a SelectTAddrModeImm7 for MVE narrow loads and stores
We were previously using the SelectT2AddrModeImm7 for both normal and narrowing
MVE loads/stores. As the narrowing instructions do not accept sp as a register,
it makes little sense to optimise a FrameIndex into the load, only to have to
recover that later on. This adds a SelectTAddrModeImm7 which does not do that
folding, and uses it for narrowing load/store patterns.
Differential Revision: https://reviews.llvm.org/D67489
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372134
91177308-0d34-0410-b5e6-
96231b3b80d8
David Green [Tue, 17 Sep 2019 15:25:24 +0000 (15:25 +0000)]
[ARM] Fixup pipeline test. NFC
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372133
91177308-0d34-0410-b5e6-
96231b3b80d8
David Green [Tue, 17 Sep 2019 15:23:09 +0000 (15:23 +0000)]
[ARM] Reserve an emergency spill slot for fp16 addressing modes that need it
Similar to D67327, but this time for the FP16 VLDR and VSTR instructions that
use the AddrMode5FP16 addressing mode. We need to reserve an emergency spill
slot for instructions that will be out of range to use sp directly.
AddrMode5FP16 is 8 bits with a scale of 2.
Differential Revision: https://reviews.llvm.org/D67483
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372132
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Tue, 17 Sep 2019 14:27:31 +0000 (14:27 +0000)]
[RISCV] Unbreak the build
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372127
91177308-0d34-0410-b5e6-
96231b3b80d8
Sam Parker [Tue, 17 Sep 2019 14:21:36 +0000 (14:21 +0000)]
[ARM] Fix for buildbots
Remove setPreservesCFG from ARMConstantIslandPass and add a couple
of -verify-machine-dom-info instances into the existing codegen
tests.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372126
91177308-0d34-0410-b5e6-
96231b3b80d8
Krasimir Georgiev [Tue, 17 Sep 2019 14:15:23 +0000 (14:15 +0000)]
Revert "[SLC] Preserve attrs for strncpy(x, "", y) -> memset(align 1 x, '\0', y)"
Summary:
This reverts commit r372101.
Causes ASAN build bot failures:
http://lab.llvm.org:8011/builders/sanitizer-ppc64be-linux/builds/14176
From http://lab.llvm.org:8011/builders/sanitizer-ppc64be-linux/builds/14176/steps/64-bit%20check-asan/logs/stdio:
```
[ RUN ] AddressSanitizer.StrNCatOOBTest
/home/buildbots/ppc64be-sanitizer/sanitizer-ppc64be/build/llvm-project/compiler-rt/lib/asan/tests/asan_str_test.cpp:462: Failure
Death test: strncat(to - 1, from, 0)
Result: failed to die.
```
Subscribers: llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D67658
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372125
91177308-0d34-0410-b5e6-
96231b3b80d8
Nico Weber [Tue, 17 Sep 2019 14:06:05 +0000 (14:06 +0000)]
gn build: (manually) merge r372076
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372123
91177308-0d34-0410-b5e6-
96231b3b80d8
George Rimar [Tue, 17 Sep 2019 13:58:46 +0000 (13:58 +0000)]
[llvm-readobj/llvm-objdump] - Improve how tool locate the dynamic table and report warnings about that.
Before this patch we gave a priority to a dynamic table found
from the section header.
It was discussed (here: https://reviews.llvm.org/D67078?id=218356#inline-602082)
that probably preferring the table from PT_DYNAMIC is better,
because it is what runtime loader sees.
This patch makes the table from PT_DYNAMIC be chosen at first place if it is available.
But also it adds logic to fall back to SHT_DYNAMIC if the table from the dynamic segment is
broken or fall back to use no table if both are broken.
It adds a few more diagnostic warnings for the logic above.
Differential revision: https://reviews.llvm.org/D67547
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372122
91177308-0d34-0410-b5e6-
96231b3b80d8
Sam Parker [Tue, 17 Sep 2019 13:46:26 +0000 (13:46 +0000)]
[ARM] Fix for buildbots
Add --verifymachineinstrs and update the remaining low overhead loop
tests.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372121
91177308-0d34-0410-b5e6-
96231b3b80d8
Luis Marques [Tue, 17 Sep 2019 13:34:17 +0000 (13:34 +0000)]
[RISCV][NFC] Use NoRegister instead of 0 literal
Summary: Trivial cleanup.
Reviewers: asb, lenary
Reviewed By: lenary
Subscribers: hiraditya, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, kito-cheng, shiva0217, jrtc27, MaskRay, zzheng, edward-jones, rogfer01, MartinMosbeck, brucehoult, the_o, rkruppe, PkmX, jocewei, psnobl, benna, Jim, s.egerton, pzheng, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D67526
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372120
91177308-0d34-0410-b5e6-
96231b3b80d8
Simon Pilgrim [Tue, 17 Sep 2019 13:27:02 +0000 (13:27 +0000)]
[X86] X86DAGToDAGISel::tryFoldLoad - assert root/parent pointers are non-null. NFCI.
Silences a static analyzer warning.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372118
91177308-0d34-0410-b5e6-
96231b3b80d8
Simon Pilgrim [Tue, 17 Sep 2019 13:25:56 +0000 (13:25 +0000)]
InterleavedAccessInfo - Don't dereference a dyn_cast result. NFCI.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372117
91177308-0d34-0410-b5e6-
96231b3b80d8
Simon Pilgrim [Tue, 17 Sep 2019 13:24:54 +0000 (13:24 +0000)]
[LoopVectorize] Don't dereference a dyn_cast result. NFCI.
The static analyzer is warning about potential null dereferences of dyn_cast<> results, we can use cast<> directly as we know that these cases should all be CastInst, which is why its working atm and anyway cast<> will assert if they aren't.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372116
91177308-0d34-0410-b5e6-
96231b3b80d8
David Green [Tue, 17 Sep 2019 12:58:51 +0000 (12:58 +0000)]
[ARM] Fix for MVE load/store stack accesses
MVE loads and stores have a 7 bit immediate range, scaled by the length of the type. This needs to be taught to the stack estimation code to ensure that an emergency spill slot is reserved in case we run out of registers when materialising stack indices.
Also the narrowing loads/stores can be created with frame indices even though they do not accept SP as a register. We need in those cases to make sure we have an emergency register to use as the frame base, as SP can never be used.
Differential Revision: https://reviews.llvm.org/D67327
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372114
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Tue, 17 Sep 2019 12:56:29 +0000 (12:56 +0000)]
Hide implementation details in namespaces.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372113
91177308-0d34-0410-b5e6-
96231b3b80d8
Sam Parker [Tue, 17 Sep 2019 12:19:32 +0000 (12:19 +0000)]
[ARM][LowOverheadLoops] Add LR def safety check
Converting the *LoopStart pseudo instructions into DLS/WLS results in
LR being defined. These instructions were inserted on the assumption
that LR would already contain the loop counter because a mov is
introduced during ISel as the the consumers in the loop can only use
LR. That assumption proved wrong!
So perform a safety check, finding an appropriate place to insert the
DLS/WLS instructions or revert if this isn't possible.
Differential Revision: https://reviews.llvm.org/D67539
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372111
91177308-0d34-0410-b5e6-
96231b3b80d8
George Rimar [Tue, 17 Sep 2019 12:05:39 +0000 (12:05 +0000)]
[llvm-readobj] - Test PPC64 relocations properly.
We had a precompiled binary committed and not all of the relocations
supported were tested. This patch fixes this.
Differential revision: https://reviews.llvm.org/D67617
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372110
91177308-0d34-0410-b5e6-
96231b3b80d8
George Rimar [Tue, 17 Sep 2019 12:00:55 +0000 (12:00 +0000)]
[obj2yaml] - Support PPC64 relocation types.
We do not support them and fail with llvm_unreachable currently.
This is not the only target we do not support and also seems we are missing
the tests for those we have already. But I needed this one for another patch,
so posted it separatelly.
Relocation names are taken from llvm\include\llvm\BinaryFormat\ELFRelocs\PowerPC64.def
Differential revision: https://reviews.llvm.org/D67615
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372109
91177308-0d34-0410-b5e6-
96231b3b80d8
George Rimar [Tue, 17 Sep 2019 11:51:26 +0000 (11:51 +0000)]
[yaml2obj/obj2yaml] - Allow setting an arbitrary values for e_machine.
Currently we only allow using a known named constants
for `Machine` field in YAML documents.
This patch allows using any numbers (valid or "unknown")
and adds test cases for current and new functionality.
With this it is possible to write a test cases for really unknown
EM_* targets.
Differential revision: https://reviews.llvm.org/D67652
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372108
91177308-0d34-0410-b5e6-
96231b3b80d8
James Henderson [Tue, 17 Sep 2019 11:43:42 +0000 (11:43 +0000)]
[docs] Make --version text more correct
Follow-up to r371983. Referring to "this program" in the description of
the --version option in the documentation isn't exactly correct, because
the docs are not part of the program, and so "this program" doesn't
really refer to anything. This patch brings the other users of this
terminology into line with the new updates to llvm-size and
llvm-strings.
Reviewed by: alexshap, MaskRay
Differential Revision: https://reviews.llvm.org/D67618
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372107
91177308-0d34-0410-b5e6-
96231b3b80d8
Luis Marques [Tue, 17 Sep 2019 11:15:35 +0000 (11:15 +0000)]
[RISCV] Switch to the Machine Scheduler
Most of the test changes are trivial instruction reorderings and differing
register allocations, without any obvious performance impact.
Differential Revision: https://reviews.llvm.org/D66973
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372106
91177308-0d34-0410-b5e6-
96231b3b80d8
Johannes Doerfert [Tue, 17 Sep 2019 10:52:41 +0000 (10:52 +0000)]
[Attributor][Fix] Initialize the cache prior to using it
Summary:
There were segfaults as we modified and iterated the instruction maps in
the cache at the same time. This was happening because we created new
instructions while we populated the cache. This fix changes the order
in which we perform these actions. First, the caches for the whole
module are created, then we start to create abstract attributes.
I don't have a unit test but the LLVM test suite exposes this problem.
Reviewers: uenoku, sstefan1
Subscribers: hiraditya, bollu, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D67232
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372105
91177308-0d34-0410-b5e6-
96231b3b80d8
Luis Marques [Tue, 17 Sep 2019 10:52:09 +0000 (10:52 +0000)]
Revert Patch from Phabricator
This reverts r372092 (git commit
e38695a0255c9e7b53639f349f8101bae1ce5c04)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372104
91177308-0d34-0410-b5e6-
96231b3b80d8
Simon Pilgrim [Tue, 17 Sep 2019 10:51:30 +0000 (10:51 +0000)]
[X86] Use APInt::getLowBitsSet helper. NFCI.
Also avoids a static analyzer warning about out of range shifts.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372103
91177308-0d34-0410-b5e6-
96231b3b80d8
David Bolvansky [Tue, 17 Sep 2019 10:25:38 +0000 (10:25 +0000)]
[SLC] Preserve attrs for strncpy(x, "", y) -> memset(align 1 x, '\0', y)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372101
91177308-0d34-0410-b5e6-
96231b3b80d8
Graham Hunter [Tue, 17 Sep 2019 10:19:23 +0000 (10:19 +0000)]
[SVE][MVT] Fixed-length vector MVT ranges
* Reordered MVT simple types to group scalable vector types
together.
* New range functions in MachineValueType.h to only iterate over
the fixed-length int/fp vector types.
* Stopped backends which don't support scalable vector types from
iterating over scalable types.
Reviewers: sdesmalen, greened
Reviewed By: greened
Differential Revision: https://reviews.llvm.org/D66339
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372099
91177308-0d34-0410-b5e6-
96231b3b80d8
David Bolvansky [Tue, 17 Sep 2019 10:12:48 +0000 (10:12 +0000)]
[InstCombine] Annotate strdup with deref_or_null
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372098
91177308-0d34-0410-b5e6-
96231b3b80d8
David Bolvansky [Tue, 17 Sep 2019 10:03:45 +0000 (10:03 +0000)]
[NFCI] Fixed buildbots
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372097
91177308-0d34-0410-b5e6-
96231b3b80d8
Fangrui Song [Tue, 17 Sep 2019 09:56:55 +0000 (09:56 +0000)]
[SimplifyLibCalls] Fix -Wunused-result after D53342/r372091
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372096
91177308-0d34-0410-b5e6-
96231b3b80d8
David Bolvansky [Tue, 17 Sep 2019 09:45:52 +0000 (09:45 +0000)]
[NFC} Updated test
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372093
91177308-0d34-0410-b5e6-
96231b3b80d8
Luis Marques [Tue, 17 Sep 2019 09:43:08 +0000 (09:43 +0000)]
Patch from Phabricator
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372092
91177308-0d34-0410-b5e6-
96231b3b80d8
David Bolvansky [Tue, 17 Sep 2019 09:32:52 +0000 (09:32 +0000)]
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372091
91177308-0d34-0410-b5e6-
96231b3b80d8
George Rimar [Tue, 17 Sep 2019 09:26:49 +0000 (09:26 +0000)]
[llvm-readobj] - Fix BB after r372087.
Seems I forgot to update the number of bytes checked.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372089
91177308-0d34-0410-b5e6-
96231b3b80d8
Fangrui Song [Tue, 17 Sep 2019 09:25:52 +0000 (09:25 +0000)]
[llvm-ar] Parse 'h' and '-h': display help and exit
Support `llvm-ar h` and `llvm-ar -h` because they may be what users try
at first. Note, operation 'h' is undocumented in GNU ar.
Reviewed By: jhenderson
Differential Revision: https://reviews.llvm.org/D67560
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372088
91177308-0d34-0410-b5e6-
96231b3b80d8
George Rimar [Tue, 17 Sep 2019 09:12:10 +0000 (09:12 +0000)]
[llvm-readobj] - Fix a TODO in elf-reloc-zero-name-or-value.test.
The "TODO" mentioned was:
"Add test for symbol with no name but with a value once yaml2obj allows
referencing symbols with no name from relocations."
We can do it now.
Differential revision: https://reviews.llvm.org/D67609
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372087
91177308-0d34-0410-b5e6-
96231b3b80d8
Alexander Timofeev [Tue, 17 Sep 2019 09:08:58 +0000 (09:08 +0000)]
[AMDGPU]: PHI Elimination hooks added for custom COPY insertion. Fixed
Defferential Revision: https://reviews.llvm.org/D67101
Reviewers: rampitec, vpykhtin
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372086
91177308-0d34-0410-b5e6-
96231b3b80d8
Sam Parker [Tue, 17 Sep 2019 09:08:05 +0000 (09:08 +0000)]
[ARM] LE support in ConstantIslands
The low-overhead branch extension provides a loop-end 'LE' instruction
that performs no decrement nor compare, it just jumps backwards. This
patch modifies the constant islands pass to try to insert LE
instructions in place of a Thumb2 conditional branch, instead of
shrinking it. This only happens if a cmp can be converted to a cbn/z
and used to exit the loop.
Differential Revision: https://reviews.llvm.org/D67404
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372085
91177308-0d34-0410-b5e6-
96231b3b80d8
Florian Hahn [Tue, 17 Sep 2019 09:02:48 +0000 (09:02 +0000)]
[LoopUnroll] Use LoopSize+1 as threshold, to allow unrolling loops matching LoopSize.
We use `< UP.Threshold` later on, so we should use LoopSize + 1, to
allow unrolling if the result won't exceed to loop size.
Fixes PR43305.
Reviewers: efriedma, dmgreen, paquette
Reviewed By: dmgreen
Differential Revision: https://reviews.llvm.org/D67594
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372084
91177308-0d34-0410-b5e6-
96231b3b80d8
George Rimar [Tue, 17 Sep 2019 08:53:18 +0000 (08:53 +0000)]
[llvm-readobj] - Refactor the code.
It's a straightforward refactoring that allows to simplify and encapsulate the code.
Differential revision: https://reviews.llvm.org/D67624
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372083
91177308-0d34-0410-b5e6-
96231b3b80d8
George Rimar [Tue, 17 Sep 2019 08:38:53 +0000 (08:38 +0000)]
[llvm-objcopy] - Remove python invocations from 2 test cases.
It is possible to use yaml2obj to create sections with overlapping sh_offset now.
This patch does that.
Differential revision: https://reviews.llvm.org/D67610
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372081
91177308-0d34-0410-b5e6-
96231b3b80d8
Florian Hahn [Tue, 17 Sep 2019 08:14:09 +0000 (08:14 +0000)]
[bugpoint] Add support for -Oz and properly enable -Os.
This patch adds -Oz as option and also properly enables support for -Os.
Currently, the existing check for -Os is dead, because the enclosing if
only checks of O1, O2 and O3.
There is still a difference between the -Oz pipeline compared to opt,
but I have not been able to track that down yet.
Reviewers: bogner, sebpop, efriedma
Reviewed By: efriedma
Differential Revision: https://reviews.llvm.org/D67593
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372079
91177308-0d34-0410-b5e6-
96231b3b80d8
Sam Parker [Tue, 17 Sep 2019 07:43:04 +0000 (07:43 +0000)]
[ARM][MVE] Add invalidForTailPredication to TSFlags
Set this bit for the MVE reduction instructions to prevent a loop from
becoming tail predicated in their presence.
Differential Revision: https://reviews.llvm.org/D67444
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372076
91177308-0d34-0410-b5e6-
96231b3b80d8
Hideto Ueno [Tue, 17 Sep 2019 06:53:27 +0000 (06:53 +0000)]
[Attributor] Use Alias Analysis in noalias callsite argument deduction
Summary: This patch adds a check of alias analysis in `noalias` callsite argument deduction.
Reviewers: jdoerfert, sstefan1
Reviewed By: jdoerfert
Subscribers: hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D67604
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372075
91177308-0d34-0410-b5e6-
96231b3b80d8
Hideto Ueno [Tue, 17 Sep 2019 05:45:18 +0000 (05:45 +0000)]
[Attributor] Create helper struct for handling analysis getters
Summary: This patch introduces a helper struct `AnalysisGetter` to put together analysis getters. In this patch, a getter for `AAResult` is also added for `noalias`.
Reviewers: jdoerfert, sstefan1
Reviewed By: jdoerfert
Subscribers: hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D67603
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372072
91177308-0d34-0410-b5e6-
96231b3b80d8
David Zarzycki [Tue, 17 Sep 2019 04:44:13 +0000 (04:44 +0000)]
[git-llvm] Do not reinvent `@{upstream}` (take 2)
This makes git-llvm more of a thin wrapper around git while temporarily
maintaining backwards compatibility with past git-llvm behavior.
Using @{upstream} makes git-llvm more robust when used with a nontrivial
local repository.
https://reviews.llvm.org/D67389
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372070
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Tue, 17 Sep 2019 04:41:14 +0000 (04:41 +0000)]
[X86] Split oversized vXi1 vector arguments and return values into scalars on avx512 targets.
Previously we tried to split them into narrower v64i1 or v16i1
pieces that each got promoted to vXi8 and then passed in a zmm
or xmm register. But this crashes when you need to pass more
pieces than available registers reserved for argument passing.
The scalarizing done here generates much longer and slower code,
but is consistent with the behavior of avx2 and earlier targets
for these types.
Fixes PR43323.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372069
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Tue, 17 Sep 2019 04:41:10 +0000 (04:41 +0000)]
[X86] Allow masked VBROADCAST instructions to be turned into BLENDM with a broadcast load to avoid a copy.
The BLENDM instructions allow an 2 sources and an independent
destination while masked VBROADCAST has the destination tied
to the source.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372068
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Tue, 17 Sep 2019 04:41:05 +0000 (04:41 +0000)]
[X86] Add support for commuting EVEX VCMP instructons with any immediate value.
Previously we limited to the EQ/NE/TRUE/FALSE/ORD/UNORD immediates.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372067
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Tue, 17 Sep 2019 04:41:01 +0000 (04:41 +0000)]
[X86] Add test case for missed opportunity to commute a VCMP instruction after unfolding one load in order to fold another load.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372066
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Tue, 17 Sep 2019 04:40:58 +0000 (04:40 +0000)]
[X86] Enable commuting of EVEX VCMP for all immediate values during isel.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372065
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Mon, 16 Sep 2019 23:56:26 +0000 (23:56 +0000)]
llvm-reduce: Clean out previous test temp/output dir, since it was a dir and now it's used as just a single file
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372054
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Mon, 16 Sep 2019 23:54:57 +0000 (23:54 +0000)]
llvm-reduce: Remove some string copies
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372053
91177308-0d34-0410-b5e6-
96231b3b80d8
Joel E. Denny [Mon, 16 Sep 2019 23:47:46 +0000 (23:47 +0000)]
Revert r372035: "[lit] Make internal diff work in pipelines"
This breaks a Windows bot.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372051
91177308-0d34-0410-b5e6-
96231b3b80d8
Amara Emerson [Mon, 16 Sep 2019 23:46:03 +0000 (23:46 +0000)]
[GlobalISel] Partially revert r371901.
r371901 was overeager and widenScalarDst() and the like in the legalizer
attempt to increment the insert point given in order to add new instructions
after the currently legalizing inst. In cases where the insertion point is not
exactly the current instruction, then callers need to de-compensate for the
behaviour by decrementing the insertion iterator before calling them. It's not
a nice state of affairs, for now just undo the problematic parts of the change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372050
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Mon, 16 Sep 2019 23:41:19 +0000 (23:41 +0000)]
llvm-reduce: Make tests shell-independent by passing the interpreter on the command line rather than using #! in the test file
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372049
91177308-0d34-0410-b5e6-
96231b3b80d8
David L. Jones [Mon, 16 Sep 2019 23:36:35 +0000 (23:36 +0000)]
Add libc to path mappings in git-llvm.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372048
91177308-0d34-0410-b5e6-
96231b3b80d8
Nemanja Ivanovic [Mon, 16 Sep 2019 22:54:52 +0000 (22:54 +0000)]
[PowerPC] Cust lower fpext v2f32 to v2f64 from extract_subvector v4f32
Add the missing piece of r372029.
Somehow when the patch for review D61961 was committed, only the test case
went in and the code didn't. This of course caused all kinds of build bot
breaks.
This patch just adds the code for that patch.
Author: Lei Huang
Differential revision: https://reviews.llvm.org/D61961
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372043
91177308-0d34-0410-b5e6-
96231b3b80d8
Francis Visoiu Mistrih [Mon, 16 Sep 2019 22:45:17 +0000 (22:45 +0000)]
[Remarks] Allow remarks::Format::YAML to take a string table
It should be allowed to take a string table in case all the strings in
the remarks point there, but it shouldn't use it during serialization.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372042
91177308-0d34-0410-b5e6-
96231b3b80d8
Joel E. Denny [Mon, 16 Sep 2019 21:22:29 +0000 (21:22 +0000)]
[lit] Make internal diff work in pipelines
When using lit's internal shell, RUN lines like the following
accidentally execute an external `diff` instead of lit's internal
`diff`:
```
# RUN: program | diff file -
# RUN: not diff file1 file2 | FileCheck %s
```
Such cases exist now, in `clang/test/Analysis` for example. We are
preparing patches to ensure lit's internal `diff` is called in such
cases, which will then fail because lit's internal `diff` cannot
currently be used in pipelines and doesn't recognize `-` as a
command-line option.
To enable pipelines, this patch moves lit's `diff` implementation into
an out-of-process script, similar to lit's `cat` implementation. A
follow-up patch will implement `-` to mean stdin.
Reviewed By: probinson, stella.stamenova
Differential Revision: https://reviews.llvm.org/D66574
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372035
91177308-0d34-0410-b5e6-
96231b3b80d8
Bardia Mahjour [Mon, 16 Sep 2019 20:44:15 +0000 (20:44 +0000)]
[NFC] Test commit access
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372033
91177308-0d34-0410-b5e6-
96231b3b80d8
DeForest Richards [Mon, 16 Sep 2019 20:29:56 +0000 (20:29 +0000)]
[Docs] Bug fix for docs homepage
Removes reference to non-existent Reference Documentation page.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@372032
91177308-0d34-0410-b5e6-
96231b3b80d8