]> granicus.if.org Git - icu/log
icu
6 years agoICU-10923 Python logic for resource filters.
Shane Carr [Thu, 13 Dec 2018 07:55:13 +0000 (23:55 -0800)]
ICU-10923 Python logic for resource filters.

- Adds schema validation for config file
- Adds JSON comment stripping utility

6 years agoICU-20302 Fix wintz header file. (Thanks to Jungshik).
Jeff Genovy [Fri, 14 Dec 2018 08:56:51 +0000 (00:56 -0800)]
ICU-20302 Fix wintz header file. (Thanks to Jungshik).

6 years agoICU-20305 XLikelySubtags avoid illegal type conversion, fix some linter warnings
Markus Scherer [Fri, 14 Dec 2018 17:32:12 +0000 (09:32 -0800)]
ICU-20305 XLikelySubtags avoid illegal type conversion, fix some linter warnings

6 years agoICU-20302 Timezone detection fails on Windows 7. Also add a test case for Windows...
Jeff Genovy [Thu, 13 Dec 2018 03:42:48 +0000 (19:42 -0800)]
ICU-20302 Timezone detection fails on Windows 7. Also add a test case for Windows time zone detection failing.

6 years agoICU-10923 Adding --filterDir option to genrb.
Shane Carr [Wed, 12 Dec 2018 01:14:58 +0000 (17:14 -0800)]
ICU-10923 Adding --filterDir option to genrb.

- Reads, parses, and applies the filter file syntax.
- Removes unused keys from the resource bundle.
- Adds sample filter txt file with test in intltest.

6 years agoICU-20300 Changing buildtool nametuples to polymorphic classes.
Shane Carr [Thu, 13 Dec 2018 08:56:13 +0000 (00:56 -0800)]
ICU-20300 Changing buildtool nametuples to polymorphic classes.

6 years agoICU-9622 Adding support for date/time skeletons
Mihai Nita [Wed, 12 Dec 2018 18:22:04 +0000 (10:22 -0800)]
ICU-9622 Adding support for date/time skeletons

6 years agoICU-20308 Define a fixed suffix without the ICU version suffix
Victor Chang [Fri, 30 Nov 2018 18:52:28 +0000 (18:52 +0000)]
ICU-20308 Define a fixed suffix without the ICU version suffix

- Add a config macro U_DISABLE_VERSION_SUFFIX to disable version suffix

6 years agoICU-20292 u_charFromName() prevent code point integer overflow, and limit to at most...
Markus Scherer [Wed, 12 Dec 2018 06:05:08 +0000 (22:05 -0800)]
ICU-20292 u_charFromName() prevent code point integer overflow, and limit to at most 8 hex digits

6 years agoICU-20279 Remove MSVC specific macro _ARM64_
Jeff Genovy [Sun, 18 Nov 2018 22:06:21 +0000 (14:06 -0800)]
ICU-20279 Remove MSVC specific macro _ARM64_

Remove unneeded check for MSVC internal _ARM64_ macro in normlzr.cpp

6 years agoICU-20299 Adds Python 2.7 support to data build script.
Shane Carr [Sat, 8 Dec 2018 01:22:10 +0000 (17:22 -0800)]
ICU-20299 Adds Python 2.7 support to data build script.

6 years agoICU-20307 Add reldatefmt.h and compactdecimalformat.h into test/hdrtst/cxxfiles.txt
Victor Chang [Tue, 11 Dec 2018 15:59:15 +0000 (15:59 +0000)]
ICU-20307 Add reldatefmt.h and compactdecimalformat.h into test/hdrtst/cxxfiles.txt

6 years agoICU-20295 Fix wrong java doc of "{#link" in TimeZoneFormat
Victor Chang [Fri, 7 Dec 2018 20:50:30 +0000 (20:50 +0000)]
ICU-20295 Fix wrong java doc of "{#link" in TimeZoneFormat

6 years agoICU-10923 Fixing broken dependency names in BUILDRULES.py.
Shane Carr [Sat, 8 Dec 2018 04:06:22 +0000 (20:06 -0800)]
ICU-10923 Fixing broken dependency names in BUILDRULES.py.

Fixes warnings and a flaky test.

6 years agoICU-10923 Adding initial version of data file filtering.
Shane Carr [Thu, 6 Dec 2018 08:33:10 +0000 (00:33 -0800)]
ICU-10923 Adding initial version of data file filtering.

- Reads filters.json or .hjson from ICU_DATA_FILTER_FILE environment variable
- Adds DepTarget for dependency semantics, and warns for missing deps.
- Fixes certain tests that crash with sliced locale data.
- Includes support for 4 filter types.

6 years agoICU-10923 Refactoring in preparation for data file filtering.
Shane Carr [Wed, 5 Dec 2018 03:07:27 +0000 (19:07 -0800)]
ICU-10923 Refactoring in preparation for data file filtering.

- Adding SpaceSeparatedList abstraction.
- Adding ListRequest abstraction.
- Adding separate dep_files option to SingleExecutionRequest.
- Removing unused variable pkg_exclusions.
- Adding IndexTxtRequest abstraction.
- Moving curr/supplementalData.txt into its own target.
- Changing getters to properties on Config.
- Re-indenting and refactoring data/BUILDRULES.py
- Adding category to request tuples. Refactoring translit.

6 years agoICU-11053 Fix locale parsing which has _ timezone
Frank Tang [Wed, 5 Dec 2018 02:49:58 +0000 (10:49 +0800)]
ICU-11053 Fix locale parsing which has _ timezone

6 years agoICU-20186 Adding test for leading and trailing spaces in DecimalFormat.
Shane Carr [Tue, 27 Nov 2018 01:01:32 +0000 (17:01 -0800)]
ICU-20186 Adding test for leading and trailing spaces in DecimalFormat.

6 years agoICU-20247 use = instead of == in sh compare
Steven R. Loomis [Wed, 5 Dec 2018 19:41:44 +0000 (11:41 -0800)]
ICU-20247 use = instead of == in sh compare

* Note: the diff will show changes to "runstatedir". This is
a feature which ICU does not use, and it is not in any released
autoconf version. Perhaps some distributions patched autoconf
locally.

https://lists.gnu.org/archive/html/autoconf/2018-07/msg00006.html

6 years agoICU-20287 ICU4J source tarball does not contain maven pom templates
Mat Booth [Tue, 27 Nov 2018 18:06:50 +0000 (18:06 +0000)]
ICU-20287 ICU4J source tarball does not contain maven pom templates

6 years agoICU-20293 Adds common base class to implement C API validation methods.
Shane Carr [Tue, 4 Dec 2018 07:32:13 +0000 (23:32 -0800)]
ICU-20293 Adds common base class to implement C API validation methods.

6 years agoICU-20288 add line_cj.txt to RBBI Monkey test.
Andy Heninger [Fri, 30 Nov 2018 01:50:18 +0000 (17:50 -0800)]
ICU-20288 add line_cj.txt to RBBI Monkey test.

6 years agoICU-11919 OlsonTimeZone, fix for Thread Sanitizer failure in cloneAsThawed().
Andy Heninger [Tue, 27 Nov 2018 22:23:19 +0000 (14:23 -0800)]
ICU-11919 OlsonTimeZone, fix for Thread Sanitizer failure in cloneAsThawed().

6 years agoICU-20203 update ICU to Unicode 12 beta
Markus Scherer [Thu, 11 Oct 2018 23:04:05 +0000 (16:04 -0700)]
ICU-20203 update ICU to Unicode 12 beta
- data as of 2018-nov-26
- API constants for new blocks & scripts
- sync RBBIMonkeyTest.java test data with C++

6 years agoICU-20186 Adding test for semicolon behavior and spacing in DecimalFormat.
Shane Carr [Mon, 1 Oct 2018 23:18:39 +0000 (16:18 -0700)]
ICU-20186 Adding test for semicolon behavior and spacing in DecimalFormat.

6 years agoICU-20281 Reenable the VS2015 build bot. Use manual install of Py3.
Jeff Genovy [Wed, 21 Nov 2018 06:47:25 +0000 (22:47 -0800)]
ICU-20281 Reenable the VS2015 build bot. Use manual install of Py3.

6 years agoICU-20276 Accept empty strings in Locale::setUnicodeKeywordValue().
Fredrik Roubert [Mon, 19 Nov 2018 14:12:05 +0000 (15:12 +0100)]
ICU-20276 Accept empty strings in Locale::setUnicodeKeywordValue().

The API documentation is perfectly clear about this, an empty string for
the value means that the keyword should be removed:

  @param keywordValue value of the keyword to be set. If 0-length or
   NULL, will result in the keyword being removed. No error is given if
   that keyword does not exist.

6 years agoICU-10923 Disable the VS2015 build until the Azure VM image has a working Python 3.
Jeff Genovy [Mon, 19 Nov 2018 20:32:46 +0000 (12:32 -0800)]
ICU-10923 Disable the VS2015 build until the Azure VM image has a working Python 3.

6 years agoICU-20179 Remove platform-specific mutex and atomics implementations.
Andy Heninger [Thu, 1 Nov 2018 00:08:38 +0000 (17:08 -0700)]
ICU-20179 Remove platform-specific mutex and atomics implementations.

Remove all POSIX and Win32 specific mutex, atomic and threading implementations
in favor of C++11 std library functions.

Move the related (internal) ICU types and functions into the icu namespace.

6 years agoICU-20230 Implementing COMPACT field.
Shane Carr [Fri, 16 Nov 2018 04:58:24 +0000 (20:58 -0800)]
ICU-20230 Implementing COMPACT field.

Adds some plumbing to allow MutablePatternModifier to set fields, and otherwise builds upon the infrastructure from the previous commit to add the MEASURE_UNIT field.

6 years agoICU-10923 Rewriting data build orchestration in Python.
Shane Carr [Sat, 25 Aug 2018 06:39:10 +0000 (23:39 -0700)]
ICU-10923 Rewriting data build orchestration in Python.

- Creates new Python package in icu4c/data/buildtool
- Creates BUILRDULES.py in icu4c/data and icu4c/test/testdata, unified between Unix/Windows
- Removes most data build orchestration rules from makedata.mak, testdata.mak, data/Makefile.in, and test/testdata/Makefile.in
- Removes pool.res files and builds them on the fly instead

6 years agoICU-20271 Use C++11 operator new = delete to disallow heap allocation.
Fredrik Roubert [Thu, 15 Nov 2018 13:01:42 +0000 (14:01 +0100)]
ICU-20271 Use C++11 operator new = delete to disallow heap allocation.

6 years agoICU-10183 Use std::mutex by default; clean up related dependency check issues.
Andy Heninger [Mon, 12 Nov 2018 18:20:49 +0000 (10:20 -0800)]
ICU-10183 Use std::mutex by default; clean up related dependency check issues.

6 years agoICU-13267 Implementing MEASURE_UNIT field.
Shane Carr [Wed, 14 Nov 2018 05:42:27 +0000 (21:42 -0800)]
ICU-13267 Implementing MEASURE_UNIT field.

Adds plumbing to trim whitespace near the FormattedNumber API boundary.
That plumbing requires a change to dependencies.txt.

6 years agoICU-13441 For zh/ja, tailor linebreak classes for quotations such as “ 201C and ...
Dongyuan Liu [Thu, 18 Oct 2018 07:42:27 +0000 (15:42 +0800)]
ICU-13441 For zh/ja, tailor linebreak classes for quotations such as “ 201C and ” 201D

6 years agoICU-20185 Remove U_USER_ATOMICS_H, U_USER_MUTEX_H, U_USER_MUTEX_CPP
Andy Heninger [Wed, 31 Oct 2018 21:30:58 +0000 (14:30 -0700)]
ICU-20185 Remove U_USER_ATOMICS_H, U_USER_MUTEX_H, U_USER_MUTEX_CPP

6 years agoICU-20202 Merge #ifdef __cplusplus blocks.
Fredrik Roubert [Mon, 5 Nov 2018 13:32:38 +0000 (14:32 +0100)]
ICU-20202 Merge #ifdef __cplusplus blocks.

For historical reasons (commit 3b12074b4092241a7e73ec8c7ea6be75548b1b82),
all C++ code (even #include statements) in cmemory.h is contained in an
#ifdef block at the end of the file. A recent bugfix inadvertently added
an additional #ifdef __cplusplus block at the beginning of the file to
add a new #include statement so that C++ #include statements now are
found in two places (commit 1bad36b91afa1fb33a0d45902a163a923d6e860a).

6 years agoICU-20084 IntlTest, add WHERE macro; remove redundant TEST macros.
Andy Heninger [Tue, 6 Nov 2018 02:37:38 +0000 (18:37 -0800)]
ICU-20084 IntlTest, add WHERE macro; remove redundant TEST macros.

6 years agoICU-20239 Add VS2015 build line to the Azure CI builds.
Jeff Genovy [Mon, 12 Nov 2018 05:30:52 +0000 (21:30 -0800)]
ICU-20239 Add VS2015 build line to the Azure CI builds.

6 years agoICU-20250 make UnicodeSet(intprop=value) faster
Markus Scherer [Fri, 9 Nov 2018 20:54:22 +0000 (12:54 -0800)]
ICU-20250 make UnicodeSet(intprop=value) faster
- fastpath for UnicodeSet.add(new last range)
- fewer UnicodeSet memory allocations:
  initial internal list array, exponential array growth,
  allocate strings list/set only when first one is added
- faster CodePointTrie.getRange(): fewer calls to filter function
- revert UnicodeSet(intprop=value) from trie ranges to range starts + lookup
- cache per-int-prop range starts: fewer lookups

6 years agoICU-20215 Conver the VSTS/Azure CI builds definitions to a YML file in the repo ...
Jeff Genovy [Wed, 17 Oct 2018 07:03:12 +0000 (00:03 -0700)]
ICU-20215 Conver the VSTS/Azure CI builds definitions to a YML file in the repo (similar to .travis.yml)

6 years agoICU-20238 Autodetect Visual Studio version, and autodetect the installed Windows...
Jeff Genovy [Thu, 25 Oct 2018 02:28:43 +0000 (19:28 -0700)]
ICU-20238 Autodetect Visual Studio version, and autodetect the installed Windows 10 SDK version.

6 years agoICU-13267 Minor documentation and test changes.
Shane Carr [Thu, 8 Nov 2018 00:16:47 +0000 (16:16 -0800)]
ICU-13267 Minor documentation and test changes.

6 years agoICU-13267 Refactoring field position testing logic into helper function.
Shane Carr [Wed, 7 Nov 2018 01:07:49 +0000 (17:07 -0800)]
ICU-13267 Refactoring field position testing logic into helper function.

Makes future field position logic easier to test.

6 years agoICU-13701 Syncs C and J increment rounding. Checks for nickel sooner.
Shane Carr [Sat, 3 Nov 2018 05:19:53 +0000 (22:19 -0700)]
ICU-13701 Syncs C and J increment rounding. Checks for nickel sooner.

6 years agoICU-13701 Refactoring DecimalQuantity: removing lOptPos/rOptPos.
Shane Carr [Thu, 25 Oct 2018 04:25:39 +0000 (21:25 -0700)]
ICU-13701 Refactoring DecimalQuantity: removing lOptPos/rOptPos.

Combined ICU4C and ICU4J.

6 years agoICU-20250 faster MutableCodePointTrie.build(): use a hashtable to find equal blocks...
Markus Scherer [Fri, 2 Nov 2018 19:47:09 +0000 (12:47 -0700)]
ICU-20250 faster MutableCodePointTrie.build(): use a hashtable to find equal blocks in earlier parts of the compacted data & index arrays

6 years agoICU-20169 Replace uprv_malloc() / uprv_free() with MemoryPool.
Fredrik Roubert [Fri, 2 Nov 2018 16:50:34 +0000 (17:50 +0100)]
ICU-20169 Replace uprv_malloc() / uprv_free() with MemoryPool.

This resolves the immediate problem of brittle memory management
in the error handling code.

An obvious future improvement would be to replace the old C style
"plain struct with pointers" VariantListEntry, AttributeListEntry
and ExtensionListEntry with contemporary C++ style containers that
take care of ownership and memory management.

6 years agoICU-20249 An internal helper class for stack allocated UResourceBundle.
Fredrik Roubert [Wed, 31 Oct 2018 19:18:34 +0000 (20:18 +0100)]
ICU-20249 An internal helper class for stack allocated UResourceBundle.

6 years agoICU-20172 Add ICU4C dependency checker to Travis CI
Andy Heninger [Mon, 5 Nov 2018 19:16:41 +0000 (11:16 -0800)]
ICU-20172 Add ICU4C dependency checker to Travis CI

6 years agoICU-13180 Support skiping building the UWP projects with a command line MSBuild option.
Jeff Genovy [Tue, 23 Oct 2018 06:12:07 +0000 (23:12 -0700)]
ICU-13180 Support skiping building the UWP projects with a command line MSBuild option.

6 years agoICU-20255 revert to reflection for methods not yet in Android API level 21..23
Markus Scherer [Mon, 5 Nov 2018 23:21:08 +0000 (15:21 -0800)]
ICU-20255 revert to reflection for methods not yet in Android API level 21..23

6 years agoICU-20169 Use LocalULanguageTagPointer also inside of ultag_parse().
Fredrik Roubert [Fri, 2 Nov 2018 17:13:25 +0000 (18:13 +0100)]
ICU-20169 Use LocalULanguageTagPointer also inside of ultag_parse().

6 years agoICU-20202 Replace CodePointMatcherWarehouse with MemoryPool.
Fredrik Roubert [Mon, 29 Oct 2018 21:20:30 +0000 (22:20 +0100)]
ICU-20202 Replace CodePointMatcherWarehouse with MemoryPool.

The shared templated helper class MemoryPool can be used to replace the
local helper class CodePointMatcherWarehouse, reducing the amount of
specialized code needed.

6 years agoICU-10183 revert mutexes to platform code while sorting dependencies from std::mutex.
Andy Heninger [Fri, 2 Nov 2018 22:34:35 +0000 (15:34 -0700)]
ICU-10183 revert mutexes to platform code while sorting dependencies from std::mutex.

6 years agoICU-20202 MemoryPool and uloc_key_type structs inherit from UMemory. Fixes dependenci...
Andy Heninger [Fri, 2 Nov 2018 21:54:45 +0000 (14:54 -0700)]
ICU-20202 MemoryPool and uloc_key_type structs inherit from UMemory. Fixes dependencies on global operator new().

6 years agoICU-20246 Fixing another integer overflow in number parsing.
Shane Carr [Tue, 30 Oct 2018 06:52:44 +0000 (23:52 -0700)]
ICU-20246 Fixing another integer overflow in number parsing.

6 years agoICU-10183 Mutexes, add C++11 std::mutex based implementation.
Andy Heninger [Sat, 29 Sep 2018 00:02:04 +0000 (17:02 -0700)]
ICU-10183 Mutexes, add C++11 std::mutex based implementation.

6 years agoICU-20169 Use smart pointers in all locale code instead of u*_close().
Fredrik Roubert [Wed, 31 Oct 2018 14:07:05 +0000 (15:07 +0100)]
ICU-20169 Use smart pointers in all locale code instead of u*_close().

Doing this consistently first will make it easier to then clean up
resource management and error handling later.

6 years agoICU-20158 Pass ByteSink from Locale::forLanguageTag() to uloc_forLanguageTag().
Fredrik Roubert [Tue, 30 Oct 2018 22:35:03 +0000 (23:35 +0100)]
ICU-20158 Pass ByteSink from Locale::forLanguageTag() to uloc_forLanguageTag().

This eliminates the need for a scratch buffer in Locale::forLanguageTag()
and also the need for counting bytes required in uloc_forLanguageTag(),
something that ByteSink will now handle correctly.

6 years agoICU-20202 Replace char* kwdBuf with MemoryPool<CharString>.
Fredrik Roubert [Tue, 30 Oct 2018 21:12:07 +0000 (22:12 +0100)]
ICU-20202 Replace char* kwdBuf with MemoryPool<CharString>.

Instead of _appendLDMLExtensionAsKeywords() requiring to receive a pre-
allocated buffer of sufficient size to store all the temporary strings
it needs to store, have it use a MemoryPool<CharString> to allocate
storage space as needed.

Storing strings as individual CharString objects, instead of as NUL
delimited substrings in a contiguous memory area, also eliminates the
need for keeping track of string boundaries and NUL terminators.

6 years agoICU-20245 tzdata2018g updates
Yoshito Umaoka [Tue, 30 Oct 2018 12:50:34 +0000 (08:50 -0400)]
ICU-20245 tzdata2018g updates

6 years agoICU-20221 Add support for building with Cygwin/GCC to the AppVeyor CI builds.
Jeff Genovy [Fri, 26 Oct 2018 18:18:35 +0000 (11:18 -0700)]
ICU-20221 Add support for building with Cygwin/GCC to the AppVeyor CI builds.

6 years agoICU-20202 Replace UVector with MemoryPool in uloc_keytype.
Fredrik Roubert [Mon, 29 Oct 2018 21:50:27 +0000 (22:50 +0100)]
ICU-20202 Replace UVector with MemoryPool in uloc_keytype.

By moving the required call to uhash_close() into the destructor of
LocExtKeyData and using CharString instead of raw chunks of bytes
allocated with uprv_malloc(), it becomes easier to guarantee that
memory handling is correct, without leaks or overflows.

With the need for custom deleter functions removed, the code doesn't use
any of the additional functionality provided by UVector, it just needs a
simple way to keep track of allocated objects to delete them after it's
done using them, which MemoryPool does in a simpler and typesafe way.

6 years agoICU-20202 Replace UVector with MemoryPool in CalendarDataSink.
Fredrik Roubert [Mon, 29 Oct 2018 21:29:12 +0000 (22:29 +0100)]
ICU-20202 Replace UVector with MemoryPool in CalendarDataSink.

CalendarDataSink doesn't use any of the additional functionality
provided by UVector, it just needs a simple way to keep track of
allocated objects to delete them after it's done using them.

6 years agoICU-20231 Adding tests for accounting with variable currency widths.
Shane Carr [Wed, 24 Oct 2018 06:47:30 +0000 (23:47 -0700)]
ICU-20231 Adding tests for accounting with variable currency widths.

6 years agoICU-20159 Fixing gcc warnings in project and test code.
Shane Carr [Thu, 25 Oct 2018 01:48:55 +0000 (18:48 -0700)]
ICU-20159 Fixing gcc warnings in project and test code.

6 years agoICU-13701 Adding custom logic for nickel rounding, C and J.
Shane Carr [Fri, 26 Oct 2018 00:50:10 +0000 (17:50 -0700)]
ICU-13701 Adding custom logic for nickel rounding, C and J.

Avoids expensive arithmetic when performing nickel rounding for currencies such as CAD, CHF, and DKK.

6 years agoICU-20209 Fix build failures on Windows with std::atomic not in enclosing namespace std
Jeff Genovy [Fri, 19 Oct 2018 23:19:24 +0000 (16:19 -0700)]
ICU-20209 Fix build failures on Windows with std::atomic not in enclosing namespace std

Also: Change to use the ICU namespace macro instead, and skip doxygen as well.

6 years agoICU-20202 Replace CharStringPool with MemoryPool.
Fredrik Roubert [Mon, 29 Oct 2018 21:12:00 +0000 (22:12 +0100)]
ICU-20202 Replace CharStringPool with MemoryPool.

The shared templated helper class MemoryPool is a drop-in replacement
for the local helper class CharStringPool, with a simpler implementation
and an interface that allows parameters to be passed to the constructor.

6 years agoICU-20202 Add an internal helper class to own heap allocated objects.
Fredrik Roubert [Wed, 24 Oct 2018 20:45:25 +0000 (22:45 +0200)]
ICU-20202 Add an internal helper class to own heap allocated objects.

This will be used first to replace existing locally defined memory
management helper classes such as CharStringPool (uloc_tag.cpp) and
CodePointMatcherWarehouse (numparse_affixes.h), then in new code.

6 years agoICU-20235 Undefine OVERFLOW in case Microsoft math.h has defined it.
Fredrik Roubert [Fri, 26 Oct 2018 11:03:13 +0000 (13:03 +0200)]
ICU-20235 Undefine OVERFLOW in case Microsoft math.h has defined it.

6 years agoICU-20240 Fix Windows build failure in japancal.cpp
Jeff Genovy [Fri, 26 Oct 2018 00:13:23 +0000 (17:13 -0700)]
ICU-20240 Fix Windows build failure in japancal.cpp

6 years agoICU-20194 TimeZone createSystemTimeZone doesn't set error code on OOM error.
Jeff Genovy [Mon, 17 Sep 2018 09:03:34 +0000 (02:03 -0700)]
ICU-20194 TimeZone createSystemTimeZone doesn't set error code on OOM error.

6 years agoICU-20132 Pass ByteSink from Locale::toLanguageTag() to uloc_toLanguageTag().
Fredrik Roubert [Mon, 22 Oct 2018 20:28:20 +0000 (22:28 +0200)]
ICU-20132 Pass ByteSink from Locale::toLanguageTag() to uloc_toLanguageTag().

This eliminates the need for a scratch buffer in Locale::toLanguageTag()
and also the need for counting bytes required in uloc_toLanguageTag(),
something that ByteSink will now handle correctly and thereby
eliminating the bug where too few bytes required was returned.

6 years agoICU-20228 Revert file from commit 10e79698d76e6d4d0aa2eb10464657aa60c231e7.
Fredrik Roubert [Wed, 24 Oct 2018 20:51:50 +0000 (22:51 +0200)]
ICU-20228 Revert file from commit 10e79698d76e6d4d0aa2eb10464657aa60c231e7.

This file was changed by mistake (and not caught by the presubmit tests
because of unrelated build failures).

6 years agoICU-20228 Fix common typos for "language".
Fredrik Roubert [Mon, 22 Oct 2018 18:23:27 +0000 (20:23 +0200)]
ICU-20228 Fix common typos for "language".

6 years agoICU-11511 Adding tests for CLDR-10103 scientific notation spec changes.
Shane Carr [Fri, 5 Oct 2018 01:59:21 +0000 (18:59 -0700)]
ICU-11511 Adding tests for CLDR-10103 scientific notation spec changes.

6 years agoICU-20224 tzdata2018f updates.
Yoshito Umaoka [Fri, 19 Oct 2018 22:12:06 +0000 (18:12 -0400)]
ICU-20224 tzdata2018f updates.

6 years agoICU-20109 Upgrade Java RelativeDateTimeFormatter QUARTER to @draft
Frank Tang [Thu, 18 Oct 2018 05:05:31 +0000 (22:05 -0700)]
ICU-20109 Upgrade Java RelativeDateTimeFormatter QUARTER to @draft
(#221)

add tests for AbsoluteUnit.QUARTER

6 years agoICU-20080 Avoid strange compiler behaviour in ASSERT_EQUAL() macro.
Fredrik Roubert [Fri, 12 Oct 2018 12:33:03 +0000 (14:33 +0200)]
ICU-20080 Avoid strange compiler behaviour in ASSERT_EQUAL() macro.

Using temporary variables for the two values to be compared here makes
GCC compile the code just like we expect it to. (What it really is that
it otherwise does on some architechtures remains a mystery.)

This will make the tests pass as expected also on IA-32 with GCC.

It'll also make it possible to revert the old workaround for SPARC
introduced by commit 5b0592af79c7601d08cafcbbc7b71077faeb7e4f.

Tested:

Linux gcc45 3.16.0-5-686-pae #1 SMP Debian 3.16.51-3+deb8u1 (2018-01-08) i686 GNU/Linux

Debian clang version 3.5.0-10 (tags/RELEASE_350/final) (based on LLVM 3.5.0)
g++ (Debian 4.9.2-10+deb8u1) 4.9.2

Linux gcc202 4.16.0-1-sparc64-smp #1 SMP Debian 4.16.5-1 (2018-04-29) sparc64 GNU/Linux

clang version 4.0.1-10+sparc64 (tags/RELEASE_401/final)
g++ (Debian 8.2.0-7) 8.2.0

6 years agoICU-20208 uspoof.cpp function checkImpl should be static, regenerate urename.h
Jeff Genovy [Thu, 18 Oct 2018 02:47:35 +0000 (19:47 -0700)]
ICU-20208 uspoof.cpp function checkImpl should be static, regenerate urename.h

6 years agoICU-20212 unistr.h, review comments from Markus for doc formatting.
Andy Heninger [Thu, 18 Oct 2018 16:56:27 +0000 (09:56 -0700)]
ICU-20212 unistr.h, review comments from Markus for doc formatting.

6 years agoICU-20212 Tweaks to markdown API docs in unistr.h
Andy Heninger [Tue, 16 Oct 2018 19:59:54 +0000 (12:59 -0700)]
ICU-20212 Tweaks to markdown API docs in unistr.h

6 years agoICU-20212 Markdown API docs in unistr.h
Andy Heninger [Tue, 16 Oct 2018 00:53:21 +0000 (17:53 -0700)]
ICU-20212 Markdown API docs in unistr.h

6 years agoICU-20214 Fix namespace error on Cygwin
Ken Brown [Tue, 16 Oct 2018 18:48:36 +0000 (14:48 -0400)]
ICU-20214 Fix namespace error on Cygwin

6 years agoICU-20166 Adding commit-checker tool.
Shane Carr [Wed, 17 Oct 2018 20:01:53 +0000 (13:01 -0700)]
ICU-20166 Adding commit-checker tool.

This tool checks the integrity of a range of commits, in particular references to the corresponding Jira issues.

Squashed commits:

ICU-20119 Adding first commit report.
ICU-20166 Handling tickets that do not require commits.
ICU-20166 Search Jira issues from extra commits
ICU-20119 Updating commit report.
ICU-20166 Adding copyright to commit checker tools.
ICU-20119 Updating commit report.
ICU-20166 Require ticket at beginning of commit message.
ICU-20119 Updating commit report.
ICU-20119 Updating commit report.
ICU-20119 Updating commit report.
ICU-20120 Updating commit report.
ICU-20166 Removing REPORT.md from source control.

6 years agoICU-20205 RelativeDateTimeFormatter pt data fix, improved error handling and test...
Andy Heninger [Fri, 12 Oct 2018 23:19:14 +0000 (16:19 -0700)]
ICU-20205 RelativeDateTimeFormatter pt data fix, improved error handling and test. (#210)

* ICU-20205 Add locale test for RelativeDateTimeFormatter.

* ICU-20205 Fix error in pt relative date data. Improve error handling in code.

* ICU-20205 Add instantiation test & regen data from ICU4C

* ICU-20205 Added DateFormatSymbols error check per jefgen's comments.

6 years agoICU-20120 BRS63GA Updating ICU4J 63 readme.html (#203)
Yoshito Umaoka [Wed, 10 Oct 2018 17:03:05 +0000 (13:03 -0400)]
ICU-20120 BRS63GA Updating ICU4J 63 readme.html (#203)

Just updating API change report link from svn to local.

6 years agoICU-20198 Add issue browse link to PR template. (#200)
Shane F. Carr [Tue, 9 Oct 2018 19:05:33 +0000 (14:05 -0500)]
ICU-20198 Add issue browse link to PR template. (#200)

6 years agoICU-20120 BRS63GA: Update version numbers/readme for ICU 63 GA. (#199)
Jeff Genovy [Mon, 8 Oct 2018 17:56:42 +0000 (10:56 -0700)]
ICU-20120 BRS63GA: Update version numbers/readme for ICU 63 GA. (#199)

6 years agoICU-20192 Add Automatic-Module-Name to META-INF/MANIFEST.MF (#193)
leadpony [Mon, 8 Oct 2018 15:41:02 +0000 (00:41 +0900)]
ICU-20192 Add Automatic-Module-Name to META-INF/MANIFEST.MF (#193)

* Add Automatic-Module-Name to META-INF/MANIFEST.MF

* Added com.ibm.icu.number in Export-Package list

* Add Automatic-Module-Name to charset and localespi

6 years agoICU-20182 Updated ICU4J pom to reflect the repository migration from svn to git....
Yoshito Umaoka [Mon, 8 Oct 2018 15:37:28 +0000 (11:37 -0400)]
ICU-20182 Updated ICU4J pom to reflect the repository migration from svn to git. (#196)

6 years agoICU-20120 Travis TSAN testing, limit time. (#198)
Andy Heninger [Sat, 6 Oct 2018 03:24:45 +0000 (20:24 -0700)]
ICU-20120 Travis TSAN testing, limit time. (#198)

* ICU-20120 Travis TSAN testing, limit time.

* ICU-20120 Travis TSAN testing, limit time.

6 years agoICU-20196 Fix MSVC/clang compiler warning C4251, export explicit template, required...
Jeff Genovy [Fri, 5 Oct 2018 17:44:52 +0000 (10:44 -0700)]
ICU-20196 Fix MSVC/clang compiler warning C4251, export explicit template, required for building DLLs on Windows. Also fix a few other warnings as well.

6 years agoICU-20120 63 BRS, integrate cldr release-34-beta with various fixes (#186)
pedberg-icu [Fri, 5 Oct 2018 18:01:15 +0000 (11:01 -0700)]
ICU-20120 63 BRS, integrate cldr release-34-beta with various fixes (#186)

6 years agoICU-20193 urename.h shouldn't be ignored by other compilers except VS IntelliSense...
gvictor [Thu, 4 Oct 2018 23:29:57 +0000 (00:29 +0100)]
ICU-20193 urename.h shouldn't be ignored by other compilers except VS IntelliSense (#189)

The macro _MSC_VER is not defined in other compilers.
Change the logic and so urename.h is ignored on VS IntelliSense

6 years agoICU-20191 Don't use Win32 APIs on Cygwin (#185)
kbrow1i [Thu, 4 Oct 2018 21:10:00 +0000 (17:10 -0400)]
ICU-20191 Don't use Win32 APIs on Cygwin (#185)

This was fixed in earlier commits (see, for example, ICU-12786), but
the problem was reintroduced in commits f8ba68e and fcb82cb.

6 years agoICU-20119 Update ICU4C #ifndef U_HIDE_XXX guard conditionals (PR #183) release-63-rc
pedberg-icu [Mon, 1 Oct 2018 04:23:42 +0000 (21:23 -0700)]
ICU-20119 Update ICU4C #ifndef U_HIDE_XXX guard conditionals (PR #183)

ICU-20119 Update ICU4C #ifndef U_HIDE_XXX guard conditionals (PR #183)

6 years agoICU-20119 cldr release-34-alpha3 integration (#181)
pedberg-icu [Fri, 28 Sep 2018 23:09:15 +0000 (16:09 -0700)]
ICU-20119 cldr release-34-alpha3 integration (#181)

ICU-20119 cldr release-34-alpha3 integration (PR #181):
* ICU-20119 63rc BRS, cldr 34-alpha3: add ku,xh; fixes for de/it CompactDec, availFmts yw amd MW patterns
* ICU-20119 Skip & log_knownIssue for Windows LCID mapping problem with ckb/ku