]> granicus.if.org Git - python/log
python
7 years agobpo-31536: Avoid wholesale rebuild after `make regen-all` (#3678)
Antoine Pitrou [Wed, 20 Sep 2017 21:57:56 +0000 (23:57 +0200)]
bpo-31536: Avoid wholesale rebuild after `make regen-all` (#3678)

* bpo-31536: Avoid wholesale rebuild after `make regen-all`

* Add NEWS

7 years agobpo-26510: make argparse subparsers required by default (#3027)
Anthony Sottile [Wed, 20 Sep 2017 21:35:27 +0000 (14:35 -0700)]
bpo-26510: make argparse subparsers required by default (#3027)

This fixes a regression from Python 2.  To get optional subparsers,
use the new parameter ``add_subparsers(required=False)``.

Patch by Anthony Sottile.

7 years agobpo-31533: fix broken link to OpenSSL docs (#3674)
Felipe [Wed, 20 Sep 2017 18:20:18 +0000 (20:20 +0200)]
bpo-31533: fix broken link to OpenSSL docs (#3674)

7 years agocloses bpo-31525: require sqlite3_prepare_v2 (#3666)
Benjamin Peterson [Wed, 20 Sep 2017 14:36:18 +0000 (07:36 -0700)]
closes bpo-31525: require sqlite3_prepare_v2 (#3666)

This is based on
https://github.com/ghaering/pysqlite/commit/40b349cadbd87c42f70fc92e5e1aee6d02564c6d#diff-0489411409cd2934730e88bf7767790,
though we can be a bit more aggressive about deleting code.

7 years agobpo-30486: Make cell_set_contents() symbol private (#3668)
Victor Stinner [Wed, 20 Sep 2017 13:54:13 +0000 (06:54 -0700)]
bpo-30486: Make cell_set_contents() symbol private (#3668)

Don't export the cell_set_contents() symbol in the C API.

7 years agobpo-31506: Improve the error message logic for object.__new__ and object.__init__...
Serhiy Storchaka [Wed, 20 Sep 2017 03:44:32 +0000 (06:44 +0300)]
bpo-31506: Improve the error message logic for object.__new__ and object.__init__. (GH-3650)

7 years agobpo-31500: Removed fixed size of IDLE config dialog. (#3664)
Terry Jan Reedy [Tue, 19 Sep 2017 23:01:45 +0000 (19:01 -0400)]
bpo-31500: Removed fixed size of IDLE config dialog. (#3664)

This one line of Serhiy Storchacka's bpo-31500 patch for is needed for other issues.

7 years agoFix build issues in Doc/make.bat (#3658)
Steve Dower [Tue, 19 Sep 2017 19:31:28 +0000 (12:31 -0700)]
Fix build issues in Doc/make.bat (#3658)

7 years agobpo-31507 Add docstring to parseaddr function in email.utils.parseaddr (gh-3647)
Rohit Balasubramanian [Tue, 19 Sep 2017 19:10:49 +0000 (00:40 +0530)]
bpo-31507 Add docstring to parseaddr function in email.utils.parseaddr (gh-3647)

7 years agobpo-31479: Always reset the signal alarm in tests (#3588)
Victor Stinner [Tue, 19 Sep 2017 16:36:54 +0000 (09:36 -0700)]
bpo-31479: Always reset the signal alarm in tests (#3588)

* bpo-31479: Always reset the signal alarm in tests

Use "try: ... finally: signal.signal(0)" pattern to make sure that
tests don't "leak" a pending fatal signal alarm.

* Move two more alarm() calls into the try block

Fix also typo: replace signal.signal(0) with signal.alarm(0)

* Move another signal.alarm() into the try block

7 years agopythoninfo: ignore OSError(ENOSYS) on getrandom() (#3655)
Victor Stinner [Tue, 19 Sep 2017 14:37:24 +0000 (07:37 -0700)]
pythoninfo: ignore OSError(ENOSYS) on getrandom() (#3655)

7 years agobpo-31293: Fix crashes in truediv and mul of a timedelta by a float with a bad as_int...
Oren Milman [Tue, 19 Sep 2017 12:58:11 +0000 (15:58 +0300)]
bpo-31293: Fix crashes in truediv and mul of a timedelta by a float with a bad as_integer_ratio() method. (#3227)

7 years agobpo-31315: Fix an assertion failure in imp.create_dynamic(), when spec.name is not...
Oren Milman [Tue, 19 Sep 2017 11:39:47 +0000 (14:39 +0300)]
bpo-31315: Fix an assertion failure in imp.create_dynamic(), when spec.name is not a string. (#3257)

7 years agobpo-31492: Fix assertion failures in case of a module with a bad __name__ attribute...
Oren Milman [Tue, 19 Sep 2017 11:23:01 +0000 (14:23 +0300)]
bpo-31492: Fix assertion failures in case of a module with a bad __name__ attribute. (#3620)

7 years agopost 3.7.0a1 development
Ned Deily [Tue, 19 Sep 2017 07:12:46 +0000 (03:12 -0400)]
post 3.7.0a1 development

7 years agoMerge tag 'v3.7.0a1'
Ned Deily [Tue, 19 Sep 2017 07:09:31 +0000 (03:09 -0400)]
Merge tag 'v3.7.0a1'

7 years agoBump to 3.6.0a1 v3.7.0a1
Ned Deily [Tue, 19 Sep 2017 05:09:03 +0000 (01:09 -0400)]
Bump to 3.6.0a1

7 years agoUpdate PyDoc topics and NEWS blurbs for 3.7.0a1
Ned Deily [Tue, 19 Sep 2017 05:01:36 +0000 (01:01 -0400)]
Update PyDoc topics and NEWS blurbs for 3.7.0a1

7 years agoUpdate Mac installer Welcome and ReadMe files for 3.7.0a1
Ned Deily [Tue, 19 Sep 2017 02:22:00 +0000 (22:22 -0400)]
Update Mac installer Welcome and ReadMe files for 3.7.0a1

7 years agoTrivial cleanups following bpo-31370 (#3649)
Antoine Pitrou [Mon, 18 Sep 2017 21:50:44 +0000 (23:50 +0200)]
Trivial cleanups following bpo-31370 (#3649)

* Trivial cleanups following bpo-31370

* Also cleanup the "importlib._bootstrap_external" module

7 years agoRestore dummy_threading and _dummy_thread, but deprecate them (bpo-31370) (#3648)
Antoine Pitrou [Mon, 18 Sep 2017 20:04:20 +0000 (22:04 +0200)]
Restore dummy_threading and _dummy_thread, but deprecate them (bpo-31370) (#3648)

7 years agoos.test_utime_current(): tolerate 50 ms delta (#3646)
Victor Stinner [Mon, 18 Sep 2017 15:49:45 +0000 (08:49 -0700)]
os.test_utime_current(): tolerate 50 ms delta (#3646)

7 years agobpo-31499, xml.etree: Fix xmlparser_gc_clear() crash (#3641)
Victor Stinner [Mon, 18 Sep 2017 12:29:37 +0000 (05:29 -0700)]
bpo-31499, xml.etree: Fix xmlparser_gc_clear() crash (#3641)

* bpo-31499, xml.etree: Fix xmlparser_gc_clear() crash

xml.etree: xmlparser_gc_clear() now sets self.parser to NULL to prevent a
crash in xmlparser_dealloc() if xmlparser_gc_clear() was called previously
by the garbage collector, because the parser was part of a reference cycle.

Co-Authored-By: Serhiy Storchaka <storchaka@gmail.com>
7 years agobpo-31501: Operator precedence description for arithmetic operators (#3633)
svelankar [Mon, 18 Sep 2017 00:56:16 +0000 (20:56 -0400)]
bpo-31501: Operator precedence  description  for arithmetic operators (#3633)

7 years agobpo-30928: Update idlelib/NEWS.txt to 2017 Sep 17. (#3635)
Terry Jan Reedy [Mon, 18 Sep 2017 00:14:21 +0000 (20:14 -0400)]
bpo-30928: Update idlelib/NEWS.txt to 2017 Sep 17. (#3635)

7 years agobpo-31502: IDLE Configdialog again deletes custom themes and keysets. (#3634)
Terry Jan Reedy [Mon, 18 Sep 2017 00:13:25 +0000 (20:13 -0400)]
bpo-31502: IDLE Configdialog again deletes custom themes and keysets. (#3634)

This reverses a never-released regression resulting from bpo-31287.

7 years agobpo-31497: Add private helper _PyType_Name(). (#3630)
Serhiy Storchaka [Sun, 17 Sep 2017 18:11:04 +0000 (21:11 +0300)]
bpo-31497: Add private helper _PyType_Name(). (#3630)

This function returns the last component of tp_name after a dot.
Returns tp_name itself if it doesn't contain a dot.

7 years agobpo-31482: Missing bytes support for random.seed() version 1 (#3614)
Raymond Hettinger [Sun, 17 Sep 2017 16:04:30 +0000 (09:04 -0700)]
bpo-31482:  Missing bytes support for random.seed() version 1 (#3614)

bpo-31482: Missing bytes support for random.seed() version 1 #3614

7 years agobpo-31487: Update F-strings doc example (GH-3627)
Mariatta [Sun, 17 Sep 2017 14:43:31 +0000 (07:43 -0700)]
bpo-31487: Update F-strings doc example (GH-3627)

Shorten the comment to: "using integer format specifier"

7 years agobpo-31490: Fix an assertion failure in ctypes in case an _anonymous_ attr is defined...
Oren Milman [Sun, 17 Sep 2017 10:45:38 +0000 (13:45 +0300)]
bpo-31490: Fix an assertion failure in ctypes in case an _anonymous_ attr is defined only outside _fields_. (#3615)

7 years agobpo-31493: Fix code context update and font update timers. (#3622)
Terry Jan Reedy [Sun, 17 Sep 2017 04:56:56 +0000 (00:56 -0400)]
bpo-31493: Fix code context update and font update timers. (#3622)

Canceling timers prevents a warning message when test_idle completes.
(This is the minimum fix needed before upcoming releases.)

7 years agoImprove f-strings documentation (GH-3604)
Mariatta [Sat, 16 Sep 2017 18:46:43 +0000 (11:46 -0700)]
Improve f-strings documentation (GH-3604)

Provide additional examples of using format specifiers in f-strings
Added examples for using integer and date format specifiers.

7 years agobpo-31458: Clarify that Changelog is built from Misc/NEWS.d directory (GH-3617)
Mariatta [Sat, 16 Sep 2017 17:43:30 +0000 (10:43 -0700)]
bpo-31458: Clarify that Changelog is built from Misc/NEWS.d directory (GH-3617)

7 years agobpo-31488: IDLE - update former extensions when options change. (#3612)
Terry Jan Reedy [Sat, 16 Sep 2017 05:42:28 +0000 (01:42 -0400)]
bpo-31488: IDLE - update former extensions when options change. (#3612)

When apply changes, call .reload on each class with non-key options.
Change ParenMatch so that updates affect current instances.

7 years agobpo-28411: Support other mappings in PyInterpreterState.modules. (#3593)
Eric Snow [Fri, 15 Sep 2017 22:35:20 +0000 (16:35 -0600)]
bpo-28411: Support other mappings in PyInterpreterState.modules. (#3593)

The concrete PyDict_* API is used to interact with PyInterpreterState.modules in a number of places. This isn't compatible with all dict subclasses, nor with other Mapping implementations. This patch switches the concrete API usage to the corresponding abstract API calls.

We also add a PyImport_GetModule() function (and some other helpers) to reduce a bunch of code duplication.

7 years agobpo-31431: SSLContext.check_hostname auto-sets CERT_REQUIRED (#3531)
Christian Heimes [Fri, 15 Sep 2017 18:29:57 +0000 (20:29 +0200)]
bpo-31431: SSLContext.check_hostname auto-sets CERT_REQUIRED (#3531)

Signed-off-by: Christian Heimes <christian@python.org>
7 years agobpo-31346: Use PROTOCOL_TLS_CLIENT/SERVER (#3058)
Christian Heimes [Fri, 15 Sep 2017 18:27:30 +0000 (20:27 +0200)]
bpo-31346: Use PROTOCOL_TLS_CLIENT/SERVER (#3058)

Replaces PROTOCOL_TLSv* and PROTOCOL_SSLv23 with PROTOCOL_TLS_CLIENT and
PROTOCOL_TLS_SERVER.

Signed-off-by: Christian Heimes <christian@python.org>
7 years agobpo-31386: Custom wrap_bio and wrap_socket type (#3426)
Christian Heimes [Fri, 15 Sep 2017 18:26:05 +0000 (20:26 +0200)]
bpo-31386: Custom wrap_bio and wrap_socket type (#3426)

SSLSocket.wrap_bio() and SSLSocket.wrap_socket() hard-code SSLObject and
SSLSocket as return types. In the light of future deprecation of
ssl.wrap_socket() module function and direct instantiation of SSLSocket,
it is desirable to make the return type of SSLSocket.wrap_bio() and
SSLSocket.wrap_socket() customizable.

Signed-off-by: Christian Heimes <christian@python.org>
7 years ago bpo-314777: IDLE - improve rstrip entry in doc (#3602)
Terry Jan Reedy [Fri, 15 Sep 2017 17:05:28 +0000 (13:05 -0400)]
 bpo-314777: IDLE - improve rstrip entry in doc (#3602)

'Strip trailing whitespace' is not limited to spaces.  Wording caters to beginners who
do know know the meaning of 'whitespace'.  Multiline string literals are not skipped.

* News blurb.

7 years agoFix description in Python 3.7 What's New (#3603)
Paul Romano [Fri, 15 Sep 2017 17:00:57 +0000 (12:00 -0500)]
Fix description in Python 3.7 What's New (#3603)

7 years agobpo-29916: Include PyGetSetDef in C API extension documentation. (#831)
Michael Seifert [Fri, 15 Sep 2017 16:25:27 +0000 (18:25 +0200)]
bpo-29916: Include PyGetSetDef in C API extension documentation. (#831)

7 years agobpo-31234: test_multiprocessing: wait 30 seconds (#3599)
Victor Stinner [Fri, 15 Sep 2017 13:55:31 +0000 (06:55 -0700)]
bpo-31234: test_multiprocessing: wait 30 seconds (#3599)

Give 30 seconds to join_process(), instead of 5 or 10 seconds, to
wait until the process completes.

7 years agobpo-31234: Join timers in test_threading (#3598)
Victor Stinner [Fri, 15 Sep 2017 12:37:42 +0000 (05:37 -0700)]
bpo-31234: Join timers in test_threading (#3598)

Call the .join() method of threading.Timer timers to prevent the
"threading_cleanup() failed to cleanup 1 threads" warning.

7 years agobpo-31464: asdl_c.py no longer emits trailing spaces in Python-ast.h. (#3568)
Serhiy Storchaka [Fri, 15 Sep 2017 03:28:22 +0000 (06:28 +0300)]
bpo-31464: asdl_c.py no longer emits trailing spaces in Python-ast.h. (#3568)

7 years agobpo-31338 (#3374)
Barry Warsaw [Fri, 15 Sep 2017 01:13:16 +0000 (18:13 -0700)]
bpo-31338 (#3374)

* Add Py_UNREACHABLE() as an alias to abort().
* Use Py_UNREACHABLE() instead of assert(0)
* Convert more unreachable code to use Py_UNREACHABLE()
* Document Py_UNREACHABLE() and a few other macros.

7 years agobpo-31480: IDLE - fix tests to pass with zzdummy extension disabled. (#3590)
Terry Jan Reedy [Thu, 14 Sep 2017 22:51:51 +0000 (18:51 -0400)]
bpo-31480: IDLE - fix tests to pass with zzdummy extension disabled. (#3590)

Enabled by default was a temporary expedient.  The fix is to add a user override to enable.

7 years agobpo-31128: Allow pydoc to bind to arbitrary hostnames (#3011)
Feanil Patel [Thu, 14 Sep 2017 21:54:09 +0000 (17:54 -0400)]
bpo-31128: Allow pydoc to bind to arbitrary hostnames (#3011)

New -n flag allow overriding localhost with custom value,
for example to run from containers.

7 years agobpo-30860: Fix deadcode in obmalloc.c (#3499)
Victor Stinner [Thu, 14 Sep 2017 21:48:37 +0000 (14:48 -0700)]
bpo-30860: Fix deadcode in obmalloc.c (#3499)

Fix Coverity CID 1417587: _PyMem_Initialize() contains code which is
never executed.

Replace the runtime check with a build assertion.

7 years agobpo-31234: Add support.join_thread() helper (#3587)
Victor Stinner [Thu, 14 Sep 2017 21:40:56 +0000 (14:40 -0700)]
bpo-31234: Add support.join_thread() helper (#3587)

join_thread() joins a thread but raises an AssertionError if the
thread is still alive after timeout seconds.

7 years agobpo-31234: Join threads in test_queue (#3586)
Victor Stinner [Thu, 14 Sep 2017 21:04:56 +0000 (14:04 -0700)]
bpo-31234: Join threads in test_queue (#3586)

Call thread.join() to prevent the "dangling thread" warning.

7 years agobpo-31234: Add test.support.wait_threads_exit() (#3578)
Victor Stinner [Thu, 14 Sep 2017 20:07:24 +0000 (13:07 -0700)]
bpo-31234: Add test.support.wait_threads_exit() (#3578)

Use _thread.count() to wait until threads exit. The new context
manager prevents the "dangling thread" warning.

7 years agobpo-31234: Join threads in test_threading (#3579)
Victor Stinner [Thu, 14 Sep 2017 20:05:21 +0000 (13:05 -0700)]
bpo-31234: Join threads in test_threading (#3579)

Call thread.join() to prevent the "dangling thread" warning.

7 years agobpo-31455: Fix an assertion failure in ElementTree.XMLParser(). (#3545)
scoder [Thu, 14 Sep 2017 20:00:03 +0000 (22:00 +0200)]
bpo-31455: Fix an assertion failure in ElementTree.XMLParser(). (#3545)

* Avoid calling "PyObject_GetAttrString()" (and potentially executing user code) with a live exception set.

* Ignore only AttributeError on attribute lookups in ElementTree.XMLParser() and propagate all other exceptions.

7 years agobpo-31471: Fix assertion failure in subprocess.Popen() on Windows, in case env has...
Oren Milman [Thu, 14 Sep 2017 19:30:28 +0000 (22:30 +0300)]
bpo-31471: Fix assertion failure in subprocess.Popen() on Windows, in case env has a bad keys() method. (#3580)

7 years agobpo-28556: typing.get_type_hints: better globalns for classes and modules (#3582)
Łukasz Langa [Thu, 14 Sep 2017 18:33:00 +0000 (14:33 -0400)]
bpo-28556: typing.get_type_hints: better globalns for classes and modules (#3582)

This makes the default behavior (without specifying `globalns` manually) more
predictable for users, finds the right globalns automatically.

Implementation for classes assumes has a `__module__` attribute and that module
is present in `sys.modules`.  It does this recursively for all bases in the
MRO.  For modules, the implementation just uses their `__dict__` directly.

This is backwards compatible, will just raise fewer exceptions in naive user
code.

Originally implemented and reviewed at https://github.com/python/typing/pull/470.

7 years agobpo-28411: Isolate PyInterpreterState.modules (#3575)
Eric Snow [Thu, 14 Sep 2017 18:18:12 +0000 (12:18 -0600)]
bpo-28411: Isolate PyInterpreterState.modules (#3575)

A bunch of code currently uses PyInterpreterState.modules directly instead of PyImport_GetModuleDict(). This complicates efforts to make changes relative to sys.modules. This patch switches to using PyImport_GetModuleDict() uniformly. Also, a number of related uses of sys.modules are updated for uniformity for the same reason.

Note that this code was already reviewed and merged as part of #1638. I reverted that and am now splitting it up into more focused parts.

7 years agobpo-31234: Join threads in test_hashlib (#3573)
Victor Stinner [Thu, 14 Sep 2017 15:43:22 +0000 (08:43 -0700)]
bpo-31234: Join threads in test_hashlib (#3573)

* bpo-31234: Join threads in test_hashlib

Use thread.join() to wait until the parallel hash tasks complete
rather than using events. Calling thread.join() prevent "dangling
thread" warnings.

* test_hashlib: minor PEP 8 coding style fixes

7 years agobpo-31234: Join threads in tests (#3572)
Victor Stinner [Thu, 14 Sep 2017 15:43:04 +0000 (08:43 -0700)]
bpo-31234: Join threads in tests (#3572)

Call thread.join() on threads to prevent the "dangling threads"
warning.

7 years agobpo-31457: Allow for nested LoggerAdapter objects (#3551)
Łukasz Langa [Thu, 14 Sep 2017 15:34:47 +0000 (11:34 -0400)]
bpo-31457: Allow for nested LoggerAdapter objects (#3551)

Some of the proxied methods use internal Logger state which isn't proxied,
causing failures if an adapter is applied to another adapter.

This commit fixes the issue, adds a new test for the use case.

7 years ago_ssl_: Fix compiler warning (#3559)
Victor Stinner [Thu, 14 Sep 2017 08:10:30 +0000 (01:10 -0700)]
_ssl_: Fix compiler warning (#3559)

Cast Py_buffer.len (Py_ssize_t, signed) to size_t (unsigned) to
prevent the following warning:

Modules/_ssl.c:3089:21: warning: comparison between signed and
unsigned integer expressions [-Wsign-compare]

7 years agobpo-30860: Fix a refleak. (#3567)
Eric Snow [Thu, 14 Sep 2017 07:35:58 +0000 (00:35 -0700)]
bpo-30860: Fix a refleak. (#3567)

Resolves bpo-31420.

(This was accidentally reverted when in #3565.)

7 years agobpo-31404: Revert "remove modules from Py_InterpreterState (#1638)" (#3565)
Eric Snow [Thu, 14 Sep 2017 06:46:04 +0000 (23:46 -0700)]
bpo-31404: Revert "remove modules from Py_InterpreterState (#1638)" (#3565)

PR #1638, for bpo-28411, causes problems in some (very) edge cases. Until that gets sorted out, we're reverting the merge. PR #3506, a fix on top of #1638, is also getting reverted.

7 years agobpo-31462: Remove trailing whitespaces. (#3564)
Serhiy Storchaka [Thu, 14 Sep 2017 06:38:36 +0000 (09:38 +0300)]
bpo-31462: Remove trailing whitespaces. (#3564)

7 years agoImprove code examples in hashlib cookie signing (GH-3562)
sww [Thu, 14 Sep 2017 06:24:36 +0000 (23:24 -0700)]
Improve code examples in hashlib cookie signing (GH-3562)

The `blake2b` function does not take the `data` keyword argument.
The hex digest returned by sign was a string, whereas compare_digest expects bytes-like objects.
Typo fix: compare_digesty -> compare_digest

7 years agobpo-30246: fix several error messages which only mention bytes in struct (#1421)
Xiang Zhang [Thu, 14 Sep 2017 02:33:26 +0000 (10:33 +0800)]
bpo-30246: fix several error messages which only mention bytes in struct (#1421)

7 years agobpo-31458: Update Misc/NEWS link in What's New page (GH-3555)
Mariatta [Wed, 13 Sep 2017 23:47:33 +0000 (16:47 -0700)]
bpo-31458: Update Misc/NEWS link in What's New page (GH-3555)

Update the link from Misc/NEWS to Misc/NEWS.d

7 years agobpo-31234: Try to fix lock_tests warning (#3557)
Victor Stinner [Wed, 13 Sep 2017 23:41:08 +0000 (16:41 -0700)]
bpo-31234: Try to fix lock_tests warning (#3557)

Try to fix the "Warning -- threading_cleanup() failed to cleanup 1
threads" warning in test.lock_tests: wait a little bit longer to give
time to the threads to complete.

Warning seen on test_thread and test_importlib.

7 years agobpo-28556: Minor updates to typing module (#3550)
Ivan Levkivskyi [Wed, 13 Sep 2017 23:25:15 +0000 (01:25 +0200)]
bpo-28556: Minor updates to typing module (#3550)

* Copy changes to typing from upstream repo
* Add NEWS entry

7 years agobpo-31418: Fix an assertion failure in PyErr_WriteUnraisable() in case of an exceptio...
Oren Milman [Wed, 13 Sep 2017 22:30:05 +0000 (01:30 +0300)]
bpo-31418: Fix an assertion failure in PyErr_WriteUnraisable() in case of an exception with a bad __module__ attribute. (#3539)

7 years agobpo-31234: threading_cleanup() now warns immediately (#3138)
Victor Stinner [Wed, 13 Sep 2017 20:42:00 +0000 (13:42 -0700)]
bpo-31234: threading_cleanup() now warns immediately (#3138)

support.threading_cleanup() waits for 1 second before emitting a
warning if there are threads running in the background. With this
change, it now emits the warning immediately, to be able to catch
bugs more easily.

7 years agoUpdate subprocess.communicate() docstring.
Joel Schaerer [Wed, 13 Sep 2017 19:11:20 +0000 (21:11 +0200)]
Update subprocess.communicate() docstring.

Explicitly state that communicate() closes stdin after writing input to it.

7 years agobpo-31234, socket.create_connection(): Fix ref cycle (#3546)
Victor Stinner [Wed, 13 Sep 2017 17:10:10 +0000 (10:10 -0700)]
bpo-31234, socket.create_connection(): Fix ref cycle (#3546)

7 years agobpo-31234: Fix dangling thread in test_ftplib (#3544)
Victor Stinner [Wed, 13 Sep 2017 13:43:58 +0000 (06:43 -0700)]
bpo-31234: Fix dangling thread in test_ftplib (#3544)

Clear also self.server_thread attribute in TestTimeouts.tearDown().

7 years agobpo-31448, test_poplib: Fix ResourceWarning (#3542)
Victor Stinner [Wed, 13 Sep 2017 12:53:10 +0000 (05:53 -0700)]
bpo-31448, test_poplib: Fix ResourceWarning (#3542)

Call POP3.close(), don't close close directly the sock attribute.

7 years agoTravis CI: run coverage test using --fail-env-changed (#3541)
Victor Stinner [Wed, 13 Sep 2017 12:17:27 +0000 (05:17 -0700)]
Travis CI: run coverage test using --fail-env-changed (#3541)

7 years agobpo-31234: Fix dangling thread in test_ftp/poplib (#3540)
Victor Stinner [Wed, 13 Sep 2017 10:58:25 +0000 (03:58 -0700)]
bpo-31234: Fix dangling thread in test_ftp/poplib (#3540)

Explicitly clear the server attribute in test_ftplib and test_poplib
to prevent dangling thread.

7 years agobpo-31233: socketserver.ThreadingMixIn.server_close() (#3523)
Victor Stinner [Wed, 13 Sep 2017 08:47:22 +0000 (01:47 -0700)]
bpo-31233: socketserver.ThreadingMixIn.server_close() (#3523)

socketserver.ThreadingMixIn now keeps a list of non-daemonic threads
to wait until all these threads complete in server_close().

Reenable test_logging skipped tests.

Fix SocketHandlerTest.tearDown(): close the socket handler before
stopping the server, so the server can join threads.

7 years agobpo-30830: logging.config.listen() calls server_close() (#3524)
Victor Stinner [Wed, 13 Sep 2017 08:44:08 +0000 (01:44 -0700)]
bpo-30830: logging.config.listen() calls server_close() (#3524)

The ConfigSocketReceiver.serve_until_stopped() method from
logging.config.listen() now calls server_close() (of
socketserver.ThreadingTCPServer) rather than closing manually the
socket.

While this change has no effect yet, it will help to prevent dangling
threads once ThreadingTCPServer.server_close() will join spawned
threads (bpo-31233).

7 years agoMention enum as an ex (#2982)
Louie Lu [Wed, 13 Sep 2017 04:44:14 +0000 (12:44 +0800)]
Mention enum as an ex (#2982)

7 years agobpo-31394: Make tokenize.rst PEP 8-compliant (GH-3526)
Mariatta [Wed, 13 Sep 2017 04:00:00 +0000 (21:00 -0700)]
bpo-31394: Make tokenize.rst PEP 8-compliant (GH-3526)

The last commit contained lines longer than 80 characters.

7 years agobpo-31394: Clarify documentation about token type attribute (GH-3469)
Aivar Annamaa [Wed, 13 Sep 2017 03:24:03 +0000 (06:24 +0300)]
bpo-31394: Clarify documentation about token type attribute (GH-3469)

Make it clear that Ellipsis tokens also have type attribute set to token.OP.

7 years agobpo-31249: Fix test_concurrent_futures dangling thread (#3521)
Victor Stinner [Wed, 13 Sep 2017 00:05:53 +0000 (17:05 -0700)]
bpo-31249: Fix test_concurrent_futures dangling thread (#3521)

ProcessPoolShutdownTest.test_del_shutdown() now closes the call queue
and joins its thread, to prevent leaking a dangling thread.

7 years agobpo-31234: Enhance test_thread.test_forkinthread() (#3516)
Victor Stinner [Tue, 12 Sep 2017 17:49:22 +0000 (10:49 -0700)]
bpo-31234: Enhance test_thread.test_forkinthread() (#3516)

* test_thread.test_forkinthread() now waits until the thread completes.
* Check the status in the test method, not in the thread function
* Don't ignore RuntimeError anymore: since the commit
  346cbd351ee0dd3ab9cb9f0e4cb625556707877e (bpo-16500,
  os.register_at_fork(), os.fork() cannot fail anymore with
  RuntimeError.
* Replace 0.01 literal with a new POLL_SLEEP constant
* test_forkinthread(): test if os.fork() exists rather than testing
  the platform.

7 years agobpo-31428: Prevent raising a SystemError in case the memo arg of ElementTree.Element...
Oren Milman [Tue, 12 Sep 2017 14:39:15 +0000 (17:39 +0300)]
bpo-31428: Prevent raising a SystemError in case the memo arg of ElementTree.Element.__deepcopy__() isn't a dictionary. (#3512)

7 years agobpo-31421: Document how IDLE runs tkinter programs. (#3513)
Terry Jan Reedy [Tue, 12 Sep 2017 13:05:16 +0000 (09:05 -0400)]
bpo-31421: Document how IDLE runs tkinter programs. (#3513)

IDLE calls tcl/tk update in the background in order to make live
interaction and experimentatin with tkinter applications much easier.

7 years agobpo-27099: Finish updating IDLE doc and help text. (#3510)
Terry Jan Reedy [Tue, 12 Sep 2017 11:45:15 +0000 (07:45 -0400)]
bpo-27099: Finish updating IDLE doc and help text. (#3510)

As needed for the conversion of extensions to features.

7 years agobpo-30860: Move windows.h include out of internal/*.h. (#3458)
Eric Snow [Tue, 12 Sep 2017 01:30:43 +0000 (18:30 -0700)]
bpo-30860: Move windows.h include out of internal/*.h. (#3458)

PR #3397 introduced a large number of warnings to the Windows build. This patch fixes them.

7 years agobpo-30860: Fix a refleak. (#3506)
Eric Snow [Tue, 12 Sep 2017 00:59:22 +0000 (17:59 -0700)]
bpo-30860: Fix a refleak. (#3506)

* Drop warnoptions from PyInterpreterState.

* Drop xoptions from PyInterpreterState.

* Don't set warnoptions and _xoptions again.

* Decref after adding to sys.__dict__.

* Drop an unused macro.

* Check sys.xoptions *before* we delete it.

7 years agobpo-30860: Always provide serialno. (#3507)
Eric Snow [Tue, 12 Sep 2017 00:02:24 +0000 (17:02 -0700)]
bpo-30860: Always provide serialno. (#3507)

This fixes bpo-31407.

7 years agobpo-31416: Fix assertion failures in case of a bad warnings.filters or warnings.defau...
Oren Milman [Mon, 11 Sep 2017 21:18:09 +0000 (00:18 +0300)]
bpo-31416: Fix assertion failures in case of a bad warnings.filters or warnings.defaultaction. (#3496)

Patch by Oren Milman.

7 years agobpo-30928: Update idlelib/NEWS.txt to 2017-09-11. (#3503)
Terry Jan Reedy [Mon, 11 Sep 2017 20:43:26 +0000 (16:43 -0400)]
bpo-30928: Update idlelib/NEWS.txt to 2017-09-11. (#3503)

7 years agobpo-31414: IDLE -- fix tk entry box tests by deleting first. (#3501)
Terry Jan Reedy [Mon, 11 Sep 2017 20:02:33 +0000 (16:02 -0400)]
bpo-31414: IDLE -- fix tk entry box tests by deleting first. (#3501)

Adding to an int entry is not the same as deleting and inserting
because int('') will fail.

7 years agobpo-30860: Add Include/internal/ in "make tags" (#3498)
Victor Stinner [Mon, 11 Sep 2017 16:34:36 +0000 (09:34 -0700)]
bpo-30860: Add Include/internal/ in "make tags" (#3498)

7 years agotest_ssl: Implement timeout in ssl_io_loop() (#3500)
Victor Stinner [Mon, 11 Sep 2017 16:34:24 +0000 (09:34 -0700)]
test_ssl: Implement timeout in ssl_io_loop() (#3500)

The timeout parameter was not used.

7 years agoRemove a null statement that was necessary for --without-threads (#3478)
Zackery Spytz [Mon, 11 Sep 2017 10:37:10 +0000 (04:37 -0600)]
Remove a null statement that was necessary for --without-threads (#3478)

7 years agobpo-31373: remove overly strict float range checks (#3486)
Benjamin Peterson [Mon, 11 Sep 2017 06:50:46 +0000 (23:50 -0700)]
bpo-31373: remove overly strict float range checks (#3486)

This undoes a853a8ba7850381d49b284295dd6f0dc491dbe44 except for the pytime.c
parts. We want to continue to allow IEEE 754 doubles larger than FLT_MAX to be
rounded into finite floats. Tests were added to very this behavior.

7 years agobpo-31411: Prevent raising a SystemError in case warnings.onceregistry is not a dicti...
Oren Milman [Mon, 11 Sep 2017 06:28:39 +0000 (09:28 +0300)]
bpo-31411: Prevent raising a SystemError in case warnings.onceregistry is not a dictionary. (#3485)

7 years agobpo-30781: IDLE: Fix help button on configdialog (#3238)
Cheryl Sabella [Mon, 11 Sep 2017 02:41:10 +0000 (22:41 -0400)]
bpo-30781: IDLE: Fix help button on configdialog (#3238)

This fixes an omission in the ttk conversion patch for this issue, hence no new news.
Patch by Cheryl Sabella.

7 years agobpo-27099: IDLE - Convert built-in extensions to regular features (#2494)
wohlganger [Sun, 10 Sep 2017 21:19:47 +0000 (16:19 -0500)]
bpo-27099: IDLE - Convert built-in extensions to regular features (#2494)

About 10 IDLE features were implemented as supposedly optional
extensions.  Their different behavior could be confusing or worse for
users and not good for maintenance.  Hence the conversion.

The main difference for users is that user configurable key bindings
for builtin features are now handled uniformly.  Now, editing a binding
in a keyset only affects its value in the keyset.  All bindings are
defined together in the system-specific default keysets in config-
extensions.def.  All custom keysets are saved as a whole in config-
extension.cfg.  All take effect as soon as one clicks Apply or Ok.

The affected events are '<<force-open-completions>>', '<<expand-word>>',
'<<force-open-calltip>>', '<<flash-paren>>', '<<format-paragraph>>',
'<<run-module>>', '<<check-module>>', and '<<zoom-height>>'.  Any
(global) customizations made before 3.6.3 will not affect their keyset-
specific customization after 3.6.3. and vice versa.

Inital patch by Charles Wohlganger, revised by Terry Jan Reedy.

7 years agoSimplify run_tests.py (#3482)
Antoine Pitrou [Sun, 10 Sep 2017 18:32:13 +0000 (20:32 +0200)]
Simplify run_tests.py (#3482)