]>
granicus.if.org Git - graphviz/log
Matthew Fernandez [Sat, 26 Jun 2021 02:26:48 +0000 (02:26 +0000)]
Merge branch 'smattr/
4776D4AA -9B85-4010-BF10-
ED5243311BE9 ' into 'main'
clean up in lib/cgraph/io.c
See merge request graphviz/graphviz!2012
Mark Hansen [Sat, 26 Jun 2021 01:17:46 +0000 (01:17 +0000)]
Update CHANGELOG.md
For https://gitlab.com/graphviz/graphviz/-/merge_requests/2017
Mark Hansen [Sat, 26 Jun 2021 01:00:54 +0000 (01:00 +0000)]
Merge branch 'fix-path-of-gvc.def' into 'main'
Fix a path of gvc.def specified in libgvc_la_LDFLAGS (WITH_WIN32)
See merge request graphviz/graphviz!2017
Lemures Lemniscati [Sat, 26 Jun 2021 00:20:02 +0000 (09:20 +0900)]
Fix a path of gvc.def specified in libgvc_la_LDFLAGS (WITH_WIN32)
Matthew Fernandez [Tue, 22 Jun 2021 04:08:33 +0000 (21:08 -0700)]
remove some unnecessary bracketing in memiofread
Matthew Fernandez [Tue, 22 Jun 2021 04:06:41 +0000 (21:06 -0700)]
remove unnecessary cast in memiofread
A void* implicitly coerces to an rdr_t*.
Matthew Fernandez [Tue, 22 Jun 2021 04:05:58 +0000 (21:05 -0700)]
remove unnecessary cast in ioflush
The function fflush takes a FILE* to which void* implicitly coerces.
Matthew Fernandez [Tue, 22 Jun 2021 04:05:18 +0000 (21:05 -0700)]
remove unnecessary cast in ioputstr
The function fputs takes a FILE* as its second argument, to which void*
implicitly coerces.
Matthew Fernandez [Tue, 22 Jun 2021 04:03:49 +0000 (21:03 -0700)]
squash a -Wsign-conversion warning in iofread
The preceding call to fgets can only have returned at most bufsize - 1
characters, so it is safe to downcast the size_t result of strlen to an int.
Matthew Fernandez [Tue, 22 Jun 2021 04:03:05 +0000 (21:03 -0700)]
remove unnecessary cast in iofread
The function fgets takes a FILE* as its third argument, to which void*
implicitly coerces.
Matthew Fernandez [Fri, 25 Jun 2021 15:27:28 +0000 (15:27 +0000)]
Merge branch 'smattr/
5a012c5d -e9c4-4395-97b1-
ef472d03fc83 ' into 'main'
clean up in cmd/gvmap
See merge request graphviz/graphviz!2014
Matthew Fernandez [Wed, 23 Jun 2021 01:33:15 +0000 (18:33 -0700)]
fix some comment typos
Matthew Fernandez [Wed, 23 Jun 2021 01:32:22 +0000 (18:32 -0700)]
remove some unnecessary bracketing
Matthew Fernandez [Wed, 23 Jun 2021 01:13:42 +0000 (18:13 -0700)]
remove dynamic allocation capability of power_method for eigs
The behavior to dynamically allocate memory for eigs was not documented (unlike
the parameter eigv). However, the only caller was not using this anyway. This
commit removes it to ease ongoing maintenance.
Matthew Fernandez [Wed, 23 Jun 2021 01:05:08 +0000 (18:05 -0700)]
inline tol and maxit from power_method into power.c as constants
The function power_method is only called in a single location. There it is
called with constants for tol and maxit. So it is simpler to remove these as
parameters and just specify them directly next to power_method.
Matthew Fernandez [Wed, 23 Jun 2021 00:54:23 +0000 (17:54 -0700)]
remove now-unused improve_antibandwidth_by_swapping_cheap
Matthew Fernandez [Wed, 23 Jun 2021 00:44:47 +0000 (17:44 -0700)]
remove unnecessary do_swapping parameter to country_graph_coloring_internal
This function is only ever called with do_swapping == DO_SWAPPING.
Matthew Fernandez [Wed, 23 Jun 2021 00:40:13 +0000 (17:40 -0700)]
remove an open coded NULL in cluster.c
Matthew Fernandez [Wed, 23 Jun 2021 00:37:49 +0000 (17:37 -0700)]
make cluster usage string a constant array
Minor clarity change that makes it more obvious to readers and the compiler that
this string is a constant that can be inlined at its usage site.
Matthew Fernandez [Wed, 23 Jun 2021 00:35:28 +0000 (17:35 -0700)]
gvmap: uniformly treat clock() results as clock_t or double
The return type of clock(), clock_t, is an unspecified real type. The usual way
to deal with it is to upcast it to a double when doing computation or printing,
as is done in this commit. Squashes 8 -Wconversion warnings.
Matthew Fernandez [Wed, 23 Jun 2021 00:25:02 +0000 (17:25 -0700)]
remove a useless return statement
Matthew Fernandez [Wed, 23 Jun 2021 00:24:23 +0000 (17:24 -0700)]
mark clusterGraph as static
This function is not used outside of its containing file.
Matthew Fernandez [Fri, 25 Jun 2021 14:38:02 +0000 (14:38 +0000)]
Merge branch 'smattr/
4BAD66AE -4F6D-4F40-96A2-
755E25EF6F5A ' into 'main'
some clean up of lib/sparse/general.c
See merge request graphviz/graphviz!2015
Matthew Fernandez [Wed, 23 Jun 2021 03:48:06 +0000 (20:48 -0700)]
remove unused vector_take
Matthew Fernandez [Wed, 23 Jun 2021 03:47:10 +0000 (20:47 -0700)]
remove unused validQ_int_string
Matthew Fernandez [Wed, 23 Jun 2021 03:46:38 +0000 (20:46 -0700)]
remove unused digitsQ
Matthew Fernandez [Wed, 23 Jun 2021 03:45:08 +0000 (20:45 -0700)]
remove unused excute_system_command3
Similar to the previous commit, this function seems to have a typoed name and
unsafe behavior.
Matthew Fernandez [Wed, 23 Jun 2021 03:44:10 +0000 (20:44 -0700)]
remove unused excute_system_command
This function appears to have a typo in its name and also do something quite
unsafe.
Matthew Fernandez [Wed, 23 Jun 2021 03:42:44 +0000 (20:42 -0700)]
remove unused vector_percentile
Matthew Fernandez [Wed, 23 Jun 2021 03:41:55 +0000 (20:41 -0700)]
remove unused vector_median
Matthew Fernandez [Wed, 23 Jun 2021 03:39:51 +0000 (20:39 -0700)]
remove ascending parameter to vector_sort_int
The only calls to this uses ascending, so having this configurable was adding
unnecessary maintenance burden.
Matthew Fernandez [Wed, 23 Jun 2021 03:37:20 +0000 (20:37 -0700)]
remove unused vector_sort_real
Matthew Fernandez [Wed, 23 Jun 2021 03:35:33 +0000 (20:35 -0700)]
remove ascending parameter from vector_ordering
All calls to this use ascending, so having this configurable was adding
unnecessary maintenance burden.
Matthew Fernandez [Fri, 25 Jun 2021 05:01:21 +0000 (05:01 +0000)]
Merge branch 'smattr/
1b923de5 -43ac-4445-adfe-
fd9b1512bd2b ' into 'main'
cleanup configure.ac
See merge request graphviz/graphviz!2002
Matthew Fernandez [Sat, 19 Jun 2021 00:07:57 +0000 (17:07 -0700)]
remove legacy advice to build on Fedora 8
Fedora 8 was EOLed in 2009. Compiling Graphviz on it in 2021 is not a journey
likely to end in happiness.
Matthew Fernandez [Sat, 19 Jun 2021 00:07:53 +0000 (17:07 -0700)]
update Graphviz URL in AC_INIT configure setup
This URL was out of date (the current Graphviz URL is https://graphviz.org/),
but the third parameter of AC_INIT is also expected to be the bug tracker, not
the project’s homepage.
Matthew Fernandez [Sat, 19 Jun 2021 00:07:50 +0000 (17:07 -0700)]
remove configure check for strerror
The strerror function is in ISO C, even prior to C99. POSIX defines some
extensions to it, but Graphviz does not rely on any of these. In either case,
there is no need to link against anything beyond libc.
Matthew Fernandez [Sat, 19 Jun 2021 00:07:45 +0000 (17:07 -0700)]
remove commented out Tclsh configure checks
Matthew Fernandez [Sat, 19 Jun 2021 00:07:42 +0000 (17:07 -0700)]
remove commented out D configure checks
Matthew Fernandez [Sat, 19 Jun 2021 00:07:38 +0000 (17:07 -0700)]
remove commented out Go configure checks
Matthew Fernandez [Sat, 19 Jun 2021 00:07:34 +0000 (17:07 -0700)]
remove commented out JavaScript configure checks
Matthew Fernandez [Sat, 19 Jun 2021 00:07:30 +0000 (17:07 -0700)]
remove commented out TCL AC_SUBST configure commands
Matthew Fernandez [Sat, 19 Jun 2021 20:25:23 +0000 (13:25 -0700)]
adjust indentation after prior commit
Matthew Fernandez [Sat, 19 Jun 2021 00:07:26 +0000 (17:07 -0700)]
remove commented out Visio configure checks
Matthew Fernandez [Sat, 19 Jun 2021 00:07:21 +0000 (17:07 -0700)]
remove commented out ANN configure checks
Matthew Fernandez [Sat, 19 Jun 2021 00:07:17 +0000 (17:07 -0700)]
remove GD_GIFANIM configure checks
Nothing in Graphviz depends on this.
Matthew Fernandez [Sat, 19 Jun 2021 00:07:11 +0000 (17:07 -0700)]
remove GD_OPENPOLYGON configure checks
Nothing in Graphviz depends on this.
Matthew Fernandez [Sat, 19 Jun 2021 00:07:05 +0000 (17:07 -0700)]
remove legacy __eprintf dependency check
This check was forcing assertions off if using them depends on __eprintf. It is
unclear to me what the motivation for this is and it was introduced in the
initial revision with no further information. As far as I am aware, this is no
longer relevant. Modern libc is intended to provide everything necessary to
support assert, unless you are building freestanding which Graphviz does not
support.
Matthew Fernandez [Wed, 23 Jun 2021 01:58:37 +0000 (01:58 +0000)]
Merge branch 'smattr/
9ca97a2a -a1dc-4631-9310-
ded139978324 ' into 'main'
clean up in lib/sfdpgen
See merge request graphviz/graphviz!2000
Matthew Fernandez [Thu, 17 Jun 2021 00:54:30 +0000 (17:54 -0700)]
replace lib/sfdpgen header guards with more modern #pragma once
Matthew Fernandez [Thu, 17 Jun 2021 00:54:26 +0000 (17:54 -0700)]
remove unused flag argument to uniform_stress_solve
Matthew Fernandez [Thu, 17 Jun 2021 00:54:23 +0000 (17:54 -0700)]
remove unused flag argument to cg
Matthew Fernandez [Thu, 17 Jun 2021 00:54:19 +0000 (17:54 -0700)]
remove unused flag parameter to conjugate_gradient
Matthew Fernandez [Thu, 17 Jun 2021 00:54:15 +0000 (17:54 -0700)]
remove another pow micro-optimization in spring_electrical.c
A slightly different variant of the instances dealt with in the prior commit.
Matthew Fernandez [Thu, 17 Jun 2021 00:54:10 +0000 (17:54 -0700)]
remove pow micro-optimizations in spring_electrical.c
This code was attempting to optimize the case when the second argument to pow()
was 2. However, modern compilers are able to understand such nuances. In fact,
at -O3 recent Clang *undoes* this branching code into an unconditional call to
pow(). In other words, it considers this branch to multiplication to be a
de-optimization.
This change also incidentally removes 14 -Wfloat-equal warnings.
Matthew Fernandez [Thu, 17 Jun 2021 00:54:06 +0000 (17:54 -0700)]
remove unused jd argument to dmean_get
Matthew Fernandez [Thu, 17 Jun 2021 00:54:02 +0000 (17:54 -0700)]
use a C99 bool array for checked in beautify_leaves
This change not only reduces the heap usage for this function (sizeof(bool) is
typically less than sizeof(int)), but also makes both allocation and
initialization more efficient.
Matthew Fernandez [Thu, 17 Jun 2021 00:53:58 +0000 (17:53 -0700)]
remove sfdp_cleanup_graph no-op function
Squashes a -Wunused-parameter warning.
Matthew Fernandez [Thu, 17 Jun 2021 00:53:55 +0000 (17:53 -0700)]
remove unused parameter from getPos
Matthew Fernandez [Thu, 17 Jun 2021 00:53:47 +0000 (17:53 -0700)]
remove commented out code in lib/sfdpgen
Magnus Jacobsson [Tue, 22 Jun 2021 17:34:40 +0000 (17:34 +0000)]
Merge branch 're-enable-asan-alloc_dealloc_mismatch' into 'main'
Re-enable ASan alloc_dealloc_mismatch
See merge request graphviz/graphviz!2013
Magnus Jacobsson [Tue, 22 Jun 2021 05:36:20 +0000 (07:36 +0200)]
re-enable ASan alloc_dealloc_mismatch
Matthew Fernandez [Sat, 19 Jun 2021 21:15:44 +0000 (21:15 +0000)]
Merge branch 'smattr/
eb82eda7 -a6c0-4c30-ab36-
0ff65dfe02ae ' into 'main'
clean up and math abbreviation in lib/fdpgen
See merge request graphviz/graphviz!2001
Matthew Fernandez [Fri, 18 Jun 2021 01:19:03 +0000 (18:19 -0700)]
abbreviate an open coded fmax in doRep
Matthew Fernandez [Fri, 18 Jun 2021 01:18:21 +0000 (18:18 -0700)]
abbreviate open coded fabs in overlap
Matthew Fernandez [Fri, 18 Jun 2021 01:17:47 +0000 (18:17 -0700)]
abbreviate an open coded fmin in genPorts
Matthew Fernandez [Fri, 18 Jun 2021 01:17:21 +0000 (18:17 -0700)]
abbreviate an open coded fmin in getEdgeList
Matthew Fernandez [Fri, 18 Jun 2021 01:16:35 +0000 (18:16 -0700)]
abbreviate open coded fmax and fmin operations in pswrite
Matthew Fernandez [Fri, 18 Jun 2021 00:45:56 +0000 (17:45 -0700)]
remove some commented out code in lib/fdpgen
Matthew Fernandez [Fri, 18 Jun 2021 01:19:29 +0000 (18:19 -0700)]
replace some open coded hypotenuse calculations in applyAttr with calls to hypot
Similar to the previous commits.
Matthew Fernandez [Fri, 18 Jun 2021 00:56:42 +0000 (17:56 -0700)]
replace an open coded hypotenuse calculation in dist with a call to hypot
Similar to the previous commit.
Matthew Fernandez [Fri, 18 Jun 2021 00:31:55 +0000 (17:31 -0700)]
replace an open coded hypotenuse calculation in RAD with call to hypot
The libc function hypot does the same work, with the potential to be more
accurate and efficient.
Matthew Fernandez [Fri, 18 Jun 2021 00:26:28 +0000 (17:26 -0700)]
remove unused temp argument to cool()
Matthew Fernandez [Fri, 18 Jun 2021 00:18:32 +0000 (17:18 -0700)]
squash -Wunused-parameter warning in newCell
Matthew Fernandez [Sat, 19 Jun 2021 20:09:38 +0000 (20:09 +0000)]
Merge branch 'smattr/
00ec825c -43d9-4855-acac-
066edec7b291 ' into 'main'
more clean up in lib/vpsc
See merge request graphviz/graphviz!1998
Matthew Fernandez [Sat, 12 Jun 2021 20:44:40 +0000 (13:44 -0700)]
replace some manual iterations in Block with range-based for loops
This C++11 syntax does the same thing.
Matthew Fernandez [Sat, 12 Jun 2021 20:34:29 +0000 (13:34 -0700)]
avoid manual memory management of PairingHeap pointers in Block
Not only does this free us from having to think about allocation tracking and
memory leaks, because Block does not participate in any inheritance hierarchy we
can also remove its explicit destructor.
Matthew Fernandez [Sat, 12 Jun 2021 20:28:47 +0000 (13:28 -0700)]
replace forward declaration of PairingHeap with include of its header
There is no need to play these forward declaration tricks in this scenario.
Circular dependencies are not involved.
Matthew Fernandez [Sat, 12 Jun 2021 20:14:01 +0000 (13:14 -0700)]
mark Block as an uncopyable object
Objects of type Block were already unsafe to copy (or move). The class contains
raw pointers that are deleted in the destructor. So any attempt to copy an
object of this type would have eventually caused a use-after-free and/or a
double free. This change makes the situation more explicit by teaching the
compiler it is unsafe to copy or move objects of this type. If there is code that
implicitly does this, it will now be rejected at compile time.
Matthew Fernandez [Sat, 12 Jun 2021 20:09:26 +0000 (13:09 -0700)]
make Block::vars a value, not a pointer
This is simpler for both humans and the compiler, and we do not need to worry
about tracking memory allocation.
Matthew Fernandez [Sat, 12 Jun 2021 20:01:07 +0000 (13:01 -0700)]
replace manual iterations over Block::vars with range-based for loops
This syntax from C++11 is equivalent to the old style iterations it is replacing
here.
Matthew Fernandez [Sat, 12 Jun 2021 19:49:18 +0000 (12:49 -0700)]
remove unnecessary temporary vector in Blocks::cleanup
This code was taking a copy of every element in a set in order to iterate
through them while removing elements from the underlying set. However, this is
not necessary. This change replaces this code with the standard pattern for
deleting elements while iterating over a set.
Matthew Fernandez [Sat, 12 Jun 2021 19:36:31 +0000 (12:36 -0700)]
return a value instead of pointer from Blocks::totalOrder
This function dynamically allocated a list and returned a pointer to this,
presumably under the assumption that copying this kind of object during return
is expensive. However, Named Return Value Optimization (NRVO) applies to this
function. So the compiler can elide the copy during return, making a value
cheaper than a heap pointer here.
Matthew Fernandez [Sat, 12 Jun 2021 19:32:11 +0000 (12:32 -0700)]
replace manual iteration in Blocks::dfsVisit with range-based for loop
This C++11 syntax does the same thing.
Matthew Fernandez [Sat, 12 Jun 2021 19:29:13 +0000 (12:29 -0700)]
take a reference instead of a pointer in Blocks::dfsVisit
This function has no ability to deal with being passed null, so it is cleaner to
accept a reference.
Matthew Fernandez [Sat, 12 Jun 2021 19:21:25 +0000 (12:21 -0700)]
manage node pointers within VPSC Event type as smart pointers
This removes the need to track these allocations and removes some raw delete.
Matthew Fernandez [Sat, 19 Jun 2021 19:22:14 +0000 (19:22 +0000)]
Merge branch 'smattr/
63e46ecc -f5d0-4201-8ce6-
300e51b9ff29 ' into 'main'
more clean up in lib/sparse
See merge request graphviz/graphviz!1995
Matthew Fernandez [Wed, 9 Jun 2021 02:47:39 +0000 (19:47 -0700)]
remove unused SparseMatrix_complement
Matthew Fernandez [Wed, 9 Jun 2021 02:47:01 +0000 (19:47 -0700)]
remove unused SparseMatrix_k_centers
Matthew Fernandez [Wed, 9 Jun 2021 02:45:50 +0000 (19:45 -0700)]
remove unused SparseMatrix_k_centers_user
Matthew Fernandez [Wed, 9 Jun 2021 02:44:03 +0000 (19:44 -0700)]
remove unused SparseMatrix_distance_matrix_k_centers
Matthew Fernandez [Wed, 9 Jun 2021 02:42:04 +0000 (19:42 -0700)]
remove duplicate SparseMatrix_distance_matrix_k_centers prototype
508f7e82873289b7d1614dfbdad521111f0809dc mistakenly added two duplicates of the
same prototype.
Matthew Fernandez [Wed, 9 Jun 2021 02:41:07 +0000 (19:41 -0700)]
remove prototype for non-existent SparseMatrix_kcoreness
This function was removed in
30905ab26d62c4b126df261ad235a0fa28af5e8a but its
prototype was mistakenly left behind.
Matthew Fernandez [Wed, 9 Jun 2021 02:40:20 +0000 (19:40 -0700)]
remove prototype for non-existent SparseMatrix_kcore_decomposition
This function was removed in
30905ab26d62c4b126df261ad235a0fa28af5e8a but its
prototype was mistakenly left behind.
Matthew Fernandez [Wed, 9 Jun 2021 02:39:28 +0000 (19:39 -0700)]
remove prototype for non-existent SparseMatrix_khairness
This function was removed in
30905ab26d62c4b126df261ad235a0fa28af5e8a but its
prototype was mistakenly left behind.
Matthew Fernandez [Wed, 9 Jun 2021 02:38:33 +0000 (19:38 -0700)]
remove prototype for non-existent SparseMatrix_khair_decomposition
This function was removed in
30905ab26d62c4b126df261ad235a0fa28af5e8a but its
prototype was mistakenly left behind.
Matthew Fernandez [Wed, 9 Jun 2021 02:36:52 +0000 (19:36 -0700)]
remove unused SparseMatrix_page_rank
Matthew Fernandez [Sat, 19 Jun 2021 18:03:13 +0000 (18:03 +0000)]
Merge branch 'smattr/
a1218a82 -9220-4f73-bcd4-
04ddaab2e226 ' into 'main'
more clean up in cmd/gvmap
See merge request graphviz/graphviz!1996
Matthew Fernandez [Sat, 12 Jun 2021 04:40:34 +0000 (21:40 -0700)]
inline matvec_sparse
Following the previous commits, this function was adding nothing except a cast
which, in itself, was unnecessary.
Matthew Fernandez [Sat, 12 Jun 2021 04:36:03 +0000 (21:36 -0700)]
remove useless 'flag' parameter passed around in power.c