]>
granicus.if.org Git - php/log
Gabriel Caruso [Thu, 16 Apr 2020 09:26:54 +0000 (11:26 +0200)]
Align magic methods' camelCase with documentation
Closes GH-5398
Dmitry Stogov [Thu, 16 Apr 2020 11:35:51 +0000 (14:35 +0300)]
Improve registers reuse
George Peter Banyard [Sun, 12 Apr 2020 22:13:58 +0000 (00:13 +0200)]
Add S390X architecture as a Travis job
This gives us a way to compile and test a big endian architecture.
Closes GH-5382.
Nikita Popov [Thu, 16 Apr 2020 10:18:50 +0000 (12:18 +0200)]
Merge branch 'PHP-7.4'
* PHP-7.4:
Fix bug #79336
Nikita Popov [Thu, 16 Apr 2020 09:52:37 +0000 (11:52 +0200)]
Fix bug #79336
Make reading of floats and doubles host-endian independent.
Nikita Popov [Fri, 21 Feb 2020 12:13:36 +0000 (13:13 +0100)]
Allow using prototypes when optimizing arg passing
Closes GH-5193.
Christoph M. Becker [Thu, 16 Apr 2020 09:57:54 +0000 (11:57 +0200)]
Merge branch 'PHP-7.4'
* PHP-7.4:
Move test to its folder
Gabriel Caruso [Thu, 16 Apr 2020 09:38:27 +0000 (11:38 +0200)]
Move test to its folder
Nikita Popov [Thu, 16 Apr 2020 09:23:11 +0000 (11:23 +0200)]
Merge branch 'PHP-7.4'
* PHP-7.4:
Fix MySQL local infile / attr handling on big endian systems
Nikita Popov [Thu, 16 Apr 2020 09:22:43 +0000 (11:22 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4
* PHP-7.3:
Fix MySQL local infile / attr handling on big endian systems
guirish [Fri, 10 Apr 2020 09:45:40 +0000 (05:45 -0400)]
Fix MySQL local infile / attr handling on big endian systems
Make sure pointer types match what is used by libmysql everywhere.
Closes GH-5380.
Gabriel Caruso [Thu, 16 Apr 2020 08:39:25 +0000 (10:39 +0200)]
Fix magic method name
Gabriel Caruso [Wed, 15 Apr 2020 23:39:51 +0000 (01:39 +0200)]
Improve error messages for magic methods by appending method's class
Closes GH-5397.
vibhutisawant [Sat, 11 Apr 2020 14:45:03 +0000 (07:45 -0700)]
Fix Bug #79431 Various compiler warnings on Big endian architecture with GCC 5.4.0
Fix [-Werror=maybe-uninitialized] compilation warnings on big endian system
Closes GH-5373
Nikita Popov [Wed, 15 Apr 2020 10:58:50 +0000 (12:58 +0200)]
Remove OP_RANGE_EX distinction
Only leave OP_RANGE macros, which always have the "EX" behavior.
This was already done for most other macros before, but these
were missed. This helps avoid mistakes by using the wrong macro.
Dmitry Stogov [Wed, 15 Apr 2020 10:09:55 +0000 (13:09 +0300)]
Use proper macro
Dmitry Stogov [Wed, 15 Apr 2020 10:08:09 +0000 (13:08 +0300)]
Removed unused parameter
Nikita Popov [Wed, 15 Apr 2020 09:27:03 +0000 (11:27 +0200)]
Force short_open_tag=0 in run-tests.php
Make sure we don't accidentially add tests depending on short tags.
Nikita Popov [Wed, 15 Apr 2020 09:25:18 +0000 (11:25 +0200)]
Merge branch 'PHP-7.4'
* PHP-7.4:
Fix directory clash in tempnam_variation4 test
Nikita Popov [Wed, 15 Apr 2020 09:25:06 +0000 (11:25 +0200)]
Fix directory clash in tempnam_variation4 test
Nikita Popov [Wed, 15 Apr 2020 09:22:05 +0000 (11:22 +0200)]
Merge branch 'PHP-7.4'
* PHP-7.4:
Fixed bug #79477
Nikita Popov [Wed, 15 Apr 2020 09:21:34 +0000 (11:21 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4
* PHP-7.3:
Fixed bug #79477
Nikita Popov [Wed, 15 Apr 2020 09:20:33 +0000 (11:20 +0200)]
Fixed bug #79477
Make sure to deindirect properties when creating array.
Nikita Popov [Wed, 15 Apr 2020 08:59:58 +0000 (10:59 +0200)]
Remove return value from llist apply functions
Unlike the hash apply functions, these do not return int.
Nikita Popov [Wed, 15 Apr 2020 08:49:44 +0000 (10:49 +0200)]
Make zend_list_free return void
And assert that the refcount is zero. This function should only
be used internally as the resource destructor.
Nikita Popov [Wed, 15 Apr 2020 08:45:18 +0000 (10:45 +0200)]
Adjust zend_write_func signature
Make it return size_t instead of int, to line up with actual
implementation.
Nikita Popov [Wed, 15 Apr 2020 08:41:19 +0000 (10:41 +0200)]
More precise ifunc resolver return type
Fixes -Wattribute-alias warning.
Nikita Popov [Wed, 15 Apr 2020 08:37:33 +0000 (10:37 +0200)]
Suppress SIG_ERR cast warnings
By casting to void*. I don't want to deal with this right now.
Nikita Popov [Wed, 15 Apr 2020 08:28:48 +0000 (10:28 +0200)]
Fix function signature mismatches in GMP
This is fairly annoying. Add adapter functions for cases where
we are discarding a return value.
Some of the issues are legitimate in that we were previously
truncating some unsigned long return values to int implicitly,
though I doubt it makes a difference in practice.
This fixes -Wcast-function-type warnings.
Nikita Popov [Wed, 15 Apr 2020 08:04:20 +0000 (10:04 +0200)]
Fix PHP_HAVALUpdate signature
Fixes a -Wcast-function-type warning.
Nikita Popov [Wed, 15 Apr 2020 07:58:19 +0000 (09:58 +0200)]
Fix function libxml free error signature
Fixes a -Wcast-function-type warning.
Remi Collet [Wed, 15 Apr 2020 07:26:55 +0000 (09:26 +0200)]
fix test using short_tag
Remi Collet [Wed, 15 Apr 2020 07:07:21 +0000 (09:07 +0200)]
workaround typo in system libgd 2.3.0
George Peter Banyard [Wed, 5 Feb 2020 16:36:41 +0000 (17:36 +0100)]
Add -Wextra compiler warnings and exclude the trigger happy ones
The compile warnings which are explicitly suppressed are:
* -Wno-implicit-fallthrough
* -Wno-unused-parameter
* -Wno-sign-compare
* -Wno-clobbered, only with GCC
Closes GH-5151
George Peter Banyard [Thu, 26 Mar 2020 20:17:23 +0000 (21:17 +0100)]
Add -Wno-type-limits compiler flag to Sodium extension
This may happen on 32bits
George Peter Banyard [Wed, 25 Mar 2020 18:13:59 +0000 (19:13 +0100)]
Add -Wno-ignored-qualifiers compiler flag to Tidy extension.
This is an issue in the provided library and needs to be fixed upstream.
Dmitry Stogov [Tue, 14 Apr 2020 17:38:42 +0000 (20:38 +0300)]
Merge branch 'PHP-7.4'
* PHP-7.4:
Fix #79472: ext/ffi/tests/040.phpt TC fails on Big endian arch
Christoph M. Becker [Mon, 13 Apr 2020 21:24:40 +0000 (23:24 +0200)]
Fix #79472: ext/ffi/tests/040.phpt TC fails on Big endian arch
For now we are choosing the simplest solution, namely to skip the test
on big-endian architectures.
Christoph M. Becker [Tue, 14 Apr 2020 16:20:58 +0000 (18:20 +0200)]
Merge branch 'PHP-7.4'
* PHP-7.4:
Add missing CVE
Christoph M. Becker [Tue, 14 Apr 2020 16:19:16 +0000 (18:19 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4
* PHP-7.3:
Add missing CVE
Christoph M. Becker [Tue, 14 Apr 2020 16:18:18 +0000 (18:18 +0200)]
Add missing CVE
Nikita Popov [Tue, 14 Apr 2020 15:55:04 +0000 (17:55 +0200)]
Make gen_stub.php compatible with PHP 7.1 again
Not worth bumping requirements over this...
Nikita Popov [Tue, 14 Apr 2020 15:50:54 +0000 (17:50 +0200)]
Fix test after callback name change
Alex Dowad [Tue, 14 Apr 2020 12:05:32 +0000 (14:05 +0200)]
Remove XFAIL from tests for 'bug' 48770
Bug 48770 was opened due to conflicting expectations about the behavior of:
call_user_func_array(array($this, 'parent::methodName'), array($arg1,$arg2))
The one reporting the 'bug' seemed to think that since the method name was prefixed with
`parent::`, it should call the method in the superclass of the *class where this code appears*.
However, `$this` might be an instance of a subclass. If so, then it is quite reasonable that
`call_user_func_array` will call the method as defined in the superclass of *the receiver*.
So the 'bug' is not really a bug. Therefore, there is no need for an XFAIL in the tests. They
should just pass.
Amend tests to reflect the actual expected behavior of `call_user_func_array`, not what the
person who reported bug 48770 thought it should be.
Closes GH-5386.
Nikita Popov [Tue, 14 Apr 2020 15:38:56 +0000 (17:38 +0200)]
Fix filter_(var|input)_array default
George Peter Banyard [Wed, 25 Mar 2020 20:30:54 +0000 (21:30 +0100)]
Remove XFAIL section of a passing COM test
Closes GH-5297
Nikita Popov [Tue, 14 Apr 2020 15:17:38 +0000 (17:17 +0200)]
Add zend_string_concat2 API
Sara Golemon [Tue, 14 Apr 2020 15:14:04 +0000 (11:14 -0400)]
Merge branch 'PHP-7.4'
* PHP-7.4:
Fixed bug #79468
NEWS
Guillaume Charifi [Tue, 14 Apr 2020 10:04:23 +0000 (12:04 +0200)]
Improve socket cmsg space handling.
This should also fix the null pointer arithmetic warning on MacOS as we don't depend on whack code written by Apple.
Closes GH-5387
Nikita Popov [Tue, 14 Apr 2020 15:02:47 +0000 (17:02 +0200)]
Always use __invoke callable name for objects
The callable name is provided also if it's not callable, in which
case it's basically "what it would be if it were callable", which
is ClassName::__invoke. The current behavior of casting the object
to string makes very little sense as this will just throw an
exception for most objects.
Nikita Popov [Tue, 14 Apr 2020 14:52:13 +0000 (16:52 +0200)]
Add zend_create_member_string() API
This is a recurring pattern.
Sara Golemon [Tue, 14 Apr 2020 14:32:21 +0000 (10:32 -0400)]
Merge branch 'PHP-7.3' into PHP-7.4
* PHP-7.3:
Fixed bug #79468
NEWS
Sara Golemon [Tue, 14 Apr 2020 14:31:35 +0000 (10:31 -0400)]
Merge branch 'PHP-7.2' into PHP-7.3
* PHP-7.2:
Fixed bug #79468
NEWS
dinosaur [Mon, 13 Apr 2020 23:46:34 +0000 (07:46 +0800)]
Fixed bug #79468
Close the stream filter resources when removing them from the stream.
Sara Golemon [Tue, 14 Apr 2020 14:25:37 +0000 (10:25 -0400)]
NEWS
Nikita Popov [Tue, 14 Apr 2020 13:16:28 +0000 (15:16 +0200)]
Use UNKNOWN default for socket_connect()
Specifying the port is mandatory for INET sockets.
Nikita Popov [Tue, 14 Apr 2020 13:14:40 +0000 (15:14 +0200)]
Fix socket_write() default value
Nikita Popov [Tue, 14 Apr 2020 14:08:43 +0000 (16:08 +0200)]
Merge branch 'PHP-7.4'
* PHP-7.4:
Don't leak peername if accept fails
Nikita Popov [Tue, 14 Apr 2020 14:08:07 +0000 (16:08 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4
* PHP-7.3:
Don't leak peername if accept fails
Nikita Popov [Tue, 14 Apr 2020 14:05:57 +0000 (16:05 +0200)]
Don't leak peername if accept fails
Even if the accept fails, the peername may be populated.
George Peter Banyard [Tue, 14 Apr 2020 11:56:48 +0000 (13:56 +0200)]
Add Intl resource bundle files for big-endian architecture.
Little and Big endian files have their own designated folder.
Both use the ASCII charset family.
We may want to add a big-endian/EBCDIC charset family resource bundle in the future.
The build script is currently left untouched as it seems to mostly be for Windows.
Máté Kocsis [Mon, 13 Apr 2020 08:41:23 +0000 (10:41 +0200)]
Improve some TypeError and ValueError messages
Closes GH-5377
Dmitry Stogov [Tue, 14 Apr 2020 12:37:20 +0000 (15:37 +0300)]
Added missed '~'
Christoph M. Becker [Tue, 14 Apr 2020 12:01:00 +0000 (14:01 +0200)]
Merge branch 'PHP-7.4'
* PHP-7.4:
Fix test cases
Christoph M. Becker [Tue, 14 Apr 2020 11:59:39 +0000 (13:59 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4
* PHP-7.3:
Fix test cases
Christoph M. Becker [Tue, 14 Apr 2020 11:55:56 +0000 (13:55 +0200)]
Fix test cases
Máté Kocsis [Sun, 12 Apr 2020 12:03:43 +0000 (14:03 +0200)]
Generate method entries for ext/intl
Closes GH-5370
Nikita Popov [Tue, 14 Apr 2020 10:52:24 +0000 (12:52 +0200)]
Increase timeout on ubsan/asan job
This one occasionally runs for more than 2:30 hours.
Nikita Popov [Tue, 14 Apr 2020 10:02:04 +0000 (12:02 +0200)]
Merge branch 'PHP-7.4'
* PHP-7.4:
Fixed bug #79468
Nikita Popov [Tue, 14 Apr 2020 10:00:02 +0000 (12:00 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4
* PHP-7.3:
Fixed bug #79468
dinosaur [Mon, 13 Apr 2020 23:46:34 +0000 (07:46 +0800)]
Fixed bug #79468
Close the stream filter resources when removing them from the stream.
Máté Kocsis [Tue, 14 Apr 2020 09:32:33 +0000 (11:32 +0200)]
Remove PDO::dbh_constructor()
Máté Kocsis [Sun, 12 Apr 2020 16:50:41 +0000 (18:50 +0200)]
Generate method entries from stubs for curl, ffi, pdo, phar
Closes GH-5375
Máté Kocsis [Mon, 13 Apr 2020 14:28:55 +0000 (16:28 +0200)]
Generate function entries from stubs for a couple of extensions
Migrates ext/standard, ext/tidy, ext/tokenizer,
ext/xml, ext/xml_reader, and ext/xml_writer. Closes GH-5381.
Alex Dowad [Wed, 8 Apr 2020 11:19:39 +0000 (13:19 +0200)]
Syntax errors caused by unclosed {, [, ( mention specific location
Aside from a few very specific syntax errors for which detailed exceptions are
thrown, generally PHP just emits the default error messages generated by bison on syntax
error. These messages are very uninformative; they just say "Unexpected ... at line ...".
This is most problematic with constructs which can span an arbitrary number of lines, such
as blocks of code delimited by { }, 'if' conditions delimited by ( ), and so on. If a closing
delimiter is missed, the block will run for the entire remainder of the source file (which
could be thousands of lines), and then at the end, a parse error will be thrown with the
dreaded words: "Unexpected end of file".
Therefore, track the positions of opening and closing delimiters and ensure that they match
up correctly. If any mismatch or missing delimiter is detected, immediately throw a parse
error which points the user to the offending line. This is best done in the *lexer* and not
in the parser.
Thanks to Nikita Popov and George Peter Banyard for suggesting improvements.
Fixes bug #79368.
Closes GH-5364.
Nikita Popov [Tue, 14 Apr 2020 08:36:55 +0000 (10:36 +0200)]
Remove int6store()
The implementation is broken (syntactically). As it's not used
anyway, I'm just dropping it instead.
Christoph M. Becker [Tue, 14 Apr 2020 06:57:29 +0000 (08:57 +0200)]
Merge branch 'PHP-7.4'
* PHP-7.4:
Add NEWS entries [ci skip]
Christoph M. Becker [Tue, 14 Apr 2020 06:55:48 +0000 (08:55 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4
* PHP-7.3:
Add NEWS entries [ci skip]
Christoph M. Becker [Tue, 14 Apr 2020 06:53:35 +0000 (08:53 +0200)]
Add NEWS entries [ci skip]
Stanislav Malyshev [Tue, 14 Apr 2020 04:09:23 +0000 (21:09 -0700)]
Merge branch 'PHP-7.4'
* PHP-7.4:
Fix bug #79465 - use unsigneds as indexes.
Fix bug #79330 - make all execution modes consistent in rejecting \0
Stanislav Malyshev [Tue, 14 Apr 2020 04:09:15 +0000 (21:09 -0700)]
Merge branch 'PHP-7.3' into PHP-7.4
* PHP-7.3:
Fix bug #79465 - use unsigneds as indexes.
Fix bug #79330 - make all execution modes consistent in rejecting \0
Stanislav Malyshev [Tue, 14 Apr 2020 04:09:08 +0000 (21:09 -0700)]
Merge branch 'PHP-7.2' into PHP-7.3
* PHP-7.2:
Fix bug #79465 - use unsigneds as indexes.
Fix bug #79330 - make all execution modes consistent in rejecting \0
Stanislav Malyshev [Tue, 14 Apr 2020 04:07:04 +0000 (21:07 -0700)]
Fix bug #79465 - use unsigneds as indexes.
Stanislav Malyshev [Tue, 14 Apr 2020 04:00:44 +0000 (21:00 -0700)]
Fix bug #79330 - make all execution modes consistent in rejecting \0
George Peter Banyard [Mon, 13 Apr 2020 18:25:22 +0000 (20:25 +0200)]
Fix [-Wchar-subscripts] in Hash extension
Use size_t type instead of char for string index.
Char may be unsigned on some platforms.
partial fix to bug 79431
George Peter Banyard [Sun, 12 Apr 2020 16:23:54 +0000 (18:23 +0200)]
Fix [-Werror=missing-braces] compiler warning
Partial fix to bug 79431
Máté Kocsis [Sun, 12 Apr 2020 17:53:32 +0000 (19:53 +0200)]
Generate method entries for ext/session and ext/reflection
Closes GH-5376
Máté Kocsis [Sat, 11 Apr 2020 20:01:51 +0000 (22:01 +0200)]
Generate method entries for ext/dom
Closes GH-5374
George Peter Banyard [Sun, 12 Apr 2020 19:10:03 +0000 (21:10 +0200)]
Fix [-Wempty-body] compiler warning in Phar extension
George Peter Banyard [Sun, 12 Apr 2020 17:34:05 +0000 (19:34 +0200)]
Adapt assertion as mbfl_strwidth returns a size_t
Máté Kocsis [Sat, 11 Apr 2020 23:49:13 +0000 (01:49 +0200)]
Generate method entries for ext/xsl
Closes GH-5372
Máté Kocsis [Sat, 11 Apr 2020 22:25:33 +0000 (00:25 +0200)]
Fix nullable types in PHPDoc
Tyson Andre [Sat, 11 Apr 2020 20:52:47 +0000 (16:52 -0400)]
Fix an undefined class error running gen_stub in php8
For whatever reason, php 8 would not have loaded the subsequent classes when
running `php build/gen_stub.php path/to/filename.php`.
I assume it didn't load the classes immediately because there's a possibility
the code before it would throw.
(Probably because __toString was added recently and prevents early binding)
Also, fix a typo
Closes GH-5369
Máté Kocsis [Sat, 11 Apr 2020 12:13:11 +0000 (14:13 +0200)]
Lowercase NULL to null in stubs
Máté Kocsis [Sat, 11 Apr 2020 11:27:04 +0000 (13:27 +0200)]
Generate method entries from stubs for a couple of extensions
Closes GH-5368
Máté Kocsis [Sat, 11 Apr 2020 08:23:51 +0000 (10:23 +0200)]
Add missing visibility modifiers in stubs
Máté Kocsis [Thu, 9 Apr 2020 09:27:20 +0000 (11:27 +0200)]
Add support for generating method entries from stubs
Closes GH-5363
Máté Kocsis [Thu, 9 Apr 2020 07:46:44 +0000 (09:46 +0200)]
Improve the default value format in incompatible signature error messages
Closes GH-5361
Máté Kocsis [Fri, 10 Apr 2020 16:04:17 +0000 (18:04 +0200)]
Fix the default value of the $length parameter of grapheme_substr()
Máté Kocsis [Fri, 10 Apr 2020 16:03:20 +0000 (18:03 +0200)]
Fix default value of the $class_name parameter of mysqli_fetch_object()