]> granicus.if.org Git - php/log
php
6 years agoFixed #75996: Add the right urls to the header of mt_rand.
TATAR Balazs Janos [Thu, 22 Feb 2018 16:10:33 +0000 (17:10 +0100)]
Fixed #75996: Add the right urls to the header of mt_rand.

6 years agoFix #76131 some arginfo params are different from the documentation
Gabriel Caruso [Sat, 24 Mar 2018 04:51:21 +0000 (01:51 -0300)]
Fix #76131 some arginfo params are different from the documentation

6 years agoUpdate libs_versions.txt
Anatol Belski [Tue, 27 Mar 2018 17:44:17 +0000 (19:44 +0200)]
Update libs_versions.txt

6 years agoMerge branch 'PHP-7.0' into PHP-7.1
Anatol Belski [Tue, 27 Mar 2018 14:03:54 +0000 (16:03 +0200)]
Merge branch 'PHP-7.0' into PHP-7.1

* PHP-7.0:
  [ci skip] Fix release date

6 years ago[ci skip] Fix release date
Anatol Belski [Tue, 27 Mar 2018 14:02:19 +0000 (16:02 +0200)]
[ci skip] Fix release date

6 years agoMerge branch 'PHP-7.0' into PHP-7.1
Anatol Belski [Tue, 27 Mar 2018 13:02:07 +0000 (15:02 +0200)]
Merge branch 'PHP-7.0' into PHP-7.1

* PHP-7.0:
  7.0.30 next

6 years ago7.0.30 next
Anatol Belski [Tue, 27 Mar 2018 13:00:54 +0000 (15:00 +0200)]
7.0.30 next

6 years ago[ci skip] Update NEWS
Anatol Belski [Tue, 27 Mar 2018 12:27:44 +0000 (14:27 +0200)]
[ci skip] Update NEWS

6 years agoMerge branch 'PHP-7.0' into PHP-7.1
Anatol Belski [Tue, 27 Mar 2018 12:26:36 +0000 (14:26 +0200)]
Merge branch 'PHP-7.0' into PHP-7.1

* PHP-7.0:
  [ci skip] Update NEWS
  [ci skip] Update NEWS

6 years ago[ci skip] Update NEWS
Anatol Belski [Tue, 27 Mar 2018 12:26:06 +0000 (14:26 +0200)]
[ci skip] Update NEWS

6 years agoMerge branch 'PHP-5.6' into PHP-7.0
Anatol Belski [Tue, 27 Mar 2018 12:25:24 +0000 (14:25 +0200)]
Merge branch 'PHP-5.6' into PHP-7.0

* PHP-5.6:
  [ci skip] Update NEWS

6 years ago[ci skip] Update NEWS
Anatol Belski [Tue, 27 Mar 2018 12:24:43 +0000 (14:24 +0200)]
[ci skip] Update NEWS

6 years agoMerge branch 'PHP-7.0' into PHP-7.1
Anatol Belski [Tue, 27 Mar 2018 12:20:10 +0000 (14:20 +0200)]
Merge branch 'PHP-7.0' into PHP-7.1

* PHP-7.0:
  Do not set PR_SET_DUMPABLE by default
  Do not set PR_SET_DUMPABLE by default

6 years agoDo not set PR_SET_DUMPABLE by default
Jakub Zelenka [Fri, 16 Mar 2018 20:23:24 +0000 (20:23 +0000)]
Do not set PR_SET_DUMPABLE by default

6 years agoMerge branch 'PHP-5.6' into PHP-7.0
Anatol Belski [Tue, 27 Mar 2018 12:19:22 +0000 (14:19 +0200)]
Merge branch 'PHP-5.6' into PHP-7.0

* PHP-5.6:
  Do not set PR_SET_DUMPABLE by default

6 years agoDo not set PR_SET_DUMPABLE by default
Jakub Zelenka [Wed, 7 Mar 2018 18:12:56 +0000 (18:12 +0000)]
Do not set PR_SET_DUMPABLE by default

6 years agoFix phpize build when DEFINE() is involved
Anatol Belski [Mon, 26 Mar 2018 11:33:55 +0000 (13:33 +0200)]
Fix phpize build when DEFINE() is involved

6 years agoSync version for VC++ 15.7
Anatol Belski [Sun, 25 Mar 2018 10:58:00 +0000 (12:58 +0200)]
Sync version for VC++ 15.7

6 years agoUpdated to version 2018.4 (2018d)
Derick Rethans [Sat, 24 Mar 2018 11:26:15 +0000 (11:26 +0000)]
Updated to version 2018.4 (2018d)

6 years agoUpdate SDK version for AppVeyor
Anatol Belski [Wed, 21 Mar 2018 12:15:29 +0000 (13:15 +0100)]
Update SDK version for AppVeyor

6 years agoFix #76113: mbstring does not build with Oniguruma 6.8.1
Christoph M. Becker [Tue, 20 Mar 2018 15:35:39 +0000 (16:35 +0100)]
Fix #76113: mbstring does not build with Oniguruma 6.8.1

As of Oniguruma 6.8.1, the regex structure has been moved from the
public `oniguruma.h` to the private `regint.h`.  Thus, it is no longer
possible to directly access the struct's members, and actually, there
is no need to, since there are respective accessor functions available
at least of 2.3.1.

6 years agoFix #75944: Wrong cp1251 detection
Christoph M. Becker [Mon, 19 Mar 2018 12:51:40 +0000 (13:51 +0100)]
Fix #75944: Wrong cp1251 detection

`\xFF` is a valid character of CP-1251.

6 years agoSet tests exit status by defaul - also in other instance.
Stanislav Malyshev [Mon, 19 Mar 2018 08:17:14 +0000 (01:17 -0700)]
Set tests exit status by defaul - also in other instance.

6 years agoSet tests exit status by default.
Stanislav Malyshev [Sun, 18 Mar 2018 22:04:50 +0000 (15:04 -0700)]
Set tests exit status by default.

Use REPORT_EXIT_STATUS=0 or REPORT_EXIT_STATUS=no to prevent it.

Based on discussion in https://www.mail-archive.com/internals@lists.php.net/msg94141.html

6 years agoSync test with newer output
Anatol Belski [Fri, 16 Mar 2018 17:54:55 +0000 (18:54 +0100)]
Sync test with newer output

Czech Republic vs. newer Czechia

6 years agoReduce var scope
Anatol Belski [Wed, 14 Mar 2018 21:59:54 +0000 (22:59 +0100)]
Reduce var scope

6 years agoFix stack use after scope
Anatol Belski [Wed, 14 Mar 2018 21:21:43 +0000 (22:21 +0100)]
Fix stack use after scope

6 years agoUpgrade binary SDK version for AppVeyor
Anatol Belski [Wed, 14 Mar 2018 10:59:37 +0000 (11:59 +0100)]
Upgrade binary SDK version for AppVeyor

6 years agoFixed use-after-free
Dmitry Stogov [Wed, 14 Mar 2018 06:11:48 +0000 (09:11 +0300)]
Fixed use-after-free

6 years agobump versions
Joe Watkins [Wed, 14 Mar 2018 04:58:42 +0000 (05:58 +0100)]
bump versions

6 years agoFix #74139: mail.add_x_header default inconsistent with docs [ci skip]
Christoph M. Becker [Tue, 13 Mar 2018 22:54:42 +0000 (23:54 +0100)]
Fix #74139: mail.add_x_header default inconsistent with docs [ci skip]

mail.add_x_header actually defaults to `Off`, so we should use this
default in the provided `php.ini`s.

6 years agoFix #76088: ODBC functions are not available by default on Windows
Christoph M. Becker [Tue, 13 Mar 2018 13:16:20 +0000 (14:16 +0100)]
Fix #76088: ODBC functions are not available by default on Windows

6 years agoRevert "More accurate symbolic constraints oferflow/unserflow handling (better fix...
Dmitry Stogov [Tue, 13 Mar 2018 08:03:45 +0000 (11:03 +0300)]
Revert "More accurate symbolic constraints oferflow/unserflow handling (better fix for bug #76074)."

This reverts commit 44ba557de5c0d767ff6ccfcc2c8bde7d7c0746fe.

6 years agoMore accurate symbolic constraints oferflow/unserflow handling (better fix for bug...
Dmitry Stogov [Tue, 13 Mar 2018 07:44:53 +0000 (10:44 +0300)]
More accurate symbolic constraints oferflow/unserflow handling (better fix for bug #76074).

6 years agoForgot NEWS
Xinchen Hui [Tue, 13 Mar 2018 05:00:47 +0000 (13:00 +0800)]
Forgot NEWS

6 years agoFixed bug #76085 (Segmentation fault in buildFromIterator when directory name contain...
Xinchen Hui [Tue, 13 Mar 2018 04:51:26 +0000 (12:51 +0800)]
Fixed bug #76085 (Segmentation fault in buildFromIterator when directory name contains a \n)

6 years agoFix heap use after free
Anatol Belski [Mon, 12 Mar 2018 19:57:21 +0000 (20:57 +0100)]
Fix heap use after free

The value may only be used until PGresult was destroyed, thus it needs
to be copied.

6 years agoUse string literal as format
Anatol Belski [Mon, 12 Mar 2018 14:17:08 +0000 (15:17 +0100)]
Use string literal as format

6 years agoProvide core includes for the resource compiler by default
Anatol Belski [Mon, 12 Mar 2018 13:14:34 +0000 (14:14 +0100)]
Provide core includes for the resource compiler by default

6 years agoReplaced usafe reference from SHM to process memory with SHM to SHM reference
Dmitry Stogov [Mon, 12 Mar 2018 08:18:12 +0000 (11:18 +0300)]
Replaced usafe reference from SHM to process memory with SHM to SHM reference

6 years agoFix #62545: wrong unicode mapping in some charsets
Christoph M. Becker [Sat, 24 Feb 2018 21:34:32 +0000 (22:34 +0100)]
Fix #62545: wrong unicode mapping in some charsets

Undefined characters are best mapped to Unicode REPLACEMENT characters.

6 years ago[ci skip] Update NEWS
Anatol Belski [Sat, 10 Mar 2018 19:07:23 +0000 (20:07 +0100)]
[ci skip] Update NEWS

6 years agoFix bug #76074 (opcache corrupts variable in for-loop)
Bob Weinand [Fri, 9 Mar 2018 14:08:14 +0000 (15:08 +0100)]
Fix bug #76074 (opcache corrupts variable in for-loop)

6 years agoFixed bug #76068 parse_ini_string fails to parse "[foo]\nbar=1|>baz" with segfault
Anatol Belski [Sat, 10 Mar 2018 10:18:21 +0000 (11:18 +0100)]
Fixed bug #76068 parse_ini_string fails to parse "[foo]\nbar=1|>baz" with segfault

6 years agoFix #73957: signed integer conversion in imagescale()
Christoph M. Becker [Fri, 9 Mar 2018 23:17:09 +0000 (00:17 +0100)]
Fix #73957: signed integer conversion in imagescale()

We must not pass values to `gdImageScale()` which cannot be represented
by an `unsigned int`.  Instead we return FALSE, according to what we
already did for negative integers.

6 years agoDisable PGO for phpdbg
Anatol Belski [Thu, 8 Mar 2018 10:38:02 +0000 (11:38 +0100)]
Disable PGO for phpdbg

For executable files, the linker seems to have issues dealing with the
empty profiling database. As PGO is unlikely to bring any benefit in
this case, the easiest is to disable it.

6 years agoExclude /Qspectre for clang analyzer
Anatol Belski [Wed, 7 Mar 2018 11:34:16 +0000 (12:34 +0100)]
Exclude /Qspectre for clang analyzer

6 years agoGuard platform dependent code
Anatol Belski [Wed, 7 Mar 2018 11:28:29 +0000 (12:28 +0100)]
Guard platform dependent code

6 years ago[ci skip] Update NEWS
Anatol Belski [Tue, 6 Mar 2018 21:06:52 +0000 (22:06 +0100)]
[ci skip] Update NEWS

6 years agoReplaced usafe reference from SHM to process memory with SHM to SHM reference.
Dmitry Stogov [Mon, 5 Mar 2018 23:43:26 +0000 (02:43 +0300)]
Replaced usafe reference from SHM to process memory with SHM to SHM reference.

6 years agoDon't keep HashTable.pDestructor in SHM and always set it into ZVAL_PTR_DTOR in zval_...
Dmitry Stogov [Mon, 5 Mar 2018 21:56:16 +0000 (00:56 +0300)]
Don't keep HashTable.pDestructor in SHM and always set it into ZVAL_PTR_DTOR in zval_array_dup().
Keeping pointer to a function in SHM is not safe because of ASLR.

6 years agoMerge branch 'PHP-7.1' of git.php.net:php-src into PHP-7.1
Dmitry Stogov [Mon, 5 Mar 2018 21:47:40 +0000 (00:47 +0300)]
Merge branch 'PHP-7.1' of git.php.net:php-src into PHP-7.1

* 'PHP-7.1' of git.php.net:php-src:
  Fixed bug #76044 'date: illegal option -- -' in ./configure on FreeBSD

6 years agoFixed invalid destructor
Dmitry Stogov [Mon, 5 Mar 2018 21:46:19 +0000 (00:46 +0300)]
Fixed invalid destructor

6 years agoFixed bug #76044 'date: illegal option -- -' in ./configure on FreeBSD
Anatol Belski [Mon, 5 Mar 2018 21:35:58 +0000 (22:35 +0100)]
Fixed bug #76044 'date: illegal option -- -' in ./configure on FreeBSD

6 years agoFixed invalid destructor
Dmitry Stogov [Mon, 5 Mar 2018 20:33:08 +0000 (23:33 +0300)]
Fixed invalid destructor

6 years agoRevert "Fixed bug #75961 (Strange references behavior)"
Nikita Popov [Mon, 5 Mar 2018 14:28:58 +0000 (15:28 +0100)]
Revert "Fixed bug #75961 (Strange references behavior)"

This reverts commit 94e9d0a2ae76bad712495d820d3962e401085fef.

This code needs to be mindful about modifications to the array
happening during callback execution. It was written in a way that
only accessed the reference, which is guaranteed not to move. The
changed implementation instead accesses the array slot, leading to
use-after-free.

Run ext/standard/tests/array/bug61967.phpt under valgrind to see
the issue.

6 years agoInclude username into the file cache path
Anatol Belski [Mon, 5 Mar 2018 14:16:55 +0000 (15:16 +0100)]
Include username into the file cache path

6 years agoFixed "opcache.file_cache_fallback" mode.
Dmitry Stogov [Mon, 5 Mar 2018 13:01:43 +0000 (16:01 +0300)]
Fixed "opcache.file_cache_fallback" mode.

It's not safe to change value of ZCG(accel_directives).file_cache_only, becuse it might be altered by INI subsystem.
Use global variable instead.

6 years agofix news date
Joe Watkins [Wed, 28 Feb 2018 11:10:58 +0000 (12:10 +0100)]
fix news date

6 years agoFixed bug #76025 (Segfault while throwing exception in error_handler).
Xinchen Hui [Wed, 28 Feb 2018 10:06:37 +0000 (18:06 +0800)]
Fixed bug #76025 (Segfault while throwing exception in error_handler).

6 years agorevert last change, for PHP7 no need to do strlen() + 1 for hash look up.
George Wang [Wed, 28 Feb 2018 04:31:43 +0000 (23:31 -0500)]
revert last change, for PHP7 no need to do strlen() + 1 for hash look up.

6 years ago[BUGFIX] calling php_ini_activate_per_host_config() with correct name length.
George Wang [Wed, 28 Feb 2018 04:18:51 +0000 (23:18 -0500)]
[BUGFIX] calling php_ini_activate_per_host_config() with correct name length.

6 years agoFix pcntl build on mac
Bob Weinand [Wed, 28 Feb 2018 01:13:28 +0000 (02:13 +0100)]
Fix pcntl build on mac

Apparently on mac WIF*(x) macros resolve to (*(int*)&x) (_W_INT macro in sys/wait.h), forcing the value to be a lvalue

6 years agoMerge branch 'PHP-7.0' into PHP-7.1
Ferenc Kovacs [Tue, 27 Feb 2018 23:02:48 +0000 (00:02 +0100)]
Merge branch 'PHP-7.0' into PHP-7.1

6 years agoMerge branch 'PHP-5.6' into PHP-7.0
Ferenc Kovacs [Tue, 27 Feb 2018 23:00:12 +0000 (00:00 +0100)]
Merge branch 'PHP-5.6' into PHP-7.0

6 years ago5.6.35 is next
Ferenc Kovacs [Tue, 27 Feb 2018 22:57:06 +0000 (23:57 +0100)]
5.6.35 is next

6 years agorelease LiteSpeed SAPI 7.0.
George Wang [Tue, 27 Feb 2018 18:54:28 +0000 (13:54 -0500)]
release LiteSpeed SAPI 7.0.
add CRIU support.
add support for [PATH=] and [HOST=] sections in php.ini

6 years agoMerge branch 'PHP-7.0' into PHP-7.1
Anatol Belski [Tue, 27 Feb 2018 10:50:22 +0000 (11:50 +0100)]
Merge branch 'PHP-7.0' into PHP-7.1

* PHP-7.0:
  7.0.29 next

6 years ago7.0.29 next
Anatol Belski [Tue, 27 Feb 2018 10:48:49 +0000 (11:48 +0100)]
7.0.29 next

6 years ago[ci skip] Update NEWS
Anatol Belski [Tue, 27 Feb 2018 10:37:24 +0000 (11:37 +0100)]
[ci skip] Update NEWS

6 years agoMerge branch 'PHP-7.0' into PHP-7.1
Anatol Belski [Tue, 27 Feb 2018 10:34:13 +0000 (11:34 +0100)]
Merge branch 'PHP-7.0' into PHP-7.1

* PHP-7.0:
  [ci skip] Update NEWS
  [ci skip] Update NEWS

6 years ago[ci skip] Update NEWS
Anatol Belski [Tue, 27 Feb 2018 10:33:40 +0000 (11:33 +0100)]
[ci skip] Update NEWS

6 years agoMerge branch 'PHP-5.6' into PHP-7.0
Anatol Belski [Tue, 27 Feb 2018 10:32:26 +0000 (11:32 +0100)]
Merge branch 'PHP-5.6' into PHP-7.0

* PHP-5.6:
  [ci skip] Update NEWS

6 years ago[ci skip] Update NEWS
Anatol Belski [Tue, 27 Feb 2018 10:31:37 +0000 (11:31 +0100)]
[ci skip] Update NEWS

6 years agoMerge branch 'PHP-7.0' into PHP-7.1
Stanislav Malyshev [Tue, 27 Feb 2018 06:26:50 +0000 (22:26 -0800)]
Merge branch 'PHP-7.0' into PHP-7.1

* PHP-7.0:
  Fix bug #75981: prevent reading beyond buffer start

6 years agoMerge branch 'PHP-5.6' into PHP-7.0
Stanislav Malyshev [Tue, 27 Feb 2018 06:26:26 +0000 (22:26 -0800)]
Merge branch 'PHP-5.6' into PHP-7.0

* PHP-5.6:
  Fix bug #75981: prevent reading beyond buffer start

6 years agoFix bug #75981: prevent reading beyond buffer start
Stanislav Malyshev [Tue, 20 Feb 2018 23:34:43 +0000 (15:34 -0800)]
Fix bug #75981: prevent reading beyond buffer start

6 years ago[ci skip] Update NEWS
Christoph M. Becker [Sat, 24 Feb 2018 22:37:43 +0000 (23:37 +0100)]
[ci skip] Update NEWS

6 years agoFix imagesetinterpolation arginfo
Gabriel Caruso [Sat, 24 Feb 2018 00:33:03 +0000 (21:33 -0300)]
Fix imagesetinterpolation arginfo

imagesetinterpolation only requires one parameter.

6 years agoMerge branch 'PHP-7.0' into PHP-7.1
Stanislav Malyshev [Sat, 24 Feb 2018 01:57:50 +0000 (17:57 -0800)]
Merge branch 'PHP-7.0' into PHP-7.1

* PHP-7.0:
  [ci skip] Set FPM maintainership

6 years agoMerge branch 'PHP-5.6' into PHP-7.0
Stanislav Malyshev [Sat, 24 Feb 2018 01:57:26 +0000 (17:57 -0800)]
Merge branch 'PHP-5.6' into PHP-7.0

* PHP-5.6:
  [ci skip] Set FPM maintainership

6 years ago[ci skip] Set FPM maintainership
Stanislav Malyshev [Sat, 24 Feb 2018 00:43:10 +0000 (16:43 -0800)]
[ci skip] Set FPM maintainership

As per http://news.php.net/php.internals/101897, Jakub is officially
annointed as new FPM maintainer.

6 years agoFix #75873: pcntl_wexitstatus returns incorrect on Big_Endian platform (s390x)
Sam Ding [Fri, 23 Feb 2018 15:11:18 +0000 (10:11 -0500)]
Fix #75873: pcntl_wexitstatus returns incorrect on Big_Endian platform (s390x)

Cf. https://github.com/php/php-src/pull/3141.

6 years agoFix some arginfos
Gabriel Caruso [Wed, 21 Feb 2018 04:04:41 +0000 (01:04 -0300)]
Fix some arginfos

* all arguments for ftp_pasv are required
* $varname for getenv function isn't required anymore
* fsockopen and pfsockopen only require $hostname
* strtok can work with only one parameter
* strpbrk needs two parameters to work
* required parameters and add some parameters in openssl_* functions

6 years agoMerge branch 'PHP-7.0' into PHP-7.1
Johannes Schlüter [Tue, 20 Feb 2018 22:32:05 +0000 (23:32 +0100)]
Merge branch 'PHP-7.0' into PHP-7.1

6 years agoFix NEWS
Johannes Schlüter [Tue, 20 Feb 2018 22:31:30 +0000 (23:31 +0100)]
Fix NEWS

6 years agoFix a memleak with mysqlnd and SSL
Johannes Schlüter [Tue, 20 Feb 2018 22:28:23 +0000 (23:28 +0100)]
Fix a memleak with mysqlnd and SSL

6 years agoMerge branch 'PHP-7.0' into PHP-7.1
Johannes Schlüter [Tue, 20 Feb 2018 22:20:02 +0000 (23:20 +0100)]
Merge branch 'PHP-7.0' into PHP-7.1

6 years agoFix negotiaton of MySQL auth plugin
Johannes Schlüter [Tue, 20 Feb 2018 22:13:03 +0000 (23:13 +0100)]
Fix negotiaton of MySQL auth plugin

6 years ago[ci skip] Sort recent NEWS entries alphabetically
Christoph M. Becker [Tue, 20 Feb 2018 15:31:56 +0000 (16:31 +0100)]
[ci skip] Sort recent NEWS entries alphabetically

6 years agoFix openssl_* arginfos
Gabriel Caruso [Sat, 17 Feb 2018 00:31:29 +0000 (22:31 -0200)]
Fix openssl_* arginfos

openssl_pkcs12_export and openssl_x509_parse had wrong arginfos

6 years agoUpdate binary tools SDK branch for AppVeyor
Anatol Belski [Tue, 20 Feb 2018 14:40:10 +0000 (15:40 +0100)]
Update binary tools SDK branch for AppVeyor

6 years agodos2unix
Anatol Belski [Tue, 20 Feb 2018 06:59:34 +0000 (07:59 +0100)]
dos2unix

6 years agoFix incorrect printf modifiers
Nikita Popov [Mon, 19 Feb 2018 20:44:36 +0000 (21:44 +0100)]
Fix incorrect printf modifiers

6 years agoUse more jobs with cppcheck
Anatol Belski [Mon, 19 Feb 2018 10:27:03 +0000 (11:27 +0100)]
Use more jobs with cppcheck

6 years agoRemove duplicated assignment
Anatol Belski [Sat, 17 Feb 2018 12:10:59 +0000 (13:10 +0100)]
Remove duplicated assignment

6 years agoFixed bug #75961 (Strange references behavior)
Xinchen Hui [Sat, 17 Feb 2018 08:31:59 +0000 (16:31 +0800)]
Fixed bug #75961 (Strange references behavior)

6 years agoFixed bug #75969
Nikita Popov [Fri, 16 Feb 2018 19:27:13 +0000 (20:27 +0100)]
Fixed bug #75969

Move NOP stripping out of zend_optimize_block: NOP stripping may
move instructions, which may invalidate a Tsource shared across
an extended basic block.

6 years agoWrap var depending on conditional compilation
Anatol Belski [Fri, 16 Feb 2018 12:37:38 +0000 (13:37 +0100)]
Wrap var depending on conditional compilation

6 years agoFixed print_const_table function and zval types in ____printzv_contents
Mitch Hagstrand [Wed, 14 Feb 2018 20:39:01 +0000 (14:39 -0600)]
Fixed print_const_table function and zval types in ____printzv_contents

1. Fixed print_const_table to work in ZE3
2. Removed ____print_const_table to use more generic ____print_ht
3. Fixed up zval types in ____printzv_contents