]>
granicus.if.org Git - graphviz/log
Magnus Jacobsson [Tue, 8 Sep 2020 21:44:36 +0000 (23:44 +0200)]
Add test of lefty usage
Magnus Jacobsson [Wed, 9 Sep 2020 07:11:33 +0000 (09:11 +0200)]
Fix lefty crash at exit in MSBuild debug build
Final commit that fixes
https://gitlab.com/graphviz/graphviz/-/issues/1818.
Magnus Jacobsson [Tue, 8 Sep 2020 22:58:36 +0000 (00:58 +0200)]
Allow lefty -? to show usage even if there's no DISPLAY (FEATURE_X11)
Parse lefty args before starting app and trying to open DISPLAY. This
allows testing that lefty can start in CI.
This change only affects the X11 variant (FEATURE_X11 or FEATURE_NONE
defined), not the Windows variant.
Magnus Jacobsson [Tue, 8 Sep 2020 21:44:19 +0000 (23:44 +0200)]
Correct lefty output directory for MSBuild
Magnus Jacobsson [Tue, 8 Sep 2020 18:12:17 +0000 (20:12 +0200)]
Fix lefty compile error on Windows
The FILE type, a.k.a. struct _iobuf does not have any _cnt field on
Windows. Setting HAVE_FILE_CNT to 0 avoids the use of that. None of
the other implementation alternatives work either so the canread macro
in lefty.c always returns 1.
Magnus Jacobsson [Tue, 8 Sep 2020 18:26:18 +0000 (20:26 +0200)]
Corrected name of HAVE_FILE_R macro in lefty
Changing it to HAVE_R_IN_FILE was clearly a mistake in commit
070479236d25977cde7d8306635695af2fb7c203 .
From what I can tell this currectly does not affect anything.
Magnus Jacobsson [Tue, 8 Sep 2020 07:51:47 +0000 (09:51 +0200)]
Remove BuildLog.htm item from MSBuild project files
This file is not found after an upgrade to Visual Studio 16.7.2. It
was automatically added in a prevous upgrade of Visual Studio more
than 4 years ago in
3c8cf3624f6a8b82434115177471b6e7092f836 .
Magnus Jacobsson [Wed, 1 Jul 2020 22:08:57 +0000 (00:08 +0200)]
Re-add lefty to graphviz solution
Magnus Jacobsson [Wed, 1 Jul 2020 21:54:21 +0000 (23:54 +0200)]
Retarget lefty to Visual Studio 2019 and toolset v142
Magnus Jacobsson [Fri, 11 Sep 2020 05:54:50 +0000 (05:54 +0000)]
Merge branch 'fix-gvedit-usage' into 'master'
Fix gvedit usage + misc cleanup of gvedit make
Closes #1813
See merge request graphviz/graphviz!1561
Magnus Jacobsson [Thu, 10 Sep 2020 16:47:01 +0000 (18:47 +0200)]
Unset the DISPLAY environment variable in gvedit usage test_1813
This ensures that the test fails instead of hanging if print usage and
exit fails and the program continues and tries to open the display.
Magnus Jacobsson [Sun, 6 Sep 2020 17:26:08 +0000 (19:26 +0200)]
Avoid unnecessary recompile of gvedit mocables
Reverts
bb9a819a64de7f8446f17ecdb734aaf0f811aa04 .
Magnus Jacobsson [Sun, 6 Sep 2020 16:41:59 +0000 (18:41 +0200)]
Remove 2 gvedit warnings about multiple recepies
Remove unnecessary gvedit executable dependency on $(MOCABLES)
alltogether.
Magnus Jacobsson [Sun, 6 Sep 2020 20:57:18 +0000 (22:57 +0200)]
Add temporary skip of test_1813 on Windows
The test is skipped because of
https://gitlab.com/graphviz/graphviz/-/issues/1816.
Magnus Jacobsson [Sun, 6 Sep 2020 15:13:54 +0000 (17:13 +0200)]
Add gvedit -? regression test
Magnus Jacobsson [Sun, 6 Sep 2020 21:47:19 +0000 (23:47 +0200)]
Add rpm install of graphviz-qt to ci/install-packages.sh
Contains gvedit.
Magnus Jacobsson [Sun, 6 Sep 2020 17:13:53 +0000 (19:13 +0200)]
Allow gvedit -? to show usage even if there's no DISPLAY
Parse gvedit args before starting app and trying to open DISPLAY. This
allows testing that gvedit can start in CI.
Magnus Jacobsson [Sun, 6 Sep 2020 14:57:48 +0000 (16:57 +0200)]
Update CHANGELOG.md with gvedit -? fix
Magnus Jacobsson [Sun, 6 Sep 2020 14:45:58 +0000 (16:45 +0200)]
Fix gvedit -? to actually print usage instead of error
Fixes https://gitlab.com/graphviz/graphviz/-/issues/1813
Magnus Jacobsson [Thu, 3 Sep 2020 13:42:20 +0000 (15:42 +0200)]
Remove TAB from otherwise empty line in gvedit Makefile.am
Emacs said "Suspicious line 71. Save anyway? (y or n)" every time the
file was about to be saved.
Magnus Jacobsson [Fri, 11 Sep 2020 05:35:59 +0000 (05:35 +0000)]
Merge branch 'remove-uncompiled-code' into 'master'
Remove uncompiled code to increase readability
See merge request graphviz/graphviz!1557
Matthew Fernandez [Thu, 10 Sep 2020 02:43:37 +0000 (02:43 +0000)]
Merge branch '1785-1' into 'master'
disambiguate #includes
See merge request graphviz/graphviz!1555
Matthew Fernandez [Sun, 23 Aug 2020 02:01:48 +0000 (19:01 -0700)]
remove commented out #include
Matthew Fernandez [Sun, 23 Aug 2020 00:35:42 +0000 (17:35 -0700)]
disambiguate lib/xdot/*.c #includes
Related to #1785.
Matthew Fernandez [Sun, 23 Aug 2020 00:14:53 +0000 (17:14 -0700)]
disambiguate lib/vpsc/*.cpp #includes
Related to #1785.
Matthew Fernandez [Sat, 22 Aug 2020 23:01:54 +0000 (16:01 -0700)]
disambiguate lib/vmalloc/*.c #includes
Related to #1785.
Matthew Fernandez [Sat, 22 Aug 2020 19:58:16 +0000 (12:58 -0700)]
disambiguate lib/twopigen/*.c #includes
Related to #1785.
Matthew Fernandez [Sat, 22 Aug 2020 19:50:45 +0000 (12:50 -0700)]
remove unnecessary lib/twopigen include directory
Matthew Fernandez [Sat, 22 Aug 2020 19:13:07 +0000 (12:13 -0700)]
diambiguate lib/topfish/*.c #includes
Related to #1242 and #1785.
Matthew Fernandez [Sat, 22 Aug 2020 19:04:49 +0000 (12:04 -0700)]
remove unnecessary lib/topfish include directory
Matthew Fernandez [Sat, 22 Aug 2020 18:24:43 +0000 (11:24 -0700)]
disambiguate lib/spine/*.c #includes
Related to #1785.
Matthew Fernandez [Sat, 22 Aug 2020 18:14:42 +0000 (11:14 -0700)]
remove unnecessary lib/spine include directory
Matthew Fernandez [Sat, 22 Aug 2020 17:45:33 +0000 (10:45 -0700)]
disambiguate lib/sparse/*.c #includes
Related to #1242 and #1785.
Matthew Fernandez [Sat, 22 Aug 2020 17:33:37 +0000 (10:33 -0700)]
remove unnecessary lib/sparse include directory
Matthew Fernandez [Sat, 22 Aug 2020 17:07:04 +0000 (10:07 -0700)]
dismbiguate lib/sfdpgen/*.c #includes
Related to #1242 and #1785.
Matthew Fernandez [Sat, 22 Aug 2020 16:32:44 +0000 (09:32 -0700)]
remove unnecessary lib/sfdpgen include directory
Matthew Fernandez [Sat, 22 Aug 2020 15:57:54 +0000 (08:57 -0700)]
disambiguate lib/rbtree/*.c #includes
Related to #1785.
Matthew Fernandez [Sat, 22 Aug 2020 15:49:26 +0000 (08:49 -0700)]
remove unnecessary lib/rbtree include directory
Matthew Fernandez [Sat, 22 Aug 2020 15:21:13 +0000 (08:21 -0700)]
disambiguate lib/pathplan/*.c #includes
Related to #1785.
Matthew Fernandez [Sat, 22 Aug 2020 02:54:55 +0000 (19:54 -0700)]
disambiguate lib/patchwork/*.c #includes
Related to #1785.
Matthew Fernandez [Sat, 22 Aug 2020 02:41:05 +0000 (19:41 -0700)]
remove unnecessary lib/patchwork include directory
Matthew Fernandez [Sat, 22 Aug 2020 01:46:43 +0000 (18:46 -0700)]
disambiguate lib/pack/*.c #includes
Related to #1785.
Matthew Fernandez [Sat, 22 Aug 2020 01:36:14 +0000 (18:36 -0700)]
remove unnecessary lib/pack include directory
Matthew Fernandez [Sat, 22 Aug 2020 01:06:17 +0000 (18:06 -0700)]
disambiguate lib/osage/*.c #includes
Related to #1785.
Matthew Fernandez [Sat, 22 Aug 2020 00:58:19 +0000 (17:58 -0700)]
remove unnecessary lib/osage include directory
Matthew Fernandez [Fri, 21 Aug 2020 03:25:18 +0000 (20:25 -0700)]
disambiguate lib/ortho/*.c #includes
Related to #1242 and #1785.
Matthew Fernandez [Fri, 21 Aug 2020 02:53:15 +0000 (19:53 -0700)]
remove unnecessary lib/ortho include directory
Matthew Fernandez [Wed, 19 Aug 2020 03:51:14 +0000 (20:51 -0700)]
disambiguate lib/neatogen/*.c #includes
Related to #1785.
Matthew Fernandez [Wed, 19 Aug 2020 03:17:34 +0000 (20:17 -0700)]
remove unnecessary lib/neatogen include directory
Matthew Fernandez [Wed, 19 Aug 2020 02:42:58 +0000 (19:42 -0700)]
disambiguate lib/mingle/*.c #includes
Related to #1785.
Matthew Fernandez [Wed, 19 Aug 2020 02:30:05 +0000 (19:30 -0700)]
remove unnecessary lib/mingle include directory
Matthew Fernandez [Tue, 18 Aug 2020 03:38:55 +0000 (20:38 -0700)]
disambiguate lib/label/*.c #includes
Related to #1242 and #1785.
Matthew Fernandez [Tue, 18 Aug 2020 03:25:06 +0000 (20:25 -0700)]
remove unnecessary lib/label include directory
Matthew Fernandez [Tue, 18 Aug 2020 02:48:46 +0000 (19:48 -0700)]
disambiguate lib/inkpot/*.c #includes
Related to #1785.
Matthew Fernandez [Tue, 18 Aug 2020 02:12:16 +0000 (19:12 -0700)]
disambiguate lib/ingraphs/*.c #includes
Related to #1785.
Matthew Fernandez [Tue, 18 Aug 2020 02:03:40 +0000 (19:03 -0700)]
remove unnecessary lib/ingraphs include directory
Matthew Fernandez [Mon, 17 Aug 2020 04:17:05 +0000 (21:17 -0700)]
disambiguate lib/gvpr/*.c #includes
Related to #1785.
Matthew Fernandez [Mon, 17 Aug 2020 03:44:02 +0000 (20:44 -0700)]
further disambiguate inclusion of colortbl.h
This generated header needs some extra acrobatics. Related to #1785.
Matthew Fernandez [Mon, 17 Aug 2020 01:54:52 +0000 (18:54 -0700)]
remove unnecessary lib/gvpr include directory
Matthew Fernandez [Mon, 17 Aug 2020 00:13:20 +0000 (17:13 -0700)]
disambiguate lib/gvc/*.c #includes
Related to #1242 and #1785.
Matthew Fernandez [Sun, 16 Aug 2020 23:55:55 +0000 (16:55 -0700)]
remove unnecessary lib/gvc include directory
Matthew Fernandez [Sun, 16 Aug 2020 23:19:20 +0000 (16:19 -0700)]
disambiguate lib/glcomp/*.c #includes
Related to #1242 and #1785.
Matthew Fernandez [Sun, 16 Aug 2020 23:07:02 +0000 (16:07 -0700)]
remove unnecessary lib/glcomp include directory
Matthew Fernandez [Sun, 16 Aug 2020 22:35:15 +0000 (15:35 -0700)]
disambiguate lib/fdpgen/*.c #includes
Related to #1785.
Matthew Fernandez [Sun, 16 Aug 2020 22:02:35 +0000 (15:02 -0700)]
remove unnecessary lib/fdpgen include directory
Matthew Fernandez [Sun, 16 Aug 2020 21:30:11 +0000 (14:30 -0700)]
disambiguate lib/expr/*.c #includes
Related to #1785.
Matthew Fernandez [Sun, 16 Aug 2020 21:10:30 +0000 (14:10 -0700)]
remove unnecessary lib/expr include directory
Matthew Fernandez [Sun, 16 Aug 2020 17:59:42 +0000 (10:59 -0700)]
disambiguate lib/edgepaint/*.c #includes
Related to #1785.
Matthew Fernandez [Sun, 16 Aug 2020 17:48:03 +0000 (10:48 -0700)]
remove unnecessary lib/edgepaint include directory
Matthew Fernandez [Sat, 15 Aug 2020 21:41:17 +0000 (14:41 -0700)]
disambiguate lib/dotgen/*.c #includes
Related to #1785.
Matthew Fernandez [Sat, 15 Aug 2020 21:25:40 +0000 (14:25 -0700)]
remove unnecessary lib/dotgen include directory
Matthew Fernandez [Sat, 15 Aug 2020 19:42:14 +0000 (12:42 -0700)]
disambiguate lib/common/*.c #includes
Related to #1242 and #1785.
Matthew Fernandez [Sat, 15 Aug 2020 19:07:44 +0000 (12:07 -0700)]
remove unnecessary lib/common include directory
Matthew Fernandez [Sat, 15 Aug 2020 18:29:10 +0000 (11:29 -0700)]
disambiguate lib/circogen/*.c #includes
Related to #1785.
Matthew Fernandez [Sat, 15 Aug 2020 17:41:16 +0000 (10:41 -0700)]
remove unnecessary lib/circogen include directory
Matthew Fernandez [Sat, 15 Aug 2020 16:46:54 +0000 (09:46 -0700)]
include internal headers with <...> in lib/ast/*.c
It turns out to deal with #1785, we will need to include internal headers this
way as well as external headers.
2ecb837a05be3d69971001708e7acccfd470ad97 should
have gone in this direction to begin with.
Matthew Fernandez [Fri, 14 Aug 2020 03:38:52 +0000 (20:38 -0700)]
make lib/cgraph/*.c #includes unambiguous
Related to #1785.
Matthew Fernandez [Fri, 14 Aug 2020 03:23:15 +0000 (20:23 -0700)]
remove unnecessary cgraph #include path
Matthew Fernandez [Fri, 14 Aug 2020 03:11:39 +0000 (20:11 -0700)]
remove #define EXTERN trick in cgraph
This was designed to allow one declaration of Ag_G_global serve as both
declaration and definition. However, this obscures the actual definition of this
variable from any code browser unable to evaluate macro expansion (e.g. Cscope).
There's no real need for this trick, as we can just define the variable as
normal.
Matthew Fernandez [Thu, 13 Aug 2020 03:07:21 +0000 (20:07 -0700)]
disambiguate lib/cdt/*.c #includes
Related to #1785.
Matthew Fernandez [Thu, 13 Aug 2020 03:00:35 +0000 (20:00 -0700)]
remove unused cdt 'Version'
Matthew Fernandez [Thu, 10 Sep 2020 01:12:06 +0000 (01:12 +0000)]
Merge branch '
3a0128e0 -8665-418d-b92d-
642f114890ce ' into 'master'
remove unused SFIO 'disciplines'
See merge request graphviz/graphviz!1556
Matthew Fernandez [Fri, 4 Sep 2020 00:31:58 +0000 (17:31 -0700)]
remove unused SFIO 'disciplines'
Matthew Fernandez [Tue, 8 Sep 2020 14:56:26 +0000 (14:56 +0000)]
Merge branch '
fcec7644 -4a9d-47cb-ba10-
81305417378d ' into 'master'
remove ad hoc name mangling for lib/expr/grammar.y
See merge request graphviz/graphviz!1553
Matthew Fernandez [Wed, 2 Sep 2020 02:29:09 +0000 (19:29 -0700)]
remove unnecessary intermediate build artifact
This is the equivalent of
c498c4bb3e12e48e3bab9aba8d3162535e163c92 for
exparse.y. Related to #1806.
Matthew Fernandez [Wed, 2 Sep 2020 01:15:07 +0000 (18:15 -0700)]
use Bison's api.prefix instead of name mangling in expr
This is the equivalent of
cc2cb52756f545d6863d6fd801fa23762a81704c . My original
intent was to split the changes that remove the build-time symbol mangling (the
equivalent of
9240da12ab7857975aa34279520f1f6aad113d48 ) into a separate commit.
However, the expression parser does a lot of messy tricks to collide with and
suppress Bison-generated macros. It was simpler to undo all of this in one go
then try to thread this convoluted needle. Related to #1806.
Matthew Fernandez [Wed, 2 Sep 2020 01:23:37 +0000 (18:23 -0700)]
explicitly name output of lib/expr/exparse.y rule
This has no effect right now, but an upcoming change modifies api.prefix which,
without this, would alter the name of the generated parser. Related to #1806.
Matthew Fernandez [Wed, 2 Sep 2020 00:57:05 +0000 (17:57 -0700)]
explicitly drop Yacc, Bison < 3 compatibility in exparse.y
Yacc was already not supported as this parser is using Bison extensions, but
this at least makes explicit what our requirements are. This is the equivalent
of
4a13c9598ad3d950a251e5d3e5be8d05c59c6214 . Related to #1806.
Matthew Fernandez [Wed, 2 Sep 2020 00:53:43 +0000 (17:53 -0700)]
suppress warnings from using Bison extensions in lib/expr/exparse.y
This is the equivalent of
8c099fc032074a0bb5961d67ef4df05ddca7eba4 but for a
different parser. Surprisingly exparse.y was already using Bison extensions, so
this actually suppresses two warnings:
bison -y -dtv ../../lib/expr/exparse.y
../../lib/expr/exparse.y:131.1-7: warning: POSIX Yacc does not support %binary [-Wyacc]
%binary <op> EQ NE
^~~~~~~
../../lib/expr/exparse.y:132.1-7: warning: POSIX Yacc does not support %binary [-Wyacc]
%binary <op> '<' '>' LE GE
^~~~~~~
Related to #1806.
Matthew Fernandez [Wed, 2 Sep 2020 01:47:32 +0000 (18:47 -0700)]
remove incorrect EXSTYPE redefinition
Bison's -pPREFIX -- which, incidentally, this parser is not using -- does *not*
miss YYSTYPE. Upcoming changes expose that this detrimentally interferes with
attempts to properly prefix the expr parser. Related to #1806.
Magnus Jacobsson [Mon, 7 Sep 2020 14:14:01 +0000 (14:14 +0000)]
Merge branch 'remove-warnings-related-to-issue-1800' into 'master'
Remove warnings related to issue 1800
See merge request graphviz/graphviz!1554
Magnus Jacobsson [Tue, 1 Sep 2020 06:37:26 +0000 (08:37 +0200)]
Remove 1 -Wswitch-default warning in attr.c
Magnus Jacobsson [Tue, 1 Sep 2020 06:36:57 +0000 (08:36 +0200)]
Remove 1 -Wunused-but-set-variable warning in attr.c
Magnus Jacobsson [Tue, 1 Sep 2020 06:36:15 +0000 (08:36 +0200)]
Remove 2 -Wsign-conversion warnings in attr.c
Magnus Jacobsson [Tue, 1 Sep 2020 06:35:45 +0000 (08:35 +0200)]
Remove 1 -Wconversion warning in attr.c
Magnus Jacobsson [Tue, 1 Sep 2020 06:34:02 +0000 (08:34 +0200)]
Remove 4 -Wmissing-prototypes warnings in attr.c by adding static
Magnus Jacobsson [Tue, 1 Sep 2020 06:32:16 +0000 (08:32 +0200)]
Remove 2 -Wmissing-field-initializers warnings in attr.c
Magnus Jacobsson [Mon, 31 Aug 2020 18:41:29 +0000 (20:41 +0200)]
Remove 1 -Wswitch-default warning in agdelrec
Magnus Jacobsson [Mon, 31 Aug 2020 18:34:33 +0000 (20:34 +0200)]
Remove 3 -Wunused-parameter warnings in rec.c
Magnus Jacobsson [Mon, 31 Aug 2020 18:28:06 +0000 (20:28 +0200)]
Remove 2 -Wconversion warnings in set_data