Nomis101 [Mon, 19 Aug 2019 19:38:24 +0000 (21:38 +0200)]
make: Add a configure.py option to enable app sandbox.
Currently only implemented for macOS. If it will be implemented on other systems, it can be switched based on the target system, per https://github.com/HandBrake/HandBrake/issues/428#issuecomment-522677832
Damiano Galassi [Wed, 14 Aug 2019 05:21:48 +0000 (07:21 +0200)]
MacGui: fix an exception when reading an HBJob from disk; do not store previews image when scanning the title in the queue; set the log level immediately; improve progress info when the pass number is not set yet.
Damiano Galassi [Tue, 13 Aug 2019 08:27:05 +0000 (10:27 +0200)]
MacGui: convert the last usage of NSDictionary to a proper class, fix external subtitles tracks when sandboxed. Add initial support to the model to store the track title.
sr55 [Mon, 12 Aug 2019 17:56:41 +0000 (18:56 +0100)]
WinGui: Drop the .NET version back to 4.7.1 as 4.8 didn't resolve any issues and isn't as widespread deployed. Installer will still download 4.8 if a suitable version isn't installed.
sr55 [Sat, 3 Aug 2019 19:17:02 +0000 (20:17 +0100)]
WinGui: Add Support for Subtitle Track Naming. Auto-populate the Track name for both Audio/Subtitles if the source track has it available and we support reading it from that type of source file. #855 #2213
John Stebbins [Tue, 6 Aug 2019 20:02:05 +0000 (14:02 -0600)]
ffmpeg: make track names visible regarless of locale
Apple will not show a track name if it doesn't match the current locale
or it's language is not "und". This patch results in the language being
set to "und".
writes 3gpp track names for all language variations in metadata.
when the language is not specified, uses "und" as default.
HandBrake doesn't actually allow multiple track name languages, but one
of the side effects of this patch is to use "und" when the track name
language is unspecified. Before this patch, language specific variants
of metadata were ignored and "eng" was always set as the language.
John Stebbins [Fri, 2 Aug 2019 18:41:13 +0000 (11:41 -0700)]
add subtitle track name read/write
Works similar to audio track names.
If source has a subtitle track name, hb_subtitle_t.name is set.
To set output subtitle track name, set hb_subtitle_config_t.name.
Source track names are available in title returned by hb_title_to_dict
and hb_title_to_json in SubtitleList[].Name
In job dict it is also SubtitleList[].Name
hb_preset_job_init and hb_preset_job_init_json initialize output tracks
with the source track name.
John Stebbins [Tue, 30 Jul 2019 19:51:13 +0000 (12:51 -0700)]
LinGui: change chapter list to GtkListBox
GtkListBox is more flexible than GtkTreeView. It is possible now to
process key press events without creating a custom text cell renderer.
Also due to the way event handling changes in GTK4, it was no longer
even possible to create a custom cell renderer that can process key
events. So this GtkListBox implementation is compatible with GTK4.
John Stebbins [Mon, 29 Jul 2019 22:39:33 +0000 (15:39 -0700)]
LinGui: gtk4 port, minimize appearence of tool bar separators
These are not supposed to be visible, but gtk4 is not respecting the
"draw" property of GtkSeparatorToolItem. When this is fixed, I can
restore proper spacing between "Open Source" and "Add To Queue" toolbar
buttons.
GTK4 added a new widgit GtkPicture that is almost identical to GtkImage.
The main difference appears to be that GtkImage now scales down the size
of the given pixbuf using some undocumented algorithm. It's filling
some of the space available, but not all of it. But it isn't a hard
size limit because making the window bigger continues to make the image
bigger.
GtkPicture shows the pixbuf unscaled as expected. So use GtkPicture for
the preview image :*(
John Stebbins [Mon, 29 Jul 2019 17:02:02 +0000 (10:02 -0700)]
LinGui: disable gtk4 key-press handling for chapter list
gtk4 makes it very difficult to handle key-press in a GtkCellRenderer
I will need to rewrite the capter list as a GtkListBox instead of a
GtkTreeView to re-enable this.
key-press handling is used here to automatically move to the next
chapter when finished editing the current
John Stebbins [Wed, 24 Jul 2019 22:03:22 +0000 (15:03 -0700)]
LinGui: WIP gtk4 support
Known issues and todo:
notebooks, use GtkNotebookPage semantics in ui file
fix keypress delete in queue_list
fix dest_file grab-focus? (highlight of filename for editing)
focus-in/out with GtkEventControllerKey
preview_state_cb how to handle icon-ified preview?
preview_configure_cb, saving preview window size?
accelerator alt-d grab-focus destination
key-press-event in chapter list, ghbcellrenderertext -> GtkEventControllerKey
Why doesn't summary preview image scale correctly?
"System" in about dialog? why is the tab there when "system" prop not set?
GtkSeparatorToolitem seems to ignore "draw" prop?