]>
granicus.if.org Git - taglib/log
Scott Wheeler [Sun, 19 Nov 2017 23:03:52 +0000 (00:03 +0100)]
Update links
Xijian Yan [Mon, 6 Nov 2017 15:48:17 +0000 (23:48 +0800)]
Fix crash when loading an empty mpeg file (#830)
When loading an empty file (empty.txt -> empty.mp3 ), TagLib will crash.
buffer.size() is 0, then buffer.size() - 1 is undefined (unsigned int)
Stephen F. Booth [Sat, 30 Sep 2017 15:15:41 +0000 (10:15 -0500)]
Don't assume TDRC is an instance of TextIdentificationFrame (#831)
If TDRC is encrypted, FrameFactory::createFrame() returns UnknownFrame
which causes problems in rebuildAggregateFrames() when it is assumed
that TDRC is a TextIdentificationFrame
Sergei Trofimovich [Tue, 19 Sep 2017 01:06:55 +0000 (02:06 +0100)]
taglib: fix test build failure on powerpc/c++11 (#834)
powerpc is a platform with 'char' == 'unsigned char'.
As a result '-1' is not expressible in char and build fails as:
```
# '-funsigned-char' to force test build failure on other platforms
$ cmake .. -DBUILD_TESTS=YES -DCMAKE_CXX_FLAGS="-O2 -funsigned-char" -DCMAKE_C_FLAGS="-O2 -funsigned-char"
...
$ make check
tests/test_synchdata.cpp: In member function 'void TestID3v2SynchData::testToUIntBroken()':
tests/test_synchdata.cpp:78:33: error: narrowing conversion of '-1' from 'int' to 'char' inside { } [-Wnarrowing]
char data[] = { 0, 0, 0, -1 };
^
```
The fix is to expliticly cast -1 to 'char'.
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
Tsuda Kageyu [Tue, 13 Jun 2017 08:22:00 +0000 (17:22 +0900)]
Check if mandatory header objects are present when opening ASF files.
Also removes some assignments of "this".
It feels too tricky when it is not absolutely necessary.
Tsuda Kageyu [Tue, 13 Jun 2017 08:01:53 +0000 (17:01 +0900)]
Use a macro to pretend virtual functions.
Tsuda Kageyu [Tue, 13 Jun 2017 06:05:25 +0000 (15:05 +0900)]
Fix some typos in debug messages.
Tsuda Kageyu [Mon, 12 Jun 2017 04:07:21 +0000 (13:07 +0900)]
Update NEWS.
Tsuda Kageyu [Mon, 12 Jun 2017 04:04:15 +0000 (13:04 +0900)]
Merge pull request #799 from TsudaKageyu/filetype-detection
Enable FileRef to detect file types by the actual content of a stream.
Tsuda Kageyu [Fri, 9 Jun 2017 08:52:56 +0000 (17:52 +0900)]
TableOfContentsFrame depends on ByteVectorList.
Tsuda Kageyu [Thu, 8 Jun 2017 23:53:25 +0000 (08:53 +0900)]
Merge pull request #824 from evpobr/fix-createfile2
Fix WinRT configuring
Tsuda Kageyu [Thu, 8 Jun 2017 23:53:10 +0000 (08:53 +0900)]
Merge pull request #823 from TsudaKageyu/isolate-3rdparty-lib
Isolate 3rdparty library for easier maintenance.
evpobr [Thu, 8 Jun 2017 13:59:14 +0000 (18:59 +0500)]
Fix WinRT configuring
Don't rely on _WIN32_WINNT value to enable WinRT support.
if _WIN32_WINNT is not set manually, it is defaulted to SDK version. So
if you use SDK > 8 you cannot use TagLib under Win7 and lower because of
CreateFile2 function dependency.
PLATFORM_WINRT option (OFF by default) was introduced to enable WinRT
build.
Related issues: https://github.com/Microsoft/vcpkg/issues/1240
Tsuda Kageyu [Wed, 7 Jun 2017 03:49:44 +0000 (12:49 +0900)]
Isolate 3rdparty library for easier maintenance.
Tsuda Kageyu [Wed, 7 Jun 2017 03:12:31 +0000 (12:12 +0900)]
Update UTF8-CPP to v2.3.5.
Tsuda Kageyu [Wed, 7 Jun 2017 02:38:46 +0000 (11:38 +0900)]
Remove an unused include directory from taglib/CMakeLists.txt.
Tsuda Kageyu [Tue, 6 Jun 2017 00:17:34 +0000 (09:17 +0900)]
Restore FileRef::create() in order not to change the previous behavior.
Michael Helmling [Mon, 5 Jun 2017 12:49:09 +0000 (14:49 +0200)]
Update INSTALL.md
Added a note that with MS Visual Studio 2017 one can directly open the CMake project.
Stephen F. Booth [Mon, 5 Jun 2017 11:37:12 +0000 (07:37 -0400)]
Merge pull request #821 from supermihi/master
Fix Markdown syntax of INSTALL file and rename it to *.md
Michael Helmling [Mon, 5 Jun 2017 09:09:16 +0000 (11:09 +0200)]
Fix Markdown syntax of INSTALL file and rename it to *.md
This enables proper formatted display of the file on e.g. GitHub, increasing readability.
Tsuda Kageyu [Wed, 31 May 2017 00:41:41 +0000 (09:41 +0900)]
Mention that FileRef::create no longer works.
Tsuda Kageyu [Wed, 31 May 2017 00:28:30 +0000 (09:28 +0900)]
Update NEWS.
Tsuda Kageyu [Wed, 31 May 2017 00:20:27 +0000 (09:20 +0900)]
Merge pull request #818 from LindyBalboa/add_rate_atom_support
Add direct support for "rate" atom
Tsuda Kageyu [Fri, 26 May 2017 07:49:36 +0000 (16:49 +0900)]
Fix memory leaks in a test.
Tsuda Kageyu [Tue, 23 May 2017 08:39:25 +0000 (17:39 +0900)]
Fix MSVC warnings about unreferenced variables.
Tsuda Kageyu [Tue, 23 May 2017 07:52:56 +0000 (16:52 +0900)]
Fix the Travis-CI testing on OS X.
AppleClang 7.3 doesn't get along with CppUnit by default.
Conner R. Phillips [Sat, 22 Apr 2017 05:31:52 +0000 (07:31 +0200)]
Add direct support for "rate" atom
Resolves #817
Tsuda Kageyu [Fri, 24 Feb 2017 06:47:30 +0000 (15:47 +0900)]
Remove an useless UTF-8 BOM.
Tsuda Kageyu [Fri, 24 Feb 2017 06:40:30 +0000 (15:40 +0900)]
Allow SYLT frames to have a timestamp with no text.
Thanks to lemonboy999.
Tsuda Kageyu [Wed, 8 Feb 2017 08:45:46 +0000 (17:45 +0900)]
FilePrivate is responsible to delete a stream pointer instead of File.
Generally, TagLib leaves the Private classes to delete their members.
Tsuda Kageyu [Tue, 7 Feb 2017 13:37:13 +0000 (22:37 +0900)]
Merge branch 'filetype-detection' of https://github.com/TsudaKageyu/taglib into filetype-detection
Tsuda Kageyu [Tue, 7 Feb 2017 13:36:56 +0000 (22:36 +0900)]
Rename the functions 'isValidStream' to 'isSupported'.
The name 'isValidStream' is a little misleading because it doesn't check if the stream is really valid. Additionally, 'isSupported' can be naturally overloaded.
Tsuda Kageyu [Mon, 6 Feb 2017 01:35:49 +0000 (10:35 +0900)]
Remove some redundant code.
Tsuda Kageyu [Mon, 6 Feb 2017 01:06:10 +0000 (10:06 +0900)]
Fix wrong endian of boolean values when saving ASF files.
Tsuda Kageyu [Sat, 4 Feb 2017 14:45:15 +0000 (23:45 +0900)]
Restore the layout of the copyright header of test_fileref.cpp.
Tsuda Kageyu [Fri, 3 Feb 2017 08:52:27 +0000 (17:52 +0900)]
Enable FileRef to detect file types by the actual content of a stream.
FileRef doesn't work with ByteVectorStream as reported at #796, since ByteVectorStream is not associated with a file name and FileRef detects file types based on file extensions.
This commit makes FileRef to work with ByteVectorStream by enabling it to detect file types based on the actual content of a stream.
Tsuda Kageyu [Fri, 3 Feb 2017 16:31:20 +0000 (01:31 +0900)]
Remove obsolete comments.
The bug mentioned in the comments are already fixed.
Scott Wheeler [Fri, 3 Feb 2017 13:56:02 +0000 (13:56 +0000)]
Ignore warnings about OSAtomicIncrement32Barrier
The warnings suggest moving to std::atomic functions, but those are only
available in C++11. It would be possible to switch to the C versions of
those functions, which are now provided in stdatoic.h (in C11), but
let's wait until we actually hit problems with this function and are a
few more OS versions into C11 headers being included by default.
Tsuda Kageyu [Wed, 1 Feb 2017 05:23:03 +0000 (14:23 +0900)]
Avoid searching the same area twice in MPEG::File::previousFrameOffset().
Tsuda Kageyu [Tue, 31 Jan 2017 05:27:23 +0000 (14:27 +0900)]
Add some test cases for invalid UTF-8 sequences.
Tsuda Kageyu [Tue, 31 Jan 2017 05:19:30 +0000 (14:19 +0900)]
Fix and add some test cases for invalid surrogate pairs.
Tsuda Kageyu [Mon, 30 Jan 2017 15:21:41 +0000 (00:21 +0900)]
Update NEWS.
Tsuda Kageyu [Mon, 30 Jan 2017 13:38:08 +0000 (22:38 +0900)]
Remove redundant functions in tstring.cpp.
Two versions of copyFromUTF16() are almost the same.
Tsuda Kageyu [Mon, 30 Jan 2017 07:11:59 +0000 (16:11 +0900)]
Remove function bodies of some non-specialized template functions.
The code won't link when a wrong version is used. It's better than showing a debug message.
Tsuda Kageyu [Mon, 30 Jan 2017 03:56:53 +0000 (12:56 +0900)]
Add a few more test cases for invalid UTF-8 sequences.
Tsuda Kageyu [Mon, 30 Jan 2017 03:54:43 +0000 (12:54 +0900)]
Merge pull request #794 from TsudaKageyu/utf8-library
Replace unicode.h/unicode.cpp by the UTF8-CPP library.
Tsuda Kageyu [Mon, 30 Jan 2017 02:35:39 +0000 (11:35 +0900)]
Check an invalid UTF-8 sequence consists of single char.
Single char can be an invalid UTF sequence. For example, { 0x80 } is invalid.
Tsuda Kageyu [Sun, 29 Jan 2017 15:36:38 +0000 (00:36 +0900)]
Stop assuming that std::wstring has a contiguous and null-terminated buffer.
Tsuda Kageyu [Fri, 27 Jan 2017 16:17:21 +0000 (01:17 +0900)]
Reduce useless memory reallocation in String::upper().
Tsuda Kageyu [Fri, 27 Jan 2017 13:10:02 +0000 (22:10 +0900)]
Remove a duplicate test file.
Tsuda Kageyu [Fri, 27 Jan 2017 06:11:08 +0000 (15:11 +0900)]
Remove some redundant code in tstring.cpp.
Tsuda Kageyu [Fri, 27 Jan 2017 02:44:56 +0000 (11:44 +0900)]
Replace unicode.h/unicode.cpp by the UTF8-CPP library.
unicode.h/unicode.cpp are no longer maintained and incompatible with Debian's guideline.
UTF8-CPP is maintained on GitHub and published under the Boost Software License which is compatible with either LGPL or MPL and should go along with Debian's guideline.
Tsuda Kageyu [Thu, 26 Jan 2017 08:33:54 +0000 (17:33 +0900)]
Add a test for unpaired surrogate characters in a UTF-16 string.
Tsuda Kageyu [Sat, 21 Jan 2017 15:43:32 +0000 (00:43 +0900)]
Remove some redundant code.
TagUnion::access() does the same thing as FLAC::File::ID3v2Tag().
Tsuda Kageyu [Sat, 21 Jan 2017 10:10:32 +0000 (19:10 +0900)]
Prefer isEmpty()/empty() to size() == 0.
Tsuda Kageyu [Sat, 21 Jan 2017 02:13:49 +0000 (11:13 +0900)]
Revert useless changes accidentally committed.
Tsuda Kageyu [Sat, 21 Jan 2017 02:09:05 +0000 (11:09 +0900)]
Add missing consts.
Tsuda Kageyu [Fri, 20 Jan 2017 16:34:50 +0000 (01:34 +0900)]
Combine two internal functions which are always used together.
Tsuda Kageyu [Fri, 20 Jan 2017 13:38:25 +0000 (22:38 +0900)]
Ignore fake MPEG frame headers when seeking them.
Tsuda Kageyu [Fri, 20 Jan 2017 12:14:38 +0000 (21:14 +0900)]
Efficient lookup for an ID3v2 tag in MPEG files with garbage.
This looks for an ID3v2 tag until reaching the first valid MPEG frame in O(n) time.
Tsuda Kageyu [Sun, 15 Jan 2017 16:14:35 +0000 (01:14 +0900)]
Update NEWS.
Tsuda Kageyu [Sun, 15 Jan 2017 16:12:07 +0000 (01:12 +0900)]
Merge pull request #791 from TsudaKageyu/flac-empty-seektable
Be tolerant of empty FLAC seektable blocks.
Tsuda Kageyu [Sun, 15 Jan 2017 16:05:30 +0000 (01:05 +0900)]
Initialize d-pointers in class member initializer list.
Tsuda Kageyu [Sun, 15 Jan 2017 15:59:12 +0000 (00:59 +0900)]
Always use parentheses with new. It's a bit safer.
Tsuda Kageyu [Sat, 14 Jan 2017 14:29:46 +0000 (23:29 +0900)]
Initialize all the data members of ASF::Attribute.
Tsuda Kageyu [Sat, 7 Jan 2017 17:11:57 +0000 (02:11 +0900)]
Be tolerant of empty FLAC seektable blocks.
Tsuda Kageyu [Sat, 7 Jan 2017 16:43:04 +0000 (01:43 +0900)]
Remove some TODO comments which are no longer necessary.
Michael Helmling [Fri, 6 Jan 2017 08:08:02 +0000 (09:08 +0100)]
Fix #789 (typo in member doc)
Stephen F. Booth [Thu, 22 Dec 2016 17:17:12 +0000 (12:17 -0500)]
Merge pull request #787 from rshanmu/master
Renamed unsupported-extension.xxx and modified test
Ramesh Shanmugasundaram [Thu, 22 Dec 2016 15:13:39 +0000 (15:13 +0000)]
Renamed unsupported-extension.xxx and modified test
The file name unsupported-extension.xxx causes issue when unpacked
taglib-xxx.gz over an NFS partition. The file extension ".xxx" is the
one NFS uses for its own purpose and hence it will not allow creation
of this file.
Hence renamed the file and modified the test cases that checks for this
file.
Signed-off-by: Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>
Tsuda Kageyu [Tue, 20 Dec 2016 03:06:21 +0000 (12:06 +0900)]
Remove the CMake check for Boost I missed out on.
Tsuda Kageyu [Tue, 20 Dec 2016 02:54:06 +0000 (11:54 +0900)]
Remove all the optional dependencies on Boost.
Tsuda Kageyu [Tue, 20 Dec 2016 02:48:14 +0000 (11:48 +0900)]
Fix the CMake check for std::atomic_int.
std::atomic_int of Visual C++ 2012 cannot be constructed with integer.
Tsuda Kageyu [Mon, 19 Dec 2016 01:37:10 +0000 (10:37 +0900)]
Safer conversion of boolean values in ASF attributes.
Technically, boolean values in Extended Content Description Object is not necessarily be 0 or 1.
Tsuda Kageyu [Fri, 9 Dec 2016 00:56:37 +0000 (09:56 +0900)]
Make use of increment/decrement operators of std::atomic.
Tsuda Kageyu [Fri, 9 Dec 2016 00:42:29 +0000 (09:42 +0900)]
Remove optional dependencies on Boost's dynamic libraries.
Using precompiled Boost libraries can lead to depending on external dynamic libraries.
Tsuda Kageyu [Fri, 9 Dec 2016 00:00:04 +0000 (09:00 +0900)]
Merge pull request #784 from haoxi911/master
Fix #667: Compiled TagLib framework for OS X fails at codesign.
Hao Xi [Thu, 8 Dec 2016 04:53:40 +0000 (12:53 +0800)]
Fix #667: Compiled TagLib framework for OS X fails at codesign.
Tsuda Kageyu [Fri, 2 Dec 2016 07:31:27 +0000 (16:31 +0900)]
Rewrite ByteVector::replace() to run in O(n) time.
Tsuda Kageyu [Mon, 5 Dec 2016 01:15:26 +0000 (10:15 +0900)]
Add a test to check if ByteVector is detached correctly when being replaced.
Tsuda Kageyu [Fri, 2 Dec 2016 08:26:43 +0000 (17:26 +0900)]
#include guards in CMake generated headers.
Tsuda Kageyu [Thu, 1 Dec 2016 06:25:30 +0000 (15:25 +0900)]
Update NEWS.
Tsuda Kageyu [Thu, 1 Dec 2016 02:32:01 +0000 (11:32 +0900)]
Fix possible Ogg packet losses.
Tsuda Kageyu [Thu, 1 Dec 2016 01:50:30 +0000 (10:50 +0900)]
Prevent the segment table of Ogg pages from exceeding the size limit.
Tsuda Kageyu [Tue, 29 Nov 2016 05:58:39 +0000 (14:58 +0900)]
Remove Utils::floatByteOrder() and use systemByteOrder() instead.
We can safely assume that the integer and float byte orders are the same on IEEE754 compliant systems.
Tsuda Kageyu [Tue, 29 Nov 2016 01:53:33 +0000 (10:53 +0900)]
Add a test for #743/#779.
Tsuda Kageyu [Tue, 29 Nov 2016 01:38:11 +0000 (10:38 +0900)]
Small fix in style.
Tsuda Kageyu [Mon, 28 Nov 2016 12:03:39 +0000 (21:03 +0900)]
Merge pull request #779 from supermihi/master
Fixes #743 by not overwriting existing Xiph comment in FLAC::File::save
Michael Helmling [Sun, 27 Nov 2016 18:17:13 +0000 (19:17 +0100)]
Fixes #743 by not overwriting existing Xiph comment in FLAC::File::save
Tsuda Kageyu [Sat, 26 Nov 2016 04:05:14 +0000 (13:05 +0900)]
A bit more tolerant check to return itself in String::substr().
Stephen F. Booth [Fri, 25 Nov 2016 21:38:32 +0000 (16:38 -0500)]
Merge pull request #778 from martin-flaska/optimization
String::substr optimization
Martin Flaska [Fri, 25 Nov 2016 14:32:26 +0000 (15:32 +0100)]
tstring: String::substr optimization when returning itself as a substring
Use copy ctor to return in a case whole string is being returned.
The intention was to optimize String::stripWhiteSpace for no-strip case
(without any leading or trailing white space removal).
copyFromUTF16 was used in any case previously and allocated duplicate
buffer for the same string - no implicit sharing.
Signed-off-by: Martin Flaska <martin.flaska@legrand.us>
Martin Flaska [Fri, 25 Nov 2016 11:58:25 +0000 (12:58 +0100)]
test_string: Make 'stripWhiteSpace' test more complex
No string without leading/trailing spaces was used in the test.
Signed-off-by: Martin Flaska <martin.flaska@legrand.us>
Tsuda Kageyu [Thu, 24 Nov 2016 05:45:22 +0000 (14:45 +0900)]
Suppress MSVC warnings in test.
Stephen F. Booth [Thu, 24 Nov 2016 04:31:49 +0000 (23:31 -0500)]
Merge pull request #776 from mathbunnyru/small_improvements
Small improvements
mathbunnyru [Wed, 23 Nov 2016 23:02:38 +0000 (02:02 +0300)]
Small fixes
mathbunnyru [Mon, 21 Nov 2016 22:10:28 +0000 (01:10 +0300)]
Increment fixes
Tsuda Kageyu [Fri, 18 Nov 2016 04:55:43 +0000 (13:55 +0900)]
Update NEWS.
Tsuda Kageyu [Fri, 18 Nov 2016 04:52:38 +0000 (13:52 +0900)]
Merge pull request #772 from TsudaKageyu/vorbis-fields
Fix handling of lowercase 'metadata_block_picture' field
Tsuda Kageyu [Thu, 10 Nov 2016 15:07:32 +0000 (00:07 +0900)]
Fix handling of lowercase 'metadata_block_picture' fields in Vorbis comments.
Also refactored some redundant code for parsing pictures.