Neil Conway [Tue, 5 Oct 2004 00:12:49 +0000 (00:12 +0000)]
License cleanup: crypt.c and qsort.c to latest NetBSD CVS sources, to
pickup license clarification (3-clause BSD is now used). Add license
terms to memcmp.c (also from NetBSD), which previously had none.
Finally, pickup an upstream fix to crypt.c (const-ify some arrays).
Tom Lane [Mon, 4 Oct 2004 22:49:59 +0000 (22:49 +0000)]
Remove arithmetic operators on the 1-byte-char datatype, as per proposals
made several times in the past. Add coercion functions between "char"
and integer so that a workaround is possible if needed.
Tom Lane [Mon, 4 Oct 2004 22:13:14 +0000 (22:13 +0000)]
Correct the volatility labeling of ten timestamp-related functions,
per discussion from Friday. initdb not forced in this commit but I intend
to do that later.
Tom Lane [Mon, 4 Oct 2004 21:52:15 +0000 (21:52 +0000)]
PortalRun must guard against the possibility that the portal it's
running contains VACUUM or a similar command that will internally start
and commit transactions. In such a case, the original caller values of
CurrentMemoryContext and CurrentResourceOwner will point to objects that
will be destroyed by the internal commit. We must restore these pointers
to point to the newly-manufactured transaction context and resource owner,
rather than possibly pointing to deleted memory.
Also tweak xact.c so that AbortTransaction and AbortSubTransaction
forcibly restore a sane value for CurrentResourceOwner, much as they
have always done for CurrentMemoryContext. I'm not certain this is
necessary but I'm feeling paranoid today.
Responds to Sean Chittenden's bug report of 4-Oct.
Tom Lane [Mon, 4 Oct 2004 14:42:48 +0000 (14:42 +0000)]
Detect overflow in integer arithmetic operators (integer, smallint, and
bigint variants). Clean up some inconsistencies in error message wording.
Fix scanint8 to allow trailing whitespace in INT64_MIN case. Update
int8-exp-three-digits.out, which seems to have been ignored by the last
couple of people to modify the int8 regression test, and remove
int8-exp-three-digits-win32.out which is thereby exposed as redundant.
Bruce Momjian [Mon, 4 Oct 2004 13:43:59 +0000 (13:43 +0000)]
Make libpgport be front-end only and make libpgport_srv be a backend
library that uses palloc, ereport, etc. This simplifies the makefiles
for client applications.
Tom Lane [Sat, 2 Oct 2004 22:39:49 +0000 (22:39 +0000)]
Clean up handling of inherited-table update queries, per bug report
from Sebastian Böck. The fix involves being more consistent about
when rangetable entries are copied or modified. Someday we really
need to fix this stuff to not scribble on its input data structures
in the first place...
Tom Lane [Fri, 1 Oct 2004 21:03:42 +0000 (21:03 +0000)]
Convert pg_stat_get_backend_idset to use the existing SRF support.
This seems the cleanest way of fixing its lack of a shutdown callback,
which was preventing it from working correctly in a query that didn't
run it to completion. Per bug report from Szima GÄbor.
Tom Lane [Fri, 1 Oct 2004 18:30:25 +0000 (18:30 +0000)]
Adjust postmaster to recognize that a lockfile containing its parent's PID
must be stale. Tweak example startup scripts to not use pg_ctl but launch
the postmaster directly, thereby ensuring that only the postmaster's direct
parent shell will be a postgres-owned process. In combination these should
fix the longstanding problem of the postmaster sometimes refusing to start
during reboot because it thinks the old lockfile is not stale.
Tom Lane [Fri, 1 Oct 2004 17:11:50 +0000 (17:11 +0000)]
Fallout from changing index locking rules: we can reduce the strength
of locking used by REINDEX. REINDEX needs only ShareLock on the parent
table, same as CREATE INDEX, plus an exclusive lock on the specific index
being processed.
Tom Lane [Fri, 1 Oct 2004 16:40:05 +0000 (16:40 +0000)]
Code review for NOWAIT patch: downgrade NOWAIT from fully reserved keyword
to unreserved keyword, use ereport not elog, assign a separate error code
for 'could not obtain lock' so that applications will be able to detect
that case cleanly.
Neil Conway [Fri, 1 Oct 2004 02:00:44 +0000 (02:00 +0000)]
Remove more traces of libpgtcl from the source tree. Also, make some
semi-related SGML cleanup. Original patch from ljb220@mindspring.com,
additional cleanup by Neil Conway.
Tom Lane [Thu, 30 Sep 2004 23:21:26 +0000 (23:21 +0000)]
Adjust index locking rules as per my proposal of earlier today. You
now are supposed to take some kind of lock on an index whenever you
are going to access the index contents, rather than relying only on a
lock on the parent table.
Tom Lane [Thu, 30 Sep 2004 21:12:45 +0000 (21:12 +0000)]
Add variant regression file to handle machines that convert -1e-700
to minus zero rather than zero; this includes at least Mac OS X 10.3
and Solaris 2.8.
Neil Conway [Thu, 30 Sep 2004 10:30:10 +0000 (10:30 +0000)]
Add a note suggesting that users should use the newer version of pg_dump
to perform upgrades, and cleanup some nearby text. Patch from Robert
Treat, editorializing by Neil Conway.
Tom Lane [Thu, 30 Sep 2004 00:24:27 +0000 (00:24 +0000)]
Come to think of it, functions in FROM have the same syntactic restriction
as CREATE INDEX did, and can be fixed the same way, for another small
improvement in usability and reduction in grammar size.
Tom Lane [Wed, 29 Sep 2004 23:39:20 +0000 (23:39 +0000)]
Split out everything that looks like a function call from c_expr into
a separate production func_expr. This allows us to accept all these
variants in the backwards-compatible syntax for creating a functional
index; which beats documenting exactly which things work and which don't.
Interestingly, it also seems to make the generated state machine a little
bit smaller.
Tom Lane [Tue, 28 Sep 2004 20:46:37 +0000 (20:46 +0000)]
Arrange to preallocate all required space for the buffer and FSM hash
tables in shared memory. This ensures that overflow of the lock table
creates no long-lasting problems. Per discussion with Merlin Moncure.
Tom Lane [Tue, 28 Sep 2004 00:49:04 +0000 (00:49 +0000)]
Remove duplicate PQclear(res) operations leading to double free() and
subsequent core dump. It looks like at one time DBLINK_RES_ERROR_AS_NOTICE
didn't include a PQclear, but now it does and so these other ones are
duplicate.
Bruce Momjian [Mon, 27 Sep 2004 14:15:49 +0000 (14:15 +0000)]
Remove completed items:
< Last updated: Sat Sep 25 21:33:44 EDT 2004
> Last updated: Mon Sep 27 10:15:31 EDT 2004
13,19d12
< Remove items before beta?
<
< Urgent
< ======
<
< * -Point-in-time data recovery using backup and write-ahead log
< * -Create native Win32 port
25d17
< * -Incremental backups
28d19
< * -Allow configuration files to be specified in a different directory
32,34d22
< * -Add the concept of dataspaces/tablespaces (Gavin)
< * -Allow logging of only data definition(DDL), or DDL and modification statements
< * -Allow log lines to include session-level information, like database and user
54d41
< * -Allow external interfaces to extend the GUC variable set 126d112
< * -Change factorial to return a numeric (Gavin)
141,142d126
< * -Allow pg_dump to dump sequences using NO_MAXVALUE and NO_MINVALUE
< * -Prevent whole-row references from leaking memory, e.g. SELECT COUNT(tab.*) 147d130
< * -Make LENGTH() of CHAR() not count trailing spaces 150d132
< * -Support composite types as table columns
198,200d179
< * -Prevent mismatch of frontend/backend encodings from converting bytea
< data from being interpreted as encoded strings
< * -Fix upper()/lower() to work for multibyte encodings 217d195
< * -Order duplicate index entries on creation by ctid for faster heap lookups 242d219
< * -Be smarter about insertion of already-ordered data into btree index
265,266d241
< * -Allow SELECT * FROM tab WHERE int2col = 4 to use int2col index, int8,
< float4, numeric/decimal too 282d256
< * -Allow command blocks to ignore certain types of errors
302,303d275
< * -Allow savepoints / nested transactions (Alvaro)
< * -Use nested transactions to prevent syntax errors from aborting a transaction
306,307d277
< * -Prevent COMMENT ON DATABASE from using a database name
< * -Add NO WAIT LOCKs
325,326d294
< * -COMMENT ON [ CAST | CONVERSION | OPERATOR CLASS | LARGE OBJECT | LANGUAGE ]
< (Christopher) 334d301
< * -Allow more ISOLATION LEVELS to be accepted 347d313
< * -Add GUC setting to make created tables default to WITHOUT OIDS
365,369d330
< o -ALTER TABLE ADD COLUMN does not honor DEFAULT and non-CHECK CONSTRAINT
< o -ALTER TABLE ADD COLUMN column DEFAULT should fill existing
< rows with DEFAULT value
< o -ALTER TABLE ADD COLUMN column SERIAL doesn't create sequence because
< of the item above
371,373d331
< o -Allow ALTER TABLE to modify column lengths and change to binary
< compatible types
< o -Add ALTER DATABASE ... OWNER TO newowner
390,393d347
< o -Add ALTER DOMAIN, AGGREGATE, CONVERSION ... OWNER TO
< o -Add ALTER SEQUENCE ... OWNER TO
< o -Add ALTER INDEX that works just like ALTER TABLE already does
< on an index 404d357
< o -Add ALTER TABLE table SET WITHOUT CLUSTER (Christopher) 411d363
< o -Allow dump/load of CSV format 464d415
< o -Allow Java server-side programming 473d423
< o -Allow PL/pgSQL parameters to be specified by name and type during definition
493,495d442
< * -Allow psql \du to show users, and add \dg for groups
< * -Have psql \dn show only visible temp schemas using current_schemas()
< * -Have psql '\i ~/<tab><tab>' actually load files it displays from home dir
509,511d455
< o -Allow pg_dump to dump CREATE CONVERSION (Christopher)
< o -Make pg_restore continue after errors, so it acts more like pg_dump
< scripts 545d488
< o -Implement SET DESCRIPTOR
592,596d534
< * -Have AFTER triggers execute after the appropriate SQL statement in a
< function, not at the end of the function
< * -Print table names with constraint names in error messages, or make constraint
< names unique within a schema
< * -Issue NOTICE if foreign key data requires costly test to match primary key
614,615d551
< * -Use dependency information to dump data in proper order
< * -Have pg_dump -c clear the database using dependency information
694,695d629
< * -Provide automatic running of vacuum in the background in backend
< rather than in /contrib (Matthew) 828d761
< * -Use background process to write dirty shared buffers to disk 843d775
< * -Change representation of whole-tuple parameters to functions
850,852d781
< * -Add checks for fclose() failure (Tom)
< * -Change CVS ID to PostgreSQL
< * -Exit postmaster if postgresql.conf can not be opened
Neil Conway [Mon, 27 Sep 2004 04:12:03 +0000 (04:12 +0000)]
A few minor list-related cleanups:
(1) Replace while loop with the new forboth() construct in
parser/analyze.c
(2) Replace lcons() with lappend() in SearchCatCacheList(). Since these
now have the same performance, there is no reason to prefer lcons() in
this case, and using lappend() leads to cleaner code.
(3) Improve the name of the second parameter to for_each_cell()
Neil Conway [Mon, 27 Sep 2004 04:01:23 +0000 (04:01 +0000)]
Code cleanup: don't bother casting the argument to pfree() to void *
from another pointer type. Per C89, this is unnecessary, and it is common
practice throughout the rest of the tree anyway.
Tom Lane [Mon, 27 Sep 2004 01:39:02 +0000 (01:39 +0000)]
Rewrite ReadArrayStr() to avoid O(N^2) behavior on large strings,
and hopefully improve code clarity while at it. One intentional
semantics change: a backslashed space will not be treated as removable
trailing whitespace, as the prior coding would do. ISTM that if it
wouldn't be considered removable leading whitespace, it shouldn't be
stripped at the end either.
Bruce Momjian [Sun, 26 Sep 2004 02:14:47 +0000 (02:14 +0000)]
Here is a patch that adds the version info from libpq.rc to the DLL
build in mingw. The MSVC build already did this, but it was not linked
into the mingw one.
This is not the same as the versioninfo patch that's in the queue.
Please apply this one before beta-3 if at all possible.
Tom Lane [Sun, 26 Sep 2004 00:26:28 +0000 (00:26 +0000)]
Repair bug that would allow libpq to think a command had succeeded when
it really hadn't, due to double output of previous command's response.
Fix prevents recursive entry to libpq routines. Found by Jan Wieck.
Tom Lane [Fri, 24 Sep 2004 19:43:03 +0000 (19:43 +0000)]
GUC assign hooks that look at external state in deciding whether a
setting is valid must ignore that state and permit the assignment anyway
when source is PGC_S_OVERRIDE. Otherwise they may disallow a rollback
at transaction abort, which is The Wrong Thing. Per example from
Michael Fuhr 12-Sep-04.
Neil Conway [Fri, 24 Sep 2004 06:29:07 +0000 (06:29 +0000)]
Cleanup some ancient Ultrix / Alpha code in main() that is intended to
modify how unaligned memory accesses are dealt with. Document that this
is really what is going on, and merge the NOFIXADE and NOPRINTADE code
paths.
Neil Conway [Fri, 24 Sep 2004 01:36:37 +0000 (01:36 +0000)]
ExecProcAppend() wasn't called ExecAppend() because the latter name was
formerly used in execMain. Since that is no longer the case, this patch
renames ExecProcAppend() to ExecAppend() for the sake of consistency.
Tom Lane [Thu, 23 Sep 2004 20:27:50 +0000 (20:27 +0000)]
If we're going to print unrecognized result codes from SSL_get_error
in open_client_SSL, surely we should do it everywhere. Also make
message formatting conform to style guide.
Bruce Momjian [Thu, 23 Sep 2004 13:31:09 +0000 (13:31 +0000)]
This patch attempts to outline the supported level of SSL within libpq.
I haven't mentioned any of
~/.postgresql/{root.crt,postgresql.crt,postresql.key} even though they
are checked for in the code, since they do not appear to be supported. I
base this on discussions in pgsql-hackers.
Bruce Momjian [Thu, 23 Sep 2004 13:20:45 +0000 (13:20 +0000)]
This patch logs the error code in the default case, so that the user
stands a chance of looking it up. "Unrecognised error" is always
disheartening. :-)