]> granicus.if.org Git - strace/log
strace
8 years agoImplement decoding of preadv2 and pwritev2 syscalls
Dmitry V. Levin [Wed, 11 May 2016 00:42:10 +0000 (00:42 +0000)]
Implement decoding of preadv2 and pwritev2 syscalls

* io.c: Include "xlat/rwf_flags.h".
(do_preadv, do_pwritev, SYS_FUNC(preadv2), SYS_FUNC(pwritev2)):
New functions.
(SYS_FUNC(preadv)): Use do_preadv.
(SYS_FUNC(pwritev)): Use do_pwritev.
* linux/32/syscallent.h (preadv2, pwritev2): New entries.
* linux/64/syscallent.h: Likewise.
* linux/arm/syscallent.h: Likewise.
* linux/hppa/syscallent.h: Likewise.
* linux/i386/syscallent.h: Likewise.
* linux/ia64/syscallent.h: Likewise.
* linux/m68k/syscallent.h: Likewise.
* linux/mips/syscallent-n32.h: Likewise.
* linux/mips/syscallent-n64.h: Likewise.
* linux/mips/syscallent-o32.h: Likewise.
* linux/powerpc/syscallent.h: Likewise.
* linux/powerpc64/syscallent.h: Likewise.
* linux/s390/syscallent.h: Likewise.
* linux/s390x/syscallent.h: Likewise.
* linux/sparc/syscallent.h: Likewise.
* linux/sparc64/syscallent.h: Likewise.
* linux/x32/syscallent.h: Likewise.
* linux/x86_64/syscallent.h: Likewise.
* syscall.c (dumpio): Handle SEN_preadv2 and SEN_pwritev2.
* xlat/rwf_flags.in: New file.
* NEWS: Mention parsers of new syscalls.

8 years agotests: extend test coverage of xattr family syscalls
Dmitry V. Levin [Tue, 10 May 2016 18:18:32 +0000 (18:18 +0000)]
tests: extend test coverage of xattr family syscalls

* tests/xattr.c: Check decoding of all xattr family syscalls.
* tests/xattr.test: Use run_strace_match_diff.
* tests/xattr.expected: Remove.
* tests/Makefile.am (EXTRA_DIST): Remove it.

8 years agotests: add print_quoted_memory function to libtests
Dmitry V. Levin [Tue, 10 May 2016 22:05:53 +0000 (22:05 +0000)]
tests: add print_quoted_memory function to libtests

* tests/print_quoted_string.c (print_quoted_memory): New function.
(print_quoted_string): Use it.
* tests/tests.h (print_quoted_memory): New prototype.

8 years agoFix corner cases of xattr family syscalls decoding
Dmitry V. Levin [Tue, 10 May 2016 18:52:06 +0000 (18:52 +0000)]
Fix corner cases of xattr family syscalls decoding

* xattr.c (print_xattr_val): Do not take insize into account, print it
as unsigned long.
Do not decode xattr values of size larger than XATTR_SIZE_MAX.
Use static buffer for fetching xattr values.
(print_xattr_list): Do not decode string when size is zero.

8 years agouserfaultfd: Add ioctl tests
Dr. David Alan Gilbert [Tue, 10 May 2016 10:49:03 +0000 (11:49 +0100)]
userfaultfd: Add ioctl tests

* tests/ioctl_uffdio.c: New file.
* tests/ioctl_uffdio.test: New test.
* tests/.gitignore: Add ioctl_uffdio.
* tests/Makefile.am (check_PROGRAMS):  Likewise.
(DECODER_TESTS): Add ioctl_uffdio.test.

8 years agoDecode UFFDIO_* ioctls
Dr. David Alan Gilbert [Tue, 10 May 2016 10:49:02 +0000 (11:49 +0100)]
Decode UFFDIO_* ioctls

Decode the ioctls associated with the userfaultfd fd.
Note that they tend to read from and also return result in it's data
structure.

* configure.ac (AC_CHECK_HEADERS): Add linux/userfaultfd.h.
* userfaultfd.c [HAVE_LINUX_USERFAULTFD_H]: Add ioctl decoder.
* defs.h (uffdio_ioctl): New prototype.
* ioctl.c (ioctl_decode) [HAVE_LINUX_USERFAULTFD_H]: Wire in
uffdio_ioctl.
* xlat/uffd_*.in: Create flag xlat for all the IOCTLs.

8 years agoUpdate AX_CODE_COVERAGE
Dmitry V. Levin [Tue, 10 May 2016 02:08:56 +0000 (02:08 +0000)]
Update AX_CODE_COVERAGE

* m4/ax_code_coverage.m4: Update to serial 16.
* Makefile.am (CODE_COVERAGE_LCOV_OPTIONS): Remove.
(CODE_COVERAGE_GENHTML_OPTIONS): Update, add prefix.
(CODE_COVERAGE_BRANCH_COVERAGE): Set to 1.

8 years agostrace-ff.test: fix race condition
Dmitry V. Levin [Tue, 10 May 2016 09:29:11 +0000 (09:29 +0000)]
strace-ff.test: fix race condition

* tests/strace-ff.test: Wait for completion of PR_SET_PTRACER command.

8 years agotests/epoll_pwait.c: fix for x32
Dmitry V. Levin [Tue, 10 May 2016 01:10:51 +0000 (01:10 +0000)]
tests/epoll_pwait.c: fix for x32

* tests/epoll_pwait.c (main): Explicitly cast last syscall argument
to kernel_ulong_t.

8 years agostrace-S.test: check "-S name"
Dmitry V. Levin [Tue, 10 May 2016 00:03:59 +0000 (00:03 +0000)]
strace-S.test: check "-S name"

* tests/strace-S.test: Add a check for "-c -S name" output.

8 years agoFix NULL dereference in "-S name" when syscall table has holes
Dmitry V. Levin [Tue, 10 May 2016 00:16:20 +0000 (00:16 +0000)]
Fix NULL dereference in "-S name" when syscall table has holes

* count.c (syscall_cmp): Do not pass NULL to strcmp.

8 years agostrace-S.test: cleanup
Dmitry V. Levin [Mon, 9 May 2016 23:42:28 +0000 (23:42 +0000)]
strace-S.test: cleanup

* tests/strace-S.test: Rewrite using sed.

8 years agotests: add strace-S.test
Fei Jie [Thu, 5 May 2016 07:19:51 +0000 (15:19 +0800)]
tests: add strace-S.test

* tests/strace-S.test: New test.
* tests/Makefile.am (MISC_TESTS): Add it.

8 years agostrace-ff.test: check that -ff does not create unexpected output files
Dmitry V. Levin [Mon, 9 May 2016 23:15:52 +0000 (23:15 +0000)]
strace-ff.test: check that -ff does not create unexpected output files

* tests/strace-ff.expected: New file.
* tests/Makefile.am (EXTRA_DIST): Add it.
* tests/strace-ff.test: Use it.  Check that no other output files
have been created.

8 years agotests: add strace-ff.test
Fei Jie [Mon, 9 May 2016 06:19:56 +0000 (14:19 +0800)]
tests: add strace-ff.test

* tests/strace-ff.test: New test.
* tests/Makefile.am (MISC_TESTS): Add it.

8 years agostrace-V.test: cleanup
Dmitry V. Levin [Mon, 9 May 2016 23:19:37 +0000 (23:19 +0000)]
strace-V.test: cleanup

* tests/strace-V.test: Move config.h parser to a function.
Rename $OUT to $EXP, swap arguments passed to match_diff.

8 years agotests: add strace-V.test
Fei Jie [Mon, 9 May 2016 06:19:55 +0000 (14:19 +0800)]
tests: add strace-V.test

* tests/strace-V.test: New test.
* tests/Makefile.am (MISC_TESTS): Add it.

8 years agotests: check decoding of epoll_pwait syscall
Dmitry V. Levin [Mon, 9 May 2016 22:11:24 +0000 (22:11 +0000)]
tests: check decoding of epoll_pwait syscall

* tests/epoll_pwait.c: New file.
* tests/epoll_pwait.test: New test.
* tests/.gitignore: Add epoll_pwait.
* tests/Makefile.am (check_PROGRAMS): Likewise.
(DECODER_TESTS): Add epoll_pwait.test.

8 years agoAssume that sys/epoll.h exists
Dmitry V. Levin [Mon, 9 May 2016 21:46:17 +0000 (21:46 +0000)]
Assume that sys/epoll.h exists

This header file was added in glibc-2.3.2,
so it's safe to assume its availability.

* configure.ac (AC_CHECK_HEADERS): Remove sys/epoll.h.
* epoll.c: Include <sys/epoll.h> unconditionally.
Compile [HAVE_SYS_EPOLL_H] code unconditionally.
* tests/epoll_ctl.c: Do not check for HAVE_SYS_EPOLL_H.
* tests/epoll_wait.c: Likewise.

8 years agoFactorize send_query functions
Fabien Siron [Sun, 8 May 2016 10:45:52 +0000 (10:45 +0000)]
Factorize send_query functions

* socketutils.c (send_query): New function.
(inet_send_query, unix_send_query): Use it.

8 years agotests: relax timings
Dmitry V. Levin [Sun, 8 May 2016 00:00:18 +0000 (00:00 +0000)]
tests: relax timings

Allow nanosleep(2) to spend 10% more time to make the test suite
more reliable on slow systems.

* tests/count.test: Treat 1.1 seconds as valid output.
* tests/strace-T.expected: Likewise.
* tests/strace-r.expected: Likewise.

8 years agotests/attach-f-p.c: increase timeouts
Dmitry V. Levin [Sat, 7 May 2016 23:51:47 +0000 (23:51 +0000)]
tests/attach-f-p.c: increase timeouts

Increase timeouts to make the test more reliable on slow systems.

* tests/attach-f-p.c (its): Increase timeouts to 1, 2, and 3 seconds,
respectively.

8 years agoRemove unused functions
Dmitry V. Levin [Sat, 7 May 2016 23:17:29 +0000 (23:17 +0000)]
Remove unused functions

* defs.h (umove_ulong_or_printaddr, umove_ulong_array_or_printaddr):
Remove.
* util.c (umove_ulong_or_printaddr, umove_ulong_array_or_printaddr):
Likewise.

8 years agov4l2.c: use print_array function
Dmitry V. Levin [Sat, 7 May 2016 23:15:36 +0000 (23:15 +0000)]
v4l2.c: use print_array function

* v4l2.c (print_v4l2_ext_control, umoven_or_printaddr_ignore_syserror):
New functions.
(print_v4l2_ext_controls): Use them via print_array.

8 years agouid.c: use print_array function
Dmitry V. Levin [Sat, 7 May 2016 23:14:24 +0000 (23:14 +0000)]
uid.c: use print_array function

* uid.c (print_gid): New function.
(print_groups): Use it via print_array.

8 years agoseccomp.c: use print_array function
Dmitry V. Levin [Sat, 7 May 2016 23:11:52 +0000 (23:11 +0000)]
seccomp.c: use print_array function

* seccomp.c (decode_filter, decode_seccomp_fprog): Remove.
(print_bpf_filter): New function.
(print_seccomp_fprog): Use it via print_array.
* tests/seccomp-filter-v.c (main): Update.

8 years agoscsi.c: use print_array function
Dmitry V. Levin [Sat, 7 May 2016 23:10:50 +0000 (23:10 +0000)]
scsi.c: use print_array function

* scsi.c (print_uchar): New function.
(print_sg_io_buffer): Use it via print_array.

8 years agopoll.c: use print_array function
Dmitry V. Levin [Sat, 7 May 2016 23:09:09 +0000 (23:09 +0000)]
poll.c: use print_array function

* poll.c (print_pollfd): Change for use as print_array callback.
(decode_poll_entering): Use print_array.
* tests/poll.c: Update.
* tests/poll.test: Update.

8 years agonuma.c: use print_array function
Dmitry V. Levin [Sat, 7 May 2016 23:02:36 +0000 (23:02 +0000)]
numa.c: use print_array function

* numa.c (print_node): New function.
(print_nodemask): Use it via print_array.
(print_page_array, print_int_array): Remove.
(print_addr): New function.
(print_status, print_int): Change for use as print_array callback.
(SYS_FUNC(move_pages)): Use print_addr, print_int, and print_status
via print_array.
* tests/move_pages.c: Update.
* tests/set_mempolicy.c: Likewise.
* tests/set_mempolicy.test: Likewise.

8 years agomem.c: use print_array function
Dmitry V. Levin [Sat, 7 May 2016 23:00:52 +0000 (23:00 +0000)]
mem.c: use print_array function

* mem.c [POWERPC] (print_protmap_entry): New function.
[POWERPC] (SYS_FUNC(subpage_prot)): Use it via print_array.

8 years agokexec.c: use print_array function
Dmitry V. Levin [Sat, 7 May 2016 22:59:05 +0000 (22:59 +0000)]
kexec.c: use print_array function

* kexec.c (print_seg): Change for use as print_array callback.
(print_kexec_segments): Use print_array.

8 years agoipc_sem.c: use print_array function
Dmitry V. Levin [Sat, 7 May 2016 22:56:59 +0000 (22:56 +0000)]
ipc_sem.c: use print_array function

* ipc_sem.c (tprint_sembuf): Rename to print_sembuf, change signature
for use as print_array callback.
(tprint_sembuf_array): Use print_array.

8 years agoio.c: use print_array function
Dmitry V. Levin [Sat, 7 May 2016 22:54:04 +0000 (22:54 +0000)]
io.c: use print_array function

* io.c (print_iovec_config): New structure.
(print_iovec): New function.
(tprint_iov_upto): Use print_array.
* tests/preadv.c (main): Update.
* tests/pwritev.c (print_iovec, main): Likewise.

8 years agoepoll.c: use print_array function
Dmitry V. Levin [Sat, 7 May 2016 22:49:39 +0000 (22:49 +0000)]
epoll.c: use print_array function

* epoll.c (print_epoll_event): Change signature for use as print_array
callback, all users updated.
(print_epoll_event_array): Remove.
(epoll_wait_common): Change to use print_array instead
of print_epoll_event_array.

8 years agoaio.c: use print_array function
Dmitry V. Levin [Sat, 7 May 2016 22:40:06 +0000 (22:40 +0000)]
aio.c: use print_array function

* aio.c (print_iocbp): New function.
(SYS_FUNC(io_submit)): Use it via print_array.  Use widen_to_long
to process long int argument.
(print_io_event): Change to print struct io_event fetched elsewhere.
(SYS_FUNC(io_cancel)): Update use of print_io_event.
(SYS_FUNC(io_getevents)): Use print_io_event via print_array.
Use widen_to_long to print long int arguments.
* tests/aio.c (main): Check decoding of io_submit with negative "nr".

8 years agoIntroduce print_array function for consistent decoding of arrays
Dmitry V. Levin [Fri, 6 May 2016 23:26:43 +0000 (23:26 +0000)]
Introduce print_array function for consistent decoding of arrays

* defs.h (print_array): New prototype.
* util.c (print_array): New function.

8 years agoFix corner cases of ICMP_FILTER decoding
Dmitry V. Levin [Fri, 6 May 2016 00:06:15 +0000 (00:06 +0000)]
Fix corner cases of ICMP_FILTER decoding

* net.c (print_icmp_filter): Print icmp_filter for any positive length.
* tests/net-icmp_filter.c: New file.
* tests/net-icmp_filter.test: New test.
* tests/.gitignore: Add net-icmp_filter.
* tests/Makefile.am (check_PROGRAMS): Likewise.
(DECODER_TESTS): Add net-icmp_filter.test.

8 years agoxlat: do not strip "1<<" prefix from xlat strings
Dmitry V. Levin [Thu, 5 May 2016 21:50:23 +0000 (21:50 +0000)]
xlat: do not strip "1<<" prefix from xlat strings

* xlat/gen.sh (cond_xlat, gen_header): Do not strip "1<<" prefix
from xlat strings to fix incorrect output.
* tests/caps.awk: Update.

Reported-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
8 years agotests/xstatfsx.c: fix mips o32 support
Dmitry V. Levin [Wed, 4 May 2016 21:43:18 +0000 (21:43 +0000)]
tests/xstatfsx.c: fix mips o32 support

mips o32 differs from all other 32-bit architectures by defining
__kernel_fsid_t structure as an array of long ints.

* tests/xstatfsx.c (print_statfs): Explicitly cast elements
of PRINT_F_FSID array to unsigned int.

8 years agoMpersify VIDIOC_* ioctl parser
Dmitry V. Levin [Tue, 3 May 2016 22:30:41 +0000 (22:30 +0000)]
Mpersify VIDIOC_* ioctl parser

* v4l2.c: Mpersify arch-specific structures.
(v4l2_ioctl): Mpersify.
* tests/ioctl_v4l2.c: New file.
* tests/ioctl_v4l2.test: New test.
* tests/.gitignore: Add ioctl_v4l2.
* tests/Makefile.am (check_PROGRAMS): Likewise.
(DECODER_TESTS): Add ioctl_v4l2.test.

8 years agoMpersify ioctl macros
Dmitry V. Levin [Mon, 2 May 2016 22:06:56 +0000 (22:06 +0000)]
Mpersify ioctl macros

As values of some ioctl macros differ between personalities, these
personality specific ioctl macros should be properly defined for
mpersified code.  Implement this by redefining personality specific
ioctl macros from ioctlent*.h for each file that includes MPERS_DEFS.

* Makefile.am (ioctl_macros_h): New variable.
(ioctl_macros%.h): New rule.
(BUILT_SOURCES, CLEANFILES): Add $(ioctl_macros_h).
(m%_type_defs.h): #include MPERS_$(mpers_PREFIX)IOCTL_MACROS.
* defs.h [HAVE_M32_MPERS] (MPERS_m32_IOCTL_MACROS): New macro.
[HAVE_MX32_MPERS] (MPERS_mx32_IOCTL_MACROS): Likewise.

Acked-by: Elvira Khabirova <lineprinter0@gmail.com>
8 years agoFix decoding of VIDIOC_* ioctls
Dmitry V. Levin [Sun, 1 May 2016 17:25:24 +0000 (17:25 +0000)]
Fix decoding of VIDIOC_* ioctls

* v4l2.c: Fix numerous bugs in decoding of VIDIOC_* ioctls.
* tests/ioctl.c (main): Update.

8 years agonsyscalls.test: add mips o32 support
Dmitry V. Levin [Sat, 30 Apr 2016 17:15:04 +0000 (17:15 +0000)]
nsyscalls.test: add mips o32 support

Out-of-range syscalls looks differently on mips o32.

* tests/nsyscalls.c (main): Handle LINUX_MIPSO32.
* tests/nsyscalls.test: Trace syscall called "syscall" on mips.

8 years agoRemove initialization of big holes in syscallent.h files
Dmitry V. Levin [Fri, 29 Apr 2016 21:31:08 +0000 (21:31 +0000)]
Remove initialization of big holes in syscallent.h files

There is no need to explicitly initialize big holes after conversion
of syscallent.h files to use designated initializers.  For architectures
that have some data at the end of syscallent.h this initialization of
big holes is no-op, for others it just inflates the table unnecessarily.

* linux/arc/syscallent.h: Remove initialization of arch specific block
at the end of table.
* linux/metag/syscallent.h: Likewise.
* linux/nios2/syscallent.h: Likewise.
* linux/or1k/syscallent.h: Likewise.
* linux/tile/syscallent.h: Likewise.
* linux/tile/syscallent1.h: Likewise.
* linux/arm/syscallent.h: Remove explicit initialization of a big hole
before socket subcalls.
* linux/i386/syscallent.h: Likewise.
* linux/m68k/syscallent.h: Likewise.
* linux/mips/syscallent-n32.h: Likewise.
* linux/powerpc/syscallent.h: Likewise.
* linux/powerpc64/syscallent.h: Likewise.
* linux/s390/syscallent.h: Likewise.
* linux/s390x/syscallent.h: Likewise.
* linux/sh/syscallent.h: Likewise.
* linux/sh64/syscallent.h: Likewise.
* linux/sparc/syscallent.h: Likewise.
* linux/sparc64/syscallent.h: Likewise.
* linux/mips/syscallent-compat.h: Remove explicit initialization
of big holes between different mips ABIs.
* linux/mips/syscallent-n64.h: Remove explicit initialization
of big holes before socket subcalls and between different mips ABIs.
* linux/mips/syscallent-o32.h: Likewise.

8 years agoxlat: make "1<<val" syntax work with 64-bit values
Dmitry V. Levin [Fri, 29 Apr 2016 20:12:54 +0000 (20:12 +0000)]
xlat: make "1<<val" syntax work with 64-bit values

* xlat/gen.sh(cond_xlat, gen_header): Generate 1UUL<<val
for 1<<val syntax.

Reported-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
8 years agoFix typo in XLAT_TYPE_PAIR
Dmitry V. Levin [Fri, 29 Apr 2016 20:04:38 +0000 (20:04 +0000)]
Fix typo in XLAT_TYPE_PAIR

* xlat.h (XLAT_TYPE_PAIR): Take "type" parameter.

Reported-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
8 years agoFix decoding of move_pages syscall
Dmitry V. Levin [Fri, 29 Apr 2016 17:26:56 +0000 (17:26 +0000)]
Fix decoding of move_pages syscall

* numa.c (print_page_array, print_status, print_int, print_int_array):
New functions.
(SYS_FUNC(move_pages)): Rewrite using these functions.
* tests/move_pages.c: New file.
* tests/move_pages.test: New test.
* tests/.gitignore: Add move_pages.
* tests/Makefile.am (check_PROGRAMS): Likewise.
(DECODER_TESTS): Add move_pages.test.

8 years agotests: check decoding of mbind syscall
Dmitry V. Levin [Fri, 29 Apr 2016 14:06:45 +0000 (14:06 +0000)]
tests: check decoding of mbind syscall

* tests/mbind.c: New file.
* tests/mbind.test: New test.
* tests/.gitignore: Add mbind.
* tests/Makefile.am (check_PROGRAMS): Likewise.
(DECODER_TESTS): Add mbind.test.

8 years agoChange type of struct xlat.val to uint64_t
Jeff Mahoney [Thu, 28 Apr 2016 15:26:59 +0000 (11:26 -0400)]
Change type of struct xlat.val to uint64_t

Some ioctls have flags fields that are 64-bit.  A 32-bit val means
these flags will never be matched or printed.

* xlat.h: Include <stdint.h>.
(struct xlat): Change type of val to uint64_t.

8 years agoxlat: extend syntax with #val_type directive
Dmitry V. Levin [Fri, 29 Apr 2016 01:02:13 +0000 (01:02 +0000)]
xlat: extend syntax with #val_type directive

When #val_type directive is encountered, gen.sh starts using
XLAT_TYPE/XLAT_TYPE_PAIR macros instead of XLAT/XLAT_PAIR,
with #val_type's argument as a type.

For example, "#val_type uint64_t" means values of type uint64_t.

* xlat/gen.sh (gen_header, print_xlat, print_xlat_pair):
Add val_type support.

8 years agoxlat/gen.sh: prepare for adding #val_type directive support
Dmitry V. Levin [Fri, 29 Apr 2016 01:02:13 +0000 (01:02 +0000)]
xlat/gen.sh: prepare for adding #val_type directive support

This is essentially a no-op change that makes the following change
easier to read.

* xlat/gen.sh (print_xlat, print_xlat_pair): New functions.
(cond_xlat, gen_header): Use them.

8 years agoIntroduce XLAT_TYPE and XLAT_TYPE_PAIR macros
Dmitry V. Levin [Fri, 29 Apr 2016 00:03:48 +0000 (00:03 +0000)]
Introduce XLAT_TYPE and XLAT_TYPE_PAIR macros

* xlat.h (XLAT_TYPE): New macro, similar to XLAT but casts
to the specified type instead of unsigned int.
(XLAT_TYPE_PAIR): New macro, similar to XLAT_PAIR but casts
to the specified type instead of unsigned int.

8 years agoxlat: generate xlat pairs using new XLAT_PAIR macro
Dmitry V. Levin [Thu, 28 Apr 2016 23:58:34 +0000 (23:58 +0000)]
xlat: generate xlat pairs using new XLAT_PAIR macro

Before this change there were two forms of xlat entries: those that use XLAT
or XLAT_END macros, and others verbatim entries.  This change converts
the latter to use new XLAT_PAIR macro.

This is necessary for the upcoming change of xlat.val type.

* xlat.h (XLAT_PAIR): New macro.
* xlat/gen.sh (cond_xlat, gen_header): Use it.

8 years agoExplicitly cast argument of XLAT macro to unsigned int
Dmitry V. Levin [Thu, 28 Apr 2016 23:52:28 +0000 (23:52 +0000)]
Explicitly cast argument of XLAT macro to unsigned int

This is necessary for the upcoming change of xlat.val type.

* xlat.h (XLAT): Cast the argument to unsigned int.

8 years agoChange type of {s,t}print_open_modes's argument to unsigned
Dmitry V. Levin [Thu, 28 Apr 2016 23:40:37 +0000 (23:40 +0000)]
Change type of {s,t}print_open_modes's argument to unsigned

As "flags" argument of sprint_open_modes and tprint_open_modes is
involved only in bit operations, change its type to unsigned.

* defs.h.c (sprint_open_modes, tprint_open_modes): Change type
to unsigned int.
* open.c (sprint_open_modes, tprint_open_modes): Likewise.

8 years agotests/remap_file_pages.c: fix for the upcoming change of xlat.val type
Dmitry V. Levin [Thu, 28 Apr 2016 21:10:59 +0000 (21:10 +0000)]
tests/remap_file_pages.c: fix for the upcoming change of xlat.val type

The "flags" argument of remap_file_page syscall has type "unsigned
long", so it is not correct to load most significant bits with garbage
ans assume they are going to be ignored.

* tests/remap_file_pages.c (main): Remove artificial garbage from flags.

8 years agoIntroduce printflags64 function
Dmitry V. Levin [Thu, 28 Apr 2016 18:55:18 +0000 (18:55 +0000)]
Introduce printflags64 function

This is necessary for the upcoming change of xlat.val type.

* defs.h (printflags): Rename to printflags64, change type of integer
argument to uint64_t.
(printflags): New static inline function.
* util.c (printflags): Rename to printflags64, change type of integer
argument to uint64_t.  Print it using PRIx64 format.
Based on patch by Jeff Mahoney <jeffm@suse.com>.

8 years agoIntroduce sprintflags64 function
Dmitry V. Levin [Thu, 28 Apr 2016 18:49:36 +0000 (18:49 +0000)]
Introduce sprintflags64 function

This is necessary for the upcoming change of xlat.val type.

* defs.h (sprintflags): Rename to sprintflags64, change type of integer
argument to uint64_t.
(sprintflags): New static inline function.
* util.c (sprintflags): Rename to sprintflags64, change type of integer
argument to uint64_t.  Print it using PRIx64 format.
Based on patch by Jeff Mahoney <jeffm@suse.com>.

8 years agoprintxvals: change type of integer argument to uint64_t
Dmitry V. Levin [Thu, 28 Apr 2016 18:42:10 +0000 (18:42 +0000)]
printxvals: change type of integer argument to uint64_t

This is necessary for the upcoming change of xlat.val type.
All users of printxvals are already prepared for this change.

* defs.h (printxvals): Change type of integer argument to uint64_t.
* util.c (printxvals): Likewise.  Print it using PRIx64 format.
Patch by Jeff Mahoney <jeffm@suse.com>.

8 years agoxlat_search: change type of integer argument to uint64_t
Dmitry V. Levin [Thu, 28 Apr 2016 18:37:54 +0000 (18:37 +0000)]
xlat_search: change type of integer argument to uint64_t

This is necessary for the upcoming change of xlat.val type.
All users of addflags are already prepared for this change.

* defs.h (xlat_search): Change type of integer argument to uint64_t.
* util.c (xlat_search): Likewise.  Pass it by pointer.
(xlat_bsearch_compare): Treat first argument as a pointer.
Patch by Jeff Mahoney <jeffm@suse.com>.

8 years agoIntroduce xlookup64 function
Dmitry V. Levin [Thu, 28 Apr 2016 18:32:45 +0000 (18:32 +0000)]
Introduce xlookup64 function

This is necessary for the upcoming change of xlat.val type.

* defs.h (xlookup): Rename to xlookup64, change type of integer argument
to uint64_t.
(xlookup): New static inline function.
* util.c (xlookup): Rename to xlookup64, change type of integer
argument to uint64_t.
Based on patch by Jeff Mahoney <jeffm@suse.com>.

8 years agoaddflags: change type of integer argument to uint64_t
Dmitry V. Levin [Thu, 28 Apr 2016 18:19:27 +0000 (18:19 +0000)]
addflags: change type of integer argument to uint64_t

This is necessary for the upcoming change of xlat.val type.
All users of addflags are already prepared for this change.

* defs.h (addflags): Change type of integer argument to uint64_t.
* util.c (addflags): Likewise.  Print it using PRIx64 format.
Based on patch by Jeff Mahoney <jeffm@suse.com>.

8 years agoIntroduce printxval64 wrapper
Dmitry V. Levin [Thu, 28 Apr 2016 18:15:20 +0000 (18:15 +0000)]
Introduce printxval64 wrapper

This is necessary for the upcoming change of xlat.val type.

* defs.h (printxval64): New static inline function.

8 years agoTurn printxval macro into a static inline function
Dmitry V. Levin [Thu, 28 Apr 2016 17:50:51 +0000 (17:50 +0000)]
Turn printxval macro into a static inline function

This is necessary for the upcoming change of xlat.val type.

* defs.h (printxval): Change to static inline function.

8 years agotests: check decoding of migrate_pages syscall
Dmitry V. Levin [Thu, 28 Apr 2016 01:09:59 +0000 (01:09 +0000)]
tests: check decoding of migrate_pages syscall

* tests/migrate_pages.c: New file.
* tests/migrate_pages.test: New test.
* tests/.gitignore: Add migrate_pages.
* tests/Makefile.am (check_PROGRAMS): Likewise.
(DECODER_TESTS): Add migrate_pages.test.

8 years agoFix decoding of migrate_pages syscall
Dmitry V. Levin [Thu, 28 Apr 2016 01:19:19 +0000 (01:19 +0000)]
Fix decoding of migrate_pages syscall

* numa.c (SYS_FUNC(migrate_pages)): Print syscall arguments
in the right order.

8 years agotests: check decoding of set_mempolicy syscall
Dmitry V. Levin [Wed, 27 Apr 2016 23:43:24 +0000 (23:43 +0000)]
tests: check decoding of set_mempolicy syscall

* tests/set_mempolicy.c: New file.
* tests/set_mempolicy.test: New test.
* tests/.gitignore: Add set_mempolicy.
* tests/Makefile.am (check_PROGRAMS): Likewise.
(DECODER_TESTS): Add set_mempolicy.test.

8 years agotests: check decoding of get_mempolicy syscall
Dmitry V. Levin [Wed, 27 Apr 2016 21:58:43 +0000 (21:58 +0000)]
tests: check decoding of get_mempolicy syscall

* tests/get_mempolicy.c: New file.
* tests/get_mempolicy.test: New test.
* tests/.gitignore: Add get_mempolicy.
* tests/Makefile.am (check_PROGRAMS): Likewise.
(DECODER_TESTS): Add get_mempolicy.test.

8 years agonuma: fix decoding of nodemask arrays
Dmitry V. Levin [Wed, 27 Apr 2016 22:02:26 +0000 (22:02 +0000)]
numa: fix decoding of nodemask arrays

* numa.c (get_nodes): Rewrite an rename to print_nodemask.
All callers updated.
(SYS_FUNC(mbind), SYS_FUNC(set_mempolicy), SYS_FUNC(get_mempolicy)):
Print a delimiter before nodemask argument.

8 years agoFix decoding of policy argument of get_mempolicy syscall
Dmitry V. Levin [Wed, 27 Apr 2016 22:36:07 +0000 (22:36 +0000)]
Fix decoding of policy argument of get_mempolicy syscall

* numa.c (SYS_FUNC(get_mempolicy)): Print policy argument in square
brackets to indicate indirect access.

8 years agoFix decoding of pid_t argument of migrate_pages syscall
Dmitry V. Levin [Wed, 27 Apr 2016 22:08:21 +0000 (22:08 +0000)]
Fix decoding of pid_t argument of migrate_pages syscall

* numa.c (SYS_FUNC(migrate_pages)): Print pid_t syscall
argument using %d format.

8 years agotests: add printxval function to libtests
Dmitry V. Levin [Wed, 27 Apr 2016 20:29:46 +0000 (20:29 +0000)]
tests: add printxval function to libtests

* tests/tests.h (printxval): New prototype.
* tests/printxval.c: New file.
* tests/Makefile.am  (libtests_a_SOURCES): Add it.

8 years agotests: check decoding of remap_file_pages syscall
Dmitry V. Levin [Wed, 27 Apr 2016 16:04:01 +0000 (16:04 +0000)]
tests: check decoding of remap_file_pages syscall

* tests/remap_file_pages.c: New file.
* tests/remap_file_pages.test: New test.
* tests/.gitignore: Add remap_file_pages.
* tests/Makefile.am (check_PROGRAMS): Likewise.
(DECODER_TESTS): Add remap_file_pages.test.

8 years agotests: add pause.test
Fei Jie [Wed, 27 Apr 2016 08:54:21 +0000 (16:54 +0800)]
tests: add pause.test

* tests/pause.c: New file.
* tests/pause.test: New test.
* tests/.gitignore: Add pause.
* tests/Makefile.am (check_PROGRAMS): Likewise.
(DECODER_TESTS): Add pause.test.

8 years agotests: add kill.test
Fei Jie [Wed, 27 Apr 2016 08:54:20 +0000 (16:54 +0800)]
tests: add kill.test

* tests/kill.c: New file.
* tests/kill.test: New test.
* tests/.gitignore: Add kill.
* tests/Makefile.am (check_PROGRAMS): Likewise.
(DECODER_TESTS): Add kill.test.

8 years agoFix decoding of pid_t arguments of kill and tgkill syscalls
Dmitry V. Levin [Wed, 27 Apr 2016 11:49:38 +0000 (11:49 +0000)]
Fix decoding of pid_t arguments of kill and tgkill syscalls

* signal.c (SYS_FUNC(kill), SYS_FUNC(tgkill)): Print pid_t syscall
arguments using %d format.

8 years agotests: add mlock.test
Fei Jie [Wed, 27 Apr 2016 08:54:19 +0000 (16:54 +0800)]
tests: add mlock.test

* tests/mlock.c: New file.
* tests/mlock.test: New test.
* tests/.gitignore: Add mlock.
* tests/Makefile.am (check_PROGRAMS): Likewise.
(DECODER_TESTS): Add mlock.test.

8 years agoMove parsers of NUMA related syscalls to numa.c
Dmitry V. Levin [Wed, 27 Apr 2016 05:06:06 +0000 (05:06 +0000)]
Move parsers of NUMA related syscalls to numa.c

* mem.c (get_nodes, SYS_FUNC(mbind), SYS_FUNC(set_mempolicy),
SYS_FUNC(get_mempolicy), SYS_FUNC(migrate_pages), SYS_FUNC(move_pages)):
Move ...
* numa.c: ... here.
* Makefile.am (strace_SOURCES): Add numa.c

8 years agotests/umovestr3.c: robustify against os specific issues
Dmitry V. Levin [Wed, 27 Apr 2016 03:18:44 +0000 (03:18 +0000)]
tests/umovestr3.c: robustify against os specific issues

* tests/umovestr3.c (main): Create extra gap before unreadable page.

8 years agotests: extend test coverage of umovestr short read condition
Dmitry V. Levin [Wed, 27 Apr 2016 00:08:06 +0000 (00:08 +0000)]
tests: extend test coverage of umovestr short read condition

* tests/umovestr3.c: New file.
* tests/umovestr3.test: New test.
* tests/.gitignore: Add umovestr3.
* tests/Makefile.am (check_PROGRAMS): Likewise.
(DECODER_TESTS): Add umovestr3.test.

8 years agotests: check decoding of out-of-range syscalls
Dmitry V. Levin [Tue, 26 Apr 2016 23:17:17 +0000 (23:17 +0000)]
tests: check decoding of out-of-range syscalls

* tests/nsyscalls.c: New file.
* tests/nsyscalls.test: New test.
* tests/.gitignore: Add nsyscalls.
* tests/Makefile.am (check_PROGRAMS): Likewise.
(DECODER_TESTS): Add nsyscalls.test.

8 years agoFix decoding of 3rd argument of getdents/getdents64 syscalls
Dmitry V. Levin [Tue, 26 Apr 2016 22:38:10 +0000 (22:38 +0000)]
Fix decoding of 3rd argument of getdents/getdents64 syscalls

* dirent.c (SYS_FUNC(getdents)): Always print 3rd syscall argument
as unsigned int.
* dirent64.c (SYS_FUNC(getdents64)): Likewise.
* tests/getdents.c (main): Check it.
* tests/getdents64.c (main): Likewise.

8 years agoFix decoding of LINUX_REBOOT_CMD_RESTART2 argument
Dmitry V. Levin [Tue, 26 Apr 2016 17:41:44 +0000 (17:41 +0000)]
Fix decoding of LINUX_REBOOT_CMD_RESTART2 argument

* reboot.c (SYS_FUNC(reboot)): Cast numeric arguments to unsigned int.

8 years ago.travis.yml: raise sleep delay
Dmitry V. Levin [Tue, 26 Apr 2016 16:46:20 +0000 (16:46 +0000)]
.travis.yml: raise sleep delay

Previous sleep delay value seems to be not enough nowadays.

.travis.yml (SLEEP_A_BIT): Raise sleep delay.

8 years agoMove definitions of MPOL_* constants to xlat files
Dmitry V. Levin [Tue, 26 Apr 2016 16:36:30 +0000 (16:36 +0000)]
Move definitions of MPOL_* constants to xlat files

* mem.c (MPOL_DEFAULT, MPOL_PREFERRED, MPOL_BIND, MPOL_INTERLEAVE):
Move to xlat/policies.in.
(MPOL_F_NODE, MPOL_F_ADDR): Move to xlat/mempolicyflags.in.
(MPOL_MF_STRICT, MPOL_MF_MOVE, MPOL_MF_MOVE_ALL): Move
to xlat/mbindflags.in.

8 years agotests: check decoding of renameat2 syscall
Dmitry V. Levin [Tue, 26 Apr 2016 16:11:48 +0000 (16:11 +0000)]
tests: check decoding of renameat2 syscall

* tests/renameat2.c: New file.
* tests/renameat2.test: New test.
* tests/.gitignore: Add renameat2.
* tests/Makefile.am (check_PROGRAMS): Likewise.
(DECODER_TESTS): Add renameat2.test.

8 years agoAdd default values for RENAME_* constants
Dmitry V. Levin [Tue, 26 Apr 2016 16:30:13 +0000 (16:30 +0000)]
Add default values for RENAME_* constants

* xlat/rename_flags.in: Add default values.

8 years agotests: check decoding of utimes syscall
Dmitry V. Levin [Tue, 26 Apr 2016 15:35:57 +0000 (15:35 +0000)]
tests: check decoding of utimes syscall

* tests/utimes.c: New file.
* tests/utimes.test: New test.
* tests/.gitignore: Add utimes.
* tests/Makefile.am (check_PROGRAMS): Likewise.
(DECODER_TESTS): Add utimes.test.

8 years agotests: check decoding of futimesat syscall
Dmitry V. Levin [Tue, 26 Apr 2016 15:34:03 +0000 (15:34 +0000)]
tests: check decoding of futimesat syscall

* tests/futimesat.c: New file.
* tests/futimesat.test: New test.
* tests/.gitignore: Add futimesat.
* tests/Makefile.am (check_PROGRAMS): Likewise.
(DECODER_TESTS): Add futimesat.test.

8 years agotests: extend test coverage of mknod syscall
Dmitry V. Levin [Tue, 26 Apr 2016 11:00:51 +0000 (11:00 +0000)]
tests: extend test coverage of mknod syscall

* mknod.c (main): Check more corner cases of mode_t parser.
* mknod.test: Update.

8 years agotests: add sched_yield.test
Fei Jie [Tue, 26 Apr 2016 08:03:11 +0000 (16:03 +0800)]
tests: add sched_yield.test

* tests/sched_yield.c: New file.
* tests/sched_yield.test: New test.
* tests/.gitignore: Add sched_yield.
* tests/Makefile.am (check_PROGRAMS): Likewise.
(DECODER_TESTS): Add sched_yield.test.

8 years agotests: add sync.test
Fei Jie [Tue, 26 Apr 2016 08:03:10 +0000 (16:03 +0800)]
tests: add sync.test

* tests/sync.c: New file.
* tests/sync.test: New test.
* tests/.gitignore: Add sync.
* tests/Makefile.am (check_PROGRAMS): Likewise.
(DECODER_TESTS): Add sync.test.

8 years agotests: add mknodat.test
Fei Jie [Tue, 26 Apr 2016 08:03:09 +0000 (16:03 +0800)]
tests: add mknodat.test

* tests/mknodat.c: New file.
* tests/mknodat.test: New test.
* tests/.gitignore: Add mknodat.
* tests/Makefile.am (check_PROGRAMS): Likewise.
(DECODER_TESTS): Add mknodat.test.

8 years agotests: add unlink.test
Fei Jie [Tue, 26 Apr 2016 08:03:08 +0000 (16:03 +0800)]
tests: add unlink.test

* tests/unlink.c: New file.
* tests/unlink.test: New test.
* tests/.gitignore: Add unlink.
* tests/Makefile.am (check_PROGRAMS): Likewise.
(DECODER_TESTS): Add unlink.test.

8 years agotests: add reboot.test
Fei Jie [Tue, 26 Apr 2016 08:03:07 +0000 (16:03 +0800)]
tests: add reboot.test

* tests/reboot.c: New file.
* tests/reboot.test: New test.
* tests/.gitignore: Add reboot.
* tests/Makefile.am (check_PROGRAMS): Likewise.
(DECODER_TESTS): Add reboot.test.

8 years agoFix decoding of statfs family syscalls
Dmitry V. Levin [Tue, 26 Apr 2016 00:21:26 +0000 (00:21 +0000)]
Fix decoding of statfs family syscalls

Fix decoders of fstatfs, fstatfs64, statfs, and statfs64 syscalls
by rewriting them using mpers infrastructure.

* fetch_struct_statfs.c: New file.
* fstatfs.c: Likewise.
* fstatfs64.c: Likewise.
* print_statfs.c: Likewise.
* statfs.h: Likewise.
* statfs64.c: Likewise.
* statfs.c: Remove everything except SYS_FUNC(statfs).
* configure.ac: Remove the check for struct statfs64 in <sys/vfs.h>.
Add checks for struct statfs and struct statfs64 in <asm/statfs.h>.
Add checks for f_frsize and f_flags members of these structures.
* defs.h (struct strace_statfs): New forward declaration.
(print_struct_statfs, print_struct_statfs64): New prototypes.
* Makefile.am (libstrace_a_SOURCES): Add fstatfs.c, fstatfs64.c,
statfs.c, and statfs64.c.
(strace_SOURCES): Add fetch_struct_statfs.c, print_statfs.c,
and statfs.h.
* NEWS: Mention this fix.
* tests/fstatfs.c: New file.
* tests/fstatfs64.c: Likewise.
* tests/statfs64.c: Likewise.
* tests/xstatfs.c: Likewise.
* tests/xstatfs64.c: Likewise.
* tests/xstatfsx.c: Likewise.
* tests/fstatfs.test: New test.
* tests/fstatfs64.test: Likewise.
* tests/statfs64.test: Likewise.
* tests/statfs.c: Rewrite using xstatfs.c.
* tests/statfs.test: Update.
* tests/.gitignore: Add fstatfs, fstatfs64, and statfs64.
* tests/Makefile.am (check_PROGRAMS): Likewise.
(DECODER_TESTS): Add  fstatfs.test, fstatfs64.test, and statfs64.test.
(EXTRA_DIST): Add xstatfs.c, xstatfs64.c, and xstatfsx.c.

8 years agotests: add printflags function to libtests
Dmitry V. Levin [Tue, 26 Apr 2016 00:13:47 +0000 (00:13 +0000)]
tests: add printflags function to libtests

* tests/printflags.c: New file.
* tests/tests.h (printflags): New prototype.
* tests/Makefile.am (libtests_a_SOURCES): Add it.

8 years agoMove definition of struct xlat to a separate header file
Dmitry V. Levin [Tue, 26 Apr 2016 00:08:16 +0000 (00:08 +0000)]
Move definition of struct xlat to a separate header file

Define struct xlat in a separate file so that it could be used later by
tests without inclusion of defs.h header file.

* defs.h (struct xlat, XLAT, XLAT_END): Move ...
* xlat.h: ... here.
* Makefile.am (strace_SOURCES): Add xlat.h.

8 years agoalpha: decode osf_statfs64 and osf_fstatfs64 syscalls
Dmitry V. Levin [Mon, 25 Apr 2016 23:52:03 +0000 (23:52 +0000)]
alpha: decode osf_statfs64 and osf_fstatfs64 syscalls

* linux/alpha/syscallent.h (osf_statfs64, osf_fstatfs64): Set nargs
and handler.

8 years agoalpha: fix decoding of osf_statfs and osf_fstatfs syscalls
Dmitry V. Levin [Mon, 25 Apr 2016 23:52:03 +0000 (23:52 +0000)]
alpha: fix decoding of osf_statfs and osf_fstatfs syscalls

Do not attempt to print struct osf_statfs as if it was the same as
struct statfs.  Since struct osf_statfs has never been decoded properly,
it is probably too late to implement a decoder, so let's just print the
pointer.

* statfs.c [ALPHA] (SYS_FUNC(osf_statfs), SYS_FUNC(osf_fstatfs)): Move ...
* alpha.c: ... here.  Replace printstatfs with printaddr.