]> granicus.if.org Git - libvpx/log
libvpx
5 years agoFix oob in vpx_setup_noise
Jerome Jiang [Wed, 7 Nov 2018 00:12:11 +0000 (16:12 -0800)]
Fix oob in vpx_setup_noise

Array index wasn't checked on boundary.

BUG=webm:1572

Change-Id: I55a93c024af77a4fd904b0e992d5587a142d66a4

5 years agoMerge "Fix arf boost factor calculation for intermediate ARFs"
Jingning Han [Fri, 16 Nov 2018 00:07:22 +0000 (00:07 +0000)]
Merge "Fix arf boost factor calculation for intermediate ARFs"

5 years agoMerge changes Ib9d16a4b,I6061f38c
Angie Chiang [Thu, 15 Nov 2018 23:40:59 +0000 (23:40 +0000)]
Merge changes Ib9d16a4b,I6061f38c

* changes:
  Refactor av1_nb_mvs_inconsistency()
  Recompute mv inconsistency after mv search is done

5 years agoAdd ARM64 Windows to configure scripts
Jon Kunkee [Mon, 12 Nov 2018 21:40:56 +0000 (13:40 -0800)]
Add ARM64 Windows to configure scripts

In order to correctly configure for Windows 10 on ARM, this change adds
a --target value arm64-win64-vs15 to ./configure and adds feature
enable/disable logic for the new platform.

This is merely sufficient for Chromium targeting ARM64 Windows.

Bug: 893460
Change-Id: I46194286f63104bdf6ac57d719fdf1e5d5fa72c8

5 years agoFix arf boost factor calculation for intermediate ARFs
Jingning Han [Thu, 15 Nov 2018 05:02:03 +0000 (21:02 -0800)]
Fix arf boost factor calculation for intermediate ARFs

Need to offset the forward range by 1 to include the stats for
the current frame itself.

Change-Id: I3b5171b7edef51ec4e97e4e0542ca58af5ce1416

5 years agoMerge "Disable tpl model in GF-only GOP structure"
Jingning Han [Thu, 15 Nov 2018 05:01:04 +0000 (05:01 +0000)]
Merge "Disable tpl model in GF-only GOP structure"

5 years agoMerge "Fix GF-only frame type allocation"
Jingning Han [Thu, 15 Nov 2018 05:00:55 +0000 (05:00 +0000)]
Merge "Fix GF-only frame type allocation"

5 years agoRefactor av1_nb_mvs_inconsistency()
Angie Chiang [Thu, 18 Oct 2018 17:40:06 +0000 (10:40 -0700)]
Refactor av1_nb_mvs_inconsistency()

Change-Id: Ib9d16a4bc3ce1d28493e34f24dc18a6b511738f0

5 years agoRecompute mv inconsistency after mv search is done
Angie Chiang [Wed, 17 Oct 2018 22:54:25 +0000 (15:54 -0700)]
Recompute mv inconsistency after mv search is done

Change-Id: I6061f38cb42eea2b4c8996ad372c829dc1051c8d

5 years agoDisable tpl model in GF-only GOP structure
Jingning Han [Wed, 14 Nov 2018 22:58:56 +0000 (14:58 -0800)]
Disable tpl model in GF-only GOP structure

The tpl model assumes a relative short stats buffer length. Hence
it is not ready to support GF-only GOP structure where the max
length can go up to 250. Disable tpl model in such setting to avoid
a rare encode failure in GF-only setting.

Change-Id: I3409dbb829a8105478876684ec21a2bd405c33c8

5 years agoMerge "vpx_dec_fuzzer: Unify single and multi-thread tests"
Harish Mahendrakar [Wed, 14 Nov 2018 21:55:16 +0000 (21:55 +0000)]
Merge "vpx_dec_fuzzer: Unify single and multi-thread tests"

5 years agovpx_dec_fuzzer: Unify single and multi-thread tests
Harish Mahendrakar [Wed, 14 Nov 2018 20:00:01 +0000 (12:00 -0800)]
vpx_dec_fuzzer: Unify single and multi-thread tests

As thread count is now randomized, serial and threaded modes can be
combined to a single binary.
With this change, threads takes values between 1 to 64 and tests both
single thread and multi-thread variants of the decoders

Change-Id: I6dd2a3aa03bff9c0e2c126843b543d46892be696

5 years agoMerge "Added libFuzzer plugin to test decoders"
Harish Mahendrakar [Wed, 14 Nov 2018 21:02:45 +0000 (21:02 +0000)]
Merge "Added libFuzzer plugin to test decoders"

5 years agoFix GF-only frame type allocation
Jingning Han [Wed, 14 Nov 2018 07:20:03 +0000 (23:20 -0800)]
Fix GF-only frame type allocation

Rework the recursive ARF allocation to avoid missing one frame's
type assignment issue in GF only GOP structure. This fixes a rare
encoder failure issue in GF only setting.

Change-Id: I3e41fe36d3cb954de25ffc058a42b2b8be0fcd7a

5 years agoAdded libFuzzer plugin to test decoders
Harish Mahendrakar [Fri, 9 Nov 2018 22:12:07 +0000 (14:12 -0800)]
Added libFuzzer plugin to test decoders

vpx_dec_fuzzer.cc can be built with clang++ to generate fuzzer binary
Build instructions are part of the file

Change-Id: I19ba0bd49b236e27b27e81a83f6de59f15bdc994

5 years agoMerge "Rescale arf bit budget calculation"
Jingning Han [Tue, 13 Nov 2018 23:13:14 +0000 (23:13 +0000)]
Merge "Rescale arf bit budget calculation"

5 years agoSkip ACL recode loop for intermediate ARF layers
Jingning Han [Fri, 2 Nov 2018 18:31:38 +0000 (11:31 -0700)]
Skip ACL recode loop for intermediate ARF layers

Speed up the encoding time by ~20% for multi-layer ARF system.

Change-Id: I16de1cfed7cd1815cf0269eb4f90ad74fdf087ee

5 years agoRescale arf bit budget calculation
Jingning Han [Tue, 13 Nov 2018 00:22:46 +0000 (16:22 -0800)]
Rescale arf bit budget calculation

To compute the total budget for a depth layer, exclude the count of
frames that have been allocated the bit budget. This improves the
avg PSNR by 0.15% and overall PSNR by 0.25% for lowres and midres
test sets.

Change-Id: I5115e33e1422dc930179142cd29aeebe97425283

5 years agoMerge "Refactor common code in RDMULT computation"
Yaowu Xu [Sun, 11 Nov 2018 14:17:35 +0000 (14:17 +0000)]
Merge "Refactor common code in RDMULT computation"

5 years agovp8: Init buffers and pred arrays for mt after allocation.
Jerome Jiang [Fri, 9 Nov 2018 21:27:39 +0000 (13:27 -0800)]
vp8: Init buffers and pred arrays for mt after allocation.

Buffers and arrays used for prediction are not initialized after
allocation.

BUG=902691

Change-Id: Ic727e5dab7456e91ec9d6c80694f60a1a3600640

5 years agoRefactor common code in RDMULT computation
Yaowu Xu [Fri, 9 Nov 2018 22:45:48 +0000 (14:45 -0800)]
Refactor common code in RDMULT computation

Change-Id: I2b59ba26fdb1f75302c457c90817398acaa28975

5 years agoMerge "Add operator<< to hadamard test."
Jerome Jiang [Thu, 8 Nov 2018 18:37:59 +0000 (18:37 +0000)]
Merge "Add operator<< to hadamard test."

5 years agoAdd operator<< to hadamard test.
Jerome Jiang [Thu, 8 Nov 2018 05:35:35 +0000 (21:35 -0800)]
Add operator<< to hadamard test.

This quiets valgrind warning.

Change-Id: I7c5e23ebb91cc67cf93678135b826b2bc8e9db2f

5 years agoMerge "Simplify rdmult computation"
Yaowu Xu [Wed, 7 Nov 2018 21:55:10 +0000 (21:55 +0000)]
Merge "Simplify rdmult computation"

5 years agoMerge "vp9-screen-content: Adjust condition for large search area"
Marco Paniconi [Wed, 7 Nov 2018 21:14:49 +0000 (21:14 +0000)]
Merge "vp9-screen-content: Adjust condition for large search area"

5 years agoSimplify rdmult computation
Yaowu Xu [Wed, 7 Nov 2018 19:20:32 +0000 (11:20 -0800)]
Simplify rdmult computation

Recognizing that max dc_quant used in rdmult computation is 21387 and
21387 * 21387 * 88 / 24 is still within the range of int32_t, this
commit simplifies the computation with minor cleanups.

Change-Id: I2ac7e8315d103c0bb39b70c312c87c0fda47b4f9

5 years agovp9-screen-content: Adjust condition for large search area
Marco Paniconi [Wed, 7 Nov 2018 19:14:42 +0000 (11:14 -0800)]
vp9-screen-content: Adjust condition for large search area

Account for dropped frame, and change resolution threshold
for limiting split below 16x16.

Change-Id: If94cfb2bc24d9103332d1c8d945daca8899db33d

5 years agoCosmetic clean up in find_arf_order
Jingning Han [Wed, 7 Nov 2018 19:26:23 +0000 (11:26 -0800)]
Cosmetic clean up in find_arf_order

Remove duplicate variable definition.

Change-Id: I476bb319078f1043116163ac7aeff28a4a3ab5e6

5 years agoMerge "Unify GOP structure layout setup"
Jingning Han [Wed, 7 Nov 2018 18:21:38 +0000 (18:21 +0000)]
Merge "Unify GOP structure layout setup"

5 years agoMerge "Modified key frame detection."
Paul Wilkins [Wed, 7 Nov 2018 17:03:44 +0000 (17:03 +0000)]
Merge "Modified key frame detection."

5 years agoUnify GOP structure layout setup
Jingning Han [Wed, 7 Nov 2018 00:35:44 +0000 (16:35 -0800)]
Unify GOP structure layout setup

Refactor define_gf_group_structure() to unify the single-layer,
multi-layer ARF, and GF only GOP structure setup.

Change-Id: Iebbe9c3742fc58ae4e77b1072ebecb3ee7bd26b2

5 years agoMerge "vp8: remove VP8_ENTROPY_STATS code"
Johann Koenig [Wed, 7 Nov 2018 15:41:22 +0000 (15:41 +0000)]
Merge "vp8: remove VP8_ENTROPY_STATS code"

5 years agoMerge "vp9: postencode drop frame for screen content in CBR."
Jerome Jiang [Wed, 7 Nov 2018 00:33:58 +0000 (00:33 +0000)]
Merge "vp9: postencode drop frame for screen content in CBR."

5 years agoMerge "vp9 screen-content: Adjustments for screen content."
Marco Paniconi [Tue, 6 Nov 2018 23:45:30 +0000 (23:45 +0000)]
Merge "vp9 screen-content: Adjustments for screen content."

5 years agovp9: postencode drop frame for screen content in CBR.
Jerome Jiang [Tue, 28 Aug 2018 21:24:53 +0000 (14:24 -0700)]
vp9: postencode drop frame for screen content in CBR.

Encode the next frame at max q.

For layers: post_encode_drop is only check on base
spatial layer, and if base is post-encoded-dropped,
then whole superframe is dropped.

Added API to guard postencode dropping. Turned off by default.

Added unittest.

BUG=b/112990050
Change-Id: I42fee279014aca616f7a4d9b582cb2bf5da2f2e7

5 years agoMerge "vp8: Increase rate correction threshold for drop-overshoot"
Marco Paniconi [Tue, 6 Nov 2018 22:43:16 +0000 (22:43 +0000)]
Merge "vp8: Increase rate correction threshold for drop-overshoot"

5 years agoMerge "Refactor Hadamard tests and add highbd tests"
Sai Deng [Tue, 6 Nov 2018 19:03:17 +0000 (19:03 +0000)]
Merge "Refactor Hadamard tests and add highbd tests"

5 years agovp9 screen-content: Adjustments for screen content.
Marco Paniconi [Tue, 6 Nov 2018 01:49:39 +0000 (17:49 -0800)]
vp9 screen-content: Adjustments for screen content.

Increase search area, use NSTEP, and in some cases avoid
bsize below 16x16. This for base spatial layer when many blocks
in the frame have motion (from scene detection analysis).

Improves quality for scrolling motion.

Change-Id: If77b43e738a6c43610d4727a95712667088db564

5 years agoMerge "vp8 dec: only compute ref frame buffer pointer for non intra"
Jerome Jiang [Tue, 6 Nov 2018 18:47:16 +0000 (18:47 +0000)]
Merge "vp8 dec: only compute ref frame buffer pointer for non intra"

5 years agoRefactor Hadamard tests and add highbd tests
sdeng [Thu, 1 Nov 2018 17:21:13 +0000 (10:21 -0700)]
Refactor Hadamard tests and add highbd tests

Change-Id: I306083f233e53884ac21fb4621066713edddc8f7

5 years agoMerge "Track maximum layer depth in a GOP"
Jingning Han [Tue, 6 Nov 2018 17:10:24 +0000 (17:10 +0000)]
Merge "Track maximum layer depth in a GOP"

5 years agoMerge "Fix gf_group->frame_end assignment"
Jingning Han [Tue, 6 Nov 2018 17:10:18 +0000 (17:10 +0000)]
Merge "Fix gf_group->frame_end assignment"

5 years agoMerge "Refactor define_gf_group_structure()"
Jingning Han [Tue, 6 Nov 2018 17:10:10 +0000 (17:10 +0000)]
Merge "Refactor define_gf_group_structure()"

5 years agoMerge "Remove redundant assignments in define_gf_group_structure()"
Jingning Han [Tue, 6 Nov 2018 17:10:03 +0000 (17:10 +0000)]
Merge "Remove redundant assignments in define_gf_group_structure()"

5 years agoMerge "Refactor find_arf_order()"
Jingning Han [Tue, 6 Nov 2018 17:09:54 +0000 (17:09 +0000)]
Merge "Refactor find_arf_order()"

5 years agoModified key frame detection.
Paul Wilkins [Fri, 26 Oct 2018 11:12:57 +0000 (12:12 +0100)]
Modified key frame detection.

Address poor key frame detection in some content.

This patch improves on poor key frame / scene cut detection observed
with some test content. The content in question was letter boxed film
style material and also had quite low contrast. For both 1080P and 4K
multiple genuine scene cuts were being missed.

The changes alter the conditions for marking a transition as a "flash" rather
than a scene change. The new code still deals well with genuine flashes as
observed in the "crew" test clip, without falsely flagging some of the
the scene cuts in the "film" test clip.

The new film test clip also had some "flash" frames caused by a lightning
effect and in one case a flash occurred right before a scene change. This
caused a misplacement of the key frame but has been addressed by a new
clause that requires the coded error for the next frame after a candidate
key frame to be lower than the current frame.

The patch also changes the way in which neutral blocks (similar inter and
inter error) are handled in the candidate key frame decision in a way which
hopefully handles the letter boxed format better.

During wider testing some film clips still had missed key frames but this
patch does improve things. In the case of the initial test clip the encoder
correctly marks all 3 scene cuts vs 0 before the patch.

Testing with our standard (mainly short single kf) derf and NF test clips
is neutral.

Change-Id: I3b7dcfe7b2fb13fd0816ea46acc3e69c8bc581b3

5 years agoMerge "vpx_codec_enc_config_default: disable 'usage'"
Johann Koenig [Tue, 6 Nov 2018 02:34:04 +0000 (02:34 +0000)]
Merge "vpx_codec_enc_config_default: disable 'usage'"

5 years agovp8 dec: only compute ref frame buffer pointer for non intra
Jerome Jiang [Tue, 6 Nov 2018 01:46:03 +0000 (17:46 -0800)]
vp8 dec: only compute ref frame buffer pointer for non intra

When ref frame is INTRA_FRAME, pre buffer shouldn't be used.

This CL copies behavior in single thread. That should apply to
multithreading case too.

BUG=webm:1496

Change-Id: Ibe9ab8ea9dc664151fa7ebac529d5fd1a481b4a3

5 years agoTrack maximum layer depth in a GOP
Jingning Han [Tue, 6 Nov 2018 00:21:49 +0000 (16:21 -0800)]
Track maximum layer depth in a GOP

Track the effective maximum layer depth in a given group of
pictures. Keep it in the GF_GROUP data structure.

Change-Id: If777c4e0f4a871c7226a91e3871f445e92f18b24

5 years agoFix gf_group->frame_end assignment
Jingning Han [Mon, 5 Nov 2018 23:42:20 +0000 (15:42 -0800)]
Fix gf_group->frame_end assignment

The previous value was set off by 1. Use the correct value.

Change-Id: I1ce53cc99063ce31e7ab1c43c6e444cb9a1972db

5 years agoRefactor define_gf_group_structure()
Jingning Han [Mon, 5 Nov 2018 23:38:10 +0000 (15:38 -0800)]
Refactor define_gf_group_structure()

Make it a standalone operation unit. Refactor to cut off unnecessary
dependency between define_gf_group_structure() and
allocate_gf_group_bits().

Change-Id: I954fd4e96152471a994f2ffd38a72061ab517ddd

5 years agoMerge changes I774a0711,I0b4fd670,Ia09935e5
Johann Koenig [Mon, 5 Nov 2018 23:32:11 +0000 (23:32 +0000)]
Merge changes I774a0711,I0b4fd670,Ia09935e5

* changes:
  Fix compilation on OS/2
  Use wcslen() instead of std::wcslen()
  Fix compilation on OS/2

5 years agoMerge "clang-tidy: fix vpx_dsp parameters"
Johann Koenig [Mon, 5 Nov 2018 23:29:06 +0000 (23:29 +0000)]
Merge "clang-tidy: fix vpx_dsp parameters"

5 years agovpx_codec_enc_config_default: disable 'usage'
Johann [Thu, 1 Nov 2018 20:02:45 +0000 (13:02 -0700)]
vpx_codec_enc_config_default: disable 'usage'

Found with clang-tidy. This value is unused in libvpx.

There is an existing test which ensures this is not used:
test/encode_api_test.cc:
    EXPECT_EQ(VPX_CODEC_INVALID_PARAM,
              vpx_codec_enc_config_default(kCodecs[i], &cfg, 1));

Change-Id: I94bd0663c6652b4267204c02c3921972c854d0b0

5 years agoRemove redundant assignments in define_gf_group_structure()
Jingning Han [Mon, 5 Nov 2018 19:15:24 +0000 (11:15 -0800)]
Remove redundant assignments in define_gf_group_structure()

The functionality has been covered in the above
set_gf_overlay_frame_type() call.

Change-Id: Id4049cd9a1a5a9bad7ea62c412fcb557afa9a572

5 years agoclang-tidy: fix vpx_img_wrap align
Johann [Thu, 1 Nov 2018 21:45:38 +0000 (14:45 -0700)]
clang-tidy: fix vpx_img_wrap align

This function specifically only aligns the stride and not the base buffer
like vpx_img_alloc does.

BUG=webm:1444

Change-Id: I3092827eeec3c9e16306a3973534d3a362a337e8

5 years agoRefactor find_arf_order()
Jingning Han [Mon, 5 Nov 2018 19:12:24 +0000 (11:12 -0800)]
Refactor find_arf_order()

Make the maximum layer depth allowed a control parameter in
GF_GROUP. No coding stats would change.

Change-Id: I9d17167da322831e7013d761980e1c16375a161b

5 years agovp8: Increase rate correction threshold for drop-overshoot
Marco Paniconi [Mon, 5 Nov 2018 17:35:47 +0000 (09:35 -0800)]
vp8: Increase rate correction threshold for drop-overshoot

For 1 pass cbr encoding mode, with frame-dropping on:
increase the rate correction threshold for drop-overshoot detection,
to better capture cases of large overshoot.

Change-Id: I1153b1b71cf106749dd985074d6bc8f37d163c7e

5 years agoMerge "vpx postproc: rewrite in intrinsics"
Johann Koenig [Fri, 2 Nov 2018 18:13:14 +0000 (18:13 +0000)]
Merge "vpx postproc: rewrite in intrinsics"

5 years agoMerge "Add highbd Hadamard transform C implementations"
Sai Deng [Fri, 2 Nov 2018 16:46:46 +0000 (16:46 +0000)]
Merge "Add highbd Hadamard transform C implementations"

5 years agoMerge "fix snprintf error on windows"
Johann Koenig [Fri, 2 Nov 2018 16:23:23 +0000 (16:23 +0000)]
Merge "fix snprintf error on windows"

5 years agoMerge "clang-tidy: normalize variance functions"
Johann Koenig [Fri, 2 Nov 2018 14:41:24 +0000 (14:41 +0000)]
Merge "clang-tidy: normalize variance functions"

5 years agofix snprintf error on windows
Johann [Fri, 2 Nov 2018 14:34:12 +0000 (07:34 -0700)]
fix snprintf error on windows

Include vpx_ports/msvc.h to handle snprintf on older
versions of Visual Studio

Change-Id: I06cd99b32bbae82b3df079d41ff20a9a07f6fe1c

5 years agovp8: remove VP8_ENTROPY_STATS code
Johann [Wed, 31 Oct 2018 21:40:44 +0000 (14:40 -0700)]
vp8: remove VP8_ENTROPY_STATS code

Does not compile. Noticed while cleaning up un-namespaced functions

Change-Id: I4a9048e66d051397f652e7b5412606a5e234f61f

5 years agoAdd highbd Hadamard transform C implementations
sdeng [Tue, 30 Oct 2018 22:35:44 +0000 (15:35 -0700)]
Add highbd Hadamard transform C implementations

Change-Id: Ibec078c80ca1dfe6fbbc4288db89d719dac453a7

5 years agoclang-tidy: fix vpx_dsp parameters
Johann [Tue, 30 Oct 2018 19:59:46 +0000 (12:59 -0700)]
clang-tidy: fix vpx_dsp parameters

BUG=webm:1444

Change-Id: Iee19be068afc6c81396c79218a89c469d2e66207

5 years agoMerge "vp8 boolcoder: normalize to "bc""
Johann Koenig [Wed, 31 Oct 2018 22:39:08 +0000 (22:39 +0000)]
Merge "vp8 boolcoder: normalize to "bc""

5 years agoMerge "vp8: fix to address overflow in decoder."
Jerome Jiang [Wed, 31 Oct 2018 22:27:44 +0000 (22:27 +0000)]
Merge "vp8: fix to address overflow in decoder."

5 years agoMerge "vp8dx_get_quantizer: normalize VP8D_COMP"
Johann Koenig [Wed, 31 Oct 2018 22:19:43 +0000 (22:19 +0000)]
Merge "vp8dx_get_quantizer: normalize VP8D_COMP"

5 years agoclang-tidy: normalize variance functions
Johann [Tue, 30 Oct 2018 21:43:36 +0000 (14:43 -0700)]
clang-tidy: normalize variance functions

Always use src/ref and _ptr/_stride suffixes.

Normalize to [xy]_offset and second_pred.

Drop some stray source/recon_strides.

BUG=webm:1444

Change-Id: I32362a50988eb84464ab78686348610ea40e5c80

5 years agoMerge "clang-tidy: fix vp9/encoder parameters"
Johann Koenig [Wed, 31 Oct 2018 21:43:05 +0000 (21:43 +0000)]
Merge "clang-tidy: fix vp9/encoder parameters"

5 years agoMerge "clang-tidy: fix vp9/decoder parameters"
Johann Koenig [Wed, 31 Oct 2018 21:42:16 +0000 (21:42 +0000)]
Merge "clang-tidy: fix vp9/decoder parameters"

5 years agoMerge "clang-tidy: fix vp9/common parameters"
Johann Koenig [Wed, 31 Oct 2018 21:42:07 +0000 (21:42 +0000)]
Merge "clang-tidy: fix vp9/common parameters"

5 years agoMerge "clang-tidy: fix vp8/encoder parameters"
Johann Koenig [Wed, 31 Oct 2018 21:41:53 +0000 (21:41 +0000)]
Merge "clang-tidy: fix vp8/encoder parameters"

5 years agovp8 boolcoder: normalize to "bc"
Johann [Wed, 31 Oct 2018 21:24:31 +0000 (14:24 -0700)]
vp8 boolcoder: normalize to "bc"

"bc" maps to BOOL_CODER better than "br"

Change-Id: Idefd03e79ccc1851a1b26f8206a159b0e5c5fb2d

5 years agoMerge "clang-tidy: fix vp8/decoder parameters"
Johann Koenig [Wed, 31 Oct 2018 21:14:46 +0000 (21:14 +0000)]
Merge "clang-tidy: fix vp8/decoder parameters"

5 years agovp8dx_get_quantizer: normalize VP8D_COMP
Johann [Wed, 31 Oct 2018 21:13:45 +0000 (14:13 -0700)]
vp8dx_get_quantizer: normalize VP8D_COMP

Use "pbi" like the rest of the functions

Change-Id: I5f3036b8f8361c30353be378d83455b83b82ac9f

5 years agoMerge "Add SSE2 support for hbd 4-tap interpolation filter."
Chi Yo Tsai [Wed, 31 Oct 2018 20:38:52 +0000 (20:38 +0000)]
Merge "Add SSE2 support for hbd 4-tap interpolation filter."

5 years agovp8: fix to address overflow in decoder.
Jerome Jiang [Tue, 7 Aug 2018 18:10:26 +0000 (11:10 -0700)]
vp8: fix to address overflow in decoder.

Can't call internal error from the decoder thread.

Add vpx_internal_error_info to MACROBLOCKD. When corrupted frame
detected, the decoder thread returns to its own context and signal
completion of decoding for current frame.

The main decoding thread will detect error too and return error code to
decoding API call.

Each thread will signal end of decoding of the frame. Main thread waits
for the signal of all other threads to start decoding next frame.

BUG=875626,webm:1496
Change-Id: Icd05fbc558893a4e7d8532c1e7177e7550283a64

5 years agoMerge "clang-tidy: fix vp8/common parameters"
Johann Koenig [Tue, 30 Oct 2018 22:11:59 +0000 (22:11 +0000)]
Merge "clang-tidy: fix vp8/common parameters"

5 years agoclang-tidy: fix vp9/encoder parameters
Johann [Tue, 30 Oct 2018 19:46:39 +0000 (12:46 -0700)]
clang-tidy: fix vp9/encoder parameters

BUG=webm:1444

Change-Id: I6823635eb1a99c3fcca0a8f091878e3ab2fdd2ac

5 years agoclang-tidy: fix vp9/decoder parameters
Johann [Tue, 30 Oct 2018 19:17:22 +0000 (12:17 -0700)]
clang-tidy: fix vp9/decoder parameters

BUG=webm:1444

Change-Id: I9c7c0a4161aaf52436bd5c01d30b035b2ff5508c

5 years agoAdd SSE2 support for hbd 4-tap interpolation filter.
chiyotsai [Mon, 29 Oct 2018 23:12:05 +0000 (16:12 -0700)]
Add SSE2 support for hbd 4-tap interpolation filter.

Unit test performance on bitdepth 10:
    | 4X4 | 8X8 |16X16|64X64|
 2D |1.582|1.461|1.425|1.572|
HORZ|1.643|1.247|1.346|1.345|
VERT|1.378|1.695|2.020|1.763|

Unit test performance on bitdepth 12:

    | 4X4 | 8X8 |16X16|64X64|
 2D |1.578|1.409|1.426|1.497|
HORZ|1.625|1.153|1.323|1.259|
VERT|1.392|1.707|2.030|1.787|

Change-Id: I6df85330ac33fcb17d46e4302b41415dda1219f5

5 years agoclang-tidy: fix vp9/common parameters
Johann [Tue, 30 Oct 2018 18:56:17 +0000 (11:56 -0700)]
clang-tidy: fix vp9/common parameters

BUG=webm:1444

Change-Id: I1a14ad119b3bcbaddcf2291a7521513cf6425635

5 years agoclang-tidy: fix vp8/encoder parameters
Johann [Tue, 30 Oct 2018 18:24:40 +0000 (11:24 -0700)]
clang-tidy: fix vp8/encoder parameters

BUG=webm:1444

Change-Id: I57a305cdab0d62b0745116272fbd5d9257c6e679

5 years agoclang-tidy: fix vp8/decoder parameters
Johann [Tue, 30 Oct 2018 17:55:21 +0000 (10:55 -0700)]
clang-tidy: fix vp8/decoder parameters

BUG=webm:1444

Change-Id: I3dfc56f7f6430d36a1c447d8999733015a001101

5 years agoclang-tidy: fix vp8/common parameters
Johann [Tue, 30 Oct 2018 17:21:58 +0000 (10:21 -0700)]
clang-tidy: fix vp8/common parameters

Match function definitions to declarations

BUG=webm:1444

Change-Id: Ib96d3b735eaf81cece5406c89cc5156bc2cde462

5 years agoMerge "Add AVX2 support for hbd 4-tap interpolation filter."
Chi Yo Tsai [Tue, 30 Oct 2018 16:50:00 +0000 (16:50 +0000)]
Merge "Add AVX2 support for hbd 4-tap interpolation filter."

5 years agoMerge "Properly space qp in q mode for multi-layer ARF"
Jingning Han [Tue, 30 Oct 2018 04:44:09 +0000 (04:44 +0000)]
Merge "Properly space qp in q mode for multi-layer ARF"

5 years agovpx postproc: rewrite in intrinsics
Johann [Thu, 25 Oct 2018 20:37:50 +0000 (13:37 -0700)]
vpx postproc: rewrite in intrinsics

About ~10% faster on 64bit but ~10% slower on 32

Removes the assembly usage of vpx_rv.

Change-Id: I214698fb5677f615dee0a8f5f5bb8f64daf2565e

5 years agoProperly space qp in q mode for multi-layer ARF
Jingning Han [Mon, 29 Oct 2018 21:08:20 +0000 (14:08 -0700)]
Properly space qp in q mode for multi-layer ARF

Space the quantization parameter distribution according to the
layer depth for multi-layer ARF coding structure. This allows
lower layers to have relatively smaller quantization parameters
than higher layers. It improves the compression performance
in constant q mode for multi-layer ARF system:

        avg PSNR      overall PSNR      SSIM
lowres  -0.33%         -0.31%          -1.44%
midres  -0.29%         -0.38%          -1.14%
hdres   -0.27%         -0.49%          -1.02%

Change-Id: I9cfe2f27e6c0029c30614970a46de3045840264e

5 years agoMerge "vp8 bilinear: ensure non-16x16 arrays are aligned"
Johann Koenig [Mon, 29 Oct 2018 22:26:42 +0000 (22:26 +0000)]
Merge "vp8 bilinear: ensure non-16x16 arrays are aligned"

5 years agoAdd AVX2 support for hbd 4-tap interpolation filter.
chiyotsai [Fri, 26 Oct 2018 21:14:28 +0000 (14:14 -0700)]
Add AVX2 support for hbd 4-tap interpolation filter.

Speed gain:

BIT DEPTH | 8TAP FPS | 4TAP FPS | PCT INC |
    10    |   1.69   |   1.85   |  9.46%  |
    12    |   1.64   |   1.78   |  8.54%  |

Speed test is done on jet.y4m on speed 1 profile 2 over 100 frame with
br=500.

Change-Id: I411e122553e2c466be7a26e64b4dd144efb884a9

5 years agovp8 bilinear: ensure non-16x16 arrays are aligned
Johann Koenig [Mon, 29 Oct 2018 18:59:56 +0000 (18:59 +0000)]
vp8 bilinear: ensure non-16x16 arrays are aligned

The 16x16 array was changed to aligned. The 8xN and 4x4 functions
use aligned loads/stores on their internal arrays as well.

BUG=webm:1570

Change-Id: I9cfe53d7c8ed76e8854c2688eb9a509b876471d8

5 years agoMerge "vp8 bilinear: ensure temp array is aligned"
Johann Koenig [Mon, 29 Oct 2018 18:55:52 +0000 (18:55 +0000)]
Merge "vp8 bilinear: ensure temp array is aligned"

5 years agoMerge "Enable 10 bit tpl support"
Sai Deng [Mon, 29 Oct 2018 17:14:09 +0000 (17:14 +0000)]
Merge "Enable 10 bit tpl support"

5 years agovp8 bilinear: ensure temp array is aligned
Johann [Mon, 29 Oct 2018 16:21:15 +0000 (09:21 -0700)]
vp8 bilinear: ensure temp array is aligned

Loads and stores to this array require 16 byte alignment.

BUG=webm:1570

Change-Id: I82c7d21c9539a108930fd030d79caaa0bcd1eeb3

5 years agoMerge "remove "register" keyword"
Johann Koenig [Mon, 29 Oct 2018 02:07:20 +0000 (02:07 +0000)]
Merge "remove "register" keyword"

5 years agoMerge "Remove unused macros from vp9_firstpass.c"
Jingning Han [Sat, 27 Oct 2018 03:56:18 +0000 (03:56 +0000)]
Merge "Remove unused macros from vp9_firstpass.c"

5 years agoEnable 10 bit tpl support
sdeng [Wed, 24 Oct 2018 23:23:24 +0000 (16:23 -0700)]
Enable 10 bit tpl support

         lowres_bd10   midres_bd10
avg_psnr      -0.897        -1.261
ovr_psnr      -0.975        -1.349

Change-Id: Id54f2c419f4edaa91e89ffea52b4038b1d94e563