]>
granicus.if.org Git - php/log
Nikita Popov [Mon, 15 Apr 2019 15:14:11 +0000 (17:14 +0200)]
s/mysql_connect()/mysqli_connect() in php.ini
Christoph M. Becker [Mon, 15 Apr 2019 16:24:59 +0000 (18:24 +0200)]
Use curl_mime_*() functions if available
As of curl 7.56.0, `curl_formadd()` is deprecated in favor of
`curl_mime_*()`, so we use the latter if available.
Dmitry Stogov [Mon, 15 Apr 2019 21:09:45 +0000 (00:09 +0300)]
Merge branch 'PHP-7.4' of git.php.net:php-src into PHP-7.4
* 'PHP-7.4' of git.php.net:php-src:
Remove not needed extension generated files gitignores
Add test for curl_version()
Fixed bug #77895
Zero sockaddr struct
Fix saproxy_property_write signature
Correctly destroy reference in ArrayObject sort
Dmitry Stogov [Mon, 15 Apr 2019 21:08:16 +0000 (00:08 +0300)]
execute_data->return_value is not used for internal functions
Peter Kokot [Mon, 15 Apr 2019 18:03:48 +0000 (20:03 +0200)]
Remove not needed extension generated files gitignores
These were refactored and moved to build directory via:
2957651c5c2a003e96318fc9217764b91266723a and
7e445ef3b1a197dccbc92f35cb66988b66671841
Rodrigo Prado [Mon, 15 Apr 2019 00:40:27 +0000 (21:40 -0300)]
Add test for curl_version()
Nikita Popov [Mon, 15 Apr 2019 13:27:37 +0000 (15:27 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4
Nikita Popov [Mon, 15 Apr 2019 13:27:19 +0000 (15:27 +0200)]
Merge branch 'PHP-7.2' into PHP-7.3
Nikita Popov [Mon, 15 Apr 2019 13:26:58 +0000 (15:26 +0200)]
Fixed bug #77895
Nikita Popov [Mon, 15 Apr 2019 13:00:56 +0000 (15:00 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4
Nikita Popov [Mon, 15 Apr 2019 13:00:49 +0000 (15:00 +0200)]
Merge branch 'PHP-7.2' into PHP-7.3
Nikita Popov [Mon, 15 Apr 2019 12:59:05 +0000 (14:59 +0200)]
Zero sockaddr struct
in6 has a bunch of extra fields that we're leaving uninitialized. I
don't see them locally, but there's valgrind warnings on gcov.
Nikita Popov [Mon, 15 Apr 2019 12:33:47 +0000 (14:33 +0200)]
Fix saproxy_property_write signature
Nikita Popov [Mon, 15 Apr 2019 11:16:16 +0000 (13:16 +0200)]
Correctly destroy reference in ArrayObject sort
The reference may be captured in an exception backtrace, in which
case the refcount may be more than one.
Dmitry Stogov [Mon, 15 Apr 2019 10:18:16 +0000 (13:18 +0300)]
Removed tests that always (or almost always) true
Nikita Popov [Mon, 15 Apr 2019 09:40:37 +0000 (11:40 +0200)]
Try to fix stat_variation3-win32.phpt
After fixing comparison operator typos in
f73c104927b64d6137cbe42bf42260d9349cbd02 this test is failing. I
believe the comparison here should be using < rather than ==.
Nikita Popov [Mon, 15 Apr 2019 09:35:13 +0000 (11:35 +0200)]
Fix last maybe uninit warnings on 7.4
Most of these only occur under GCC 5. Not fond of all the workarounds
(especially the PDO one), but it gets us a clean build...
Nikita Popov [Mon, 15 Apr 2019 08:59:45 +0000 (10:59 +0200)]
Avoid maybe uninit warning in libmagic
GCC 5 false positive, gone in newer versions.
Nikita Popov [Mon, 15 Apr 2019 08:54:39 +0000 (10:54 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4
Nikita Popov [Mon, 15 Apr 2019 08:54:31 +0000 (10:54 +0200)]
Merge branch 'PHP-7.2' into PHP-7.3
Nikita Popov [Mon, 15 Apr 2019 08:53:33 +0000 (10:53 +0200)]
Fix uninitialized cert_captured
This is a legimitimate bug and also shows up under valgrind.
Nikita Popov [Mon, 15 Apr 2019 08:43:49 +0000 (10:43 +0200)]
Disable strict aliasing warnings
It seems like GCC 5 likes to warn about exactly those trivial strict
aliasing violations that it's not going to miscompile anyway and the
warnings are gone in newer versions. Just disable the noise.
Nikita Popov [Mon, 15 Apr 2019 08:25:20 +0000 (10:25 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4
Nikita Popov [Mon, 15 Apr 2019 08:25:00 +0000 (10:25 +0200)]
Merge branch 'PHP-7.2' into PHP-7.3
Nikita Popov [Mon, 15 Apr 2019 08:22:40 +0000 (10:22 +0200)]
Fixed bug #77882
Côme Chilliet [Mon, 15 Apr 2019 08:20:12 +0000 (10:20 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4
* PHP-7.3:
Updated NEWS
Fix a NULL dereferencing crash in php-ldap
Côme Chilliet [Mon, 15 Apr 2019 08:19:19 +0000 (10:19 +0200)]
Updated NEWS
Côme Chilliet [Mon, 15 Apr 2019 08:16:29 +0000 (10:16 +0200)]
Fix a NULL dereferencing crash in php-ldap
This happens when parsing a control response to a VLV request which does
not contain a "context" string.
See bug #77869
Rodrigo Prado [Mon, 15 Apr 2019 00:15:23 +0000 (21:15 -0300)]
Remove functions from func_info that were removed in PHP 7
Nikita Popov [Mon, 15 Apr 2019 07:48:39 +0000 (09:48 +0200)]
Fix incorrect compare_stats operator
Gabriel Caruso [Sat, 16 Mar 2019 09:14:01 +0000 (06:14 -0300)]
Remove HAVE_* for always available extensions
Peter Kokot [Tue, 9 Apr 2019 23:04:02 +0000 (01:04 +0200)]
Disable PACKAGE_* preprocessor symbols
Autoconf defines PACKAGE_* symbols:
- PACKAGE_NAME
- PACKAGE_VERSION
- PACKAGE_TARNAME
- PACKAGE_STRING
- PACKAGE_BUGREPORT
- PACKAGE_URL
and appends them to the generated config.h.in files. With AC_INIT change
via
afd52f9d9986d92dd0c63832a07ab1a16bf11d53 where package version, URL,
bug report location and similar meta data are defined, these
preprocessor macros are then non empty strings in the generated
configuration header file. When using phpize, PHP shares the config
files in extensions, warnings of redefined macros appear, such as:
- `warning: 'PACKAGE_NAME' macro redefined`
This patch now disables these non utilized symbols in the generated
config header files.
Better practice would be to include only API specific headers where
needed but this would require even more refactorings. Some extensions
such as pcre, pgsql, and pdo_pgsql solve this issue by undefining some
of these symbols before including the library configuration headers in
the code also. Because these symbols can be defined by any library which
uses Autotools.
Additionally, the unused PACKAGE_* symbols were cleaned for the bundled
libmbfl library and with this patch not needed undef code removed.
Peter Kokot [Sat, 13 Apr 2019 02:45:28 +0000 (04:45 +0200)]
Remove PHP_READDIR_R_TYPE
The PHP_READDIR_R_TYPE m4 macro has been removed via
2b28f7189144a21e753dbc09efadd571121a82b9 .
HAVE_POSIX_READDIR_R in windows header file is also not needed anymore.
George Wang [Fri, 12 Apr 2019 21:48:22 +0000 (17:48 -0400)]
Merge branch 'PHP-7.3' into PHP-7.4
George Wang [Fri, 12 Apr 2019 21:44:32 +0000 (17:44 -0400)]
Merge branch 'PHP-7.2' into PHP-7.3
George Wang [Fri, 12 Apr 2019 21:43:45 +0000 (17:43 -0400)]
LiteSpeed SAPI 7.3, better process management, new API function litespeed_finish_request().
Nikita Popov [Fri, 12 Apr 2019 15:04:44 +0000 (17:04 +0200)]
Try to fix windows build
noreturn attribute has to be on the declaration as well.
Nikita Popov [Fri, 12 Apr 2019 14:46:23 +0000 (16:46 +0200)]
Fix strict aliasing violation in phpdbg
By explicitly computing the message length from bytes. This also
makes sure that the length is interpreted in an endianness-independent
manner.
Nikita Popov [Fri, 12 Apr 2019 14:17:35 +0000 (16:17 +0200)]
Don't use php_strtok_r in build_tablename
This is unnecessary convoluted... we just want to find the position
of the dot. Using php_strtok_r requires a copy of the string, and the
implementation also relied on the specific semantics of the scratch
space that strtok_r uses.
Nikita Popov [Fri, 12 Apr 2019 14:03:01 +0000 (16:03 +0200)]
Fix uninit warning in gd.c
This matches the upstream implementation.
Nikita Popov [Fri, 12 Apr 2019 13:54:29 +0000 (15:54 +0200)]
Avoid uninit warning in ftp
Nikita Popov [Fri, 12 Apr 2019 13:10:17 +0000 (15:10 +0200)]
Remove dubious memcmp optimization in iconv
This violates strict aliasing, and appears entirely unnecessary --
the compiler can optimize fixed size memcmp's by itself.
Nikita Popov [Fri, 12 Apr 2019 13:00:55 +0000 (15:00 +0200)]
Avoid uninit warnin in http_fopen_wrapper
This one looks semi-legit, in case php_stream_eof() returns false
but php_stream_get_line() fails. Not totally sure this cannot
happen, so rewriting to check both conditions at once.
Nikita Popov [Fri, 12 Apr 2019 12:56:21 +0000 (14:56 +0200)]
Avoid uninit warning in dtoa
This code is extremely convoluted, I have no idea whether or not
this one is legitimate. Suppressing with explicit initialization.
Nikita Popov [Fri, 12 Apr 2019 12:55:37 +0000 (14:55 +0200)]
Avoid misc uninitialized variable warnings
Nikita Popov [Fri, 12 Apr 2019 12:32:29 +0000 (14:32 +0200)]
Avoid uninitialized variable warnings in gmp
Nikita Popov [Fri, 12 Apr 2019 11:38:51 +0000 (13:38 +0200)]
Add test for get_cfg_var with array variable
And fix incorrect variable shadowing in add_config_entry(). However,
the test doesn't hit this case, as it requires a nested array. I'm
not sure if it's possible to produce nested arrays from ini?
Nikita Popov [Fri, 12 Apr 2019 11:18:23 +0000 (13:18 +0200)]
Avoid unitialized variable warning in soap
Extract envelope fetch into separate function, so the control
flow becomes more obvious.
Christoph M. Becker [Fri, 12 Apr 2019 12:12:08 +0000 (14:12 +0200)]
Include libpq-fs.h on Windows, too
That's more future proof than defining hard-coded macros.
Christoph M. Becker [Fri, 12 Apr 2019 11:08:44 +0000 (13:08 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4
* PHP-7.3:
Fix tests wrt. internationalization
Christoph M. Becker [Fri, 12 Apr 2019 11:08:13 +0000 (13:08 +0200)]
Merge branch 'PHP-7.2' into PHP-7.3
* PHP-7.2:
Fix tests wrt. internationalization
Christoph M. Becker [Fri, 12 Apr 2019 11:05:16 +0000 (13:05 +0200)]
Fix tests wrt. internationalization
Nikita Popov [Fri, 12 Apr 2019 10:47:39 +0000 (12:47 +0200)]
Fix SOAP bailout handling
This code was reusing the _bailout variable from
SOAP_CLIENT_BEGIN/END_CODE(). As _bailout is not volatile, modifying
it after the setjmp call and then reading it back on return is
illegal. Use a separate local bailout variable instead.
This fixes the miscompile introduced by marking zend_bailout() as
noreturn.
Nikita Popov [Fri, 12 Apr 2019 10:09:09 +0000 (12:09 +0200)]
Enable -Wall on release builds for GCC
-Wall was already enabled for debug builds, enable it for release
builds as well.
Nikita Popov [Fri, 12 Apr 2019 10:01:42 +0000 (12:01 +0200)]
Fix unused variable warnings in libmagic
These variables are only used in assertions.
Nikita Popov [Fri, 12 Apr 2019 09:56:37 +0000 (11:56 +0200)]
Remove odd variable assignment in escape_analysis
As we are breaking out of the for loop setting i = ssa_vars_count
doesn't do anything, but it confuses GCC into throwing a no-overflow
assumption warning.
Nikita Popov [Fri, 12 Apr 2019 09:20:29 +0000 (11:20 +0200)]
Fix potentially uninitialized warnings in phpdbg
Nikita Popov [Fri, 12 Apr 2019 09:11:53 +0000 (11:11 +0200)]
Regroup expressions in php_schema.c to avoid array bounds warnings
Nikita Popov [Fri, 12 Apr 2019 09:01:56 +0000 (11:01 +0200)]
Avoid potentially-uninitialized warnings in readline
Nikita Popov [Fri, 12 Apr 2019 08:49:56 +0000 (10:49 +0200)]
Fix uninitializde heredoc_tag use in readline
Could happen if "<<<" is directly followed by a newline.
Nikita Popov [Fri, 12 Apr 2019 08:41:53 +0000 (10:41 +0200)]
Mark zend_bailout() as a noreturn function
Nikita Popov [Fri, 12 Apr 2019 08:37:17 +0000 (10:37 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4
Nikita Popov [Fri, 12 Apr 2019 08:37:08 +0000 (10:37 +0200)]
Merge branch 'PHP-7.2' into PHP-7.3
Nikita Popov [Fri, 12 Apr 2019 08:36:26 +0000 (10:36 +0200)]
Fix key leaks in mb_convert_encoding()
Nikita Popov [Fri, 12 Apr 2019 08:26:11 +0000 (10:26 +0200)]
Use EMPTY_SWITCH_DEFAULT_CASE in php_unicode.c
Avoids a potentially uninitialized variable warning.
Nikita Popov [Fri, 12 Apr 2019 08:05:15 +0000 (10:05 +0200)]
Run compile step under travis_wait
If there are no warnings, we may end up compiling more than 10
minutes without output, in which case the build times out. Use
travis_wait to avoid this.
Nikita Popov [Fri, 12 Apr 2019 07:56:46 +0000 (09:56 +0200)]
Avoid directory clash in realpath tests
Dmitry Stogov [Thu, 11 Apr 2019 23:35:42 +0000 (02:35 +0300)]
Backported call frame initialization improvement
Dmitry Stogov [Thu, 11 Apr 2019 21:49:45 +0000 (00:49 +0300)]
Replace "ZEND_CALL_CTOR" hack by additional live-range
Dmitry Stogov [Thu, 11 Apr 2019 18:37:10 +0000 (21:37 +0300)]
Added test
Christoph M. Becker [Thu, 11 Apr 2019 16:31:17 +0000 (18:31 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4
* PHP-7.3:
Fix potential OPcache file cache related issues
Christoph M. Becker [Thu, 11 Apr 2019 16:30:27 +0000 (18:30 +0200)]
Merge branch 'PHP-7.2' into PHP-7.3
* PHP-7.2:
Fix potential OPcache file cache related issues
Anatol Belski [Thu, 11 Apr 2019 16:17:03 +0000 (18:17 +0200)]
Fix potential OPcache file cache related issues
To solve issues detected during testing, we backport the following
commits to PHP 7.2:
129c5c1181bf344b37e13fd6dc5dfe76c13d7208
9ac133a0b3863ca4d9659140154ee237e5f4669a
ce72bc6b658c335dd37393d0beb28584e6805e97
Nikita Popov [Thu, 11 Apr 2019 15:44:20 +0000 (17:44 +0200)]
Work around -Walloc-size-larger-than bug
Markus Staab [Thu, 11 Apr 2019 13:46:32 +0000 (15:46 +0200)]
Fixed typo
Nikita Popov [Thu, 11 Apr 2019 12:25:40 +0000 (14:25 +0200)]
Use readdir() instead of readdir_r()
readdir_r() is deprecated in modern glibc versions. readdir() is
thread safe in practice, as long as there are no concurrent accesses
on the *same* directory stream.
Nikita Popov [Thu, 11 Apr 2019 14:45:45 +0000 (16:45 +0200)]
Remove curl gnutls locking
This is only relevant for the gcrypt backend, which is no longer in
use. I couldn't find any hard info on when exactly gcrypt support was
dropped, but nette is the default since 2.11.1. Most code that still
has the gcrypt handling is checking against < 2.12. In either case,
those versions were released in 2010/2011.
Nikita Popov [Thu, 11 Apr 2019 13:54:09 +0000 (15:54 +0200)]
Fix libgd warnings
Nikita Popov [Thu, 11 Apr 2019 13:47:41 +0000 (15:47 +0200)]
Remove incorrect mbstring includes
And thus fix unused variable warnings.
Nikita Popov [Thu, 11 Apr 2019 13:39:24 +0000 (15:39 +0200)]
Remove unused function prototype
Nikita Popov [Thu, 11 Apr 2019 13:32:30 +0000 (15:32 +0200)]
Remove restrict zend_portability define
We're not using this anywhere, and it causes warnings, so I'm
dropping it. If we do end up needing this, it should be reintroduced
with a ZEND_ prefix.
Nikita Popov [Thu, 11 Apr 2019 13:22:59 +0000 (15:22 +0200)]
Fix error message in spl_autoload test
Nikita Popov [Thu, 11 Apr 2019 13:20:05 +0000 (15:20 +0200)]
Fix libmagic warnings
Nikita Popov [Thu, 11 Apr 2019 13:12:20 +0000 (15:12 +0200)]
Add script to generate libmagic.patch
Nikita Popov [Thu, 11 Apr 2019 12:12:38 +0000 (14:12 +0200)]
Remove the readline thread-safety warning
Would be nice to have this in configure, but we'd have to change
the ordering of extension & Zend processing for that.
Nikita Popov [Thu, 11 Apr 2019 11:58:20 +0000 (13:58 +0200)]
Fix pointer signedness warning in mysqlnd
Nikita Popov [Thu, 11 Apr 2019 11:55:11 +0000 (13:55 +0200)]
Remove unused rcsid variables
Nikita Popov [Thu, 11 Apr 2019 10:56:42 +0000 (12:56 +0200)]
Avoid curl ssl callback warnings with OpenSSL 1.1
Sebastian Bergmann [Thu, 11 Apr 2019 11:34:02 +0000 (13:34 +0200)]
Fix typo
Dmitry Stogov [Thu, 11 Apr 2019 11:24:04 +0000 (14:24 +0300)]
Fixed bug #77877 (call_user_func() passes $this to satatic methods).
Nikita Popov [Thu, 11 Apr 2019 10:36:01 +0000 (12:36 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4
Nikita Popov [Thu, 11 Apr 2019 10:34:18 +0000 (12:34 +0200)]
Avoid onig match param unused variable warning
Nikita Popov [Thu, 11 Apr 2019 10:22:52 +0000 (12:22 +0200)]
Suppress warnings using zend_quiet_write
Nikita Popov [Thu, 11 Apr 2019 08:48:52 +0000 (10:48 +0200)]
Generate ZEND_COUNT for sizeof()
sizeof() is an alias of count(), so we should generate the same
code for them.
Nikita Popov [Thu, 11 Apr 2019 08:40:54 +0000 (10:40 +0200)]
Make tsrm_env_lock() void
We're not checking the return value and the NTS version of this
generates warnings. If we want to handle lock failures, we should
do a hard abort inside tsrm_env_lock() itself.
Anatol Belski [Wed, 10 Apr 2019 13:47:36 +0000 (15:47 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4
* PHP-7.3:
Ensure double slashes are replaced by the path normalization
Nikita Popov [Mon, 25 Mar 2019 14:23:11 +0000 (15:23 +0100)]
Support VirtualProtect for opcache.protect_memory
Don't enable this on AppVeyor yet, as there is still an open
issue in phar.
Anatol Belski [Wed, 10 Apr 2019 13:20:36 +0000 (15:20 +0200)]
Ensure double slashes are replaced by the path normalization
Anatol Belski [Wed, 10 Apr 2019 12:57:04 +0000 (14:57 +0200)]
Merge branch 'PHP-7.3' into PHP-7.4
* PHP-7.3:
Fix phar:// include handling with file cache
Anatol Belski [Wed, 10 Apr 2019 12:56:29 +0000 (14:56 +0200)]
Merge branch 'PHP-7.2' into PHP-7.3
* PHP-7.2:
Fix phar:// include handling with file cache