]> granicus.if.org Git - apache/log
apache
22 years agoThis fixes a failed assert when r->remaining is left in a negative
Aaron Bannert [Fri, 31 May 2002 00:23:34 +0000 (00:23 +0000)]
This fixes a failed assert when r->remaining is left in a negative
state and we hit some other error (like permission failure) causing
an internal redirect causing us to reevaluate the input buffers
(for discarding the request body).

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95419 13f79535-47bb-0310-9956-ffa450edef68

22 years agoThis should have remained cleanup not a re-creation.
Justin Erenkrantz [Thu, 30 May 2002 23:27:15 +0000 (23:27 +0000)]
This should have remained cleanup not a re-creation.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95418 13f79535-47bb-0310-9956-ffa450edef68

22 years agoshowstoppers++; (groan)
Justin Erenkrantz [Thu, 30 May 2002 23:17:23 +0000 (23:17 +0000)]
showstoppers++;  (groan)

I need to step away from this for a half hour or so because I'm
completely confused as to how we are even getting in this state.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95417 13f79535-47bb-0310-9956-ffa450edef68

22 years ago- Fix case where the initial chunk length was 0 was not handled correctly.
Justin Erenkrantz [Thu, 30 May 2002 23:13:16 +0000 (23:13 +0000)]
- Fix case where the initial chunk length was 0 was not handled correctly.
- Fix bucket lifetimes so that they don't live longer than their brigades.
  That's not nice.
- Simplify some usage of f->r->connection to f->c in the bucket creation
  calls.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95416 13f79535-47bb-0310-9956-ffa450edef68

22 years agoThis definitely gets the award for least useful error message of the month.
Cliff Woolley [Thu, 30 May 2002 22:39:08 +0000 (22:39 +0000)]
This definitely gets the award for least useful error message of the month.

Not only should it just say "can't do that on win32," which is after all
the bottom line, it was spitting out openssl error messages which were
totally useless.  Eg:

[30/May/2002 17:31:17 05760] [error] Init: PassPhraseDialog BuiltIn not
supported in server private key from file
F:/Apache/Apache2/conf/ssl/secure.key (OpenSSL library error follows)
[30/May/2002 17:31:17 05760] [error] OpenSSL: error:0D084069:asn1
encoding routines:d2i_ASN1_SET:bad tag
[30/May/2002 17:31:17 05760] [error] OpenSSL: error:0D09D082:asn1
encoding routines:d2i_RSAPrivateKey:parsing
[30/May/2002 17:31:17 05760] [error] OpenSSL: error:0D09B00D:asn1
encoding routines:d2i_PrivateKey:ASN1 lib

Which is essentially saying "OpenSSL couldn't read your private key because
it was encrypted, and we can't get the passphrase the way you asked us to
on this platform."

Brought to my attention by the inquiry of:  Chris Hsiang <chsiang@ivivos.com>

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95415 13f79535-47bb-0310-9956-ffa450edef68

22 years agoWhy the stack buffer and the copy? This seems much more straightforward.
Cliff Woolley [Thu, 30 May 2002 22:06:01 +0000 (22:06 +0000)]
Why the stack buffer and the copy?  This seems much more straightforward.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95413 13f79535-47bb-0310-9956-ffa450edef68

22 years agomod_bucketeer needs to preserve error buckets if it sees them rather
Justin Erenkrantz [Thu, 30 May 2002 21:10:19 +0000 (21:10 +0000)]
mod_bucketeer needs to preserve error buckets if it sees them rather
than silently discarding them.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95412 13f79535-47bb-0310-9956-ffa450edef68

22 years agoLet the error bucket implement the simple copy routine.
Justin Erenkrantz [Thu, 30 May 2002 21:09:23 +0000 (21:09 +0000)]
Let the error bucket implement the simple copy routine.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95411 13f79535-47bb-0310-9956-ffa450edef68

22 years agoAdd macro to check for an error bucket. (Can't call it APR_BUCKET_IS_ERROR
Justin Erenkrantz [Thu, 30 May 2002 21:08:21 +0000 (21:08 +0000)]
Add macro to check for an error bucket.  (Can't call it APR_BUCKET_IS_ERROR
since error bucket is private to httpd - hence the AP_ prefix.)

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95410 13f79535-47bb-0310-9956-ffa450edef68

22 years agosome comments after testing "apxs -g" from a 2.0.36 binbuild
Jeff Trawick [Thu, 30 May 2002 20:20:30 +0000 (20:20 +0000)]
some comments after testing "apxs -g" from a 2.0.36 binbuild

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95409 13f79535-47bb-0310-9956-ffa450edef68

22 years ago Based on DougM's feedback to the list...
William A. Rowe Jr [Thu, 30 May 2002 19:19:20 +0000 (19:19 +0000)]
  Based on DougM's feedback to the list...

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95408 13f79535-47bb-0310-9956-ffa450edef68

22 years ago Apparently Roy missed this comment. Rephrase as a seperate paragraph
William A. Rowe Jr [Thu, 30 May 2002 18:50:43 +0000 (18:50 +0000)]
  Apparently Roy missed this comment.  Rephrase as a seperate paragraph
  to more clearly split credit for OpenSSL from credit for mod_ssl.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95407 13f79535-47bb-0310-9956-ffa450edef68

22 years ago Split out the LAYOUT
William A. Rowe Jr [Thu, 30 May 2002 18:17:16 +0000 (18:17 +0000)]
  Split out the LAYOUT

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95406 13f79535-47bb-0310-9956-ffa450edef68

22 years ago As we find the right places for this content, move them out in bits
William A. Rowe Jr [Thu, 30 May 2002 17:37:54 +0000 (17:37 +0000)]
  As we find the right places for this content, move them out in bits

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95405 13f79535-47bb-0310-9956-ffa450edef68

22 years agoclear up some warnings about unused variables
Ian Holsman [Thu, 30 May 2002 16:34:38 +0000 (16:34 +0000)]
clear up some warnings about unused variables

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95404 13f79535-47bb-0310-9956-ffa450edef68

22 years ago Thanks for verifying these are valid, Doug. Now this [much shorter]
William A. Rowe Jr [Thu, 30 May 2002 16:00:28 +0000 (16:00 +0000)]
  Thanks for verifying these are valid, Doug.  Now this [much shorter]
  list should be living in our STATUS file.  Question of module maps
  and file layout is already off to the list.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95403 13f79535-47bb-0310-9956-ffa450edef68

22 years agoA tiny bit more clarification of _default_.
Joshua Slive [Thu, 30 May 2002 13:26:08 +0000 (13:26 +0000)]
A tiny bit more clarification of _default_.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95402 13f79535-47bb-0310-9956-ffa450edef68

22 years agoToo many people seem to try to use _default_ with name-virtual hosts.
Joshua Slive [Thu, 30 May 2002 13:18:54 +0000 (13:18 +0000)]
Too many people seem to try to use _default_ with name-virtual hosts.
Maybe this will help?

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95401 13f79535-47bb-0310-9956-ffa450edef68

22 years agokeep the signed-ness of char buffers consistent with what is expected
Jeff Trawick [Thu, 30 May 2002 11:00:42 +0000 (11:00 +0000)]
keep the signed-ness of char buffers consistent with what is expected
by functions they are passed to (putLong() this time)

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95399 13f79535-47bb-0310-9956-ffa450edef68

22 years agoUnroll the putLong and getLong loops and correct putLong's input param type to
Justin Erenkrantz [Thu, 30 May 2002 08:32:09 +0000 (08:32 +0000)]
Unroll the putLong and getLong loops and correct putLong's input param type to
be unsigned char* instead of char*.

Submitted by: Sander Striker
Reviewed by: Justin Erenkrantz

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95397 13f79535-47bb-0310-9956-ffa450edef68

22 years agoUpdate Japanese translation.
Yoshiki Hayashi [Thu, 30 May 2002 07:53:10 +0000 (07:53 +0000)]
Update Japanese translation.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95396 13f79535-47bb-0310-9956-ffa450edef68

22 years agoNew Japanese translation.
Yoshiki Hayashi [Thu, 30 May 2002 07:51:47 +0000 (07:51 +0000)]
New Japanese translation.

Submitted by: Hiroaki KAWAI <hawk@bcl.t.u-tokyo.ac.jp>

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95395 13f79535-47bb-0310-9956-ffa450edef68

22 years agoSwitch mod_proxy to using the brigade/filter calls directly rather than
Justin Erenkrantz [Thu, 30 May 2002 07:33:59 +0000 (07:33 +0000)]
Switch mod_proxy to using the brigade/filter calls directly rather than
the *_client_block calls.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95394 13f79535-47bb-0310-9956-ffa450edef68

22 years agoNew Japanese translation. Forward port from 1.3.
Yoshiki Hayashi [Thu, 30 May 2002 07:27:50 +0000 (07:27 +0000)]
New Japanese translation.  Forward port from 1.3.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95393 13f79535-47bb-0310-9956-ffa450edef68

22 years agoNew Japanese translation. Forward port from 1.3.
Yoshiki Hayashi [Thu, 30 May 2002 07:22:08 +0000 (07:22 +0000)]
New Japanese translation.  Forward port from 1.3.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95392 13f79535-47bb-0310-9956-ffa450edef68

22 years agoNew Japanese translation.
Yoshiki Hayashi [Thu, 30 May 2002 07:17:37 +0000 (07:17 +0000)]
New Japanese translation.

Submitted by: Hiroaki KAWAI <hawk@bcl.t.u-tokyo.ac.jp>
Reviewed by: Yoshiki Hayashi

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95391 13f79535-47bb-0310-9956-ffa450edef68

22 years agoAdd a PROXYREQ_RESPONSE value for request_rec->proxyreq because it is
Justin Erenkrantz [Thu, 30 May 2002 07:04:45 +0000 (07:04 +0000)]
Add a PROXYREQ_RESPONSE value for request_rec->proxyreq because it is
possible that there can be different behavior at the protocol level if
request_rec isn't really a request but a response.

This stems from the fact that request bodies must be indicated by
Content-Length or Transfer-Encoding, but response bodies do not.  The
recent change to ap_http_filter to return EOS if there isn't a body broke
proxy.  Therefore, there must be some way for the proxy to indicate that
this is a response.  Accordingly, ap_http_filter can allow the BODY_NONE
iff this is a response.

Since r->proxyreq is set to PROXYREQ_PROXY even for the original request
from the client, that value isn't sufficient.  Hence, the introduction of
PROXYREQ_RESPONSE.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95390 13f79535-47bb-0310-9956-ffa450edef68

22 years ago All rather stale. Any new/remaining issues should be moved to CHANGES
William A. Rowe Jr [Thu, 30 May 2002 06:02:15 +0000 (06:02 +0000)]
  All rather stale.  Any new/remaining issues should be moved to CHANGES
  in the present tense, as opposed to the "Future port to 2.0".  Heh

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95389 13f79535-47bb-0310-9956-ffa450edef68

22 years agoImagine the horror. I go to try compiling PHP4, and it bombs out on
Cliff Woolley [Thu, 30 May 2002 05:57:33 +0000 (05:57 +0000)]
Imagine the horror.  I go to try compiling PHP4, and it bombs out on
r->boundary.  BUT WAIT, I say, we have a test in there for that:
#if !MODULE_MAGIC_AT_LEAST(20020506,0).  The test doesn't seem to be
working.  That's odd, I think.  So I go look at the ap_mmn.h.  Egad,
the tests are totally backwards.  How on earth are we going to handle this?
Surely it's wrong in 1.3.x as well.  So I go look.  Nope, turns out it
got fixed TWO YEARS AGO in that repository.  Sigh.  Anyway, thanks Greg.
:)

Submitted by: Greg Stein, circa Apache 1.3.13

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95388 13f79535-47bb-0310-9956-ffa450edef68

22 years ago Now a moot issue.
William A. Rowe Jr [Thu, 30 May 2002 05:54:43 +0000 (05:54 +0000)]
  Now a moot issue.

  Isn't it time to just drop "PRs that have been suspended forever waiting
  for someone to put them into 'the next release'" if they have no status?

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95387 13f79535-47bb-0310-9956-ffa450edef68

22 years agomod_cgid got hit too with this change
Justin Erenkrantz [Thu, 30 May 2002 05:43:35 +0000 (05:43 +0000)]
mod_cgid got hit too with this change

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95386 13f79535-47bb-0310-9956-ffa450edef68

22 years agoApply same patch to mod_cgid that was applied to mod_cgi so that it
Justin Erenkrantz [Thu, 30 May 2002 05:42:46 +0000 (05:42 +0000)]
Apply same patch to mod_cgid that was applied to mod_cgi so that it
bypasses the *_client_block calls in favor of using the input filters
and brigades directly.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95385 13f79535-47bb-0310-9956-ffa450edef68

22 years ago Goodness
William A. Rowe Jr [Thu, 30 May 2002 05:31:20 +0000 (05:31 +0000)]
  Goodness

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95383 13f79535-47bb-0310-9956-ffa450edef68

22 years agookay then :)
Cliff Woolley [Thu, 30 May 2002 05:09:24 +0000 (05:09 +0000)]
okay then :)

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95382 13f79535-47bb-0310-9956-ffa450edef68

22 years agoYet another reason the MMN needs to get bumped. If there are changes
Cliff Woolley [Thu, 30 May 2002 05:04:32 +0000 (05:04 +0000)]
Yet another reason the MMN needs to get bumped.  If there are changes
that anyone's been holding off on because they would affect the MMN, might
as well get them in now so we minimize the number of releases with MMN
changes.  I believe there are more renames pending in APR that should be
done sooner rather than later, for example.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95381 13f79535-47bb-0310-9956-ffa450edef68

22 years ago Always using -t "Window Title" option myself, so I never caught this.
William A. Rowe Jr [Thu, 30 May 2002 04:47:03 +0000 (04:47 +0000)]
  Always using -t "Window Title" option myself, so I never caught this.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95380 13f79535-47bb-0310-9956-ffa450edef68

22 years ago Four column tabs, no less? Just a formatting fix
William A. Rowe Jr [Thu, 30 May 2002 04:33:51 +0000 (04:33 +0000)]
  Four column tabs, no less?  Just a formatting fix

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95379 13f79535-47bb-0310-9956-ffa450edef68

22 years agoA clean prefork build starts up for me on Darwin. Will try with worker later.
Justin Erenkrantz [Thu, 30 May 2002 02:55:56 +0000 (02:55 +0000)]
A clean prefork build starts up for me on Darwin.  Will try with worker later.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95378 13f79535-47bb-0310-9956-ffa450edef68

22 years agoFix some subscriptions and a typo.
Joshua Slive [Thu, 30 May 2002 01:50:04 +0000 (01:50 +0000)]
Fix some subscriptions and a typo.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95377 13f79535-47bb-0310-9956-ffa450edef68

22 years agoRewrite mod_cgi's input handling to use brigades and input filters directly.
Justin Erenkrantz [Thu, 30 May 2002 00:36:58 +0000 (00:36 +0000)]
Rewrite mod_cgi's input handling to use brigades and input filters directly.
This removes the unnecessary overhead of the *_client_block functions.

Optimize usage of the dbuf char* (don't do pcalloc on it!)

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95376 13f79535-47bb-0310-9956-ffa450edef68

22 years agoThanks Ryan for cleaning up after my laziness. :) Here are just a few
Cliff Woolley [Thu, 30 May 2002 00:35:25 +0000 (00:35 +0000)]
Thanks Ryan for cleaning up after my laziness.  :)  Here are just a few
last little changes.  ->datafile should be initialized... but doing so
brings up the fact that the check in run_rewritemap_programs() was
expecting ->datafile to have a string attached to it.  For clarity,
let's just use argv[0] there.  And since we've reinstated the use of
->checkfile, we no longer need that extra apr_stat() I hacked in,
so let's get rid of it.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95375 13f79535-47bb-0310-9956-ffa450edef68

22 years ago- Remove APR_STATUS_IS_SUCCESS calls in favor of directly testing APR_SUCCESS.
Justin Erenkrantz [Thu, 30 May 2002 00:30:28 +0000 (00:30 +0000)]
- Remove APR_STATUS_IS_SUCCESS calls in favor of directly testing APR_SUCCESS.
- Minor style nit with spaces.
(No functional changes.)

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95374 13f79535-47bb-0310-9956-ffa450edef68

22 years agoCatch up with the apr_allocator_set_owner -> apr_allocator_owner_set renames
Sander Striker [Thu, 30 May 2002 00:21:27 +0000 (00:21 +0000)]
Catch up with the apr_allocator_set_owner -> apr_allocator_owner_set renames
in APR.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95373 13f79535-47bb-0310-9956-ffa450edef68

22 years agoTokenize the arguments for rewrite programs during config parsing, and
Ryan Bloom [Thu, 30 May 2002 00:02:59 +0000 (00:02 +0000)]
Tokenize the arguments for rewrite programs during config parsing, and
just use that information later.  I was having a problem with prg
directives with arguments failing the configuration.  The problem was
a call to stat, which was being passed the program name and the arguments.
Obviously, the arguments were messing up the call to stat.  This gets the
test suite working for me again.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95372 13f79535-47bb-0310-9956-ffa450edef68

22 years agoCall apr_file_write_full instead to achieve the same effect.
Justin Erenkrantz [Wed, 29 May 2002 23:06:12 +0000 (23:06 +0000)]
Call apr_file_write_full instead to achieve the same effect.

apr_file_write_full is *guaranteed* to either write everything or return
an error.  It'll only write short if it received an error.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95371 13f79535-47bb-0310-9956-ffa450edef68

22 years agoAs discussed previously on-list, HTTP_IN should return EOS if it thinks
Justin Erenkrantz [Wed, 29 May 2002 23:04:14 +0000 (23:04 +0000)]
As discussed previously on-list, HTTP_IN should return EOS if it thinks
there is no request body.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95370 13f79535-47bb-0310-9956-ffa450edef68

22 years agoStylistic changes - remove tabs, clean up long lines, etc.
Justin Erenkrantz [Wed, 29 May 2002 22:27:37 +0000 (22:27 +0000)]
Stylistic changes - remove tabs, clean up long lines, etc.
(No functional changes.)
(Functional optimizations/cleanups coming later...)

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95369 13f79535-47bb-0310-9956-ffa450edef68

22 years agoI'm holding off on the pool patches until they settle down a bit.
Cliff Woolley [Wed, 29 May 2002 22:15:44 +0000 (22:15 +0000)]
I'm holding off on the pool patches until they settle down a bit.

Getting ready to tag PRE2.  We already know there will be a PRE3, but
this is just to help me in my RM duties later on.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95368 13f79535-47bb-0310-9956-ffa450edef68

22 years agoFinally got rotatelogs working on NetWare
Bradley Nicholes [Wed, 29 May 2002 21:28:05 +0000 (21:28 +0000)]
Finally got rotatelogs working on NetWare

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95367 13f79535-47bb-0310-9956-ffa450edef68

22 years ago Solve a bug identified by Sebastian that we would always reaquire the
William A. Rowe Jr [Wed, 29 May 2002 21:23:03 +0000 (21:23 +0000)]
  Solve a bug identified by Sebastian that we would always reaquire the
  lock immediately instead of stalling for the isapi module's thread
  to complete its work.  This requires the new changes to thread_mutex
  that introduce a guarenteed APR_THREAD_MUTEX_UNNESTED flag.

Reported by: Sebastian Hantsch <Sebastian.Hantsch@t-online.de>

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95366 13f79535-47bb-0310-9956-ffa450edef68

22 years agoUpdated the NetWare makefiles to include the rotatelogs NLM and to copy
Bradley Nicholes [Wed, 29 May 2002 21:16:46 +0000 (21:16 +0000)]
Updated the NetWare makefiles to include the rotatelogs NLM and to copy
all of the support NLMs to a bin directory.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95365 13f79535-47bb-0310-9956-ffa450edef68

22 years agoAdded a NetWare makefile to build the rotate logs NLM
Bradley Nicholes [Wed, 29 May 2002 21:15:00 +0000 (21:15 +0000)]
Added a NetWare makefile to build the rotate logs NLM

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95364 13f79535-47bb-0310-9956-ffa450edef68

22 years agoUpdated the build project to build rotatelogs.nlm as a multi-use NLM.
Bradley Nicholes [Wed, 29 May 2002 21:14:21 +0000 (21:14 +0000)]
Updated the build project to build rotatelogs.nlm as a multi-use NLM.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95363 13f79535-47bb-0310-9956-ffa450edef68

22 years agoMake sure that z_RC is not Z_STREAM_END in case we get a 0-length bucket
Justin Erenkrantz [Wed, 29 May 2002 17:55:42 +0000 (17:55 +0000)]
Make sure that z_RC is not Z_STREAM_END in case we get a 0-length bucket
and we don't enter the while loop.

Submitted by: Jeff Trawick's horde of picky compilers

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95359 13f79535-47bb-0310-9956-ffa450edef68

22 years ago Deflate inflates, who woulda known. Glad I build clean occasionally.
William A. Rowe Jr [Wed, 29 May 2002 16:52:25 +0000 (16:52 +0000)]
  Deflate inflates, who woulda known.  Glad I build clean occasionally.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95356 13f79535-47bb-0310-9956-ffa450edef68

22 years agoFix links.
Joshua Slive [Wed, 29 May 2002 16:29:10 +0000 (16:29 +0000)]
Fix links.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95355 13f79535-47bb-0310-9956-ffa450edef68

22 years agoA couple small corrections to the content negotiation docs:
Joshua Slive [Wed, 29 May 2002 16:26:43 +0000 (16:26 +0000)]
A couple small corrections to the content negotiation docs:

- The "parent language" matchine is available always, not just
with ForceLanguagePriority

- ForceLanguagePriority defaults to Prefer, not None.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95354 13f79535-47bb-0310-9956-ffa450edef68

22 years agoNicely done, gentlemen. :)
Cliff Woolley [Wed, 29 May 2002 15:37:40 +0000 (15:37 +0000)]
Nicely done, gentlemen.  :)

showstoppers -= 4;

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95353 13f79535-47bb-0310-9956-ffa450edef68

22 years agoIgnore leading zeros when parsing hex value for chunk extensions.
Aaron Bannert [Wed, 29 May 2002 14:57:26 +0000 (14:57 +0000)]
Ignore leading zeros when parsing hex value for chunk extensions.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95352 13f79535-47bb-0310-9956-ffa450edef68

22 years agoget mod_deflate to compile with compilers that care about the
Jeff Trawick [Wed, 29 May 2002 14:26:00 +0000 (14:26 +0000)]
get mod_deflate to compile with compilers that care about the
signed-ness of char *

it looks like it should work fine, but it is untested

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95350 13f79535-47bb-0310-9956-ffa450edef68

22 years agohot
Jeff Trawick [Wed, 29 May 2002 11:41:10 +0000 (11:41 +0000)]
hot

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95347 13f79535-47bb-0310-9956-ffa450edef68

22 years agoUpdate URL to mirror finding script.
Yoshiki Hayashi [Wed, 29 May 2002 11:01:22 +0000 (11:01 +0000)]
Update URL to mirror finding script.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95346 13f79535-47bb-0310-9956-ffa450edef68

22 years agoInput filter support for mod_deflate.
Justin Erenkrantz [Wed, 29 May 2002 10:27:05 +0000 (10:27 +0000)]
Input filter support for mod_deflate.

Highly experimental, but known to work for some tests.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95345 13f79535-47bb-0310-9956-ffa450edef68

22 years agoAdd a note indicating what it would take to get MTIME field populated.
Justin Erenkrantz [Wed, 29 May 2002 07:23:10 +0000 (07:23 +0000)]
Add a note indicating what it would take to get MTIME field populated.
(I did this locally, but didn't figure it was worth committing, but it's
still worth noting.)

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95343 13f79535-47bb-0310-9956-ffa450edef68

22 years agoProperly detect overflow when reading the hex chunk lines.
Aaron Bannert [Wed, 29 May 2002 06:42:58 +0000 (06:42 +0000)]
Properly detect overflow when reading the hex chunk lines.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95342 13f79535-47bb-0310-9956-ffa450edef68

22 years agoImplement flushing support for mod_deflate.
Justin Erenkrantz [Wed, 29 May 2002 06:40:23 +0000 (06:40 +0000)]
Implement flushing support for mod_deflate.
(Review of RFC 1952 indicates that this is indeed easily allowable.)

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95341 13f79535-47bb-0310-9956-ffa450edef68

22 years agomod_bucketeer has been tried, convicted, and sentenced in the style courts.
Justin Erenkrantz [Wed, 29 May 2002 06:19:26 +0000 (06:19 +0000)]
mod_bucketeer has been tried, convicted, and sentenced in the style courts.
(No functional changes, just style changes, so I can read the darn thing.)

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95340 13f79535-47bb-0310-9956-ffa450edef68

22 years agoAllow mod_deflate to be more tolerant of multiple content-encodings.
Justin Erenkrantz [Wed, 29 May 2002 05:48:57 +0000 (05:48 +0000)]
Allow mod_deflate to be more tolerant of multiple content-encodings.

- Tighten scope of a few affected variables (accepts, token).
- Look for gzip in r->headers_out (!) - if there, we've already compressed.
  (Previously, we'd look at r->headers_in which was bogus - we're output.)
- Switch the Accept-Encoding check to be case-insensitive per RFC 2616.
- Remove commented-out code.
- If C-E wasn't present or it was just "identity," set C-E to "gzip",
  otherwise, merge "gzip" onto the C-E list.

This patch was originally submitted by Ian and cleaned up and tested by
Justin.

Submitted by: Ian Holsman
Reviewed by: Justin Erenkrantz

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95339 13f79535-47bb-0310-9956-ffa450edef68

22 years agoSimplify ap_read_pid and make it more portable.
Justin Erenkrantz [Wed, 29 May 2002 04:39:07 +0000 (04:39 +0000)]
Simplify ap_read_pid and make it more portable.

- Switch to using apr_file_read_full()
- Stop checking for \n (non-portable)
- Error if we read the entire buffer or the first digit isn't a number

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95338 13f79535-47bb-0310-9956-ffa450edef68

22 years agoError out a bit more nicely if the RewriteMap prg: is not found. We
Cliff Woolley [Wed, 29 May 2002 04:38:59 +0000 (04:38 +0000)]
Error out a bit more nicely if the RewriteMap prg: is not found.  We
can't just apr_stat in the first init round because we haven't run
apr_tokenize_to_argv() yet, and it would be a relatively ugly hack to run
it twice just for that.  Well, I suppose we could store the argv in the
rewritemap structure, but ... nah.  With this, we shutdown (cleanly, as
opposed to the old exit(1) method) if we go to execute a rewritemap
and discover it doesn't exist, and log a nice descriptive message at the
end of the error_log.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95337 13f79535-47bb-0310-9956-ffa450edef68

22 years agoUpdate transformations.
Joshua Slive [Wed, 29 May 2002 03:49:52 +0000 (03:49 +0000)]
Update transformations.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95336 13f79535-47bb-0310-9956-ffa450edef68

22 years agoUpdate the content negotiation docs to incorporate some of the new stuff in 2.0.
Joshua Slive [Wed, 29 May 2002 03:42:32 +0000 (03:42 +0000)]
Update the content negotiation docs to incorporate some of the new stuff in 2.0.
This could use review!

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95335 13f79535-47bb-0310-9956-ffa450edef68

22 years agoFix RewriteMap prg:'s that have command-line args.
Cliff Woolley [Wed, 29 May 2002 03:27:01 +0000 (03:27 +0000)]
Fix RewriteMap prg:'s that have command-line args.

PR: 8464
Submitted by: James Tait <JTait@wyrddreams.demon.co.uk>

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95334 13f79535-47bb-0310-9956-ffa450edef68

22 years agoSwitch the limit directive enforcement error paths to match the error handling
Justin Erenkrantz [Tue, 28 May 2002 23:55:53 +0000 (23:55 +0000)]
Switch the limit directive enforcement error paths to match the error handling
code for invalid chunk sizes.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95332 13f79535-47bb-0310-9956-ffa450edef68

22 years agoCorrectly return 413 when an invalid chunk size is given on input.
Justin Erenkrantz [Tue, 28 May 2002 23:38:31 +0000 (23:38 +0000)]
Correctly return 413 when an invalid chunk size is given on input.

- If get_chunk_size() returns a negative number, that probably implies
  an overflow.  So, create a 413 error and pass it to the output filters.
- Modify ap_discard_request_body() to return OK quickly if we're a subreq
  or our status code implies that we will be dropping the connection.
- Modify ap_die() so that if the new status implies that we will drop
  the connection, that we correctly indicate that we can not keepalive
  this connection.  (Without this, the error is returned, but the connection
  is not closed.)

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95331 13f79535-47bb-0310-9956-ffa450edef68

22 years agoshowstoppers--;
Cliff Woolley [Tue, 28 May 2002 23:16:57 +0000 (23:16 +0000)]
showstoppers--;

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95330 13f79535-47bb-0310-9956-ffa450edef68

22 years agoFix http redirecting for UserDir. Before this patch, the directive:
Ryan Bloom [Tue, 28 May 2002 23:14:15 +0000 (23:14 +0000)]
Fix http redirecting for UserDir.  Before this patch, the directive:

UserDir http://www.foo.com/~*/

The code would ignore the http:// and instead use the user's home directory

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95329 13f79535-47bb-0310-9956-ffa450edef68

22 years agowhy do I keep forgetting to commit CHANGES with the code change itself?
Cliff Woolley [Tue, 28 May 2002 21:51:13 +0000 (21:51 +0000)]
why do I keep forgetting to commit CHANGES with the code change itself?
ugh.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95328 13f79535-47bb-0310-9956-ffa450edef68

22 years agoAPR-ize the localtime() fooness, since localtime() is not always
Cliff Woolley [Tue, 28 May 2002 21:47:31 +0000 (21:47 +0000)]
APR-ize the localtime() fooness, since localtime() is not always
threadsafe.

PR: 9469

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95327 13f79535-47bb-0310-9956-ffa450edef68

22 years agojust in case anybody cares
Cliff Woolley [Tue, 28 May 2002 21:26:44 +0000 (21:26 +0000)]
just in case anybody cares

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95326 13f79535-47bb-0310-9956-ffa450edef68

22 years agovote++; (cheer)
Justin Erenkrantz [Tue, 28 May 2002 21:14:28 +0000 (21:14 +0000)]
vote++;         (cheer)
showstopper++;  (groan)

Cliff can revoke this as a showstopper, but I think this'll get fixed as soon
as I (or someone else) figures out how to return HTTP errors from a filter.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95325 13f79535-47bb-0310-9956-ffa450edef68

22 years agoshowstoppers--;
Cliff Woolley [Tue, 28 May 2002 21:07:58 +0000 (21:07 +0000)]
showstoppers--;

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95324 13f79535-47bb-0310-9956-ffa450edef68

22 years agoThe lock should have already been released when the connection was closed.
Bradley Nicholes [Tue, 28 May 2002 19:32:30 +0000 (19:32 +0000)]
The lock should have already been released when the connection was closed.
If it was then releasing it again causes a "releasing an unheld lock" warning
on NetWare.  To avoid the warning, first try to get the lock before releasing
it.  The other alternative would be to just assume that the lock has been
released when the connection was closed so do nothing.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95323 13f79535-47bb-0310-9956-ffa450edef68

22 years agoNeed to destroy the global cache during module shutdown that was created
Bradley Nicholes [Tue, 28 May 2002 19:28:13 +0000 (19:28 +0000)]
Need to destroy the global cache during module shutdown that was created
when the module what initialized.  This eliminates a memory leak.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95322 13f79535-47bb-0310-9956-ffa450edef68

22 years agoNeed to also free the cache node itself when destroying the cache. The
Bradley Nicholes [Tue, 28 May 2002 19:26:26 +0000 (19:26 +0000)]
Need to also free the cache node itself when destroying the cache.  The
eliminates a memory leak on shutdown

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95321 13f79535-47bb-0310-9956-ffa450edef68

22 years agoshowstoppers--;
Cliff Woolley [Tue, 28 May 2002 18:06:06 +0000 (18:06 +0000)]
showstoppers--;

Thanks, Bill!

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95320 13f79535-47bb-0310-9956-ffa450edef68

22 years agoFix problem where mod_cache/mod_disk_cache was setting content_type to
Bill Stoddard [Tue, 28 May 2002 18:04:43 +0000 (18:04 +0000)]
Fix problem where mod_cache/mod_disk_cache was setting content_type to
text/plain for all cached remote responses.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95319 13f79535-47bb-0310-9956-ffa450edef68

22 years agoMostly harmless.
Cliff Woolley [Tue, 28 May 2002 15:22:55 +0000 (15:22 +0000)]
Mostly harmless.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95314 13f79535-47bb-0310-9956-ffa450edef68

22 years agoRegenerate HTML files with latest common.xsl.
Yoshiki Hayashi [Tue, 28 May 2002 07:35:00 +0000 (07:35 +0000)]
Regenerate HTML files with latest common.xsl.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95313 13f79535-47bb-0310-9956-ffa450edef68

22 years agoAdd nowrap attribute to the column showing description, status,
Yoshiki Hayashi [Tue, 28 May 2002 07:34:10 +0000 (07:34 +0000)]
Add nowrap attribute to the column showing description, status,
module identifier etc.

This change is mainly for the sake of Japanese translation.  Because
Japanese words are not whitespace separated, web browser can wrap it
anywhere it wants.  This change prevent "module identifier" etc from
being wrapped.

Suggested by: Hiroaki KAWAI <hawk@bcl.t.u-tokyo.ac.jp>

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95312 13f79535-47bb-0310-9956-ffa450edef68

22 years agoAdd link to howto/auth.html.
Yoshiki Hayashi [Tue, 28 May 2002 07:14:37 +0000 (07:14 +0000)]
Add link to howto/auth.html.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95311 13f79535-47bb-0310-9956-ffa450edef68

22 years agoFix typo.
Yoshiki Hayashi [Tue, 28 May 2002 07:13:48 +0000 (07:13 +0000)]
Fix typo.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95310 13f79535-47bb-0310-9956-ffa450edef68

22 years agoUpdate the proxy docs a little bit. Still lots of work needed.
Joshua Slive [Tue, 28 May 2002 01:36:44 +0000 (01:36 +0000)]
Update the proxy docs a little bit.  Still lots of work needed.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95309 13f79535-47bb-0310-9956-ffa450edef68

22 years agoremove a vote which was resolved
Ian Holsman [Mon, 27 May 2002 14:00:46 +0000 (14:00 +0000)]
remove a vote which was resolved
PR:
Obtained from:
Submitted by:
Reviewed by:

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95308 13f79535-47bb-0310-9956-ffa450edef68

22 years agosimplified apachectl...
Jeff Trawick [Mon, 27 May 2002 11:46:01 +0000 (11:46 +0000)]
simplified apachectl...

. it now uses "httpd -k verb" support for start/restart/etc.
. it now can pass through any httpd option, so apachectl
  can be used as a replacement for invoking httpd directly
  (this practice ensures that any necessary environment
  variables are set up)

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95307 13f79535-47bb-0310-9956-ffa450edef68

22 years agofix a char signed-ness mismatc in the call to apr_table_set()
Jeff Trawick [Mon, 27 May 2002 10:28:17 +0000 (10:28 +0000)]
fix a char signed-ness mismatc in the call to apr_table_set()

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95306 13f79535-47bb-0310-9956-ffa450edef68

22 years agoDocument the --with-suexec-bin configure flag.
Aaron Bannert [Mon, 27 May 2002 04:07:32 +0000 (04:07 +0000)]
Document the --with-suexec-bin configure flag.
PR: 9038

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95304 13f79535-47bb-0310-9956-ffa450edef68

22 years agoReorder these directives to match the output from ./configure --help
Aaron Bannert [Mon, 27 May 2002 02:38:51 +0000 (02:38 +0000)]
Reorder these directives to match the output from ./configure --help

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95303 13f79535-47bb-0310-9956-ffa450edef68

22 years agoA bunch of small corrections, mostly to <description>s and <override>s.
Joshua Slive [Mon, 27 May 2002 02:22:09 +0000 (02:22 +0000)]
A bunch of small corrections, mostly to <description>s and <override>s.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95302 13f79535-47bb-0310-9956-ffa450edef68

22 years agoUpdate transformations.
Joshua Slive [Mon, 27 May 2002 02:20:38 +0000 (02:20 +0000)]
Update transformations.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95301 13f79535-47bb-0310-9956-ffa450edef68