]> granicus.if.org Git - php/log
php
5 years agoClean build system
Peter Kokot [Wed, 13 Mar 2019 21:50:53 +0000 (22:50 +0100)]
Clean build system

Changes:
- AC_TYPE_SIZE_T called on only one place (configure.ac)
- AC_FUNC_ALLOCA called on only one place (configure.ac)
- AC_TYPE_UID_T called on only one place (configure.ac)
- HAVE_STRSTR removed since strstr is part of C89 standard [1]
- Remove checks for strtol and strpbrk
- Checking for the presence of perror function is not needed anymore
  since it is part of C89 standard and PHP calls it unconditionally.
- Checking for functions strdup, setenv, strerror, and memmove done only
  on one place (configure.ac)
- outdated check for snprintf removed

1: https://port70.net/~nsz/c/c89/c89-draft.html

5 years agoRemove HAVE_STRFTIME
Peter Kokot [Wed, 13 Mar 2019 22:14:37 +0000 (23:14 +0100)]
Remove HAVE_STRFTIME

Function strftime is part of the C89 standard [1] and current systems
don't need to check for its presence anymore.

Additionally, checks for strftime function in tests have been removed
since the PHP strftime function is now always available.

1: https://port70.net/~nsz/c/c89/c89-draft.html

5 years agoext/session: remove the redundant convert_to_long
c9s [Tue, 12 Mar 2019 12:21:38 +0000 (20:21 +0800)]
ext/session: remove the redundant convert_to_long

5 years agoMerge branch 'PHP-7.3' into PHP-7.4
Nikita Popov [Thu, 14 Mar 2019 16:26:17 +0000 (17:26 +0100)]
Merge branch 'PHP-7.3' into PHP-7.4

5 years agoMerge branch 'PHP-7.2' into PHP-7.3
Nikita Popov [Thu, 14 Mar 2019 16:25:44 +0000 (17:25 +0100)]
Merge branch 'PHP-7.2' into PHP-7.3

5 years agoFixed bug #77742
Nikita Popov [Thu, 14 Mar 2019 16:24:50 +0000 (17:24 +0100)]
Fixed bug #77742

By avoiding integer overflow in the implementation entirely. The
multiplication was already explicitly checked for overflow, so also
add a check for the addition and remove the overflow checks after
the calculation.

5 years agoupdated NEWS
Xinchen Hui [Thu, 14 Mar 2019 08:47:16 +0000 (16:47 +0800)]
updated NEWS

5 years agoMerge branch 'PHP-7.2' into PHP-7.3
Xinchen Hui [Thu, 14 Mar 2019 08:46:46 +0000 (16:46 +0800)]
Merge branch 'PHP-7.2' into PHP-7.3

* PHP-7.2:
  Fixed bug #77738 (Nullptr deref in zend_compile_expr)

5 years agoFixed bug #77738 (Nullptr deref in zend_compile_expr)
Xinchen Hui [Thu, 14 Mar 2019 08:46:04 +0000 (16:46 +0800)]
Fixed bug #77738 (Nullptr deref in zend_compile_expr)

5 years agoImplemented a faster way to access predefined TSRM resources - CG(), EG(), etc.
Dmitry Stogov [Thu, 14 Mar 2019 00:01:01 +0000 (03:01 +0300)]
Implemented a faster way to access predefined TSRM resources - CG(), EG(), etc.

5 years agoIntegrate README.EXT_SKEL to help option
Peter Kokot [Mon, 11 Mar 2019 01:01:25 +0000 (02:01 +0100)]
Integrate README.EXT_SKEL to help option

- Sync help output using heredoc
- Add extension building instructions
- Building with phpize is preferred option. Mention also tests
- Refactor print_success()

5 years agoFix duplicate symbols _zend_ce_weakrefs
Peter Kokot [Wed, 13 Mar 2019 00:08:38 +0000 (01:08 +0100)]
Fix duplicate symbols _zend_ce_weakrefs

The zend_ce_weakref need to be external...

5 years ago[ci skip] Mention removed m4 macros
Peter Kokot [Tue, 12 Mar 2019 23:16:34 +0000 (00:16 +0100)]
[ci skip] Mention removed m4 macros

5 years agoSync with ZEND_ENABLE_STATIC_TSRMLS_CACHE enablement in ext/mbstring
Anatol Belski [Tue, 12 Mar 2019 20:33:43 +0000 (21:33 +0100)]
Sync with ZEND_ENABLE_STATIC_TSRMLS_CACHE enablement in ext/mbstring

5 years agoBetter data packing
Dmitry Stogov [Tue, 12 Mar 2019 19:19:11 +0000 (22:19 +0300)]
Better data packing

5 years agoAvoid reinitailization of ZTS cache pointer. Initialize it once in TSRM.c
Dmitry Stogov [Tue, 12 Mar 2019 14:35:50 +0000 (17:35 +0300)]
Avoid reinitailization of ZTS cache pointer. Initialize it once in TSRM.c

5 years agoFixed ZTS cache usage
Dmitry Stogov [Tue, 12 Mar 2019 13:58:02 +0000 (16:58 +0300)]
Fixed ZTS cache usage

5 years agoFixed ZTS cache usage
Dmitry Stogov [Tue, 12 Mar 2019 12:25:51 +0000 (15:25 +0300)]
Fixed ZTS cache usage

5 years agoFixed ZTS cache usage
Dmitry Stogov [Tue, 12 Mar 2019 12:13:52 +0000 (15:13 +0300)]
Fixed ZTS cache usage

5 years agoFixed ZTS cache usage
Dmitry Stogov [Tue, 12 Mar 2019 12:05:56 +0000 (15:05 +0300)]
Fixed ZTS cache usage

5 years agoSwitch to use ZTS cache
Dmitry Stogov [Tue, 12 Mar 2019 11:15:47 +0000 (14:15 +0300)]
Switch to use ZTS cache

5 years agoCleanup unused module globals
Dmitry Stogov [Tue, 12 Mar 2019 10:44:05 +0000 (13:44 +0300)]
Cleanup unused module globals

5 years agoFixed ZTS cache usage
Dmitry Stogov [Tue, 12 Mar 2019 09:07:25 +0000 (12:07 +0300)]
Fixed ZTS cache usage

5 years agoMerge branch 'PHP-7.3' into PHP-7.4
Nikita Popov [Tue, 12 Mar 2019 08:58:29 +0000 (09:58 +0100)]
Merge branch 'PHP-7.3' into PHP-7.4

5 years agoFixed bug #77722
Nikita Popov [Tue, 12 Mar 2019 08:57:51 +0000 (09:57 +0100)]
Fixed bug #77722

5 years agoadd --enable-rtld-now in upgrade info
Remi Collet [Tue, 12 Mar 2019 07:26:22 +0000 (08:26 +0100)]
add --enable-rtld-now in upgrade info

5 years agouse DL_LOAD in litespeed
Remi Collet [Mon, 11 Mar 2019 12:39:22 +0000 (13:39 +0100)]
use DL_LOAD in litespeed

5 years agoadd --enable-rtld-now build option to change dlopen behavior
Remi Collet [Mon, 11 Mar 2019 12:38:58 +0000 (13:38 +0100)]
add --enable-rtld-now build option to change dlopen behavior

5 years agoweakrefs upgrading note
Joe Watkins [Tue, 12 Mar 2019 05:52:43 +0000 (06:52 +0100)]
weakrefs upgrading note

5 years agozend_weakrefs
Joe Watkins [Thu, 10 May 2018 12:58:10 +0000 (14:58 +0200)]
zend_weakrefs

5 years agoMerge branch 'PHP-7.3' into PHP-7.4
Anatol Belski [Mon, 11 Mar 2019 19:59:51 +0000 (20:59 +0100)]
Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
  Die hard if mc.exe or mt.exe not found

5 years agoMerge branch 'PHP-7.2' into PHP-7.3
Anatol Belski [Mon, 11 Mar 2019 19:59:23 +0000 (20:59 +0100)]
Merge branch 'PHP-7.2' into PHP-7.3

* PHP-7.2:
  Die hard if mc.exe or mt.exe not found

5 years agoDie hard if mc.exe or mt.exe not found
Anatol Belski [Mon, 11 Mar 2019 19:41:45 +0000 (20:41 +0100)]
Die hard if mc.exe or mt.exe not found

Even configure would pass, that producess quite subtle build errors
which are better to avoid at configure stage already.

5 years agoMerge branch 'PHP-7.3' into PHP-7.4
Christoph M. Becker [Mon, 11 Mar 2019 15:31:26 +0000 (16:31 +0100)]
Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
  SQLite3: add DEFENSIVE config for SQLite >= 3.26.0 as a mitigation strategy against potential security flaws

5 years agoMerge branch 'PHP-7.2' into PHP-7.3
Christoph M. Becker [Mon, 11 Mar 2019 15:28:46 +0000 (16:28 +0100)]
Merge branch 'PHP-7.2' into PHP-7.3

* PHP-7.2:
  SQLite3: add DEFENSIVE config for SQLite >= 3.26.0 as a mitigation strategy against potential security flaws

5 years agoSQLite3: add DEFENSIVE config for SQLite >= 3.26.0 as a mitigation strategy against...
bohwaz [Sun, 16 Dec 2018 21:52:37 +0000 (22:52 +0100)]
SQLite3: add DEFENSIVE config for SQLite >= 3.26.0 as a mitigation strategy against potential security flaws

5 years agoMerge branch 'PHP-7.3' into PHP-7.4
Nikita Popov [Mon, 11 Mar 2019 14:36:40 +0000 (15:36 +0100)]
Merge branch 'PHP-7.3' into PHP-7.4

5 years agoMerge branch 'PHP-7.2' into PHP-7.3
Nikita Popov [Mon, 11 Mar 2019 14:36:16 +0000 (15:36 +0100)]
Merge branch 'PHP-7.2' into PHP-7.3

5 years agoFixed bug #76717
Nikita Popov [Mon, 11 Mar 2019 14:35:02 +0000 (15:35 +0100)]
Fixed bug #76717

Print INT_MIN as -INT_MAX-1 to avoid it getting parsed as a float
literal due to integer overflow.

5 years agoFree trampolines from get_closure in is_callable
Nikita Popov [Mon, 11 Mar 2019 12:56:22 +0000 (13:56 +0100)]
Free trampolines from get_closure in is_callable

Also extract this logic into a function, as it's duplicated a few times.

5 years agoClosure::fromCallable() supports only regular methods and magic method invoked throug...
Dmitry Stogov [Mon, 11 Mar 2019 12:39:34 +0000 (15:39 +0300)]
Closure::fromCallable() supports only regular methods and magic method invoked through __call()/__callStatic().
It doesn't support method of internal classes invoked through C object or class handlers.
This commit prevents crash described at bug #77708, but doesn't implement the desired behavior.

5 years agoReset fields
Dmitry Stogov [Mon, 11 Mar 2019 12:38:49 +0000 (15:38 +0300)]
Reset fields

5 years agoFixed bug #77707 (FFI loses type information for opaque types)
Dmitry Stogov [Mon, 11 Mar 2019 11:26:17 +0000 (14:26 +0300)]
Fixed bug #77707 (FFI loses type information for opaque types)

5 years agoFixed bug #77706 (Improve error messages in FFI for incompatible arguments)
Dmitry Stogov [Mon, 11 Mar 2019 10:27:23 +0000 (13:27 +0300)]
Fixed bug #77706 (Improve error messages in FFI for incompatible arguments)

5 years agoFix #71890: Add support for crc32c Castagnoli's polynomial.
Andrew Brampton [Mon, 4 Mar 2019 03:57:40 +0000 (19:57 -0800)]
Fix #71890: Add support for crc32c Castagnoli's polynomial.

This variant of crc32 is heavily used by storage systems, such as iSCSI, SCTP,
Btrfs, ext4, and is increasingly being used in API (such as Google Cloud
Storage, and Apache Kafka).

5 years agoFix shm api detection test for opcache module on FreeBSD
David Carlier [Fri, 1 Mar 2019 11:33:29 +0000 (11:33 +0000)]
Fix shm api detection test for opcache module on FreeBSD

Per man page the shm_open path should start with / and contain no
further slashes.

5 years agodrop unused parameter from zend_startup
Joe Watkins [Mon, 11 Mar 2019 09:10:14 +0000 (10:10 +0100)]
drop unused parameter from zend_startup

5 years agoRemove function_table var from the caller
c9s [Sun, 10 Mar 2019 07:16:04 +0000 (15:16 +0800)]
Remove function_table var from the caller

function_table var is not used in call_user_function macro anymore
hence replace the usage with NULL

5 years agocurl_exec: remove bad check for CURLE_PARTIAL_FILE
Daniel Stenberg [Wed, 6 Mar 2019 23:06:00 +0000 (00:06 +0100)]
curl_exec: remove bad check for CURLE_PARTIAL_FILE

This check introduced in 2004 is wrong and removed. A HEAD request with
curl does *not* cause this error code - only if you make a regular GET
request but tell curl to send a HEAD using CURLOPT_CUSTOMREQUEST and
then you've asked for it.

You do a proper HEAD request with curl by setting the CURLOPT_NOBODY
option to 1L.

This was the case in 2004. This is still the case in 2019. This is also
documented in libcurl documentation.

This check hides the possibly serious error when this error code is
genuinely and correctly returned by curl because the transfer was
truncated and ended up partial.

As can be seen, I objected to this change already in the original bug:
https://bugs.php.net/bug.php?id=27341

5 years agoThis option doesn't exist for a long time.
Stanislav Malyshev [Mon, 11 Mar 2019 08:13:50 +0000 (01:13 -0700)]
This option doesn't exist for a long time.

5 years agoUse EXPECT when possible
Gabriel Caruso [Mon, 11 Mar 2019 03:05:44 +0000 (00:05 -0300)]
Use EXPECT when possible

EXPECTF logic in run-tests.php is considerable, so let's avoid it.

5 years agoFix tests filenames
Gabriel Caruso [Mon, 11 Mar 2019 02:57:32 +0000 (23:57 -0300)]
Fix tests filenames

5 years agoAdd meaningful error message for ext/zip
hassan [Tue, 10 Oct 2017 19:10:08 +0000 (21:10 +0200)]
Add meaningful error message for ext/zip

5 years agoMerge branch 'PHP-7.3' into PHP-7.4
Jakub Zelenka [Sun, 10 Mar 2019 16:36:55 +0000 (16:36 +0000)]
Merge branch 'PHP-7.3' into PHP-7.4

5 years agoSpeed up TLS wrapper test for min and max versions
Jakub Zelenka [Sun, 10 Mar 2019 16:36:13 +0000 (16:36 +0000)]
Speed up TLS wrapper test for min and max versions

5 years agoMerge branch 'PHP-7.2' into PHP-7.3
Jakub Zelenka [Sun, 10 Mar 2019 16:34:58 +0000 (16:34 +0000)]
Merge branch 'PHP-7.2' into PHP-7.3

5 years agoSpeed up TLS wrapper tests when SSLv3 disabled
Jakub Zelenka [Sun, 10 Mar 2019 16:23:44 +0000 (16:23 +0000)]
Speed up TLS wrapper tests when SSLv3 disabled

If SSLv3 is disabled in OpenSSL, then sslv3 is not available so the accept
times out. This commit removes the extra accept if SSLv3 is disabled.

5 years agoFix bc break in Windows readlink
johnstevenson [Wed, 13 Feb 2019 11:34:00 +0000 (11:34 +0000)]
Fix bc break in Windows readlink

GetFinalPathNameByHandleW is given a file handle to a symbolic link,
rather than one to the target, and therefore returns an incorrect path.

Fix symlink with relative path and add test

5 years agoDon't use Opcache with the master test process
Anatol Belski [Sun, 10 Mar 2019 12:56:32 +0000 (13:56 +0100)]
Don't use Opcache with the master test process

Additionally, enable opcache.file_cache to mitigate possible reattach
failures in the tests.

5 years agoMerge branch 'PHP-7.3' into PHP-7.4
Anatol Belski [Fri, 8 Mar 2019 20:55:48 +0000 (21:55 +0100)]
Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
  Update libmagic.patch [skip ci]

5 years agoUpdate libmagic.patch [skip ci]
Anatol Belski [Fri, 8 Mar 2019 20:55:15 +0000 (21:55 +0100)]
Update libmagic.patch [skip ci]

5 years agoMerge branch 'PHP-7.3' into PHP-7.4
Anatol Belski [Fri, 8 Mar 2019 20:45:18 +0000 (21:45 +0100)]
Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
  Fix typo in libmagic version

5 years agoFix typo in libmagic version
Fabien Villepinte [Fri, 8 Mar 2019 11:43:37 +0000 (12:43 +0100)]
Fix typo in libmagic version

5 years agoMerge branch 'PHP-7.3' into PHP-7.4
Anatol Belski [Fri, 8 Mar 2019 19:48:24 +0000 (20:48 +0100)]
Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
  Fixed bug #77576 pull the libmagic implementation of gmtime_r

5 years agoFixed bug #77576 pull the libmagic implementation of gmtime_r
Anatol Belski [Fri, 8 Mar 2019 19:32:15 +0000 (20:32 +0100)]
Fixed bug #77576 pull the libmagic implementation of gmtime_r

PHP already has all the checks to handle the *_r function variants.
Thus, reusing it to get right symbols.

5 years agoMerge branch 'PHP-7.3' into PHP-7.4
Anatol Belski [Fri, 8 Mar 2019 14:56:48 +0000 (15:56 +0100)]
Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
  Sync with behavior change in OpenSSL 1.1.1b
  fix news
  bump versions after release

5 years agoMerge branch 'PHP-7.2' into PHP-7.3
Anatol Belski [Fri, 8 Mar 2019 14:55:34 +0000 (15:55 +0100)]
Merge branch 'PHP-7.2' into PHP-7.3

* PHP-7.2:
  Sync with behavior change in OpenSSL 1.1.1b
  fix news
  bump versions after release

5 years agoMerge branch 'PHP-7.1' into PHP-7.2
Anatol Belski [Fri, 8 Mar 2019 14:54:27 +0000 (15:54 +0100)]
Merge branch 'PHP-7.1' into PHP-7.2

* PHP-7.1:
  Sync with behavior change in OpenSSL 1.1.1b
  fix news
  bump versions after release

5 years agoSync with behavior change in OpenSSL 1.1.1b
Anatol Belski [Thu, 28 Feb 2019 11:48:47 +0000 (12:48 +0100)]
Sync with behavior change in OpenSSL 1.1.1b

A behavior change in revealed by some openssl_decrypt() based test,
where an encrypt API is used with a decrypt context. The EVP_Cipher*
functions will automatically choose the right operation depending on the
context passed.

(cherry picked from commit 19a44ffb7be91344550fa700830b8e62a73031ba)

5 years agoMore zpp error/variation test removals
Nikita Popov [Fri, 8 Mar 2019 08:45:24 +0000 (09:45 +0100)]
More zpp error/variation test removals

5 years agoGive Peter credit for his work on the Unix build system
Kalle Sommer Nielsen [Thu, 7 Mar 2019 21:27:10 +0000 (23:27 +0200)]
Give Peter credit for his work on the Unix build system

5 years agoClean *nix build system
Peter Kokot [Thu, 7 Mar 2019 19:58:14 +0000 (20:58 +0100)]
Clean *nix build system

- remove some outdated and not used macro calls
- remove some unused variables
- Remove not needed comment from tokenizer config.m4
- Remove not needed comment
- remove not needed local variables for editors and syntax highlighting

5 years agoAdd AS_HELP_STRING to *nix build configure options
Peter Kokot [Sun, 3 Mar 2019 15:44:16 +0000 (16:44 +0100)]
Add AS_HELP_STRING to *nix build configure options

The Autoconf's default AS_HELP_STRING macro can properly format help
strings [1] so watching out if columns are aligned manually is not
anymore.

[1] https://www.gnu.org/software/autoconf/manual/autoconf.html#Pretty-Help-Strings

5 years agoMore zpp error/variation test removals
Nikita Popov [Thu, 7 Mar 2019 15:39:05 +0000 (16:39 +0100)]
More zpp error/variation test removals

5 years agoMore zpp error/variation test removals
Nikita Popov [Thu, 7 Mar 2019 09:38:11 +0000 (10:38 +0100)]
More zpp error/variation test removals

5 years agoMerge branch 'PHP-7.3' into PHP-7.4
Dmitry Stogov [Thu, 7 Mar 2019 11:00:02 +0000 (14:00 +0300)]
Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
  ws

5 years agows
Dmitry Stogov [Thu, 7 Mar 2019 10:59:18 +0000 (13:59 +0300)]
ws

5 years agoMerge branch 'PHP-7.3' into PHP-7.4
Dmitry Stogov [Thu, 7 Mar 2019 10:53:43 +0000 (13:53 +0300)]
Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
  Fixed bug #77345 (Stack Overflow caused by circular reference in garbage collection)

5 years agoFixed bug #77345 (Stack Overflow caused by circular reference in garbage collection)
Dmitry Stogov [Thu, 7 Mar 2019 10:33:19 +0000 (13:33 +0300)]
Fixed bug #77345 (Stack Overflow caused by circular reference in garbage collection)

5 years agoAdd support for MemorySanitizer
Stanislav Malyshev [Thu, 7 Mar 2019 00:18:08 +0000 (16:18 -0800)]
Add support for MemorySanitizer

5 years agoRefactor README.md file
Peter Kokot [Thu, 7 Mar 2019 00:57:53 +0000 (01:57 +0100)]
Refactor README.md file

- Initial refactorings of the README.md file with some more user
  oriented information about the php-src repository and PHP in general.
- SVG logo added
- README.WIN32-BUILD-SYSTEM file contents moved to README.md
- INSTALL file contents moved to README.md
- Windows releases now instead of install.txt file ship with the
  README.md.
- A brief installation section added with help options mentioned for the
  configure and make.
- Also mentioned the `-j` option for build and tests

Co-authored-by: Javier Eguiluz <javier.eguiluz@gmail.com>
Co-authored-by: Gabriel Caruso <carusogabriel34@gmail.com>
Co-authored-by: Matthias Kaschubowski <nihylum@gmail.com>
5 years agoMerge branch 'PHP-7.3' into PHP-7.4
Peter Kokot [Thu, 7 Mar 2019 00:05:43 +0000 (01:05 +0100)]
Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
  Update editorconfig

5 years agoMerge branch 'PHP-7.2' into PHP-7.3
Peter Kokot [Thu, 7 Mar 2019 00:05:22 +0000 (01:05 +0100)]
Merge branch 'PHP-7.2' into PHP-7.3

* PHP-7.2:
  Update editorconfig

5 years agoUpdate editorconfig
Peter Kokot [Sun, 17 Feb 2019 13:21:58 +0000 (14:21 +0100)]
Update editorconfig

Changes:
- New property max_line_length
- COMMIT_EDITMSG file added when writing commit messages
- Markdown files can have trimmed trailing whitespace also to simplify
  settings.
- https link used to EditorConfig page.
- Added also *.y, *.cpp, and *.inc files
- The tab_width moved to a new all files section

5 years agoRemove legacy AC_CHECK_TYPE calls for uint and ulong
Peter Kokot [Sat, 2 Mar 2019 13:42:21 +0000 (14:42 +0100)]
Remove legacy AC_CHECK_TYPE calls for uint and ulong

The AC_CHECK_TYPE was refactored in more recent versions of Autoconf
and the call with two arguments is obsolete and not recommended anymore.

This patch also refactors some leftovers of using ulong and uint which
are not standard nor common usages of types in C.

The ulong can be used as zend_ulong and uint usage is actually
`unsigned int`.

The usage of HAVE_ULONG removed since it is not used in current code
base.

Legacy edgecase for some legacy HPUX systems removed:
- sys/stream.h header is not checked and the HAVE_SYS_STREAM_H is
  not defined with current build system.

- flags are unsigned int
- max_allowed_packet changed to unsigned int

5 years agoMore zpp error/variation test removals
Nikita Popov [Wed, 6 Mar 2019 10:23:38 +0000 (11:23 +0100)]
More zpp error/variation test removals

Some of these tests also check non-zpp conditions -- however, there is
always some other test that also checks those error conditions.

5 years agoFix shifting signed values too far
Stanislav Malyshev [Tue, 5 Mar 2019 21:25:21 +0000 (13:25 -0800)]
Fix shifting signed values too far

Signed shift of 31 for int and 63 for long is flagged as undefined
behavior by UBSan (-fsanitize=undefined) and seems to be indeed so
according to the standard.

The patch converts such cases to use unsigned.

5 years agoMerge branch 'PHP-7.3' into PHP-7.4
Christoph M. Becker [Tue, 5 Mar 2019 23:38:12 +0000 (00:38 +0100)]
Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
  Fix #77700: Writing truecolor images as GIF ignores interlace flag

5 years agoMerge branch 'PHP-7.2' into PHP-7.3
Christoph M. Becker [Tue, 5 Mar 2019 23:35:37 +0000 (00:35 +0100)]
Merge branch 'PHP-7.2' into PHP-7.3

* PHP-7.2:
  Fix #77700: Writing truecolor images as GIF ignores interlace flag

5 years agoFix #77700: Writing truecolor images as GIF ignores interlace flag
Christoph M. Becker [Tue, 5 Mar 2019 23:27:16 +0000 (00:27 +0100)]
Fix #77700: Writing truecolor images as GIF ignores interlace flag

We  revert the interlace flag related part of commit ff2822a[1], since
contrary to the transparent color, the interlace flag is not retained
by `gdImageCreatePaletteFromTrueColor()`.  This also matches upstream
libgd.

[1] <http://git.php.net/?p=php-src.git;a=commit;h=ff2822a82b740edb8ccf307f080bae188c200fb9>

5 years agofix news
Joe Watkins [Tue, 5 Mar 2019 19:50:07 +0000 (20:50 +0100)]
fix news

5 years agobump versions after release
Joe Watkins [Tue, 5 Mar 2019 17:28:47 +0000 (18:28 +0100)]
bump versions after release

5 years agoRemove more zpp error tests
Nikita Popov [Tue, 5 Mar 2019 14:49:15 +0000 (15:49 +0100)]
Remove more zpp error tests

5 years agoRemove unnecessary check for always available extension
Gabriel Caruso [Tue, 5 Mar 2019 15:54:24 +0000 (12:54 -0300)]
Remove unnecessary check for always available extension

5 years agoRemove more zpp error/variation tests
Nikita Popov [Tue, 5 Mar 2019 10:55:03 +0000 (11:55 +0100)]
Remove more zpp error/variation tests

5 years agoRemove custom error handler in mbstring tests
Nikita Popov [Tue, 5 Mar 2019 10:41:53 +0000 (11:41 +0100)]
Remove custom error handler in mbstring tests

To make it more obvious what is tested and what the error messages
are.

5 years agoRemove more zpp error tests
Nikita Popov [Tue, 5 Mar 2019 09:39:19 +0000 (10:39 +0100)]
Remove more zpp error tests

5 years agoRemove tests for zpp failure conditions
Nikita Popov [Tue, 5 Mar 2019 08:46:02 +0000 (09:46 +0100)]
Remove tests for zpp failure conditions

These tests only check zpp error conditions, so drop them per
zpp testing policy.

5 years agoMerge branch 'PHP-7.3' into PHP-7.4
Remi Collet [Tue, 5 Mar 2019 06:33:11 +0000 (07:33 +0100)]
Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
  add NEWS entry

5 years agoMerge branch 'PHP-7.2' into PHP-7.3
Remi Collet [Tue, 5 Mar 2019 06:32:54 +0000 (07:32 +0100)]
Merge branch 'PHP-7.2' into PHP-7.3

* PHP-7.2:
  add NEWS entry