Bruce Momjian [Sat, 14 Dec 2002 18:39:39 +0000 (18:39 +0000)]
Ok, I think I've gotten this figured out now. I saw this comment in
pqcomm.c, switched the ERROR logs to COMMERROR logs and it all works.
I've attached a patch to be-secure.c that fixes all my problems.
Tom Lane [Thu, 12 Dec 2002 16:16:58 +0000 (16:16 +0000)]
Back-patch fix to prevent core dump in EXPLAIN if optimizer has
simplified function call to a constant. (7.3 won't actually execute
such a plan anyway, but core dump is bad regardless.)
Bruce Momjian [Mon, 9 Dec 2002 17:45:17 +0000 (17:45 +0000)]
As far as I figured from the source code this function only deals with
cleaning up locale names and nothing else. Since all the locale names
are in plain ASCII I think it will be safe to use ASCII-only lower-case
conversion.
Bruce Momjian [Fri, 6 Dec 2002 05:15:32 +0000 (05:15 +0000)]
Thank you very much, you catch it :). This bug had a long life, because it
exists if and only if locale of postmaster
was a different from C (or ru_RU.KOI8-R).
Please, apply patch for current CVS & 7.3.1
Magnus Naeslund(f) wrote:
> Ok, I nailed the bug, but i'm not sure what the correct fix is.
> Attached tsearch_morph.diff that remedies this problem by avoiding it.
> Also there's a debug aid patch if someone would like to know how i
> finally found it out :)
>
> There problem in the lemmatize() function is that GETDICT(...) returned
> a value not handled (BYLOCALE).
> The value (-1) and later used as an index into the dicts[] array.
> After that everything went berserk stack went crazy somehow so trapping
> the fault sent me to the wrong place, and every time i read the value it
> was positive ;)
>
> So now i just return the initial word passed to the lemmatize function,
> because i don't know what to do with it.
Tom Lane [Thu, 5 Dec 2002 21:46:55 +0000 (21:46 +0000)]
Avoid pulling up sublinks from a subselect's targetlist. Works around
problems that occur if sublink is referenced via a join alias variable.
Perhaps this can be improved later, but a simple and safe fix is needed
for 7.3.1.
Tom Lane [Wed, 4 Dec 2002 20:00:19 +0000 (20:00 +0000)]
Repair oversight in recent change of dependency extraction code: when
recursing to handle a join alias var, the context had better be set to
be appropriate to the join var's query level. Per report from Hristo Neshev.
Tom Lane [Sun, 1 Dec 2002 17:33:33 +0000 (17:33 +0000)]
Repair coredump in COPY OUT when client encoding is different from
server encoding, per report from Nicolai Tufar. This is a minimum-risk
patch for 7.3.1 --- I intend to apply a more general repair in HEAD.
Tom Lane [Fri, 22 Nov 2002 16:25:55 +0000 (16:25 +0000)]
Fix a dozen or so places that were passing unpredictable data strings
as elog format strings. Hai-Chen Tu pointed out the problem in
contrib/dbmirror, but it wasn't the only such error.
Tom Lane [Thu, 21 Nov 2002 23:31:37 +0000 (23:31 +0000)]
Fix breakage in new-in-7.3 timetz_zone() function: was giving random
results due to doing arithmetic on uninitialized values. Add some
documentation about the AT TIME ZONE construct. Update some other
date/time documentation that seemed out of date for 7.3.
Tom Lane [Thu, 21 Nov 2002 06:36:27 +0000 (06:36 +0000)]
Code review for superuser_reserved_connections patch. Don't try to do
database access outside a transaction; revert bogus performance improvement
in SIBackendInit(); improve comments; add documentation (this part courtesy
Neil Conway).
Tom Lane [Thu, 21 Nov 2002 04:40:41 +0000 (04:40 +0000)]
NetBSD versions 1.6 and (we hope) later can use the standard geometry
comparison file, instead of geometry-positive-zeros. Per report from
Patrick Welche.
Tom Lane [Tue, 12 Nov 2002 00:39:36 +0000 (00:39 +0000)]
Remove NO_MKTIME_BEFORE_1970. I had speculated that it was not needed
anymore given the mktime() workaround now done in DetermineLocalTimeZone.
This has now been confirmed by Robert Bruccoleri for Irix, and I'm going
to extrapolate to AIX as well.
Bruce Momjian [Fri, 8 Nov 2002 04:57:07 +0000 (04:57 +0000)]
I'm using libpgtcl with PostgreSQL-7.2.3. There is a discrepancy between
the documentation and behavior of "pg_result $res -oid" when $res is not
from an INSERT. The documentation says it should return an empty
string, but in fact it returns 0. I think it used to return an empty
string around PostgreSQL-7.1.3 when PQoidStatus() was used, but now it
uses PQoidValue() which returns InvalidOid, 0 in this case.
Assuming the current behavior is desired, here is a patch to the
documentation doc/src/sgml/libpgtcl.sgml to match what really happens: