jstebbins [Sat, 21 Nov 2009 23:52:50 +0000 (23:52 +0000)]
LinGui: fix problem with loading preset that has deinterlace enabled
setting a radio box to false doesn't automatically set it's
counterpart to true. Must explicitly enable deinterlace when decomb is false
dynaflash [Sat, 21 Nov 2009 17:13:50 +0000 (17:13 +0000)]
MacGui: Trigger "Open Source Title Specific" if the option key is held down when clicking "Open" in the source browse window.
- This has the same effect as choosing Open Source Title Specific from the file menu, which still exists.
jstebbins [Fri, 20 Nov 2009 16:14:07 +0000 (16:14 +0000)]
LinGui: make subtitle burned and default checkboxes mutually exclusive
"default" doesn't really apply to burned in subtitles so it shouldn't
be checked when burned.
dynaflash [Wed, 18 Nov 2009 20:34:05 +0000 (20:34 +0000)]
MacGui: Remove vestigial conditional which did not allow loose anamorphic if the ffmpeg video encoder was used.
- Patch by Rodeo. Thanks Rodeo!
- Addresses http://forum.handbrake.fr/viewtopic.php?f=4&t=13117
dynaflash [Wed, 18 Nov 2009 20:27:18 +0000 (20:27 +0000)]
MacGui: change the min and max bitrate for faac six channel discrete encodes.
- Patch by Rodeo so its his fault. ;)
- Addresses http://forum.handbrake.fr/viewtopic.php?f=4&t=13114
jstebbins [Mon, 16 Nov 2009 19:32:49 +0000 (19:32 +0000)]
a better patch for handling MTR missing menu scenario
The previous method was not very robust and we found corner cases that broke.
This new method explicitly checks for the existance of a menu whenever
the vm attempts to transition to a menu. If there is no menu, it enters
the Exit state.
sr55 [Sat, 14 Nov 2009 18:44:12 +0000 (18:44 +0000)]
WinGui:
- Fixed: Chapter Markers were being disabled for VIDEO_TS directories when the folder above the VIDEO_TS folder was being used as the source path.
jstebbins [Fri, 13 Nov 2009 19:40:58 +0000 (19:40 +0000)]
fix lockup in reader when importing srt's
The subitle id for srt's was not being set. This caused the reader to
mistakenly select the subtitle's fifo when processing audio data and
stuff audio into it, filling it very rapidly. Sync would not
remove items from the subtitle fifo because the corresponding video timestamp
hadn't arrived yet. And since reader was waiting on a full subtitle fifo,
no more video would ever arive at sync.
jstebbins [Fri, 13 Nov 2009 19:02:25 +0000 (19:02 +0000)]
handle duplicate language units and pgc's more gracefully
some discs have large numbers of repeated language units and pgc's that
cause memory consumption and file i/o issues. detect such repeats and
ref-count the data structures to avoid reading and storing duplicate info.
jstebbins [Mon, 9 Nov 2009 18:02:37 +0000 (18:02 +0000)]
fix an off-by-one error in assignment of audio stream registration descriptor
format. This sometimes caused the misdetection of TrueHD audio since it
would be tagged as the format of the stream following it in the PMT.
Also fix a problem in PMT parsing that I stumbled upon while investigating
the above problem. If a PMT has a PID listed more than once for some reason,
we would add that PID multiple times to our stream list. And if it happened
to be a video PID that is duplicated, the duplications would be interpreted
as audio PIDs.
jstebbins [Thu, 5 Nov 2009 22:50:06 +0000 (22:50 +0000)]
possible fix for WDTV vobsub duration problem
There were 2 problems
1. The duration was not being written to the mkv track. Other players use
the timestamps in the vobsub. WDTV appears to use the duration in the mkv.
2. The vobsub timestamps were being rewritten improperly in sync.c. They
don't need to be rewritten at all.
dynaflash [Thu, 5 Nov 2009 21:40:26 +0000 (21:40 +0000)]
MacGui: Make sure that drc is set to 0 by default (not just in the built in presets). Patch by Rodeo.
- Update the queue readout to only display "Off" for drc when the drc is 0.0 instead of 1.0 ( our previous off ).
dynaflash [Mon, 2 Nov 2009 17:35:54 +0000 (17:35 +0000)]
MacGui: Fix the RF and QP labels in the constant quality slider when switching between video encoders. Patch by Rodeo.
- http://forum.handbrake.fr/viewtopic.php?f=4&t=12838
jbrjake [Sat, 31 Oct 2009 15:09:22 +0000 (15:09 +0000)]
Adds a parity parameter to detelecine and rewires it in decomb, so that TFF can be set for non-MPEG-2 sources that don't include parity flags, which will be falsely autodetected as BFF.
jstebbins [Fri, 30 Oct 2009 18:24:29 +0000 (18:24 +0000)]
LinGui: modify toolbar buttons to adapt to new user customizable
toolbar style settings. The new option for customizing this
is available in System->Preferences->Appearance->Interface.
jstebbins [Fri, 23 Oct 2009 02:20:47 +0000 (02:20 +0000)]
fix a couple transport stream issues
when the first packet seen is audio, the stream timing for the audio
must be initialized a little different then when it follows video
add a more thorough check for duplicate packets.
a ts stream that is the result of splicing multiple clips together can
have duplicate continuity count values. usually this means that a duplicate
packet exists and the duplicate is dropped. but in the case of spliced
clips, the packet should not be dropped.
jstebbins [Fri, 23 Oct 2009 00:30:02 +0000 (00:30 +0000)]
fix a couple picture scale issues
adjusting the storage height sometimes got wedged due to incorrect rounding
causing feedback loop.
height change leads to width change, but width rounded too small
width change leads to height change that goes back to original height
presets that had width/height saved (e.g. iPod) were blocking user from
manually selecting a higher resolution.
jstebbins [Wed, 14 Oct 2009 01:04:03 +0000 (01:04 +0000)]
fix reading of short srt subtitle files
if the whole file is consumed before filling the output buffer during
the iconv conversion, the subtitles would be dropped
jstebbins [Mon, 12 Oct 2009 00:54:49 +0000 (00:54 +0000)]
dvdnav: fix crash when poorly masterd disc has no menus
Mac The Ripper, when in "Main Feature Extraction" mode, likes to create
an image with no menus, but leaves navigation commands in place that jump
to the non-existing menu. libdvdnav doesn't like this much.
dynaflash [Fri, 9 Oct 2009 19:34:07 +0000 (19:34 +0000)]
MacGui: In presets with an audio track specified for pass thru ( either AC3 or DTS ) prevent a mixdown in any track besides track one.
- If pass thru is specified in any track > track 1in the preset, set that track to "None" if a matching source codec cannot be found.
- Still allow track 1 to mixdown if a matching source track codec is not present. Prevents accidental encodes with no audio.
- Among other things prevents a duplication of tracks with an aac mixdown for the AppleTV preset when using a source with audio other than AC3.
jstebbins [Tue, 6 Oct 2009 15:46:35 +0000 (15:46 +0000)]
LinGui: allow display of picture settings before a scan has been done
preview window is still blocked, but picture settings can be viewed and
modified for the purpose of setting up a preset.
jstebbins [Tue, 6 Oct 2009 01:25:46 +0000 (01:25 +0000)]
fix VC1 I-frame detection in ffmpeg_is_keyframe
The pattern was incorrect, so we were pretty much always starting on a
non-I-frame when creating previews from VC1 ffmpeg sources. This fixes
the grey preview complaints several users have had.
jstebbins [Sun, 4 Oct 2009 17:05:53 +0000 (17:05 +0000)]
LinGui: modify the interaction between preview window and settings window
make hiding the settings window from the preview "settings" button
a separate state from the settings button in the main window. The "hidden"
status persists when you toggle the settings button in the main window.
jstebbins [Sat, 3 Oct 2009 16:51:58 +0000 (16:51 +0000)]
fix reading of UTF-16 SRT subtitle files (and other wide charsets)
The entire file is encoded in the chosen charset, not just the subtitle text.
So we must read and convert the text prior to any parsing. Using fgets() to
read a line doesn't work because wide charsets can have 0x0a in the high byte
of some char.
jstebbins [Sat, 3 Oct 2009 16:47:09 +0000 (16:47 +0000)]
LinGui: fix a couple subtitle UI issues
- SRT filename was getting lost when moving the subtitle highlight around
- SRT subtitles didn't get reloaded properly when editing a queue item
projects / handbrake / log