]> granicus.if.org Git - postgresql/log
postgresql
18 years agoAdd:
Bruce Momjian [Fri, 25 Aug 2006 23:43:46 +0000 (23:43 +0000)]
Add:

<
> * Implement SQL:2003 window functions

18 years agoAdd 'feedback' section heading to xml2.
Bruce Momjian [Fri, 25 Aug 2006 23:43:11 +0000 (23:43 +0000)]
Add 'feedback' section heading to xml2.

18 years agoFix regression tests: after changing comparing function
Teodor Sigaev [Fri, 25 Aug 2006 07:39:08 +0000 (07:39 +0000)]
Fix regression tests: after changing comparing function
order is changed.

18 years agoAdd the ability to create indexes 'concurrently', that is, without
Tom Lane [Fri, 25 Aug 2006 04:06:58 +0000 (04:06 +0000)]
Add the ability to create indexes 'concurrently', that is, without
blocking concurrent writes to the table.  Greg Stark, with a little help
from Tom Lane.

18 years agoFix compare bug for tsvector: problem was in aligment. Per Stefan Kaltenbrunner ...
Teodor Sigaev [Thu, 24 Aug 2006 17:37:34 +0000 (17:37 +0000)]
Fix compare bug for tsvector: problem was in aligment. Per Stefan Kaltenbrunner <stefan@kaltenbrunner.cc> and Phil Frost <indigo@bitglue.com>

18 years agoAdd:
Bruce Momjian [Thu, 24 Aug 2006 16:38:13 +0000 (16:38 +0000)]
Add:

> * Allow inlining of set-returning functions

18 years agoSynced parser
Michael Meskes [Thu, 24 Aug 2006 12:31:33 +0000 (12:31 +0000)]
Synced parser

18 years agoNeeded more stuff from c.h.
Michael Meskes [Thu, 24 Aug 2006 10:48:21 +0000 (10:48 +0000)]
Needed more stuff from c.h.

18 years agoFixed of by one variable size.
Michael Meskes [Thu, 24 Aug 2006 10:35:58 +0000 (10:35 +0000)]
Fixed of by one variable size.

18 years agoNeed more defines in ecpg_config.h, patch sent by Rocco Altier <RoccoA@Routescape...
Michael Meskes [Thu, 24 Aug 2006 09:37:07 +0000 (09:37 +0000)]
Need more defines in ecpg_config.h, patch sent by Rocco Altier <RoccoA@Routescape.com>

18 years agoAdd some debug logging code to AllocateFile's failure path to log the
Tom Lane [Thu, 24 Aug 2006 03:15:43 +0000 (03:15 +0000)]
Add some debug logging code to AllocateFile's failure path to log the
specific Windows error code (GetLastError).  This is a hopefully temporary
hack to try to diagnose rare failures.  Magnus Hagander

18 years agoUpdate XML2 documentation for xpath_table().
Bruce Momjian [Thu, 24 Aug 2006 01:41:06 +0000 (01:41 +0000)]
Update XML2 documentation for xpath_table().

John Gray

18 years agoOptimize the case where a btree indexscan has current and mark positions
Tom Lane [Thu, 24 Aug 2006 01:18:34 +0000 (01:18 +0000)]
Optimize the case where a btree indexscan has current and mark positions
on the same index page; we can avoid data copying as well as buffer refcount
manipulations in this common case.  Makes for a small but noticeable
improvement in mergejoin speed.

Heikki Linnakangas

18 years agoAdd "AS" item:
Bruce Momjian [Wed, 23 Aug 2006 18:32:02 +0000 (18:32 +0000)]
Add "AS" item:

< * All backends running as threads in a single process (not want)
> * All backends running as threads in a single process (not wanted)
< * Optimizer hints (not want)
> * Optimizer hints (not wanted)
>
> * Allow AS in "SELECT col AS label" to be optional (not wanted)
>
>   Because we support postfix operators, it isn't possible to make AS
>   optional and continue to use bison.
>   http://archives.postgresql.org/pgsql-sql/2006-08/msg00164.php

18 years agoSomehow my version compiled but the change didn't make it to CVS.
Michael Meskes [Wed, 23 Aug 2006 13:57:27 +0000 (13:57 +0000)]
Somehow my version compiled but the change didn't make it to CVS.

18 years agoUsed autoconf 2.59 this time.
Michael Meskes [Wed, 23 Aug 2006 12:59:18 +0000 (12:59 +0000)]
Used autoconf 2.59 this time.

18 years agoArgh, forgot the new file yet again.
Michael Meskes [Wed, 23 Aug 2006 12:51:26 +0000 (12:51 +0000)]
Argh, forgot the new file yet again.

18 years agoReplaced double-quote-fix with a hopefully better version.
Michael Meskes [Wed, 23 Aug 2006 12:01:53 +0000 (12:01 +0000)]
Replaced double-quote-fix with a hopefully better version.
Use initializer string length as size for character strings.
Added ecpg_config.h file that is created via configure.

18 years agoUpdate COPY/VIEW item:
Bruce Momjian [Wed, 23 Aug 2006 02:48:12 +0000 (02:48 +0000)]
Update COPY/VIEW item:

<  o Allow COPY to output from SELECT
>  o Allow COPY (SELECT ...) TO 'filename'
<    COPY should also be able to output views.
>    COPY should also be able to output views using COPY (SELECT
>    * FROM view) TO 'filename' internally.

18 years agoDescriptor values were quoted twice.
Michael Meskes [Tue, 22 Aug 2006 12:46:18 +0000 (12:46 +0000)]
Descriptor values were quoted twice.
Fixed some regression test problems.

18 years agoIn new "invalid byte sequence" error hint, call it "error", not
Bruce Momjian [Tue, 22 Aug 2006 12:11:28 +0000 (12:11 +0000)]
In new "invalid byte sequence" error hint, call it "error", not
"failure".

18 years agoAdd info for get_* functions:
Bruce Momjian [Tue, 22 Aug 2006 03:40:39 +0000 (03:40 +0000)]
Add info for get_* functions:

>
>   These would be for application use, not for use by pg_dump.
>

18 years agoAdd hint for "invalid byte sequence for encoding" error message,
Bruce Momjian [Tue, 22 Aug 2006 03:30:20 +0000 (03:30 +0000)]
Add hint for "invalid byte sequence for encoding" error message,
suggesting review of client_encoding.

18 years agoOoops, ldap fix for win32 broke the non-win32 case.
Tom Lane [Tue, 22 Aug 2006 02:23:45 +0000 (02:23 +0000)]
Ooops, ldap fix for win32 broke the non-win32 case.

18 years agoGeneralize width_bucket() documentation because b1/b2 can be
Bruce Momjian [Tue, 22 Aug 2006 00:49:19 +0000 (00:49 +0000)]
Generalize width_bucket() documentation because b1/b2 can be
interchanged.

18 years agoAdd space between Win2000 and SP4.
Bruce Momjian [Tue, 22 Aug 2006 00:45:34 +0000 (00:45 +0000)]
Add space between Win2000 and SP4.

18 years agoFix encrypted-LDAP support so that it doesn't cause the server to fail
Tom Lane [Mon, 21 Aug 2006 19:21:38 +0000 (19:21 +0000)]
Fix encrypted-LDAP support so that it doesn't cause the server to fail
entirely on older Windows platforms without the needed library function.
Magnus Hagander

18 years agoMinor code rearrangement to save a few cycles in RI_FKey_check when
Tom Lane [Mon, 21 Aug 2006 19:15:29 +0000 (19:15 +0000)]
Minor code rearrangement to save a few cycles in RI_FKey_check when
the subject tuple is already deleted: we need not open the pk_rel
until after we check that.

18 years agoRemove obsolete tip about casting bool to int, per Taiki Yamaguchi.
Tom Lane [Mon, 21 Aug 2006 16:23:46 +0000 (16:23 +0000)]
Remove obsolete tip about casting bool to int, per Taiki Yamaguchi.

18 years agoMake the server track an 'XID epoch', that is, maintain higher-order bits
Tom Lane [Mon, 21 Aug 2006 16:16:31 +0000 (16:16 +0000)]
Make the server track an 'XID epoch', that is, maintain higher-order bits
of the transaction ID counter.  Nothing is done with the epoch except to
store it in checkpoint records, but this provides a foundation with which
add-on code can pretend that XIDs never wrap around.  This is a severely
trimmed and rewritten version of the xxid patch submitted by Marko Kreen.
Per discussion, the epoch counter seems the only part of xxid that really
needs to be in the core server.

18 years agoDone:
Bruce Momjian [Mon, 21 Aug 2006 12:50:29 +0000 (12:50 +0000)]
Done:

<  o Add a function to support Parse/DescribeStatement capability
>  o -Add a function to support Parse/DescribeStatement capability

18 years agoRemove items, not needed anymore:
Bruce Momjian [Mon, 21 Aug 2006 12:20:26 +0000 (12:20 +0000)]
Remove items, not needed anymore:

< * %Disallow changing DEFAULT expression of a SERIAL column?
<
<   This should be done only if the existing SERIAL problems cannot be
<   fixed.
<
< * %Disallow ALTER SEQUENCE changes for SERIAL sequences because pg_dump
<   does not dump the changes

18 years agoFixed a few memory leaks. One indeed was part of a loop.
Michael Meskes [Mon, 21 Aug 2006 10:48:21 +0000 (10:48 +0000)]
Fixed a few memory leaks. One indeed was part of a loop.

18 years agoFix all known problems with pg_dump's handling of serial sequences
Tom Lane [Mon, 21 Aug 2006 00:57:26 +0000 (00:57 +0000)]
Fix all known problems with pg_dump's handling of serial sequences
by abandoning the idea that it should say SERIAL in the dump.  Instead,
dump serial sequences and column defaults just like regular ones.
Add a new backend command ALTER SEQUENCE OWNED BY to let pg_dump recreate
the sequence-to-column dependency that was formerly created "behind the
scenes" by SERIAL.  This restores SERIAL to being truly "just a macro"
consisting of component operations that can be stated explicitly in SQL.
Furthermore, the new command allows sequence ownership to be reassigned,
so that old mistakes can be cleaned up.

Also, downgrade the OWNED-BY dependency from INTERNAL to AUTO, since there
is no longer any very compelling argument why the sequence couldn't be
dropped while keeping the column.  (This forces initdb, to be sure the
right kinds of dependencies are in there.)

Along the way, add checks to prevent ALTER OWNER or SET SCHEMA on an
owned sequence; you can now only do this indirectly by changing the
owning table's owner or schema.  This is an oversight in previous
releases, but probably not worth back-patching.

18 years agoFix DROP OWNED BY to correctly consider the implicitly-deleted objects list for
Alvaro Herrera [Sun, 20 Aug 2006 21:56:16 +0000 (21:56 +0000)]
Fix DROP OWNED BY to correctly consider the implicitly-deleted objects list for
each object to be deleted, instead of the previous hack that just skipped
INTERNAL dependencies, which didn't really work.  Per report from Tom Lane.

To do this, introduce a new performMultipleDeletions entry point in
dependency.c to delete multiple objects at once.  The dependency code then has
the responsability of tracking INTERNAL and AUTO dependencies as needed.

Along the way, change ObjectAddresses so that we can allocate an ObjectAddress
list from outside dependency.c and not have to export the internal
representation.

18 years agoFixed a few trivial memory leaks reported by Coverity just to test my setup.
Michael Meskes [Sun, 20 Aug 2006 16:08:09 +0000 (16:08 +0000)]
Fixed a few trivial memory leaks reported by Coverity just to test my setup.

18 years agoAdded another test
Michael Meskes [Sat, 19 Aug 2006 15:10:00 +0000 (15:10 +0000)]
Added another test

18 years agoMore SoC stuff
Michael Meskes [Sat, 19 Aug 2006 13:42:40 +0000 (13:42 +0000)]
More SoC stuff

18 years agoSuppress subquery pullup/pushdown when a subquery contains volatile
Tom Lane [Sat, 19 Aug 2006 02:48:53 +0000 (02:48 +0000)]
Suppress subquery pullup/pushdown when a subquery contains volatile
functions in its targetlist, to avoid introducing multiple evaluations
of volatile functions that textually appear only once.  This is a
slightly tighter version of Jaime Casanova's recent patch.

18 years agoAdd a 'waiting' column to pg_stat_activity to carry the same information
Tom Lane [Sat, 19 Aug 2006 01:36:34 +0000 (01:36 +0000)]
Add a 'waiting' column to pg_stat_activity to carry the same information
that ps_status provides by appending 'waiting' to the PS display.  This
completes the project of making it feasible to turn off process title
updates and instead rely on pg_stat_activity.  Per my suggestion a few
weeks ago.

18 years agoAdd installcheck-parallel target to top level makefiles.
Andrew Dunstan [Fri, 18 Aug 2006 19:58:05 +0000 (19:58 +0000)]
Add installcheck-parallel target to top level makefiles.

18 years agoAdd PQdescribePrepared, PQdescribePortal, and related functions to libpq
Tom Lane [Fri, 18 Aug 2006 19:52:39 +0000 (19:52 +0000)]
Add PQdescribePrepared, PQdescribePortal, and related functions to libpq
to allow obtaining information about previously prepared statements and
open cursors.  Volkan Yazici

18 years agoFixed a buffer overrun that was masked on Linux systems.
Michael Meskes [Fri, 18 Aug 2006 16:30:53 +0000 (16:30 +0000)]
Fixed a buffer overrun that was masked on Linux systems.

18 years agoAdd space before SP4.
Bruce Momjian [Fri, 18 Aug 2006 16:27:40 +0000 (16:27 +0000)]
Add space before SP4.

18 years agoUpdate Win2000SP4 mention.
Bruce Momjian [Fri, 18 Aug 2006 16:26:59 +0000 (16:26 +0000)]
Update Win2000SP4 mention.

18 years agoNow that we've rearranged relation open to get a lock before touching
Tom Lane [Fri, 18 Aug 2006 16:09:13 +0000 (16:09 +0000)]
Now that we've rearranged relation open to get a lock before touching
the rel, it's easy to get rid of the narrow race-condition window that
used to exist in VACUUM and CLUSTER.  Did some minor code-beautification
work in the same area, too.

18 years agoChanged lexer to no longer use the default rule.
Michael Meskes [Fri, 18 Aug 2006 15:59:35 +0000 (15:59 +0000)]
Changed lexer to no longer use the default rule.
Synced parser and keyword list.
Fixed parsing of CONNECT statement so it accepts a C string again.

18 years agoMention only Windows 2000SP4 works.
Bruce Momjian [Fri, 18 Aug 2006 15:51:28 +0000 (15:51 +0000)]
Mention only Windows 2000SP4 works.

18 years agoUpdate Win32 CMD quoting rules information location, CMD /?, from
Bruce Momjian [Fri, 18 Aug 2006 15:47:08 +0000 (15:47 +0000)]
Update Win32 CMD quoting rules information location, CMD /?, from
Magnus.

18 years agoImplement archive_timeout feature to force xlog file switches to occur no more
Tom Lane [Thu, 17 Aug 2006 23:04:10 +0000 (23:04 +0000)]
Implement archive_timeout feature to force xlog file switches to occur no more
than N seconds apart.  This allows a simple, if not very high performance,
means of guaranteeing that a PITR archive is no more than N seconds behind
real time.  Also make pg_current_xlog_location return the WAL Write pointer,
add pg_current_xlog_insert_location to return the Insert pointer, and fix
pg_xlogfile_name_offset to return its results as a two-element record instead
of a smashed-together string, as per recent discussion.

Simon Riggs

18 years agoProduce a clean failure in configure when dtrace is selected but cannot be
Peter Eisentraut [Thu, 17 Aug 2006 17:25:43 +0000 (17:25 +0000)]
Produce a clean failure in configure when dtrace is selected but cannot be
found.  Besides stopping those early who have no dtrace installed
whatsoever, this will also alert those who have dtrace in /usr/sbin, which
might not be in the path, which would produce confusing failures much later
in the build process.

Add documentation about pointing configure to find dtrace.

18 years agoFix an oversight in mergejoin planning: the planner would reject a
Tom Lane [Thu, 17 Aug 2006 17:06:37 +0000 (17:06 +0000)]
Fix an oversight in mergejoin planning: the planner would reject a
mergejoin possibility where the inner rel was less well sorted than
the outer (ie, it matches some but not all of the merge clauses that
can work with the outer), if the inner path in question is also the
overall cheapest path for its rel.  This is an old bug, but I'm not
sure it's worth back-patching, because it's such a corner case.
Noted while investigating a test case from Peter Hardman.

18 years agoTeach convert_subquery_pathkeys() to handle the case where the
Tom Lane [Thu, 17 Aug 2006 17:02:49 +0000 (17:02 +0000)]
Teach convert_subquery_pathkeys() to handle the case where the
subquery's pathkey is a RelabelType applied to something that appears
in the subquery's output; for example where the subquery returns a
varchar Var and the sort order is shown as that Var coerced to text.
This comes up because varchar doesn't have its own sort operator.
Per example from Peter Hardman.

18 years agoAdd:
Bruce Momjian [Thu, 17 Aug 2006 06:48:38 +0000 (06:48 +0000)]
Add:

< * Add support for arrays of domains
>  o Add support for arrays of domains
>  o Add support for arrays of complex types

18 years agoAdd:
Bruce Momjian [Thu, 17 Aug 2006 06:45:12 +0000 (06:45 +0000)]
Add:

> * Support a data type with specific enumerated values (ENUM)
>
>   http://archives.postgresql.org/pgsql-hackers/2006-08/msg00979.php

18 years agoAdd:
Bruce Momjian [Wed, 16 Aug 2006 14:59:26 +0000 (14:59 +0000)]
Add:

> * Add support for arrays of domains

18 years agoPut probes.o file in right directory, fixes dtrace compilation
Peter Eisentraut [Wed, 16 Aug 2006 14:57:37 +0000 (14:57 +0000)]
Put probes.o file in right directory, fixes dtrace compilation

18 years agoSeems some C compilers think 'restrict' is a fully reserved word.
Tom Lane [Wed, 16 Aug 2006 04:32:49 +0000 (04:32 +0000)]
Seems some C compilers think 'restrict' is a fully reserved word.
Per buildfarm results from warthog.

18 years agoAdd a hack so that get_type_io_data() can work from bootstrap.c's
Tom Lane [Tue, 15 Aug 2006 22:36:17 +0000 (22:36 +0000)]
Add a hack so that get_type_io_data() can work from bootstrap.c's
internal TypInfo table in bootstrap mode.  This allows array_in and
array_out to be used during early bootstrap, which eliminates the
former obstacle to giving OUT parameters to built-in functions.

18 years agoAdd hooks to allow debugging and performance measurement plugins
Tom Lane [Tue, 15 Aug 2006 19:01:17 +0000 (19:01 +0000)]
Add hooks to allow debugging and performance measurement plugins
to instrument PL/pgSQL.  Korry Douglas

18 years agoAdd server support for "plugin" libraries that can be used for add-on tasks
Tom Lane [Tue, 15 Aug 2006 18:26:59 +0000 (18:26 +0000)]
Add server support for "plugin" libraries that can be used for add-on tasks
such as debugging and performance measurement.  This consists of two features:
a table of "rendezvous variables" that allows separately-loaded shared
libraries to communicate, and a new GUC setting "local_preload_libraries"
that allows libraries to be loaded into specific sessions without explicit
cooperation from the client application.  To make local_preload_libraries
as flexible as possible, we do not restrict its use to superusers; instead,
it is restricted to load only libraries stored in $libdir/plugins/.  The
existing LOAD command has also been modified to allow non-superusers to
LOAD libraries stored in this directory.

This patch also renames the existing GUC variable preload_libraries to
shared_preload_libraries (after a suggestion by Simon Riggs) and does some
code refactoring in dfmgr.c to improve clarity.

Korry Douglas, with a little help from Tom Lane.

18 years agoFix pgbench to handle empty lines in script files as documented.
Tatsuo Ishii [Tue, 15 Aug 2006 13:05:30 +0000 (13:05 +0000)]
Fix pgbench to handle empty lines in script files as documented.
patches contributed by Itagaki Takahiro.

18 years agoFixed a typo and made two mallocs Coverity friendly.
Michael Meskes [Tue, 15 Aug 2006 12:46:25 +0000 (12:46 +0000)]
Fixed a typo and made two mallocs Coverity friendly.

18 years agoSorry, forgot the new files.
Michael Meskes [Tue, 15 Aug 2006 06:48:24 +0000 (06:48 +0000)]
Sorry, forgot the new files.

18 years agoAdded lots of SoC stuff made by Joachim.
Michael Meskes [Tue, 15 Aug 2006 06:40:20 +0000 (06:40 +0000)]
Added lots of SoC stuff made by Joachim.
Fixed broken newline on Windows.
Fixed a nasty buffer underrun that only occured when using Informix
no_indicator NULL setting on timestamps and intervals.

18 years agoCause '*' and 'foo.*' notations to mark the referenced RTE(s) as
Tom Lane [Mon, 14 Aug 2006 23:39:32 +0000 (23:39 +0000)]
Cause '*' and 'foo.*' notations to mark the referenced RTE(s) as
requiring read permissions.  Up till now there was no possible case
in which the RTEs wouldn't already have ACL_SELECT set ... but now that
you can say something like 'INSERT INTO foo ... RETURNING *' this is
an essential step.  With this commit, a RETURNING clause adds the
requirement for SELECT permissions on the target table if and only if
the clause actually reads the value of at least one target-table column.

18 years agoFix oversight in initial implementation of PORTAL_ONE_RETURNING mode: we
Tom Lane [Mon, 14 Aug 2006 22:57:15 +0000 (22:57 +0000)]
Fix oversight in initial implementation of PORTAL_ONE_RETURNING mode: we
cannot assume that there's exactly one Query in the Portal, as we can for
ONE_SELECT mode, because non-SELECT queries might have extra queries added
during rule rewrites.  Fix things up so that we'll use ONE_RETURNING mode
when a Portal contains one primary (canSetTag) query and that query has
a RETURNING list.  This appears to be a second showstopper reason for running
the Portal to completion before we start to hand anything back --- we want
to be sure that the rule-added queries get run too.

18 years agoSupport INSERT/UPDATE/DELETE RETURNING in plpgsql, with rowcount checking
Tom Lane [Mon, 14 Aug 2006 21:14:42 +0000 (21:14 +0000)]
Support INSERT/UPDATE/DELETE RETURNING in plpgsql, with rowcount checking
as per yesterday's proposal.  Also make things a tad more orthogonal by
adding the recent STRICT addition to EXECUTE INTO.
Jonah Harris and Tom Lane

18 years agoWhen executing a list of queries derived from rule expansion,
Tom Lane [Mon, 14 Aug 2006 13:40:18 +0000 (13:40 +0000)]
When executing a list of queries derived from rule expansion,
_SPI_execute_plan's return code should reflect the type of the query
that is marked canSetTag, not necessarily the last one in the list.

This is arguably a bug fix, but I'm hesitant to back-patch it because
it's the sort of subtle change that might break someone's code, and it's
best not to do that kind of thing in point releases.

18 years agoRemove hash_destroy calls in hash_create's failure paths. As noted by
Tom Lane [Mon, 14 Aug 2006 12:39:55 +0000 (12:39 +0000)]
Remove hash_destroy calls in hash_create's failure paths.  As noted by
a Coverity warning, these are risky since the hashtable isn't necessarily
fully set up yet.  They're unnecessary anyway: a deletable hashtable
should be in a memory context that will be cleared following elog(ERROR).
Per report from Martijn van Oosterhout.

18 years agoRevert (again) GUC patch to return commented fields to their default
Bruce Momjian [Mon, 14 Aug 2006 02:27:27 +0000 (02:27 +0000)]
Revert (again) GUC patch to return commented fields to their default
values, due to concern about the patch.

18 years agoGet rid of "lookahead" functionality in plpgsql's yylex() function,
Tom Lane [Mon, 14 Aug 2006 00:46:53 +0000 (00:46 +0000)]
Get rid of "lookahead" functionality in plpgsql's yylex() function,
and instead make the grammar production for the RETURN statement do the
heavy lifting.  The lookahead idea was copied from the main parser, but
it does not work in plpgsql's parser because here gram.y looks explicitly
at the scanner's yytext variable, which will be out of sync after a
failed lookahead step.  A minimal example is

create or replace function foo() returns void language plpgsql as '
begin
  perform return foo bar;
end';

which can be seen by testing to deliver "foo foo bar" to the main parser
instead of the expected "return foo bar".  This isn't a huge bug since
RETURN is not found in the main grammar, but it could bite someone who
tried to use "return" as an identifier.

Back-patch to 8.1.  Bug exists further back, but HEAD patch doesn't apply
cleanly, and given the lack of field complaints it doesn't seem worth
the effort to develop adjusted patches.

18 years agoFix core dump in duration logging for a V3-protocol Execute message
Tom Lane [Sun, 13 Aug 2006 22:18:08 +0000 (22:18 +0000)]
Fix core dump in duration logging for a V3-protocol Execute message
when what's being executed is a COMMIT or ROLLBACK.  Per report from
Sergey Koposov.  Backpatch to 8.1; 8.0 and before don't have the bug
due to lack of any logging at all here.

18 years agoCause psql to report both the returned data and the command status tag
Tom Lane [Sun, 13 Aug 2006 21:10:04 +0000 (21:10 +0000)]
Cause psql to report both the returned data and the command status tag
for INSERT/UPDATE/DELETE RETURNING.  Per discussion.

18 years agoIf test postmaster fails to start within 60 seconds, try to kill -9 it
Tom Lane [Sun, 13 Aug 2006 20:39:07 +0000 (20:39 +0000)]
If test postmaster fails to start within 60 seconds, try to kill -9 it
so that it won't interfere with later trials.  Per recent buildfarm
experience.  Anyone know how to do this on Windows?

18 years agoExtend 'guc' regression test to check manipulations of datestyle as
Tom Lane [Sun, 13 Aug 2006 19:31:06 +0000 (19:31 +0000)]
Extend 'guc' regression test to check manipulations of datestyle as
well as vacuum_cost_delay.  Since datestyle is a string variable,
this exercises memory allocation issues that might not appear when
modifying an integer GUC variable.  Also, we can observe the side
effects of changing datestyle to check that assign hooks are called
at the right times.

18 years agoOriginal coding of 'returning' regression test inadvertently chose a
Tom Lane [Sun, 13 Aug 2006 17:58:49 +0000 (17:58 +0000)]
Original coding of 'returning' regression test inadvertently chose a
nonunique join value, leading to plan-choice-dependent results ... and
it seems some platforms will choose a different plan.  Tweak the test
so that it has well-defined results.  Per report from Olivier Prenant.

18 years agoBack out plperl OUT hash/array parameter patch, again.
Bruce Momjian [Sun, 13 Aug 2006 17:31:10 +0000 (17:31 +0000)]
Back out plperl OUT hash/array parameter patch, again.

18 years agoFix recent guc comment-to-default patch for custom variables.
Bruce Momjian [Sun, 13 Aug 2006 15:37:02 +0000 (15:37 +0000)]
Fix recent guc comment-to-default patch for custom variables.

18 years agoApplied patch for VPATH builds by Alvaro Herrera <alvherre@commandprompt.com>
Michael Meskes [Sun, 13 Aug 2006 10:18:31 +0000 (10:18 +0000)]
Applied patch for VPATH builds by Alvaro Herrera <alvherre@commandprompt.com>
Merged dyntest.pgc and dyntest2.pgc.
Hopefully fixed the last Coverity reports (finally)

18 years agoRe-apply plperl patch that allows OUT parameters to be placed into Perl
Bruce Momjian [Sun, 13 Aug 2006 02:37:11 +0000 (02:37 +0000)]
Re-apply plperl patch that allows OUT parameters to be placed into Perl
hash and array variables.  (regression output updated)

18 years agoRecommit patch to allow commented GUC variables to return to their
Bruce Momjian [Sun, 13 Aug 2006 02:22:24 +0000 (02:22 +0000)]
Recommit patch to allow commented GUC variables to return to their
default values.

18 years agoRe-apply guc cleanup patch, with memory allocation bugs fixed.
Bruce Momjian [Sun, 13 Aug 2006 01:30:17 +0000 (01:30 +0000)]
Re-apply guc cleanup patch, with memory allocation bugs fixed.

18 years agoTweak SPI_cursor_open to allow INSERT/UPDATE/DELETE RETURNING; this was
Tom Lane [Sat, 12 Aug 2006 20:05:56 +0000 (20:05 +0000)]
Tweak SPI_cursor_open to allow INSERT/UPDATE/DELETE RETURNING; this was
merely a matter of fixing the error check, since the underlying Portal
infrastructure already handles it.  This in turn allows these statements
to be used in some existing plpgsql and plperl contexts, such as a
plpgsql FOR loop.  Also, do some marginal code cleanup in places that
were being sloppy about distinguishing SELECT from SELECT INTO.

18 years agoRemove ancient, obsolete comment.
Tom Lane [Sat, 12 Aug 2006 18:58:54 +0000 (18:58 +0000)]
Remove ancient, obsolete comment.

18 years agoBack out patch for plperl to handle OUT paramaters into arrays and
Bruce Momjian [Sat, 12 Aug 2006 04:16:45 +0000 (04:16 +0000)]
Back out patch for plperl to handle OUT paramaters into arrays and
hashes.  Was causing regression failures.

18 years agoBack out patch to reorganize guc processing. Was causing regression
Bruce Momjian [Sat, 12 Aug 2006 04:12:41 +0000 (04:12 +0000)]
Back out patch to reorganize guc processing.  Was causing regression
failures.

18 years agoBack out patch that allowed commented guc variables to return to their
Bruce Momjian [Sat, 12 Aug 2006 04:11:50 +0000 (04:11 +0000)]
Back out patch that allowed commented guc variables to return to their
default values.  Was causing regression failures.

18 years agoDone:
Bruce Momjian [Sat, 12 Aug 2006 03:50:27 +0000 (03:50 +0000)]
Done:

<  o Allow INSERT/UPDATE ... RETURNING new.col or old.col
<
<    This is useful for returning the auto-generated key for an INSERT.
<    One complication is how to handle rules that run as part of
<    the insert.
<    http://archives.postgresql.org/pgsql-patches/2005-07/msg00568.php
>  o -Allow INSERT/UPDATE ... RETURNING new.col or old.col

18 years agoFix wording, per Neil.
Bruce Momjian [Sat, 12 Aug 2006 03:48:32 +0000 (03:48 +0000)]
Fix wording, per Neil.

18 years agoAdd INSERT/UPDATE/DELETE RETURNING, with basic docs and regression tests.
Tom Lane [Sat, 12 Aug 2006 02:52:06 +0000 (02:52 +0000)]
Add INSERT/UPDATE/DELETE RETURNING, with basic docs and regression tests.
plpgsql support to come later.  Along the way, convert execMain's
SELECT INTO support into a DestReceiver, in order to eliminate some ugly
special cases.

Jonah Harris and Tom Lane

18 years agoSet Win32 server-size socket buffer to 32k, for performance reasons.
Bruce Momjian [Fri, 11 Aug 2006 20:44:20 +0000 (20:44 +0000)]
Set Win32 server-size socket buffer to 32k, for performance reasons.

Yoshiyuki Asaba

18 years agoDone:
Bruce Momjian [Fri, 11 Aug 2006 20:17:26 +0000 (20:17 +0000)]
Done:

<  o %Allow commenting of variables in postgresql.conf to restore them
>  o -Allow commenting of variables in postgresql.conf to restore them

18 years agoRevert undesired FAQ_DEV change.
Bruce Momjian [Fri, 11 Aug 2006 20:16:50 +0000 (20:16 +0000)]
Revert undesired  FAQ_DEV change.

18 years agoAllow commenting of variables in postgresql.conf to restore them to
Bruce Momjian [Fri, 11 Aug 2006 20:15:16 +0000 (20:15 +0000)]
Allow commenting of variables in postgresql.conf to restore them to
defaults.

Zdenek Kotala

18 years agoRefactor GUC set_config_option function:
Bruce Momjian [Fri, 11 Aug 2006 20:08:28 +0000 (20:08 +0000)]
Refactor GUC set_config_option function:

The main reason for refactoring was that set_config_option() was too
overloaded function and its behavior did not consistent. Old version of
set_config_function hides some messages. For example if you type:

tcp_port = 5432.1

then old implementation ignore this error without any message to log
file in the signal context (configuration reload). Main problem was that
semantic analysis of postgresql.conf is not perform in the
ProcessConfigFile function, but in the set_config_options *after*
context check. This skipped check for variables with PG_POSTMASTER
context. There was request from Joachim Wieland to add more messages
about ignored changes in the config file as well.

Zdenek Kotala

18 years agoplperl:
Bruce Momjian [Fri, 11 Aug 2006 19:42:35 +0000 (19:42 +0000)]
plperl:

Allow conversion from perl to postgresql array in OUT parameters. Second,
allow hash form output from procedures with one OUT argument.

Pavel Stehule

18 years agoMake the psql line counter 64-bit so it can handle files > 4gig lines.
Bruce Momjian [Fri, 11 Aug 2006 19:20:59 +0000 (19:20 +0000)]
Make the psql line counter 64-bit so it can handle files > 4gig lines.

David Fetter

18 years agoAdd Neil's presentation to FAQ_DEV.
Bruce Momjian [Fri, 11 Aug 2006 19:18:59 +0000 (19:18 +0000)]
Add Neil's presentation to FAQ_DEV.

18 years agoFix typo.
Alvaro Herrera [Fri, 11 Aug 2006 18:51:50 +0000 (18:51 +0000)]
Fix typo.